- tbb-commits - lists.torproject.org

[torbutton/maint-1.9.5] Bug 19417: Clear asmjscache
by gk＠torproject.org 17 Jun '16

17 Jun '16

commit ecc71020f6e3e6db5a2e8dc87af354cf2c86733b Author: Georg Koppen <gk(a)torproject.org> Date: Fri Jun 17 09:49:16 2016 +0000 Bug 19417: Clear asmjscache This patch clears the asmjscache (and the IndexedDB storage) on New Identity and during start-up. The latter is a suboptimal workaround we deploy until the asmjscache is Private Browsing Mode aware. InedxedDB storage is not so urgent as IndexedDB is not working in Private Browsing Mode anyway. --- src/chrome/content/torbutton.js | 33 +++++++++++++++++++++++++++++++++ 1 file changed, 33 insertions(+) diff --git a/src/chrome/content/torbutton.js b/src/chrome/content/torbutton.js index a293c44..539bd88 100644 --- a/src/chrome/content/torbutton.js +++ b/src/chrome/content/torbutton.js @@ -578,6 +578,23 @@ function torbutton_init() { torbutton_update_security_slider(); } + // XXX: Get rid of the cached asmjs (or IndexedDB) files on disk in case we + // don't allow things saved to disk. This is an ad-hoc fix to work around + // #19417. Once this is properly solved we should remove this code again. + if (m_tb_prefs.getBoolPref("extensions.torbutton.block_disk")) { + let orig_quota_test = m_tb_prefs.getBoolPref("dom.quotaManager.testing"); + try { + // This works only by setting the pref to `true` otherwise we get an + // exception and nothing is happening. + m_tb_prefs.setBoolPref("dom.quotaManager.testing", true); + Cc["@mozilla.org/dom/quota-manager-service;1"] + .getService(Ci.nsIQuotaManagerService).clear(); + } catch(e) { + } finally { + m_tb_prefs.setBoolPref("dom.quotaManager.testing", orig_quota_test); + } + } + // set panel style from preferences torbutton_set_panel_style(); @@ -1677,6 +1694,7 @@ function torbutton_new_identity() { * h. last open location url * i. clear content prefs * j. permissions + * k. IndexedDB and asmjscache storage * 3. Sends tor the NEWNYM signal to get a new circuit * 4. Opens a new window with the default homepage * 5. Closes this window @@ -1824,6 +1842,21 @@ function torbutton_do_new_identity() { window.alert("Torbutton: Unexpected error during cache clearing: "+e); } + torbutton_log(3, "New Identity: Clearing storage"); + + let orig_quota_test = m_tb_prefs.getBoolPref("dom.quotaManager.testing"); + try { + // This works only by setting the pref to `true` otherwise we get an + // exception and nothing is happening. + m_tb_prefs.setBoolPref("dom.quotaManager.testing", true); + Cc["@mozilla.org/dom/quota-manager-service;1"] + .getService(Ci.nsIQuotaManagerService).clear(); + } catch(e) { + torbutton_log(5, "Exception on storage clearing: "+e); + } finally { + m_tb_prefs.setBoolPref("dom.quotaManager.testing", orig_quota_test); + } + torbutton_log(3, "New Identity: Clearing Cookies and DOM Storage"); if (m_tb_prefs.getBoolPref('extensions.torbutton.cookie_protections')) {

1 0

[torbutton/maint-1.9.5] Release preparations for 1.9.5.5
by gk＠torproject.org 17 Jun '16

17 Jun '16

commit 752bf7244bf20141003bfd6da06aaab92be2fae7 Author: Georg Koppen <gk(a)torproject.org> Date: Fri Jun 17 14:48:30 2016 +0000 Release preparations for 1.9.5.5 Changelog update, version bump --- src/CHANGELOG | 3 +++ src/install.rdf | 2 +- 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/src/CHANGELOG b/src/CHANGELOG index ecf6cba..77ba290 100644 --- a/src/CHANGELOG +++ b/src/CHANGELOG @@ -1,3 +1,6 @@ +1.9.5.5 + * Bug 19417: Clear asmjscache + 1.9.5.4 * Bug 18466: Make Torbutton compatible with Firefox ESR 45 * Bug 18743: Pref to hide 'Sign in to Sync' button in hamburger menu diff --git a/src/install.rdf b/src/install.rdf index 44affa3..ac45b1d 100644 --- a/src/install.rdf +++ b/src/install.rdf @@ -6,7 +6,7 @@ <em:name>Torbutton</em:name> <em:creator>Mike Perry</em:creator> <em:id>torbutton(a)torproject.org</em:id> - <em:version>1.9.5.4</em:version> + <em:version>1.9.5.5</em:version> <em:homepageURL>https://www.torproject.org/projects/torbrowser.html.en</em:homepageURL> <em:optionsURL>chrome://torbutton/content/preferences.xul</em:optionsURL> <em:iconURL>chrome://torbutton/skin/tor.png</em:iconURL>

1 0

[torbutton/master] Bug 19417: Clear asmjscache
by gk＠torproject.org 17 Jun '16

17 Jun '16

commit e264e6027a78488f9813e3796d29f52df1a189ba Author: Georg Koppen <gk(a)torproject.org> Date: Fri Jun 17 09:49:16 2016 +0000 Bug 19417: Clear asmjscache This patch clears the asmjscache (and the IndexedDB storage) on New Identity and during start-up. The latter is a suboptimal workaround we deploy until the asmjscache is Private Browsing Mode aware. InedxedDB storage is not so urgent as IndexedDB is not working in Private Browsing Mode anyway. --- src/chrome/content/torbutton.js | 33 +++++++++++++++++++++++++++++++++ 1 file changed, 33 insertions(+) diff --git a/src/chrome/content/torbutton.js b/src/chrome/content/torbutton.js index e0e541b..f69fd8a 100644 --- a/src/chrome/content/torbutton.js +++ b/src/chrome/content/torbutton.js @@ -578,6 +578,23 @@ function torbutton_init() { torbutton_update_security_slider(); } + // XXX: Get rid of the cached asmjs (or IndexedDB) files on disk in case we + // don't allow things saved to disk. This is an ad-hoc fix to work around + // #19417. Once this is properly solved we should remove this code again. + if (m_tb_prefs.getBoolPref("extensions.torbutton.block_disk")) { + let orig_quota_test = m_tb_prefs.getBoolPref("dom.quotaManager.testing"); + try { + // This works only by setting the pref to `true` otherwise we get an + // exception and nothing is happening. + m_tb_prefs.setBoolPref("dom.quotaManager.testing", true); + Cc["@mozilla.org/dom/quota-manager-service;1"] + .getService(Ci.nsIQuotaManagerService).clear(); + } catch(e) { + } finally { + m_tb_prefs.setBoolPref("dom.quotaManager.testing", orig_quota_test); + } + } + // set panel style from preferences torbutton_set_panel_style(); @@ -1677,6 +1694,7 @@ function torbutton_new_identity() { * h. last open location url * i. clear content prefs * j. permissions + * k. IndexedDB and asmjscache storage * 3. Sends tor the NEWNYM signal to get a new circuit * 4. Opens a new window with the default homepage * 5. Closes this window @@ -1824,6 +1842,21 @@ function torbutton_do_new_identity() { window.alert("Torbutton: Unexpected error during cache clearing: "+e); } + torbutton_log(3, "New Identity: Clearing storage"); + + let orig_quota_test = m_tb_prefs.getBoolPref("dom.quotaManager.testing"); + try { + // This works only by setting the pref to `true` otherwise we get an + // exception and nothing is happening. + m_tb_prefs.setBoolPref("dom.quotaManager.testing", true); + Cc["@mozilla.org/dom/quota-manager-service;1"] + .getService(Ci.nsIQuotaManagerService).clear(); + } catch(e) { + torbutton_log(5, "Exception on storage clearing: "+e); + } finally { + m_tb_prefs.setBoolPref("dom.quotaManager.testing", orig_quota_test); + } + torbutton_log(3, "New Identity: Clearing Cookies and DOM Storage"); if (m_tb_prefs.getBoolPref('extensions.torbutton.cookie_protections')) {

1 0

[tor-browser/tor-browser-45.2.0esr-6.0-1] Revert "Bug 1229855: Fix miscompilation of uint8_t enum class with gcc4.8.2; r=luke a=lizzard"
by gk＠torproject.org 17 Jun '16

17 Jun '16

commit 6803b2f08165a02cac4621db10fc2e1d99b7b435 Author: Georg Koppen <gk(a)torproject.org> Date: Fri Jun 17 13:37:19 2016 +0000 Revert "Bug 1229855: Fix miscompilation of uint8_t enum class with gcc4.8.2; r=luke a=lizzard" This reverts commit fcb31773712f1e2adce790771f7978ba30056645. This fixes bug 19400. We are not affected by a buggy GCC 4.8.2. --- js/src/asmjs/Wasm.h | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/js/src/asmjs/Wasm.h b/js/src/asmjs/Wasm.h index b0976d0..2777467 100644 --- a/js/src/asmjs/Wasm.h +++ b/js/src/asmjs/Wasm.h @@ -34,9 +34,7 @@ using mozilla::Move; // The ValType enum represents the WebAssembly "value type", which are used to // specify the type of locals and parameters. -// FIXME: uint8_t would make more sense for the underlying storage class, but -// causes miscompilations in GCC (fixed in 4.8.5 and 4.9.3). -enum class ValType +enum class ValType : uint8_t { I32, I64,

1 0

[tor-browser/tor-browser-45.2.0esr-6.5-1] Revert "Bug 1229855: Fix miscompilation of uint8_t enum class with gcc4.8.2; r=luke a=lizzard"
by gk＠torproject.org 17 Jun '16

17 Jun '16

commit 2fbfb9d9af2553b35ec9231f3923b3be49ab2549 Author: Georg Koppen <gk(a)torproject.org> Date: Fri Jun 17 13:38:23 2016 +0000 Revert "Bug 1229855: Fix miscompilation of uint8_t enum class with gcc4.8.2; r=luke a=lizzard" This reverts commit fcb31773712f1e2adce790771f7978ba30056645. This fixes bug 19400. We are not affected by a buggy GCC 4.8.2. --- js/src/asmjs/Wasm.h | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/js/src/asmjs/Wasm.h b/js/src/asmjs/Wasm.h index b0976d0..2777467 100644 --- a/js/src/asmjs/Wasm.h +++ b/js/src/asmjs/Wasm.h @@ -34,9 +34,7 @@ using mozilla::Move; // The ValType enum represents the WebAssembly "value type", which are used to // specify the type of locals and parameters. -// FIXME: uint8_t would make more sense for the underlying storage class, but -// causes miscompilations in GCC (fixed in 4.8.5 and 4.9.3). -enum class ValType +enum class ValType : uint8_t { I32, I64,

1 0

[tor-browser/tor-browser-45.2.0esr-6.0-1] fixup! TB4: Tor Browser's Firefox preference overrides.
by gk＠torproject.org 17 Jun '16

17 Jun '16

commit 979f170107821ca481870c01820d628e55d47913 Author: Georg Koppen <gk(a)torproject.org> Date: Fri Jun 17 08:29:48 2016 +0000 fixup! TB4: Tor Browser's Firefox preference overrides. This works around the most problematic performance regressions brought up in bug 19276. --- browser/app/profile/000-tor-browser.js | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/browser/app/profile/000-tor-browser.js b/browser/app/profile/000-tor-browser.js index 7b2e773..e3665b4 100644 --- a/browser/app/profile/000-tor-browser.js +++ b/browser/app/profile/000-tor-browser.js @@ -240,6 +240,10 @@ pref("network.http.pipelining.max-optimistic-requests", 3); pref("security.ssl.disable_session_identifiers", true); pref("network.manage-offline-status", false); +// Disable Xrender as it causes serious performance regressions on some machines +// and is disabled in Firefox >= 47 anyway. +pref("gfx.xrender.enabled",false); + // As a "defense in depth" measure, configure an empty push server URL (the // DOM Push features are disabled by default via other prefs). pref("dom.push.serverURL", "");

1 0

[tor-browser/tor-browser-45.2.0esr-6.5-1] fixup! TB4: Tor Browser's Firefox preference overrides.
by gk＠torproject.org 17 Jun '16

17 Jun '16

commit 7d0974ce3580b26f24f9363404e5d36cc584e254 Author: Georg Koppen <gk(a)torproject.org> Date: Fri Jun 17 08:29:48 2016 +0000 fixup! TB4: Tor Browser's Firefox preference overrides. This works around the most problematic performance regressions brought up in bug 19276. --- browser/app/profile/000-tor-browser.js | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/browser/app/profile/000-tor-browser.js b/browser/app/profile/000-tor-browser.js index 7b2e773..e3665b4 100644 --- a/browser/app/profile/000-tor-browser.js +++ b/browser/app/profile/000-tor-browser.js @@ -240,6 +240,10 @@ pref("network.http.pipelining.max-optimistic-requests", 3); pref("security.ssl.disable_session_identifiers", true); pref("network.manage-offline-status", false); +// Disable Xrender as it causes serious performance regressions on some machines +// and is disabled in Firefox >= 47 anyway. +pref("gfx.xrender.enabled",false); + // As a "defense in depth" measure, configure an empty push server URL (the // DOM Push features are disabled by default via other prefs). pref("dom.push.serverURL", "");

1 0

[tor-browser-bundle/master] Bump Tor Browser branch used in nightlies
by gk＠torproject.org 17 Jun '16

17 Jun '16

commit ee898eb0345f572bae8f0dca6a68ad75edeb8ce3 Author: Georg Koppen <gk(a)torproject.org> Date: Fri Jun 17 11:36:37 2016 +0000 Bump Tor Browser branch used in nightlies --- gitian/versions.nightly | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/gitian/versions.nightly b/gitian/versions.nightly index 815a169..331da1c 100755 --- a/gitian/versions.nightly +++ b/gitian/versions.nightly @@ -17,11 +17,11 @@ MULTI_LINGUAL=1 VERIFY_TAGS=0 -FIREFOX_VERSION=45.1.0esr +FIREFOX_VERSION=45.2.0esr TORBROWSER_UPDATE_CHANNEL=default -TORBROWSER_TAG=tor-browser-${FIREFOX_VERSION}-6.0-1 +TORBROWSER_TAG=tor-browser-${FIREFOX_VERSION}-6.5-1 TOR_TAG=master TORLAUNCHER_TAG=master TORBUTTON_TAG=master

1 0

[tor-browser/tor-browser-45.2.0esr-6.0-1] Bug 19411: Update icon shows up even if partial updates are failing.
by gk＠torproject.org 17 Jun '16

17 Jun '16

commit 15792fd075f46d2150a566bd546ec41b427f3588 Author: Kathy Brade <brade(a)pearlcrescent.com> Date: Wed Jun 15 14:12:45 2016 -0400 Bug 19411: Update icon shows up even if partial updates are failing. Do not show the "update badge" on the hamburger menu when the update state is "downloading" (which means fallback to a complete update is in progress). --- browser/base/content/browser.js | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/browser/base/content/browser.js b/browser/base/content/browser.js index 0adbe61..41d72ae 100644 --- a/browser/base/content/browser.js +++ b/browser/base/content/browser.js @@ -2668,6 +2668,12 @@ var gMenuButtonUpdateBadge = { }, observe: function (subject, topic, status) { + if (status == "downloading") { + // A partial update failed and a complete update is being attempted. + // Ignore (it does not make sense to show the update badge yet). + return; + } + if (status == "failed") { // Background update has failed, let's show the UI responsible for // prompting the user to update manually.

1 0

[tor-browser/tor-browser-45.2.0esr-6.5-1] Bug 19411: Update icon shows up even if partial updates are failing.
by gk＠torproject.org 17 Jun '16

17 Jun '16

commit 8d80221e8cfdc85e1b6c7692542181621b2eb4f1 Author: Kathy Brade <brade(a)pearlcrescent.com> Date: Wed Jun 15 14:12:45 2016 -0400 Bug 19411: Update icon shows up even if partial updates are failing. Do not show the "update badge" on the hamburger menu when the update state is "downloading" (which means fallback to a complete update is in progress). --- browser/base/content/browser.js | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/browser/base/content/browser.js b/browser/base/content/browser.js index 0adbe61..41d72ae 100644 --- a/browser/base/content/browser.js +++ b/browser/base/content/browser.js @@ -2668,6 +2668,12 @@ var gMenuButtonUpdateBadge = { }, observe: function (subject, topic, status) { + if (status == "downloading") { + // A partial update failed and a complete update is being attempted. + // Ignore (it does not make sense to show the update badge yet). + return; + } + if (status == "failed") { // Background update has failed, let's show the UI responsible for // prompting the user to update manually.

1 0