- tbb-commits - lists.torproject.org

[tor-browser/tor-browser-52.1.0esr-7.0-2] fixup! Bug 5282: Randomize HTTP request order and pipeline depth.
by gk＠torproject.org 29 May '17

29 May '17

commit 7aa5a5c8565273ea41a0c003160226f3229373f6 Author: Arthur Edelstein <arthuredelstein(a)gmail.com> Date: Sat May 27 00:22:17 2017 -0700 fixup! Bug 5282: Randomize HTTP request order and pipeline depth. Use format specifiers for unsigned long integers. --- netwerk/protocol/http/nsHttpPipeline.cpp | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/netwerk/protocol/http/nsHttpPipeline.cpp b/netwerk/protocol/http/nsHttpPipeline.cpp index 207c55b..6735c55 100644 --- a/netwerk/protocol/http/nsHttpPipeline.cpp +++ b/netwerk/protocol/http/nsHttpPipeline.cpp @@ -16,6 +16,10 @@ #include <algorithm> #include "nsHttpRequestHead.h" +#ifdef WTF_TEST +#include <inttypes.h> +#endif + #ifdef DEBUG #include "prthread.h" #endif @@ -965,7 +969,9 @@ nsHttpPipeline::FillSendBuf() #ifdef WTF_TEST if (totalSent) - fprintf(stderr, "WTF-combine: Sent %lld/%lld bytes of %lld combined pipelined requests for host %s\n", + fprintf(stderr, + "WTF-combine: Sent %" PRIu64 "/%" PRIu64 " bytes of %" PRIu64 + " combined pipelined requests for host %s\n", alreadyPending+totalSent, totalAvailable, reqsSent, ci->Origin()); #endif

1 0

[tor-browser/tor-browser-52.1.0esr-7.0-2] Bug 21684: Don't expose navigator.AddonManager to content
by gk＠torproject.org 29 May '17

29 May '17

commit e5da14c4ae6e3917928b3004bca7bd49e972089e Author: Georg Koppen <gk(a)torproject.org> Date: Fri May 26 19:18:32 2017 +0000 Bug 21684: Don't expose navigator.AddonManager to content With https://bugzilla.mozilla.org/show_bug.cgi?id=1245571 support for websites to learn about installed add-ons landed. Currently, this is only enabled for AMO related sites but we don't think this functionality is something we want for Tor Browser as it might aid in fingerprinting users. The patch does not outright disable access to the API. Privileged code is still able to use it if needed. This should help with usability issues should they arise while mitigating possible fingerprinting and security problems by having this API available to content. This fixes bug 21684 by deleting the whitelist of URLs shipped with Firefox 52. --- toolkit/mozapps/extensions/AddonManagerWebAPI.cpp | 23 ++++------------------- 1 file changed, 4 insertions(+), 19 deletions(-) diff --git a/toolkit/mozapps/extensions/AddonManagerWebAPI.cpp b/toolkit/mozapps/extensions/AddonManagerWebAPI.cpp index ca33f3a..45326fd 100644 --- a/toolkit/mozapps/extensions/AddonManagerWebAPI.cpp +++ b/toolkit/mozapps/extensions/AddonManagerWebAPI.cpp @@ -20,25 +20,10 @@ using namespace mozilla::dom; static bool IsValidHost(const nsACString& host) { - if (host.Equals("addons.mozilla.org") || - host.Equals("discovery.addons.mozilla.org") || - host.Equals("testpilot.firefox.com")) { - return true; - } - - // When testing allow access to the developer sites. - if (Preferences::GetBool("extensions.webapi.testing", false)) { - if (host.LowerCaseEqualsLiteral("addons.allizom.org") || - host.LowerCaseEqualsLiteral("discovery.addons.allizom.org") || - host.LowerCaseEqualsLiteral("addons-dev.allizom.org") || - host.LowerCaseEqualsLiteral("discovery.addons-dev.allizom.org") || - host.LowerCaseEqualsLiteral("testpilot.stage.mozaws.net") || - host.LowerCaseEqualsLiteral("testpilot.dev.mozaws.net") || - host.LowerCaseEqualsLiteral("example.com")) { - return true; - } - } - + // We don't want to allow content to get information about the state of the + // extensions a user has installed. This might aid in fingerprinting. And + // allowing content at all access to this kind of information seems + // potentially risky from a security point as well. Fixes bug 21684. return false; }

1 0

[tor-browser/tor-browser-52.1.1esr-7.0-1] Bug 21684: Don't expose navigator.AddonManager to content
by gk＠torproject.org 29 May '17

29 May '17

commit 9de9d5a74472423e5a7e5754f5d93b2d89103dfe Author: Georg Koppen <gk(a)torproject.org> Date: Fri May 26 19:18:32 2017 +0000 Bug 21684: Don't expose navigator.AddonManager to content With https://bugzilla.mozilla.org/show_bug.cgi?id=1245571 support for websites to learn about installed add-ons landed. Currently, this is only enabled for AMO related sites but we don't think this functionality is something we want for Tor Browser as it might aid in fingerprinting users. The patch does not outright disable access to the API. Privileged code is still able to use it if needed. This should help with usability issues should they arise while mitigating possible fingerprinting and security problems by having this API available to content. This fixes bug 21684 by deleting the whitelist of URLs shipped with Firefox 52. --- toolkit/mozapps/extensions/AddonManagerWebAPI.cpp | 23 ++++------------------- 1 file changed, 4 insertions(+), 19 deletions(-) diff --git a/toolkit/mozapps/extensions/AddonManagerWebAPI.cpp b/toolkit/mozapps/extensions/AddonManagerWebAPI.cpp index ca33f3a..45326fd 100644 --- a/toolkit/mozapps/extensions/AddonManagerWebAPI.cpp +++ b/toolkit/mozapps/extensions/AddonManagerWebAPI.cpp @@ -20,25 +20,10 @@ using namespace mozilla::dom; static bool IsValidHost(const nsACString& host) { - if (host.Equals("addons.mozilla.org") || - host.Equals("discovery.addons.mozilla.org") || - host.Equals("testpilot.firefox.com")) { - return true; - } - - // When testing allow access to the developer sites. - if (Preferences::GetBool("extensions.webapi.testing", false)) { - if (host.LowerCaseEqualsLiteral("addons.allizom.org") || - host.LowerCaseEqualsLiteral("discovery.addons.allizom.org") || - host.LowerCaseEqualsLiteral("addons-dev.allizom.org") || - host.LowerCaseEqualsLiteral("discovery.addons-dev.allizom.org") || - host.LowerCaseEqualsLiteral("testpilot.stage.mozaws.net") || - host.LowerCaseEqualsLiteral("testpilot.dev.mozaws.net") || - host.LowerCaseEqualsLiteral("example.com")) { - return true; - } - } - + // We don't want to allow content to get information about the state of the + // extensions a user has installed. This might aid in fingerprinting. And + // allowing content at all access to this kind of information seems + // potentially risky from a security point as well. Fixes bug 21684. return false; }

1 0

[tor-browser/tor-browser-52.1.1esr-7.0-1] fixup! TB4: Tor Browser's Firefox preference overrides.
by gk＠torproject.org 25 May '17

25 May '17

commit b9bff8b465284d1ad0a95ca19e2318b4e200f63f Author: Georg Koppen <gk(a)torproject.org> Date: Tue May 23 09:08:40 2017 +0000 fixup! TB4: Tor Browser's Firefox preference overrides. For now we disable WebGL2 due to fingerprinting concerns. We could think about restricting its features to a minimal mode as well in order to make at least some use of it. This is the task for bug 22333, though. --- browser/app/profile/000-tor-browser.js | 1 + 1 file changed, 1 insertion(+) diff --git a/browser/app/profile/000-tor-browser.js b/browser/app/profile/000-tor-browser.js index 53d1ac2..78e6a05 100644 --- a/browser/app/profile/000-tor-browser.js +++ b/browser/app/profile/000-tor-browser.js @@ -137,6 +137,7 @@ pref("social.whitelist", ""); pref("webgl.min_capability_mode", true); pref("webgl.disable-extensions", true); pref("webgl.disable-fail-if-major-performance-caveat", true); +pref("webgl.enable-webgl2", false); pref("dom.network.enabled",false); // fingerprinting due to differing OS implementations pref("gfx.downloadable_fonts.fallback_delay", -1); pref("general.appname.override", "Netscape");

1 0

[tor-browser/tor-browser-52.1.0esr-7.0-2] fixup! TB4: Tor Browser's Firefox preference overrides.
by gk＠torproject.org 25 May '17

25 May '17

commit 2931426f6f8f2541ca6e5b43c62a61ab8bc9eec4 Author: Georg Koppen <gk(a)torproject.org> Date: Tue May 23 09:08:40 2017 +0000 fixup! TB4: Tor Browser's Firefox preference overrides. For now we disable WebGL2 due to fingerprinting concerns. We could think about restricting its features to a minimal mode as well in order to make at least some use of it. This is the task for bug 22333, though. --- browser/app/profile/000-tor-browser.js | 1 + 1 file changed, 1 insertion(+) diff --git a/browser/app/profile/000-tor-browser.js b/browser/app/profile/000-tor-browser.js index 53d1ac2..78e6a05 100644 --- a/browser/app/profile/000-tor-browser.js +++ b/browser/app/profile/000-tor-browser.js @@ -137,6 +137,7 @@ pref("social.whitelist", ""); pref("webgl.min_capability_mode", true); pref("webgl.disable-extensions", true); pref("webgl.disable-fail-if-major-performance-caveat", true); +pref("webgl.enable-webgl2", false); pref("dom.network.enabled",false); // fingerprinting due to differing OS implementations pref("gfx.downloadable_fonts.fallback_delay", -1); pref("general.appname.override", "Netscape");

1 0

[tor-browser/tor-browser-52.1.0esr-7.0-2] Bug 22320: Use pref name 'referer.hideOnionSource' everywhere
by gk＠torproject.org 25 May '17

25 May '17

commit f59a7bc0288dcf5efaa71ebe8f591d7edea7b7b7 Author: Arthur Edelstein <arthuredelstein(a)gmail.com> Date: Wed May 24 12:49:27 2017 -0700 Bug 22320: Use pref name 'referer.hideOnionSource' everywhere Correcting my mistake in https://bugzilla.mozilla.org/show_bug.cgi?id=1305144 --- modules/libpref/init/all.js | 2 +- netwerk/protocol/http/nsHttpHandler.cpp | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/modules/libpref/init/all.js b/modules/libpref/init/all.js index 983c93a..b79cc3a 100644 --- a/modules/libpref/init/all.js +++ b/modules/libpref/init/all.js @@ -1450,7 +1450,7 @@ pref("network.http.accept.default", "text/html,application/xhtml+xml,application pref("network.http.sendRefererHeader", 2); // false=real referer, true=spoof referer (use target URI as referer) pref("network.http.referer.spoofSource", false); -// false=allow onion referer, true=hide onion referer (use target URI as referer) +// false=allow onion referer, true=hide onion referer (use empty referer) pref("network.http.referer.hideOnionSource", false); // 0=full URI, 1=scheme+host+port+path, 2=scheme+host+port pref("network.http.referer.trimmingPolicy", 0); diff --git a/netwerk/protocol/http/nsHttpHandler.cpp b/netwerk/protocol/http/nsHttpHandler.cpp index 13c4d3f..4276c71 100644 --- a/netwerk/protocol/http/nsHttpHandler.cpp +++ b/netwerk/protocol/http/nsHttpHandler.cpp @@ -1075,8 +1075,8 @@ nsHttpHandler::PrefsChanged(nsIPrefBranch *prefs, const char *pref) mSpoofReferrerSource = cVar; } - if (PREF_CHANGED(HTTP_PREF("referer.spoofOnionSource"))) { - rv = prefs->GetBoolPref(HTTP_PREF("referer.spoofOnionSource"), &cVar); + if (PREF_CHANGED(HTTP_PREF("referer.hideOnionSource"))) { + rv = prefs->GetBoolPref(HTTP_PREF("referer.hideOnionSource"), &cVar); if (NS_SUCCEEDED(rv)) mHideOnionReferrerSource = cVar; }

1 0

[tor-browser/tor-browser-52.1.1esr-7.0-1] Bug 22320: Use pref name 'referer.hideOnionSource' everywhere
by gk＠torproject.org 25 May '17

25 May '17

commit 326e9aedfec184325ae95059d12e6b674bfa9013 Author: Arthur Edelstein <arthuredelstein(a)gmail.com> Date: Wed May 24 12:49:27 2017 -0700 Bug 22320: Use pref name 'referer.hideOnionSource' everywhere Correcting my mistake in https://bugzilla.mozilla.org/show_bug.cgi?id=1305144 --- modules/libpref/init/all.js | 2 +- netwerk/protocol/http/nsHttpHandler.cpp | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/modules/libpref/init/all.js b/modules/libpref/init/all.js index 983c93a..b79cc3a 100644 --- a/modules/libpref/init/all.js +++ b/modules/libpref/init/all.js @@ -1450,7 +1450,7 @@ pref("network.http.accept.default", "text/html,application/xhtml+xml,application pref("network.http.sendRefererHeader", 2); // false=real referer, true=spoof referer (use target URI as referer) pref("network.http.referer.spoofSource", false); -// false=allow onion referer, true=hide onion referer (use target URI as referer) +// false=allow onion referer, true=hide onion referer (use empty referer) pref("network.http.referer.hideOnionSource", false); // 0=full URI, 1=scheme+host+port+path, 2=scheme+host+port pref("network.http.referer.trimmingPolicy", 0); diff --git a/netwerk/protocol/http/nsHttpHandler.cpp b/netwerk/protocol/http/nsHttpHandler.cpp index 13c4d3f..4276c71 100644 --- a/netwerk/protocol/http/nsHttpHandler.cpp +++ b/netwerk/protocol/http/nsHttpHandler.cpp @@ -1075,8 +1075,8 @@ nsHttpHandler::PrefsChanged(nsIPrefBranch *prefs, const char *pref) mSpoofReferrerSource = cVar; } - if (PREF_CHANGED(HTTP_PREF("referer.spoofOnionSource"))) { - rv = prefs->GetBoolPref(HTTP_PREF("referer.spoofOnionSource"), &cVar); + if (PREF_CHANGED(HTTP_PREF("referer.hideOnionSource"))) { + rv = prefs->GetBoolPref(HTTP_PREF("referer.hideOnionSource"), &cVar); if (NS_SUCCEEDED(rv)) mHideOnionReferrerSource = cVar; }

1 0

[tor-browser/tor-browser-52.1.0esr-7.0-2] Bug 21431: Clean-up system extensions shipped in Firefox 52
by gk＠torproject.org 24 May '17

24 May '17

commit 6b8a66553b3aa4a518dc4448baf11099a8df22cd Author: Kathy Brade <brade(a)pearlcrescent.com> Date: Tue May 23 17:05:29 2017 -0400 Bug 21431: Clean-up system extensions shipped in Firefox 52 Only ship the e10srollout system extension and pdfjs. --- browser/extensions/moz.build | 10 ---------- browser/locales/Makefile.in | 1 - 2 files changed, 11 deletions(-) diff --git a/browser/extensions/moz.build b/browser/extensions/moz.build index 9b01ed0..71fda56 100644 --- a/browser/extensions/moz.build +++ b/browser/extensions/moz.build @@ -5,16 +5,6 @@ # file, You can obtain one at http://mozilla.org/MPL/2.0/. DIRS += [ - 'aushelper', 'e10srollout', 'pdfjs', - 'pocket', - 'webcompat', ] - -# Only include the following system add-ons if building Aurora or Nightly -if 'a' in CONFIG['GRE_MILESTONE']: - DIRS += [ - 'flyweb', - 'formautofill', - ] diff --git a/browser/locales/Makefile.in b/browser/locales/Makefile.in index 6b0455b..e178dfe 100644 --- a/browser/locales/Makefile.in +++ b/browser/locales/Makefile.in @@ -99,7 +99,6 @@ libs-%: @$(MAKE) -C ../../toolkit/locales libs-$* XPI_ROOT_APPID='$(XPI_ROOT_APPID)' @$(MAKE) -C ../../services/sync/locales AB_CD=$* XPI_NAME=locale-$* @$(MAKE) -C ../../extensions/spellcheck/locales AB_CD=$* XPI_NAME=locale-$* - @$(MAKE) -C ../extensions/pocket/locale AB_CD=$* XPI_NAME=locale-$* @$(MAKE) -C ../../intl/locales AB_CD=$* XPI_NAME=locale-$* @$(MAKE) -C ../../devtools/client/locales AB_CD=$* XPI_NAME=locale-$* XPI_ROOT_APPID='$(XPI_ROOT_APPID)' @$(MAKE) -B searchplugins AB_CD=$* XPI_NAME=locale-$*

1 0

[tor-browser/tor-browser-52.1.1esr-7.0-1] Bug 21431: Clean-up system extensions shipped in Firefox 52
by gk＠torproject.org 24 May '17

24 May '17

commit 475734012b70c7515a2a105ea6584136cee57bf6 Author: Kathy Brade <brade(a)pearlcrescent.com> Date: Tue May 23 17:05:29 2017 -0400 Bug 21431: Clean-up system extensions shipped in Firefox 52 Only ship the e10srollout system extension and pdfjs. --- browser/extensions/moz.build | 10 ---------- browser/locales/Makefile.in | 1 - 2 files changed, 11 deletions(-) diff --git a/browser/extensions/moz.build b/browser/extensions/moz.build index 9b01ed0..71fda56 100644 --- a/browser/extensions/moz.build +++ b/browser/extensions/moz.build @@ -5,16 +5,6 @@ # file, You can obtain one at http://mozilla.org/MPL/2.0/. DIRS += [ - 'aushelper', 'e10srollout', 'pdfjs', - 'pocket', - 'webcompat', ] - -# Only include the following system add-ons if building Aurora or Nightly -if 'a' in CONFIG['GRE_MILESTONE']: - DIRS += [ - 'flyweb', - 'formautofill', - ] diff --git a/browser/locales/Makefile.in b/browser/locales/Makefile.in index 6b0455b..e178dfe 100644 --- a/browser/locales/Makefile.in +++ b/browser/locales/Makefile.in @@ -99,7 +99,6 @@ libs-%: @$(MAKE) -C ../../toolkit/locales libs-$* XPI_ROOT_APPID='$(XPI_ROOT_APPID)' @$(MAKE) -C ../../services/sync/locales AB_CD=$* XPI_NAME=locale-$* @$(MAKE) -C ../../extensions/spellcheck/locales AB_CD=$* XPI_NAME=locale-$* - @$(MAKE) -C ../extensions/pocket/locale AB_CD=$* XPI_NAME=locale-$* @$(MAKE) -C ../../intl/locales AB_CD=$* XPI_NAME=locale-$* @$(MAKE) -C ../../devtools/client/locales AB_CD=$* XPI_NAME=locale-$* XPI_ROOT_APPID='$(XPI_ROOT_APPID)' @$(MAKE) -B searchplugins AB_CD=$* XPI_NAME=locale-$*

1 0

[tor-browser-bundle/master] Revert "Bug 21779: Non-admin users can't access Tor Browser on macOS."
by gk＠torproject.org 24 May '17

24 May '17

commit 082738a4bd83943d97e084fa04045e481772b998 Author: Georg Koppen <gk(a)torproject.org> Date: Wed May 24 07:43:18 2017 +0000 Revert "Bug 21779: Non-admin users can't access Tor Browser on macOS." This reverts commit f27d2cab4ed80a4c7b4f594b593b6b90f6148a82. The problem was the script for recreating the .dmg files after the code-signing set the permissions wrong. No need to fix anything in the bundle descriptor. --- gitian/descriptors/mac/gitian-bundle.yml | 13 ++----------- 1 file changed, 2 insertions(+), 11 deletions(-) diff --git a/gitian/descriptors/mac/gitian-bundle.yml b/gitian/descriptors/mac/gitian-bundle.yml index 54ce237..a2c8408 100644 --- a/gitian/descriptors/mac/gitian-bundle.yml +++ b/gitian/descriptors/mac/gitian-bundle.yml @@ -303,11 +303,7 @@ script: | rm -f precomplete python $MARTOOLS/createprecomplete.py popd - - # Ensure that files and directories are accessible by non-admin users - # if the app bundle is placed in /Applications. See bug 21779. - chmod -R o+rX ~/build/$TORBROWSER_NAME.app - + # # Create full MAR file and disk image. MAR_FILE=tor-browser-osx${GBUILD_BITS}-${TORBROWSER_VERSION}_${PKG_LOCALE}.mar MAR=$MARTOOLS/mar MBSDIFF=$MARTOOLS/mbsdiff $MARTOOLS/make_full_update.sh -q $OUTDIR/$MAR_FILE ~/build/$TORBROWSER_NAME.app @@ -345,12 +341,7 @@ script: | rm -f precomplete python $MARTOOLS/createprecomplete.py popd - - # Ensure that files and directories are accessible by non-admin users - # if the app bundle is placed in /Applications. See bug 21779. - chmod -R o+rX ~/build/dmg/$DEST.app - - # Create full MAR file and disk image. + # MAR_FILE=tor-browser-osx${GBUILD_BITS}-${TORBROWSER_VERSION}_$LANG.mar MAR=$MARTOOLS/mar MBSDIFF=$MARTOOLS/mbsdiff $MARTOOLS/make_full_update.sh -q $OUTDIR/$MAR_FILE ~/build/dmg/$DEST.app # Rename the Japanese bundle to not confuse users

1 0