lists.torproject.org
Sign In Sign Up
Manage this list Sign In Sign Up

Keyboard Shortcuts

Thread View

  • j: Next unread message
  • k: Previous unread message
  • j a: Jump to all threads
  • j l: Jump to MailingList overview

tbb-commits

Thread Start a new thread
Download
Threads by month
  • ----- 2025 -----
  • June
  • May
  • April
  • March
  • February
  • January
  • ----- 2024 -----
  • December
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
  • ----- 2023 -----
  • December
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
  • ----- 2022 -----
  • December
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
  • ----- 2021 -----
  • December
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
  • ----- 2020 -----
  • December
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
  • ----- 2019 -----
  • December
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
  • ----- 2018 -----
  • December
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
  • ----- 2017 -----
  • December
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
  • ----- 2016 -----
  • December
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
  • ----- 2015 -----
  • December
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
  • January
  • ----- 2014 -----
  • December
  • November
  • October
  • September
  • August
  • July
  • June
  • May
  • April
  • March
  • February
tbb-commits@lists.torproject.org

  • 1 participants
  • 18588 discussions
[Git][tpo/applications/tor-browser][base-browser-128.4.0esr-14.5-1] fixup! Adding issue and merge request templates
by morgan (@morgan) 14 Nov '24

14 Nov '24
morgan pushed to branch base-browser-128.4.0esr-14.5-1 at The Tor Project / Applications / Tor Browser Commits: 56ffe58d by Morgan at 2024-11-14T01:56:46+00:00 fixup! Adding issue and merge request templates Bug 43295: Update MR templates - - - - - 1 changed file: - .gitlab/merge_request_templates/default.md Changes: ===================================== .gitlab/merge_request_templates/default.md ===================================== @@ -2,18 +2,42 @@ <!-- Bookkeeping information for release management --> -### Related Issues +### Issues + +#### Resolves - tor-browser#xxxxx - mullvad-browser#xxxxx - tor-browser-build#xxxxx +#### Related + +- tor-browser#xxxxx +- mullvad-browser#xxxxx +- tor-browser-build#xxxxx + +### Merging + +<!-- This block tells the merger where commits need to be merged and future code archaeologists where commits were *supposed* to be merged --> + +#### Target Branches + +- [ ] **`tor-browser`** - `!fixups` to `tor-browser`-specific commits, new features, security backports +- [ ] **`base-browser`** *and* **`mullvad-browser`** - `!fixups` to `base-browser`-specific commits, new features to be shared with `mullvad-browser`, and security backports + - ⚠️ **IMPORTANT**: Please list the `base-browser`-specific commits which need to be cherry-picked to the `base-browser` and `mullvad-browser` branches here + +#### Target Channels + +- [ ] **Alpha**: esr128-14.5 +- [ ] **Stable**: esr128-14.0 +- [ ] **Legacy**: esr115-13.5 + ### Backporting #### Timeline +- [ ] **No Backport (preferred)**: patchset for the next major stable - [ ] **Immediate**: patchset needed as soon as possible - [ ] **Next Minor Stable Release**: patchset that needs to be verified in nightly before backport - [ ] **Eventually**: patchset that needs to be verified in alpha before backport -- [ ] **No Backport (preferred)**: patchset for the next major stable #### (Optional) Justification - [ ] **Emergency security update**: patchset fixes CVEs, 0-days, etc @@ -24,11 +48,6 @@ - [ ] **Localization**: typos and other localization changes that should be also in the release branch - [ ] **Other**: please explain -### Merging -- [ ] Merge to `tor-browser` - `!fixups` to `tor-browser`-specific commits, new features, security backports -- [ ] Merge to `base-browser` - `!fixups` to `base-browser`-specific commits, new features to be shared with `mullvad-browser`, and security backports - - **NOTE**: if your changeset includes patches to both `base-browser` and `tor-browser` please clearly label in the change description which commits should be cherry-picked to `base-browser` after merging - ### Issue Tracking - [ ] Link resolved issues with appropriate [Release Prep issue](https://gitlab.torproject.org/groups/tpo/applications/-/issues/?sort… for changelog generation @@ -37,7 +56,7 @@ #### Request Reviewer - [ ] Request review from an applications developer depending on modified system: - - **NOTE**: if the MR modifies multiple areas, please `/cc` all the relevant reviewers (since gitlab only allows 1 reviewer) + - **NOTE**: if the MR modifies multiple areas, please `/cc` all the relevant reviewers (since Gitlab only allows 1 reviewer) - **accessibility** : henry - **android** : clairehurst, dan - **build system** : boklm @@ -45,21 +64,22 @@ - **firefox internals (XUL/JS/XPCOM)** : jwilde, ma1 - **fonts** : pierov - **frontend (implementation)** : henry - - **frontend (review)** : donuts, richard + - **frontend (review)** : donuts, morgan - **localization** : henry, pierov - **macOS** : clairehurst, dan - **nightly builds** : boklm - - **rebases/release-prep** : dan, ma1, pierov, richard + - **rebases/release-prep** : dan, ma1, pierov, morgan - **security** : jwilde, ma1 - - **signing** : boklm, richard + - **signing** : boklm, morgan - **updater** : pierov - - **windows** : jwilde, richard - - **misc/other** : pierov, richard + - **windows** : jwilde, morgan + - **misc/other** : pierov, morgan #### Change Description <!-- Whatever context the reviewer needs to effectively review the patchset; if the patch includes UX updates be sure to include screenshots/video of how any new behaviour --> + #### How Tested <!-- Description of steps taken to verify the change --> View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/56ffe58… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/56ffe58… You're receiving this email because of your account on gitlab.torproject.org.
1 0
0 0
[Git][tpo/applications/tor-browser-build] Pushed new tag mb-14.0-build2
by morgan (@morgan) 14 Nov '24

14 Nov '24
morgan pushed new tag mb-14.0-build2 at The Tor Project / Applications / tor-browser-build -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/tree/mb-… You're receiving this email because of your account on gitlab.torproject.org.
1 0
0 0
[Git][tpo/applications/tor-browser-build][maint-14.0] 2 commits: Bug 41291: Enable mingw changes for WebRTC unconditionally
by morgan (@morgan) 14 Nov '24

14 Nov '24
morgan pushed to branch maint-14.0 at The Tor Project / Applications / tor-browser-build Commits: a6600db7 by Morgan at 2024-11-14T00:08:29+00:00 Bug 41291: Enable mingw changes for WebRTC unconditionally - - - - - 2272e06e by Morgan at 2024-11-14T00:09:41+00:00 Bug 41299: Mullvad Browser 14.0 build2 - - - - - 3 changed files: - projects/mingw-w64-clang/build - projects/mingw-w64-clang/config - rbm.conf Changes: ===================================== projects/mingw-w64-clang/build ===================================== @@ -89,9 +89,7 @@ EOF patch -p1 < "$rootdir/mingw-dispatchqueue.patch" patch -p1 < "$rootdir/mingw-ts_sd.patch" patch -p1 < "$rootdir/mingw-composition.patch" - [% IF !c("var/release") %] - patch -p1 < "$rootdir/mingw-webrtc.patch" - [% END %] + patch -p1 < "$rootdir/mingw-webrtc.patch" cd $builddir/mingw-w64-clang/mingw-w64-headers mkdir build && cd build ===================================== projects/mingw-w64-clang/config ===================================== @@ -1,7 +1,7 @@ # vim: filetype=yaml sw=2 filename: '[% project %]-[% c("version") %]-[% pc("llvm-project", "version") %]-[% c("var/build_id") %].tar.[% c("compress_tar") %]' git_url: https://git.code.sf.net/p/mingw-w64/mingw-w64 -git_hash: '[% IF c("var/release") %]cd4cf9b279f8fb0815f8b9665d3cea60a30290bc[% ELSE %]4ef04b0a7f7a20735de2f58b5c0496fcb4c7d191[% END -%]' +git_hash: '4ef04b0a7f7a20735de2f58b5c0496fcb4c7d191' version: '[% c("abbrev") %]' container: use_container: 1 @@ -36,4 +36,3 @@ input_files: - filename: mingw-ts_sd.patch - filename: mingw-composition.patch - filename: mingw-webrtc.patch - enable: '[% !c("var/release") %]' \ No newline at end of file ===================================== rbm.conf ===================================== @@ -74,7 +74,7 @@ buildconf: var: torbrowser_version: '[% IF c("var/tor-browser") %]14.0.2[% ELSE %]14.0[% END %]' - torbrowser_build: 'build1' + torbrowser_build: 'build2' # This should be the date of when the build is started. For the build # to be reproducible, browser_release_date should always be in the past. browser_release_date: '2024/11/12 20:16:21' View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/compare/… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/compare/… You're receiving this email because of your account on gitlab.torproject.org.
1 0
0 0
[Git][tpo/applications/tor-browser][tor-browser-128.4.0esr-14.5-1] fixup! Bug 41600: Add a tor circuit display panel.
by morgan (@morgan) 13 Nov '24

13 Nov '24
morgan pushed to branch tor-browser-128.4.0esr-14.5-1 at The Tor Project / Applications / Tor Browser Commits: facc9a28 by Henry Wilkes at 2024-11-13T20:06:19+00:00 fixup! Bug 41600: Add a tor circuit display panel. Bug 43237: Tweak Tor circuit display panel for screen readers. - - - - - 3 changed files: - browser/components/torcircuit/content/torCircuitPanel.css - browser/components/torcircuit/content/torCircuitPanel.inc.xhtml - browser/components/torcircuit/content/torCircuitPanel.js Changes: ===================================== browser/components/torcircuit/content/torCircuitPanel.css ===================================== @@ -182,6 +182,6 @@ margin: 0; } -.tor-circuit-button label.tor-circuit-button-description { +.tor-circuit-button .tor-circuit-button-description { margin-block-start: var(--space-xsmall); } ===================================== browser/components/torcircuit/content/torCircuitPanel.inc.xhtml ===================================== @@ -3,18 +3,20 @@ aria-labelledby="tor-circuit-heading" type="arrow" orient="vertical" - class="cui-widget-panel panel-no-padding" - tabindex="0"> + class="cui-widget-panel panel-no-padding"> <!-- Use same semantic structure as #identity-popup and #protections-popup - with a role="alertdialog" wrapping a role="document", except we use a - "dialog" rather than an "alertdialog". - Moreover, since this "dialog" may just be for reading, we also make the - - "dialog" part of the focus cycle and receive the initial focus, rather + - "document" part of the focus cycle and receive the initial focus, rather - than finding the first focusable target within. - We do not set "aria-describedby" for this "dialog" because the content - is complex, so a flat string would not make sense. --> - <vbox id="tor-circuit-panel-document" - role="document"> + <!-- NOTE: Currently Orca fails to read the content of this panel, so the + - circuit details are not accessible. This effects mozilla-central as well. + - See bugzilla bug 1820765 and bugzilla bug 1926374. + - The focusable elements are still operable though. --> + <vbox id="tor-circuit-panel-document" role="document" tabindex="0"> <vbox class="panel-header"> <html:h1 id="tor-circuit-heading"></html:h1> <html:div id="tor-circuit-alias" hidden="hidden"> @@ -75,10 +77,12 @@ class="toolbarbutton-text" data-l10n-id="tor-circuit-panel-new-button" /> - <label + <!-- NOTE: Use html:span rather than xul:label. Otherwise Orca will + - treat this as a label for the dialog. --> + <html:span id="tor-circuit-new-circuit-description" class="tor-circuit-button-description" - /> + ></html:span> </vbox> </toolbarbutton> </vbox> ===================================== browser/components/torcircuit/content/torCircuitPanel.js ===================================== @@ -61,6 +61,7 @@ var gTorCircuitPanel = { this.panel = document.getElementById("tor-circuit-panel"); this._panelElements = { + doc: document.getElementById("tor-circuit-panel-document"), heading: document.getElementById("tor-circuit-heading"), alias: document.getElementById("tor-circuit-alias"), aliasLabel: document.getElementById("tor-circuit-alias-label"), @@ -138,13 +139,18 @@ var gTorCircuitPanel = { this._updateCircuitPanel(); }); - // Set the initial focus to the panel element itself, which has been made a - // focusable target. Similar to dialogs, or webextension-popup-browser. + // Set the initial focus to the panel document itself, which has been made a + // focusable target. Similar to webextension-popup-browser. + // Switching to a document should prompt screen readers to enter "browse + // mode" and allow the user to navigate the dialog content. + // NOTE: We could set the focus to the first focusable child within the + // document, but this would usually be the "New circuit" button, which would + // skip over the rest of the document content. this.panel.addEventListener("popupshown", event => { if (event.target !== this.panel) { return; } - this.panel.focus(); + this._panelElements.doc.focus(); }); // this.toolbarButton follows "identity-button" markup, so is a <xul:box> View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/facc9a2… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/facc9a2… You're receiving this email because of your account on gitlab.torproject.org.
1 0
0 0
[Git][tpo/applications/tor-browser][tor-browser-128.4.0esr-14.5-1] 2 commits: fixup! Bug 30237: Add v3 onion services client authentication prompt
by morgan (@morgan) 13 Nov '24

13 Nov '24
morgan pushed to branch tor-browser-128.4.0esr-14.5-1 at The Tor Project / Applications / Tor Browser Commits: a83dddb9 by Henry Wilkes at 2024-11-13T19:54:08+00:00 fixup! Bug 30237: Add v3 onion services client authentication prompt Bug 43263: Add some alert semantics for onion site keys. Also use `spoof-button-disabled` to better manage focus for temporarily disabled buttons. - - - - - 2073c1fa by Henry Wilkes at 2024-11-13T19:54:08+00:00 fixup! Bug 31286: Implementation of bridge, proxy, and firewall settings in about:preferences#connection Bug 43263: Update `spoof-button-disabled` buttons to use tabIndex=-1. Also remove aria-live=&quot;assertive&quot; from role=&quot;alert&quot; since it should already be implied by default. - - - - - 10 changed files: - browser/components/onionservices/content/authPopup.inc.xhtml - browser/components/onionservices/content/authPreferences.css - browser/components/onionservices/content/authPrompt.js - browser/components/onionservices/content/savedKeysDialog.js - browser/components/onionservices/content/savedKeysDialog.xhtml - browser/components/torpreferences/content/connectionPane.js - browser/components/torpreferences/content/loxInviteDialog.js - browser/components/torpreferences/content/provideBridgeDialog.js - browser/components/torpreferences/content/provideBridgeDialog.xhtml - browser/components/torpreferences/content/torPreferences.css Changes: ===================================== browser/components/onionservices/content/authPopup.inc.xhtml ===================================== @@ -11,12 +11,27 @@ data-l10n-id="onion-site-authentication-prompt-learn-more" /> <html:div> + <!-- NOTE: Orca 46.2 will not say "invalid" for "type=password". See + - https://gitlab.gnome.org/GNOME/orca/-/issues/550 + - Moreover, it will ignore the aria-errormessage relation when we are + - not in a document context. See related bugzilla bug 1820765. --> <html:input id="tor-clientauth-notification-key" type="password" data-l10n-id="onion-site-authentication-prompt-key-input" + aria-errormessage="tor-clientauth-warning" /> - <html:div id="tor-clientauth-warning"></html:div> + <html:div + id="tor-clientauth-warning" + role="alert" + aria-labelledby="tor-clientauth-warning-text" + > + <!-- NOTE: Orca 46.2 treats this notification as non-document context. + - As such it seems to only read out the alert content if it contains + - a <xul:label>, <html:label> or if it has an accessible name. + - We use aria-labelledby here. --> + <html:span id="tor-clientauth-warning-text"></html:span> + </html:div> <checkbox id="tor-clientauth-persistkey-checkbox" data-l10n-id="onion-site-authentication-prompt-remember-checkbox" ===================================== browser/components/onionservices/content/authPreferences.css ===================================== @@ -23,3 +23,15 @@ -moz-context-properties: fill; fill: var(--in-content-warning-icon-color); } + +/* Make a button appear disabled, whilst still allowing it to keep keyboard + * focus. + * Duplicate of rule in torPreferences.css. + * TODO: Replace with moz-button when it handles this for us. See + * tor-browser#43275. */ +button.spoof-button-disabled { + /* Borrow the :disabled rule from common-shared.css */ + opacity: 0.4; + /* Also ensure it does not get hover or active styling. */ + pointer-events: none; +} ===================================== browser/components/onionservices/content/authPrompt.js ===================================== @@ -32,6 +32,8 @@ var OnionAuthPrompt = { /** * The currently shown details in the prompt. + * + * @type {?PromptDetails} */ _shownDetails: null, @@ -264,16 +266,18 @@ var OnionAuthPrompt = { */ _showWarning(warningMessageId) { this._logger.debug(`Showing warning: ${warningMessageId}`); + if (warningMessageId) { - document.l10n.setAttributes(this._warningEl, warningMessageId); + document.l10n.setAttributes(this._warningTextEl, warningMessageId); this._warningEl.removeAttribute("hidden"); this._keyInput.classList.add("invalid"); + this._keyInput.setAttribute("aria-invalid", "true"); } else { - // Clean up. - this._warningEl.removeAttribute("data-l10n-id"); - this._warningEl.textContent = ""; + this._warningTextEl.removeAttribute("data-l10n-id"); + this._warningTextEl.textContent = ""; this._warningEl.setAttribute("hidden", "true"); this._keyInput.classList.remove("invalid"); + this._keyInput.removeAttribute("aria-invalid"); } }, @@ -344,6 +348,9 @@ var OnionAuthPrompt = { "tor-clientauth-persistkey-checkbox" ); this._warningEl = document.getElementById("tor-clientauth-warning"); + this._warningTextEl = document.getElementById( + "tor-clientauth-warning-text" + ); this._descriptionEl = document.getElementById( "tor-clientauth-notification-desc" ); ===================================== browser/components/onionservices/content/savedKeysDialog.js ===================================== @@ -14,6 +14,20 @@ var gOnionServicesSavedKeysDialog = { return this._busyCount > 0; }, + /** + * Whether the "remove selected" button is disabled. + * + * @type {boolean} + */ + _removeSelectedDisabled: true, + + /** + * Whether the "remove all" button is disabled. + * + * @type {boolean} + */ + _removeAllDisabled: true, + async _deleteSelectedKeys() { this._showError(null); this._withBusy(async () => { @@ -36,6 +50,15 @@ var gOnionServicesSavedKeysDialog = { for (let i = indexesToDelete.length - 1; i >= 0; --i) { await this._deleteOneKey(provider, indexesToDelete[i]); } + // If successful and the user focus is still on the buttons move focus + // to the table with the updated state. We do this before calling + // _updateButtonState and potentially making the buttons disabled. + if ( + this._removeButton.contains(document.activeElement) || + this._removeAllButton.contains(document.activeElement) + ) { + this._tree.focus(); + } } catch (e) { console.error("Removing a saved key failed", e); this._showError( @@ -51,10 +74,37 @@ var gOnionServicesSavedKeysDialog = { await this._deleteSelectedKeys(); }, + /** + * Show the given button as being disabled or enabled. + * + * @param {Button} button - The button to change. + * @param {boolean} disable - Whether to show the button as disabled or + * enabled. + */ + _disableButton(button, disable) { + // If we are disabled we show the button as disabled, and we also remove it + // from the tab focus cycle using `tabIndex = -1`. + // This is similar to using the `disabled` attribute, except that + // `tabIndex = -1` still allows the button to be focusable. I.e. not part of + // the focus cycle but can *keep* existing focus when the button becomes + // disabled to avoid loosing focus to the top of the dialog. + // TODO: Replace with moz-button when it handles this for us. See + // tor-browser#43275. + button.classList.toggle("spoof-button-disabled", disable); + button.tabIndex = disable ? -1 : 0; + if (disable) { + this._removeButton.setAttribute("aria-disabled", "true"); + } else { + this._removeButton.removeAttribute("aria-disabled"); + } + }, + _updateButtonsState() { const haveSelection = this._tree.view.selection.getRangeCount() > 0; - this._removeButton.disabled = this._isBusy || !haveSelection; - this._removeAllButton.disabled = this._isBusy || this.rowCount === 0; + this._removeSelectedDisabled = this._isBusy || !haveSelection; + this._removeAllDisabled = this._isBusy || this.rowCount === 0; + this._disableButton(this._removeButton, this._removeSelectedDisabled); + this._disableButton(this._removeAllButton, this._removeAllDisabled); }, // Private functions. @@ -79,12 +129,18 @@ var gOnionServicesSavedKeysDialog = { "onionservices-savedkeys-remove" ); this._removeButton.addEventListener("click", () => { + if (this._removeSelectedDisabled) { + return; + } this._deleteSelectedKeys(); }); this._removeAllButton = document.getElementById( "onionservices-savedkeys-removeall" ); this._removeAllButton.addEventListener("click", () => { + if (this._removeAllDisabled) { + return; + } this._deleteAllKeys(); }); ===================================== browser/components/onionservices/content/savedKeysDialog.xhtml ===================================== @@ -49,7 +49,11 @@ </treecols> <treechildren /> </tree> - <hbox id="onionservices-savedkeys-errorContainer" align="center"> + <hbox + id="onionservices-savedkeys-errorContainer" + align="center" + role="alert" + > <image id="onionservices-savedkeys-errorIcon" /> <description id="onionservices-savedkeys-errorMessage" flex="1" /> </hbox> @@ -57,7 +61,6 @@ <hbox id="onionservices-savedkeys-buttons"> <html:button id="onionservices-savedkeys-remove" - disabled="true" data-l10n-id="onion-site-saved-keys-dialog-remove-button" ></html:button> <html:button ===================================== browser/components/torpreferences/content/connectionPane.js ===================================== @@ -2354,8 +2354,11 @@ const gNetworkStatus = { this._internetTestDisabled = true; // We use "aria-disabled" rather than the "disabled" attribute so that the // button can remain focusable during the test. + // TODO: Replace with moz-button when it handles this for us. See + // tor-browser#43275. this._internetTestButton.setAttribute("aria-disabled", "true"); this._internetTestButton.classList.add("spoof-button-disabled"); + this._internetTestButton.tabIndex = -1; try { this._updateInternetStatus("testing"); const mrpc = new MoatRPC(); @@ -2376,6 +2379,7 @@ const gNetworkStatus = { } finally { this._internetTestButton.removeAttribute("aria-disabled"); this._internetTestButton.classList.remove("spoof-button-disabled"); + this._internetTestButton.tabIndex = 0; this._internetTestDisabled = false; } }, ===================================== browser/components/torpreferences/content/loxInviteDialog.js ===================================== @@ -255,15 +255,11 @@ const gLoxInvites = { // When generating we use "aria-disabled" rather than the "disabled" // attribute so that the button can remain focusable whilst we generate // invites. - // NOTE: When we generate the invite the focus will move to the invite list, - // so it should be safe to make the button non-focusable in this case. - const spoofDisabled = this._generating; - this._generateButton.disabled = disabled && !spoofDisabled; - this._generateButton.classList.toggle( - "spoof-button-disabled", - spoofDisabled - ); - if (spoofDisabled) { + // TODO: Replace with moz-button when it handles this for us. See + // tor-browser#43275. + this._generateButton.classList.toggle("spoof-button-disabled", disabled); + this._generateButton.tabIndex = disabled ? -1 : 0; + if (disabled) { this._generateButton.setAttribute("aria-disabled", "true"); } else { this._generateButton.removeAttribute("aria-disabled"); ===================================== browser/components/torpreferences/content/provideBridgeDialog.js ===================================== @@ -215,7 +215,10 @@ const gProvideBridgeDialog = { this._acceptDisabled = disabled; // Spoof the button to look and act as if it is disabled, but still allow // keyboard focus so the user can sit on this button whilst we are loading. + // TODO: Replace with moz-button when it handles this for us. See + // tor-browser#43275. this._acceptButton.classList.toggle("spoof-button-disabled", disabled); + this._acceptButton.tabIndex = disabled ? -1 : 0; if (disabled) { this._acceptButton.setAttribute("aria-disabled", "true"); } else { ===================================== browser/components/torpreferences/content/provideBridgeDialog.xhtml ===================================== @@ -55,7 +55,6 @@ <html:span id="user-provide-bridge-error-message" role="alert" - aria-live="assertive" ></html:span> <img id="user-provide-bridge-loading-icon" ===================================== browser/components/torpreferences/content/torPreferences.css ===================================== @@ -6,7 +6,9 @@ } /* Make a button appear disabled, whilst still allowing it to keep keyboard - * focus. */ + * focus. + * TODO: Replace with moz-button when it handles this for us. See + * tor-browser#43275. */ button.spoof-button-disabled { /* Borrow the :disabled rule from common-shared.css */ opacity: 0.4; View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/compare/b66037… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/compare/b66037… You're receiving this email because of your account on gitlab.torproject.org.
1 0
0 0
[Git][tpo/applications/mullvad-browser][mullvad-browser-128.4.0esr-14.5-1] fixup! Firefox preference overrides.
by morgan (@morgan) 13 Nov '24

13 Nov '24
morgan pushed to branch mullvad-browser-128.4.0esr-14.5-1 at The Tor Project / Applications / Mullvad Browser Commits: b518f02a by Pier Angelo Vendrame at 2024-11-13T19:50:58+00:00 fixup! Firefox preference overrides. Bug 43165: Disable Microsoft SSO on macOS. - - - - - 1 changed file: - browser/app/profile/001-base-profile.js Changes: ===================================== browser/app/profile/001-base-profile.js ===================================== @@ -455,6 +455,9 @@ pref("network.http.referer.defaultPolicy.pbmode", 2); pref("network.http.referer.XOriginTrimmingPolicy", 2); // Bug 17228: Force trim referer to scheme+host+port in cross-origin requests // Bug 40463: Disable Windows SSO pref("network.http.windows-sso.enabled", false, locked); +// Bug 43165: Disable Microsoft SSO on macOS +pref("network.http.microsoft-entra-sso.enabled", false); +pref("network.microsoft-sso-authority-list", ""); // tor-browser#40424 pref("pdfjs.enableScripting", false); #if MOZ_UPDATE_CHANNEL == release View it on GitLab: https://gitlab.torproject.org/tpo/applications/mullvad-browser/-/commit/b51… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/mullvad-browser/-/commit/b51… You're receiving this email because of your account on gitlab.torproject.org.
1 0
0 0
[Git][tpo/applications/mullvad-browser][mullvad-browser-128.4.0esr-14.0-1] fixup! Firefox preference overrides.
by morgan (@morgan) 13 Nov '24

13 Nov '24
morgan pushed to branch mullvad-browser-128.4.0esr-14.0-1 at The Tor Project / Applications / Mullvad Browser Commits: 3850c827 by Pier Angelo Vendrame at 2024-11-13T19:50:20+00:00 fixup! Firefox preference overrides. Bug 43165: Disable Microsoft SSO on macOS. - - - - - 1 changed file: - browser/app/profile/001-base-profile.js Changes: ===================================== browser/app/profile/001-base-profile.js ===================================== @@ -447,6 +447,9 @@ pref("network.http.referer.defaultPolicy.pbmode", 2); pref("network.http.referer.XOriginTrimmingPolicy", 2); // Bug 17228: Force trim referer to scheme+host+port in cross-origin requests // Bug 40463: Disable Windows SSO pref("network.http.windows-sso.enabled", false, locked); +// Bug 43165: Disable Microsoft SSO on macOS +pref("network.http.microsoft-entra-sso.enabled", false); +pref("network.microsoft-sso-authority-list", ""); // tor-browser#40424 pref("pdfjs.enableScripting", false); #if MOZ_UPDATE_CHANNEL == release View it on GitLab: https://gitlab.torproject.org/tpo/applications/mullvad-browser/-/commit/385… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/mullvad-browser/-/commit/385… You're receiving this email because of your account on gitlab.torproject.org.
1 0
0 0
[Git][tpo/applications/tor-browser][tor-browser-128.4.0esr-14.0-1] fixup! Firefox preference overrides.
by morgan (@morgan) 13 Nov '24

13 Nov '24
morgan pushed to branch tor-browser-128.4.0esr-14.0-1 at The Tor Project / Applications / Tor Browser Commits: 47f93bf5 by Pier Angelo Vendrame at 2024-11-13T19:48:31+00:00 fixup! Firefox preference overrides. Bug 43165: Disable Microsoft SSO on macOS. - - - - - 1 changed file: - browser/app/profile/001-base-profile.js Changes: ===================================== browser/app/profile/001-base-profile.js ===================================== @@ -447,6 +447,9 @@ pref("network.http.referer.defaultPolicy.pbmode", 2); pref("network.http.referer.XOriginTrimmingPolicy", 2); // Bug 17228: Force trim referer to scheme+host+port in cross-origin requests // Bug 40463: Disable Windows SSO pref("network.http.windows-sso.enabled", false, locked); +// Bug 43165: Disable Microsoft SSO on macOS +pref("network.http.microsoft-entra-sso.enabled", false); +pref("network.microsoft-sso-authority-list", ""); // tor-browser#40424 pref("pdfjs.enableScripting", false); #if MOZ_UPDATE_CHANNEL == release View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/47f93bf… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/47f93bf… You're receiving this email because of your account on gitlab.torproject.org.
1 0
0 0
[Git][tpo/applications/tor-browser][base-browser-128.4.0esr-14.0-1] fixup! Firefox preference overrides.
by morgan (@morgan) 13 Nov '24

13 Nov '24
morgan pushed to branch base-browser-128.4.0esr-14.0-1 at The Tor Project / Applications / Tor Browser Commits: ccf8f463 by Pier Angelo Vendrame at 2024-11-13T19:49:07+00:00 fixup! Firefox preference overrides. Bug 43165: Disable Microsoft SSO on macOS. - - - - - 1 changed file: - browser/app/profile/001-base-profile.js Changes: ===================================== browser/app/profile/001-base-profile.js ===================================== @@ -447,6 +447,9 @@ pref("network.http.referer.defaultPolicy.pbmode", 2); pref("network.http.referer.XOriginTrimmingPolicy", 2); // Bug 17228: Force trim referer to scheme+host+port in cross-origin requests // Bug 40463: Disable Windows SSO pref("network.http.windows-sso.enabled", false, locked); +// Bug 43165: Disable Microsoft SSO on macOS +pref("network.http.microsoft-entra-sso.enabled", false); +pref("network.microsoft-sso-authority-list", ""); // tor-browser#40424 pref("pdfjs.enableScripting", false); #if MOZ_UPDATE_CHANNEL == release View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/ccf8f46… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/ccf8f46… You're receiving this email because of your account on gitlab.torproject.org.
1 0
0 0
[Git][tpo/applications/tor-browser][base-browser-128.4.0esr-14.5-1] fixup! Firefox preference overrides.
by morgan (@morgan) 13 Nov '24

13 Nov '24
morgan pushed to branch base-browser-128.4.0esr-14.5-1 at The Tor Project / Applications / Tor Browser Commits: 729f901e by Pier Angelo Vendrame at 2024-11-13T19:47:49+00:00 fixup! Firefox preference overrides. Bug 43165: Disable Microsoft SSO on macOS. - - - - - 1 changed file: - browser/app/profile/001-base-profile.js Changes: ===================================== browser/app/profile/001-base-profile.js ===================================== @@ -455,6 +455,9 @@ pref("network.http.referer.defaultPolicy.pbmode", 2); pref("network.http.referer.XOriginTrimmingPolicy", 2); // Bug 17228: Force trim referer to scheme+host+port in cross-origin requests // Bug 40463: Disable Windows SSO pref("network.http.windows-sso.enabled", false, locked); +// Bug 43165: Disable Microsoft SSO on macOS +pref("network.http.microsoft-entra-sso.enabled", false); +pref("network.microsoft-sso-authority-list", ""); // tor-browser#40424 pref("pdfjs.enableScripting", false); #if MOZ_UPDATE_CHANNEL == release View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/729f901… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/729f901… You're receiving this email because of your account on gitlab.torproject.org.
1 0
0 0
  • ← Newer
  • 1
  • ...
  • 118
  • 119
  • 120
  • 121
  • 122
  • 123
  • 124
  • ...
  • 1859
  • Older →

HyperKitty Powered by HyperKitty version 1.3.12.