March 2025 - tbb-commits - lists.torproject.org

[Git][tpo/applications/tor-browser][base-browser-128.8.0esr-14.5-1] fixup! BB 41631: Prevent weird initial window dimensions caused by subpixel computations
by Pier Angelo Vendrame (＠pierov) 17 Mar '25

17 Mar '25

Pier Angelo Vendrame pushed to branch base-browser-128.8.0esr-14.5-1 at The Tor Project / Applications / Tor Browser Commits: 23e53d28 by Pier Angelo Vendrame at 2025-03-17T21:08:55+01:00 fixup! BB 41631: Prevent weird initial window dimensions caused by subpixel computations BB 42670: Sometimes LB is applied even when disabled. - - - - - 1 changed file: - toolkit/components/resistfingerprinting/RFPHelper.sys.mjs Changes: ===================================== toolkit/components/… [View More]

1 0

[Git][tpo/applications/mullvad-browser][mullvad-browser-128.8.0esr-14.5-1] fixup! BB 41631: Prevent weird initial window dimensions caused by subpixel computations
by Pier Angelo Vendrame (＠pierov) 17 Mar '25

17 Mar '25

Pier Angelo Vendrame pushed to branch mullvad-browser-128.8.0esr-14.5-1 at The Tor Project / Applications / Mullvad Browser Commits: a8407f55 by Pier Angelo Vendrame at 2025-03-17T21:08:16+01:00 fixup! BB 41631: Prevent weird initial window dimensions caused by subpixel computations BB 42670: Sometimes LB is applied even when disabled. - - - - - 1 changed file: - toolkit/components/resistfingerprinting/RFPHelper.sys.mjs Changes: ===================================== toolkit/components/… [View More]

1 0

[Git][tpo/applications/tor-browser-bundle-testsuite][main] Bug 40084: Add browser-single-platform target to Mullvad/Tor Browser nightly builds
by morgan (＠morgan) 17 Mar '25

17 Mar '25

morgan pushed to branch main at The Tor Project / Applications / tor-browser-bundle-testsuite Commits: 4299c5eb by Nicolas Vigier at 2025-03-12T19:42:29+01:00 Bug 40084: Add browser-single-platform target to Mullvad/Tor Browser nightly builds With the changes from tor-browser-build#41040, the `browser-single-platform` target is needed when building a single platform. - - - - - 1 changed file: - TBBTestSuite/TestSuite/TorBrowserBuild.pm Changes: ===================================== … [View More]TBBTestSuite/TestSuite/TorBrowserBuild.pm ===================================== @@ -36,6 +36,7 @@ sub set_tests { targets => [ 'noversiondir', 'nightly', + 'browser-single-platform', 'browser-linux-x86_64', 'torbrowser', ], @@ -56,6 +57,7 @@ sub set_tests { targets => [ 'noversiondir', 'nightly', + 'browser-single-platform', 'browser-linux-i686', 'torbrowser', ], @@ -76,6 +78,7 @@ sub set_tests { targets => [ 'noversiondir', 'nightly', + 'browser-single-platform', 'browser-linux-aarch64', 'torbrowser', ], @@ -96,6 +99,7 @@ sub set_tests { targets => [ 'noversiondir', 'nightly', + 'browser-single-platform', 'browser-windows-i686', 'torbrowser', ], @@ -116,6 +120,7 @@ sub set_tests { targets => [ 'noversiondir', 'nightly', + 'browser-single-platform', 'browser-windows-x86_64', 'torbrowser', ], @@ -136,6 +141,7 @@ sub set_tests { targets => [ 'noversiondir', 'nightly', + 'browser-single-platform', 'browser-macos', 'torbrowser', ], @@ -156,6 +162,7 @@ sub set_tests { targets => [ 'noversiondir', 'nightly', + 'browser-single-platform', 'browser-android-armv7', 'torbrowser', ], @@ -169,6 +176,7 @@ sub set_tests { targets => [ 'noversiondir', 'nightly', + 'browser-single-platform', 'browser-android-x86', 'torbrowser', ], @@ -182,6 +190,7 @@ sub set_tests { targets => [ 'noversiondir', 'nightly', + 'browser-single-platform', 'browser-android-x86_64', 'torbrowser', ], @@ -195,6 +204,7 @@ sub set_tests { targets => [ 'noversiondir', 'nightly', + 'browser-single-platform', 'browser-android-aarch64', 'torbrowser', ], @@ -209,6 +219,7 @@ sub set_tests { targets => [ 'noversiondir', 'nightly', + 'browser-single-platform', 'browser-linux-x86_64', 'mullvadbrowser', ], @@ -229,6 +240,7 @@ sub set_tests { targets => [ 'noversiondir', 'nightly', + 'browser-single-platform', 'browser-linux-aarch64', 'mullvadbrowser', ], @@ -249,6 +261,7 @@ sub set_tests { targets => [ 'noversiondir', 'nightly', + 'browser-single-platform', 'browser-windows-x86_64', 'mullvadbrowser', ], @@ -269,6 +282,7 @@ sub set_tests { targets => [ 'noversiondir', 'nightly', + 'browser-single-platform', 'browser-macos', 'mullvadbrowser', ], View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-bundle-testsuite… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-bundle-testsuite… You're receiving this email because of your account on gitlab.torproject.org. [View Less]

1 0

[Git][tpo/applications/tor-browser][tor-browser-128.8.0esr-14.5-1] fixup! BB 41631: Prevent weird initial window dimensions caused by subpixel computations
by Pier Angelo Vendrame (＠pierov) 17 Mar '25

17 Mar '25

Pier Angelo Vendrame pushed to branch tor-browser-128.8.0esr-14.5-1 at The Tor Project / Applications / Tor Browser Commits: f5c2815d by Pier Angelo Vendrame at 2025-03-17T19:13:24+01:00 fixup! BB 41631: Prevent weird initial window dimensions caused by subpixel computations BB 42670: Sometimes LB is applied even when disabled. - - - - - 1 changed file: - toolkit/components/resistfingerprinting/RFPHelper.sys.mjs Changes: ===================================== toolkit/components/… [View More]

1 0

[Git][tpo/applications/tor-browser-build][main] 4 commits: Bug 41389: Remove `\` mistakenly added in the middle of a line.
by morgan (＠morgan) 17 Mar '25

17 Mar '25

morgan pushed to branch main at The Tor Project / Applications / tor-browser-build Commits: 5752074b by Nicolas Vigier at 2025-03-17T19:46:58+00:00 Bug 41389: Remove `\` mistakenly added in the middle of a line. Fixup for 810e8e207b5e4f568c25c3b3817873fa11684606. - - - - - 181c3a6a by Nicolas Vigier at 2025-03-17T19:46:58+00:00 Bug 41389: tbb_version_build is now `buildN` instead of `N`. Fixup for 810e8e207b5e4f568c25c3b3817873fa11684606. - - - - - ecd7d21b by Nicolas Vigier at 2025-03-… [View More]17T19:46:58+00:00 Bug 41389: don't generate config in staticiforme-prepare-cdn-dist-upload staticiforme-prepare-cdn-dist-upload is being run on staticiforme, so configuration should not be generated from rbm. Fixup for 4c29020e99aac0d2a06b6ca9b9a3b17e04c7f3de. - - - - - ca6a15eb by Nicolas Vigier at 2025-03-17T19:46:58+00:00 Bug 41394: Don't try to add download-android-*.json files for Mullvad Browser - - - - - 6 changed files: - tools/signing/download-unsigned-sha256sums-gpg-signatures-from-people-tpo - tools/signing/functions - tools/signing/staticiforme-prepare-cdn-dist-upload - tools/signing/sync-builder-unsigned-to-local-signed - tools/signing/upload-update_responses-to-staticiforme - tools/signing/wait-for-finished-build Changes: ===================================== tools/signing/download-unsigned-sha256sums-gpg-signatures-from-people-tpo ===================================== @@ -11,14 +11,14 @@ do chmod 644 "$tmpfile" if test "$builder" = 'jb'; then file="$file.gpg" - urls=("https://cdn.stagemole.eu/hashes/$SIGNING_PROJECTNAME/$tbb_version-build$tbb…") + urls=("https://cdn.stagemole.eu/hashes/$SIGNING_PROJECTNAME/$tbb_version-$tbb_vers…") else file="$file.asc" urls=( \ - "https://people.torproject.org/~$builder/builds/$SIGNING_PROJECTNAME/$tbb_ve…" \ - "https://people.torproject.org/~$builder/builds/$SIGNING_PROJECTNAME/$tbb_ve…" \ - "https://tb-build-02.torproject.org/~$builder/builds/$SIGNING_PROJECTNAME/$t…" \ - "https://tb-build-03.torproject.org/~$builder/builds/$SIGNING_PROJECTNAME/$t…" \ + "https://people.torproject.org/~$builder/builds/$SIGNING_PROJECTNAME/$tbb_ve…" \ + "https://people.torproject.org/~$builder/builds/$SIGNING_PROJECTNAME/$tbb_ve…" \ + "https://tb-build-02.torproject.org/~$builder/builds/$SIGNING_PROJECTNAME/$t…" \ + "https://tb-build-03.torproject.org/~$builder/builds/$SIGNING_PROJECTNAME/$t…" \ ) fi for url in "${urls[@]}" ===================================== tools/signing/functions ===================================== @@ -40,7 +40,7 @@ function generate_config { "$SIGNING_PROJECTNAME" --target "$tbb_version_type") echo "SIGNING_PROJECTNAMES=(\"$p1\" \"$p2\" \"$p3\" \"$p4\")" > \ "$script_dir/set-config.generated-config" - local tbb_version_type=$("$rbm" showconf browser \ var/browser_default_channel \ + local tbb_version_type=$("$rbm" showconf browser var/browser_default_channel \ --target "$SIGNING_PROJECTNAME") local tbb_version=$("$rbm" showconf browser var/torbrowser_version \ --target "$SIGNING_PROJECTNAME" --target \ ===================================== tools/signing/staticiforme-prepare-cdn-dist-upload ===================================== @@ -1,5 +1,6 @@ #!/bin/bash set -e +no_generate_config=1 script_dir=$( cd -- "$( dirname -- "${BASH_SOURCE[0]}" )" &> /dev/null && pwd ) source "$script_dir/functions" ===================================== tools/signing/sync-builder-unsigned-to-local-signed ===================================== @@ -5,4 +5,4 @@ source "$script_dir/functions" var_is_defined ssh_host_builder builder_tor_browser_build_dir -rsync $rsync_options "$ssh_host_builder:$builder_tor_browser_build_dir/$SIGNING_PROJECTNAME/$tbb_version_type/unsigned/$tbb_version-build$tbb_version_build/" "$signed_version_dir/" +rsync $rsync_options "$ssh_host_builder:$builder_tor_browser_build_dir/$SIGNING_PROJECTNAME/$tbb_version_type/unsigned/$tbb_version-$tbb_version_build/" "$signed_version_dir/" ===================================== tools/signing/upload-update_responses-to-staticiforme ===================================== @@ -56,9 +56,11 @@ do git commit -m "$tbb_version_type: new version, $tbb_version ($file)" done -git add "$tbb_version_type"/download-android-*.json -git diff --quiet --cached --exit-code || \ - git commit -m "$tbb_version_type: new version, $tbb_version (android)" +if is_project torbrowser; then + git add "$tbb_version_type"/download-android-*.json + git diff --quiet --cached --exit-code || \ + git commit -m "$tbb_version_type: new version, $tbb_version (android)" +fi git add "$tbb_version_type" git diff --quiet --cached --exit-code || \ ===================================== tools/signing/wait-for-finished-build ===================================== @@ -14,7 +14,7 @@ var_is_defined ssh_host_builder builder_tor_browser_build_dir while true do - ssh "$ssh_host_builder" test -f "$builder_tor_browser_build_dir/$SIGNING_PROJECTNAME/$tbb_version_type/unsigned/$tbb_version-build$tbb_version_build/sha256sums-unsigned-build.incrementals.txt" && \ + ssh "$ssh_host_builder" test -f "$builder_tor_browser_build_dir/$SIGNING_PROJECTNAME/$tbb_version_type/unsigned/$tbb_version-$tbb_version_build/sha256sums-unsigned-build.incrementals.txt" && \ exit 0 echo "$(date -Iseconds): Waiting for build to finish..." sleep 5m View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/compare/… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/compare/… You're receiving this email because of your account on gitlab.torproject.org. [View Less]

1 0

[Git][tpo/applications/tor-browser][tor-browser-128.8.0esr-14.5-1] fixup! [android] TBA strings
by Dan Ballard (＠dan) 17 Mar '25

17 Mar '25

Dan Ballard pushed to branch tor-browser-128.8.0esr-14.5-1 at The Tor Project / Applications / Tor Browser Commits: 642c18d0 by Henry Wilkes at 2025-03-17T10:17:33+00:00 fixup! [android] TBA strings TB 43091: Remove unused android strings. - - - - - 1 changed file: - mobile/android/fenix/app/src/main/res/values/torbrowser_strings.xml Changes: ===================================== mobile/android/fenix/app/src/main/res/values/torbrowser_strings.xml ===================================== @… [View More]@ -5,26 +5,12 @@  <string name="tor_about_content">%1$s is produced by the Tor Project, a U.S.-based 501(c)(3) nonprofit.</string> -  - <string name="preferences_disable_normal_mode">Allow Only Private Browsing Mode</string>  <string name="preferences_donate">Donate to The Tor Project</string>  <string name="preferences_allow_screenshots">Allow screenshots</string> <string name="tor_bootstrap_connect">Connect</string> - <string name="tor_bootstrap_connecting">Connecting</string> - <string name="tor_bootstrap_connecting_failed">Connecting Failed</string> - <string name="tor_bootstrap_swipe_for_logs">Swipe to the left to see Tor logs</string> - <string name="tor_initializing_log">Initializing Tor Log</string> - - <string name="tor_onboarding_security_level">Set your Security Level</string> - <string name="tor_onboarding_security_level_description">Disable certain web features that can be used to attack you, and harm your security, anonymity, and privacy.</string> - <string name="tor_onboarding_chosen_security_level_label">Current Security Level: %s</string> - <string name="tor_onboarding_security_settings_button">Open Security Settings</string> - <string name="tor_onboarding_donate_header">Donate and keep Tor safe</string> - <string name="tor_onboarding_donate_description">Tor is free to use because of donations from people like you.</string> - <string name="tor_onboarding_donate_button">Donate Now</string> <string name="tor_explore_privately">Explore. Privately.</string> @@ -34,8 +20,6 @@ <string name="preferences_tor_network_settings_explanation">Tor Browser routes your traffic over the Tor network, run by thousands of volunteers around the world.</string> <string name="preferences_tor_network_settings_bridge_config">Config Bridge</string> <string name="preferences_tor_network_settings_bridge_config_description">Use a Bridge to connect to Tor</string> - <string name="preferences_tor_network_settings_bridge_config_description_builtin_transport_enabled">You’re using a built-in bridge to connect to Tor</string> - <string name="preferences_tor_network_settings_bridge_config_description_user_provided_enabled">You provided a bridge to connect to Tor</string> <string name="preferences_tor_network_settings_bridge_config_explanation">Bridges are unlisted relays that make it more difficult to block connections to the Tor network. Because of how certain countries try to block Tor, certain bridges work in certain countries but not others.</string> <string name="preferences_tor_network_settings_bridge_config_toggle">Use a Bridge</string> <string name="preferences_tor_network_settings_bridge_config_toggle_description">Config a bridge to connect to Tor</string> @@ -46,21 +30,9 @@ <string name="preferences_tor_network_settings_bridge_config_user_provided_bridge_description">Enter bridge information from a trusted source</string> <string name="preferences_tor_network_settings_bridge_config_current_bridge">Current Configured Bridge: %s</string> <string name="tor_network_settings_bridge_not_configured">Not Configured</string> - <string name="preferences_tor_network_settings_status">Current Status</string> - <string name="preferences_tor_network_settings_tor_ready">Is Tor Ready: %s</string> - <string name="preferences_tor_network_settings_state">State: %s</string> - <string name="preferences_tor_network_settings_yes">Yes</string> - <string name="preferences_tor_network_settings_no">No</string> - <string name="preferences_tor_network_settings_disconnected">Disconnected</string> - <string name="preferences_tor_network_settings_connecting">Connecting</string> - <string name="preferences_tor_network_settings_connected">Connected</string> - <string name="preferences_tor_network_settings_restarting">Restarting</string> - <string name="preferences_tor_network_settings_bridges_enabled">Bridges are enabled: %s</string> <string name="preferences_tor_logs">Tor Logs</string> <string name="preferences_tor_logs_description">View and copy your Tor logs</string> -  - <string name="preferences_tor_security_level_settings">Security Settings</string> <string name="preferences_tor_security_level_options">Security Level</string>  View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/642c18d… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/642c18d… You're receiving this email because of your account on gitlab.torproject.org. [View Less]

1 0

[Git][tpo/applications/tor-browser-build][main] 2 commits: Update the Tor Browser Stable release-prep template to notify Tails devs...
by morgan (＠morgan) 17 Mar '25

17 Mar '25

morgan pushed to branch main at The Tor Project / Applications / tor-browser-build Commits: 2356d9d7 by Morgan at 2025-03-17T13:54:18+00:00 Update the Tor Browser Stable release-prep template to notify Tails devs earlier in the release process - - - - - fe816f62 by Morgan at 2025-03-17T13:56:36+00:00 Update release-prep templates with updated devmole build notes - - - - - 5 changed files: - .gitlab/issue_templates/Release Prep - Mullvad Browser Alpha.md - .gitlab/issue_templates/Release … [View More]Prep - Mullvad Browser Stable.md - .gitlab/issue_templates/Release Prep - Tor Browser Alpha.md - .gitlab/issue_templates/Release Prep - Tor Browser Legacy.md - .gitlab/issue_templates/Release Prep - Tor Browser Stable.md Changes: ===================================== .gitlab/issue_templates/Release Prep - Mullvad Browser Alpha.md ===================================== @@ -117,8 +117,7 @@ Mullvad Browser Alpha (and Nightly) are on the `main` branch - [ ] Tor Project build machine - [ ] Local developer machine - [ ] Submit build request to Mullvad infrastructure: - - **NOTE** this requires a devmole authentication token - - **NOTE** this also requires you be connected to Gothenburg Mulvad VPN exit `se-got-wg-101` + - **NOTE** this requires a github authentication token - Run: ```bash make mullvadbrowser-kick-devmole-build ===================================== .gitlab/issue_templates/Release Prep - Mullvad Browser Stable.md ===================================== @@ -113,11 +113,10 @@ Mullvad Browser Stable is on the `maint-${MULLVAD_BROWSER_MAJOR}.${MULLVAD_BROWS ```bash make mullvadbrowser-release && make mullvadbrowser-incrementals-release ``` - - Tor Project build machine - - Local developer machine + - [ ] Tor Project build machine + - [ ] Local developer machine - [ ] Submit build request to Mullvad infrastructure: - - **NOTE** this requires a devmole authentication token - - **NOTE** this also requires you be connected to Gothenburg Mulvad VPN exit `se-got-wg-101` + - **NOTE** this requires a github authentication token - Run: ```bash make mullvadbrowser-kick-devmole-build ===================================== .gitlab/issue_templates/Release Prep - Tor Browser Alpha.md ===================================== @@ -141,8 +141,7 @@ Tor Browser Alpha (and Nightly) are on the `main` branch - [ ] Tor Project build machine - [ ] Local developer machine - [ ] Submit build request to Mullvad infrastructure: - - **NOTE** this requires a devmole authentication token - - **NOTE** this also requires you be connected to Gothenburg Mulvad VPN exit `se-got-wg-101` + - **NOTE** this requires a github authentication token - Run: ```bash make torbrowser-kick-devmole-build ===================================== .gitlab/issue_templates/Release Prep - Tor Browser Legacy.md ===================================== @@ -133,8 +133,7 @@ Tor Browser Legacy is on the `maint-13.5` branch - [ ] Tor Project build machine - [ ] Local developer machine - [ ] Submit build request to Mullvad infrastructure: - - **NOTE** this requires a devmole authentication token - - **NOTE** this also requires you be connected to Gothenburg Mulvad VPN exit `se-got-wg-101` + - **NOTE** this requires a github authentication token - Run: ```bash make torbrowser-kick-devmole-build ===================================== .gitlab/issue_templates/Release Prep - Tor Browser Stable.md ===================================== @@ -142,12 +142,33 @@ Tor Browser Stable is on the `maint-${TOR_BROWSER_MAJOR}.${TOR_BROWSER_MINOR}` b - Tor Project build machine - Local developer machine - [ ] Submit build request to Mullvad infrastructure: - - **NOTE** this requires a devmole authentication token - - **NOTE** this also requires you be connected to Gothenburg Mulvad VPN exit `se-got-wg-101` + - **NOTE** this requires a github authentication token - Run: ```bash make torbrowser-kick-devmole-build ``` +- [ ] Notify Tails of pending builds + - **Recipients** + ``` + tails-dev(a)boum.org + ``` + - **Subject** + ``` + Tor Browser ${TOR_BROWSER_VERSION} Building + ``` + - **Body** + ``` + Hello, + + Tor Browser Stable is being built and should be ready for Tails in the coming hours. Build artifacts and hashes will be available here: + - ${BUILD_ARTIFACTS_URL} + - ${BUIDL_HASHES_URL} + + ⚠️ WARNING: We have not yet verified the builds match, so make sure you do so before prepping the Tails release! + + Changelog: + # paste changelog as quote here + ``` </details> @@ -321,14 +342,13 @@ popd ### packagers - [ ] Email packagers: - **Recipients** - - Tails dev mailing list: tails-dev(a)boum.org - Guardian Project: nathan(a)guardianproject.info - FreeBSD port: freebsd(a)sysctl.cz  - OpenBSD port: caspar(a)schutijser.com  - torbrowser-launcher: mail(a)asciiwolf.com  - Anti-Censorship: meskio(a)torproject.org  ``` - tails-dev(a)boum.org, nathan(a)guardianproject.info, freebsd(a)sysctl.cz, caspar(a)schutijser.com, mail(a)asciiwolf.com, meskio(a)torproject.org, + nathan(a)guardianproject.info, freebsd(a)sysctl.cz, caspar(a)schutijser.com, mail(a)asciiwolf.com, meskio(a)torproject.org, ``` - **Subject** ``` View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/compare/… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/compare/… You're receiving this email because of your account on gitlab.torproject.org. [View Less]

1 0

[Git][tpo/applications/tor-browser][tor-browser-128.8.0esr-14.5-1] 2 commits: fixup! [android] Implement Android-native Connection Assist UI
by clairehurst (＠clairehurst) 13 Mar '25

13 Mar '25

clairehurst pushed to branch tor-browser-128.8.0esr-14.5-1 at The Tor Project / Applications / Tor Browser Commits: d7dfb3f5 by clairehurst at 2025-03-13T15:41:50-06:00 fixup! [android] Implement Android-native Connection Assist UI tor-browser#43361 - - - - - ec07d29a by clairehurst at 2025-03-13T15:41:57-06:00 fixup! TB 41878: [android] Add standalone Tor Bootstrap tor-browser#43361 - - - - - 5 changed files: - mobile/android/fenix/app/src/main/java/org/mozilla/fenix/FenixApplication.… [View More]kt - mobile/android/fenix/app/src/main/java/org/mozilla/fenix/HomeActivity.kt - mobile/android/fenix/app/src/main/java/org/mozilla/fenix/home/HomeFragment.kt - mobile/android/fenix/app/src/main/java/org/mozilla/fenix/tor/TorConnectionAssistFragment.kt - mobile/android/fenix/app/src/main/java/org/mozilla/fenix/tor/TorConnectionAssistViewModel.kt Changes: ===================================== mobile/android/fenix/app/src/main/java/org/mozilla/fenix/FenixApplication.kt ===================================== @@ -137,8 +137,6 @@ open class FenixApplication : LocaleAwareApplication(), Provider { isDeviceRamAboveThreshold() } - var terminating = false - open val components by lazy { Components(this) } var visibilityLifecycleCallback: VisibilityLifecycleCallback? = null @@ -188,20 +186,6 @@ open class FenixApplication : LocaleAwareApplication(), Provider { } } - fun isTerminating() = terminating - - fun terminate() { - onTerminate() - } - - override fun onTerminate() { - terminating = true - - super.onTerminate() - components.torController.stop() - components.torController.stopTor() - } - @OptIn(DelicateCoroutinesApi::class) // GlobalScope usage @VisibleForTesting protected open fun initializeGlean() { ===================================== mobile/android/fenix/app/src/main/java/org/mozilla/fenix/HomeActivity.kt ===================================== @@ -158,6 +158,7 @@ import org.mozilla.fenix.home.HomeFragment import org.mozilla.fenix.tor.UrlQuickLoadViewModel import org.mozilla.geckoview.TorAndroidIntegration import org.mozilla.geckoview.TorConnectStage +import kotlin.system.exitProcess /** * The main activity of the application. The application is primarily a single Activity (this one) @@ -653,22 +654,6 @@ open class HomeActivity : LocaleAwareAppCompatActivity(), NavHostActivity, TorAn if (this !is ExternalAppBrowserActivity && !activityStartedWithLink) { stopMediaSession() } - - if (isFinishing && !(application as FenixApplication).isTerminating()) { - // We assume the Activity is being destroyed because the user - // swiped away the app on the Recent screen. When this happens, - // we assume the user expects the entire Application is destroyed - // and not only the top Activity/Task. Therefore we kill the - // underlying Application, as well. - (application as FenixApplication).terminate() - if (settings().useHtmlConnectionUi) { - val engine = components.core.engine - if (engine is GeckoEngine) { - val torIntegration = engine.getTorIntegrationController() - torIntegration.unregisterBootstrapStateChangeListener(this) - } - } - } } final override fun onConfigurationChanged(newConfig: Configuration) { @@ -1453,6 +1438,11 @@ open class HomeActivity : LocaleAwareAppCompatActivity(), NavHostActivity, TorAn private const val PWA_RECENTLY_USED_THRESHOLD = DateUtils.DAY_IN_MILLIS * 30L } + fun shutDown() : Nothing { + finishAndRemoveTask() + exitProcess(0) + } + override fun onBootstrapStateChange(state: String) = Unit override fun onBootstrapStageChange(stage: TorConnectStage) = Unit override fun onBootstrapProgress(progress: Double, hasWarnings: Boolean) = Unit ===================================== mobile/android/fenix/app/src/main/java/org/mozilla/fenix/home/HomeFragment.kt ===================================== @@ -1394,7 +1394,6 @@ class HomeFragment : Fragment(), UserInteractionHandler { } override fun onBackPressed(): Boolean { - requireActivity().finish() - return true + (requireActivity() as HomeActivity).shutDown() } } ===================================== mobile/android/fenix/app/src/main/java/org/mozilla/fenix/tor/TorConnectionAssistFragment.kt ===================================== @@ -149,7 +149,7 @@ class TorConnectionAssistFragment : Fragment(), UserInteractionHandler { private fun setBackButton(screen: ConnectAssistUiState) { binding.backButton.visibility = if (screen.backButtonVisible) View.VISIBLE else View.INVISIBLE binding.backButton.setOnClickListener { - torConnectionAssistViewModel.handleBackButtonPressed() + onBackPressed() } } @@ -314,7 +314,8 @@ class TorConnectionAssistFragment : Fragment(), UserInteractionHandler { } override fun onBackPressed(): Boolean { - return torConnectionAssistViewModel.handleBackButtonPressed() + torConnectionAssistViewModel.handleBackButtonPressed(requireActivity() as HomeActivity) + return true } } ===================================== mobile/android/fenix/app/src/main/java/org/mozilla/fenix/tor/TorConnectionAssistViewModel.kt ===================================== @@ -10,6 +10,7 @@ import androidx.lifecycle.AndroidViewModel import androidx.lifecycle.MutableLiveData import kotlinx.coroutines.flow.MutableStateFlow import kotlinx.coroutines.flow.StateFlow +import org.mozilla.fenix.HomeActivity import org.mozilla.fenix.ext.components class TorConnectionAssistViewModel( @@ -150,10 +151,10 @@ class TorConnectionAssistViewModel( return true } - fun handleBackButtonPressed(): Boolean { + fun handleBackButtonPressed(homeActivity: HomeActivity) { when (torConnectScreen.value) { - ConnectAssistUiState.Splash -> return false - ConnectAssistUiState.Configuring -> return false + ConnectAssistUiState.Splash -> homeActivity.shutDown() + ConnectAssistUiState.Configuring -> homeActivity.shutDown() ConnectAssistUiState.Connecting -> cancelTorBootstrap() ConnectAssistUiState.InternetError -> { _torController.lastKnownError = null @@ -191,6 +192,5 @@ class TorConnectionAssistViewModel( _torConnectScreen.value = ConnectAssistUiState.LocationCheck } } - return true } } View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/compare/da17f7… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/compare/da17f7… You're receiving this email because of your account on gitlab.torproject.org. [View Less]

1 0

[Git][tpo/applications/tor-browser][tor-browser-128.8.0esr-14.5-1] 4 commits: fixup! TB 42247: Android helpers for the TorProvider
by Dan Ballard (＠dan) 13 Mar '25

13 Mar '25

Dan Ballard pushed to branch tor-browser-128.8.0esr-14.5-1 at The Tor Project / Applications / Tor Browser Commits: 6199983c by Dan Ballard at 2025-03-13T11:17:04-07:00 fixup! TB 42247: Android helpers for the TorProvider Bug 41188: Add staging event wiring - - - - - d9c0e220 by Dan Ballard at 2025-03-13T11:17:04-07:00 fixup! TB 41878: [android] Add standalone Tor Bootstrap Bug 41188: Add staging event wiring - - - - - f545b853 by Dan Ballard at 2025-03-13T11:17:04-07:00 fixup! [android] … [View More]Implement Android-native Connection Assist UI Bug 41188: Add staging event wiring - - - - - da17f78c by Dan Ballard at 2025-03-13T11:17:05-07:00 fixup! TB 40597: Implement TorSettings module Bug 41188: pt1 add android stages - - - - - 9 changed files: - mobile/android/fenix/app/src/main/java/org/mozilla/fenix/HomeActivity.kt - mobile/android/fenix/app/src/main/java/org/mozilla/fenix/tor/TorBootstrapProgressViewModel.kt - mobile/android/fenix/app/src/main/java/org/mozilla/fenix/tor/TorControllerGV.kt - mobile/android/geckoview/src/main/java/org/mozilla/geckoview/TorAndroidIntegration.java - + mobile/android/geckoview/src/main/java/org/mozilla/geckoview/TorBootstrappingStatus.java - + mobile/android/geckoview/src/main/java/org/mozilla/geckoview/TorConnectStage.java - + mobile/android/geckoview/src/main/java/org/mozilla/geckoview/TorConnectStageName.java - toolkit/modules/TorAndroidIntegration.sys.mjs - toolkit/modules/TorConnect.sys.mjs Changes: ===================================== mobile/android/fenix/app/src/main/java/org/mozilla/fenix/HomeActivity.kt ===================================== @@ -157,6 +157,7 @@ import org.mozilla.fenix.components.FenixSnackbar import org.mozilla.fenix.home.HomeFragment import org.mozilla.fenix.tor.UrlQuickLoadViewModel import org.mozilla.geckoview.TorAndroidIntegration +import org.mozilla.geckoview.TorConnectStage /** * The main activity of the application. The application is primarily a single Activity (this one) @@ -1453,6 +1454,7 @@ open class HomeActivity : LocaleAwareAppCompatActivity(), NavHostActivity, TorAn } override fun onBootstrapStateChange(state: String) = Unit + override fun onBootstrapStageChange(stage: TorConnectStage) = Unit override fun onBootstrapProgress(progress: Double, hasWarnings: Boolean) = Unit override fun onBootstrapComplete() { if (settings().useHtmlConnectionUi) { ===================================== mobile/android/fenix/app/src/main/java/org/mozilla/fenix/tor/TorBootstrapProgressViewModel.kt ===================================== @@ -5,6 +5,7 @@ import androidx.lifecycle.AndroidViewModel import androidx.lifecycle.MutableLiveData import org.mozilla.fenix.ext.components import org.mozilla.geckoview.TorAndroidIntegration.BootstrapStateChangeListener +import org.mozilla.geckoview.TorConnectStage class TorBootstrapProgressViewModel( application: Application, @@ -27,6 +28,7 @@ class TorBootstrapProgressViewModel( } override fun onBootstrapStateChange(state: String?) {} + override fun onBootstrapStageChange(stage: TorConnectStage) = Unit override fun onBootstrapProgress(progress: Double, hasWarnings: Boolean) { this.progress.value = progress.toInt() ===================================== mobile/android/fenix/app/src/main/java/org/mozilla/fenix/tor/TorControllerGV.kt ===================================== @@ -11,6 +11,7 @@ import org.mozilla.fenix.ext.components import org.mozilla.geckoview.TorAndroidIntegration import org.mozilla.geckoview.TorAndroidIntegration.BootstrapStateChangeListener import org.mozilla.geckoview.TorAndroidIntegration.TorLogListener +import org.mozilla.geckoview.TorConnectStage import org.mozilla.geckoview.TorSettings import org.mozilla.geckoview.TorSettings.BridgeBuiltinType import org.mozilla.geckoview.TorSettings.BridgeSource @@ -322,6 +323,8 @@ class TorControllerGV( onTorStatusUpdate(null, newStateVal, null) } + override fun onBootstrapStageChange(stage: TorConnectStage) = Unit + // TorEventsBootstrapStateChangeListener override fun onBootstrapProgress(progress: Double, hasWarnings: Boolean) { Log.d(TAG, "onBootstrapProgress(progress = $progress, hasWarnings = $hasWarnings)") ===================================== mobile/android/geckoview/src/main/java/org/mozilla/geckoview/TorAndroidIntegration.java ===================================== @@ -37,7 +37,8 @@ public class TorAndroidIntegration implements BundleEventListener { private static final String EVENT_TOR_STOP = "GeckoView:Tor:StopTor"; private static final String EVENT_MEEK_START = "GeckoView:Tor:StartMeek"; private static final String EVENT_MEEK_STOP = "GeckoView:Tor:StopMeek"; - private static final String EVENT_CONNECT_STATE_CHANGED = "GeckoView:Tor:ConnectStateChanged"; + private static final String EVENT_CONNECT_STATE_CHANGED = "GeckoView:Tor:ConnectStateChanged"; // deprecation path + private static final String EVENT_CONNECT_STAGE_CHANGED = "GeckoView:Tor:ConnectStageChanged"; // replacement path private static final String EVENT_CONNECT_ERROR = "GeckoView:Tor:ConnectError"; private static final String EVENT_BOOTSTRAP_PROGRESS = "GeckoView:Tor:BootstrapProgress"; private static final String EVENT_BOOTSTRAP_COMPLETE = "GeckoView:Tor:BootstrapComplete"; @@ -114,6 +115,7 @@ public class TorAndroidIntegration implements BundleEventListener { EVENT_SETTINGS_READY, EVENT_SETTINGS_CHANGED, EVENT_CONNECT_STATE_CHANGED, + EVENT_CONNECT_STAGE_CHANGED, EVENT_CONNECT_ERROR, EVENT_BOOTSTRAP_PROGRESS, EVENT_BOOTSTRAP_COMPLETE, @@ -150,6 +152,11 @@ public class TorAndroidIntegration implements BundleEventListener { for (BootstrapStateChangeListener listener : mBootstrapStateListeners) { listener.onBootstrapStateChange(state); } + } else if (EVENT_CONNECT_STAGE_CHANGED.equals(event)) { + TorConnectStage stage = new TorConnectStage(message.getBundle("stage")); + for (BootstrapStateChangeListener listener : mBootstrapStateListeners) { + listener.onBootstrapStageChange(stage); + } } else if (EVENT_CONNECT_ERROR.equals(event)) { String code = message.getString("code"); String msg = message.getString("message"); @@ -629,7 +636,9 @@ public class TorAndroidIntegration implements BundleEventListener { } public interface BootstrapStateChangeListener { - void onBootstrapStateChange(String state); + void onBootstrapStateChange(String state); // depreaction path + + void onBootstrapStageChange(TorConnectStage stage); // new upgrade void onBootstrapProgress(double progress, boolean hasWarnings); ===================================== mobile/android/geckoview/src/main/java/org/mozilla/geckoview/TorBootstrappingStatus.java ===================================== @@ -0,0 +1,14 @@ +package org.mozilla.geckoview; + +import org.mozilla.gecko.util.GeckoBundle; + +// Class to receive BootstrappingStatus object from TorConnect.sys.mjs ~ln698 +public class TorBootstrappingStatus { + public int progress; // percent of bootstrap progress + public boolean hasWarning; // Whether this bootstrap has a warning in the tor log + + public TorBootstrappingStatus(GeckoBundle bundle) { + progress = bundle.getInt("progress"); + hasWarning = bundle.getBoolean("hasWarning"); + } +} ===================================== mobile/android/geckoview/src/main/java/org/mozilla/geckoview/TorConnectStage.java ===================================== @@ -0,0 +1,48 @@ +package org.mozilla.geckoview; + +import org.mozilla.gecko.util.GeckoBundle; + +// Class to receive ConnectStage object from TorConnect.sys.mjs ~ln677 +public class TorConnectStage { + + public class Error { + public String code; + public String message; + public String phase; + public String reason; + + public Error(GeckoBundle bundle) { + code = bundle.getString("code"); + message = bundle.getString("message"); + phase = bundle.getString("phase"); + reason = bundle.getString("reason"); + } + } + + public TorConnectStageName name; + // The TorConnectStage prior to this bootstrap attempt. Only set during the "Bootstrapping" stage. + public TorConnectStageName bootstrapTrigger; + public Error error; + public String defaultRegion; + public Boolean potentiallyBlocked; + public Boolean tryAgain; + public TorBootstrappingStatus bootstrappingStatus; + + public TorConnectStage(GeckoBundle bundle) { + name = TorConnectStageName.fromString(bundle.getString("name")); + if (bundle.getString("bootstrapTrigger") != null) { + bootstrapTrigger = TorConnectStageName.fromString(bundle.getString("bootstrapTrigger")); + } + defaultRegion = bundle.getString("defaultRegion"); + potentiallyBlocked = bundle.getBoolean("potentiallyBlocked"); + tryAgain = bundle.getBoolean("tryAgain"); + if (bundle.getBundle("error") != null) { + error = new Error(bundle.getBundle("error")); + } + bootstrappingStatus = new TorBootstrappingStatus(bundle.getBundle("bootstrappingStatus")); + } + + public Boolean isBootstrapped() { + return name.isBootstrapped(); + } +} ===================================== mobile/android/geckoview/src/main/java/org/mozilla/geckoview/TorConnectStageName.java ===================================== @@ -0,0 +1,43 @@ +package org.mozilla.geckoview; + +import java.security.InvalidParameterException; + +public enum TorConnectStageName { + // These names should match entries from TorConnectStage in TorConnect.sys.mjs at ~ln163. + Disabled("Disabled"), + Loading("Loading"), + Start("Start"), + Bootstrapping("Bootstrapping"), + Offline("Offline"), + ChooseRegion("ChooseRegion"), + RegionNotFound("RegionNotFound"), + ConfirmRegion("ConfirmRegion"), + FinalError("FinalError"), + Bootstrapped("Bootstrapped"); + + private String valueText; + + TorConnectStageName(String valueText) { + this.valueText = valueText; + } + + public Boolean isBootstrapped() { + return this == Bootstrapped; + } + + public String getString() { + return this.valueText; + } + + public static TorConnectStageName fromString(String text) { + for (TorConnectStageName tcs : TorConnectStageName.values()) { + if (tcs.valueText.equalsIgnoreCase(text)) { + return tcs; + } + } + if (BuildConfig.BUILD_TYPE == "debug") { + throw new InvalidParameterException("Unknown TorConnectStageName " + text); + } + return null; + } +} ===================================== toolkit/modules/TorAndroidIntegration.sys.mjs ===================================== @@ -25,7 +25,8 @@ const logger = console.createInstance({ const EmittedEvents = Object.freeze({ settingsReady: "GeckoView:Tor:SettingsReady", settingsChanged: "GeckoView:Tor:SettingsChanged", - connectStateChanged: "GeckoView:Tor:ConnectStateChanged", + connectStateChanged: "GeckoView:Tor:ConnectStateChanged", // deprecation path + connectStageChanged: "GeckoView:Tor:ConnectStageChanged", // new replacement path connectError: "GeckoView:Tor:ConnectError", bootstrapProgress: "GeckoView:Tor:BootstrapProgress", bootstrapComplete: "GeckoView:Tor:BootstrapComplete", @@ -106,6 +107,12 @@ class TorAndroidIntegrationImpl { state: subj.wrappedJSObject.state ?? "", }); break; + case lazy.TorConnectTopics.StageChange: + lazy.EventDispatcher.instance.sendRequest({ + type: EmittedEvents.connectStageChanged, + stage: subj.wrappedJSObject ?? "", + }); + break; case lazy.TorConnectTopics.BootstrapProgress: lazy.EventDispatcher.instance.sendRequest({ type: EmittedEvents.bootstrapProgress, ===================================== toolkit/modules/TorConnect.sys.mjs ===================================== @@ -660,6 +660,7 @@ export const InternetStatus = Object.freeze({ Online: 1, }); +// This enum is mirrored for Android in TorConnectStageName.java. Changes should be mirrored there export const TorConnectStage = Object.freeze({ Disabled: "Disabled", Loading: "Loading", @@ -677,6 +678,7 @@ export const TorConnectStage = Object.freeze({ * @typedef {object} ConnectStage * * A summary of the user stage. + * (This class is mirrored for Android in TorConnectStage.java. Changes should be mirrored there) * * @property {string} name - The name of the stage. * @property {string} defaultRegion - The default region to show in the UI. @@ -698,6 +700,7 @@ export const TorConnectStage = Object.freeze({ * @typedef {object} BootstrappingStatus * * The status of a bootstrap. + * (This class is mirrored for Android in TorBootstrapping.java. Changes should be mirrored there) * * @property {number} progress - The percent progress. * @property {boolean} hasWarning - Whether this bootstrap has a warning in the @@ -708,6 +711,7 @@ export const TorConnectStage = Object.freeze({ * @typedef {object} BootstrapError * * Details about the error that caused bootstrapping to fail. + * (This class is mirrored for Android in TorError.java. Changes should be mirrored there) * * @property {string} code - The error code type. * @property {string} message - The error message. View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/compare/8fec31… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/compare/8fec31… You're receiving this email because of your account on gitlab.torproject.org. [View Less]

1 0

[Git][tpo/applications/tor-browser-update-responses][main] 7 commits: alpha: new version, 14.5a4 (linux-i686)
by boklm (＠boklm) 13 Mar '25

13 Mar '25

boklm pushed to branch main at The Tor Project / Applications / Tor Browser update responses Commits: e17c7051 by Nicolas Vigier at 2025-03-13T19:39:44+01:00 alpha: new version, 14.5a4 (linux-i686) - - - - - 744b4515 by Nicolas Vigier at 2025-03-13T19:39:44+01:00 alpha: new version, 14.5a4 (linux-x86_64) - - - - - 8a7bae89 by Nicolas Vigier at 2025-03-13T19:39:44+01:00 alpha: new version, 14.5a4 (macos) - - - - - c691cfaf by Nicolas Vigier at 2025-03-13T19:39:44+01:00 alpha: new version, … [View More]14.5a4 (windows-i686) - - - - - cae24212 by Nicolas Vigier at 2025-03-13T19:39:44+01:00 alpha: new version, 14.5a4 (windows-x86_64) - - - - - cfa892da by Nicolas Vigier at 2025-03-13T19:39:44+01:00 alpha: new version, 14.5a4 (android) - - - - - ad49bab4 by Nicolas Vigier at 2025-03-13T19:39:44+01:00 alpha: new version, 14.5a4 - - - - - 49 changed files: - update_3/alpha/.htaccess - − update_3/alpha/14.0a9-14.5a3-windows-i686-ALL.xml - − update_3/alpha/14.0a9-14.5a3-windows-x86_64-ALL.xml - − update_3/alpha/14.5a1-14.5a3-windows-i686-ALL.xml - − update_3/alpha/14.5a1-14.5a3-windows-x86_64-ALL.xml - − update_3/alpha/14.5a2-14.5a3-windows-i686-ALL.xml - − update_3/alpha/14.5a2-14.5a3-windows-x86_64-ALL.xml - − update_3/alpha/14.5a3-windows-i686-ALL.xml - − update_3/alpha/14.5a3-windows-x86_64-ALL.xml - update_3/alpha/download-android-aarch64.json - update_3/alpha/download-android-armv7.json - update_3/alpha/download-android-x86.json - update_3/alpha/download-android-x86_64.json - update_3/alpha/download-linux-i686.json - update_3/alpha/download-linux-x86_64.json - update_3/alpha/download-macos.json - update_3/alpha/download-windows-i686.json - update_3/alpha/download-windows-x86_64.json - update_3/alpha/downloads.json - + update_3/alpha/linux-i686/.htaccess - update_3/alpha/14.0a9-14.5a3-linux-i686-ALL.xml → update_3/alpha/linux-i686/14.5a1-14.5a4-linux-i686.xml - update_3/alpha/14.5a1-14.5a3-linux-i686-ALL.xml → update_3/alpha/linux-i686/14.5a2-14.5a4-linux-i686.xml - update_3/alpha/14.5a2-14.5a3-linux-i686-ALL.xml → update_3/alpha/linux-i686/14.5a3-14.5a4-linux-i686.xml - update_3/alpha/14.5a3-linux-i686-ALL.xml → update_3/alpha/linux-i686/14.5a4-linux-i686.xml - update_3/alpha/no-update.xml → update_3/alpha/linux-i686/no-update.xml - + update_3/alpha/linux-x86_64/.htaccess - update_3/alpha/14.0a9-14.5a3-linux-x86_64-ALL.xml → update_3/alpha/linux-x86_64/14.5a1-14.5a4-linux-x86_64.xml - update_3/alpha/14.5a1-14.5a3-linux-x86_64-ALL.xml → update_3/alpha/linux-x86_64/14.5a2-14.5a4-linux-x86_64.xml - update_3/alpha/14.5a2-14.5a3-linux-x86_64-ALL.xml → update_3/alpha/linux-x86_64/14.5a3-14.5a4-linux-x86_64.xml - update_3/alpha/14.5a3-linux-x86_64-ALL.xml → update_3/alpha/linux-x86_64/14.5a4-linux-x86_64.xml - + update_3/alpha/linux-x86_64/no-update.xml - + update_3/alpha/macos/.htaccess - update_3/alpha/14.5a1-14.5a3-macos-ALL.xml → update_3/alpha/macos/14.5a1-14.5a4-macos.xml - update_3/alpha/14.5a2-14.5a3-macos-ALL.xml → update_3/alpha/macos/14.5a2-14.5a4-macos.xml - update_3/alpha/14.0a9-14.5a3-macos-ALL.xml → update_3/alpha/macos/14.5a3-14.5a4-macos.xml - update_3/alpha/14.5a3-macos-ALL.xml → update_3/alpha/macos/14.5a4-macos.xml - + update_3/alpha/macos/no-update.xml - + update_3/alpha/windows-i686/.htaccess - + update_3/alpha/windows-i686/14.5a1-14.5a4-windows-i686.xml - + update_3/alpha/windows-i686/14.5a2-14.5a4-windows-i686.xml - + update_3/alpha/windows-i686/14.5a3-14.5a4-windows-i686.xml - + update_3/alpha/windows-i686/14.5a4-windows-i686.xml - + update_3/alpha/windows-i686/no-update.xml - + update_3/alpha/windows-x86_64/.htaccess - + update_3/alpha/windows-x86_64/14.5a1-14.5a4-windows-x86_64.xml - + update_3/alpha/windows-x86_64/14.5a2-14.5a4-windows-x86_64.xml - + update_3/alpha/windows-x86_64/14.5a3-14.5a4-windows-x86_64.xml - + update_3/alpha/windows-x86_64/14.5a4-windows-x86_64.xml - + update_3/alpha/windows-x86_64/no-update.xml The diff was not included because it is too large. View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-update-responses… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-update-responses… You're receiving this email because of your account on gitlab.torproject.org. [View Less]

1 0