morgan pushed to branch tor-browser-128.7.0esr-14.5-1 at The Tor Project / Applications / Tor Browser
Commits:
983bf5de by Henry Wilkes at 2025-02-10T14:38:02+00:00
fixup! TB 21952: Implement Onion-Location
TB 43406: Hide the "onion available" button whilst the "Connect" button
is shown.
- - - - -
1 changed file:
- browser/components/onionservices/content/onionlocation.css
Changes:
=====================================
browser/components/onionservices/content/onionlocation.css
=====================================
@@ -5,3 +5,18 @@
-moz-context-properties: fill;
fill: currentColor;
}
+
+#tor-connect-urlbar-button:not([hidden]) ~ #onion-location-box {
+ /* Hide this button whilst the "Connect" button is shown. tor-browser#43406.
+ * This should only make a difference when the tor process dies mid-session.
+ * NOTE: We do not attempt to re-assign focus since the user should already
+ * have had their attention disrupted when the tor process dies mid-session.
+ * NOTE: If we hide this whilst the onion location popup is shown, the popup
+ * will instead become anchored to the site identity (padlock) button instead,
+ * but will return to the #onion-location-box once the "Connect" button is
+ * hidden again. In principle we could explicitly call
+ * PopupNotifications.anchorVisibilityChange() but mozilla code already has
+ * plenty of entry points to update the anchor position for us.
+ * Moreover, this scenario is expected to be a very rare. */
+ display: none;
+}
View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/983bf5d…
--
View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/983bf5d…
You're receiving this email because of your account on gitlab.torproject.org.
morgan pushed to branch mullvad-browser-128.7.0esr-14.0-1 at The Tor Project / Applications / Mullvad Browser
Commits:
0100be62 by Pier Angelo Vendrame at 2025-02-06T18:28:13+00:00
BB 43468: ScreenCaptureKit should be a weak link.
ScreenCaptureKit is not available on older macOS versions.
For some reason, the upstream build have it as a weak import even though
they do not specify the -weak_framework flag, whereas our builds have it
as a normal import and do not work on macOS 10.15 without this patch.
- - - - -
1 changed file:
- toolkit/library/moz.build
Changes:
=====================================
toolkit/library/moz.build
=====================================
@@ -228,7 +228,7 @@ if CONFIG["MOZ_WIDGET_TOOLKIT"] == "cocoa":
"-framework AVFoundation",
"-framework CoreMedia",
"-framework IOKit",
- "-framework ScreenCaptureKit",
+ "-weak_framework ScreenCaptureKit",
"-F%s" % CONFIG["MACOS_PRIVATE_FRAMEWORKS_DIR"],
"-framework CoreUI",
"-framework CoreSymbolication",
View it on GitLab: https://gitlab.torproject.org/tpo/applications/mullvad-browser/-/commit/010…
--
View it on GitLab: https://gitlab.torproject.org/tpo/applications/mullvad-browser/-/commit/010…
You're receiving this email because of your account on gitlab.torproject.org.
morgan pushed to branch base-browser-128.7.0esr-14.0-1 at The Tor Project / Applications / Tor Browser
Commits:
ca7de33e by Pier Angelo Vendrame at 2025-02-06T18:25:29+00:00
BB 43468: ScreenCaptureKit should be a weak link.
ScreenCaptureKit is not available on older macOS versions.
For some reason, the upstream build have it as a weak import even though
they do not specify the -weak_framework flag, whereas our builds have it
as a normal import and do not work on macOS 10.15 without this patch.
- - - - -
1 changed file:
- toolkit/library/moz.build
Changes:
=====================================
toolkit/library/moz.build
=====================================
@@ -228,7 +228,7 @@ if CONFIG["MOZ_WIDGET_TOOLKIT"] == "cocoa":
"-framework AVFoundation",
"-framework CoreMedia",
"-framework IOKit",
- "-framework ScreenCaptureKit",
+ "-weak_framework ScreenCaptureKit",
"-F%s" % CONFIG["MACOS_PRIVATE_FRAMEWORKS_DIR"],
"-framework CoreUI",
"-framework CoreSymbolication",
View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/ca7de33…
--
View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/ca7de33…
You're receiving this email because of your account on gitlab.torproject.org.
morgan pushed to branch tor-browser-128.7.0esr-14.0-1 at The Tor Project / Applications / Tor Browser
Commits:
3eb91e73 by Pier Angelo Vendrame at 2025-02-06T18:27:01+00:00
BB 43468: ScreenCaptureKit should be a weak link.
ScreenCaptureKit is not available on older macOS versions.
For some reason, the upstream build have it as a weak import even though
they do not specify the -weak_framework flag, whereas our builds have it
as a normal import and do not work on macOS 10.15 without this patch.
- - - - -
1 changed file:
- toolkit/library/moz.build
Changes:
=====================================
toolkit/library/moz.build
=====================================
@@ -228,7 +228,7 @@ if CONFIG["MOZ_WIDGET_TOOLKIT"] == "cocoa":
"-framework AVFoundation",
"-framework CoreMedia",
"-framework IOKit",
- "-framework ScreenCaptureKit",
+ "-weak_framework ScreenCaptureKit",
"-F%s" % CONFIG["MACOS_PRIVATE_FRAMEWORKS_DIR"],
"-framework CoreUI",
"-framework CoreSymbolication",
View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/3eb91e7…
--
View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/3eb91e7…
You're receiving this email because of your account on gitlab.torproject.org.
morgan pushed to branch mullvad-browser-128.7.0esr-14.5-1 at The Tor Project / Applications / Mullvad Browser
Commits:
f31aff63 by Pier Angelo Vendrame at 2025-02-06T18:24:38+00:00
BB 43468: ScreenCaptureKit should be a weak link.
ScreenCaptureKit is not available on older macOS versions.
For some reason, the upstream build have it as a weak import even though
they do not specify the -weak_framework flag, whereas our builds have it
as a normal import and do not work on macOS 10.15 without this patch.
- - - - -
1 changed file:
- toolkit/library/moz.build
Changes:
=====================================
toolkit/library/moz.build
=====================================
@@ -228,7 +228,7 @@ if CONFIG["MOZ_WIDGET_TOOLKIT"] == "cocoa":
"-framework AVFoundation",
"-framework CoreMedia",
"-framework IOKit",
- "-framework ScreenCaptureKit",
+ "-weak_framework ScreenCaptureKit",
"-F%s" % CONFIG["MACOS_PRIVATE_FRAMEWORKS_DIR"],
"-framework CoreUI",
"-framework CoreSymbolication",
View it on GitLab: https://gitlab.torproject.org/tpo/applications/mullvad-browser/-/commit/f31…
--
View it on GitLab: https://gitlab.torproject.org/tpo/applications/mullvad-browser/-/commit/f31…
You're receiving this email because of your account on gitlab.torproject.org.
morgan pushed to branch base-browser-128.7.0esr-14.5-1 at The Tor Project / Applications / Tor Browser
Commits:
6e19b43b by Pier Angelo Vendrame at 2025-02-06T18:20:34+00:00
BB 43468: ScreenCaptureKit should be a weak link.
ScreenCaptureKit is not available on older macOS versions.
For some reason, the upstream build have it as a weak import even though
they do not specify the -weak_framework flag, whereas our builds have it
as a normal import and do not work on macOS 10.15 without this patch.
- - - - -
1 changed file:
- toolkit/library/moz.build
Changes:
=====================================
toolkit/library/moz.build
=====================================
@@ -228,7 +228,7 @@ if CONFIG["MOZ_WIDGET_TOOLKIT"] == "cocoa":
"-framework AVFoundation",
"-framework CoreMedia",
"-framework IOKit",
- "-framework ScreenCaptureKit",
+ "-weak_framework ScreenCaptureKit",
"-F%s" % CONFIG["MACOS_PRIVATE_FRAMEWORKS_DIR"],
"-framework CoreUI",
"-framework CoreSymbolication",
View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/6e19b43…
--
View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/6e19b43…
You're receiving this email because of your account on gitlab.torproject.org.