August 2024 - tbb-commits - lists.torproject.org

[Git][tpo/applications/mullvad-browser][mullvad-browser-128.1.0esr-14.0-1] 2 commits: fixup! Add CI for Base Browser
by morgan (＠morgan) 15 Aug '24

15 Aug '24

morgan pushed to branch mullvad-browser-128.1.0esr-14.0-1 at The Tor Project / Applications / Mullvad Browser Commits: 8ca33b25 by Beatriz Rizental at 2024-08-15T19:28:25+00:00 fixup! Add CI for Base Browser Fix issue that prevents the create-bundle job from succeeding when there is already a branch with the same name as the one being pushed to in the CI -- mostly happens on protected branches. - - - - - 88536a9e by Beatriz Rizental at 2024-08-15T19:28:25+00:00 Temporary commit: Disable CI in protected branches This is temporary until we find a proper fix for the slowness caused by our CI in Gitlba. - - - - - 2 changed files: - .gitlab/ci/lint.yml - .gitlab/ci/setup.yml Changes: ===================================== .gitlab/ci/lint.yml ===================================== @@ -61,7 +61,7 @@ eslint: - 'tools/lint/eslint/eslint-plugin-mozilla/**' - 'tools/lint/eslint/eslint-plugin-spidermonkey-js/**' # Run job whenever a commit is merged to a protected branch - - if: $CI_COMMIT_REF_PROTECTED == 'true' + # - if: $CI_COMMIT_REF_PROTECTED == 'true' stylelint: extends: .base @@ -79,7 +79,7 @@ stylelint: - '**/.stylelintignore' - '**/*stylelintrc*' # Run job whenever a commit is merged to a protected branch - - if: $CI_COMMIT_REF_PROTECTED == 'true' + # - if: $CI_COMMIT_REF_PROTECTED == 'true' py-black: extends: .base @@ -98,7 +98,7 @@ py-black: - 'pyproject.toml' - 'tools/lint/black.yml' # Run job whenever a commit is merged to a protected branch - - if: $CI_COMMIT_REF_PROTECTED == 'true' + # - if: $CI_COMMIT_REF_PROTECTED == 'true' py-ruff: extends: .base @@ -117,7 +117,7 @@ py-ruff: - 'tools/lint/python/ruff.py' - 'tools/lint/python/ruff_requirements.txt' # Run job whenever a commit is merged to a protected branch - - if: $CI_COMMIT_REF_PROTECTED == 'true' + # - if: $CI_COMMIT_REF_PROTECTED == 'true' yaml: extends: .base @@ -132,7 +132,7 @@ yaml: - '**/*.yaml' - '**/.ymllint' # Run job whenever a commit is merged to a protected branch - - if: $CI_COMMIT_REF_PROTECTED == 'true' + # - if: $CI_COMMIT_REF_PROTECTED == 'true' shellcheck: extends: .base @@ -146,7 +146,7 @@ shellcheck: - '**/*.sh' - 'tools/lint/shellcheck.yml' # Run job whenever a commit is merged to a protected branch - - if: $CI_COMMIT_REF_PROTECTED == 'true' + # - if: $CI_COMMIT_REF_PROTECTED == 'true' clang-format: extends: .base @@ -166,7 +166,7 @@ clang-format: - '**/*.mm' - 'tools/lint/clang-format.yml' # Run job whenever a commit is merged to a protected branch - - if: $CI_COMMIT_REF_PROTECTED == 'true' + # - if: $CI_COMMIT_REF_PROTECTED == 'true' rustfmt: extends: .base @@ -180,7 +180,7 @@ rustfmt: - '**/*.rs' - 'tools/lint/rustfmt.yml' # Run job whenever a commit is merged to a protected branch - - if: $CI_COMMIT_REF_PROTECTED == 'true' + # - if: $CI_COMMIT_REF_PROTECTED == 'true' fluent-lint: extends: .base @@ -195,7 +195,7 @@ fluent-lint: - 'tools/lint/fluent-lint.yml' - 'tools/lint/fluent-lint/exclusions.yml' # Run job whenever a commit is merged to a protected branch - - if: $CI_COMMIT_REF_PROTECTED == 'true' + # - if: $CI_COMMIT_REF_PROTECTED == 'true' localization: extends: .base @@ -212,7 +212,7 @@ localization: - 'third_party/python/fluent/**' - 'tools/lint/l10n.yml' # Run job whenever a commit is merged to a protected branch - - if: $CI_COMMIT_REF_PROTECTED == 'true' + # - if: $CI_COMMIT_REF_PROTECTED == 'true' mingw-capitalization: extends: .base @@ -229,7 +229,7 @@ mingw-capitalization: - '**/*.h' - 'tools/lint/mingw-capitalization.yml' # Run job whenever a commit is merged to a protected branch - - if: $CI_COMMIT_REF_PROTECTED == 'true' + # - if: $CI_COMMIT_REF_PROTECTED == 'true' mscom-init: extends: .base @@ -246,7 +246,7 @@ mscom-init: - '**/*.h' - 'tools/lint/mscom-init.yml' # Run job whenever a commit is merged to a protected branch - - if: $CI_COMMIT_REF_PROTECTED == 'true' + # - if: $CI_COMMIT_REF_PROTECTED == 'true' file-whitespace: extends: .base @@ -275,7 +275,7 @@ file-whitespace: - '**/*.xhtml' - 'tools/lint/file-whitespace.yml' # Run job whenever a commit is merged to a protected branch - - if: $CI_COMMIT_REF_PROTECTED == 'true' + # - if: $CI_COMMIT_REF_PROTECTED == 'true' test-manifest: extends: .base @@ -290,7 +290,7 @@ test-manifest: - 'python/mozlint/**' - 'tools/lint/**' # Run job whenever a commit is merged to a protected branch - - if: $CI_COMMIT_REF_PROTECTED == 'true' + # - if: $CI_COMMIT_REF_PROTECTED == 'true' trojan-source: extends: .base @@ -309,4 +309,4 @@ trojan-source: - '**/*.rs' - 'tools/lint/trojan-source.yml' # Run job whenever a commit is merged to a protected branch - - if: $CI_COMMIT_REF_PROTECTED == 'true' + # - if: $CI_COMMIT_REF_PROTECTED == 'true' ===================================== .gitlab/ci/setup.yml ===================================== @@ -32,11 +32,14 @@ create-bundle: script: # DEBUG: Check repository status. - git status - # Switch to a named branch. - - git switch -c $BRANCH_NAME + # DEBUG: Check branches in repository + - git branch + # Force switch to a named branch. We force it in case there is already + # a branch with the same name from previous runs. + - git switch -C $BRANCH_NAME # Create a git bundle -- this will generate the app.bundle file, # which can be used as a git remote for offline fetching. - - git bundle create app.bundle --all + - git bundle create app.bundle $BRANCH_NAME # Retain the SHA of the base of this shallow repository. - cat .git/shallow > shallow.txt # DEBUG: Check sizes. View it on GitLab: https://gitlab.torproject.org/tpo/applications/mullvad-browser/-/compare/98… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/mullvad-browser/-/compare/98… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser][base-browser-128.1.0esr-14.0-1] 2 commits: fixup! Add CI for Base Browser
by morgan (＠morgan) 15 Aug '24

15 Aug '24

morgan pushed to branch base-browser-128.1.0esr-14.0-1 at The Tor Project / Applications / Tor Browser Commits: 28c9e96f by Beatriz Rizental at 2024-08-15T19:21:34+00:00 fixup! Add CI for Base Browser Fix issue that prevents the create-bundle job from succeeding when there is already a branch with the same name as the one being pushed to in the CI -- mostly happens on protected branches. - - - - - 9781ac51 by Beatriz Rizental at 2024-08-15T19:21:42+00:00 Temporary commit: Disable CI in protected branches This is temporary until we find a proper fix for the slowness caused by our CI in Gitlba. - - - - - 2 changed files: - .gitlab/ci/lint.yml - .gitlab/ci/setup.yml Changes: ===================================== .gitlab/ci/lint.yml ===================================== @@ -61,7 +61,7 @@ eslint: - 'tools/lint/eslint/eslint-plugin-mozilla/**' - 'tools/lint/eslint/eslint-plugin-spidermonkey-js/**' # Run job whenever a commit is merged to a protected branch - - if: $CI_COMMIT_REF_PROTECTED == 'true' + # - if: $CI_COMMIT_REF_PROTECTED == 'true' stylelint: extends: .base @@ -79,7 +79,7 @@ stylelint: - '**/.stylelintignore' - '**/*stylelintrc*' # Run job whenever a commit is merged to a protected branch - - if: $CI_COMMIT_REF_PROTECTED == 'true' + # - if: $CI_COMMIT_REF_PROTECTED == 'true' py-black: extends: .base @@ -98,7 +98,7 @@ py-black: - 'pyproject.toml' - 'tools/lint/black.yml' # Run job whenever a commit is merged to a protected branch - - if: $CI_COMMIT_REF_PROTECTED == 'true' + # - if: $CI_COMMIT_REF_PROTECTED == 'true' py-ruff: extends: .base @@ -117,7 +117,7 @@ py-ruff: - 'tools/lint/python/ruff.py' - 'tools/lint/python/ruff_requirements.txt' # Run job whenever a commit is merged to a protected branch - - if: $CI_COMMIT_REF_PROTECTED == 'true' + # - if: $CI_COMMIT_REF_PROTECTED == 'true' yaml: extends: .base @@ -132,7 +132,7 @@ yaml: - '**/*.yaml' - '**/.ymllint' # Run job whenever a commit is merged to a protected branch - - if: $CI_COMMIT_REF_PROTECTED == 'true' + # - if: $CI_COMMIT_REF_PROTECTED == 'true' shellcheck: extends: .base @@ -146,7 +146,7 @@ shellcheck: - '**/*.sh' - 'tools/lint/shellcheck.yml' # Run job whenever a commit is merged to a protected branch - - if: $CI_COMMIT_REF_PROTECTED == 'true' + # - if: $CI_COMMIT_REF_PROTECTED == 'true' clang-format: extends: .base @@ -166,7 +166,7 @@ clang-format: - '**/*.mm' - 'tools/lint/clang-format.yml' # Run job whenever a commit is merged to a protected branch - - if: $CI_COMMIT_REF_PROTECTED == 'true' + # - if: $CI_COMMIT_REF_PROTECTED == 'true' rustfmt: extends: .base @@ -180,7 +180,7 @@ rustfmt: - '**/*.rs' - 'tools/lint/rustfmt.yml' # Run job whenever a commit is merged to a protected branch - - if: $CI_COMMIT_REF_PROTECTED == 'true' + # - if: $CI_COMMIT_REF_PROTECTED == 'true' fluent-lint: extends: .base @@ -195,7 +195,7 @@ fluent-lint: - 'tools/lint/fluent-lint.yml' - 'tools/lint/fluent-lint/exclusions.yml' # Run job whenever a commit is merged to a protected branch - - if: $CI_COMMIT_REF_PROTECTED == 'true' + # - if: $CI_COMMIT_REF_PROTECTED == 'true' localization: extends: .base @@ -212,7 +212,7 @@ localization: - 'third_party/python/fluent/**' - 'tools/lint/l10n.yml' # Run job whenever a commit is merged to a protected branch - - if: $CI_COMMIT_REF_PROTECTED == 'true' + # - if: $CI_COMMIT_REF_PROTECTED == 'true' mingw-capitalization: extends: .base @@ -229,7 +229,7 @@ mingw-capitalization: - '**/*.h' - 'tools/lint/mingw-capitalization.yml' # Run job whenever a commit is merged to a protected branch - - if: $CI_COMMIT_REF_PROTECTED == 'true' + # - if: $CI_COMMIT_REF_PROTECTED == 'true' mscom-init: extends: .base @@ -246,7 +246,7 @@ mscom-init: - '**/*.h' - 'tools/lint/mscom-init.yml' # Run job whenever a commit is merged to a protected branch - - if: $CI_COMMIT_REF_PROTECTED == 'true' + # - if: $CI_COMMIT_REF_PROTECTED == 'true' file-whitespace: extends: .base @@ -275,7 +275,7 @@ file-whitespace: - '**/*.xhtml' - 'tools/lint/file-whitespace.yml' # Run job whenever a commit is merged to a protected branch - - if: $CI_COMMIT_REF_PROTECTED == 'true' + # - if: $CI_COMMIT_REF_PROTECTED == 'true' test-manifest: extends: .base @@ -290,7 +290,7 @@ test-manifest: - 'python/mozlint/**' - 'tools/lint/**' # Run job whenever a commit is merged to a protected branch - - if: $CI_COMMIT_REF_PROTECTED == 'true' + # - if: $CI_COMMIT_REF_PROTECTED == 'true' trojan-source: extends: .base @@ -309,4 +309,4 @@ trojan-source: - '**/*.rs' - 'tools/lint/trojan-source.yml' # Run job whenever a commit is merged to a protected branch - - if: $CI_COMMIT_REF_PROTECTED == 'true' + # - if: $CI_COMMIT_REF_PROTECTED == 'true' ===================================== .gitlab/ci/setup.yml ===================================== @@ -32,11 +32,14 @@ create-bundle: script: # DEBUG: Check repository status. - git status - # Switch to a named branch. - - git switch -c $BRANCH_NAME + # DEBUG: Check branches in repository + - git branch + # Force switch to a named branch. We force it in case there is already + # a branch with the same name from previous runs. + - git switch -C $BRANCH_NAME # Create a git bundle -- this will generate the app.bundle file, # which can be used as a git remote for offline fetching. - - git bundle create app.bundle --all + - git bundle create app.bundle $BRANCH_NAME # Retain the SHA of the base of this shallow repository. - cat .git/shallow > shallow.txt # DEBUG: Check sizes. View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/compare/668cc0… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/compare/668cc0… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser][tor-browser-128.1.0esr-14.0-1] 2 commits: fixup! Add CI for Base Browser
by morgan (＠morgan) 15 Aug '24

15 Aug '24

morgan pushed to branch tor-browser-128.1.0esr-14.0-1 at The Tor Project / Applications / Tor Browser Commits: 428b8dd0 by Beatriz Rizental at 2024-08-15T19:17:29+00:00 fixup! Add CI for Base Browser Fix issue that prevents the create-bundle job from succeeding when there is already a branch with the same name as the one being pushed to in the CI -- mostly happens on protected branches. - - - - - 41a1b3e0 by Beatriz Rizental at 2024-08-15T19:17:29+00:00 Temporary commit: Disable CI in protected branches This is temporary until we find a proper fix for the slowness caused by our CI in Gitlba. - - - - - 2 changed files: - .gitlab/ci/lint.yml - .gitlab/ci/setup.yml Changes: ===================================== .gitlab/ci/lint.yml ===================================== @@ -61,7 +61,7 @@ eslint: - 'tools/lint/eslint/eslint-plugin-mozilla/**' - 'tools/lint/eslint/eslint-plugin-spidermonkey-js/**' # Run job whenever a commit is merged to a protected branch - - if: $CI_COMMIT_REF_PROTECTED == 'true' + # - if: $CI_COMMIT_REF_PROTECTED == 'true' stylelint: extends: .base @@ -79,7 +79,7 @@ stylelint: - '**/.stylelintignore' - '**/*stylelintrc*' # Run job whenever a commit is merged to a protected branch - - if: $CI_COMMIT_REF_PROTECTED == 'true' + # - if: $CI_COMMIT_REF_PROTECTED == 'true' py-black: extends: .base @@ -98,7 +98,7 @@ py-black: - 'pyproject.toml' - 'tools/lint/black.yml' # Run job whenever a commit is merged to a protected branch - - if: $CI_COMMIT_REF_PROTECTED == 'true' + # - if: $CI_COMMIT_REF_PROTECTED == 'true' py-ruff: extends: .base @@ -117,7 +117,7 @@ py-ruff: - 'tools/lint/python/ruff.py' - 'tools/lint/python/ruff_requirements.txt' # Run job whenever a commit is merged to a protected branch - - if: $CI_COMMIT_REF_PROTECTED == 'true' + # - if: $CI_COMMIT_REF_PROTECTED == 'true' yaml: extends: .base @@ -132,7 +132,7 @@ yaml: - '**/*.yaml' - '**/.ymllint' # Run job whenever a commit is merged to a protected branch - - if: $CI_COMMIT_REF_PROTECTED == 'true' + # - if: $CI_COMMIT_REF_PROTECTED == 'true' shellcheck: extends: .base @@ -146,7 +146,7 @@ shellcheck: - '**/*.sh' - 'tools/lint/shellcheck.yml' # Run job whenever a commit is merged to a protected branch - - if: $CI_COMMIT_REF_PROTECTED == 'true' + # - if: $CI_COMMIT_REF_PROTECTED == 'true' clang-format: extends: .base @@ -166,7 +166,7 @@ clang-format: - '**/*.mm' - 'tools/lint/clang-format.yml' # Run job whenever a commit is merged to a protected branch - - if: $CI_COMMIT_REF_PROTECTED == 'true' + # - if: $CI_COMMIT_REF_PROTECTED == 'true' rustfmt: extends: .base @@ -180,7 +180,7 @@ rustfmt: - '**/*.rs' - 'tools/lint/rustfmt.yml' # Run job whenever a commit is merged to a protected branch - - if: $CI_COMMIT_REF_PROTECTED == 'true' + # - if: $CI_COMMIT_REF_PROTECTED == 'true' fluent-lint: extends: .base @@ -195,7 +195,7 @@ fluent-lint: - 'tools/lint/fluent-lint.yml' - 'tools/lint/fluent-lint/exclusions.yml' # Run job whenever a commit is merged to a protected branch - - if: $CI_COMMIT_REF_PROTECTED == 'true' + # - if: $CI_COMMIT_REF_PROTECTED == 'true' localization: extends: .base @@ -212,7 +212,7 @@ localization: - 'third_party/python/fluent/**' - 'tools/lint/l10n.yml' # Run job whenever a commit is merged to a protected branch - - if: $CI_COMMIT_REF_PROTECTED == 'true' + # - if: $CI_COMMIT_REF_PROTECTED == 'true' mingw-capitalization: extends: .base @@ -229,7 +229,7 @@ mingw-capitalization: - '**/*.h' - 'tools/lint/mingw-capitalization.yml' # Run job whenever a commit is merged to a protected branch - - if: $CI_COMMIT_REF_PROTECTED == 'true' + # - if: $CI_COMMIT_REF_PROTECTED == 'true' mscom-init: extends: .base @@ -246,7 +246,7 @@ mscom-init: - '**/*.h' - 'tools/lint/mscom-init.yml' # Run job whenever a commit is merged to a protected branch - - if: $CI_COMMIT_REF_PROTECTED == 'true' + # - if: $CI_COMMIT_REF_PROTECTED == 'true' file-whitespace: extends: .base @@ -275,7 +275,7 @@ file-whitespace: - '**/*.xhtml' - 'tools/lint/file-whitespace.yml' # Run job whenever a commit is merged to a protected branch - - if: $CI_COMMIT_REF_PROTECTED == 'true' + # - if: $CI_COMMIT_REF_PROTECTED == 'true' test-manifest: extends: .base @@ -290,7 +290,7 @@ test-manifest: - 'python/mozlint/**' - 'tools/lint/**' # Run job whenever a commit is merged to a protected branch - - if: $CI_COMMIT_REF_PROTECTED == 'true' + # - if: $CI_COMMIT_REF_PROTECTED == 'true' trojan-source: extends: .base @@ -309,4 +309,4 @@ trojan-source: - '**/*.rs' - 'tools/lint/trojan-source.yml' # Run job whenever a commit is merged to a protected branch - - if: $CI_COMMIT_REF_PROTECTED == 'true' + # - if: $CI_COMMIT_REF_PROTECTED == 'true' ===================================== .gitlab/ci/setup.yml ===================================== @@ -32,11 +32,14 @@ create-bundle: script: # DEBUG: Check repository status. - git status - # Switch to a named branch. - - git switch -c $BRANCH_NAME + # DEBUG: Check branches in repository + - git branch + # Force switch to a named branch. We force it in case there is already + # a branch with the same name from previous runs. + - git switch -C $BRANCH_NAME # Create a git bundle -- this will generate the app.bundle file, # which can be used as a git remote for offline fetching. - - git bundle create app.bundle --all + - git bundle create app.bundle $BRANCH_NAME # Retain the SHA of the base of this shallow repository. - cat .git/shallow > shallow.txt # DEBUG: Check sizes. View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/compare/7b9fe5… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/compare/7b9fe5… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser][tor-browser-128.1.0esr-14.0-1] fixup! Bug 40701: Add security warning when downloading a file
by morgan (＠morgan) 15 Aug '24

15 Aug '24

morgan pushed to branch tor-browser-128.1.0esr-14.0-1 at The Tor Project / Applications / Tor Browser Commits: 7b9fe534 by Henry Wilkes at 2024-08-15T19:03:15+00:00 fixup! Bug 40701: Add security warning when downloading a file Bug 42642: Focus the "Got it" button when opening the downloads panel. This should ensure that the alert is read aloud by Orca screen reader. - - - - - 1 changed file: - browser/components/downloads/content/downloads.js Changes: ===================================== browser/components/downloads/content/downloads.js ===================================== @@ -107,11 +107,12 @@ var DownloadsPanel = { if (Services.prefs.getBoolPref(PREF_SHOW_DOWNLOAD_WARNING)) { torWarningMessage.hidden = false; } else { - // Re-assign focus if it is about to be lost. - if (torWarningMessage.contains(document.activeElement)) { + const hadFocus = torWarningMessage.contains(document.activeElement); + torWarningMessage.hidden = true; + // Re-assign focus that was lost. + if (hadFocus) { this._focusPanel(true); } - torWarningMessage.hidden = true; } }; Services.prefs.addObserver( @@ -577,6 +578,20 @@ var DownloadsPanel = { if (this._preventFocusRing) { focusOptions.focusVisible = false; } + + // Focus the "Got it" button if it is visible. + // This should ensure that the alert is read aloud by Orca when the + // downloads panel is opened. See tor-browser#42642. + const torWarningMessage = document.getElementById( + "downloadsPanelTorWarning" + ); + if (!torWarningMessage.hidden) { + torWarningMessage + .querySelector(".downloads-tor-warning-dismiss-button") + .focus(focusOptions); + return; + } + if (DownloadsView.richListBox.itemCount > 0) { if (DownloadsView.canChangeSelectedItem) { DownloadsView.richListBox.selectedIndex = 0; View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/7b9fe53… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/7b9fe53… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser][tor-browser-128.1.0esr-14.0-1] fixup! Bug 31286: Implementation of bridge, proxy, and firewall settings in...
by morgan (＠morgan) 15 Aug '24

15 Aug '24

morgan pushed to branch tor-browser-128.1.0esr-14.0-1 at The Tor Project / Applications / Tor Browser Commits: 7d28998a by Henry Wilkes at 2024-08-15T18:41:57+00:00 fixup! Bug 31286: Implementation of bridge, proxy, and firewall settings in about:preferences#connection Bug 42806: Use `lh` unit in tor connection preferences. Bug 42705: Adjust spacing of the Lox update list to account for removal of 1.8 line-height. - - - - - 1 changed file: - browser/components/torpreferences/content/torPreferences.css Changes: ===================================== browser/components/torpreferences/content/torPreferences.css ===================================== @@ -558,7 +558,7 @@ button.spoof-button-disabled { ". invites button" min-content / min-content 1fr max-content; align-items: start; - gap: 0 8px; + gap: 8px; } .tor-bridges-lox-image-outer { @@ -620,6 +620,7 @@ button.spoof-button-disabled { /* Align the icons, as if list markers. */ grid-template-columns: max-content 1fr; align-items: start; + gap: 8px 0; } .tor-bridges-lox-list-item { @@ -628,16 +629,15 @@ button.spoof-button-disabled { .tor-bridges-lox-list-item::before { /* We use ::before rather than list-style-image to have more control. */ - display: block; box-sizing: content-box; width: 18px; height: 18px; margin-inline: 4px 6px; /* We want the icons to be center-aligned relative to the *first* line. */ - /* TODO: After firefox 120, can use line-height unit "lh" to do proper - * center-alignment: calc((1lh - 18px) / 2) - * For now, we use 3.4ex as an approximation for 1lh */ - margin-block-start: calc((3.4ex - 18px) / 2); + margin-block-start: calc((1lh - 18px) / 2); + /* We use display: grid rather than display: block. Otherwise the content will + * be offset vertically by the line-height. */ + display: grid; /* fill is the icon color, stroke is the border color. */ -moz-context-properties: fill, stroke; fill: var(--in-content-icon-color); View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/7d28998… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/7d28998… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser][tor-browser-128.1.0esr-14.0-1] 2 commits: fixup! [android] Add Tor integration and UI
by morgan (＠morgan) 15 Aug '24

15 Aug '24

morgan pushed to branch tor-browser-128.1.0esr-14.0-1 at The Tor Project / Applications / Tor Browser Commits: 1095fb7a by Morgan at 2024-08-15T18:26:31+00:00 fixup! [android] Add Tor integration and UI - - - - - ab628494 by Morgan at 2024-08-15T18:27:15+00:00 fixup! [android] Implement Android-native Connection Assist UI - - - - - 2 changed files: - mobile/android/fenix/app/src/main/java/org/mozilla/fenix/tor/TorConnectionAssistViewModel.kt - mobile/android/fenix/app/src/main/java/org/mozilla/fenix/tor/TorController.kt Changes: ===================================== mobile/android/fenix/app/src/main/java/org/mozilla/fenix/tor/TorConnectionAssistViewModel.kt ===================================== @@ -254,6 +254,4 @@ class TorConnectionAssistViewModel( } return true } - } - ===================================== mobile/android/fenix/app/src/main/java/org/mozilla/fenix/tor/TorController.kt ===================================== @@ -63,6 +63,3 @@ interface TorController: TorEvents { fun setTorStopped() fun restartTor() } - - - View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/compare/efea03… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/compare/efea03… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/mullvad-browser][mullvad-browser-128.1.0esr-14.0-1] 2 commits: fixup! Bug 41916: Letterboxing preferences UI
by morgan (＠morgan) 15 Aug '24

15 Aug '24

morgan pushed to branch mullvad-browser-128.1.0esr-14.0-1 at The Tor Project / Applications / Mullvad Browser Commits: 53ce1284 by Henry Wilkes at 2024-08-15T18:11:41+00:00 fixup! Bug 41916: Letterboxing preferences UI Bug 42667: Add the "description-deemphasized" class to our preferences. - - - - - 9885ce7f by Henry Wilkes at 2024-08-15T18:11:47+00:00 fixup! Bug 40925: Implemented the Security Level component Bug 42667: Add the "description-deemphasized" class to our preferences. - - - - - 2 changed files: - browser/components/preferences/letterboxing.inc.xhtml - browser/components/securitylevel/content/securityLevelPreferences.inc.xhtml Changes: ===================================== browser/components/preferences/letterboxing.inc.xhtml ===================================== @@ -6,7 +6,7 @@ data-category="paneGeneral" > <html:h1 data-l10n-id="letterboxing-header" /> - <description class="letterboxing-overview"> + <description class="letterboxing-overview description-deemphasized"> <html:span data-l10n-id="letterboxing-overview" class="tail-with-learn-more" @@ -25,7 +25,7 @@ > <label><html:h2 data-l10n-id="letterboxing-window-size-header"/></label> - <description class="letterboxing-search-overview"> + <description class="letterboxing-search-overview description-deemphasized"> <html:span data-l10n-id="letterboxing-overview" class="tail-with-learn-more" @@ -50,7 +50,7 @@ <label><html:h2 data-l10n-id="letterboxing-alignment-header" /></label> - <description class="letterboxing-search-overview"> + <description class="letterboxing-search-overview description-deemphasized"> <html:span data-l10n-id="letterboxing-overview" class="tail-with-learn-more" @@ -99,7 +99,7 @@ > <label class="letterboxing-search-heading"><html:h2 data-l10n-id="letterboxing-header"/></label> - <description class="letterboxing-search-overview"> + <description class="letterboxing-search-overview description-deemphasized"> <html:span data-l10n-id="letterboxing-overview" class="tail-with-learn-more" ===================================== browser/components/securitylevel/content/securityLevelPreferences.inc.xhtml ===================================== @@ -6,7 +6,7 @@ <html:h2 data-l10n-id="security-level-preferences-heading"></html:h2> </label> <vbox flex="1"> - <description flex="1"> + <description class="description-deemphasized" flex="1"> <html:span id="securityLevel-overview" class="tail-with-learn-more" View it on GitLab: https://gitlab.torproject.org/tpo/applications/mullvad-browser/-/compare/2d… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/mullvad-browser/-/compare/2d… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser][base-browser-128.1.0esr-14.0-1] 2 commits: fixup! Bug 41916: Letterboxing preferences UI
by morgan (＠morgan) 15 Aug '24

15 Aug '24

morgan pushed to branch base-browser-128.1.0esr-14.0-1 at The Tor Project / Applications / Tor Browser Commits: 18ad1960 by Henry Wilkes at 2024-08-15T18:04:28+00:00 fixup! Bug 41916: Letterboxing preferences UI Bug 42667: Add the "description-deemphasized" class to our preferences. - - - - - 668cc010 by Henry Wilkes at 2024-08-15T18:04:32+00:00 fixup! Bug 40925: Implemented the Security Level component Bug 42667: Add the "description-deemphasized" class to our preferences. - - - - - 2 changed files: - browser/components/preferences/letterboxing.inc.xhtml - browser/components/securitylevel/content/securityLevelPreferences.inc.xhtml Changes: ===================================== browser/components/preferences/letterboxing.inc.xhtml ===================================== @@ -6,7 +6,7 @@ data-category="paneGeneral" > <html:h1 data-l10n-id="letterboxing-header" /> - <description class="letterboxing-overview"> + <description class="letterboxing-overview description-deemphasized"> <html:span data-l10n-id="letterboxing-overview" class="tail-with-learn-more" @@ -25,7 +25,7 @@ > <label><html:h2 data-l10n-id="letterboxing-window-size-header"/></label> - <description class="letterboxing-search-overview"> + <description class="letterboxing-search-overview description-deemphasized"> <html:span data-l10n-id="letterboxing-overview" class="tail-with-learn-more" @@ -50,7 +50,7 @@ <label><html:h2 data-l10n-id="letterboxing-alignment-header" /></label> - <description class="letterboxing-search-overview"> + <description class="letterboxing-search-overview description-deemphasized"> <html:span data-l10n-id="letterboxing-overview" class="tail-with-learn-more" @@ -99,7 +99,7 @@ > <label class="letterboxing-search-heading"><html:h2 data-l10n-id="letterboxing-header"/></label> - <description class="letterboxing-search-overview"> + <description class="letterboxing-search-overview description-deemphasized"> <html:span data-l10n-id="letterboxing-overview" class="tail-with-learn-more" ===================================== browser/components/securitylevel/content/securityLevelPreferences.inc.xhtml ===================================== @@ -6,7 +6,7 @@ <html:h2 data-l10n-id="security-level-preferences-heading"></html:h2> </label> <vbox flex="1"> - <description flex="1"> + <description class="description-deemphasized" flex="1"> <html:span id="securityLevel-overview" class="tail-with-learn-more" View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/compare/7e9fa8… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/compare/7e9fa8… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser][tor-browser-128.1.0esr-14.0-1] 4 commits: fixup! Bug 41916: Letterboxing preferences UI
by morgan (＠morgan) 15 Aug '24

15 Aug '24

morgan pushed to branch tor-browser-128.1.0esr-14.0-1 at The Tor Project / Applications / Tor Browser Commits: c9598c59 by Henry Wilkes at 2024-08-15T17:46:24+00:00 fixup! Bug 41916: Letterboxing preferences UI Bug 42667: Add the "description-deemphasized" class to our preferences. - - - - - a6cfccb9 by Henry Wilkes at 2024-08-15T17:46:24+00:00 fixup! Bug 40925: Implemented the Security Level component Bug 42667: Add the "description-deemphasized" class to our preferences. - - - - - c7138dec by Henry Wilkes at 2024-08-15T17:46:24+00:00 fixup! Bug 30237: Add v3 onion services client authentication prompt Bug 42667: Add the "description-deemphasized" class to our preferences. Also use the "description-width-side-element" class. - - - - - efea0346 by Henry Wilkes at 2024-08-15T17:46:24+00:00 fixup! Bug 31286: Implementation of bridge, proxy, and firewall settings in about:preferences#connection Bug 42667: Add the "description-deemphasized" class to our preferences. - - - - - 5 changed files: - browser/components/onionservices/content/authPreferences.css - browser/components/onionservices/content/authPreferences.inc.xhtml - browser/components/preferences/letterboxing.inc.xhtml - browser/components/securitylevel/content/securityLevelPreferences.inc.xhtml - browser/components/torpreferences/content/connectionPane.xhtml Changes: ===================================== browser/components/onionservices/content/authPreferences.css ===================================== @@ -2,10 +2,6 @@ @import url("chrome://global/skin/browser-colors.css"); -#torOnionServiceKeys-overview-container { - margin-inline-end: 30px; -} - #onionservices-savedkeys-dialog { min-width: 45em; } ===================================== browser/components/onionservices/content/authPreferences.inc.xhtml ===================================== @@ -4,7 +4,10 @@ data-category="panePrivacy" hidden="true"> <label><html:h2 id="torOnionServiceKeys-header"/></label> <hbox> - <description id="torOnionServiceKeys-overview-container" flex="1"> + <description + class="description-deemphasized description-with-side-element" + flex="1" + > <html:span id="torOnionServiceKeys-overview" class="tail-with-learn-more"/> <label id="torOnionServiceKeys-learnMore" class="learnMore text-link" ===================================== browser/components/preferences/letterboxing.inc.xhtml ===================================== @@ -6,7 +6,7 @@ data-category="paneGeneral" > <html:h1 data-l10n-id="letterboxing-header" /> - <description class="letterboxing-overview"> + <description class="letterboxing-overview description-deemphasized"> <html:span data-l10n-id="letterboxing-overview" class="tail-with-learn-more" @@ -25,7 +25,7 @@ > <label><html:h2 data-l10n-id="letterboxing-window-size-header"/></label> - <description class="letterboxing-search-overview"> + <description class="letterboxing-search-overview description-deemphasized"> <html:span data-l10n-id="letterboxing-overview" class="tail-with-learn-more" @@ -50,7 +50,7 @@ <label><html:h2 data-l10n-id="letterboxing-alignment-header" /></label> - <description class="letterboxing-search-overview"> + <description class="letterboxing-search-overview description-deemphasized"> <html:span data-l10n-id="letterboxing-overview" class="tail-with-learn-more" @@ -99,7 +99,7 @@ > <label class="letterboxing-search-heading"><html:h2 data-l10n-id="letterboxing-header"/></label> - <description class="letterboxing-search-overview"> + <description class="letterboxing-search-overview description-deemphasized"> <html:span data-l10n-id="letterboxing-overview" class="tail-with-learn-more" ===================================== browser/components/securitylevel/content/securityLevelPreferences.inc.xhtml ===================================== @@ -6,7 +6,7 @@ <html:h2 data-l10n-id="security-level-preferences-heading"></html:h2> </label> <vbox flex="1"> - <description flex="1"> + <description class="description-deemphasized" flex="1"> <html:span id="securityLevel-overview" class="tail-with-learn-more" ===================================== browser/components/torpreferences/content/connectionPane.xhtml ===================================== @@ -12,7 +12,7 @@ hidden="true" > <html:h1 data-l10n-id="tor-connection-settings-heading"></html:h1> - <description flex="1"> + <description class="description-deemphasized" flex="1"> <html:span data-l10n-id="tor-connection-overview" class="tail-with-learn-more" @@ -86,8 +86,11 @@ <label> <html:h2 data-l10n-id="tor-connection-quickstart-heading"></html:h2> </label> - <description flex="1" data-l10n-id="tor-connection-quickstart-description"> - </description> + <description + class="description-deemphasized" + flex="1" + data-l10n-id="tor-connection-quickstart-description" + /> <checkbox id="torPreferences-quickstart-toggle" data-l10n-id="tor-connection-quickstart-checkbox" @@ -108,7 +111,7 @@ data-category="paneConnection" hidden="true" > - <description flex="1"> + <description class="description-deemphasized" flex="1"> <html:span class="tail-with-learn-more" data-l10n-id="tor-bridges-overview" @@ -434,7 +437,10 @@ id="tor-bridges-provider-heading" data-l10n-id="tor-bridges-find-more-heading" ></html:h3> - <description data-l10n-id="tor-bridges-find-more-description" /> + <description + data-l10n-id="tor-bridges-find-more-description" + class="description-deemphasized" + /> <html:div id="tor-bridges-provider-area"> <html:ul id="tor-bridges-provider-list"> <html:li class="tor-bridges-provider-item"> View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/compare/6bec5d… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/compare/6bec5d… You're receiving this email because of your account on gitlab.torproject.org.

1 0

[Git][tpo/applications/tor-browser][tor-browser-128.1.0esr-14.0-1] fixup! Bug 42247: Android helpers for the TorProvider
by morgan (＠morgan) 15 Aug '24

15 Aug '24

morgan pushed to branch tor-browser-128.1.0esr-14.0-1 at The Tor Project / Applications / Tor Browser Commits: 6bec5d4d by Morgan at 2024-08-15T16:42:53+00:00 fixup! Bug 42247: Android helpers for the TorProvider - - - - - 1 changed file: - browser/app/profile/000-tor-browser.js Changes: ===================================== browser/app/profile/000-tor-browser.js ===================================== @@ -101,7 +101,6 @@ pref("extensions.torlauncher.tor_path", ""); // which is TorBrowser-Data/ if it exists as a sibling of the application // directory. If TorBrowser-Data/ does not exist, these paths are relative // to the TorBrowser/ directory within the application directory. -pref pref("extensions.torlauncher.torrc_path", ""); pref("extensions.torlauncher.tordatadir_path", ""); View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/6bec5d4… -- View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/6bec5d4… You're receiving this email because of your account on gitlab.torproject.org.

1 0