ma1 pushed to branch tor-browser-115.16.0esr-13.5-1 at The Tor Project / Applications / Tor Browser
Commits:
e9a98dae by Emilio Cobos Álvarez at 2024-10-08T20:36:09+02:00
Bug 1923344. a=diannaS
Original Revision: https://phabricator.services.mozilla.com/D224958
Differential Revision: https://phabricator.services.mozilla.com/D224963
- - - - -
2 changed files:
- dom/animation/AnimationTimeline.cpp
- dom/animation/ScrollTimelineAnimationTracker.cpp
Changes:
=====================================
dom/animation/AnimationTimeline.cpp
=====================================
@@ -41,41 +41,33 @@ AnimationTimeline::~AnimationTimeline() { mAnimationOrder.clear(); }
bool AnimationTimeline::Tick() {
bool needsTicks = false;
- nsTArray<Animation*> animationsToRemove;
-
- for (Animation* animation = mAnimationOrder.getFirst(); animation;
- animation =
- static_cast<LinkedListElement<Animation>*>(animation)->getNext()) {
+ AutoTArray<RefPtr<Animation>, 32> animationsToTick;
+ for (Animation* animation : mAnimationOrder) {
MOZ_ASSERT(mAnimations.Contains(animation),
"The sampling order list should be a subset of the hashset");
MOZ_ASSERT(!animation->IsHiddenByContentVisibility(),
"The sampling order list should not contain any animations "
"that are hidden by content-visibility");
+ animationsToTick.AppendElement(animation);
+ }
+ for (Animation* animation : animationsToTick) {
// Skip any animations that are longer need associated with this timeline.
if (animation->GetTimeline() != this) {
- // If animation has some other timeline, it better not be also in the
- // animation list of this timeline object!
- MOZ_ASSERT(!animation->GetTimeline());
- animationsToRemove.AppendElement(animation);
+ RemoveAnimation(animation);
continue;
}
needsTicks |= animation->NeedsTicks();
- // Even if |animation| doesn't need future ticks, we should still
- // Tick it this time around since it might just need a one-off tick in
- // order to dispatch events.
+ // Even if |animation| doesn't need future ticks, we should still Tick it
+ // this time around since it might just need a one-off tick in order to
+ // dispatch events.
animation->Tick();
-
if (!animation->NeedsTicks()) {
- animationsToRemove.AppendElement(animation);
+ RemoveAnimation(animation);
}
}
- for (Animation* animation : animationsToRemove) {
- RemoveAnimation(animation);
- }
-
return needsTicks;
}
@@ -91,11 +83,12 @@ void AnimationTimeline::NotifyAnimationUpdated(Animation& aAnimation) {
}
void AnimationTimeline::RemoveAnimation(Animation* aAnimation) {
- MOZ_ASSERT(!aAnimation->GetTimeline() || aAnimation->GetTimeline() == this);
- if (static_cast<LinkedListElement<Animation>*>(aAnimation)->isInList()) {
+ if (static_cast<LinkedListElement<Animation>*>(aAnimation)->isInList() &&
+ MOZ_LIKELY(!aAnimation->GetTimeline() ||
+ aAnimation->GetTimeline() == this)) {
+ static_cast<LinkedListElement<Animation>*>(aAnimation)->remove();
MOZ_ASSERT(mAnimations.Contains(aAnimation),
"The sampling order list should be a subset of the hashset");
- static_cast<LinkedListElement<Animation>*>(aAnimation)->remove();
}
mAnimations.Remove(aAnimation);
}
=====================================
dom/animation/ScrollTimelineAnimationTracker.cpp
=====================================
@@ -13,13 +13,10 @@ namespace mozilla {
NS_IMPL_CYCLE_COLLECTION(ScrollTimelineAnimationTracker, mPendingSet, mDocument)
void ScrollTimelineAnimationTracker::TriggerPendingAnimations() {
- for (auto iter = mPendingSet.begin(), end = mPendingSet.end(); iter != end;
- ++iter) {
- dom::Animation* animation = *iter;
-
+ for (RefPtr<dom::Animation>& animation :
+ ToTArray<AutoTArray<RefPtr<dom::Animation>, 32>>(mPendingSet)) {
MOZ_ASSERT(animation->GetTimeline() &&
!animation->GetTimeline()->IsMonotonicallyIncreasing());
-
// FIXME: Trigger now may not be correct because the spec says:
// If a user agent determines that animation is immediately ready, it may
// schedule the task (i.e. ResumeAt()) as a microtask such that it runs at
@@ -39,9 +36,7 @@ void ScrollTimelineAnimationTracker::TriggerPendingAnimations() {
// inactive, and this also matches the current spec definition.
continue;
}
-
- // Note: Remove() is legitimately called once per entry during the loop.
- mPendingSet.Remove(iter);
+ mPendingSet.Remove(animation);
}
}
View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/e9a98da…
--
View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/e9a98da…
You're receiving this email because of your account on gitlab.torproject.org.
morgan pushed to branch main at The Tor Project / Applications / tor-browser-build
Commits:
b585a1a9 by Nicolas Vigier at 2024-10-07T23:48:35+02:00
Bug 41260: Don't set legacy version for Mullvad Browser
First part was done in f27b37421deb3dd27fb76ee40cfb6ec77c9012a2. But
this part was missed.
- - - - -
1 changed file:
- projects/release/update_responses_config.yml
Changes:
=====================================
projects/release/update_responses_config.yml
=====================================
@@ -29,7 +29,7 @@ build_targets:
channels:
[% c('var/channel') %]:
- [% c("var/torbrowser_version") %]
-[% IF c("var/torbrowser_legacy_version") -%]
+[% IF c("var/tor-browser") && c("var/torbrowser_legacy_version") -%]
- [% c("var/torbrowser_legacy_version") %]
[% END -%]
versions:
View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/commit/b…
--
View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser-build/-/commit/b…
You're receiving this email because of your account on gitlab.torproject.org.
Pier Angelo Vendrame pushed to branch mullvad-browser-128.3.0esr-14.0-1 at The Tor Project / Applications / Mullvad Browser
Commits:
03a35fcd by Pier Angelo Vendrame at 2024-10-08T12:23:46+02:00
fixup! MB 38: Mullvad Browser configuration
Bug 42356: Preference review for Firefox ESR128.
Remove privacy.webrtc.legacyGlobalIndicator, as it is not supported by
Firefox anymore.
- - - - -
1 changed file:
- browser/app/profile/000-mullvad-browser.js
Changes:
=====================================
browser/app/profile/000-mullvad-browser.js
=====================================
@@ -18,11 +18,6 @@ pref("doh-rollout.disable-heuristics", true);
// mullvad-browser#37: Customization for the about dialog
pref("app.releaseNotesURL.aboutDialog", "about:blank");
-// mullvad-browser#94: Disable legacy global microphone/webcam indicator
-// Disable the legacy Firefox Quantum-styled global webcam/microphone indicator in favor of each
-// platform's native indicator
-pref("privacy.webrtc.legacyGlobalIndicator", false);
-
// mullvad-browser#87: Windows and Linux need additional work to make the
// default browser choice working.
// We are shipping only the portable versions for the initial release anyway, so
View it on GitLab: https://gitlab.torproject.org/tpo/applications/mullvad-browser/-/commit/03a…
--
View it on GitLab: https://gitlab.torproject.org/tpo/applications/mullvad-browser/-/commit/03a…
You're receiving this email because of your account on gitlab.torproject.org.
ma1 pushed to branch mullvad-browser-128.3.0esr-14.0-1 at The Tor Project / Applications / Mullvad Browser
Commits:
93669b13 by hackademix at 2024-10-08T09:06:43+02:00
fixup! Firefox preference overrides.
Bug 43197: Disable automatic exception for HTTPS-First.
- - - - -
1 changed file:
- browser/app/profile/001-base-profile.js
Changes:
=====================================
browser/app/profile/001-base-profile.js
=====================================
@@ -120,6 +120,8 @@ pref("dom.security.https_only_mode", true);
// The previous pref automatically sets this to true (see StaticPrefList.yaml),
// but set it anyway only as a defense-in-depth.
pref("dom.security.https_only_mode_pbm", true);
+// tor-browser#43197, defense in depth if ever https-only got disabled
+pref("dom.security.https_first_add_exception_on_failiure", false);
// tor-browser#22320: Hide referer when comming from a .onion address
// We enable this here (rather than in Tor Browser) in case users of other
View it on GitLab: https://gitlab.torproject.org/tpo/applications/mullvad-browser/-/commit/936…
--
View it on GitLab: https://gitlab.torproject.org/tpo/applications/mullvad-browser/-/commit/936…
You're receiving this email because of your account on gitlab.torproject.org.
ma1 pushed to branch base-browser-128.3.0esr-14.0-1 at The Tor Project / Applications / Tor Browser
Commits:
905e6a95 by hackademix at 2024-10-08T09:06:30+02:00
fixup! Firefox preference overrides.
Bug 43197: Disable automatic exception for HTTPS-First.
- - - - -
1 changed file:
- browser/app/profile/001-base-profile.js
Changes:
=====================================
browser/app/profile/001-base-profile.js
=====================================
@@ -120,6 +120,8 @@ pref("dom.security.https_only_mode", true);
// The previous pref automatically sets this to true (see StaticPrefList.yaml),
// but set it anyway only as a defense-in-depth.
pref("dom.security.https_only_mode_pbm", true);
+// tor-browser#43197, defense in depth if ever https-only got disabled
+pref("dom.security.https_first_add_exception_on_failiure", false);
// tor-browser#22320: Hide referer when comming from a .onion address
// We enable this here (rather than in Tor Browser) in case users of other
View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/905e6a9…
--
View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/905e6a9…
You're receiving this email because of your account on gitlab.torproject.org.
ma1 pushed to branch tor-browser-128.3.0esr-14.0-1 at The Tor Project / Applications / Tor Browser
Commits:
b0b0ccd9 by hackademix at 2024-10-07T23:25:50+02:00
fixup! Firefox preference overrides.
Bug 43197: Disable automatic exception for HTTPS-First.
- - - - -
1 changed file:
- browser/app/profile/001-base-profile.js
Changes:
=====================================
browser/app/profile/001-base-profile.js
=====================================
@@ -120,6 +120,8 @@ pref("dom.security.https_only_mode", true);
// The previous pref automatically sets this to true (see StaticPrefList.yaml),
// but set it anyway only as a defense-in-depth.
pref("dom.security.https_only_mode_pbm", true);
+// tor-browser#43197, defense in depth if ever https-only got disabled
+pref("dom.security.https_first_add_exception_on_failiure", false);
// tor-browser#22320: Hide referer when comming from a .onion address
// We enable this here (rather than in Tor Browser) in case users of other
View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/b0b0ccd…
--
View it on GitLab: https://gitlab.torproject.org/tpo/applications/tor-browser/-/commit/b0b0ccd…
You're receiving this email because of your account on gitlab.torproject.org.