October 2021 - tbb-commits - lists.torproject.org

[tor-browser-build/master] Bug 40366: Use bullseye to build https-everywhere
by boklm＠torproject.org 29 Oct '21

29 Oct '21

commit ad7289e3af09b1883e13305fe49ef24cb218c3b3 Author: Nicolas Vigier <boklm(a)torproject.org> Date: Fri Sep 24 15:56:36 2021 +0200 Bug 40366: Use bullseye to build https-everywhere --- projects/https-everywhere/config | 6 +++--- rbm.conf | 8 ++++---- 2 files changed, 7 insertions(+), 7 deletions(-) diff --git a/projects/https-everywhere/config b/projects/https-everywhere/config index f51b13c..13fd3bd 100644 --- a/projects/https-everywhere/config +++ b/projects/https-everywhere/config @@ -10,14 +10,14 @@ var: # HTTPS Everywhere is expected to be the same on all platforms. To avoid # building the same thing 4 times, using 4 different container images # (each one with a different suite or architecture), we set the container - # to buster/amd64 for all platforms. This allows us to create only one + # to bullseye/amd64 for all platforms. This allows us to create only one # container image, and also build the extension only one time as the # filename does not contain the platform, and var/build_id should be # the same since there is now nothing platform specific in the build # inputs. This allows us to save a little time and disk space. container: use_container: 1 - suite: buster + suite: bullseye arch: amd64 deps: - git @@ -34,4 +34,4 @@ input_files: - project: python name: python target_prepend: - - common-buster + - common-bullseye diff --git a/rbm.conf b/rbm.conf index dc7072b..b5c0566 100644 --- a/rbm.conf +++ b/rbm.conf @@ -247,13 +247,13 @@ targets: # Don't create mar files to save time build_mar: 0 - # The common-buster target is used to build components that are common to all - # platforms, using Debian Buster. - common-buster: + # The common-bullseye target is used to build components that are common to all + # platforms, using Debian Bullseye. + common-bullseye: var: common: 1 container: - suite: buster + suite: bullseye arch: amd64 pre_pkginst: '' deps:

1 0

[tor-browser-build/master] Bug 40368: Use system's python3 for https-everywhere
by boklm＠torproject.org 29 Oct '21

29 Oct '21

commit ce2c78e4ccc24a4b46ff9336f54b1ec8129e430c Author: Nicolas Vigier <boklm(a)torproject.org> Date: Thu Sep 30 14:40:45 2021 +0200 Bug 40368: Use system's python3 for https-everywhere --- projects/https-everywhere/build | 1 - projects/https-everywhere/config | 6 ++---- rbm.conf | 17 ----------------- 3 files changed, 2 insertions(+), 22 deletions(-) diff --git a/projects/https-everywhere/build b/projects/https-everywhere/build index 88431e0..10dd4bf 100644 --- a/projects/https-everywhere/build +++ b/projects/https-everywhere/build @@ -1,6 +1,5 @@ #!/bin/bash [% c("var/set_default_env") -%] -[% pc('python', 'var/setup', { python_tarfile => c('input_files_by_name/python') }) %] tar xf [% project %]-[% c('version') %].tar.gz cd [% project %]-[% c('version') %] ./make.sh diff --git a/projects/https-everywhere/config b/projects/https-everywhere/config index 13fd3bd..9af5ff6 100644 --- a/projects/https-everywhere/config +++ b/projects/https-everywhere/config @@ -27,11 +27,9 @@ var: - rsync - zip - unzip + - python3 + - python3-distutils pre_pkginst: '' input_files: - project: container-image - - project: python - name: python - target_prepend: - - common-bullseye diff --git a/rbm.conf b/rbm.conf index b5c0566..7295953 100644 --- a/rbm.conf +++ b/rbm.conf @@ -247,23 +247,6 @@ targets: # Don't create mar files to save time build_mar: 0 - # The common-bullseye target is used to build components that are common to all - # platforms, using Debian Bullseye. - common-bullseye: - var: - common: 1 - container: - suite: bullseye - arch: amd64 - pre_pkginst: '' - deps: - - build-essential - - python - - automake - - libtool - - zip - - unzip - torbrowser-android-armv7: - android-armv7 - android

1 0

[tor-browser/tor-browser-91.2.0esr-11.0-1] Bug 40483: Temporarily redirect DW's v2 address to their new v3 address
by sysrqb＠torproject.org 29 Oct '21

29 Oct '21

commit 4928a95242dcd3e617cc1abc3231fab7c0015e0a Author: Matthew Finkel <sysrqb(a)torproject.org> Date: Mon Oct 4 22:45:56 2021 +0000 Bug 40483: Temporarily redirect DW's v2 address to their new v3 address --- docshell/base/nsDocShell.cpp | 13 +++++++++++++ 1 file changed, 13 insertions(+) diff --git a/docshell/base/nsDocShell.cpp b/docshell/base/nsDocShell.cpp index c86fed307be6..080754c938b8 100644 --- a/docshell/base/nsDocShell.cpp +++ b/docshell/base/nsDocShell.cpp @@ -5990,6 +5990,7 @@ already_AddRefed<nsIURI> nsDocShell::AttemptURIFixup( bool aNotifyKeywordSearchLoading, nsIInputStream** aNewPostData) { if (aStatus != NS_ERROR_UNKNOWN_HOST && aStatus != NS_ERROR_NET_RESET && aStatus != NS_ERROR_CONNECTION_REFUSED && + aStatus != NS_ERROR_TOR_ONION_SVC_BAD_ADDRESS && aStatus != mozilla::psm::GetXPCOMFromNSSError(SSL_ERROR_BAD_CERT_DOMAIN)) { return nullptr; @@ -6137,6 +6138,18 @@ already_AddRefed<nsIURI> nsDocShell::AttemptURIFixup( } } } + } else if (aStatus == NS_ERROR_TOR_ONION_SVC_BAD_ADDRESS) { + // Bug 40483: Temporarily redirect DW's v2 address to their new v3 address + constexpr auto kV2DW = "dwnewsvdyyiamwnp.onion"_ns; + constexpr auto kV3DW = "dwnewsgngmhlplxy6o2twtfgjnrnjxbegbwqx6wnotdhkzt562tszfid.onion"_ns; + nsAutoCString host; + newURI = nullptr; + Unused << url->GetHost(host); + if (StringEndsWith(host, kV2DW)) { + auto& subdomains = Substring(host, 0, host.Length() - kV2DW.Length()); + Unused << NS_MutateURI(url).SetHost(subdomains + kV3DW).Finalize( + getter_AddRefs(newURI)); + } } else if (aStatus == NS_ERROR_CONNECTION_REFUSED && Preferences::GetBool("browser.fixup.fallback-to-https", false)) { // Try HTTPS, since http didn't work

1 0

[tor-browser/tor-browser-91.2.0esr-11.0-1] Merge remote-tracking branch 'richardgl/40657' into tor-browser-91.2.0esr-11.0-1
by sysrqb＠torproject.org 27 Oct '21

27 Oct '21

commit 5fc7f2c499303029af14826cc34bbf607e6c4295 Merge: 562c608deb02 9b34a8f00237 Author: Matthew Finkel <sysrqb(a)torproject.org> Date: Wed Oct 27 16:15:45 2021 +0000 Merge remote-tracking branch 'richardgl/40657' into tor-browser-91.2.0esr-11.0-1 browser/base/content/appmenu-viewcache.inc.xhtml | 11 +++++++++++ browser/themes/shared/menupanel.inc.css | 13 ++++++------- 2 files changed, 17 insertions(+), 7 deletions(-)

1 0

[tor-browser/tor-browser-91.2.0esr-11.0-1] fixup! Bug 10760: Integrate TorButton to TorBrowser core
by sysrqb＠torproject.org 27 Oct '21

27 Oct '21

commit dde53322cd4e444f490abc6dedd4a2ceb4f2dbab Author: Richard Pospesel <richard(a)torproject.org> Date: Wed Oct 13 14:13:24 2021 +0200 fixup! Bug 10760: Integrate TorButton to TorBrowser core --- browser/base/content/appmenu-viewcache.inc.xhtml | 11 +++++++++++ browser/themes/shared/menupanel.inc.css | 8 -------- 2 files changed, 11 insertions(+), 8 deletions(-) diff --git a/browser/base/content/appmenu-viewcache.inc.xhtml b/browser/base/content/appmenu-viewcache.inc.xhtml index c86a60a9d847..0812e0e84f45 100644 --- a/browser/base/content/appmenu-viewcache.inc.xhtml +++ b/browser/base/content/appmenu-viewcache.inc.xhtml @@ -269,6 +269,17 @@ key="key_privatebrowsing" command="Tools:PrivateBrowsing"/> <toolbarseparator/> + <toolbarbutton id="appMenuNewIdentity" + class="subviewbutton" + key="torbutton-new-identity-key" + label="&torbutton.context_menu.new_identity;" + oncommand="torbutton_new_identity();"/> + <toolbarbutton id="appMenuNewCircuit" + class="subviewbutton" + key="torbutton-new-circuit-key" + label="&torbutton.context_menu.new_circuit;" + oncommand="torbutton_new_circuit();"/> + <toolbarseparator/> <toolbarbutton id="appMenu-bookmarks-button" class="subviewbutton subviewbutton-nav" data-l10n-id="library-bookmarks-menu" diff --git a/browser/themes/shared/menupanel.inc.css b/browser/themes/shared/menupanel.inc.css index 355477453773..4629e5e86891 100644 --- a/browser/themes/shared/menupanel.inc.css +++ b/browser/themes/shared/menupanel.inc.css @@ -23,11 +23,3 @@ #appMenu-fullscreen-button2[checked] { list-style-image: url(chrome://browser/skin/fullscreen-exit.svg); } - -#appMenuNewIdentity { - list-style-image: url("chrome://browser/skin/new_identity.svg"); -} - -#appMenuNewCircuit { - list-style-image: url("chrome://browser/skin/new_circuit.svg"); -}

1 0

[tor-browser/tor-browser-91.2.0esr-11.0-1] fixup! TB4: Tor Browser's Firefox preference overrides.
by sysrqb＠torproject.org 27 Oct '21

27 Oct '21

commit 9b34a8f002374f36543a7cf1dfa2b37e8ade83ef Author: Richard Pospesel <richard(a)torproject.org> Date: Wed Oct 13 14:22:27 2021 +0200 fixup! TB4: Tor Browser's Firefox preference overrides. --- browser/themes/shared/menupanel.inc.css | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/browser/themes/shared/menupanel.inc.css b/browser/themes/shared/menupanel.inc.css index 4629e5e86891..ef71035f5fd5 100644 --- a/browser/themes/shared/menupanel.inc.css +++ b/browser/themes/shared/menupanel.inc.css @@ -23,3 +23,10 @@ #appMenu-fullscreen-button2[checked] { list-style-image: url(chrome://browser/skin/fullscreen-exit.svg); } + +/* hide the separate new private window button when all windows are private */ +@supports -moz-bool-pref("browser.privatebrowsing.autostart") { + toolbarbutton#appMenu-new-private-window-button2 { + display: none; + } +} \ No newline at end of file

1 0

[tor-browser/tor-browser-91.2.0esr-11.0-1] fixup! Bug 10760: Integrate TorButton to TorBrowser core
by sysrqb＠torproject.org 27 Oct '21

27 Oct '21

commit 562c608deb02ccf1756f62f85b3afb0a1635152d Author: Matthew Finkel <sysrqb(a)torproject.org> Date: Wed Oct 27 16:00:43 2021 +0000 fixup! Bug 10760: Integrate TorButton to TorBrowser core --- toolkit/torproject/torbutton | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/toolkit/torproject/torbutton b/toolkit/torproject/torbutton index 36c269168552..8fc112b749be 160000 --- a/toolkit/torproject/torbutton +++ b/toolkit/torproject/torbutton @@ -1 +1 @@ -Subproject commit 36c269168552a5bb0dcd0858bc868bcbe77d3215 +Subproject commit 8fc112b749bed1bd48589b1c12bf27e66648d4dd

1 0

[torbutton/master] fixup! Bug 40051: Implement 2021 Year End Campaign look in about:tor
by sysrqb＠torproject.org 27 Oct '21

27 Oct '21

commit 8b9c56f7080aab4bbb5d6f6516e7c828e017f534 Author: Richard Pospesel <richard(a)torproject.org> Date: Wed Oct 27 15:01:40 2021 +0200 fixup! Bug 40051: Implement 2021 Year End Campaign look in about:tor --- chrome/skin/aboutTor.css | 23 +++++++++++++++++++++++ 1 file changed, 23 insertions(+) diff --git a/chrome/skin/aboutTor.css b/chrome/skin/aboutTor.css index 2db20151..49b3e21a 100644 --- a/chrome/skin/aboutTor.css +++ b/chrome/skin/aboutTor.css @@ -202,6 +202,8 @@ body:not([showmanual]) .showForManual { margin-block-start: 1em; margin-inline-end: auto; background-color: var(--abouttor-donate-button-bg); + outline-color: var(--abouttor-donate-button-bg); + outline-style: none; color: var(--abouttor-donate-button-color); font-family: sans-serif; font-weight: bold; @@ -213,14 +215,24 @@ body:not([showmanual]) .showForManual { max-height: 3em; height: 3em; line-height: 3em; + + } #donateButton:hover { background-color: var(--abouttor-donate-button-bg-hover); + outline-color: var(--abouttor-donate-button-bg-hover); } #donateButton:active { background-color: var(--abouttor-donate-button-bg-active); + outline-color: var(--abouttor-donate-button-bg-active); +} + +#donateButton:focus-visible { + outline-style: dotted; + outline-width: 1px; + outline-offset: 2px; } #bottom { @@ -305,6 +317,17 @@ body:not([showmanual]) .showForManual { margin: 0; font-size: 15px; } + +#search-text:focus-visible { + outline: none; +} + +#search-button:focus-visible { + outline: 1px dotted black; + outline-offset: -6px; +} + + /* * Mobile specific css */

1 0

[torbutton/master] Merge remote-tracking branches 'richardgl/40057' and 'richardgl/40058'
by sysrqb＠torproject.org 27 Oct '21

27 Oct '21

commit 8fc112b749bed1bd48589b1c12bf27e66648d4dd Merge: fb69c2dc 66abd8c1 8b9c56f7 Author: Matthew Finkel <sysrqb(a)torproject.org> Date: Wed Oct 27 16:03:52 2021 +0000 Merge remote-tracking branches 'richardgl/40057' and 'richardgl/40058' chrome/content/torbutton.js | 35 +++++------------------------------ chrome/skin/aboutTor.css | 23 +++++++++++++++++++++++ 2 files changed, 28 insertions(+), 30 deletions(-)

1 0

[torbutton/master] Bug 40057: Error popup when using New Identity feature
by sysrqb＠torproject.org 27 Oct '21

27 Oct '21

commit 66abd8c194b0518c84c7ac94e5094315741d2ece Author: Richard Pospesel <richard(a)torproject.org> Date: Tue Oct 26 16:03:08 2021 +0200 Bug 40057: Error popup when using New Identity feature --- chrome/content/torbutton.js | 35 +++++------------------------------ 1 file changed, 5 insertions(+), 30 deletions(-) diff --git a/chrome/content/torbutton.js b/chrome/content/torbutton.js index c05dd605..65048b1a 100644 --- a/chrome/content/torbutton.js +++ b/chrome/content/torbutton.js @@ -556,34 +556,6 @@ async function torbutton_do_new_identity() { torbutton_log(3, "New Identity: Clearing Image Cache"); torbutton_clear_image_caches(); - torbutton_log(3, "New Identity: Clearing Offline Cache"); - - try { - const LoadContextInfo = Services.loadContextInfo; - - for (let contextInfo of [LoadContextInfo.default, LoadContextInfo.private]) { - let appCacheStorage = Services.cache2.appCacheStorage(contextInfo, null); - // The following call (asyncEvictStorage) is actually synchronous, either - // if we have pref "browser.cache.use_new_backend" -> 1 or - // "browser.cache.use_new_backend_temp" -> true, - // then we are using the new cache (cache2) which operates synchronously. - // If we are using the old cache, then the tor-browser.git patch for - // #5715 also makes this synchronous. So we pass a null callback. - try { - appCacheStorage.asyncEvictStorage(null); - } catch (err) { - // We ignore "not available" errors because they occur if a cache - // has not been used, e.g., if no browsing has been done. - if (err.name !== 'NS_ERROR_NOT_AVAILABLE') { - throw err; - } - } - } - } catch(e) { - torbutton_log(5, "Exception on cache clearing: "+e); - window.alert("Torbutton: Unexpected error during offline cache clearing: "+e); - } - torbutton_log(3, "New Identity: Clearing Disk and Memory Caches"); try { @@ -1086,8 +1058,11 @@ function torbutton_disable_browser_js(browser) { torbutton_log(4, "Failed to disable JS events: "+e) } - if (browser.docShell) - browser.docShell.allowJavascript = false; + let { browsingContext } = browser; + + if (browsingContext) { + browsingContext.allowJavascript = false; + } try { // My estimation is that this does not get the inner iframe windows,

1 0