September 2019 - tbb-commits - lists.torproject.org

[tor-browser/tor-browser-60.9.0esr-8.5-2] Pick up Torbutton 2.1.14
by gk＠torproject.org 09 Sep '19

09 Sep '19

commit 0e179ca39eabf6465b585d719832f3020e5df790 Author: Georg Koppen <gk(a)torproject.org> Date: Mon Sep 9 06:03:00 2019 +0000 Pick up Torbutton 2.1.14 --- toolkit/torproject/torbutton | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/toolkit/torproject/torbutton b/toolkit/torproject/torbutton index 850024dd1bef..6963d9bfe669 160000 --- a/toolkit/torproject/torbutton +++ b/toolkit/torproject/torbutton @@ -1 +1 @@ -Subproject commit 850024dd1bef30256f0ef443d4761aa43a3b84f6 +Subproject commit 6963d9bfe669dcb03ac23058c68989a74e3b7d1c

1 0

[torbutton/maint-2.1] Release prep for 2.1.14
by gk＠torproject.org 09 Sep '19

09 Sep '19

commit 6963d9bfe669dcb03ac23058c68989a74e3b7d1c Author: Georg Koppen <gk(a)torproject.org> Date: Mon Sep 9 05:59:06 2019 +0000 Release prep for 2.1.14 CHANGELOG update and version bump --- src/CHANGELOG | 3 +++ src/install.rdf | 2 +- 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/src/CHANGELOG b/src/CHANGELOG index 9435d991..17a8e15a 100644 --- a/src/CHANGELOG +++ b/src/CHANGELOG @@ -1,3 +1,6 @@ +2.1.14 + * Bug 31616: Do not enable JIT on aarch64 + 2.1.13 * Bug 31520: Remove monthly giving banner from Tor Browser * Bug 31140: Do not enable IonMonkey on AARCH64 diff --git a/src/install.rdf b/src/install.rdf index df859c72..dedb2c81 100644 --- a/src/install.rdf +++ b/src/install.rdf @@ -6,7 +6,7 @@ <em:name>Torbutton</em:name> <em:creator>Mike Perry</em:creator> <em:id>torbutton(a)torproject.org</em:id> - <em:version>2.1.13</em:version> + <em:version>2.1.14</em:version> <em:multiprocessCompatible>true</em:multiprocessCompatible> <em:homepageURL>https://www.torproject.org/projects/torbrowser.html.en</em:homepageURL> <em:iconURL>chrome://torbutton/skin/tor.png</em:iconURL>

1 0

[torbutton/maint-2.1] Bug 31616: Fix JIT related crashes on aarch64
by gk＠torproject.org 08 Sep '19

08 Sep '19

commit 7d292d774a3605673c912b2d3a248b95c6fabcb1 Author: Georg Koppen <gk(a)torproject.org> Date: Sat Sep 7 20:19:56 2019 +0000 Bug 31616: Fix JIT related crashes on aarch64 Patch by sysrqb. --- src/modules/security-prefs.js | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/modules/security-prefs.js b/src/modules/security-prefs.js index fb465a05..a0a4ad4d 100644 --- a/src/modules/security-prefs.js +++ b/src/modules/security-prefs.js @@ -47,9 +47,11 @@ const kCustomPref = "extensions.torbutton.security_custom"; var write_setting_to_prefs = function (settingIndex) { Object.keys(kSecuritySettings).forEach( prefName => { - // Bug 31140 - Do not enable IonMonkey on AARCH64. + // Bug 31140 and 31616 - Do not enable JIT on aarch64. if (XPCOMABI.split("-")[0] == "aarch64" && - prefName == "javascript.options.ion") { + (prefName == "javascript.options.ion" || + prefName == "javascript.options.baselinejit" || + prefName == "javascript.options.native_regexp")) { setBoolPref(prefName, false); return; }

1 0

[torbutton/master] Bug 31562: Fix circuit display for error pages
by gk＠torproject.org 06 Sep '19

06 Sep '19

commit bb975009a65ab9039641d03b11023fe6c52f5b7a Author: Alex Catarineu <acat(a)torproject.org> Date: Thu Sep 5 17:56:08 2019 +0200 Bug 31562: Fix circuit display for error pages --- chrome/content/torbutton.js | 2 +- modules/utils.js | 49 +++++++++++++++++++++++---------------------- 2 files changed, 26 insertions(+), 25 deletions(-) diff --git a/chrome/content/torbutton.js b/chrome/content/torbutton.js index 9d6a5c48..94206ea5 100644 --- a/chrome/content/torbutton.js +++ b/chrome/content/torbutton.js @@ -850,7 +850,7 @@ function torbutton_send_ctrl_cmd(command) { // Bug 1506 P4: Needed for New IP Address function torbutton_new_circuit() { - let firstPartyDomain = getDomainForBrowser(gBrowser); + let firstPartyDomain = getDomainForBrowser(gBrowser.selectedBrowser); let domainIsolator = Cc["@torproject.org/domain-isolator;1"] .getService(Ci.nsISupports).wrappedJSObject; diff --git a/modules/utils.js b/modules/utils.js index ea41fce9..0caf475f 100644 --- a/modules/utils.js +++ b/modules/utils.js @@ -4,9 +4,6 @@ // ### Import Mozilla Services const { Services } = ChromeUtils.import("resource://gre/modules/Services.jsm"); -// ### About firstPartyDomain literal -const k_tb_about_uri_first_party_domain = "about.ef2a7dd5-93bc-417f-a698-142c3116864f.mozilla"; - // ## Pref utils // __prefs__. A shortcut to Mozilla Services.prefs. @@ -212,30 +209,34 @@ var show_torbrowser_manual = () => { return availableLocales.indexOf(shortLocale) >= 0; } +var getFPDFromHost = (hostname) => { + try { + return Services.eTLD.getBaseDomainFromHost(hostname); + } catch (e) { + if (e.result == Cr.NS_ERROR_HOST_IS_IP_ADDRESS || + e.result == Cr.NS_ERROR_INSUFFICIENT_DOMAIN_LEVELS) { + return hostname; + } + } + return null; +} + +// Assuming this is called with gBrowser.selectedBrowser var getDomainForBrowser = (browser) => { - let firstPartyDomain = browser.contentPrincipal.originAttributes.firstPartyDomain; - // Bug 22538: For neterror or certerror, get firstPartyDomain causing it from the u param - if (firstPartyDomain === k_tb_about_uri_first_party_domain) { - let knownErrors = ["about:neterror", "about:certerror"]; - let origin = browser.contentPrincipal.origin || ''; - if (knownErrors.some(x => origin.startsWith(x))) { - try { - let urlOrigin = new URL(origin); - let { hostname } = new URL(urlOrigin.searchParams.get('u')); - if (hostname) { - try { - firstPartyDomain = Services.eTLD.getBaseDomainFromHost(hostname); - } catch (e) { - if (e.result == Cr.NS_ERROR_HOST_IS_IP_ADDRESS || - e.result == Cr.NS_ERROR_INSUFFICIENT_DOMAIN_LEVELS) { - firstPartyDomain = hostname; - } - } - } - } catch (e) {} + let fpd = browser.contentPrincipal.originAttributes.firstPartyDomain; + // Bug 31562: For neterror or certerror, get the original URL from + // browser.currentURI and use it to calculate the firstPartyDomain. + let knownErrors = ["about:neterror", "about:certerror"]; + let documentURI = browser.documentURI; + if (documentURI && documentURI.schemeIs('about') && + knownErrors.some(x => documentURI.spec.startsWith(x))) { + let knownSchemes = ["http", "https", "ftp"]; + let currentURI = browser.currentURI; + if (currentURI && knownSchemes.some(x => currentURI.schemeIs(x))) { + fpd = getFPDFromHost(currentURI.host) || fpd; } } - return firstPartyDomain; + return fpd; }; // Export utility functions for external use.

1 0

[tor-browser/tor-browser-68.1.0esr-9.0-2] Bug 31457: disable per-installation profiles
by gk＠torproject.org 06 Sep '19

06 Sep '19

commit 31d00e2f9c23184c2378d125c11a4e1219a8b59e Author: Kathy Brade <brade(a)pearlcrescent.com> Date: Wed Sep 4 08:23:19 2019 -0400 Bug 31457: disable per-installation profiles The dedicated profiles (per-installation) feature does not interact well with our bundled profiles on Linux and Windows, and it also causes multiple profiles to be created on macOS under TorBrowser-Data. --- browser/moz.configure | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/browser/moz.configure b/browser/moz.configure index 3057a5040c5f..43bc0c1fe59b 100644 --- a/browser/moz.configure +++ b/browser/moz.configure @@ -7,7 +7,7 @@ imply_option('MOZ_PLACES', True) imply_option('MOZ_SERVICES_HEALTHREPORT', True) imply_option('MOZ_SERVICES_SYNC', True) -imply_option('MOZ_DEDICATED_PROFILES', True) +imply_option('MOZ_DEDICATED_PROFILES', False) imply_option('MOZ_BLOCK_PROFILE_DOWNGRADE', True) with only_when(target_is_linux & compile_environment):

1 0

[tor-browser/tor-browser-68.1.0esr-9.0-2] Pick up Torbutton changes for onboarding
by gk＠torproject.org 06 Sep '19

06 Sep '19

commit 936ea93a3e8dc9846c2e738096a3ad8a0fe90325 Author: Georg Koppen <gk(a)torproject.org> Date: Fri Sep 6 10:02:40 2019 +0000 Pick up Torbutton changes for onboarding --- toolkit/torproject/torbutton | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/toolkit/torproject/torbutton b/toolkit/torproject/torbutton index 1edfec57049a..d796dd27d128 160000 --- a/toolkit/torproject/torbutton +++ b/toolkit/torproject/torbutton @@ -1 +1 @@ -Subproject commit 1edfec57049a76052fda8eb17b6e3b8f281e3361 +Subproject commit d796dd27d12850bd176a85e160002755bfccfab2

1 0

[tor-browser/tor-browser-68.1.0esr-9.0-2] fixup! Bug 28822: Convert onboarding to webextension
by gk＠torproject.org 06 Sep '19

06 Sep '19

commit b4e8db514df16856b567be1e13cb9af11a7de6e5 Author: Alex Catarineu <acat(a)torproject.org> Date: Mon Sep 2 12:06:24 2019 +0200 fixup! Bug 28822: Convert onboarding to webextension --- browser/extensions/onboarding/content/Onboarding.jsm | 2 +- extensions/permissions/nsPermissionManager.cpp | 3 +++ 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/browser/extensions/onboarding/content/Onboarding.jsm b/browser/extensions/onboarding/content/Onboarding.jsm index 33777dd27d6e..059701f78960 100644 --- a/browser/extensions/onboarding/content/Onboarding.jsm +++ b/browser/extensions/onboarding/content/Onboarding.jsm @@ -8,7 +8,7 @@ var EXPORTED_SYMBOLS = ["Onboarding"]; -const {Services} = ChromeUtils.import("resource://gre/modules/Services.jsm"); +const { Services } = ChromeUtils.import("resource://gre/modules/Services.jsm"); const ONBOARDING_CSS_URL = "resource://onboarding/onboarding.css"; const TORBUTTON_BUNDLE_URI = "chrome://torbutton/locale/browserOnboarding.properties"; diff --git a/extensions/permissions/nsPermissionManager.cpp b/extensions/permissions/nsPermissionManager.cpp index 1a652bef4222..2e23d48623e8 100644 --- a/extensions/permissions/nsPermissionManager.cpp +++ b/extensions/permissions/nsPermissionManager.cpp @@ -125,6 +125,9 @@ static const nsLiteralCString kPreloadPermissions[] = { NS_LITERAL_CSTRING("cookie"), NS_LITERAL_CSTRING("trackingprotection"), NS_LITERAL_CSTRING("trackingprotection-pb"), + // Bug 28822: Make sure uitour permissions are preloaded in content processes. + NS_LITERAL_CSTRING("uitour"), + USER_INTERACTION_PERM}; // NOTE: nullptr can be passed as aType - if it is this function will return

1 0

[tor-browser/tor-browser-68.1.0esr-9.0-2] fixup! Bug 29768: Introduce new features to users
by gk＠torproject.org 06 Sep '19

06 Sep '19

commit 535d41fd820d5b94caf43f3e403dc74b3566c837 Author: Alex Catarineu <acat(a)torproject.org> Date: Mon Sep 2 11:45:55 2019 +0200 fixup! Bug 29768: Introduce new features to users Fixes bug 30560 --- .../content/img/figure_tor-security-level.png | Bin 10888 -> 11263 bytes .../content/img/figure_tor-toolbar-layout.png | Bin 5837 -> 10569 bytes .../extensions/onboarding/content/onboarding.css | 8 ++------ 3 files changed, 2 insertions(+), 6 deletions(-) diff --git a/browser/extensions/onboarding/content/img/figure_tor-security-level.png b/browser/extensions/onboarding/content/img/figure_tor-security-level.png index 4f940ea008ef..9a5c221c8d8e 100644 Binary files a/browser/extensions/onboarding/content/img/figure_tor-security-level.png and b/browser/extensions/onboarding/content/img/figure_tor-security-level.png differ diff --git a/browser/extensions/onboarding/content/img/figure_tor-toolbar-layout.png b/browser/extensions/onboarding/content/img/figure_tor-toolbar-layout.png index 0a8161087827..624ef6514d39 100644 Binary files a/browser/extensions/onboarding/content/img/figure_tor-toolbar-layout.png and b/browser/extensions/onboarding/content/img/figure_tor-toolbar-layout.png differ diff --git a/browser/extensions/onboarding/content/onboarding.css b/browser/extensions/onboarding/content/onboarding.css index 7373e0da53fc..f71ec1d13789 100644 --- a/browser/extensions/onboarding/content/onboarding.css +++ b/browser/extensions/onboarding/content/onboarding.css @@ -27,7 +27,7 @@ padding: 16px 0 0 0; position: fixed; top: 4px; - offset-inline-start: 12px; + inset-inline-start: 12px; } /* @@ -41,7 +41,7 @@ width: 20px; height: 20px; top: -8px; - offset-inline-start: -16px; + inset-inline-start: -16px; background-color: #00E2B1; border-radius: 50%; animation: pulsate 2.0s ease-out; @@ -61,11 +61,7 @@ } #onboarding-overlay-button { - padding: 10px 0 0 0; - position: fixed; cursor: pointer; - top: 4px; - inset-inline-start: 12px; border: none; /* Set to none so no grey contrast background in the high-contrast mode */ background: none;

1 0

[tor-browser/tor-browser-68.1.0esr-9.0-2] fixup! Bug 26962 - implement new features onboarding (part 1).
by gk＠torproject.org 06 Sep '19

06 Sep '19

commit 915d521a2fae009509a229bdaeb1d3a95a17b8c1 Author: Alex Catarineu <acat(a)torproject.org> Date: Mon Sep 2 12:12:18 2019 +0200 fixup! Bug 26962 - implement new features onboarding (part 1). --- browser/app/permissions | 2 -- browser/themes/shared/UITour.inc.css | 1 - 2 files changed, 3 deletions(-) diff --git a/browser/app/permissions b/browser/app/permissions index c9feba65b69f..fa17e78db211 100644 --- a/browser/app/permissions +++ b/browser/app/permissions @@ -9,8 +9,6 @@ # UITour # DuckDuckGo .onion (used for circuit display onboarding). origin uitour 1 https://3g2upl4pq6kufc4m.onion -origin uitour 1 about:home -origin uitour 1 about:newtab origin uitour 1 about:tor # Remote troubleshooting diff --git a/browser/themes/shared/UITour.inc.css b/browser/themes/shared/UITour.inc.css index bfc782c68c5f..235e4d898e78 100644 --- a/browser/themes/shared/UITour.inc.css +++ b/browser/themes/shared/UITour.inc.css @@ -132,7 +132,6 @@ padding-right: 10px; } -/* The primary button gets the same color as the customize button. */ #UITourTooltipButtons > button.button-primary { background-color: #420C5D; color: white;

1 0

[tor-browser/tor-browser-68.1.0esr-9.0-2] Revert "Bug 1498378 - Actually remove the old onboarding add-on's prefs r=Gijs"
by gk＠torproject.org 06 Sep '19

06 Sep '19

commit 5d0ffb6cea1e3eca56884f087120f2b40aa2926b Author: Alex Catarineu <acat(a)torproject.org> Date: Mon Sep 2 12:48:36 2019 +0200 Revert "Bug 1498378 - Actually remove the old onboarding add-on's prefs r=Gijs" This reverts commit 057fe36fc6f3e93e265505c7dcc703a0941778e2. --- browser/components/BrowserGlue.jsm | 11 ----------- 1 file changed, 11 deletions(-) diff --git a/browser/components/BrowserGlue.jsm b/browser/components/BrowserGlue.jsm index 7503ca7037e6..a99a29a014ad 100644 --- a/browser/components/BrowserGlue.jsm +++ b/browser/components/BrowserGlue.jsm @@ -3086,17 +3086,6 @@ BrowserGlue.prototype = { ); } - if (currentUIVersion < 76) { - // Clear old onboarding prefs from profile (bug 1462415) - let onboardingPrefs = Services.prefs.getBranch("browser.onboarding."); - if (onboardingPrefs) { - let onboardingPrefsArray = onboardingPrefs.getChildList(""); - for (let item of onboardingPrefsArray) { - Services.prefs.clearUserPref("browser.onboarding." + item); - } - } - } - if (currentUIVersion < 77) { // Remove currentset from all the toolbars let toolbars = [

1 0