tor-commits January 2019

tor-commits@lists.torproject.org

15 participants
2081 discussions

[metrics-web/master] Leave gaps for missing data.
by karsten＠torproject.org 11 Jan '19

11 Jan '19

commit d1cedb7f2d011f8896f169338db7f0403702ea64 Author: Karsten Loesing <karsten.loesing(a)gmx.net> Date: Fri Jan 11 10:48:47 2019 +0100 Leave gaps for missing data. --- src/main/R/rserver/graphs.R | 47 ++++++++++++++++++++++++++++++--------------- 1 file changed, 31 insertions(+), 16 deletions(-) diff --git a/src/main/R/rserver/graphs.R b/src/main/R/rserver/graphs.R index 18a9d3e..0d7a90c 100644 --- a/src/main/R/rserver/graphs.R +++ b/src/main/R/rserver/graphs.R @@ -405,7 +405,9 @@ plot_versions <- function(start_p, end_p, path_p) { stringsAsFactors = FALSE) versions <- s[s$version %in% known_versions, ] visible_versions <- sort(unique(versions$version)) - ggplot(versions, aes(x = date, y = relays, colour = version)) + + versions <- versions %>% + complete(date = full_seq(date, period = 1), nesting(version)) %>% + ggplot(aes(x = date, y = relays, colour = version)) + geom_line() + scale_x_date(name = "", breaks = custom_breaks, labels = custom_labels, minor_breaks = custom_minor_breaks) + @@ -433,6 +435,7 @@ prepare_platforms <- function(start_p = NULL, end_p = NULL) { plot_platforms <- function(start_p, end_p, path_p) { prepare_platforms(start_p, end_p) %>% gather(platform, relays, -date) %>% + complete(date = full_seq(date, period = 1), nesting(platform)) %>% ggplot(aes(x = date, y = relays, colour = platform)) + geom_line() + scale_x_date(name = "", breaks = custom_breaks, @@ -470,6 +473,7 @@ prepare_dirbytes <- function(start_p = NULL, end_p = NULL) { plot_dirbytes <- function(start_p, end_p, path_p) { prepare_dirbytes(start_p, end_p) %>% gather(variable, value, -date) %>% + complete(date = full_seq(date, period = 1), nesting(variable)) %>% ggplot(aes(x = date, y = value, colour = variable)) + geom_line() + scale_x_date(name = "", breaks = custom_breaks, @@ -695,10 +699,10 @@ prepare_connbidirect <- function(start_p = NULL, end_p = NULL) { plot_connbidirect <- function(start_p, end_p, path_p) { prepare_connbidirect(start_p, end_p) %>% - ggplot(aes(x = date, y = md, colour = direction)) + - geom_line(size = 0.75) + - geom_ribbon(aes(x = date, ymin = q1, ymax = q3, - fill = direction), alpha = 0.5, show.legend = FALSE) + + complete(date = full_seq(date, period = 1), nesting(direction)) %>% + ggplot(aes(x = date, y = md, ymin = q1, ymax = q3, fill = direction)) + + geom_ribbon(alpha = 0.5) + + geom_line(aes(colour = direction), size = 0.75) + scale_x_date(name = "", breaks = custom_breaks, labels = custom_labels, minor_breaks = custom_minor_breaks) + scale_y_continuous(name = "", labels = percent, limits = c(0, NA)) + @@ -1013,11 +1017,12 @@ plot_userstats_bridge_combined <- function(start_p, end_p, country_p, path_p) { a <- aggregate(list(mid = (u$high + u$low) / 2), by = list(transport = u$transport), FUN = sum) a <- a[order(a$mid, decreasing = TRUE)[1:top], ] - u <- u[u$transport %in% a$transport, ] + u <- u[u$transport %in% a$transport, ] %>% + complete(date = full_seq(date, period = 1), nesting(country, transport)) title <- paste("Bridge users by transport from ", countryname(country_p), sep = "") ggplot(u, aes(x = as.Date(date), ymin = low, ymax = high, - colour = transport, fill = transport)) + + fill = transport)) + geom_ribbon(alpha = 0.5, size = 0.5) + scale_x_date(name = "", breaks = custom_breaks, labels = custom_labels, minor_breaks = custom_minor_breaks) + @@ -1055,6 +1060,7 @@ plot_advbwdist_perc <- function(start_p, end_p, p_p, path_p) { gather(variable, advbw, -c(date, p)) %>% mutate(variable = ifelse(variable == "all", "All relays", "Exits only")) %>% + complete(date = full_seq(date, period = 1), nesting(p, variable)) %>% ggplot(aes(x = date, y = advbw, colour = p)) + facet_grid(variable ~ .) + geom_line() + @@ -1092,6 +1098,7 @@ plot_advbwdist_relay <- function(start_p, end_p, n_p, path_p) { gather(variable, advbw, -c(date, n)) %>% mutate(variable = ifelse(variable == "all", "All relays", "Exits only")) %>% + complete(date = full_seq(date, period = 1), nesting(n, variable)) %>% ggplot(aes(x = date, y = advbw, colour = n)) + facet_grid(variable ~ .) + geom_line() + @@ -1123,6 +1130,7 @@ prepare_hidserv_dir_onions_seen <- function(start_p = NULL, end_p = NULL) { plot_hidserv_dir_onions_seen <- function(start_p, end_p, path_p) { prepare_hidserv_dir_onions_seen(start_p, end_p) %>% + complete(date = full_seq(date, period = 1)) %>% ggplot(aes(x = date, y = onions)) + geom_line() + scale_x_date(name = "", breaks = custom_breaks, @@ -1152,6 +1160,7 @@ prepare_hidserv_rend_relayed_cells <- function(start_p = NULL, end_p = NULL) { plot_hidserv_rend_relayed_cells <- function(start_p, end_p, path_p) { prepare_hidserv_rend_relayed_cells(start_p, end_p) %>% + complete(date = full_seq(date, period = 1)) %>% ggplot(aes(x = date, y = relayed)) + geom_line() + scale_x_date(name = "", breaks = custom_breaks, @@ -1192,6 +1201,8 @@ plot_webstats_tb <- function(start_p, end_p, path_p) { "update_requests"), labels = c("Initial downloads", "Signature downloads", "Update pings", "Update requests"))) %>% + ungroup() %>% + complete(date = full_seq(date, period = 1), nesting(request_type)) %>% ggplot(aes(x = date, y = count)) + geom_point() + geom_line() + @@ -1231,6 +1242,9 @@ plot_webstats_tb_platform <- function(start_p, end_p, path_p) { mutate(request_type = factor(request_type, levels = c("initial_downloads", "update_pings"), labels = c("Initial downloads", "Update pings"))) %>% + ungroup() %>% + complete(date = full_seq(date, period = 1), + nesting(platform, request_type)) %>% ggplot(aes(x = date, y = count, colour = platform)) + geom_point() + geom_line() + @@ -1299,6 +1313,7 @@ plot_webstats_tb_locale <- function(start_p, end_p, path_p) { theme(strip.text.y = element_text(angle = 0, hjust = 0, size = rel(1.5)), strip.background = element_rect(fill = NA), legend.position = "top") + + guides(col = guide_legend(nrow = 1)) + ggtitle("Tor Browser downloads and updates by locale") + labs(caption = copyright_notice) ggsave(filename = path_p, width = 8, height = 5, dpi = 150) @@ -1320,7 +1335,7 @@ prepare_webstats_tm <- function(start_p = NULL, end_p = NULL) { group_by(log_date, request_type) %>% summarize(count = sum(count)) %>% mutate(request_type = factor(request_type, levels = c("tmid", "tmup"))) %>% - spread(request_type, count, drop = FALSE) %>% + spread(request_type, count, drop = FALSE, fill = 0) %>% rename(date = log_date, initial_downloads = tmid, update_pings = tmup) } @@ -1330,6 +1345,8 @@ plot_webstats_tm <- function(start_p, end_p, path_p) { mutate(request_type = factor(request_type, levels = c("initial_downloads", "update_pings"), labels = c("Initial downloads", "Update pings"))) %>% + ungroup() %>% + complete(date = full_seq(date, period = 1), nesting(request_type)) %>% ggplot(aes(x = date, y = count)) + geom_point() + geom_line() + @@ -1366,15 +1383,12 @@ prepare_relays_ipv6 <- function(start_p = NULL, end_p = NULL) { announced = sum(server_count_sum_avg[announced_ipv6]), reachable = sum(server_count_sum_avg[reachable_ipv6_relay]), exiting = sum(server_count_sum_avg[exiting_ipv6_relay])) %>% - complete(valid_after_date = full_seq(valid_after_date, period = 1)) %>% - gather(total, announced, reachable, exiting, key = "category", - value = "count") %>% - rename(date = valid_after_date) %>% - spread(category, count) + rename(date = valid_after_date) } plot_relays_ipv6 <- function(start_p, end_p, path_p) { prepare_relays_ipv6(start_p, end_p) %>% + complete(date = full_seq(date, period = 1)) %>% gather(category, count, -date) %>% ggplot(aes(x = date, y = count, colour = category)) + geom_line() + @@ -1411,12 +1425,12 @@ prepare_bridges_ipv6 <- function(start_p = NULL, end_p = NULL) { group_by(valid_after_date) %>% summarize(total = sum(server_count_sum_avg), announced = sum(server_count_sum_avg[announced_ipv6])) %>% - complete(valid_after_date = full_seq(valid_after_date, period = 1)) %>% rename(date = valid_after_date) } plot_bridges_ipv6 <- function(start_p, end_p, path_p) { prepare_bridges_ipv6(start_p, end_p) %>% + complete(date = full_seq(date, period = 1)) %>% gather(category, count, -date) %>% ggplot(aes(x = date, y = count, colour = category)) + geom_line() + @@ -1461,12 +1475,12 @@ prepare_advbw_ipv6 <- function(start_p = NULL, end_p = NULL) { reachable_ipv6_relay & exit_relay]), exiting = sum(advertised_bandwidth_bytes_sum_avg[ exiting_ipv6_relay])) %>% - complete(valid_after_date = full_seq(valid_after_date, period = 1)) %>% rename(date = valid_after_date) } plot_advbw_ipv6 <- function(start_p, end_p, path_p) { prepare_advbw_ipv6(start_p, end_p) %>% + complete(date = full_seq(date, period = 1)) %>% gather(category, advbw, -date) %>% ggplot(aes(x = date, y = advbw, colour = category)) + geom_line() + @@ -1506,9 +1520,10 @@ prepare_totalcw <- function(start_p = NULL, end_p = NULL) { plot_totalcw <- function(start_p, end_p, path_p) { prepare_totalcw(start_p, end_p) %>% - mutate(nickname = ifelse(nickname == "", "consensus", nickname)) %>% + mutate(nickname = ifelse(is.na(nickname), "consensus", nickname)) %>% mutate(nickname = factor(nickname, levels = c("consensus", unique(nickname[nickname != "consensus"])))) %>% + ungroup() %>% complete(date = full_seq(date, period = 1), nesting(nickname)) %>% ggplot(aes(x = date, y = totalcw, colour = nickname)) + geom_line(na.rm = TRUE) +

1 0

[translation/https_everywhere_completed] Update translations for https_everywhere_completed
by translation＠torproject.org 11 Jan '19

11 Jan '19

commit c5bd653ef6c4d684a6ff8378fa4252f95a148afe Author: Translation commit bot <translation(a)torproject.org> Date: Fri Jan 11 08:45:57 2019 +0000 Update translations for https_everywhere_completed --- he/https-everywhere.dtd | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/he/https-everywhere.dtd b/he/https-everywhere.dtd index 6cdb6c5f9..e19957804 100644 --- a/he/https-everywhere.dtd +++ b/he/https-everywhere.dtd @@ -8,7 +8,7 @@ <!ENTITY https-everywhere.menu.donate_eff_imperative "EFF תרום אל"> <!ENTITY https-everywhere.menu.observatory "העדפות מיצפה SSL"> <!ENTITY https-everywhere.menu.globalEnable "HTTPS Everywhere אפשר את"> -<!ENTITY https-everywhere.menu.blockUnencryptedRequests "חסום את כל הבקשות הבלתי מוצפנות"> +<!ENTITY https-everywhere.menu.encryptAllSitesEligible "(EASE) הצפן את כל האתרים הזכאיים"> <!ENTITY https-everywhere.menu.showCounter "הראה מונה"> <!ENTITY https-everywhere.menu.viewAllRules "הצג את כל הכללים">

1 0

[translation/https_everywhere] Update translations for https_everywhere
by translation＠torproject.org 11 Jan '19

11 Jan '19

commit 0c269a8c8c6bc9a953dbb916adf21e009a4df155 Author: Translation commit bot <translation(a)torproject.org> Date: Fri Jan 11 08:45:50 2019 +0000 Update translations for https_everywhere --- he/https-everywhere.dtd | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/he/https-everywhere.dtd b/he/https-everywhere.dtd index 9965c968b..e19957804 100644 --- a/he/https-everywhere.dtd +++ b/he/https-everywhere.dtd @@ -8,7 +8,7 @@ <!ENTITY https-everywhere.menu.donate_eff_imperative "EFF תרום אל"> <!ENTITY https-everywhere.menu.observatory "העדפות מיצפה SSL"> <!ENTITY https-everywhere.menu.globalEnable "HTTPS Everywhere אפשר את"> -<!ENTITY https-everywhere.menu.encryptAllSitesEligible "Encrypt All Sites Eligible (EASE)"> +<!ENTITY https-everywhere.menu.encryptAllSitesEligible "(EASE) הצפן את כל האתרים הזכאיים"> <!ENTITY https-everywhere.menu.showCounter "הראה מונה"> <!ENTITY https-everywhere.menu.viewAllRules "הצג את כל הכללים">

1 0

[translation/donatepages-messagespot] Update translations for donatepages-messagespot
by translation＠torproject.org 11 Jan '19

11 Jan '19

commit 5d10ae6c79d96261cd40b852cb45cc00310b6d50 Author: Translation commit bot <translation(a)torproject.org> Date: Fri Jan 11 08:45:27 2019 +0000 Update translations for donatepages-messagespot --- locale/he/LC_MESSAGES/messages.po | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/locale/he/LC_MESSAGES/messages.po b/locale/he/LC_MESSAGES/messages.po index 32f16d72e..a67afbc9c 100644 --- a/locale/he/LC_MESSAGES/messages.po +++ b/locale/he/LC_MESSAGES/messages.po @@ -2,11 +2,11 @@ # Giovanni Pellerano <giovanni.pellerano(a)evilaliv3.org>, 2018 # Adam Lynn <adam(a)opentechfund.org>, 2018 # erinm, 2018 -# ION, 2018 +# ION, 2019 # msgid "" msgstr "" -"Last-Translator: ION, 2018\n" +"Last-Translator: ION, 2019\n" "Language-Team: Hebrew (https://www.transifex.com/otf/teams/1519/he/)\n" "Language: he\n" "Plural-Forms: nplurals=4; plural=(n == 1 && n % 1 == 0) ? 0 : (n == 2 && n % 1 == 0) ? 1: (n % 10 == 0 && n % 1 == 0 && n > 10) ? 2 : 3;\n" @@ -312,7 +312,7 @@ msgstr "חולצה קצרה" #: tmp/cache_locale/93/936f5ca9f26662b60293a725343573df95cb28c99d7c3f12b1c94ed37a453012.php:259 msgid "$15" -msgstr "" +msgstr "$15" #: tmp/cache_locale/93/936f5ca9f26662b60293a725343573df95cb28c99d7c3f12b1c94ed37a453012.php:261 msgid "OFF"

1 0

[meek/utls] Use the utls HelloRandomizedNoALPN handshake.
by dcf＠torproject.org 11 Jan '19

11 Jan '19

commit 90d82c205c0269b87de5a6956e485225f8a9a2cb Author: David Fifield <david(a)bamsoftware.com> Date: Thu Jan 10 22:11:10 2019 -0700 Use the utls HelloRandomizedNoALPN handshake. Since we cannot use any handshake that has a "h2" ALPN (like HelloFirefox_63 or HelloChrome_70), let's use a randomized handshake. HelloRandomizedNoALPN differs from HelloRandomized and HelloRandomizedALPN in that it always omits ALPN. The http.Transport still appears to make 10 independent connections, each with its own randomized fingerprint... --- meek-client/meek-client.go | 14 ++------------ 1 file changed, 2 insertions(+), 12 deletions(-) diff --git a/meek-client/meek-client.go b/meek-client/meek-client.go index 5853428..4f5aadd 100644 --- a/meek-client/meek-client.go +++ b/meek-client/meek-client.go @@ -451,18 +451,8 @@ func main() { if err != nil { return nil, err } - uconn := tls.UClient(conn, config, tls.HelloChrome_Auto) - // We cannot call uconn.Handshake() here: it causes the server - // to use HTTP/2, when the client is still using HTTP/1.1, - // because net/http disables automatic HTTP/2 support when using - // DialTLS. - // https://github.com/golang/go/issues/21753 - // "Auto-HTTP/2 is disabled by DialTLS being set" - // https://github.com/golang/go/issues/21336 - // But: returning without calling uconn.Handshake causes the - // ClientHello to lack the ALPN extension entirely... - // - // err = uconn.Handshake() + uconn := tls.UClient(conn, config, tls.HelloRandomizedNoALPN) + err = uconn.Handshake() return uconn, err }

1 0

[translation/https_everywhere_completed] Update translations for https_everywhere_completed
by translation＠torproject.org 11 Jan '19

11 Jan '19

commit d094538f6f2cae99db726aeba6f03578d28e8efb Author: Translation commit bot <translation(a)torproject.org> Date: Fri Jan 11 02:45:55 2019 +0000 Update translations for https_everywhere_completed --- es/https-everywhere.dtd | 2 +- es_AR/https-everywhere.dtd | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/es/https-everywhere.dtd b/es/https-everywhere.dtd index 504990a04..5bb36d2f7 100644 --- a/es/https-everywhere.dtd +++ b/es/https-everywhere.dtd @@ -8,7 +8,7 @@ <!ENTITY https-everywhere.menu.donate_eff_imperative "Donar a EFF"> <!ENTITY https-everywhere.menu.observatory "Opciones del Observatorio SSL"> <!ENTITY https-everywhere.menu.globalEnable "Activar HTTPS Everywhere"> -<!ENTITY https-everywhere.menu.encryptAllSitesEligible "Encriptar Todos los Sitios Elegibles (EASE)"> +<!ENTITY https-everywhere.menu.encryptAllSitesEligible "Cifrar Todos los Sitios Elegibles (EASE)"> <!ENTITY https-everywhere.menu.showCounter "Mostrar contador"> <!ENTITY https-everywhere.menu.viewAllRules "Ver todas las reglas"> diff --git a/es_AR/https-everywhere.dtd b/es_AR/https-everywhere.dtd index 9a8cd6cf8..39160ed15 100644 --- a/es_AR/https-everywhere.dtd +++ b/es_AR/https-everywhere.dtd @@ -8,7 +8,7 @@ <!ENTITY https-everywhere.menu.donate_eff_imperative "Donar a EFF"> <!ENTITY https-everywhere.menu.observatory "Preferencias del Observatorio SSL"> <!ENTITY https-everywhere.menu.globalEnable "Habilitar HTTPS Everywhere"> -<!ENTITY https-everywhere.menu.blockUnencryptedRequests "Bloquear todas las solicitudes no encriptadas"> +<!ENTITY https-everywhere.menu.encryptAllSitesEligible "Encriptar Todos los Sitios Elegibles (EASE)"> <!ENTITY https-everywhere.menu.showCounter "Mostrar contador"> <!ENTITY https-everywhere.menu.viewAllRules "Ver todas las Reglas">

1 0

[translation/https_everywhere] Update translations for https_everywhere
by translation＠torproject.org 11 Jan '19

11 Jan '19

commit cc849484c85371597a4c37867f7a3fbd9885a297 Author: Translation commit bot <translation(a)torproject.org> Date: Fri Jan 11 02:45:44 2019 +0000 Update translations for https_everywhere --- es/https-everywhere.dtd | 2 +- es_AR/https-everywhere.dtd | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/es/https-everywhere.dtd b/es/https-everywhere.dtd index 504990a04..5bb36d2f7 100644 --- a/es/https-everywhere.dtd +++ b/es/https-everywhere.dtd @@ -8,7 +8,7 @@ <!ENTITY https-everywhere.menu.donate_eff_imperative "Donar a EFF"> <!ENTITY https-everywhere.menu.observatory "Opciones del Observatorio SSL"> <!ENTITY https-everywhere.menu.globalEnable "Activar HTTPS Everywhere"> -<!ENTITY https-everywhere.menu.encryptAllSitesEligible "Encriptar Todos los Sitios Elegibles (EASE)"> +<!ENTITY https-everywhere.menu.encryptAllSitesEligible "Cifrar Todos los Sitios Elegibles (EASE)"> <!ENTITY https-everywhere.menu.showCounter "Mostrar contador"> <!ENTITY https-everywhere.menu.viewAllRules "Ver todas las reglas"> diff --git a/es_AR/https-everywhere.dtd b/es_AR/https-everywhere.dtd index d046ce6ab..39160ed15 100644 --- a/es_AR/https-everywhere.dtd +++ b/es_AR/https-everywhere.dtd @@ -8,7 +8,7 @@ <!ENTITY https-everywhere.menu.donate_eff_imperative "Donar a EFF"> <!ENTITY https-everywhere.menu.observatory "Preferencias del Observatorio SSL"> <!ENTITY https-everywhere.menu.globalEnable "Habilitar HTTPS Everywhere"> -<!ENTITY https-everywhere.menu.encryptAllSitesEligible "Encrypt All Sites Eligible (EASE)"> +<!ENTITY https-everywhere.menu.encryptAllSitesEligible "Encriptar Todos los Sitios Elegibles (EASE)"> <!ENTITY https-everywhere.menu.showCounter "Mostrar contador"> <!ENTITY https-everywhere.menu.viewAllRules "Ver todas las Reglas">

1 0

[nyx/master] Drop bold tag from changelog tickets
by atagar＠torproject.org 10 Jan '19

10 Jan '19

commit f9395cb313222831928db0b212a5d2921fc72a13 Author: Damian Johnson <atagar(a)torproject.org> Date: Wed Jan 9 11:38:29 2019 -0800 Drop bold tag from changelog tickets I've been inconsistent on if tickets are wrapped with a bold tag or not. Cursory glance indicates links are already a bold typeface so the presence or omission of these tags don't look any different. --- web/changelog/index.html | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/web/changelog/index.html b/web/changelog/index.html index dfb6465..f5787e2 100644 --- a/web/changelog/index.html +++ b/web/changelog/index.html @@ -109,24 +109,24 @@ <li>Configuration Editor <ul> - <li>New tor configuration options crashed nyx when shown (<a href="https://trac.torproject.org/projects/tor/ticket/24401">ticket</a>)</li> - <li>Errors when saving the configuration could result in a stacktrace (<a href="https://trac.torproject.org/projects/tor/ticket/24409">ticket</a>)</li> - <li>Pressing 'esc' when editing values changed their value to 'none' (<a href="https://trac.torproject.org/projects/tor/ticket/28334">ticket</a>)</li> + <li>New tor configuration options crashed nyx when shown (<a href="https://trac.torproject.org/projects/tor/ticket/24401">ticket</a>)</li> + <li>Errors when saving the configuration could result in a stacktrace (<a href="https://trac.torproject.org/projects/tor/ticket/24409">ticket</a>)</li> + <li>Pressing 'esc' when editing values changed their value to 'none' (<a href="https://trac.torproject.org/projects/tor/ticket/28334">ticket</a>)</li> <li>Reset configuration option if set to an empty value</li> </ul> </li> <li>Interpreter <ul> - <li>Line wrap content (<a href="https://trac.torproject.org/projects/tor/ticket/28297">ticket</a>)</li> - <li>Large amounts of content made panel sluggish (<a href="https://trac.torproject.org/projects/tor/ticket/28902">ticket</a>)</li> + <li>Line wrap content (<a href="https://trac.torproject.org/projects/tor/ticket/28297">ticket</a>)</li> + <li>Large amounts of content made panel sluggish (<a href="https://trac.torproject.org/projects/tor/ticket/28902">ticket</a>)</li> </ul> </li> <li>Curses <ul> - <li>Resizing could crash the interface (<a href="https://trac.torproject.org/projects/tor/ticket/24382">ticket</a>)</li> - <li>Implemented del key in editable text fields (<a href="https://trac.torproject.org/projects/tor/ticket/5835">ticket</a>)</li> + <li>Resizing could crash the interface (<a href="https://trac.torproject.org/projects/tor/ticket/24382">ticket</a>)</li> + <li>Implemented del key in editable text fields (<a href="https://trac.torproject.org/projects/tor/ticket/5835">ticket</a>)</li> </ul> </li>

1 0

[nyx/master] Skip installation test when offline
by atagar＠torproject.org 10 Jan '19

10 Jan '19

commit 55854cdbf674151d368f134bdb8d381e69209ce8 Author: Damian Johnson <atagar(a)torproject.org> Date: Thu Jan 10 14:58:46 2019 -0800 Skip installation test when offline On my morning bus commute I was pretty puzzled why our tests broke. Turns out we fail in a rather confusing way that says our PYTHONPATH is misconfigured when unable to install stem from pypi. --- test/installation.py | 16 ++++++++++++++++ 1 file changed, 16 insertions(+) diff --git a/test/installation.py b/test/installation.py index 4b89177..4bde759 100644 --- a/test/installation.py +++ b/test/installation.py @@ -3,18 +3,34 @@ import shutil import subprocess import sys import unittest +import urllib2 import nyx import stem.util.system import test +def is_online(): + """ + Confirm we can reach PyPI. If we can't then our installation test will fail + due to being unable to install Stem. + """ + + try: + urllib2.urlopen('https://pypi.org/', timeout = 1) + return True + except urllib2.URLError: + return False + + class TestInstallation(unittest.TestCase): def test_installing_stem(self): base_directory = os.path.sep.join(__file__.split(os.path.sep)[:-2]) if not os.path.exists(os.path.sep.join([base_directory, 'setup.py'])): self.skipTest('(only for git checkout)') + elif not is_online(): + self.skipTest('(only when online)') original_cwd = os.getcwd() site_packages = '/tmp/nyx_test/lib/python%i.%i/site-packages/' % sys.version_info[:2]

1 0

[nyx/master] Implement delete key
by atagar＠torproject.org 10 Jan '19

10 Jan '19

commit 321eb30eb1f38eb16b94ead67ad21cf5e3930a48 Author: Damian Johnson <atagar(a)torproject.org> Date: Wed Jan 9 11:35:00 2019 -0800 Implement delete key Special keys (arrows, home/end, etc) require for us to implement their handling. Doing so for the delete key. https://trac.torproject.org/projects/tor/ticket/5835 --- nyx/curses.py | 12 ++++++++++++ web/changelog/index.html | 1 + 2 files changed, 13 insertions(+) diff --git a/nyx/curses.py b/nyx/curses.py index 3f4b797..9f998b0 100644 --- a/nyx/curses.py +++ b/nyx/curses.py @@ -318,6 +318,18 @@ def _handle_key(textbox, key): textbox.win.move(y, msg_length - 1) # if we're in the content then move to the end elif key == curses.KEY_RIGHT and x < msg_length - 1: textbox.win.move(y, x + 1) # only move cursor if there's content after it + elif key == curses.KEY_DC: + # Delete key. Remove the character after the cursor if there is one. + + y, x = textbox.win.getyx() + content = textbox.gather() + + if x < len(content): + content = content[:x] + content[x + 1:] + textbox.win.clear() + textbox.win.addstr(y, 0, content) + + textbox.win.move(y, x) # revert cursor to its prior position elif key == 410: # if we're resizing the display during text entry then cancel it # (otherwise the input field is filled with nonprintable characters) diff --git a/web/changelog/index.html b/web/changelog/index.html index d49533e..dfb6465 100644 --- a/web/changelog/index.html +++ b/web/changelog/index.html @@ -126,6 +126,7 @@ <li>Curses <ul> <li>Resizing could crash the interface (<a href="https://trac.torproject.org/projects/tor/ticket/24382">ticket</a>)</li> + <li>Implemented del key in editable text fields (<a href="https://trac.torproject.org/projects/tor/ticket/5835">ticket</a>)</li> </ul> </li>

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

tor-commits January 2019