Network team meeting, 13 May 2019 - tor-project

13 May 2019


      Hi!
We just had a meeting.  Logs are at:
http://meetbot.debian.net/tor-meeting/2019/tor-meeting.2019-05-13-17.00.html
Meeting pad contents are below:
= Network team meeting pad! =
This week's team meeting is at Monday 13 May at 1700 UTC on
#tor-meeting on OFTC.
May schedule:
    * Monday 6 May at 1700 UTC
    * Monday 13 May at 1700 UTC
    * Monday 20 May at 1700 UTC
    * Monday 27 May at 1700 UTC
June schedule:
    * Tuesday 4 June at 2300 UTC
    * Monday 10 June at 1700 UTC
Welcome to our meeting!
First meeting each month: Tuesday at 2300 UTC
Other meetings each month: Mondays at 1700 UTC until 3 November 2019,
when daylight saving time changes
On #tor-meeting on OFTC.
(This channel is logged while meetings are in progress.) (See
https://lists.torproject.org/pipermail/tor-project/2017-September/001459.htm...
for background.)
Want to participate?  Awesome!  Here's what to do:
    1. If you have updates, enter them below, under your name.
    2. If you see anything you want to talk about in your updates, put
them in boldface!
    3. Show up to the IRC meeting and say hi!
After each week's meetings, the contents of this pad will be sent to
tor-project @ lists.torproject.org.
After that is done, the pad can be used for the next week.
== Previous notes ==
(Search the list archive for older notes.)
25 Mar: https://lists.torproject.org/pipermail/tor-project/2019-April/002280.html
 2 Apr: http://meetbot.debian.net/tor-meeting/2019/tor-meeting.2019-04-02-23.00.html
(we forgot to post the notes)
 8 Apr: https://lists.torproject.org/pipermail/tor-project/2019-April/002289.html
15 Apr: https://lists.torproject.org/pipermail/tor-project/2019-April/002296.html
23 Apr: https://lists.torproject.org/pipermail/tor-project/2019-April/002308.html
29 Apr: https://lists.torproject.org/pipermail/tor-project/2019-April/002310.html
 6 May: https://lists.torproject.org/pipermail/tor-project/2019-May/002316.html
== Stuff to do every week =
* How are we managing CI failures from last week?
  See https://trac.torproject.org/projects/tor/wiki/org/teams/NetworkTeam/CIFailur...
* Let's check the 0.4.0 release status page.
  See https://trac.torproject.org/projects/tor/wiki/org/teams/NetworkTeam/CoreTorR...
  (This page automatically shows the latest trac ticket status.)
* Let's check and update the roadmap.
  What's done, and what's coming up?
  We're using a kanban board:
      https://storm.torproject.org/shared/_mx8PMGOHFBOximocl1gy3COvhLPr6k3Ja7JA1vN...
      Click on 'all boards' and then the network team one. Filter by
your name and check the 'in progress' column is correct.
* Check reviewer assignments! How reviews from last week worked? Any blocker?
Here are the outstanding reviews, oldest first, including sbws
    https://trac.torproject.org/projects/tor/query?status=needs_review&compo...
* Check rotations at
https://trac.torproject.org/projects/tor/wiki/org/teams/NetworkTeam/TeamRota...
.
* See discussion notes below.
Any blocker from last week?
== Reminders ==
* Remember to "/me status: foo" at least once daily.
* Remember that our current code reviews should be done by end-of-week.
* Make sure you are in touch with everybody with whom you are doing
work for the next releases.
* Remember to fill up the 'actual point' field when you close a
ticket. We need those to calculate velocity.
* Check other's people call for help in their entries.
* Remember to fill in the doodle for monthly retrospective
https://doodle.com/poll/8xhmkm3zqmzdg8pe
-------------------------------
---- 13th May 2019
-------------------------------
== Announcements ==
- The master branch is now 0.4.1.x; 0.4.0 development will continue in
maint-0.4.0.
We need to prioritize 0.4.0 fixes and reviews in April, because stable
was due on 15 April.
== Discussion ==
Rotation updates:
Bug triage - ahf to asn
The Bug Triage role description and queries is on the wiki at:
https://trac.torproject.org/projects/tor/wiki/org/teams/NetworkTeam/TeamRota...
I think I've left all our triage queries as empty as of Monday.
CI - catalyst to dgoulet
https://trac.torproject.org/projects/tor/wiki/org/teams/NetworkTeam/CIFailur...
       Jenkins tor-ci-freebsd-amd64-0.2.9 seems to have been broken
for a while, but maybe the FreeBSD builds don't automatically build
anymore?
Coverity - catalyst to dgoulet
[In other news, coverity scan seems to have TLS issues that are
keeping nick's automatic updates from working.  If anybody can provide
a correct incantation to "curl https://scan.coverity.com/ " in a way
that works, that would rock. -nickm]
new CID 1444999 https://trac.torproject.org/projects/tor/ticket/30467
-- fixed by dgoulet
new CID 1444999 https://trac.torproject.org/projects/tor/ticket/30458
-- low priority?
Tor meetup in July: do we need 1 room for the network team for 1 whole
day? Retrospective, roadmap, any other session that may not be shared
with the rest of Tor?
How do we handle our freeze and freeze period?  Nick has suggestions:
Let's default to "if a feature isn't needs_review by Wednesday, it
isn't going in", with sensible exceptions.
If the initial review suggests that the branch is high-risk, we should
maybe not merge it, depending on impact.
Let's IMMEDIATELY look for MUST items in 041, and try to fix them.
Nick will recreate Teor's "040-must" page for 041.
We can open 042 early if people are all focusing on 041-must fixes.
Please look for 041 problems to fix, or S19 things to do, instead of
getting an early start on 042.
By default we keep 042 closed for a month, but should look at it fresh
each meeting.
== Recommended links ==
"Select male faculty, they said, effectively ran the Institute and
were showered with private donations,
 while women were forced to fire essential staff and were shut out from power."
This article is an excellent analysis of the mechanics of power and
discrimination:
https://www.nytimes.com/2019/04/18/magazine/salk-institute-discrimination-sc...
On allyship in newsrooms but also in workplaces:
https://source.opennews.org/articles/how-be-ally-newsroom/
In github but a bot for assigning reviews: https://github.com/lmarkus/ReviewBot
== Updates ==
NOTE NEW FORMAT!
Name:
    Week of XYZ (planned):
        - What you planned for last week.
    Week of XYZ (actual):
        - What you did last week.
    Week of ABC (planned):
        - What you're planning to do this week.
    Help with:
- Something you may need help with.
PLEASE DO NOT BULK-DELETE THE OLD ENTRIES!
Leave the "Planned" parts!
Leave the parts for last week and this week!
gaba:
Last week (actual):
looked at closed tickets during April. Still a lot of non sponsor work.
incorporated net team sponsored projects into Tor planning
This week (planned):
check sponsor v and 2 work until now
check s27 in the network team roadmap
Help with:
teor: (online for 23 April, then on leave until 21 May)
* AFK
Nick:
    Week of 6 May (planned):
        - Finish up ADL prototype
        - More refactoring
        - Work on PTs in chutney?
        - Lots of reviews and merges
        - Meetings most of the day on Tuesday
        - finish up relay-periodic events branch and get it merged,
then fill in some gaps from it that would be well suited for pubsub.
Week of 6 May (actual):
        - ADL prototype to mailing list, with comments on prop295.
          (https://lists.torproject.org/pipermail/tor-dev/2019-May/013804.html )
        - Implemented code to make chutney handle bidi connections
(#29263) and gracefully detect unsupported configurations (#30459)
        - Wrestled with confusing chutney travis failures for way too
long on #29263.
        - Lots of reviews and merges and meetings
Week of 13 May (planned):
        - Reviews and merge as top priority
        - Work on 29024 [PT support in chutney] for obfs4 at least
        - Freeze 0.4.1.x
        - Start on (and finish?) an alpha release
        - Privcount, time permitting
        - More work on 30414, time permitting, if review happens
dgoulet:
  Week of 05/06 (actual):
    - Reviews and merges (See timeline).
    - Work on #26288 child tickets.
    - Resolve important issue found by armadev about prop289 code: #30428
    - While working on the #15516 defenses, find out that #30440 is a big
      problem so we are falling back to a token bucket approach instead.
    - Found #30454 issue in the HS code and made a fix for it.
    - Opened #30466 which is related to #30440.
    - Did worked hard on implementing a unit test for #26288 but ultimately
      couldn't achieve it with our current code setup :S.
   Week of 05/13 (planned):
    - Rush anything needed for the freeze. In particular, some child tickets
      in #26288.
    - Work on the #15516 Plan B which is token bucket rate limit design.
    - Make progress in #30382 which changed to using SOCKS error.
    - REMINDER: Will be offline on Thu and Fri.
Mike:
  Week of 5/6 (planned):
    - PETS stipend, registration, and hotel logistics
    - Get child tickets of
https://trac.torproject.org/projects/tor/ticket/28634 merged or
needs_review
  Week of 5/6 (actual):
    - PETS stipend
    - Got child tickets of
https://trac.torproject.org/projects/tor/ticket/28634 merged or
needs_review
  Week of 5/13 (planned):
    - Get child tickets of
https://trac.torproject.org/projects/tor/ticket/28634 merged
  Need help with:
    - Discuss https://trac.torproject.org/projects/tor/ticket/28780
with Nick, asn some more
catalyst:
week of 05/06 (2019-W19) (planned):
        - reviews
        - CI + Coverity rotation
        - get #29976 ready for review
        - peer feedback (2) and team leader feedback
        - open more bootstrap reporting improvement tickets
    week of 05/06 (2019-W19) (actual):
        - more [redacted]
        - medical bureaucracy
        - CI + Coverity rotation -- a few new defects; see handoff section
        - reviews
    week of 05/13 (2019-W20) (planned):
        - reviews
        - #29976
        - peer feedback (2) and team leader feedback
asn:
   Week of 05/06 (planned):
   - Hopefully finalize open WTF-PAD tasks.
   - Work more on #30381.
   - Work more on #15516.
   - Reviews and merges.
   Week of 05/06 (actual):
   - Hopefully finalize open WTF-PAD tasks by the 15th.
   - Finalized #30381 spec work and started coding the control port parts.
   - Provided (almost) final revisions for the final WTF-PAD branch
(#28634), and tested #28780 code.
   - Discused #14389 with mcs and David. We figured that reviving prop#229 is
     the way to go.
   - Discussed #15516 with David and made some plans for future DoS prevention.
   - Rebased #30236 to master because of some conflicts.
   - Reviews and merges.
   Week of 05/13 (planned):
   - Continue coding #30381 so that we unblock the TB team.
   - Keep on working on the DoS stuff by the side.
   - Got lots of reviews for this week. Got a few more last midweek, so I got
     stuff to do here.
   - Peer review everything
ahf
    Week of 5/6 (planned):
        Network team:
            - Bug triage role.
            - Look at network team S19 tickets for May after the
network team meeting.
        Anti-censorship team:
            - Cleaning up Snowflake patches for cohosh/dcf to review.
    Week of 5/6 (actually):
        Network team:
            - Meeting with Gaba and Catalyst about splitting up S19
network team tickets.
            - Got a lot of help from Nick with Dormant mode questions
            - Wrote pt-spec.txt patch proposal and initial patch for
#28849 (dormant and PT integration)
            - Got help from Catalyst with understanding #28930
        Anti-censorship Team:
            - Got help from dcf with #28849 spec changes.
        Misc:
            - Triage duty.
            - Submitted request for PETS stipend.
    Week of 13/5 (planned):
        Network team:
            - Finish #28849 when we (PT community and us) agrees on
spec changes.
            - Begin #28930 code.
            - Rebase #29736 code on top of master and see what is missing.
        Misc:
            - Submit peer review to people's respective team leaders.
juga(offline):
    Week of 05/06 (plan)
       - Add Tor version to the bandwidth file (#30196)
       - Most headers non-compliant with spec (#30373)
    Week of 05/13 (actual)
       - Revised Add HeaderLine to the bandwidth file specification (#30311)
       - Revised Refactor header constants in sbws to use Stem's one (#30406)
       - Added patch for Most headers non-compliant with spec (#30373)
    Week of 05/20 (actual)
       - Continue with #30311, #30406, #30373 as needed
    Help with:
       - Question: basted would start running sbws 1.0.1 (Tor 3.5.8)
later this week if nobody sees a problem with it