March 2021 - tor-commits - lists.torproject.org

[translation/https_everywhere] https://gitweb.torproject.org/translation.git/commit/?h=https_everywhere
by translation＠torproject.org 19 Mar '21

19 Mar '21

commit 0d293e1bd13601763ce9cd42f195bd0922dc7a7b Author: Translation commit bot <translation(a)torproject.org> Date: Fri Mar 19 21:45:23 2021 +0000 https://gitweb.torproject.org/translation.git/commit/?h=https_everywhere --- sv/https-everywhere.dtd | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sv/https-everywhere.dtd b/sv/https-everywhere.dtd index 56aa5dd863..9c4ab42216 100644 --- a/sv/https-everywhere.dtd +++ b/sv/https-everywhere.dtd @@ -34,7 +34,7 @@ <!ENTITY https-everywhere.options.hostNotFormattedCorrectly "Denna värd kunde inte läggas till eftersom den inte var formaterad korrekt. Vänligen kontrollera det och försök igen."> <!ENTITY https-everywhere.options.addUpdateChannel "Lägg till uppdateringskanal"> <!ENTITY https-everywhere.options.enterUpdateChannelName "Ange namn på uppdateringskanal"> -<!ENTITY https-everywhere.options.delete "Radera"> +<!ENTITY https-everywhere.options.delete "Ta bort"> <!ENTITY https-everywhere.options.update "Uppdatera"> <!ENTITY https-everywhere.options.storedRulesetsVersion "Lagrad version för regleruppsättning: "> <!ENTITY https-everywhere.options.updatesLastChecked "Uppdateringar som senast kontrollerats: ">

1 0

[tor-browser-spec/master] Update NETWORK_AUDIT_RUBRIC
by gk＠torproject.org 19 Mar '21

19 Mar '21

commit 6735a8b4b3fda67088089c5a06b8ba25d2f89a44 Author: Matthew Finkel <sysrqb(a)torproject.org> Date: Tue Feb 9 19:29:32 2021 +0000 Update NETWORK_AUDIT_RUBRIC --- audits/NETWORK_AUDIT_RUBRIC | 93 +++++++++++---------------------------------- 1 file changed, 22 insertions(+), 71 deletions(-) diff --git a/audits/NETWORK_AUDIT_RUBRIC b/audits/NETWORK_AUDIT_RUBRIC index b58bb49..a755b64 100644 --- a/audits/NETWORK_AUDIT_RUBRIC +++ b/audits/NETWORK_AUDIT_RUBRIC @@ -1,88 +1,39 @@ -`git diff esrA esrB` and then go over all the changes containing the -below mentioned potentially dangerous calls and features. Grep the diff for -the following strings and examine surrounding usage. +============ General ============= -=============== Native DNS Portion ============= +The audit begins at the commit hash where the previous audit ended. Use +code_audit.sh for creating the diff and highlighting potentially problematic +code. The audit is scoped to a specific language (currently C/C++, Rust, +Java/Kotlin, and Javascript). -PR_GetHostByName -PR_GetIPNodeByName -PR_GetAddrInfoByName -PR_StringToNetAddr (itself is good as it passes AI_NUMERICHOST to getaddrinfo. No resolution.) +The output includes the entire patch where the new problematic code was +introduced. Search for "XXX MATCH XXX" to find the next potential violation. -MDNS -TRR (DNS Trusted Recursive Resolver) +code_audit.sh contains the list of known problematic APIs. New usage of these +functions are documented and analyzed in this audit. -Direct Paths to DNS resolution: -nsDNSService::Resolve -nsDNSService::AsyncResolve -nsHostResolver::ResolveHost +============ Firefox General Portion ============= -============ Misc Socket Portion ============== +Start: ${previous_base_commit_hash} # ${prev_tag} +End: ${next_base_commit_hash} # ${next_tag} -SOCK_ -SOCKET_ -_SOCKET -UDPSocket -TCPSocket - PR_NewTCPSocket - AsyncTCPSocket +============ Application Services Portion ============= -Misc PR_Socket +Start: ${previous_base_commit_hash} # ${prev_tag} +End: ${next_base_commit_hash} # ${next_tag} -=========== Misc XPCOM Portion ================ +============ Android Components Portion ============= -Misc XPCOM (including commands for pre-diff review approach) - *SocketProvider - grep -R udp-socket . - grep -R tcp-socket . - grep for tcpsocket - grep -R "NS_" | grep SOCKET | grep "_C" - grep -R "@mozilla.org/network/" . | grep socket | grep -v udp-socket +Start: ${previous_base_commit_hash} # ${prev_tag} +End: ${next_base_commit_hash} # ${next_tag} -============ Rust Portion ================ +============ Fenix Portion ============= -Rust - - XXX: What do we grep for here? Or do we rely on Ritter's compile-time tool? - - Check for new sendmsg and recvmsg usage - -============ Android Portion ============= - -Android Java calls - - URLConnection - - XXX: getInputStream? other methods? - - HttpURLConnection - - UrlConnectionDownloader - - ch.boye.httpclientandroidlib.impl.client.* (look for execute() calls) - - grep -n openConnection\( mobile/android/thirdparty/ - - java.net.URL -- has SEVERAL proxy bypass URL fetching methods :/ - - java.net - - javax.net - - ch.boye.httpclientandroidlib.conn.* (esp ssl) - - ch.boye.httpclientandroidlib.impl.conn.* (esp ssl) - - Sudden appearance of thirdparty libs: - - OkHttp - - Retrofit - - Glide - - com.amitshekhar.android - - IntentHelper - - openUriExternal (can come from GeckoAppShell too) - - getHandlersForMimeType - - getHandlersForURL - - getHandlersForIntent - - android.content.Intent - too common; instead find launch methods: - - startActivity - - startActivities - - sendBroadcast - - sendOrderedBroadcast - - startService - - bindService - - android.app.PendingIntent - - android.app.DownloadManager - - ActivityHandlerHelper.startIntentAndCatch +Start: ${previous_base_commit_hash} # ${prev_tag} +End: ${next_base_commit_hash} # ${next_tag} ============ Regression/Prior Vuln Review ========= Review proxy bypass bugs; check for new vectors to look for: - - https://trac.torproject.org/projects/tor/query?keywords=~tbb-proxy + - https://gitlab.torproject.org/groups/tpo/applications/-/issues?scope=all&ut… - Look for new features like these. Especially external app launch vectors

1 0

[tor-browser-spec/master] Bug 40010: Generalize audit script
by gk＠torproject.org 19 Mar '21

19 Mar '21

commit 68566ac4e7021456026bf057e47a00fa8513d2cf Author: Matthew Finkel <sysrqb(a)torproject.org> Date: Thu Jan 21 21:29:22 2021 +0000 Bug 40010: Generalize audit script --- audits/java_audit.sh | 206 +++++++++++++++++++++++++++++++++++---------------- 1 file changed, 142 insertions(+), 64 deletions(-) diff --git a/audits/java_audit.sh b/audits/java_audit.sh old mode 100644 new mode 100755 index b1183eb..3586470 --- a/audits/java_audit.sh +++ b/audits/java_audit.sh @@ -1,90 +1,168 @@ #!/bin/bash -e -if [ $# -ne 3 ]; then - echo "usage: <path/to/repo> <old commit> <new commit>" +if [ $# -ne 4 ]; then + echo "usage: <path/to/repo> <lang> <old commit> <new commit>" exit 1 fi REPO_DIR=$1 -OLD=$2 -NEW=$3 - -SCOPE="java" # string: this is the java audit -EXT="java kt" +SCOPE=$2 +OLD=$3 +NEW=$4 declare -a KEYWORDS #KEYWORDS+=('\+\+\+\ ') -# URL access -KEYWORDS+=(URLConnection) -KEYWORDS+=(UrlConnectionDownloader) - -# Proxy settings -KEYWORDS+=(ProxySelector) - -# Android and java networking and 3rd party libs -KEYWORDS+=("openConnection\(") -KEYWORDS+=("java.net") -KEYWORDS+=("javax.net") -KEYWORDS+=(android.net) -KEYWORDS+=(android.webkit) - -# Third Party http libs -KEYWORDS+=(ch.boye.httpclientandroidlib.impl.client) -KEYWORDS+=(okhttp) - -# Intents -KEYWORDS+=(IntentHelper) -KEYWORDS+=(openUriExternal) -KEYWORDS+=(getHandlersForMimeType) -KEYWORDS+=(getHandlersForURL) -KEYWORDS+=(getHandlersForIntent) -# KEYOWRDS+=(android.content.Intent) # Common -KEYWORDS+=(startActivity) -KEYWORDS+=(startActivities) -KEYWORDS+=(startBroadcast) -KEYWORDS+=(sendBroadcast) -KEYWORDS+=(sendOrderedBroadcast) -KEYWORDS+=(startService) -KEYWORDS+=(bindService) -KEYWORDS+=(android.app.PendingIntent) -KEYWORDS+=(ActivityHandlerHelper.startIntentAndCatch) -KEYWORDS+=(AppLinksInterceptor) -KEYWORDS+=(AppLinksUseCases) - -# Rust symbols -KEYWORDS+=("connect\(") -KEYWORDS+=("recvmsg\(") -KEYWORDS+=("sendmsg\(") -KEYWORDS+=("::post\(") -KEYWORDS+=("::get\(") - -cd $REPO_DIR - -# Step 1: Generate match pattern based on in-scope keywords +initialize_java_symbols() { + # URL access + KEYWORDS+=(URLConnection) + KEYWORDS+=(UrlConnectionDownloader) + + # Proxy settings + KEYWORDS+=(ProxySelector) + + # Android and java networking and 3rd party libs + KEYWORDS+=("openConnection\(") + KEYWORDS+=("java.net") + KEYWORDS+=("javax.net") + KEYWORDS+=(android.net) + KEYWORDS+=(android.webkit) + + # Third Party http libs + KEYWORDS+=(ch.boye.httpclientandroidlib.impl.client) + KEYWORDS+=(okhttp) + + # Intents + KEYWORDS+=(IntentHelper) + KEYWORDS+=(openUriExternal) + KEYWORDS+=(getHandlersForMimeType) + KEYWORDS+=(getHandlersForURL) + KEYWORDS+=(getHandlersForIntent) + # KEYOWRDS+=(android.content.Intent) # Common + KEYWORDS+=(startActivity) + KEYWORDS+=(startActivities) + KEYWORDS+=(startBroadcast) + KEYWORDS+=(sendBroadcast) + KEYWORDS+=(sendOrderedBroadcast) + KEYWORDS+=(startService) + KEYWORDS+=(bindService) + KEYWORDS+=(android.app.PendingIntent) + KEYWORDS+=(ActivityHandlerHelper.startIntentAndCatch) + KEYWORDS+=(AppLinksInterceptor) + KEYWORDS+=(AppLinksUseCases) + KEYWORDS+=(ActivityDelegate) +} + +initialize_rust_symbols() { + KEYWORDS+=("connect\(") + KEYWORDS+=("recvmsg\(") + KEYWORDS+=("sendmsg\(") + KEYWORDS+=("::post\(") + KEYWORDS+=("::get\(") +} + +initialize_cpp_symbols() { + KEYWORDS+=("PR_GetHostByName") + KEYWORDS+=("PR_GetIPNodeByName") + KEYWORDS+=("PR_GetAddrInfoByName") + KEYWORDS+=("PR_StringToNetAddr") + + KEYWORDS+=("MDNS") + KEYWORDS+=("mDNS") + KEYWORDS+=("mdns") + + KEYWORDS+=("TRR") + KEYWORDS+=("trr") + + KEYWORDS+=("AsyncResolve") + KEYWORDS+=("asyncResolve") + KEYWORDS+=("ResolveHost") + KEYWORDS+=("resolveHost") + + KEYWORDS+=("SOCK_") + KEYWORDS+=("SOCKET_") + KEYWORDS+=("_SOCKET") + + KEYWORDS+=("UDPSocket") + KEYWORDS+=("TCPSocket") + + KEYWORDS+=("PR_Socket") + + KEYWORDS+=("SocketProvider") + KEYWORDS+=("udp-socket") + KEYWORDS+=("tcp-socket") + KEYWORDS+=("tcpsocket") + KEYWORDS+=("SOCKET") + KEYWORDS+=("mozilla.org/network") +} + +initialize_js_symbols() { + KEYWORDS+=("AsyncResolve\(") + KEYWORDS+=("asyncResolve\(") + KEYWORDS+=("ResolveHost\(") + KEYWORDS+=("resolveHost\(") + + KEYWORDS+=("udp-socket") + KEYWORDS+=("udpsocket") + KEYWORDS+=("tcp-socket") + KEYWORDS+=("tcpsocket") + KEYWORDS+=("SOCKET") + KEYWORDS+=("mozilla.org/network") +} + +# Step 1: Initialize scope of audit +EXT= +case "${SCOPE}" in + "java" | "kt" | "java-kt" ) + EXT="java kt" + SCOPE="java-kt" + initialize_java_symbols + ;; + "c-cpp" | "c-cxx" | "c" | "cxx" | "cpp" ) + EXT="c cpp h cxx hpp hxx" + SCOPE="c-cpp" + initialize_cpp_symbols + ;; + "rust" ) + EXT="rs" + initialize_rust_symbols + ;; + "js" ) + EXT="js jsm" + initialize_js_symbols + ;; + * ) + echo "requested language not recognized" + exit 1 + ;; +esac + +cd "$REPO_DIR" + +# Step 2: Generate match pattern based on in-scope keywords function join_by { local d=$1; shift; local f=$1; shift; printf %s "$f" "${@/#/$d}"; } -GREP_LINE="$(join_by \| ${KEYWORDS[@]})" +GREP_LINE="$(join_by \| "${KEYWORDS[@]}")" -# Step 2: Obtain patches for all in-scope files where a keyword is present -echo "Diffing patches-${OLD}-${NEW}-${SCOPE}.diff" -path= +# Step 3: Obtain patches for all in-scope files where a keyword is present +declare -a path for ext in ${EXT}; do - path="${path} *.${ext}" + path+=("*.${ext}") done +echo "Diffing patches-${OLD}-${NEW}-${SCOPE}.diff from all ${path[*]} files" # Exclude Deleted and Unmerged files from diff DIFF_FILTER=ACMRTXB -git diff --color=always --color-moved --diff-filter="${DIFF_FILTER}" -U20 -G"${GREP_LINE}" $OLD $NEW -- ${path} > patches-${OLD}-${NEW}-${SCOPE}.diff +git diff --color=always --color-moved --diff-filter="${DIFF_FILTER}" -U20 -G"${GREP_LINE}" "$OLD" "$NEW" -- "${path[@]}" > "patches-${OLD}-${NEW}-${SCOPE}.diff" -# Step 3: Highlight the keyword with an annoying, flashing color +# Step 4: Highlight the keyword with an annoying, flashing color export GREP_COLOR="05;37;41" # Capture the entire file and/or overlap with the previous match, add GREP_COLOR highlighting -egrep -A10000 -B10000 --color=always "${GREP_LINE}" patches-${OLD}-${NEW}-${SCOPE}.diff > keywords-$OLD-$NEW-$SCOPE.diff +grep -A10000 -B10000 --color=always -E "${GREP_LINE}" "patches-${OLD}-${NEW}-${SCOPE}.diff" > "keywords-$OLD-$NEW-$SCOPE.diff" # Add a 'XXX MATCH XXX' at the end of each matched line, easily searchable. -sed -i 's/$\x1b\[05;37;41.*$/\1 XXX MATCH XXX/' keywords-$OLD-$NEW-$SCOPE.diff +sed -i 's/$\x1b\[05;37;41.*$/\1 XXX MATCH XXX/' "keywords-$OLD-$NEW-$SCOPE.diff" -# Step 4: Review the code changes +# Step 5: Review the code changes echo "Diff generated. View it with:" echo " less -R $REPO_DIR/keywords-$OLD-$NEW-$SCOPE.diff"

1 0

[tor-browser-spec/master] Bug 40010: Use full patch diff for code audit
by gk＠torproject.org 19 Mar '21

19 Mar '21

commit 49b2b716aaa4fdc186202584fefccbc1ce62c479 Author: Matthew Finkel <sysrqb(a)torproject.org> Date: Thu Jan 21 21:23:21 2021 +0000 Bug 40010: Use full patch diff for code audit --- audits/java_audit.sh | 28 ++++++++++++++++++---------- 1 file changed, 18 insertions(+), 10 deletions(-) diff --git a/audits/java_audit.sh b/audits/java_audit.sh index 1417011..b1183eb 100644 --- a/audits/java_audit.sh +++ b/audits/java_audit.sh @@ -11,6 +11,7 @@ OLD=$2 NEW=$3 SCOPE="java" # string: this is the java audit +EXT="java kt" declare -a KEYWORDS @@ -62,21 +63,28 @@ KEYWORDS+=("::get\(") cd $REPO_DIR -if [ ! -f "release-${OLD}-${NEW}.diff" ]; -then - echo "Diffing release-${OLD}-${NEW}.diff" - git diff --color=always --color-moved $OLD $NEW -U20 > release-${OLD}-${NEW}.diff -fi - -echo "Done with diff" - +# Step 1: Generate match pattern based on in-scope keywords function join_by { local d=$1; shift; local f=$1; shift; printf %s "$f" "${@/#/$d}"; } GREP_LINE="$(join_by \| ${KEYWORDS[@]})" +# Step 2: Obtain patches for all in-scope files where a keyword is present +echo "Diffing patches-${OLD}-${NEW}-${SCOPE}.diff" +path= +for ext in ${EXT}; do + path="${path} *.${ext}" +done +# Exclude Deleted and Unmerged files from diff +DIFF_FILTER=ACMRTXB +git diff --color=always --color-moved --diff-filter="${DIFF_FILTER}" -U20 -G"${GREP_LINE}" $OLD $NEW -- ${path} > patches-${OLD}-${NEW}-${SCOPE}.diff + +# Step 3: Highlight the keyword with an annoying, flashing color export GREP_COLOR="05;37;41" +# Capture the entire file and/or overlap with the previous match, add GREP_COLOR highlighting +egrep -A10000 -B10000 --color=always "${GREP_LINE}" patches-${OLD}-${NEW}-${SCOPE}.diff > keywords-$OLD-$NEW-$SCOPE.diff -# XXX: Arg this sometimes misses file context -egrep -A40 -B40 --color=always "${GREP_LINE}" release-${OLD}-${NEW}.diff > keywords-${OLD}-${NEW}-$SCOPE.diff +# Add a 'XXX MATCH XXX' at the end of each matched line, easily searchable. +sed -i 's/$\x1b\[05;37;41.*$/\1 XXX MATCH XXX/' keywords-$OLD-$NEW-$SCOPE.diff +# Step 4: Review the code changes echo "Diff generated. View it with:" echo " less -R $REPO_DIR/keywords-$OLD-$NEW-$SCOPE.diff"

1 0

[tor-browser-spec/master] Rename java_audit.sh as code_audit.sh
by gk＠torproject.org 19 Mar '21

19 Mar '21

commit a93a6c96555ad0a8816cc08d9006794dc7b29e28 Author: Matthew Finkel <sysrqb(a)torproject.org> Date: Tue Feb 2 00:34:57 2021 +0000 Rename java_audit.sh as code_audit.sh --- audits/{java_audit.sh => code_audit.sh} | 0 1 file changed, 0 insertions(+), 0 deletions(-) diff --git a/audits/java_audit.sh b/audits/code_audit.sh similarity index 100% rename from audits/java_audit.sh rename to audits/code_audit.sh

1 0

[tor-browser-spec/master] Clean up java_audit script
by gk＠torproject.org 19 Mar '21

19 Mar '21

commit b5a9016a3d7ca0d6843a357f2ffc0118ad5bfc50 Author: Matthew Finkel <sysrqb(a)torproject.org> Date: Thu Jan 21 21:11:55 2021 +0000 Clean up java_audit script --- audits/java_audit.sh | 12 ------------ 1 file changed, 12 deletions(-) diff --git a/audits/java_audit.sh b/audits/java_audit.sh index 51c9bf4..1417011 100644 --- a/audits/java_audit.sh +++ b/audits/java_audit.sh @@ -61,34 +61,22 @@ KEYWORDS+=("::post\(") KEYWORDS+=("::get\(") cd $REPO_DIR -#function join_by { local d=$1; shift; local f=$1; shift; printf %s "$f" "${@/#/ $d}"; } -#GREP_LINE="$(join_by \-G ${KEYWORDS[@]})" - -#base=`git merge-base ${OLD} ${NEW}` if [ ! -f "release-${OLD}-${NEW}.diff" ]; -#if [ ! -f "release-${base}-${NEW}.diff" ]; then echo "Diffing release-${OLD}-${NEW}.diff" - #echo "Diffing release-${base}-${NEW}.diff" git diff --color=always --color-moved $OLD $NEW -U20 > release-${OLD}-${NEW}.diff - #git diff --color=always --color-moved $base $NEW -U20 > release-${base}-${NEW}.diff - #git diff --color=always --color-moved -G${GREP_LINE} $OLD $NEW -U20 > release-${OLD}-${NEW}-G.diff fi echo "Done with diff" function join_by { local d=$1; shift; local f=$1; shift; printf %s "$f" "${@/#/$d}"; } - GREP_LINE="$(join_by \| ${KEYWORDS[@]})" -#GREP_LINE="\+\+\+ |$(join_by \| ${KEYWORDS[@]})" export GREP_COLOR="05;37;41" # XXX: Arg this sometimes misses file context -#egrep -A40 -B40 --color=always "${GREP_LINE}" release-${base}-${NEW}.diff > keywords-${base}-${NEW}-$SCOPE.diff egrep -A40 -B40 --color=always "${GREP_LINE}" release-${OLD}-${NEW}.diff > keywords-${OLD}-${NEW}-$SCOPE.diff echo "Diff generated. View it with:" -#echo " less -R $REPO_DIR/keywords-$base-$NEW-$SCOPE.diff" echo " less -R $REPO_DIR/keywords-$OLD-$NEW-$SCOPE.diff"

1 0

[tor-browser-spec/master] Bug 40016: Add FF87 audit
by gk＠torproject.org 19 Mar '21

19 Mar '21

commit 82aa16329ad0e1e03d2dda72a67c2dd4e47fb8d5 Author: Matthew Finkel <sysrqb(a)torproject.org> Date: Mon Mar 15 17:55:22 2021 +0000 Bug 40016: Add FF87 audit --- audits/FF87_NETWORK_AUDIT | 153 ++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 153 insertions(+) diff --git a/audits/FF87_NETWORK_AUDIT b/audits/FF87_NETWORK_AUDIT new file mode 100644 index 0000000..8874897 --- /dev/null +++ b/audits/FF87_NETWORK_AUDIT @@ -0,0 +1,153 @@ +Start: fe9560804bef331ff346f3fd3b05e74122fdd30b # FIREFOX_86_0_BUILD2 +End: 1be3d58406ce4dd8af63a169482ae4ca1709d8e5 # FIREFOX_87_0b9_BUILD1 + +`git diff fe9560804bef331ff346f3fd3b05e74122fdd30b 1be3d58406ce4dd8af63a169482ae4ca1709d8e5` +and then go over all the changes containing the +below mentioned potentially dangerous calls and features. Grep the diff for +the following strings and examine surrounding usage. + +=============== Native DNS Portion ============= + +PR_GetHostByName +PR_GetIPNodeByName +PR_GetAddrInfoByName +PR_StringToNetAddr (itself is good as it passes AI_NUMERICHOST to getaddrinfo. No resolution.) + +MDNS +TRR (DNS Trusted Recursive Resolver) +Direct Paths to DNS resolution: +nsDNSService::Resolve +nsDNSService::AsyncResolve +nsHostResolver::ResolveHost + +# FF87: +# Bug 902346: +# - Support socks proxy in TCPSocket +# - Review Result: Safe + +# Bug 1684040 +# - Introduce new ODoH class for sending ODoH queries +# - Review Result: Safe (if TRR is safe) + +# Bug 1690615 +# - Move DNS lookup into DnsAndConnectSocket +# - Review Result: Safe + +============ Misc Socket Portion ============== + +SOCK_ +SOCKET_ +_SOCKET + +# FF87: +# Bug 1693270 +# - Switch audioipc-2 to vendored code +# - Review Result: Probably safe. + +UDPSocket +TCPSocket + PR_NewTCPSocket + AsyncTCPSocket + +Misc PR_Socket + +# FF87: Nothing of interest + +=========== Misc XPCOM Portion ================ + +Misc XPCOM (including commands for pre-diff review approach) + *SocketProvider + grep -R udp-socket . + grep -R tcp-socket . + grep for tcpsocket + grep -R "NS_" | grep SOCKET | grep "_C" + grep -R "@mozilla.org/network/" . | grep socket | grep -v udp-socket + +# FF87: Nothing of interest + +============ Rust Portion ================ + +Rust + - XXX: What do we grep for here? Or do we rely on Ritter's compile-time tool? + - Check for new sendmsg and recvmsg usage + +# FF87: Nothing of interest (using `java_audit.sh`) + +============ Android Portion ============= + +Android Java calls + - URLConnection + - XXX: getInputStream? other methods? + - HttpURLConnection + - UrlConnectionDownloader + - ch.boye.httpclientandroidlib.impl.client.* (look for execute() calls) + - grep -n openConnection\( mobile/android/thirdparty/ + - java.net.URL -- has SEVERAL proxy bypass URL fetching methods :/ + - java.net + - javax.net + - ch.boye.httpclientandroidlib.conn.* (esp ssl) + - ch.boye.httpclientandroidlib.impl.conn.* (esp ssl) + - Sudden appearance of thirdparty libs: + - OkHttp + - Retrofit + - Glide + - com.amitshekhar.android + - IntentHelper + - openUriExternal (can come from GeckoAppShell too) + - getHandlersForMimeType + - getHandlersForURL + - getHandlersForIntent + - android.content.Intent - too common; instead find launch methods: + - startActivity + - startActivities + - sendBroadcast + - sendOrderedBroadcast + - startService + - bindService + - android.app.PendingIntent + - android.app.DownloadManager + - ActivityHandlerHelper.startIntentAndCatch + +# FF87: Nothing new (using `java_audit.sh`) + +============ Application Services Portion ============= + +Start: 4cc798c8cd8a1e38ce88e0bb22a05692be63b164 # v67.2.0 +End: 1ee6b32f3ee569036fdf1015cf7ffc01ded2860f # v71.0.0 + +# FF87: Nothing related to networking in Java/Koltlin/Rust code (using `java_audit.sh`) + +============ Android Components Portion ============= + +Start: 095c0ef007ada4dab8561bef69e43bf6db1d3298 # v72.0.15 +End: ecccbf2da2b0572a1d600cce447d47f2eae0de9a # v73.0.3 + +# FF87 (using `java_audit.sh`) +# Commit 6edfec5fe464e4b1d0eb82ed8825526036d861c8 +# - Add prototype component to support Android's autofill framework. +# - Review Result: Conditionally Safe +# - Comments: +# - 1) Hooks into Android's Autofill service +# - 2) Uses PendingIntent, safety depends on usage. Not currently used +# in Fenix. + +# Issue #9417 +# - Add support for sharing actual website images (#9420) +# - Review Result: Patch with external app prompt + +============ Fenix Portion ============= + +Start: db196d0e49eb0f69ab620856491deb8c4c7ccf57 # v86.1.0 +End: 82c8a64ca0b8bd5e6ea88395cba41c0db68d0a36 # v87.0.0-beta.4 + +# FF87: (using `java_audit.sh`) +# - c9b8f57f96e9188746391885a065428df62f3ff9 +# - Refactor BrowserToolbarMenuController to use browser store +# - Review Result: Safe + +============ Regression/Prior Vuln Review ========= + +Review proxy bypass bugs; check for new vectors to look for: + - https://trac.torproject.org/projects/tor/query?keywords=~tbb-proxy + - Look for new features like these. Especially external app launch vectors +

1 0

[tor-browser-spec/master] Merge remote-tracking branch 'gitlab/merge-requests/26'
by gk＠torproject.org 19 Mar '21

19 Mar '21

commit 2d8705e699f2bf7a00bc52ca6a38b1b5326b93e4 Merge: 82aa163 6735a8b Author: Georg Koppen <gk(a)torproject.org> Date: Fri Mar 19 21:04:59 2021 +0000 Merge remote-tracking branch 'gitlab/merge-requests/26' audits/NETWORK_AUDIT_RUBRIC | 93 ++++++------------------ audits/code_audit.sh | 168 ++++++++++++++++++++++++++++++++++++++++++++ audits/java_audit.sh | 94 ------------------------- 3 files changed, 190 insertions(+), 165 deletions(-)

1 0

[translation/snowflakeaddon-messages.json] https://gitweb.torproject.org/translation.git/commit/?h=snowflakeaddon-messages.json
by translation＠torproject.org 19 Mar '21

19 Mar '21

commit b3a301a9acab9ce5f85a81ba1ad4eb4720dd79cf Author: Translation commit bot <translation(a)torproject.org> Date: Fri Mar 19 19:45:44 2021 +0000 https://gitweb.torproject.org/translation.git/commit/?h=snowflakeaddon-mess… --- it/messages.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/it/messages.json b/it/messages.json index dd259d9085..a0bc0f728a 100644 --- a/it/messages.json +++ b/it/messages.json @@ -36,7 +36,7 @@ "message": "I cookie non sono attivati." }, "websiteIntro": { - "message": "Snowflake is a system to defeat internet censorship. People who are censored can use Snowflake to access the internet. Their connection goes through Snowflake proxies, which are run by volunteers. For more detailed information about how Snowflake works see our <a href=\"https://gitlab.torproject.org/tpo/anti-censorship/pluggable-transports/snow…">documentation wiki</a>." + "message": "Snowflake è un sistema per sconfiggere la censura di internet. Le persone che sono sottoposte a censura possono usare Snowflake per accedere ad internet. Le loro connessioni passano attraverso i proxy Snowflake, che sono gestiti da volontari. Per informazioni più dettagliate su come funziona Snowflake, leggi la nostra <a href=\"https://trac.torproject.org/projects/tor/wiki/doc/Snowflake/\" data-msgid=\"__MSG_docWiki__\">wiki di documentazione</a>." }, "browser": { "message": "Browser"

1 0

[tpo/master] Remove metrics data architect job. Fix #166
by gus＠torproject.org 19 Mar '21

19 Mar '21

commit 4cf60471a3db27bbca05b8ccdc60093dbedb5274 Author: gus <gus(a)torproject.org> Date: Fri Mar 19 16:02:26 2021 -0300 Remove metrics data architect job. Fix #166 --- content/about/jobs/metrics-data-architect/contents.lr | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/content/about/jobs/metrics-data-architect/contents.lr b/content/about/jobs/metrics-data-architect/contents.lr index 94ed6775..7f3b612d 100644 --- a/content/about/jobs/metrics-data-architect/contents.lr +++ b/content/about/jobs/metrics-data-architect/contents.lr @@ -6,7 +6,7 @@ section: about --- section_id: about --- -active: True +active: False --- title: Metrics Data Architect ---

1 0