tor-commits October 2021

tor-commits@lists.torproject.org

15 participants
2054 discussions

[translation/support-portal] https://gitweb.torproject.org/translation.git/commit/?h=support-portal
by translation＠torproject.org 14 Oct '21

14 Oct '21

commit 1075a8701c3c9531e42d8033ce70f2c4af2958c7 Author: Translation commit bot <translation(a)torproject.org> Date: Thu Oct 14 19:47:48 2021 +0000 https://gitweb.torproject.org/translation.git/commit/?h=support-portal --- contents+ar.po | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/contents+ar.po b/contents+ar.po index debb028170..23b232831a 100644 --- a/contents+ar.po +++ b/contents+ar.po @@ -13630,7 +13630,7 @@ msgstr "" #: https//support.torproject.org/get-in-touch/why-i-cant-join-tor-channels/ #: (content/get-in-touch/why-i-cant-join-tor-channels/contents+en.lrquestion.description) msgid "Here's how to reach #tor-project and other registered channels." -msgstr "إليك كيفية الوصول إلى # tor-project والقنوات المسجلة الأخرى." +msgstr "إليك كيفية الوصول إلى #‎tor-project والقنوات المسجلة الأخرى." #: https//support.torproject.org/get-in-touch/why-i-cant-join-tor-channels/ #: (content/get-in-touch/why-i-cant-join-tor-channels/contents+en.lrquestion.description)

1 0

[tor/main] Lower maximum value for guard-extreme-restriction-percent to 100.
by ahf＠torproject.org 14 Oct '21

14 Oct '21

commit 15ede0435f5d161e34c11770b6a96f0f31b6cf2f Author: Nick Mathewson <nickm(a)torproject.org> Date: Thu Oct 14 12:39:05 2021 -0400 Lower maximum value for guard-extreme-restriction-percent to 100. Values greater than 100 would have had the same effect as 100, so this doesn't actually change Tor's behavior; it just makes the intent clearer. Fixes #40486; see also torspec#66. --- changes/bug40486 | 5 +++++ src/feature/client/entrynodes.c | 2 +- 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/changes/bug40486 b/changes/bug40486 new file mode 100644 index 0000000000..83315bfb2b --- /dev/null +++ b/changes/bug40486 @@ -0,0 +1,5 @@ + o Code simplification and refactoring: + - Lower the official maximum for "guard-extreme-restriction-percent" to + 100. This has no effect on when the guard code will generate a warning, + but it makes the intent of the option clearer. Fixes bug 40486; bugfix + on 0.3.0.1-alpha. diff --git a/src/feature/client/entrynodes.c b/src/feature/client/entrynodes.c index 9583a4db71..315bd54674 100644 --- a/src/feature/client/entrynodes.c +++ b/src/feature/client/entrynodes.c @@ -559,7 +559,7 @@ get_extreme_restriction_threshold(void) int32_t pct = networkstatus_get_param(NULL, "guard-extreme-restriction-percent", DFLT_EXTREME_RESTRICTION_PERCENT, - 1, INT32_MAX); + 1, 100); return pct / 100.0; }

1 0

[tor/main] Merge remote-tracking branch 'tor-gitlab/mr/459' into main
by ahf＠torproject.org 14 Oct '21

14 Oct '21

commit 8c18e9a949a76f53b7892739205bf29a8c020224 Merge: b93af906c4 15ede0435f Author: Alexander Færøy <ahf(a)torproject.org> Date: Thu Oct 14 19:19:32 2021 +0000 Merge remote-tracking branch 'tor-gitlab/mr/459' into main changes/bug40486 | 5 +++++ src/feature/client/entrynodes.c | 2 +- 2 files changed, 6 insertions(+), 1 deletion(-)

1 0

[tor/main] hs: Fix memory leak if service failed to configure
by ahf＠torproject.org 14 Oct '21

14 Oct '21

commit e0a6a0d085e7918f1128d6300aa64361467a0c3f Author: David Goulet <dgoulet(a)torproject.org> Date: Thu Oct 14 10:09:25 2021 -0400 hs: Fix memory leak if service failed to configure Closes #40484 Signed-off-by: David Goulet <dgoulet(a)torproject.org> --- changes/ticket40484 | 5 +++++ src/feature/hs/hs_config.c | 1 + 2 files changed, 6 insertions(+) diff --git a/changes/ticket40484 b/changes/ticket40484 new file mode 100644 index 0000000000..9a9ffdf448 --- /dev/null +++ b/changes/ticket40484 @@ -0,0 +1,5 @@ + o Minor bugfixes (onion service, config): + - Fix a memory leak for a small config line string that could occur if the + service failed to be configured from file properly. Fixes bug 40484; + bugfix on 0.3.2.1-alpha. + diff --git a/src/feature/hs/hs_config.c b/src/feature/hs/hs_config.c index f9f71c78f2..de1f608ddf 100644 --- a/src/feature/hs/hs_config.c +++ b/src/feature/hs/hs_config.c @@ -640,6 +640,7 @@ hs_config_service_all(const or_options_t *options, int validate_only) int rv = config_service(section, options, new_service_list); config_free_lines(section); if (rv < 0) { + config_free_lines(remaining); goto err; } }

1 0

[tor/main] Merge remote-tracking branch 'tor-gitlab/mr/456' into main
by ahf＠torproject.org 14 Oct '21

14 Oct '21

commit b93af906c444a71b52105c49239069adf680efad Merge: 1ea523c705 e0a6a0d085 Author: Alexander Færøy <ahf(a)torproject.org> Date: Thu Oct 14 19:18:22 2021 +0000 Merge remote-tracking branch 'tor-gitlab/mr/456' into main changes/ticket40484 | 5 +++++ src/feature/hs/hs_config.c | 1 + 2 files changed, 6 insertions(+)

1 0

[translation/support-portal] https://gitweb.torproject.org/translation.git/commit/?h=support-portal
by translation＠torproject.org 14 Oct '21

14 Oct '21

commit 7cbb7c7dc0266d4ab5abe9be2f22d67eec18b469 Author: Translation commit bot <translation(a)torproject.org> Date: Thu Oct 14 19:17:50 2021 +0000 https://gitweb.torproject.org/translation.git/commit/?h=support-portal --- contents+ar.po | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/contents+ar.po b/contents+ar.po index 695627263b..debb028170 100644 --- a/contents+ar.po +++ b/contents+ar.po @@ -13724,7 +13724,7 @@ msgstr "" #: https//support.torproject.org/get-in-touch/why-i-cant-join-tor-channels/ #: (content/get-in-touch/why-i-cant-join-tor-channels/contents+en.lrquestion.description) msgid "`/msg nickserv checkverify`" -msgstr "`/msg اسم المستخدم تحقق`" +msgstr "`/msg nickserv checkverify`" #: https//support.torproject.org/get-in-touch/why-i-cant-join-tor-channels/ #: (content/get-in-touch/why-i-cant-join-tor-channels/contents+en.lrquestion.description)

1 0

[snowflake/main] Unify broker/bridge domains to torproject.net
by cohosh＠torproject.org 14 Oct '21

14 Oct '21

commit 54ab79384f94b52edc444063408de1394e507417 Author: Cecylia Bocovich <cohosh(a)torproject.org> Date: Thu Oct 14 11:14:22 2021 -0400 Unify broker/bridge domains to torproject.net --- doc/snowflake-proxy.1 | 4 ++-- proxy/README.md | 4 ++-- proxy/snowflake.go | 4 ++-- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/doc/snowflake-proxy.1 b/doc/snowflake-proxy.1 index ccdd9a2..67f71b6 100644 --- a/doc/snowflake-proxy.1 +++ b/doc/snowflake-proxy.1 @@ -9,7 +9,7 @@ Snowflake bridge and then through the Tor network. .HP \fB\-broker\fR string .IP -broker URL (default "https://snowflake\-broker.bamsoftware.com/") +broker URL (default "https://snowflake\-broker.torproject.net/") .HP \fB\-capacity\fR uint .IP @@ -25,7 +25,7 @@ log filename .HP \fB\-relay\fR string .IP -websocket relay URL (default "wss://snowflake.bamsoftware.com/") +websocket relay URL (default "wss://snowflake.torproject.net/") .HP \fB\-stun\fR string .IP diff --git a/proxy/README.md b/proxy/README.md index a7496da..e736667 100644 --- a/proxy/README.md +++ b/proxy/README.md @@ -30,7 +30,7 @@ The Snowflake proxy can be run with the following options: ``` Usage of ./proxy: -broker string - broker URL (default "https://snowflake-broker.bamsoftware.com/") + broker URL (default "https://snowflake-broker.torproject.net/") -capacity uint maximum concurrent clients -keep-local-addresses @@ -38,7 +38,7 @@ Usage of ./proxy: -log string log filename -relay string - websocket relay URL (default "wss://snowflake.bamsoftware.com/") + websocket relay URL (default "wss://snowflake.torproject.net/") -stun string stun URL (default "stun:stun.stunprotocol.org:3478") -unsafe-logging diff --git a/proxy/snowflake.go b/proxy/snowflake.go index d694471..7d7f9a2 100644 --- a/proxy/snowflake.go +++ b/proxy/snowflake.go @@ -25,9 +25,9 @@ import ( "github.com/pion/webrtc/v3" ) -const defaultBrokerURL = "https://snowflake-broker.bamsoftware.com/" +const defaultBrokerURL = "https://snowflake-broker.torproject.net/" const defaultProbeURL = "https://snowflake-broker.torproject.net:8443/probe" -const defaultRelayURL = "wss://snowflake.bamsoftware.com/" +const defaultRelayURL = "wss://snowflake.torproject.net/" const defaultSTUNURL = "stun:stun.stunprotocol.org:3478" const pollInterval = 5 * time.Second const (

1 0

[snowflake-webext/main] Unify bridge/broker domains to freehaven.net
by cohosh＠torproject.org 14 Oct '21

14 Oct '21

commit 2eb7adaa66485ac088eba8c6f856bf9717fdd311 Author: Cecylia Bocovich <cohosh(a)torproject.org> Date: Thu Oct 14 11:21:00 2021 -0400 Unify bridge/broker domains to freehaven.net It's still the case that torproject.net can be blocked on residential or public networks, so we're going with the safer freehaven.net domain. --- config.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/config.js b/config.js index 2e7555a..d05554c 100644 --- a/config.js +++ b/config.js @@ -50,4 +50,4 @@ Config.prototype.pcConfig = { ] }; -Config.PROBEURL = "https://snowflake-broker.torproject.net:8443/probe"; +Config.PROBEURL = "https://snowflake-broker.freehaven.net:8443/probe";

1 0

[tor/main] Downgrade "Rejecting RENDEZVOUS1 cell with unrecognized cookie"
by dgoulet＠torproject.org 14 Oct '21

14 Oct '21

commit d10ceb7165effc30d38edbbe370f311c4719d2b6 Author: Nick Mathewson <nickm(a)torproject.org> Date: Thu Oct 14 12:21:30 2021 -0400 Downgrade "Rejecting RENDEZVOUS1 cell with unrecognized cookie" This is the loudest of our LOG_PROTOCOL_WARN messages, it can occur naturally, and there doesn't seem to be a great response to it. Partial fix for 40400; bugfix on 0.1.1.13-alpha. --- changes/bug40400_part2 | 5 +++++ src/feature/rend/rendmid.c | 6 +++++- 2 files changed, 10 insertions(+), 1 deletion(-) diff --git a/changes/bug40400_part2 b/changes/bug40400_part2 new file mode 100644 index 0000000000..9b834d5ea1 --- /dev/null +++ b/changes/bug40400_part2 @@ -0,0 +1,5 @@ + o Minor bugfixes (usability): + - Do not log "RENDEZVOUS1 cell with unrecognized rendezvous cookie" + at LOG_PROTOCOL_WARN; instead log it at DEBUG. This warning can happen + naturally if a client gives up on a rendezvous circuit after sending + INTRODUCE1. Fixes part of bug 40400; bugfix on 0.1.1.13-alpha. diff --git a/src/feature/rend/rendmid.c b/src/feature/rend/rendmid.c index df838aa527..8f6a45dfef 100644 --- a/src/feature/rend/rendmid.c +++ b/src/feature/rend/rendmid.c @@ -131,7 +131,11 @@ rend_mid_rendezvous(or_circuit_t *circ, const uint8_t *request, rend_circ = hs_circuitmap_get_rend_circ_relay_side(request); if (!rend_circ) { - log_fn(LOG_PROTOCOL_WARN, LD_PROTOCOL, + /* Once this was a LOG_PROTOCOL_WARN, but it can happen naturally if a + * client gives up on a rendezvous circuit after sending INTRODUCE1, but + * before the onion service sends the RENDEZVOUS1 cell. + */ + log_fn(LOG_DEBUG, LD_PROTOCOL, "Rejecting RENDEZVOUS1 cell with unrecognized rendezvous cookie %s.", hexid); reason = END_CIRC_REASON_TORPROTOCOL;

1 0

[tor/main] Merge branch 'tor-gitlab/mr/458'
by dgoulet＠torproject.org 14 Oct '21

14 Oct '21

commit 1ea523c705755df6ed63a4aa0cd548d2990e3fe2 Merge: ed4b8ca74b d10ceb7165 Author: David Goulet <dgoulet(a)torproject.org> Date: Thu Oct 14 13:09:21 2021 -0400 Merge branch 'tor-gitlab/mr/458' changes/bug40400_part2 | 5 +++++ src/feature/rend/rendmid.c | 6 +++++- 2 files changed, 10 insertions(+), 1 deletion(-)

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

tor-commits October 2021