tor-commits July 2020

tor-commits@lists.torproject.org

17 participants
2100 discussions

[tor/master] Improve docs for addr, address, and real_addr fields
by nickm＠torproject.org 13 Jul '20

13 Jul '20

commit 02cff32d7947cd230b1dab299b29dec5315ea4b9 Author: Nick Mathewson <nickm(a)torproject.org> Date: Mon Jul 13 12:13:41 2020 -0400 Improve docs for addr, address, and real_addr fields These fields have a complicated history, some slightly complicated behavior, and some definitely inadequate documentation. Before we go fixing them up, let's document how they work now. --- src/core/or/connection_st.h | 52 +++++++++++++++++++++++++++++++++++++----- src/core/or/or_connection_st.h | 16 +++++++++---- 2 files changed, 58 insertions(+), 10 deletions(-) diff --git a/src/core/or/connection_st.h b/src/core/or/connection_st.h index 55d94d9451..508328f75c 100644 --- a/src/core/or/connection_st.h +++ b/src/core/or/connection_st.h @@ -109,6 +109,39 @@ struct connection_t { int socket_family; /**< Address family of this connection's socket. Usually * AF_INET, but it can also be AF_UNIX, or AF_INET6 */ + /** + * IP address on the internet of this connection's peer, usually. + * + * This address may come from several sources. If this is an outbound + * connection, it is the address we are trying to connect to--either + * directly through `s`, or via a proxy. (If we used a proxy, then + * `getpeername(s)` will not give this address.) + * + * For incoming connections, this field is the address we got from + * getpeername() or accept(), as updated by any proxy that we + * are using (for example, an ExtORPort proxy). + * + * For listeners, this is the address we are trying to bind to. + * + * If this connection is using a unix socket, then this address is a null + * address, and the real address is in the `address` field. + * + * If this connection represents a request made somewhere other than via + * TCP (for example, a UDP dns request, or a controller resolve request), + * then this address is the address that originated the request. + * + * TECHNICAL DEBT: + * + * There are a few places in the code that modify this address, + * or use it in other ways that we don't currently like. Please don't add + * any more! + * + * The misuses of this field include: + * * Setting it to the canonical address of a relay on an OR connection. + * * Setting it on linked connections, possibly. + * * Updating it based on the Forwarded-For header-- Forwarded-For is + * set by a proxy, but not a local trusted troxy. + **/ tor_addr_t addr; /**< IP that socket "s" is directly connected to; * may be the IP address for a proxy or pluggable transport, * see "address" for the address of the final destination. @@ -122,12 +155,19 @@ struct connection_t { * marked.) */ const char *marked_for_close_file; /**< For debugging: in which file were * we marked for close? */ - char *address; /**< FQDN (or IP) and port of the final destination for this - * connection; this is always the remote address, it is - * passed to a proxy or pluggable transport if one in use. - * See "addr" and "port" for the address that socket "s" is - * directly connected to. - * strdup into this, because free_connection() frees it. */ + /** + * String address of the peer of this connection. + * + * TECHNICAL DEBT: + * + * This field serves many purposes, and they're not all pretty. In addition + * to describing the peer we're connected to, it can also hold: + * + * * An address we're trying to resolve (as an exit). + * * A unix address we're trying to bind to (as a listener). + * * A canonical address for an OR connection. + **/ + char *address; /** Another connection that's connected to this one in lieu of a socket. */ struct connection_t *linked_conn; diff --git a/src/core/or/or_connection_st.h b/src/core/or/or_connection_st.h index 92956c2847..2507f90803 100644 --- a/src/core/or/or_connection_st.h +++ b/src/core/or/or_connection_st.h @@ -49,10 +49,18 @@ struct or_connection_t { /* Channel using this connection */ channel_tls_t *chan; - tor_addr_t real_addr; /**< The actual address that this connection came from - * or went to. The addr field is prone to - * getting overridden by the address from the router - * descriptor matching identity_digest. */ + /** + * The actual address (as modified by any proxies) that this connection + * came from or went to. (See connection_t.addr for caveats.) + * + * TECHNICAL DEBT: + * + * This field shouldn't really exist. We need it because our code + * overwrites conenction_t.addr with the "canonical address" of the OR we + * are talking to, taken from the descriptor of the authenticated OR. + * That's a bad choice. + **/ + tor_addr_t real_addr; /** Should this connection be used for extending circuits to the server * matching the identity_digest field? Set to true if we're pretty

1 0

[tor/maint-0.4.4] Changes file for ticket 31812.
by nickm＠torproject.org 13 Jul '20

13 Jul '20

commit eb427f309cbe2eb82769fdec4e9b7a7249c3287b Author: Nick Mathewson <nickm(a)torproject.org> Date: Mon Jul 13 10:42:41 2020 -0400 Changes file for ticket 31812. --- changes/ticket31812 | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/changes/ticket31812 b/changes/ticket31812 new file mode 100644 index 000000000..869e49489 --- /dev/null +++ b/changes/ticket31812 @@ -0,0 +1,4 @@ + o Documentation: + - Replace most http:// URLs in our code and documentation with https:// + URLs. (We have left unchanged the code in src/ext/, and the text in + LICENSE.) Closes ticket 31812. Patch from Jeremy Rand.

1 0

[tor/maint-0.4.4] Bug 31812: Change http URL's to https
by nickm＠torproject.org 13 Jul '20

13 Jul '20

commit 0be80fb65003df21bece5d56e298b7fbf277b429 Author: JeremyRand <biolizard89(a)gmail.com> Date: Fri Sep 20 07:58:30 2019 +0000 Bug 31812: Change http URL's to https --- contrib/clang/sanitize_blacklist.txt | 4 ++-- contrib/operator-tools/tor-exit-notice.html | 4 ++-- doc/HACKING/CodingStandards.md | 2 +- doc/HACKING/CodingStandardsRust.md | 4 ++-- doc/HACKING/Fuzzing.md | 4 ++-- doc/HACKING/GettingStarted.md | 2 +- doc/HACKING/GettingStartedRust.md | 2 +- doc/building-tor-msvc.txt | 8 ++++---- doc/contrib/tor-rpm-creation.txt | 2 +- doc/tor-gencert.1.txt | 2 +- doc/tor-print-ed-signing-cert.1.txt | 2 +- doc/tor-resolve.1.txt | 2 +- doc/tor.1.txt | 2 +- doc/torify.1.txt | 2 +- m4/ax_check_sign.m4 | 2 +- m4/pkg.m4 | 2 +- src/app/config/config.c | 2 +- src/app/main/ntmain.c | 2 +- src/config/mmdb-convert.py | 2 +- src/core/or/circuitstats.c | 12 ++++++------ src/core/or/scheduler.c | 2 +- src/lib/evloop/timers.c | 2 +- src/lib/math/laplace.c | 2 +- src/lib/process/restrict.c | 6 +++--- src/test/slow_ed25519.py | 2 +- src/test/test_crypto_slow.c | 2 +- src/test/test_options.c | 4 ++-- src/test/test_prob_distr.c | 2 +- src/test/test_util.c | 2 +- 29 files changed, 44 insertions(+), 44 deletions(-) diff --git a/contrib/clang/sanitize_blacklist.txt b/contrib/clang/sanitize_blacklist.txt index c71cc4d87..2ce787975 100644 --- a/contrib/clang/sanitize_blacklist.txt +++ b/contrib/clang/sanitize_blacklist.txt @@ -1,6 +1,6 @@ # clang sanitizer special case list -# syntax specified in http://clang.llvm.org/docs/SanitizerSpecialCaseList.html -# for more info see http://clang.llvm.org/docs/AddressSanitizer.html +# syntax specified in https://clang.llvm.org/docs/SanitizerSpecialCaseList.html +# for more info see https://clang.llvm.org/docs/AddressSanitizer.html # # Tor notes: This file is obsolete! diff --git a/contrib/operator-tools/tor-exit-notice.html b/contrib/operator-tools/tor-exit-notice.html index f0f9a6344..278d3de50 100644 --- a/contrib/operator-tools/tor-exit-notice.html +++ b/contrib/operator-tools/tor-exit-notice.html @@ -254,7 +254,7 @@ seize this router will accomplish nothing. Furthermore, this machine also serves as a carrier of email, which means that its contents are further protected under the ECPA. <a -href="http://www.law.cornell.edu/uscode/text/18/2707">18 +href="https://www.law.cornell.edu/uscode/text/18/2707">18 USC 2707</a> explicitly allows for civil remedies ($1000/account plus legal fees) in the event of a seizure executed without good faith or probable cause (it @@ -272,7 +272,7 @@ used to violate the DMCA, please be aware that this machine does not host or contain any illegal content. Also be aware that network infrastructure maintainers are not liable for the type of content that passes over their equipment, in accordance with <a -href="http://www.law.cornell.edu/uscode/text/17/512">DMCA +href="https://www.law.cornell.edu/uscode/text/17/512">DMCA "safe harbor" provisions</a>. In other words, you will have just as much luck sending a takedown notice to the Internet backbone providers. Please consult <a href="https://www.torproject.org/eff/tor-dmca-response">EFF's prepared diff --git a/doc/HACKING/CodingStandards.md b/doc/HACKING/CodingStandards.md index 99bc3e502..150acf185 100644 --- a/doc/HACKING/CodingStandards.md +++ b/doc/HACKING/CodingStandards.md @@ -336,7 +336,7 @@ General advice: For additional useful advice (and a little bit of background), see [What Every Programmer Should Know About Floating-Point -Arithmetic](http://floating-point-gui.de/). +Arithmetic](https://floating-point-gui.de/). A list of notable (and surprising) facts about floating point arithmetic is at [Floating-point diff --git a/doc/HACKING/CodingStandardsRust.md b/doc/HACKING/CodingStandardsRust.md index 97026c9b7..36a0dcda2 100644 --- a/doc/HACKING/CodingStandardsRust.md +++ b/doc/HACKING/CodingStandardsRust.md @@ -210,10 +210,10 @@ Here are some additional bits of advice and rules: > > * Data races > * Dereferencing a null/dangling raw pointer - > * Reads of [undef](http://llvm.org/docs/LangRef.html#undefined-values) + > * Reads of [undef](https://llvm.org/docs/LangRef.html#undefined-values) > (uninitialized) memory > * Breaking the - > [pointer aliasing rules](http://llvm.org/docs/LangRef.html#pointer-aliasing-rules) + > [pointer aliasing rules](https://llvm.org/docs/LangRef.html#pointer-aliasing-rules) > with raw pointers (a subset of the rules used by C) > * `&mut T` and `&T` follow LLVM’s scoped noalias model, except if the `&T` > contains an `UnsafeCell`. Unsafe code must not violate these aliasing diff --git a/doc/HACKING/Fuzzing.md b/doc/HACKING/Fuzzing.md index 41853a8a2..487716bb6 100644 --- a/doc/HACKING/Fuzzing.md +++ b/doc/HACKING/Fuzzing.md @@ -25,7 +25,7 @@ have a reasonably recent clang and libfuzzer installed. At that point, you just build with --enable-expensive-hardening and --enable-libfuzzer. That will produce a set of binaries in src/test/fuzz/lf-fuzz-* . These programs take as input a series of directories full of fuzzing examples. For more -information on libfuzzer, see http://llvm.org/docs/LibFuzzer.html +information on libfuzzer, see https://llvm.org/docs/LibFuzzer.html Third, there's Google's OSS-Fuzz infrastructure, which expects to get all of its. For more on this, see https://github.com/google/oss-fuzz and the @@ -72,7 +72,7 @@ and then not actually use it. Read afl/docs/notes_for_asan.txt for more details. - Download recidivm from http://jwilk.net/software/recidivm + Download recidivm from https://jwilk.net/software/recidivm Download the signature Check the signature tar xvzf recidivm*.tar.gz diff --git a/doc/HACKING/GettingStarted.md b/doc/HACKING/GettingStarted.md index c2ca74d96..633a7f041 100644 --- a/doc/HACKING/GettingStarted.md +++ b/doc/HACKING/GettingStarted.md @@ -22,7 +22,7 @@ and any high-quality guide to C for information on programming.) I'm also going to assume that you know a little bit about how to use Git, or that you're able to follow one of the several excellent guides -at [git-scm](http://git-scm.org) to learn. +at [git-scm](https://git-scm.org) to learn. Most Tor developers develop using some Unix-based system, such as GNU/Linux, BSD, or macOS. It's okay to develop on Windows if you want, but you're diff --git a/doc/HACKING/GettingStartedRust.md b/doc/HACKING/GettingStartedRust.md index 247ea5c69..af80018f4 100644 --- a/doc/HACKING/GettingStartedRust.md +++ b/doc/HACKING/GettingStartedRust.md @@ -43,7 +43,7 @@ is [The Little Book of Rust Macros](https://danielkeep.github.io/tlborm/book/index.html). For learning more about FFI and Rust, see Jake Goulding's -[Rust FFI Omnibus](http://jakegoulding.com/rust-ffi-omnibus/). +[Rust FFI Omnibus](https://jakegoulding.com/rust-ffi-omnibus/). ## Compiling Tor with Rust enabled diff --git a/doc/building-tor-msvc.txt b/doc/building-tor-msvc.txt index 3d3eced8a..dbc644d17 100644 --- a/doc/building-tor-msvc.txt +++ b/doc/building-tor-msvc.txt @@ -11,15 +11,15 @@ Requirements: ------------- * Visual Studio 2010 - http://go.microsoft.com/fwlink/?LinkId=323467 + https://go.microsoft.com/fwlink/?LinkId=323467 * CMake 2.8.12.2 - http://www.cmake.org/download/ + https://www.cmake.org/download/ * Perl 5.16 - http://www.activestate.com/activeperl/downloads + https://www.activestate.com/activeperl/downloads * Latest stable OpenSSL tarball https://www.openssl.org/source/ * Latest stable zlib tarball - http://zlib.net/ + https://zlib.net/ * Latest stable libevent Libevent tarball https://github.com/libevent/libevent/releases diff --git a/doc/contrib/tor-rpm-creation.txt b/doc/contrib/tor-rpm-creation.txt index 9c4e05764..f4090aa87 100644 --- a/doc/contrib/tor-rpm-creation.txt +++ b/doc/contrib/tor-rpm-creation.txt @@ -4,7 +4,7 @@ The process used to create the official rpms is as follows: You'll need to install libevent headers, usually located in package named libevent-devel. Alternatively, you could download latest libevent from -http://libevent.org/ but that shouldn't be necessary. +https://libevent.org/ but that shouldn't be necessary. Download and Extract the latest tor source code from https://www.torproject.org/download diff --git a/doc/tor-gencert.1.txt b/doc/tor-gencert.1.txt index 6bba548b8..26f68b29c 100644 --- a/doc/tor-gencert.1.txt +++ b/doc/tor-gencert.1.txt @@ -1,7 +1,7 @@ // Copyright (c) The Tor Project, Inc. // See LICENSE for licensing information // This is an asciidoc file used to generate the manpage/html reference. -// Learn asciidoc on http://www.methods.co.nz/asciidoc/userguide.html +// Learn asciidoc on https://www.methods.co.nz/asciidoc/userguide.html :man source: Tor :man manual: Tor Manual tor-gencert(1) diff --git a/doc/tor-print-ed-signing-cert.1.txt b/doc/tor-print-ed-signing-cert.1.txt index 48a3f095d..71c8b67ec 100644 --- a/doc/tor-print-ed-signing-cert.1.txt +++ b/doc/tor-print-ed-signing-cert.1.txt @@ -1,7 +1,7 @@ // Copyright (c) The Tor Project, Inc. // See LICENSE for licensing information // This is an asciidoc file used to generate the manpage/html reference. -// Learn asciidoc on http://www.methods.co.nz/asciidoc/userguide.html +// Learn asciidoc on https://www.methods.co.nz/asciidoc/userguide.html :man source: Tor :man manual: Tor Manual tor-print-ed-signing-cert(1) diff --git a/doc/tor-resolve.1.txt b/doc/tor-resolve.1.txt index f1f8f77a4..17a77e482 100644 --- a/doc/tor-resolve.1.txt +++ b/doc/tor-resolve.1.txt @@ -1,7 +1,7 @@ // Copyright (c) The Tor Project, Inc. // See LICENSE for licensing information // This is an asciidoc file used to generate the manpage/html reference. -// Learn asciidoc on http://www.methods.co.nz/asciidoc/userguide.html +// Learn asciidoc on https://www.methods.co.nz/asciidoc/userguide.html :man source: Tor :man manual: Tor Manual tor-resolve(1) diff --git a/doc/tor.1.txt b/doc/tor.1.txt index 9d073635a..f2a1aceb2 100644 --- a/doc/tor.1.txt +++ b/doc/tor.1.txt @@ -1,7 +1,7 @@ // Copyright (c) The Tor Project, Inc. // See LICENSE for licensing information // This is an asciidoc file used to generate the manpage/html reference. -// Learn asciidoc on http://www.methods.co.nz/asciidoc/userguide.html +// Learn asciidoc on https://www.methods.co.nz/asciidoc/userguide.html :man source: Tor :man manual: Tor Manual // compat-mode tells Asciidoctor tools to process this as legacy AsciiDoc diff --git a/doc/torify.1.txt b/doc/torify.1.txt index 7e49081cf..716625f92 100644 --- a/doc/torify.1.txt +++ b/doc/torify.1.txt @@ -1,7 +1,7 @@ // Copyright (c) The Tor Project, Inc. // See LICENSE for licensing information // This is an asciidoc file used to generate the manpage/html reference. -// Learn asciidoc on http://www.methods.co.nz/asciidoc/userguide.html +// Learn asciidoc on https://www.methods.co.nz/asciidoc/userguide.html :man source: Tor :man manual: Tor Manual torify(1) diff --git a/m4/ax_check_sign.m4 b/m4/ax_check_sign.m4 index d67e114db..b6285012f 100644 --- a/m4/ax_check_sign.m4 +++ b/m4/ax_check_sign.m4 @@ -1,5 +1,5 @@ # =========================================================================== -# http://www.gnu.org/software/autoconf-archive/ax_check_sign.html +# https://www.gnu.org/software/autoconf-archive/ax_check_sign.html # =========================================================================== # # SYNOPSIS diff --git a/m4/pkg.m4 b/m4/pkg.m4 index c5b26b52e..12e9835fb 100644 --- a/m4/pkg.m4 +++ b/m4/pkg.m4 @@ -148,7 +148,7 @@ path to pkg-config. _PKG_TEXT -To get pkg-config, see <http://pkg-config.freedesktop.org/>.])[]dnl +To get pkg-config, see <https://pkg-config.freedesktop.org/>.])[]dnl ]) else $1[]_CFLAGS=$pkg_cv_[]$1[]_CFLAGS diff --git a/src/app/config/config.c b/src/app/config/config.c index ba2cecd9a..930986483 100644 --- a/src/app/config/config.c +++ b/src/app/config/config.c @@ -3436,7 +3436,7 @@ options_validate_cb(const void *old_options_, void *options_, char **msg) "UseEntryGuards is disabled, but you have configured one or more " "hidden services on this Tor instance. Your hidden services " "will be very easy to locate using a well-known attack -- see " - "http://freehaven.net/anonbib/#hs-attack06 for details."); + "https://freehaven.net/anonbib/#hs-attack06 for details."); } if (options->NumPrimaryGuards && options->NumEntryGuards && diff --git a/src/app/main/ntmain.c b/src/app/main/ntmain.c index 494119975..5dc0edd59 100644 --- a/src/app/main/ntmain.c +++ b/src/app/main/ntmain.c @@ -603,7 +603,7 @@ nt_service_install(int argc, char **argv) /* Genericity is apparently _so_ last year in Redmond, where some * accounts are accounts that you can look up, and some accounts * are magic and undetectable via the security subsystem. See - * http://msdn2.microsoft.com/en-us/library/ms684188.aspx + * https://msdn2.microsoft.com/en-us/library/ms684188.aspx */ printf("Running on a Post-Win2K OS, so we'll assume that the " "LocalService account exists.\n"); diff --git a/src/config/mmdb-convert.py b/src/config/mmdb-convert.py index a58f5d43e..4acfea6c0 100644 --- a/src/config/mmdb-convert.py +++ b/src/config/mmdb-convert.py @@ -9,7 +9,7 @@ # # You should have received a copy of the CC0 legalcode along with this # work in doc/cc0.txt. If not, see -# <http://creativecommons.org/publicdomain/zero/1.0/>. +# <https://creativecommons.org/publicdomain/zero/1.0/>. # Nick Mathewson is responsible for this kludge, but takes no # responsibility for it. diff --git a/src/core/or/circuitstats.c b/src/core/or/circuitstats.c index 822e5bd30..5875627b9 100644 --- a/src/core/or/circuitstats.c +++ b/src/core/or/circuitstats.c @@ -972,7 +972,7 @@ circuit_build_times_update_state(const circuit_build_times_t *cbt, /** * Shuffle the build times array. * - * Adapted from http://en.wikipedia.org/wiki/Fisher-Yates_shuffle + * Adapted from https://en.wikipedia.org/wiki/Fisher-Yates_shuffle */ static void circuit_build_times_shuffle_and_store_array(circuit_build_times_t *cbt, @@ -1183,7 +1183,7 @@ circuit_build_times_parse_state(circuit_build_times_t *cbt, /** * Estimates the Xm and Alpha parameters using - * http://en.wikipedia.org/wiki/Pareto_distribution#Parameter_estimation + * https://en.wikipedia.org/wiki/Pareto_distribution#Parameter_estimation * * The notable difference is that we use mode instead of min to estimate Xm. * This is because our distribution is frechet-like. We claim this is @@ -1198,7 +1198,7 @@ circuit_build_times_update_alpha(circuit_build_times_t *cbt) int n=0,i=0,abandoned_count=0; build_time_t max_time=0; - /* http://en.wikipedia.org/wiki/Pareto_distribution#Parameter_estimation */ + /* https://en.wikipedia.org/wiki/Pareto_distribution#Parameter_estimation */ /* We sort of cheat here and make our samples slightly more pareto-like * and less frechet-like. */ cbt->Xm = circuit_build_times_get_xm(cbt); @@ -1270,9 +1270,9 @@ circuit_build_times_update_alpha(circuit_build_times_t *cbt) * We use it to calculate the timeout and also to generate synthetic * values of time for circuits that timeout before completion. * - * See http://en.wikipedia.org/wiki/Quantile_function, - * http://en.wikipedia.org/wiki/Inverse_transform_sampling and - * http://en.wikipedia.org/wiki/Pareto_distribution#Generating_a_ + * See https://en.wikipedia.org/wiki/Quantile_function, + * https://en.wikipedia.org/wiki/Inverse_transform_sampling and + * https://en.wikipedia.org/wiki/Pareto_distribution#Generating_a_ * random_sample_from_Pareto_distribution * That's right. I'll cite wikipedia all day long. * diff --git a/src/core/or/scheduler.c b/src/core/or/scheduler.c index ff58f9ca5..072d78128 100644 --- a/src/core/or/scheduler.c +++ b/src/core/or/scheduler.c @@ -42,7 +42,7 @@ * circuit scheduler. It was supposed to prioritize circuits across many * channels, but wasn't effective. It is preserved in scheduler_vanilla.c. * - * [0]: http://www.robgjansen.com/publications/kist-sec2014.pdf + * [0]: https://www.robgjansen.com/publications/kist-sec2014.pdf * * Then we actually got around to implementing KIST for real. We decided to * modularize the scheduler so new ones can be implemented. You can find KIST diff --git a/src/lib/evloop/timers.c b/src/lib/evloop/timers.c index 7be9bae08..11418e93f 100644 --- a/src/lib/evloop/timers.c +++ b/src/lib/evloop/timers.c @@ -11,7 +11,7 @@ * The main advantage of tor_timer_t over using libevent's timers is that * they're way more efficient if we need to have thousands or millions of * them. For more information, see - * http://www.25thandclement.com/~william/projects/timeout.c.html + * https://www.25thandclement.com/~william/projects/timeout.c.html * * Periodic timers are available in the backend, but I've turned them off. * We can turn them back on if needed. diff --git a/src/lib/math/laplace.c b/src/lib/math/laplace.c index 5c1d686a9..a0e67384e 100644 --- a/src/lib/math/laplace.c +++ b/src/lib/math/laplace.c @@ -29,7 +29,7 @@ sample_laplace_distribution(double mu, double b, double p) tor_assert(p >= 0.0 && p < 1.0); /* This is the "inverse cumulative distribution function" from: - * http://en.wikipedia.org/wiki/Laplace_distribution */ + * https://en.wikipedia.org/wiki/Laplace_distribution */ if (p <= 0.0) { /* Avoid taking log(0.0) == -INFINITY, as some processors or compiler * options can cause the program to trap. */ diff --git a/src/lib/process/restrict.c b/src/lib/process/restrict.c index a3ce52dea..cd2a1c57b 100644 --- a/src/lib/process/restrict.c +++ b/src/lib/process/restrict.c @@ -85,7 +85,7 @@ tor_set_max_memlock(void) { /* Future consideration for Windows is probably SetProcessWorkingSetSize * This is similar to setting the memory rlimit of RLIMIT_MEMLOCK - * http://msdn.microsoft.com/en-us/library/ms686234(VS.85).aspx + * https://msdn.microsoft.com/en-us/library/ms686234(VS.85).aspx */ struct rlimit limit; @@ -128,7 +128,7 @@ tor_mlockall(void) * Future consideration for Windows may be VirtualLock * VirtualLock appears to implement mlock() but not mlockall() * - * http://msdn.microsoft.com/en-us/library/aa366895(VS.85).aspx + * https://msdn.microsoft.com/en-us/library/aa366895(VS.85).aspx */ #ifdef HAVE_UNIX_MLOCKALL @@ -190,7 +190,7 @@ set_max_file_descriptors(rlim_t limit, int *max_out) /* Define some maximum connections values for systems where we cannot * automatically determine a limit. Re Cygwin, see - * http://archives.seul.org/or/talk/Aug-2006/msg00210.html + * https://archives.seul.org/or/talk/Aug-2006/msg00210.html * For an iPhone, 9999 should work. For Windows and all other unknown * systems we use 15000 as the default. */ #ifndef HAVE_GETRLIMIT diff --git a/src/test/slow_ed25519.py b/src/test/slow_ed25519.py index afad67800..be4eeab85 100644 --- a/src/test/slow_ed25519.py +++ b/src/test/slow_ed25519.py @@ -1,5 +1,5 @@ # This is the ed25519 implementation from -# http://ed25519.cr.yp.to/python/ed25519.py . +# https://ed25519.cr.yp.to/python/ed25519.py . # It is in the public domain. # # It isn't constant-time. Don't use it except for testing. Also, see diff --git a/src/test/test_crypto_slow.c b/src/test/test_crypto_slow.c index 56319f2c7..1702427b0 100644 --- a/src/test/test_crypto_slow.c +++ b/src/test/test_crypto_slow.c @@ -342,7 +342,7 @@ test_crypto_scrypt_vectors(void *arg) #endif /* Test vectors from - http://tools.ietf.org/html/draft-josefsson-scrypt-kdf-00 section 11. + https://tools.ietf.org/html/draft-josefsson-scrypt-kdf-00 section 11. Note that the names of 'r' and 'N' are switched in that section. Or possibly in libscrypt. diff --git a/src/test/test_options.c b/src/test/test_options.c index 9cd1d11d2..8e0d19f12 100644 --- a/src/test/test_options.c +++ b/src/test/test_options.c @@ -2362,7 +2362,7 @@ test_options_validate__rend(void *ignored) expect_log_msg("UseEntryGuards is disabled, but you" " have configured one or more hidden services on this Tor " "instance. Your hidden services will be very easy to locate using" - " a well-known attack -- see http://freehaven.net/anonbib/#hs-" + " a well-known attack -- see https://freehaven.net/anonbib/#hs-" "attack06 for details.\n"); tor_free(msg); @@ -2378,7 +2378,7 @@ test_options_validate__rend(void *ignored) expect_no_log_msg("UseEntryGuards is disabled, but you" " have configured one or more hidden services on this Tor " "instance. Your hidden services will be very easy to locate using" - " a well-known attack -- see http://freehaven.net/anonbib/#hs-" + " a well-known attack -- see https://freehaven.net/anonbib/#hs-" "attack06 for details.\n"); free_options_test_data(tdata); diff --git a/src/test/test_prob_distr.c b/src/test/test_prob_distr.c index c5423ce14..541a81df3 100644 --- a/src/test/test_prob_distr.c +++ b/src/test/test_prob_distr.c @@ -893,7 +893,7 @@ test_uniform_interval(void *arg) * * NIST/SEMATECH e-Handbook of Statistical Methods, Section * 1.3.6.7.4 `Critical Values of the Chi-Square Distribution', - * <http://www.itl.nist.gov/div898/handbook/eda/section3/eda3674.htm>, + * <https://www.itl.nist.gov/div898/handbook/eda/section3/eda3674.htm>, * retrieved 2018-10-28. */ diff --git a/src/test/test_util.c b/src/test/test_util.c index b2ee7cd35..7700cfa2b 100644 --- a/src/test/test_util.c +++ b/src/test/test_util.c @@ -5651,7 +5651,7 @@ test_util_hostname_validation(void *arg) tt_assert(string_is_valid_nonrfc_hostname("luck.y13.")); // We allow punycode TLDs. For examples, see - // http://data.iana.org/TLD/tlds-alpha-by-domain.txt + // https://data.iana.org/TLD/tlds-alpha-by-domain.txt tt_assert(string_is_valid_nonrfc_hostname("example.xn--l1acc")); done:

1 0

[tor/master] Changes file for ticket 31812.
by nickm＠torproject.org 13 Jul '20

13 Jul '20

1 0

[tor/master] Bug 31812: Change http URL's to https
by nickm＠torproject.org 13 Jul '20

13 Jul '20

1 0

[tor/master] Merge branch 'maint-0.4.4'
by nickm＠torproject.org 13 Jul '20

13 Jul '20

commit ecb43ce21caccbdfe99b0e12cdce7f83d59b06e3 Merge: 0c91c6359 eb427f309 Author: Nick Mathewson <nickm(a)torproject.org> Date: Mon Jul 13 10:45:04 2020 -0400 Merge branch 'maint-0.4.4' changes/ticket31812 | 4 ++++ contrib/clang/sanitize_blacklist.txt | 4 ++-- contrib/operator-tools/tor-exit-notice.html | 4 ++-- doc/HACKING/CodingStandards.md | 2 +- doc/HACKING/CodingStandardsRust.md | 4 ++-- doc/HACKING/Fuzzing.md | 4 ++-- doc/HACKING/GettingStarted.md | 2 +- doc/HACKING/GettingStartedRust.md | 2 +- doc/building-tor-msvc.txt | 8 ++++---- doc/contrib/tor-rpm-creation.txt | 2 +- doc/tor-gencert.1.txt | 2 +- doc/tor-print-ed-signing-cert.1.txt | 2 +- doc/tor-resolve.1.txt | 2 +- doc/tor.1.txt | 2 +- doc/torify.1.txt | 2 +- m4/ax_check_sign.m4 | 2 +- m4/pkg.m4 | 2 +- src/app/config/config.c | 2 +- src/app/main/ntmain.c | 2 +- src/config/mmdb-convert.py | 2 +- src/core/or/circuitstats.c | 12 ++++++------ src/core/or/scheduler.c | 2 +- src/lib/evloop/timers.c | 2 +- src/lib/math/laplace.c | 2 +- src/lib/process/restrict.c | 6 +++--- src/test/slow_ed25519.py | 2 +- src/test/test_crypto_slow.c | 2 +- src/test/test_options.c | 4 ++-- src/test/test_prob_distr.c | 2 +- src/test/test_util.c | 2 +- 30 files changed, 48 insertions(+), 44 deletions(-) diff --cc doc/HACKING/Fuzzing.md index d140844be,487716bb6..d9e133008 --- a/doc/HACKING/Fuzzing.md +++ b/doc/HACKING/Fuzzing.md @@@ -77,15 -72,13 +77,15 @@@ and then not actually use it Read afl/docs/notes_for_asan.txt for more details. - Download recidivm from http://jwilk.net/software/recidivm + Download recidivm from https://jwilk.net/software/recidivm Download the signature Check the signature - tar xvzf recidivm*.tar.gz - cd recidivm* - make - /path/to/recidivm -v src/test/fuzz/fuzz-http + ```console + $ tar xvzf recidivm*.tar.gz + $ cd recidivm* + $ make + $ /path/to/recidivm -v src/test/fuzz/fuzz-http + ``` Use the final "ok" figure as the input to -m when calling afl-fuzz (Normally, recidivm would output a figure automatically, but in some cases, the fuzzing harness will hang when the memory limit is too small.)

1 0

[tor/release-0.4.4] Changes file for ticket 31812.
by nickm＠torproject.org 13 Jul '20

13 Jul '20

1 0

[tor/release-0.4.4] Bug 31812: Change http URL's to https
by nickm＠torproject.org 13 Jul '20

13 Jul '20

1 0

[tor/release-0.4.4] Merge branch 'maint-0.4.4' into release-0.4.4
by nickm＠torproject.org 13 Jul '20

13 Jul '20

1 0

[tor/master] Merge branch 'ticket33919'
by nickm＠torproject.org 13 Jul '20

13 Jul '20

commit 0c91c63593720f07a20034bce2b0478dee216763 Merge: b119c5577 59133051f Author: Nick Mathewson <nickm(a)torproject.org> Date: Mon Jul 13 10:10:57 2020 -0400 Merge branch 'ticket33919' changes/ticket33919 | 3 +++ src/core/or/channel.c | 9 +------- src/core/or/channel.h | 5 ++++- src/test/test_channel.c | 56 +++++++++++++++++++++++++++++++++++++++++++++++++ 4 files changed, 64 insertions(+), 9 deletions(-)

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

tor-commits July 2020