July 2020 - tor-commits - lists.torproject.org

[snowflake-mobile/master] Moved creation of PeerConnection to offerRequestSuccess
by cohosh＠torproject.org 13 Jul '20

13 Jul '20

commit 492e7648eb72935b179f987d8b88269ac4ea084e Author: Hashik Donthineni <HashikDonthineni(a)gmail.com> Date: Thu Jul 9 22:44:46 2020 +0530 Moved creation of PeerConnection to offerRequestSuccess --- app/src/main/java/org/torproject/snowflake/MyPersistentService.java | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/app/src/main/java/org/torproject/snowflake/MyPersistentService.java b/app/src/main/java/org/torproject/snowflake/MyPersistentService.java index 6e5fe23..7654997 100644 --- a/app/src/main/java/org/torproject/snowflake/MyPersistentService.java +++ b/app/src/main/java/org/torproject/snowflake/MyPersistentService.java @@ -238,7 +238,6 @@ public class MyPersistentService extends Service { private void startWebRTCConnection() { Log.d(TAG, "startWebRTCConnection: Starting Connection."); initializePeerConnectionFactory(); //Android Specific, you can Ignore. - mainPeerConnection = createPeerConnection(factory); //Creating New Peer Connection. compositeDisposable.add( //First argument is initialDelay, Second argument is the time after which it has to repeat. Observable.interval(1, 5, TimeUnit.SECONDS) @@ -392,6 +391,8 @@ public class MyPersistentService extends Service { * @param sdpOfferResponse */ public void offerRequestSuccess(SDPOfferResponse sdpOfferResponse) { + //Creating New Peer Connection. + mainPeerConnection = createPeerConnection(factory); updateNotification("Fetching offer success. Creating Answer."); if (sdpOfferResponse.getStatus().equals(BrokerConstants.CLIENT_MATCH)) { updateNotification("Client match, generating answer...");

1 0

[snowflake-mobile/master] Used closeConnections function in onDestroy to clear connections
by cohosh＠torproject.org 13 Jul '20

13 Jul '20

commit 7cac3c5b732f9bc97dc345e8cec9d34a266e481a Author: Hashik Donthineni <HashikDonthineni(a)gmail.com> Date: Fri Jul 10 23:48:45 2020 +0530 Used closeConnections function in onDestroy to clear connections --- .../torproject/snowflake/MyPersistentService.java | 22 +++++++++------------- 1 file changed, 9 insertions(+), 13 deletions(-) diff --git a/app/src/main/java/org/torproject/snowflake/MyPersistentService.java b/app/src/main/java/org/torproject/snowflake/MyPersistentService.java index 7654997..8d7da11 100644 --- a/app/src/main/java/org/torproject/snowflake/MyPersistentService.java +++ b/app/src/main/java/org/torproject/snowflake/MyPersistentService.java @@ -114,17 +114,8 @@ public class MyPersistentService extends Service { @Override public void onDestroy() { sharedPreferencesHelper(ForegroundServiceConstants.SERVICE_STOPPED); - if (compositeDisposable != null) - compositeDisposable.dispose(); //Disposing all the threads. Including network calls. - if (mainDataChannel != null) { - mainDataChannel.close(); - } - if (mainPeerConnection != null) { - mainPeerConnection.close(); - mainPeerConnection.dispose(); - } - if (webSocket != null) - webSocket.close(1000, "Normal closure"); + //Close and dispose off all connections + closeConnections(false); mNotificationManager.cancel(ForegroundServiceConstants.DEF_NOTIFICATION_ID); Log.d(TAG, "onDestroy: Service Destroyed"); super.onDestroy(); @@ -484,15 +475,20 @@ public class MyPersistentService extends Service { private void closeConnections(boolean resend) { if (!resend) { //If you don't want to resend Log.d(TAG, "closeConnection: Closing connection"); - //Closing both to avoid memory leak. + //Closing all to avoid memory leak. if (mainDataChannel != null) mainDataChannel.close(); - if (mainPeerConnection != null) + + if (mainPeerConnection != null){ mainPeerConnection.close(); + mainPeerConnection.dispose(); + } + if (webSocket != null && isWebSocketOpen) { webSocket.close(1000, "Normal closure"); isWebSocketOpen = false; } + if (compositeDisposable != null) compositeDisposable.dispose(); //Disposing all the threads. Including network calls.

1 0

[torspec/master] Add new ipv6 stats fields to dirstats from prop313
by dgoulet＠torproject.org 13 Jul '20

13 Jul '20

commit 4b7d9b1b442c0f46b4ac430f0e79b499f5923ff0 Author: Nick Mathewson <nickm(a)torproject.org> Date: Mon Jul 13 11:11:39 2020 -0400 Add new ipv6 stats fields to dirstats from prop313 --- dir-spec.txt | 18 ++++++++++++++++++ 1 file changed, 18 insertions(+) diff --git a/dir-spec.txt b/dir-spec.txt index 1748e5a..0f31047 100644 --- a/dir-spec.txt +++ b/dir-spec.txt @@ -874,6 +874,16 @@ number of bytes used in the most recent intervals, ordered from oldest to newest. + These fields include both IPv4 and IPv6 traffic. + + "ipv6-read-history" YYYY-MM-DD HH:MM:SS (NSEC s) NUM,NUM,NUM... NL + [At most once] + "ipv6-write-history" YYYY-MM-DD HH:MM:SS (NSEC s) NUM,NUM,NUM... NL + [At most once] + + Declare how much bandwidth the OR has used recently, on IPv6 + connections. See "read-history" and "write-history" for full details. + "geoip-db-digest" Digest NL [At most once.] @@ -1156,6 +1166,14 @@ connection, read and write counters are reset for the next 10-second interval. + This measurement includes both IPv4 and IPv6 connections. + + "ipv6-conn-bi-direct" YYYY-MM-DD HH:MM:SS (NSEC s) BELOW,READ,WRITE,BOTH NL + [At most once] + + Number of IPv6 connections that are used uni-directionally or + bi-directionally. See "conn-bi-direct" for more details. + "exit-stats-end" YYYY-MM-DD HH:MM:SS (NSEC s) NL [At most once.]

1 0

[torspec/master] Move description of read-history and write-history to extrainfo
by dgoulet＠torproject.org 13 Jul '20

13 Jul '20

commit 8729838399814f1baec4e754cec48fc141660864 Author: Nick Mathewson <nickm(a)torproject.org> Date: Mon Jul 13 11:08:51 2020 -0400 Move description of read-history and write-history to extrainfo We moved the fields to extrainto back in 0.2.0.x, which is now long-obsolete -- it's time to move the description of the fields there, and remove the legacy migration note. --- dir-spec.txt | 32 +++++++------------------------- 1 file changed, 7 insertions(+), 25 deletions(-) diff --git a/dir-spec.txt b/dir-spec.txt index 626b9ce..1748e5a 100644 --- a/dir-spec.txt +++ b/dir-spec.txt @@ -703,16 +703,8 @@ "write-history" YYYY-MM-DD HH:MM:SS (NSEC s) NUM,NUM,NUM,NUM,NUM... NL [At most once] - Declare how much bandwidth the OR has used recently. Usage is divided - into intervals of NSEC seconds. The YYYY-MM-DD HH:MM:SS field - defines the end of the most recent interval. The numbers are the - number of bytes used in the most recent intervals, ordered from - oldest to newest. - - [We didn't start parsing these lines until Tor 0.1.0.6-rc; they should - be marked with "opt" until earlier versions of Tor are obsolete.] - - [See also migration notes in section 2.1.2.1.] + (These fields once appeared in router descriptors, but have + appeared in extrainfo descriptors since 0.2.0.x.) "eventdns" bool NL @@ -876,8 +868,11 @@ "write-history" YYYY-MM-DD HH:MM:SS (NSEC s) NUM,NUM,NUM,NUM,NUM... NL [At most once.] - As documented in section 2.1.1 above. See migration notes in - section 2.1.2.1. + Declare how much bandwidth the OR has used recently. Usage is divided + into intervals of NSEC seconds. The YYYY-MM-DD HH:MM:SS field + defines the end of the most recent interval. The numbers are the + number of bytes used in the most recent intervals, ordered from + oldest to newest. "geoip-db-digest" Digest NL [At most once.] @@ -1294,19 +1289,6 @@ initial item "extra-info" and the final item "router-signature", signed with the router's identity key. -2.1.2.1. Moving history fields to extra-info documents - - Tools that want to use the read-history and write-history values SHOULD - download extra-info documents as well as server descriptors. Such - tools SHOULD accept history values from both sources; if they appear in - both documents, the values in the extra-info documents are authoritative. - - New versions of Tor no longer generate server descriptors - containing read-history or write-history. Tools should continue to - accept read-history and write-history values in server descriptors - produced by older versions of Tor until all Tor versions earlier - than 0.2.0.x are obsolete. - 2.1.3. Nonterminals in server descriptors nickname ::= between 1 and 19 alphanumeric characters ([A-Za-z0-9]),

1 0

[tor/maint-0.4.3] Remove check-cocci from check-local target.
by dgoulet＠torproject.org 13 Jul '20

13 Jul '20

commit 0acc3ae87904ca5d9bd430a5a89f89dd97f9ec85 Author: Nick Mathewson <nickm(a)torproject.org> Date: Mon Jul 13 09:24:26 2020 -0400 Remove check-cocci from check-local target. check-cocci is still a good idea -- perhaps as a cron job? But doing it as part of our regular tests has just been confusing, especially to volunteers who shouldn't have to become coccinelle experts in order to get their patches through our CI. Closes #40030. --- Makefile.am | 3 +-- changes/ticket40030 | 7 +++++++ 2 files changed, 8 insertions(+), 2 deletions(-) diff --git a/Makefile.am b/Makefile.am index 8b55bf0e32..3b30c01f00 100644 --- a/Makefile.am +++ b/Makefile.am @@ -271,8 +271,7 @@ check-local: \ check-spaces \ check-changes \ check-includes \ - shellcheck \ - check-cocci + shellcheck need-chutney-path: @if test ! -d "$$CHUTNEY_PATH"; then \ diff --git a/changes/ticket40030 b/changes/ticket40030 new file mode 100644 index 0000000000..c5f3ca4ff9 --- /dev/null +++ b/changes/ticket40030 @@ -0,0 +1,7 @@ + o Removed features: + - Our "check-local" test target no longer tries to use the Coccinelle + semantic patching tool parse all the C files. While it is a good idea + to try to make sure Coccinelle works on our C before we run a + Coccinelle patch, doing so on every test run has proven to be disruptive. + You can still run this tool manually with "make check-cocci". Closes + ticket 40030.

1 0

[tor/maint-0.4.4] Remove check-cocci from check-local target.
by dgoulet＠torproject.org 13 Jul '20

13 Jul '20

commit 0acc3ae87904ca5d9bd430a5a89f89dd97f9ec85 Author: Nick Mathewson <nickm(a)torproject.org> Date: Mon Jul 13 09:24:26 2020 -0400 Remove check-cocci from check-local target. check-cocci is still a good idea -- perhaps as a cron job? But doing it as part of our regular tests has just been confusing, especially to volunteers who shouldn't have to become coccinelle experts in order to get their patches through our CI. Closes #40030. --- Makefile.am | 3 +-- changes/ticket40030 | 7 +++++++ 2 files changed, 8 insertions(+), 2 deletions(-) diff --git a/Makefile.am b/Makefile.am index 8b55bf0e32..3b30c01f00 100644 --- a/Makefile.am +++ b/Makefile.am @@ -271,8 +271,7 @@ check-local: \ check-spaces \ check-changes \ check-includes \ - shellcheck \ - check-cocci + shellcheck need-chutney-path: @if test ! -d "$$CHUTNEY_PATH"; then \ diff --git a/changes/ticket40030 b/changes/ticket40030 new file mode 100644 index 0000000000..c5f3ca4ff9 --- /dev/null +++ b/changes/ticket40030 @@ -0,0 +1,7 @@ + o Removed features: + - Our "check-local" test target no longer tries to use the Coccinelle + semantic patching tool parse all the C files. While it is a good idea + to try to make sure Coccinelle works on our C before we run a + Coccinelle patch, doing so on every test run has proven to be disruptive. + You can still run this tool manually with "make check-cocci". Closes + ticket 40030.

1 0

[tor/master] Merge branch 'maint-0.4.3' into maint-0.4.4
by dgoulet＠torproject.org 13 Jul '20

13 Jul '20

commit 515d4f1e93bcf9160c8b41d5a90b3144388f706f Merge: eb427f309c 0acc3ae879 Author: David Goulet <dgoulet(a)torproject.org> Date: Mon Jul 13 15:03:34 2020 -0400 Merge branch 'maint-0.4.3' into maint-0.4.4 Makefile.am | 3 +-- changes/ticket40030 | 7 +++++++ 2 files changed, 8 insertions(+), 2 deletions(-) diff --cc Makefile.am index 1a1fa9b658,3b30c01f00..8a26c6403b --- a/Makefile.am +++ b/Makefile.am @@@ -273,13 -271,8 +273,12 @@@ check-local: check-spaces \ check-changes \ check-includes \ + check-best-practices \ - shellcheck \ - check-cocci + shellcheck +# test-network requires a copy of Chutney in $CHUTNEY_PATH. +# Chutney can be cloned from https://git.torproject.org/chutney.git . +.PHONY: need-chutney-path need-chutney-path: @if test ! -d "$$CHUTNEY_PATH"; then \ echo '$$CHUTNEY_PATH was not set.'; \

1 0

[tor/maint-0.4.4] Merge branch 'maint-0.4.3' into maint-0.4.4
by dgoulet＠torproject.org 13 Jul '20

13 Jul '20

commit 515d4f1e93bcf9160c8b41d5a90b3144388f706f Merge: eb427f309c 0acc3ae879 Author: David Goulet <dgoulet(a)torproject.org> Date: Mon Jul 13 15:03:34 2020 -0400 Merge branch 'maint-0.4.3' into maint-0.4.4 Makefile.am | 3 +-- changes/ticket40030 | 7 +++++++ 2 files changed, 8 insertions(+), 2 deletions(-) diff --cc Makefile.am index 1a1fa9b658,3b30c01f00..8a26c6403b --- a/Makefile.am +++ b/Makefile.am @@@ -273,13 -271,8 +273,12 @@@ check-local: check-spaces \ check-changes \ check-includes \ + check-best-practices \ - shellcheck \ - check-cocci + shellcheck +# test-network requires a copy of Chutney in $CHUTNEY_PATH. +# Chutney can be cloned from https://git.torproject.org/chutney.git . +.PHONY: need-chutney-path need-chutney-path: @if test ! -d "$$CHUTNEY_PATH"; then \ echo '$$CHUTNEY_PATH was not set.'; \

1 0

[tor/master] Remove check-cocci from check-local target.
by dgoulet＠torproject.org 13 Jul '20

13 Jul '20

commit 0acc3ae87904ca5d9bd430a5a89f89dd97f9ec85 Author: Nick Mathewson <nickm(a)torproject.org> Date: Mon Jul 13 09:24:26 2020 -0400 Remove check-cocci from check-local target. check-cocci is still a good idea -- perhaps as a cron job? But doing it as part of our regular tests has just been confusing, especially to volunteers who shouldn't have to become coccinelle experts in order to get their patches through our CI. Closes #40030. --- Makefile.am | 3 +-- changes/ticket40030 | 7 +++++++ 2 files changed, 8 insertions(+), 2 deletions(-) diff --git a/Makefile.am b/Makefile.am index 8b55bf0e32..3b30c01f00 100644 --- a/Makefile.am +++ b/Makefile.am @@ -271,8 +271,7 @@ check-local: \ check-spaces \ check-changes \ check-includes \ - shellcheck \ - check-cocci + shellcheck need-chutney-path: @if test ! -d "$$CHUTNEY_PATH"; then \ diff --git a/changes/ticket40030 b/changes/ticket40030 new file mode 100644 index 0000000000..c5f3ca4ff9 --- /dev/null +++ b/changes/ticket40030 @@ -0,0 +1,7 @@ + o Removed features: + - Our "check-local" test target no longer tries to use the Coccinelle + semantic patching tool parse all the C files. While it is a good idea + to try to make sure Coccinelle works on our C before we run a + Coccinelle patch, doing so on every test run has proven to be disruptive. + You can still run this tool manually with "make check-cocci". Closes + ticket 40030.

1 0

[tor/release-0.4.3] Remove check-cocci from check-local target.
by dgoulet＠torproject.org 13 Jul '20

13 Jul '20

commit 0acc3ae87904ca5d9bd430a5a89f89dd97f9ec85 Author: Nick Mathewson <nickm(a)torproject.org> Date: Mon Jul 13 09:24:26 2020 -0400 Remove check-cocci from check-local target. check-cocci is still a good idea -- perhaps as a cron job? But doing it as part of our regular tests has just been confusing, especially to volunteers who shouldn't have to become coccinelle experts in order to get their patches through our CI. Closes #40030. --- Makefile.am | 3 +-- changes/ticket40030 | 7 +++++++ 2 files changed, 8 insertions(+), 2 deletions(-) diff --git a/Makefile.am b/Makefile.am index 8b55bf0e32..3b30c01f00 100644 --- a/Makefile.am +++ b/Makefile.am @@ -271,8 +271,7 @@ check-local: \ check-spaces \ check-changes \ check-includes \ - shellcheck \ - check-cocci + shellcheck need-chutney-path: @if test ! -d "$$CHUTNEY_PATH"; then \ diff --git a/changes/ticket40030 b/changes/ticket40030 new file mode 100644 index 0000000000..c5f3ca4ff9 --- /dev/null +++ b/changes/ticket40030 @@ -0,0 +1,7 @@ + o Removed features: + - Our "check-local" test target no longer tries to use the Coccinelle + semantic patching tool parse all the C files. While it is a good idea + to try to make sure Coccinelle works on our C before we run a + Coccinelle patch, doing so on every test run has proven to be disruptive. + You can still run this tool manually with "make check-cocci". Closes + ticket 40030.

1 0