March 2020 - tor-commits - lists.torproject.org

[tor/master] Disable parts of test_protover_all_supported() that cause fatal exceptions when ALL_BUGS_ARE_FATAL
by teor＠torproject.org 17 Mar '20

17 Mar '20

commit dcb75f00e1425bb7fa447fad79a8b7a429445614 Author: rl1987 <rl1987(a)sdf.lonestar.org> Date: Fri Mar 6 19:09:50 2020 +0200 Disable parts of test_protover_all_supported() that cause fatal exceptions when ALL_BUGS_ARE_FATAL --- src/test/test_protover.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/test/test_protover.c b/src/test/test_protover.c index 7d0891102..c33fbcae2 100644 --- a/src/test/test_protover.c +++ b/src/test/test_protover.c @@ -317,6 +317,7 @@ test_protover_all_supported(void *arg) tt_assert(protover_all_supported("Fribble=", &msg)); tt_ptr_op(msg, OP_EQ, NULL); +#ifndef ALL_BUGS_ARE_FATAL /* If we get a completely unparseable list, protover_all_supported should * hit a fatal assertion for BUG(entries == NULL). */ tor_capture_bugs_(1); @@ -328,9 +329,10 @@ test_protover_all_supported(void *arg) tor_capture_bugs_(1); tt_assert(protover_all_supported("Sleen=1-4294967295", &msg)); tor_end_capture_bugs_(); +#endif /* !defined(ALL_BUGS_ARE_FATAL) */ /* Protocol name too long */ -#ifndef HAVE_RUST // XXXXXX ????? +#if !defined(HAVE_RUST) && !defined(ALL_BUGS_ARE_FATAL) tor_capture_bugs_(1); tt_assert(protover_all_supported( "DoSaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa" @@ -338,7 +340,7 @@ test_protover_all_supported(void *arg) "aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa" "aaaaaaaaaaaa=1-65536", &msg)); tor_end_capture_bugs_(); -#endif /* !defined(HAVE_RUST) */ +#endif /* !defined(HAVE_RUST) && !defined(ALL_BUGS_ARE_FATAL) */ done: tor_end_capture_bugs_();

1 0

[tor/master] Use --enable-all-bugs-are-fatal on hardened Appveyor build
by teor＠torproject.org 17 Mar '20

17 Mar '20

commit 8680ff70827e5b08cdfde95ce03fcd635f1a49aa Author: rl1987 <rl1987(a)sdf.lonestar.org> Date: Sat Mar 14 16:15:19 2020 +0200 Use --enable-all-bugs-are-fatal on hardened Appveyor build --- .appveyor.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.appveyor.yml b/.appveyor.yml index 7e08602fe..a74c1861c 100644 --- a/.appveyor.yml +++ b/.appveyor.yml @@ -18,7 +18,7 @@ environment: - target: i686-w64-mingw32 compiler_path: mingw32 mingw_prefix: mingw-w64-i686 - hardening: + hardening: --enable-all-bugs-are-fatal - target: x86_64-w64-mingw32 compiler_path: mingw64 mingw_prefix: mingw-w64-x86_64 @@ -36,7 +36,7 @@ matrix: target: i686-w64-mingw32 compiler_path: mingw32 mingw_prefix: mingw-w64-i686 - hardening: + hardening: --enable-all-bugs-are-fatal - image: Visual Studio 2015 target: x86_64-w64-mingw32 compiler_path: mingw64

1 0

[tor/master] Add --enable-all-bugs-are-fatal option to configure
by teor＠torproject.org 17 Mar '20

17 Mar '20

commit 5591f424753c1f732e4c9d58b31070b878f18484 Author: rl1987 <rl1987(a)sdf.lonestar.org> Date: Fri Mar 13 20:24:54 2020 +0200 Add --enable-all-bugs-are-fatal option to configure This option enables the ALL_BUGS_ARE_FATAL macro. And use --enable-all-bugs-are-fatal in the Travis configuration. --- .travis.yml | 15 +++++++-------- configure.ac | 7 +++++++ 2 files changed, 14 insertions(+), 8 deletions(-) diff --git a/.travis.yml b/.travis.yml index 49745278b..77dd78f27 100644 --- a/.travis.yml +++ b/.travis.yml @@ -93,9 +93,9 @@ matrix: # compiler: clang # os: osx - - env: ALL_BUGS_ARE_FATAL="yes" - - env: ALL_BUGS_ARE_FATAL="yes" SKIP_MAKE_CHECK="yes" CHUTNEY="yes" - - env: ALL_BUGS_ARE_FATAL="yes" SKIP_MAKE_CHECK="yes" TEST_STEM="yes" + - env: HARDENING_OPTIONS="--enable-assert-fatalism" + - env: HARDENING_OPTIONS="--enable-assert-fatalism" SKIP_MAKE_CHECK="yes" CHUTNEY="yes" + - env: HARDENING_OPTIONS="--enable-assert-fatalism" SKIP_MAKE_CHECK="yes" TEST_STEM="yes" ## Allow the build to report success (with non-required sub-builds ## continuing to run) if all required sub-builds have succeeded. @@ -118,9 +118,9 @@ matrix: ## chutney tests #- env: CHUTNEY_MAKE="test-network-ipv6" CHUTNEY="yes" CHUTNEY_ALLOW_FAILURES="2" SKIP_MAKE_CHECK="yes" # os: osx - - env: ALL_BUGS_ARE_FATAL="yes" - - env: ALL_BUGS_ARE_FATAL="yes" SKIP_MAKE_CHECK="yes" CHUTNEY="yes" - - env: ALL_BUGS_ARE_FATAL="yes" SKIP_MAKE_CHECK="yes" TEST_STEM="yes" + - env: HARDENING_OPTIONS="--enable-assert-fatalism" + - env: HARDENING_OPTIONS="--enable-assert-fatalism" SKIP_MAKE_CHECK="yes" CHUTNEY="yes" + - env: HARDENING_OPTIONS="--enable-assert-fatalism" SKIP_MAKE_CHECK="yes" TEST_STEM="yes" ## (Linux only) Use a recent Linux image (Ubuntu Bionic) dist: bionic @@ -248,8 +248,7 @@ script: - ./autogen.sh - CONFIGURE_FLAGS="$ASCIIDOC_OPTIONS $COVERAGE_OPTIONS $HARDENING_OPTIONS $MODULES_OPTIONS $NSS_OPTIONS $OPENSSL_OPTIONS $RUST_OPTIONS --enable-fatal-warnings --disable-silent-rules" - echo "Configure flags are $CONFIGURE_FLAGS CC=\"$CC $C_DIALECT_OPTIONS\"" - - if [[ "$ALL_BUGS_ARE_FATAL" == "" ]]; then ./configure $CONFIGURE_FLAGS CC="$CC $C_DIALECT_OPTIONS"; fi - - if [[ "$ALL_BUGS_ARE_FATAL" != "" ]]; then ./configure CFLAGS="-DALL_BUGS_ARE_FATAL" $CONFIGURE_FLAGS CC="$CC $C_DIALECT_OPTIONS"; fi + - ./configure $CONFIGURE_FLAGS CC="$CC $C_DIALECT_OPTIONS"; ## We run `make check` because that's what https://jenkins.torproject.org does. - if [[ "$SKIP_MAKE_CHECK" == "" ]]; then make check; fi - if [[ "$DISTCHECK" != "" ]]; then make distcheck DISTCHECK_CONFIGURE_FLAGS="$CONFIGURE_FLAGS"; fi diff --git a/configure.ac b/configure.ac index aa511a391..9d3bef999 100644 --- a/configure.ac +++ b/configure.ac @@ -228,6 +228,13 @@ if test "x$enable_expensive_hardening" = "xyes" || test "x$enable_fragile_harden AC_DEFINE(DEBUG_SMARTLIST, 1, [Enable smartlist debugging]) fi +AC_ARG_ENABLE(all-bugs-are-fatal, + AS_HELP_STRING(--enable-all-bugs-are-fatal, [force all soft asserts in Tor codebase (tor_assert_nonfatal(), BUG(), etc.) to act as hard asserts (tor_assert() and equivalents); makes Tor fragile; only recommended for dev builds])) + +if test "x$enable_all_bugs_are_fatal" = "xyes"; then + AC_DEFINE(ALL_BUGS_ARE_FATAL, 1, [All assert failures are fatal]) +fi + dnl Linker hardening options dnl Currently these options are ELF specific - you can't use this with MacOSX AC_ARG_ENABLE(linker-hardening,

1 0

[tor/master] Documentation fixups
by teor＠torproject.org 17 Mar '20

17 Mar '20

commit b0cb3f54583d1aa5b5adb25636c079d5cfccbf19 Author: rl1987 <rl1987(a)sdf.lonestar.org> Date: Sat Mar 14 16:25:59 2020 +0200 Documentation fixups --- .travis.yml | 2 +- changes/ticket32143 | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/.travis.yml b/.travis.yml index fe6ce973f..01343e65d 100644 --- a/.travis.yml +++ b/.travis.yml @@ -52,7 +52,7 @@ matrix: - compiler: clang os: osx ## Turn off some newer features, turn on clang's -Wtypedef-redefinition - ## Also, disable ALL_BUGS_FATAL macro. + ## Also, disable ALL_BUGS_ARE_FATAL macro. env: C_DIALECT_OPTIONS="-std=gnu99" HARDENING_OPTIONS="--enable-expensive-hardening" ## We run chutney on Linux, because it's faster than chutney on macOS diff --git a/changes/ticket32143 b/changes/ticket32143 index 6100e4bf8..7f8a809ba 100644 --- a/changes/ticket32143 +++ b/changes/ticket32143 @@ -1,4 +1,4 @@ o Minor features (continuous integration): - Run unit-test and integration test (Stem, Chutney) jobs with - ALL_BUGS_ARE_FATAL macro being enabled on Travis. Allow failures for - time being. Closes ticket 32143. + ALL_BUGS_ARE_FATAL macro being enabled on Travis and Appveyor. + Resolves ticket 32143.

1 0

[tor/master] Fix allow_failures section
by teor＠torproject.org 17 Mar '20

17 Mar '20

commit 437da7fb3a1a8834a2cc939119f71da15d5bea64 Author: rl1987 <rl1987(a)sdf.lonestar.org> Date: Fri Mar 6 19:45:03 2020 +0200 Fix allow_failures section --- .travis.yml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/.travis.yml b/.travis.yml index 13d4d9d10..49745278b 100644 --- a/.travis.yml +++ b/.travis.yml @@ -119,6 +119,8 @@ matrix: #- env: CHUTNEY_MAKE="test-network-ipv6" CHUTNEY="yes" CHUTNEY_ALLOW_FAILURES="2" SKIP_MAKE_CHECK="yes" # os: osx - env: ALL_BUGS_ARE_FATAL="yes" + - env: ALL_BUGS_ARE_FATAL="yes" SKIP_MAKE_CHECK="yes" CHUTNEY="yes" + - env: ALL_BUGS_ARE_FATAL="yes" SKIP_MAKE_CHECK="yes" TEST_STEM="yes" ## (Linux only) Use a recent Linux image (Ubuntu Bionic) dist: bionic

1 0

[tor/master] Don't create new CI jobs; use --enable-all-bugs-are-fatal with some of the existing jobs
by teor＠torproject.org 17 Mar '20

17 Mar '20

commit 39f77a5b1f5ed687e9ca4d8900b0f41e4334dcb6 Author: rl1987 <rl1987(a)sdf.lonestar.org> Date: Sat Mar 14 16:11:00 2020 +0200 Don't create new CI jobs; use --enable-all-bugs-are-fatal with some of the existing jobs --- .travis.yml | 18 ++++++------------ 1 file changed, 6 insertions(+), 12 deletions(-) diff --git a/.travis.yml b/.travis.yml index 77dd78f27..fe6ce973f 100644 --- a/.travis.yml +++ b/.travis.yml @@ -26,7 +26,7 @@ env: - MAKEFLAGS="-k -j 2" ## We turn on hardening by default ## Also known as --enable-fragile-hardening in 0.3.0.3-alpha and later - - HARDENING_OPTIONS="--enable-expensive-hardening" + - HARDENING_OPTIONS="--enable-all-bugs-are-fatal --enable-expensive-hardening" ## We turn off asciidoc by default, because it's slow - ASCIIDOC_OPTIONS="--disable-asciidoc" ## Our default rust version is the minimum supported version @@ -52,7 +52,8 @@ matrix: - compiler: clang os: osx ## Turn off some newer features, turn on clang's -Wtypedef-redefinition - env: C_DIALECT_OPTIONS="-std=gnu99" + ## Also, disable ALL_BUGS_FATAL macro. + env: C_DIALECT_OPTIONS="-std=gnu99" HARDENING_OPTIONS="--enable-expensive-hardening" ## We run chutney on Linux, because it's faster than chutney on macOS ## Chutney is a fast job, clang is slower on Linux, so we do Chutney clang @@ -63,9 +64,9 @@ matrix: - env: DISTCHECK="yes" ASCIIDOC_OPTIONS="" SKIP_MAKE_CHECK="yes" ## We check disable module relay - - env: MODULES_OPTIONS="--disable-module-relay" + - env: MODULES_OPTIONS="--disable-module-relay" HARDENING_OPTIONS="--enable-expensive-hardening" ## We check disable module dirauth - - env: MODULES_OPTIONS="--disable-module-dirauth" + - env: MODULES_OPTIONS="--disable-module-dirauth" HARDENING_OPTIONS="--enable-expensive-hardening" ## We run rust on Linux, because it's faster than rust on macOS ## We check rust offline @@ -74,7 +75,7 @@ matrix: ## We check NSS ## Use -std=gnu99 to turn off some newer features, and maybe turn on some ## extra gcc warnings? - - env: NSS_OPTIONS="--enable-nss" C_DIALECT_OPTIONS="-std=gnu99" + - env: NSS_OPTIONS="--enable-nss" C_DIALECT_OPTIONS="-std=gnu99" HARDENING_OPTIONS="--enable-expensive-hardening" ## We include a single coverage build with the best options for coverage - env: COVERAGE_OPTIONS="--enable-coverage" HARDENING_OPTIONS="" TOR_TEST_RNG_SEED="636f766572616765" @@ -93,10 +94,6 @@ matrix: # compiler: clang # os: osx - - env: HARDENING_OPTIONS="--enable-assert-fatalism" - - env: HARDENING_OPTIONS="--enable-assert-fatalism" SKIP_MAKE_CHECK="yes" CHUTNEY="yes" - - env: HARDENING_OPTIONS="--enable-assert-fatalism" SKIP_MAKE_CHECK="yes" TEST_STEM="yes" - ## Allow the build to report success (with non-required sub-builds ## continuing to run) if all required sub-builds have succeeded. fast_finish: true @@ -118,9 +115,6 @@ matrix: ## chutney tests #- env: CHUTNEY_MAKE="test-network-ipv6" CHUTNEY="yes" CHUTNEY_ALLOW_FAILURES="2" SKIP_MAKE_CHECK="yes" # os: osx - - env: HARDENING_OPTIONS="--enable-assert-fatalism" - - env: HARDENING_OPTIONS="--enable-assert-fatalism" SKIP_MAKE_CHECK="yes" CHUTNEY="yes" - - env: HARDENING_OPTIONS="--enable-assert-fatalism" SKIP_MAKE_CHECK="yes" TEST_STEM="yes" ## (Linux only) Use a recent Linux image (Ubuntu Bionic) dist: bionic

1 0

[translation/https_everywhere] https://gitweb.torproject.org/translation.git/commit/?h=https_everywhere
by translation＠torproject.org 17 Mar '20

17 Mar '20

commit 6946c405bca707351e61ea45a1551c2b750f5f08 Author: Translation commit bot <translation(a)torproject.org> Date: Tue Mar 17 10:46:02 2020 +0000 https://gitweb.torproject.org/translation.git/commit/?h=https_everywhere --- es/https-everywhere.dtd | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/es/https-everywhere.dtd b/es/https-everywhere.dtd index 5947dfcd4a..3ad8a39700 100644 --- a/es/https-everywhere.dtd +++ b/es/https-everywhere.dtd @@ -50,7 +50,7 @@ <!ENTITY https-everywhere.cancel.http_once "Abrir una página insegura sólo por esta sesión"> <!ENTITY https-everywhere.onboarding.intro "¡Cifre la Web! Utilice automáticamente la seguridad HTTPS en muchos sitios."> -<!ENTITY https-everywhere.onboarding.header "HTTPS Everywhere has been updated!"> +<!ENTITY https-everywhere.onboarding.header "¡HTTPS Everywhere ha sido actualizado!"> <!ENTITY https-everywhere.onboarding.details_one "Modo EASE optimizado"> <!ENTITY https-everywhere.onboarding.details_two "Ahora puedes incluir en la lista blanca sitios para deshabilitar en HTTPS Everywhere"> <!ENTITY https-everywhere.onboarding.footer "HTTPS Everywhere es un proyecto de EFF">

1 0

[translation/https_everywhere] https://gitweb.torproject.org/translation.git/commit/?h=https_everywhere
by translation＠torproject.org 17 Mar '20

17 Mar '20

commit 8deb558dfb3295c86721c01999e062b8352df71b Author: Translation commit bot <translation(a)torproject.org> Date: Tue Mar 17 09:16:06 2020 +0000 https://gitweb.torproject.org/translation.git/commit/?h=https_everywhere --- nl/https-everywhere.dtd | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/nl/https-everywhere.dtd b/nl/https-everywhere.dtd index 0b20bf18a1..3ad782d472 100644 --- a/nl/https-everywhere.dtd +++ b/nl/https-everywhere.dtd @@ -50,7 +50,7 @@ <!ENTITY https-everywhere.cancel.http_once "Niet-beveiligde pagina alleen voor deze sessie openen"> <!ENTITY https-everywhere.onboarding.intro "Versleutel het web! Gebruik automatisch HTTPS-beveiliging op veel websites."> -<!ENTITY https-everywhere.onboarding.header "HTTPS Everywhere has been updated!"> +<!ENTITY https-everywhere.onboarding.header "HTTPS Everywhere is bijgewerkt!"> <!ENTITY https-everywhere.onboarding.details_one "EASE-modus geoptimaliseerd"> <!ENTITY https-everywhere.onboarding.details_two "U kunt nu websites whitelisten voor uitschakeling in HTTPS Everywhere"> <!ENTITY https-everywhere.onboarding.footer "HTTPS Everywhere is een EFF-project">

1 0

[tor/master] Run "make autostyle"
by teor＠torproject.org 17 Mar '20

17 Mar '20

commit 9c73f5adc4e766b6c5875deeb365f4e40a6caebc Author: teor <teor(a)torproject.org> Date: Tue Mar 17 18:19:04 2020 +1000 Run "make autostyle" --- src/lib/osinfo/uname.c | 2 +- src/test/test_util.c | 2 +- src/test/test_util_process.c | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/lib/osinfo/uname.c b/src/lib/osinfo/uname.c index 800acdddb..f7f5ede30 100644 --- a/src/lib/osinfo/uname.c +++ b/src/lib/osinfo/uname.c @@ -59,7 +59,7 @@ static struct { { 0, 0, NULL, NULL } // clang-format on }; -#endif +#endif /* defined(_WIN32) */ /** Return a pointer to a description of our platform. */ diff --git a/src/test/test_util.c b/src/test/test_util.c index fecd27909..a9cc54d8f 100644 --- a/src/test/test_util.c +++ b/src/test/test_util.c @@ -6369,7 +6369,7 @@ test_util_map_anon_nofork(void *arg) #else #define UTIL_TEST_PWDB(n, f) UTIL_TEST(n, (f)) #endif -#endif +#endif /* !defined(COCCI) */ struct testcase_t util_tests[] = { UTIL_LEGACY(time), diff --git a/src/test/test_util_process.c b/src/test/test_util_process.c index f0e7334a9..fc79fe9b1 100644 --- a/src/test/test_util_process.c +++ b/src/test/test_util_process.c @@ -73,7 +73,7 @@ test_util_process_clear_waitpid_callback(void *ignored) #else #define TEST(name) { (#name), NULL, TT_SKIP, NULL, NULL } #endif -#endif +#endif /* !defined(COCCI) */ struct testcase_t util_process_tests[] = { TEST(set_waitpid_callback),

1 0

[translation/https_everywhere] https://gitweb.torproject.org/translation.git/commit/?h=https_everywhere
by translation＠torproject.org 17 Mar '20

17 Mar '20

commit 1676ec3f10c32d94216782cdc7c153603cc4a18d Author: Translation commit bot <translation(a)torproject.org> Date: Tue Mar 17 07:16:00 2020 +0000 https://gitweb.torproject.org/translation.git/commit/?h=https_everywhere --- sq/https-everywhere.dtd | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/sq/https-everywhere.dtd b/sq/https-everywhere.dtd index f533edd00e..fa0d77cbaa 100644 --- a/sq/https-everywhere.dtd +++ b/sq/https-everywhere.dtd @@ -50,7 +50,7 @@ <!ENTITY https-everywhere.cancel.http_once "Hap faqen e pasigurt vetëm për këtë sesion"> <!ENTITY https-everywhere.onboarding.intro "Fshehtëzoni Web-in! Përdorni automatikisht siguri HTTPS në mjaft sajte."> -<!ENTITY https-everywhere.onboarding.header "HTTPS Everywhere has been updated!"> +<!ENTITY https-everywhere.onboarding.header "HTTPS Everywhere është përditësuar!"> <!ENTITY https-everywhere.onboarding.details_one "U optimizua Mënyra EASE"> <!ENTITY https-everywhere.onboarding.details_two "Tanimë mundeni të vendosni sajte në listë lejimesh për të çaktivizuar HTTPS Everywhere"> <!ENTITY https-everywhere.onboarding.footer "HTTPS Everywhere është një projekt i EFF-së">

1 0