March 2020 - tor-commits - lists.torproject.org

[translation/https_everywhere] https://gitweb.torproject.org/translation.git/commit/?h=https_everywhere
by translation＠torproject.org 17 Mar '20

17 Mar '20

commit bddba46a85c96904ae8fb941351b2dbf9b64dd96 Author: Translation commit bot <translation(a)torproject.org> Date: Tue Mar 17 12:16:07 2020 +0000 https://gitweb.torproject.org/translation.git/commit/?h=https_everywhere --- et/https-everywhere.dtd | 4 ++-- ka/https-everywhere.dtd | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/et/https-everywhere.dtd b/et/https-everywhere.dtd index 014f754bfd..e3634e9a81 100644 --- a/et/https-everywhere.dtd +++ b/et/https-everywhere.dtd @@ -52,8 +52,8 @@ <!ENTITY https-everywhere.onboarding.intro "Krüpteeri veeb! Kasuta HTTPS turvalaiendust automaatselt paljudel lehtedel."> <!ENTITY https-everywhere.onboarding.header "HTTPS Kõikjal on uuendatud!"> <!ENTITY https-everywhere.onboarding.details_one "EASE-režiim optimeeritud"> -<!ENTITY https-everywhere.onboarding.details_two "You can now whitelist sites to disable in HTTPS Everywhere"> -<!ENTITY https-everywhere.onboarding.footer "HTTPS Everywhere is an EFF project"> +<!ENTITY https-everywhere.onboarding.details_two "Sa saad nüüd lisada saite valgesse nimekirja, et keelata neil HTTPS Kõikjal"> +<!ENTITY https-everywhere.onboarding.footer "HTTPS Kõikjal on EFF'i projekt"> <!ENTITY https-everywhere.chrome.settings_for_this_site_header "Selle lehe seaded"> <!ENTITY https-everywhere.chrome.settings_for_this_site_subheader "Muuda oma krüpteeritud ühenduste eelistusi"> diff --git a/ka/https-everywhere.dtd b/ka/https-everywhere.dtd index 6c741337c1..e4c91f8c9e 100644 --- a/ka/https-everywhere.dtd +++ b/ka/https-everywhere.dtd @@ -50,7 +50,7 @@ <!ENTITY https-everywhere.cancel.http_once "დაუცველი გვერდის გახსნა მხოლოდ ამ სეანსზე"> <!ENTITY https-everywhere.onboarding.intro "დაშიფრეთ ინტერნეტკავშირი! გამოიყენეთ დაცული HTTPS საიტების უმეტეს ნაწილზე."> -<!ENTITY https-everywhere.onboarding.header "HTTPS Everywhere has been updated!"> +<!ENTITY https-everywhere.onboarding.header "HTTPS Everywhere განახლებულია!"> <!ENTITY https-everywhere.onboarding.details_one "გაუმჯობესდა EASE-რეჟიმი (თვითდაშიფვრა)"> <!ENTITY https-everywhere.onboarding.details_two "ახლა უკვე შეგიძლიათ მიუთითოთ გამონაკლისები, რომელზეც გაითიშება HTTPS Everywhere"> <!ENTITY https-everywhere.onboarding.footer "HTTPS Everywhere არის EFF-პროექტი">

1 0

[translation/https_everywhere] https://gitweb.torproject.org/translation.git/commit/?h=https_everywhere
by translation＠torproject.org 17 Mar '20

17 Mar '20

commit 5b285dfb4f8cb4422cb3a3b356202fd69b85963d Author: Translation commit bot <translation(a)torproject.org> Date: Tue Mar 17 11:45:59 2020 +0000 https://gitweb.torproject.org/translation.git/commit/?h=https_everywhere --- et/https-everywhere.dtd | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/et/https-everywhere.dtd b/et/https-everywhere.dtd index be76e88839..014f754bfd 100644 --- a/et/https-everywhere.dtd +++ b/et/https-everywhere.dtd @@ -29,8 +29,8 @@ <!ENTITY https-everywhere.options.userRulesListed "HTTPS Kõikjal kasutaja reeglid"> <!ENTITY https-everywhere.options.disabledUrlsListed "HTTPS Kõikjal blokeeritud veebilehed"> <!ENTITY https-everywhere.options.updateChannelsWarning "Hoiatus: Uuenduskanalite lisamine võib võimaldada ründajatel Teie brauserit kaaperdada. Muuda seda jaotist vaid siis, kui teate, mida teete!"> -<!ENTITY https-everywhere.options.addDisabledSite "Add Disabled Site"> -<!ENTITY https-everywhere.options.enterDisabledSite "Enter disabled site"> +<!ENTITY https-everywhere.options.addDisabledSite "Lisa keelatud sait"> +<!ENTITY https-everywhere.options.enterDisabledSite "Sisene keelatud saiti"> <!ENTITY https-everywhere.options.addUpdateChannel "Lisa uuenduskanal"> <!ENTITY https-everywhere.options.enterUpdateChannelName "Sisesta uuenduskanali nimi"> <!ENTITY https-everywhere.options.delete "Kustuta"> @@ -47,11 +47,11 @@ <!ENTITY https-everywhere.cancel.he_blocking_explainer "HTTPS Kõikjal avastas sind navigeerimast HTTPSita lehele ning proovis sind saata selle HTTPSiga versioonile. HTTPS-versioon pole saadaval. Tõenäoliselt see sait ei toeta HTTPSi, aga on ka võimalus et ründaja blokeerib HTTPSi versiooni. Kui soovid vaadata selle lehe krüpteerimata versiooni, saad seda siiski teha, keelates valiku "Krüpteeri kõik sobivad saidid (EASE)" oma HTTPS Kõikjal laienduses. Pane tähele, et selle valiku keelamine võib muuta sinu brauseri võrgupõhistele madaldusrünnetele haavatavaks."> <!ENTITY https-everywhere.cancel.he_blocking_network "võrgupõhised madaldusründed"> <!ENTITY https-everywhere.cancel.open_page "Ava ebaturvaline leht"> -<!ENTITY https-everywhere.cancel.http_once "Open insecure page for this session only"> +<!ENTITY https-everywhere.cancel.http_once "Ava ebaturvaline leht ainult selle sessiooni ajal"> <!ENTITY https-everywhere.onboarding.intro "Krüpteeri veeb! Kasuta HTTPS turvalaiendust automaatselt paljudel lehtedel."> -<!ENTITY https-everywhere.onboarding.header "HTTPS Everywhere has been updated!"> -<!ENTITY https-everywhere.onboarding.details_one "EASE Mode Optimized"> +<!ENTITY https-everywhere.onboarding.header "HTTPS Kõikjal on uuendatud!"> +<!ENTITY https-everywhere.onboarding.details_one "EASE-režiim optimeeritud"> <!ENTITY https-everywhere.onboarding.details_two "You can now whitelist sites to disable in HTTPS Everywhere"> <!ENTITY https-everywhere.onboarding.footer "HTTPS Everywhere is an EFF project">

1 0

[tor/master] Conditionally disable part of hs_intropoint/introduce1_validation
by teor＠torproject.org 17 Mar '20

17 Mar '20

commit 5675cbd4c756283419fb0ed3b2d524b2b3cb101b Author: rl1987 <rl1987(a)sdf.lonestar.org> Date: Sat Mar 14 19:00:54 2020 +0200 Conditionally disable part of hs_intropoint/introduce1_validation This makes it not fail when ALL_BUGS_ARE_FATAL is enabled. Fixes bug 33546. --- src/test/test_hs_intropoint.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/test/test_hs_intropoint.c b/src/test/test_hs_intropoint.c index 533718842..3b6e3fd21 100644 --- a/src/test/test_hs_intropoint.c +++ b/src/test/test_hs_intropoint.c @@ -757,12 +757,15 @@ test_introduce1_validation(void *arg) cell = helper_create_introduce1_cell(); tt_assert(cell); +#ifndef ALL_BUGS_ARE_FATAL /* It should NOT be a legacy cell which will trigger a BUG(). */ memset(cell->legacy_key_id, 'a', sizeof(cell->legacy_key_id)); tor_capture_bugs_(1); ret = validate_introduce1_parsed_cell(cell); tor_end_capture_bugs_(); tt_int_op(ret, OP_EQ, -1); +#endif + /* Reset legacy ID and make sure it's correct. */ memset(cell->legacy_key_id, 0, sizeof(cell->legacy_key_id)); ret = validate_introduce1_parsed_cell(cell);

1 0

[tor/master] Try fixing Windows build to work with ALL_BUGS_ARE_FATAL
by teor＠torproject.org 17 Mar '20

17 Mar '20

commit 752122b2e9647b82fbb7f6eac120d57b913761f9 Author: rl1987 <rl1987(a)sdf.lonestar.org> Date: Sat Mar 14 16:43:08 2020 +0200 Try fixing Windows build to work with ALL_BUGS_ARE_FATAL --- src/feature/dircache/conscache.c | 15 +++++++++++++++ 1 file changed, 15 insertions(+) diff --git a/src/feature/dircache/conscache.c b/src/feature/dircache/conscache.c index ceba410a5..d9aaccddc 100644 --- a/src/feature/dircache/conscache.c +++ b/src/feature/dircache/conscache.c @@ -132,6 +132,15 @@ consensus_cache_may_overallocate(consensus_cache_t *cache) #endif } +// HACK: GCC on Appveyor hates that we may assert before returning. Work around +// the error. +#ifdef _WIN32 +#ifndef COCCI +#pragma GCC diagnostic push +#pragma GCC diagnostic ignored "-Wsuggest-attribute=noreturn" +#endif +#endif + /** * Tell the sandbox (if any) configured by cfg to allow the * operations that cache will need. @@ -156,6 +165,12 @@ consensus_cache_register_with_sandbox(consensus_cache_t *cache, return storage_dir_register_with_sandbox(cache->dir, cfg); } +#ifdef _WIN32 +#ifndef COCCI +#pragma GCC diagnostic pop +#endif +#endif + /** * Helper: clear all entries from cache (but do not delete * any that aren't marked for removal

1 0

[tor/master] Merge branch 'pr1777_squashed'
by teor＠torproject.org 17 Mar '20

17 Mar '20

commit 0fa1d8ef92a2911fcf660bc57637d525988d63b6 Merge: 9c73f5adc 5675cbd4c Author: teor <teor(a)torproject.org> Date: Tue Mar 17 21:08:45 2020 +1000 Merge branch 'pr1777_squashed' .appveyor.yml | 4 ++-- .travis.yml | 13 +++++++------ changes/ticket32143 | 4 ++++ configure.ac | 7 +++++++ src/feature/dircache/conscache.c | 15 +++++++++++++++ src/test/test_circuitbuild.c | 4 ++++ src/test/test_dir.c | 6 ++++++ src/test/test_hs_intropoint.c | 3 +++ src/test/test_protover.c | 6 ++++-- 9 files changed, 52 insertions(+), 10 deletions(-)

1 0

[tor/master] Conditionally disable part of dir/param_voting_lookup that expects soft asserts to happen
by teor＠torproject.org 17 Mar '20

17 Mar '20

commit 4ab20b4f63daa021df7575d6251eaca61301850b Author: rl1987 <rl1987(a)sdf.lonestar.org> Date: Sat Mar 14 18:51:01 2020 +0200 Conditionally disable part of dir/param_voting_lookup that expects soft asserts to happen --- src/test/test_dir.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/test/test_dir.c b/src/test/test_dir.c index b09c1acfe..e6f87dbd3 100644 --- a/src/test/test_dir.c +++ b/src/test/test_dir.c @@ -3005,6 +3005,7 @@ test_dir_param_voting_lookup(void *arg) tt_int_op(99, OP_EQ, dirvote_get_intermediate_param_value(lst, "abcd", 1000)); +#ifndef ALL_BUGS_ARE_FATAL /* moomin appears twice. That's a bug. */ tor_capture_bugs_(1); tt_int_op(-100, OP_EQ, @@ -3040,6 +3041,7 @@ test_dir_param_voting_lookup(void *arg) tt_str_op(smartlist_get(tor_get_captured_bug_log_(), 0), OP_EQ, "!(!ok)"); tor_end_capture_bugs_(); +#endif done: SMARTLIST_FOREACH(lst, char *, cp, tor_free(cp));

1 0

[tor/master] Add changes file
by teor＠torproject.org 17 Mar '20

17 Mar '20

commit 159009ae476d8832eb7ec548efe012e804b0a202 Author: rl1987 <rl1987(a)sdf.lonestar.org> Date: Fri Mar 6 18:32:49 2020 +0200 Add changes file --- changes/ticket32143 | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/changes/ticket32143 b/changes/ticket32143 new file mode 100644 index 000000000..6100e4bf8 --- /dev/null +++ b/changes/ticket32143 @@ -0,0 +1,4 @@ + o Minor features (continuous integration): + - Run unit-test and integration test (Stem, Chutney) jobs with + ALL_BUGS_ARE_FATAL macro being enabled on Travis. Allow failures for + time being. Closes ticket 32143.

1 0

[tor/master] Also skip dir/purpose_needs_anonymity_returns_true_by_default when ALL_BUGS_ARE_FATAL
by teor＠torproject.org 17 Mar '20

17 Mar '20

commit 0732513f160a9e599424ddfdcef9f753524f6330 Author: rl1987 <rl1987(a)sdf.lonestar.org> Date: Fri Mar 6 18:51:23 2020 +0200 Also skip dir/purpose_needs_anonymity_returns_true_by_default when ALL_BUGS_ARE_FATAL --- src/test/test_dir.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/src/test/test_dir.c b/src/test/test_dir.c index b66938d7c..b09c1acfe 100644 --- a/src/test/test_dir.c +++ b/src/test/test_dir.c @@ -4989,6 +4989,10 @@ test_dir_purpose_needs_anonymity_returns_true_by_default(void *arg) { (void)arg; +#ifdef ALL_BUGS_ARE_FATAL + tt_skip(); +#endif + tor_capture_bugs_(1); setup_full_capture_of_logs(LOG_WARN); tt_int_op(1, OP_EQ, purpose_needs_anonymity(0, 0, NULL));

1 0

[tor/master] Skip test_new_route_len_unhandled_exit() when ALL_BUGS_ARE_FATAL
by teor＠torproject.org 17 Mar '20

17 Mar '20

commit 3db65bc21893bf1d3e1edf5610419f9ec4304c33 Author: rl1987 <rl1987(a)sdf.lonestar.org> Date: Fri Mar 6 17:55:21 2020 +0200 Skip test_new_route_len_unhandled_exit() when ALL_BUGS_ARE_FATAL --- src/test/test_circuitbuild.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/src/test/test_circuitbuild.c b/src/test/test_circuitbuild.c index 70920c0c5..8b506011b 100644 --- a/src/test/test_circuitbuild.c +++ b/src/test/test_circuitbuild.c @@ -114,6 +114,10 @@ test_new_route_len_unhandled_exit(void *arg) int r; (void)arg; +#ifdef ALL_BUGS_ARE_FATAL + tt_skip(); +#endif + MOCK(count_acceptable_nodes, mock_count_acceptable_nodes); tor_capture_bugs_(1);

1 0

[tor/master] Try running some CI jobs with ALL_BUGS_ARE_FATAL
by teor＠torproject.org 17 Mar '20

17 Mar '20

commit 33f2de45e70aea9fab7974e17231f14f72774bcd Author: rl1987 <rl1987(a)sdf.lonestar.org> Date: Fri Mar 6 18:14:41 2020 +0200 Try running some CI jobs with ALL_BUGS_ARE_FATAL Build Tor with ALL_BUGS_ARE_FATAL macro and run: * make check * make test-stem * make test-network These jobs are allowed to fail at this point. --- .travis.yml | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/.travis.yml b/.travis.yml index 16d2e432d..13d4d9d10 100644 --- a/.travis.yml +++ b/.travis.yml @@ -93,6 +93,10 @@ matrix: # compiler: clang # os: osx + - env: ALL_BUGS_ARE_FATAL="yes" + - env: ALL_BUGS_ARE_FATAL="yes" SKIP_MAKE_CHECK="yes" CHUTNEY="yes" + - env: ALL_BUGS_ARE_FATAL="yes" SKIP_MAKE_CHECK="yes" TEST_STEM="yes" + ## Allow the build to report success (with non-required sub-builds ## continuing to run) if all required sub-builds have succeeded. fast_finish: true @@ -114,6 +118,7 @@ matrix: ## chutney tests #- env: CHUTNEY_MAKE="test-network-ipv6" CHUTNEY="yes" CHUTNEY_ALLOW_FAILURES="2" SKIP_MAKE_CHECK="yes" # os: osx + - env: ALL_BUGS_ARE_FATAL="yes" ## (Linux only) Use a recent Linux image (Ubuntu Bionic) dist: bionic @@ -241,7 +246,8 @@ script: - ./autogen.sh - CONFIGURE_FLAGS="$ASCIIDOC_OPTIONS $COVERAGE_OPTIONS $HARDENING_OPTIONS $MODULES_OPTIONS $NSS_OPTIONS $OPENSSL_OPTIONS $RUST_OPTIONS --enable-fatal-warnings --disable-silent-rules" - echo "Configure flags are $CONFIGURE_FLAGS CC=\"$CC $C_DIALECT_OPTIONS\"" - - ./configure $CONFIGURE_FLAGS CC="$CC $C_DIALECT_OPTIONS" + - if [[ "$ALL_BUGS_ARE_FATAL" == "" ]]; then ./configure $CONFIGURE_FLAGS CC="$CC $C_DIALECT_OPTIONS"; fi + - if [[ "$ALL_BUGS_ARE_FATAL" != "" ]]; then ./configure CFLAGS="-DALL_BUGS_ARE_FATAL" $CONFIGURE_FLAGS CC="$CC $C_DIALECT_OPTIONS"; fi ## We run `make check` because that's what https://jenkins.torproject.org does. - if [[ "$SKIP_MAKE_CHECK" == "" ]]; then make check; fi - if [[ "$DISTCHECK" != "" ]]; then make distcheck DISTCHECK_CONFIGURE_FLAGS="$CONFIGURE_FLAGS"; fi

1 0