March 2020 - tor-commits - lists.torproject.org

[tor/maint-0.4.3] Split a wide line.
by nickm＠torproject.org 18 Mar '20

18 Mar '20

commit bc4c89eb2f47ba0774a05aea3798fbec31f9b920 Author: Nick Mathewson <nickm(a)torproject.org> Date: Tue Mar 17 11:53:01 2020 -0400 Split a wide line. --- src/test/test_hs_control.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/test/test_hs_control.c b/src/test/test_hs_control.c index 566cc21fe..9277711d2 100644 --- a/src/test/test_hs_control.c +++ b/src/test/test_hs_control.c @@ -661,8 +661,10 @@ test_hs_control_add_onion_with_bad_pubkey(void *arg) conn.current_cmd = tor_strdup("ADD_ONION"); } - args = tor_strdup("ED25519-V3:AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA" - "AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA Port=9735,127.0.0.1 Flags=DiscardPK"); + args = tor_strdup("ED25519-V3:AAAAAAAAAAAAAAAAAAAAAAAAAAAAA" + "AAAAAAAAAAAAAAAAAAAAAAA" + "AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA " + "Port=9735,127.0.0.1 Flags=DiscardPK"); retval = handle_control_command(&conn, (uint32_t) strlen(args), args); tt_int_op(retval, OP_EQ, 0);

1 0

[tor/master] Trivial bugfixes found during TROVE investigation.
by nickm＠torproject.org 18 Mar '20

18 Mar '20

commit c940b7cf13d8ceb5705d52c215256e1de5a4e757 Author: George Kadianakis <desnacked(a)riseup.net> Date: Mon Feb 10 16:35:40 2020 +0200 Trivial bugfixes found during TROVE investigation. --- src/feature/hs/hs_client.c | 6 +++--- src/lib/crypt_ops/crypto_ed25519.c | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/feature/hs/hs_client.c b/src/feature/hs/hs_client.c index fd2d26645..0efe9fc28 100644 --- a/src/feature/hs/hs_client.c +++ b/src/feature/hs/hs_client.c @@ -1275,7 +1275,7 @@ hs_client_decode_descriptor(const char *desc_str, uint8_t subcredential[DIGEST256_LEN]; ed25519_public_key_t blinded_pubkey; hs_client_service_authorization_t *client_auth = NULL; - curve25519_secret_key_t *client_auht_sk = NULL; + curve25519_secret_key_t *client_auth_sk = NULL; tor_assert(desc_str); tor_assert(service_identity_pk); @@ -1284,7 +1284,7 @@ hs_client_decode_descriptor(const char *desc_str, /* Check if we have a client authorization for this service in the map. */ client_auth = find_client_auth(service_identity_pk); if (client_auth) { - client_auht_sk = &client_auth->enc_seckey; + client_auth_sk = &client_auth->enc_seckey; } /* Create subcredential for this HS so that we can decrypt */ @@ -1297,7 +1297,7 @@ hs_client_decode_descriptor(const char *desc_str, /* Parse descriptor */ ret = hs_desc_decode_descriptor(desc_str, subcredential, - client_auht_sk, desc); + client_auth_sk, desc); memwipe(subcredential, 0, sizeof(subcredential)); if (ret < 0) { goto err; diff --git a/src/lib/crypt_ops/crypto_ed25519.c b/src/lib/crypt_ops/crypto_ed25519.c index 400f96389..0a442bb73 100644 --- a/src/lib/crypt_ops/crypto_ed25519.c +++ b/src/lib/crypt_ops/crypto_ed25519.c @@ -795,7 +795,7 @@ ed25519_point_is_identity_element(const uint8_t *point) int ed25519_validate_pubkey(const ed25519_public_key_t *pubkey) { - uint8_t result[32] = {9}; + uint8_t result[32] = {0}; /* First check that we were not given the identity element */ if (ed25519_point_is_identity_element(pubkey->pubkey)) {

1 0

[tor/master] Merge branch 'maint-0.3.5' into maint-0.4.1
by nickm＠torproject.org 18 Mar '20

18 Mar '20

commit 5f4e14b8c8cd4c8907f669144a5a4bb8b8b7a585 Merge: c22696e36 089e57d22 Author: Nick Mathewson <nickm(a)torproject.org> Date: Tue Mar 17 11:45:16 2020 -0400 Merge branch 'maint-0.3.5' into maint-0.4.1 changes/trove_2020_003 | 4 ++++ src/feature/hs/hs_client.c | 6 +++--- src/feature/hs/hs_service.c | 6 ++++++ src/lib/crypt_ops/crypto_ed25519.c | 2 +- 4 files changed, 14 insertions(+), 4 deletions(-)

1 0

[tor/master] Merge branch 'maint-0.4.1' into maint-0.4.2
by nickm＠torproject.org 18 Mar '20

18 Mar '20

commit e15a621ac81c472f69a082180fa9b4ed39274e43 Merge: 9ef8f5d1b 5f4e14b8c Author: Nick Mathewson <nickm(a)torproject.org> Date: Tue Mar 17 11:45:16 2020 -0400 Merge branch 'maint-0.4.1' into maint-0.4.2 changes/trove_2020_003 | 4 ++++ src/feature/hs/hs_client.c | 6 +++--- src/feature/hs/hs_service.c | 6 ++++++ src/lib/crypt_ops/crypto_ed25519.c | 2 +- 4 files changed, 14 insertions(+), 4 deletions(-)

1 0

[tor/master] Merge branch 'maint-0.4.2' into maint-0.4.3
by nickm＠torproject.org 18 Mar '20

18 Mar '20

commit bbc80ea042a124a5935bd4264677180efdcb2da2 Merge: 855cd533e e15a621ac Author: Nick Mathewson <nickm(a)torproject.org> Date: Tue Mar 17 11:45:16 2020 -0400 Merge branch 'maint-0.4.2' into maint-0.4.3 changes/trove_2020_003 | 4 ++++ src/feature/hs/hs_client.c | 6 +++--- src/feature/hs/hs_service.c | 6 ++++++ src/lib/crypt_ops/crypto_ed25519.c | 2 +- 4 files changed, 14 insertions(+), 4 deletions(-) diff --cc src/feature/hs/hs_client.c index 222261e60,9d67f7127..af8cb0b41 --- a/src/feature/hs/hs_client.c +++ b/src/feature/hs/hs_client.c @@@ -1870,9 -1296,9 +1870,9 @@@ hs_client_decode_descriptor(const char /* Parse descriptor */ ret = hs_desc_decode_descriptor(desc_str, subcredential, - client_auht_sk, desc); + client_auth_sk, desc); memwipe(subcredential, 0, sizeof(subcredential)); - if (ret < 0) { + if (ret != HS_DESC_DECODE_OK) { goto err; }

1 0

[translation/https_everywhere] https://gitweb.torproject.org/translation.git/commit/?h=https_everywhere
by translation＠torproject.org 18 Mar '20

18 Mar '20

commit 3bf1a4cc0894aed81deed65b9554335ae8011dcf Author: Translation commit bot <translation(a)torproject.org> Date: Tue Mar 17 15:46:02 2020 +0000 https://gitweb.torproject.org/translation.git/commit/?h=https_everywhere --- fr/https-everywhere.dtd | 8 ++++---- lt/https-everywhere.dtd | 2 +- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/fr/https-everywhere.dtd b/fr/https-everywhere.dtd index e8ffea43fb..ac9c906b9d 100644 --- a/fr/https-everywhere.dtd +++ b/fr/https-everywhere.dtd @@ -29,8 +29,8 @@ <!ENTITY https-everywhere.options.userRulesListed "Règles utilisateur de HTTPS partout"> <!ENTITY https-everywhere.options.disabledUrlsListed "Sites désactivés dans HTTPS partout"> <!ENTITY https-everywhere.options.updateChannelsWarning "Avertissement : L’ajout de canaux de mise à jour peut permettre à des assaillants de pirater votre navigateur. Ne modifiez cette section que si vous savez ce que vous faites !"> -<!ENTITY https-everywhere.options.addDisabledSite "Ajouter un site désactivé"> -<!ENTITY https-everywhere.options.enterDisabledSite "Saisir un site désactivé"> +<!ENTITY https-everywhere.options.addDisabledSite "Ajouter un site à désactiver"> +<!ENTITY https-everywhere.options.enterDisabledSite "Saisir un site à Désactiver"> <!ENTITY https-everywhere.options.addUpdateChannel "Ajouter un canal de mise à jour"> <!ENTITY https-everywhere.options.enterUpdateChannelName "Saisir le nom du canal de mise à jour"> <!ENTITY https-everywhere.options.delete "Supprimer"> @@ -44,14 +44,14 @@ <!ENTITY https-everywhere.prefs.reset_defaults "Réinitialiser aux paramètres par défaut"> <!ENTITY https-everywhere.prefs.reset_defaults_message "Chaque ensemble de règles sera réinitialisé à son état par défaut. Poursuivre ?"> -<!ENTITY https-everywhere.cancel.he_blocking_explainer "HTTPS partout a remarqué que vous naviguiez vers une page non HTTPS et a tenté de plutôt vous envoyer vers la version HTTPS. La version HTTPS n’est pas proposée. Ce site ne prend probablement pas HTTPS en charge, mais il est aussi possible qu’un assaillant bloque la version HTTPS. Si vous souhaitez visualiser la version non chiffrée de cette page, vous pouvez quand même le faire en désactivant l’option « Chiffrer tous les sites admissibles (EASE) » dans votre extension HTTPS partout. Sachez que la désactivation de cette option peut rendre votre navigateur vulnérable aux attaques réseau par déclassement contre les sites Web que vous visitez."> +<!ENTITY https-everywhere.cancel.he_blocking_explainer "HTTPS partout a remarqué que vous naviguiez vers une page non HTTPS et a tenté de plutôt vous envoyer vers la version HTTPS. La version HTTPS n’est pas proposée. Ce site ne prend probablement pas HTTPS en charge, mais il est aussi possible qu’un assaillant bloque la version HTTPS. Si vous souhaitez visualiser la version non chiffrée de cette page, vous pouvez quand même le faire en désactivant l’option « Chiffrer tous les sites admissibles (CTDA) » dans votre extension HTTPS partout. Sachez que la désactivation de cette option peut rendre votre navigateur vulnérable aux attaques réseau par déclassement contre les sites Web que vous visitez."> <!ENTITY https-everywhere.cancel.he_blocking_network "attaques de rétrograde réseau"> <!ENTITY https-everywhere.cancel.open_page "Ouvrir la page non sécurisée"> <!ENTITY https-everywhere.cancel.http_once "N’ouvrir la page non sécurisée que pour cette session"> <!ENTITY https-everywhere.onboarding.intro "Chiffrez la Toile ! Utilisez automatiquement la sécurité HTTPS avec de nombreux sites."> <!ENTITY https-everywhere.onboarding.header "HTTPS Everywhere has been updated!"> -<!ENTITY https-everywhere.onboarding.details_one "Optimisation du mode EASE"> +<!ENTITY https-everywhere.onboarding.details_one "Optimisation du mode CTDA"> <!ENTITY https-everywhere.onboarding.details_two "Vous pouvez désormais mettre en liste blanche les sites à désactiver dans HTTPS partout"> <!ENTITY https-everywhere.onboarding.footer "HTTPS partout est un projet de la FFÉ"> diff --git a/lt/https-everywhere.dtd b/lt/https-everywhere.dtd index 23eefc53ea..c5c09b3213 100644 --- a/lt/https-everywhere.dtd +++ b/lt/https-everywhere.dtd @@ -50,7 +50,7 @@ <!ENTITY https-everywhere.cancel.http_once "Atverti nesaugų puslapį tik šiam seansui"> <!ENTITY https-everywhere.onboarding.intro "Šifruokite saityną! Automatiškai naudokite HTTPS saugumą daugelyje svetainių."> -<!ENTITY https-everywhere.onboarding.header "HTTPS Everywhere has been updated!"> +<!ENTITY https-everywhere.onboarding.header "HTTPS Everywhere atnaujinta!"> <!ENTITY https-everywhere.onboarding.details_one "Optimizuota EASE veiksena"> <!ENTITY https-everywhere.onboarding.details_two "Dabar, galite įtraukti internetines svetaines į baltąjį sąrašą, kad jos būtų išjungtos HTTPS Everywhere"> <!ENTITY https-everywhere.onboarding.footer "HTTPS Everywhere yra EFF projektas">

1 0

[tor-browser-build/master] Fold in stable changelog for 9.0.6
by sysrqb＠torproject.org 18 Mar '20

18 Mar '20

commit 26c782f39f5eed7bb69fc98b015a58a5d0301391 Author: Matthew Finkel <sysrqb(a)torproject.org> Date: Tue Mar 17 15:02:20 2020 +0000 Fold in stable changelog for 9.0.6 --- projects/tor-browser/Bundle-Data/Docs/ChangeLog.txt | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/projects/tor-browser/Bundle-Data/Docs/ChangeLog.txt b/projects/tor-browser/Bundle-Data/Docs/ChangeLog.txt index eadcd2a..9a6bd34 100644 --- a/projects/tor-browser/Bundle-Data/Docs/ChangeLog.txt +++ b/projects/tor-browser/Bundle-Data/Docs/ChangeLog.txt @@ -11,6 +11,15 @@ Tor Browser 9.5a8 -- March 13 2020 * Windows * Bug 33535: Patch openssl to use SOURCE_DATE_EPOCH for copyright year +Tor Browser 9.0.6 -- March 11 2020 + * All Platforms + * Update Firefox to 68.6.0esr + * Bump NoScript to 11.0.15 + * Bug 33430: Disable downloadable fonts on Safest security level + * Build System + * Windows + * Bug 33535: Patch openssl to use SOURCE_DATE_EPOCH for copyright year + Tor Browser 9.5a7 -- March 6 2020 * All Platforms * Translations update

1 0

[tor/master] dos: Pass transport name on new client connection
by teor＠torproject.org 18 Mar '20

18 Mar '20

commit 894ff2dc8422cb86312c512698acd76476224f87 Author: David Goulet <dgoulet(a)torproject.org> Date: Tue Mar 10 14:45:13 2020 -0400 dos: Pass transport name on new client connection For a bridge configured with a pluggable transport, the transport name is used, with the IP address, for the GeoIP client cache entry. However, the DoS subsystem was not aware of it and always passing NULL when doing a lookup into the GeoIP cache. This resulted in bridges with a PT are never able to apply DoS defenses for newly created connections. Fixes #33491 Signed-off-by: David Goulet <dgoulet(a)torproject.org> --- changes/ticket33491 | 6 ++++++ src/core/or/channel.c | 2 +- src/core/or/dos.c | 4 ++-- src/core/or/dos.h | 3 ++- src/test/test_dos.c | 24 ++++++++++++------------ 5 files changed, 23 insertions(+), 16 deletions(-) diff --git a/changes/ticket33491 b/changes/ticket33491 new file mode 100644 index 000000000..595ea863e --- /dev/null +++ b/changes/ticket33491 @@ -0,0 +1,6 @@ + o Major bugfixes (DoS defenses, bridges, pluggable transport): + - DoS subsystem was not given the transport name of the client connection + when tor is a bridge and thus failing to find the GeoIP cache entry for + that client address. This resulted in failing to apply DoS defenses on + bridges with a pluggable transport. Fixes bug 33491; bugfix on + 0.3.3.2-alpha. diff --git a/src/core/or/channel.c b/src/core/or/channel.c index fd7bf6278..388690687 100644 --- a/src/core/or/channel.c +++ b/src/core/or/channel.c @@ -1871,7 +1871,7 @@ channel_do_open_actions(channel_t *chan) tor_free(transport_name); /* Notify the DoS subsystem of a new client. */ if (tlschan && tlschan->conn) { - dos_new_client_conn(tlschan->conn); + dos_new_client_conn(tlschan->conn, transport_name); } } /* Otherwise the underlying transport can't tell us this, so skip it */ diff --git a/src/core/or/dos.c b/src/core/or/dos.c index 5f9bbf90a..d06eaa6d0 100644 --- a/src/core/or/dos.c +++ b/src/core/or/dos.c @@ -671,7 +671,7 @@ dos_log_heartbeat(void) /* Called when a new client connection has been established on the given * address. */ void -dos_new_client_conn(or_connection_t *or_conn) +dos_new_client_conn(or_connection_t *or_conn, const char *transport_name) { clientmap_entry_t *entry; @@ -692,7 +692,7 @@ dos_new_client_conn(or_connection_t *or_conn) } /* We are only interested in client connection from the geoip cache. */ - entry = geoip_lookup_client(&or_conn->real_addr, NULL, + entry = geoip_lookup_client(&or_conn->real_addr, transport_name, GEOIP_CLIENT_CONNECT); if (BUG(entry == NULL)) { /* Should never happen because we note down the address in the geoip diff --git a/src/core/or/dos.h b/src/core/or/dos.h index 95448d053..058b7afce 100644 --- a/src/core/or/dos.h +++ b/src/core/or/dos.h @@ -53,7 +53,8 @@ int dos_enabled(void); void dos_log_heartbeat(void); void dos_geoip_entry_about_to_free(const struct clientmap_entry_t *geoip_ent); -void dos_new_client_conn(or_connection_t *or_conn); +void dos_new_client_conn(or_connection_t *or_conn, + const char *transport_name); void dos_close_client_conn(const or_connection_t *or_conn); int dos_should_refuse_single_hop_client(void); diff --git a/src/test/test_dos.c b/src/test/test_dos.c index 4756c5014..01d7cd006 100644 --- a/src/test/test_dos.c +++ b/src/test/test_dos.c @@ -79,7 +79,7 @@ test_dos_conn_creation(void *arg) { /* Register many conns from this client but not enough to get it blocked */ unsigned int i; for (i = 0; i < max_concurrent_conns; i++) { - dos_new_client_conn(&or_conn); + dos_new_client_conn(&or_conn, NULL); } } @@ -88,7 +88,7 @@ test_dos_conn_creation(void *arg) dos_conn_addr_get_defense_type(addr)); /* Register another conn and check that new conns are not allowed anymore */ - dos_new_client_conn(&or_conn); + dos_new_client_conn(&or_conn, NULL); tt_int_op(DOS_CONN_DEFENSE_CLOSE, OP_EQ, dos_conn_addr_get_defense_type(addr)); @@ -98,7 +98,7 @@ test_dos_conn_creation(void *arg) dos_conn_addr_get_defense_type(addr)); /* Register another conn and see that defense measures get reactivated */ - dos_new_client_conn(&or_conn); + dos_new_client_conn(&or_conn, NULL); tt_int_op(DOS_CONN_DEFENSE_CLOSE, OP_EQ, dos_conn_addr_get_defense_type(addr)); @@ -153,7 +153,7 @@ test_dos_circuit_creation(void *arg) * circuit counting subsystem */ geoip_note_client_seen(GEOIP_CLIENT_CONNECT, addr, NULL, now); for (i = 0; i < min_conc_conns_for_cc ; i++) { - dos_new_client_conn(&or_conn); + dos_new_client_conn(&or_conn, NULL); } /* Register new circuits for this client and conn, but not enough to get @@ -217,7 +217,7 @@ test_dos_bucket_refill(void *arg) /* Register this client */ geoip_note_client_seen(GEOIP_CLIENT_CONNECT, addr, NULL, now); - dos_new_client_conn(&or_conn); + dos_new_client_conn(&or_conn, NULL); /* Fetch this client from the geoip cache and get its DoS structs */ clientmap_entry_t *entry = geoip_lookup_client(addr, NULL, @@ -460,11 +460,11 @@ test_known_relay(void *arg) geoip_note_client_seen(GEOIP_CLIENT_CONNECT, &or_conn.real_addr, NULL, 0); /* Suppose we have 5 connections in rapid succession, the counter should * always be 0 because we should ignore this. */ - dos_new_client_conn(&or_conn); - dos_new_client_conn(&or_conn); - dos_new_client_conn(&or_conn); - dos_new_client_conn(&or_conn); - dos_new_client_conn(&or_conn); + dos_new_client_conn(&or_conn, NULL); + dos_new_client_conn(&or_conn, NULL); + dos_new_client_conn(&or_conn, NULL); + dos_new_client_conn(&or_conn, NULL); + dos_new_client_conn(&or_conn, NULL); entry = geoip_lookup_client(&or_conn.real_addr, NULL, GEOIP_CLIENT_CONNECT); tt_assert(entry); /* We should have a count of 0. */ @@ -474,8 +474,8 @@ test_known_relay(void *arg) * connection and see if we do get it. */ tor_addr_parse(&or_conn.real_addr, "42.42.42.43"); geoip_note_client_seen(GEOIP_CLIENT_CONNECT, &or_conn.real_addr, NULL, 0); - dos_new_client_conn(&or_conn); - dos_new_client_conn(&or_conn); + dos_new_client_conn(&or_conn, NULL); + dos_new_client_conn(&or_conn, NULL); entry = geoip_lookup_client(&or_conn.real_addr, NULL, GEOIP_CLIENT_CONNECT); tt_assert(entry); /* We should have a count of 2. */

1 0

[tor/master] Merge remote-tracking branch 'tor-github/pr/1784'
by teor＠torproject.org 18 Mar '20

18 Mar '20

commit 44f92e8e4278403b9e633668f8be70f197b6e8db Merge: c86d08e3e 894ff2dc8 Author: teor <teor(a)torproject.org> Date: Tue Mar 17 23:11:31 2020 +1000 Merge remote-tracking branch 'tor-github/pr/1784' changes/ticket33491 | 6 ++++++ src/core/or/channel.c | 2 +- src/core/or/dos.c | 4 ++-- src/core/or/dos.h | 3 ++- src/test/test_dos.c | 24 ++++++++++++------------ 5 files changed, 23 insertions(+), 16 deletions(-)

1 0

[tor/master] Run "practracker.py --regen-overbroad"
by teor＠torproject.org 18 Mar '20

18 Mar '20

commit c86d08e3e6a4210fb10ab0d00ba22bb9e9d1ffde Author: teor <teor(a)torproject.org> Date: Tue Mar 17 23:02:16 2020 +1000 Run "practracker.py --regen-overbroad" We've successfully resolved a bunch of technical debt over the last few months. Let's remove the allowances for that debt from the practracker exceptions. --- scripts/maint/practracker/exceptions.txt | 16 ++++++---------- 1 file changed, 6 insertions(+), 10 deletions(-) diff --git a/scripts/maint/practracker/exceptions.txt b/scripts/maint/practracker/exceptions.txt index 53c6faff2..a3644893d 100644 --- a/scripts/maint/practracker/exceptions.txt +++ b/scripts/maint/practracker/exceptions.txt @@ -47,7 +47,7 @@ problem function-size /src/app/config/config.c:parse_dir_authority_line() 150 problem function-size /src/app/config/config.c:parse_dir_fallback_line() 101 problem function-size /src/app/config/config.c:port_parse_config() 450 problem function-size /src/app/config/config.c:parse_ports() 132 -problem file-size /src/app/config/or_options_st.h 1053 +problem file-size /src/app/config/or_options_st.h 1050 problem include-count /src/app/main/main.c 68 problem function-size /src/app/main/main.c:dumpstats() 102 problem function-size /src/app/main/main.c:tor_init() 101 @@ -74,7 +74,7 @@ problem function-size /src/core/mainloop/connection.c:assert_connection_ok() 143 problem dependency-violation /src/core/mainloop/connection.c 47 problem dependency-violation /src/core/mainloop/cpuworker.c 12 problem include-count /src/core/mainloop/mainloop.c 64 -problem function-size /src/core/mainloop/mainloop.c:conn_close_if_marked() 108 +problem function-size /src/core/mainloop/mainloop.c:conn_close_if_marked() 107 problem function-size /src/core/mainloop/mainloop.c:run_connection_housekeeping() 123 problem dependency-violation /src/core/mainloop/mainloop.c 50 problem dependency-violation /src/core/mainloop/mainloop_pubsub.c 1 @@ -142,7 +142,6 @@ problem function-size /src/core/or/connection_edge.c:connection_exit_begin_conn( problem function-size /src/core/or/connection_edge.c:connection_exit_connect() 102 problem dependency-violation /src/core/or/connection_edge.c 27 problem dependency-violation /src/core/or/connection_edge.h 1 -problem file-size /src/core/or/connection_or.c 3122 problem function-size /src/core/or/connection_or.c:connection_or_group_set_badness_() 105 problem function-size /src/core/or/connection_or.c:connection_or_client_learned_peer_id() 142 problem dependency-violation /src/core/or/connection_or.c 20 @@ -152,13 +151,12 @@ problem file-size /src/core/or/or.h 1107 problem include-count /src/core/or/or.h 48 problem dependency-violation /src/core/or/or.h 1 problem dependency-violation /src/core/or/or_periodic.c 1 -problem file-size /src/core/or/policies.c 3195 +problem file-size /src/core/or/policies.c 3182 problem function-size /src/core/or/policies.c:policy_summarize() 107 problem dependency-violation /src/core/or/policies.c 14 problem function-size /src/core/or/protover.c:protover_all_supported() 117 problem dependency-violation /src/core/or/reasons.c 2 problem file-size /src/core/or/relay.c 3264 -problem dependency-violation /src/core/or/relay_handshake.c 5 problem function-size /src/core/or/relay.c:circuit_receive_relay_cell() 127 problem function-size /src/core/or/relay.c:relay_send_command_from_edge_() 109 problem function-size /src/core/or/relay.c:connection_ap_process_end_not_open() 192 @@ -182,7 +180,7 @@ problem dependency-violation /src/core/proto/proto_http.c 1 problem function-size /src/core/proto/proto_socks.c:parse_socks_client() 110 problem dependency-violation /src/core/proto/proto_socks.c 8 problem function-size /src/feature/client/addressmap.c:addressmap_rewrite() 109 -problem function-size /src/feature/client/bridges.c:rewrite_node_address_for_bridge() 126 +problem function-size /src/feature/client/bridges.c:rewrite_node_address_for_bridge() 125 problem function-size /src/feature/client/circpathbias.c:pathbias_measure_close_rate() 108 problem function-size /src/feature/client/dnsserv.c:evdns_server_callback() 153 problem file-size /src/feature/client/entrynodes.c 3825 @@ -209,7 +207,7 @@ problem function-size /src/feature/dirauth/dirvote.c:format_networkstatus_vote() problem function-size /src/feature/dirauth/dirvote.c:networkstatus_compute_bw_weights_v10() 233 problem function-size /src/feature/dirauth/dirvote.c:networkstatus_compute_consensus() 952 problem function-size /src/feature/dirauth/dirvote.c:networkstatus_add_detached_signatures() 119 -problem function-size /src/feature/dirauth/dirvote.c:dirvote_add_vote() 162 +problem function-size /src/feature/dirauth/dirvote.c:dirvote_add_vote() 161 problem function-size /src/feature/dirauth/dirvote.c:dirvote_compute_consensuses() 164 problem function-size /src/feature/dirauth/dirvote.c:dirserv_generate_networkstatus_vote_obj() 281 problem function-size /src/feature/dirauth/dsigs_parse.c:networkstatus_parse_detached_signatures() 196 @@ -242,12 +240,11 @@ problem function-size /src/feature/dirparse/routerparse.c:router_parse_entry_fro problem function-size /src/feature/dirparse/routerparse.c:extrainfo_parse_entry_from_string() 208 problem function-size /src/feature/hibernate/hibernate.c:accounting_parse_options() 109 problem function-size /src/feature/hs/hs_cell.c:hs_cell_build_establish_intro() 115 -problem function-size /src/feature/hs/hs_cell.c:hs_cell_parse_introduce2() 152 +problem function-size /src/feature/hs/hs_cell.c:hs_cell_parse_introduce2() 134 problem function-size /src/feature/hs/hs_client.c:send_introduce1() 103 problem function-size /src/feature/hs/hs_common.c:hs_get_responsible_hsdirs() 102 problem function-size /src/feature/hs/hs_config.c:config_service_v3() 128 problem function-size /src/feature/hs/hs_config.c:config_generic_service() 138 -problem function-size /src/feature/hs/hs_descriptor.c:desc_encode_v3() 101 problem function-size /src/feature/hs/hs_descriptor.c:decrypt_desc_layer() 111 problem function-size /src/feature/hs/hs_descriptor.c:decode_introduction_point() 122 problem function-size /src/feature/hs/hs_descriptor.c:desc_decode_superencrypted_v3() 107 @@ -315,7 +312,6 @@ problem function-size /src/lib/net/address.c:tor_addr_parse_mask_ports() 194 problem function-size /src/lib/net/address.c:tor_addr_compare_masked() 110 problem function-size /src/lib/net/inaddr.c:tor_inet_pton() 107 problem function-size /src/lib/net/socketpair.c:tor_ersatz_socketpair() 102 -problem function-size /src/lib/osinfo/uname.c:get_uname() 116 problem function-size /src/lib/process/process_unix.c:process_unix_exec() 213 problem function-size /src/lib/process/process_win32.c:process_win32_exec() 151 problem function-size /src/lib/process/process_win32.c:process_win32_create_pipe() 109

1 0