October 2019 - tor-commits - lists.torproject.org

[tor-browser/tor-browser-68.1.0esr-9.0-3] Bug 31144 - Do not switching apps from CustomTabs without consent
by gk＠torproject.org 18 Oct '19

18 Oct '19

commit d5123da897516717e62db98dccbcabd70162dcb3 Author: Matthew Finkel <Matthew.Finkel(a)gmail.com> Date: Fri Oct 18 00:57:00 2019 +0000 Bug 31144 - Do not switching apps from CustomTabs without consent --- .../base/java/org/mozilla/gecko/customtabs/CustomTabsActivity.java | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/mobile/android/base/java/org/mozilla/gecko/customtabs/CustomTabsActivity.java b/mobile/android/base/java/org/mozilla/gecko/customtabs/CustomTabsActivity.java index 230773cd1292..872fe9723001 100644 --- a/mobile/android/base/java/org/mozilla/gecko/customtabs/CustomTabsActivity.java +++ b/mobile/android/base/java/org/mozilla/gecko/customtabs/CustomTabsActivity.java @@ -621,7 +621,8 @@ public class CustomTabsActivity extends AppCompatActivity final Intent intent = new Intent(Intent.ACTION_VIEW); intent.setData(uri); try { - startActivity(intent); + // Bug 31144 - Don't know how to handle this case. + //startActivity(intent); } catch (ActivityNotFoundException e) { Log.w(LOGTAG, "No activity handler found for: " + request.uri); }

1 0

[translation/bridgedb_completed] https://gitweb.torproject.org/translation.git/commit/?h=bridgedb_completed
by translation＠torproject.org 18 Oct '19

18 Oct '19

commit aae3212e393bb4be15947a1b0ed7229c0d6f4ffd Author: Translation commit bot <translation(a)torproject.org> Date: Fri Oct 18 02:15:24 2019 +0000 https://gitweb.torproject.org/translation.git/commit/?h=bridgedb_completed --- ru/LC_MESSAGES/bridgedb.po | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/ru/LC_MESSAGES/bridgedb.po b/ru/LC_MESSAGES/bridgedb.po index a5f47426a..69cca74bc 100644 --- a/ru/LC_MESSAGES/bridgedb.po +++ b/ru/LC_MESSAGES/bridgedb.po @@ -19,6 +19,7 @@ # Oleg, 2014 # Roberto Brigante, 2017 # Sergey Briskin, 2014 +# Sergey Smirnov <cj75300(a)gmail.com>, 2019 # solokot <solokot(a)gmail.com>, 2019 # solokot <solokot(a)gmail.com>, 2018 # Valid Olov, 2014 @@ -31,8 +32,8 @@ msgstr "" "Project-Id-Version: Tor Project\n" "Report-Msgid-Bugs-To: 'https://trac.torproject.org/projects/tor/newticket?component=BridgeDB&keywo…'\n" "POT-Creation-Date: 2019-10-03 15:04-0700\n" -"PO-Revision-Date: 2019-10-06 10:47+0000\n" -"Last-Translator: solokot <solokot(a)gmail.com>\n" +"PO-Revision-Date: 2019-10-18 01:48+0000\n" +"Last-Translator: Sergey Smirnov <cj75300(a)gmail.com>\n" "Language-Team: Russian (http://www.transifex.com/otf/torproject/language/ru/)\n" "MIME-Version: 1.0\n" "Content-Type: text/plain; charset=UTF-8\n"

1 0

[translation/bridgedb] https://gitweb.torproject.org/translation.git/commit/?h=bridgedb
by translation＠torproject.org 18 Oct '19

18 Oct '19

commit e7a352b0632e0100b97bde917ebe4cace8f5869f Author: Translation commit bot <translation(a)torproject.org> Date: Fri Oct 18 02:15:16 2019 +0000 https://gitweb.torproject.org/translation.git/commit/?h=bridgedb --- ru/LC_MESSAGES/bridgedb.po | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/ru/LC_MESSAGES/bridgedb.po b/ru/LC_MESSAGES/bridgedb.po index f8a0f22c5..81d746326 100644 --- a/ru/LC_MESSAGES/bridgedb.po +++ b/ru/LC_MESSAGES/bridgedb.po @@ -19,6 +19,7 @@ # Oleg, 2014 # Roberto Brigante, 2017 # Sergey Briskin, 2014 +# Sergey Smirnov <cj75300(a)gmail.com>, 2019 # solokot <solokot(a)gmail.com>, 2019 # solokot <solokot(a)gmail.com>, 2018 # Valid Olov, 2014 @@ -31,8 +32,8 @@ msgstr "" "Project-Id-Version: Tor Project\n" "Report-Msgid-Bugs-To: 'https://trac.torproject.org/projects/tor/newticket?component=BridgeDB&keywo…'\n" "POT-Creation-Date: 2019-10-03 15:04-0700\n" -"PO-Revision-Date: 2019-10-06 10:47+0000\n" -"Last-Translator: solokot <solokot(a)gmail.com>\n" +"PO-Revision-Date: 2019-10-18 01:48+0000\n" +"Last-Translator: Sergey Smirnov <cj75300(a)gmail.com>\n" "Language-Team: Russian (http://www.transifex.com/otf/torproject/language/ru/)\n" "MIME-Version: 1.0\n" "Content-Type: text/plain; charset=UTF-8\n" @@ -127,7 +128,7 @@ msgstr "На данный момент нет доступных мостов... msgid "" " Perhaps you should try %s going back %s and choosing a different bridge " "type!" -msgstr "Возможно, вам стоит попробовать %s вернуться%s и выбрать другой тип моста!" +msgstr "Возможно, вам стоит попробовать %s вернуться %s и выбрать другой тип моста!" #: bridgedb/distributors/https/templates/index.html:11 #, python-format

1 0

[tor/release-0.4.2] hs-v3: Fix possible memory leak in error code path
by teor＠torproject.org 18 Oct '19

18 Oct '19

commit 09e6c0f7c7b91a73c73df197e45072a96240ea8d Author: David Goulet <dgoulet(a)torproject.org> Date: Tue Oct 15 08:54:11 2019 -0400 hs-v3: Fix possible memory leak in error code path Found by coverity CID 1454769. There were a second possible leak that is also fixed in this commit. Fixes #32063 Signed-off-by: David Goulet <dgoulet(a)torproject.org> --- changes/ticket32063 | 3 +++ src/feature/hs/hs_cell.c | 13 +++++++++---- 2 files changed, 12 insertions(+), 4 deletions(-) diff --git a/changes/ticket32063 b/changes/ticket32063 new file mode 100644 index 000000000..2c0246917 --- /dev/null +++ b/changes/ticket32063 @@ -0,0 +1,3 @@ + o Minor bugfixes (hs-v3, memory leak): + - Fix memory leak in unlikely error code path when encoding HS DoS establish + intro extension cell. Fixes bug 32063; bugfix on 0.4.2.1-alpha. diff --git a/src/feature/hs/hs_cell.c b/src/feature/hs/hs_cell.c index d691a1b00..df59f73c1 100644 --- a/src/feature/hs/hs_cell.c +++ b/src/feature/hs/hs_cell.c @@ -503,8 +503,8 @@ build_establish_intro_dos_extension(const hs_service_config_t *service_config, ssize_t ret; size_t dos_ext_encoded_len; uint8_t *field_array; - trn_cell_extension_field_t *field; - trn_cell_extension_dos_t *dos_ext; + trn_cell_extension_field_t *field = NULL; + trn_cell_extension_dos_t *dos_ext = NULL; tor_assert(service_config); tor_assert(extensions); @@ -530,7 +530,7 @@ build_establish_intro_dos_extension(const hs_service_config_t *service_config, /* Set the field with the encoded DoS extension. */ ret = trn_cell_extension_dos_encoded_len(dos_ext); if (BUG(ret <= 0)) { - return -1; + goto err; } dos_ext_encoded_len = ret; /* Set length field and the field array size length. */ @@ -541,7 +541,7 @@ build_establish_intro_dos_extension(const hs_service_config_t *service_config, ret = trn_cell_extension_dos_encode(field_array, trn_cell_extension_field_getlen_field(field), dos_ext); if (BUG(ret <= 0)) { - return -1; + goto err; } tor_assert(ret == (ssize_t) dos_ext_encoded_len); @@ -557,6 +557,11 @@ build_establish_intro_dos_extension(const hs_service_config_t *service_config, trn_cell_extension_dos_free(dos_ext); return 0; + + err: + trn_cell_extension_field_free(field); + trn_cell_extension_dos_free(dos_ext); + return -1; } /* ========== */

1 0

[tor/release-0.4.2] Merge remote-tracking branch 'tor-github/pr/1407' into maint-0.4.2
by teor＠torproject.org 18 Oct '19

18 Oct '19

commit f73c8bd7865a8a64d46c126ca7e206204510ace8 Merge: 8ac9af233 09e6c0f7c Author: teor <teor(a)torproject.org> Date: Fri Oct 18 12:05:07 2019 +1000 Merge remote-tracking branch 'tor-github/pr/1407' into maint-0.4.2 changes/ticket32063 | 3 +++ src/feature/hs/hs_cell.c | 13 +++++++++---- 2 files changed, 12 insertions(+), 4 deletions(-)

1 0

[tor/maint-0.4.2] Merge remote-tracking branch 'tor-github/pr/1407' into maint-0.4.2
by teor＠torproject.org 18 Oct '19

18 Oct '19

commit f73c8bd7865a8a64d46c126ca7e206204510ace8 Merge: 8ac9af233 09e6c0f7c Author: teor <teor(a)torproject.org> Date: Fri Oct 18 12:05:07 2019 +1000 Merge remote-tracking branch 'tor-github/pr/1407' into maint-0.4.2 changes/ticket32063 | 3 +++ src/feature/hs/hs_cell.c | 13 +++++++++---- 2 files changed, 12 insertions(+), 4 deletions(-)

1 0

[tor/maint-0.4.2] hs-v3: Fix possible memory leak in error code path
by teor＠torproject.org 18 Oct '19

18 Oct '19

commit 09e6c0f7c7b91a73c73df197e45072a96240ea8d Author: David Goulet <dgoulet(a)torproject.org> Date: Tue Oct 15 08:54:11 2019 -0400 hs-v3: Fix possible memory leak in error code path Found by coverity CID 1454769. There were a second possible leak that is also fixed in this commit. Fixes #32063 Signed-off-by: David Goulet <dgoulet(a)torproject.org> --- changes/ticket32063 | 3 +++ src/feature/hs/hs_cell.c | 13 +++++++++---- 2 files changed, 12 insertions(+), 4 deletions(-) diff --git a/changes/ticket32063 b/changes/ticket32063 new file mode 100644 index 000000000..2c0246917 --- /dev/null +++ b/changes/ticket32063 @@ -0,0 +1,3 @@ + o Minor bugfixes (hs-v3, memory leak): + - Fix memory leak in unlikely error code path when encoding HS DoS establish + intro extension cell. Fixes bug 32063; bugfix on 0.4.2.1-alpha. diff --git a/src/feature/hs/hs_cell.c b/src/feature/hs/hs_cell.c index d691a1b00..df59f73c1 100644 --- a/src/feature/hs/hs_cell.c +++ b/src/feature/hs/hs_cell.c @@ -503,8 +503,8 @@ build_establish_intro_dos_extension(const hs_service_config_t *service_config, ssize_t ret; size_t dos_ext_encoded_len; uint8_t *field_array; - trn_cell_extension_field_t *field; - trn_cell_extension_dos_t *dos_ext; + trn_cell_extension_field_t *field = NULL; + trn_cell_extension_dos_t *dos_ext = NULL; tor_assert(service_config); tor_assert(extensions); @@ -530,7 +530,7 @@ build_establish_intro_dos_extension(const hs_service_config_t *service_config, /* Set the field with the encoded DoS extension. */ ret = trn_cell_extension_dos_encoded_len(dos_ext); if (BUG(ret <= 0)) { - return -1; + goto err; } dos_ext_encoded_len = ret; /* Set length field and the field array size length. */ @@ -541,7 +541,7 @@ build_establish_intro_dos_extension(const hs_service_config_t *service_config, ret = trn_cell_extension_dos_encode(field_array, trn_cell_extension_field_getlen_field(field), dos_ext); if (BUG(ret <= 0)) { - return -1; + goto err; } tor_assert(ret == (ssize_t) dos_ext_encoded_len); @@ -557,6 +557,11 @@ build_establish_intro_dos_extension(const hs_service_config_t *service_config, trn_cell_extension_dos_free(dos_ext); return 0; + + err: + trn_cell_extension_field_free(field); + trn_cell_extension_dos_free(dos_ext); + return -1; } /* ========== */

1 0

[tor/master] Merge remote-tracking branch 'tor-github/pr/1407' into maint-0.4.2
by teor＠torproject.org 18 Oct '19

18 Oct '19

commit f73c8bd7865a8a64d46c126ca7e206204510ace8 Merge: 8ac9af233 09e6c0f7c Author: teor <teor(a)torproject.org> Date: Fri Oct 18 12:05:07 2019 +1000 Merge remote-tracking branch 'tor-github/pr/1407' into maint-0.4.2 changes/ticket32063 | 3 +++ src/feature/hs/hs_cell.c | 13 +++++++++---- 2 files changed, 12 insertions(+), 4 deletions(-)

1 0

[tor/master] Merge branch 'maint-0.4.2'
by teor＠torproject.org 18 Oct '19

18 Oct '19

commit d616214e474084fd6fc0af122f699e9dd2ad02d1 Merge: 800b823c2 f73c8bd78 Author: teor <teor(a)torproject.org> Date: Fri Oct 18 12:05:20 2019 +1000 Merge branch 'maint-0.4.2' changes/ticket32063 | 3 +++ src/feature/hs/hs_cell.c | 13 +++++++++---- 2 files changed, 12 insertions(+), 4 deletions(-)

1 0

[tor/master] hs-v3: Fix possible memory leak in error code path
by teor＠torproject.org 18 Oct '19

18 Oct '19

commit 09e6c0f7c7b91a73c73df197e45072a96240ea8d Author: David Goulet <dgoulet(a)torproject.org> Date: Tue Oct 15 08:54:11 2019 -0400 hs-v3: Fix possible memory leak in error code path Found by coverity CID 1454769. There were a second possible leak that is also fixed in this commit. Fixes #32063 Signed-off-by: David Goulet <dgoulet(a)torproject.org> --- changes/ticket32063 | 3 +++ src/feature/hs/hs_cell.c | 13 +++++++++---- 2 files changed, 12 insertions(+), 4 deletions(-) diff --git a/changes/ticket32063 b/changes/ticket32063 new file mode 100644 index 000000000..2c0246917 --- /dev/null +++ b/changes/ticket32063 @@ -0,0 +1,3 @@ + o Minor bugfixes (hs-v3, memory leak): + - Fix memory leak in unlikely error code path when encoding HS DoS establish + intro extension cell. Fixes bug 32063; bugfix on 0.4.2.1-alpha. diff --git a/src/feature/hs/hs_cell.c b/src/feature/hs/hs_cell.c index d691a1b00..df59f73c1 100644 --- a/src/feature/hs/hs_cell.c +++ b/src/feature/hs/hs_cell.c @@ -503,8 +503,8 @@ build_establish_intro_dos_extension(const hs_service_config_t *service_config, ssize_t ret; size_t dos_ext_encoded_len; uint8_t *field_array; - trn_cell_extension_field_t *field; - trn_cell_extension_dos_t *dos_ext; + trn_cell_extension_field_t *field = NULL; + trn_cell_extension_dos_t *dos_ext = NULL; tor_assert(service_config); tor_assert(extensions); @@ -530,7 +530,7 @@ build_establish_intro_dos_extension(const hs_service_config_t *service_config, /* Set the field with the encoded DoS extension. */ ret = trn_cell_extension_dos_encoded_len(dos_ext); if (BUG(ret <= 0)) { - return -1; + goto err; } dos_ext_encoded_len = ret; /* Set length field and the field array size length. */ @@ -541,7 +541,7 @@ build_establish_intro_dos_extension(const hs_service_config_t *service_config, ret = trn_cell_extension_dos_encode(field_array, trn_cell_extension_field_getlen_field(field), dos_ext); if (BUG(ret <= 0)) { - return -1; + goto err; } tor_assert(ret == (ssize_t) dos_ext_encoded_len); @@ -557,6 +557,11 @@ build_establish_intro_dos_extension(const hs_service_config_t *service_config, trn_cell_extension_dos_free(dos_ext); return 0; + + err: + trn_cell_extension_field_free(field); + trn_cell_extension_dos_free(dos_ext); + return -1; } /* ========== */

1 0