October 2019 - tor-commits - lists.torproject.org

[onionoo/master] Bump version to 7.0-1.21.0-dev.
by karsten＠torproject.org 18 Oct '19

18 Oct '19

commit 06ab8b46f03b612f551025fcb5abaff690ee70c6 Author: Karsten Loesing <karsten.loesing(a)gmx.net> Date: Fri Oct 18 09:08:28 2019 +0200 Bump version to 7.0-1.21.0-dev. --- CHANGELOG.md | 3 +++ build.xml | 2 +- 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index d0f9e8d..29b57e0 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,3 +1,6 @@ +# Changes in version 7.0-1.??.? - 2019-1?-?? + + # Changes in version 7.0-1.21.0 - 2019-10-18 * Medium changes diff --git a/build.xml b/build.xml index 91e6130..ec84464 100644 --- a/build.xml +++ b/build.xml @@ -11,7 +11,7 @@ <property name="implementation-title" value="Onionoo" /> <property name="onionoo.protocol.version" value="7.0"/> <property name="release.version" - value="${onionoo.protocol.version}-1.21.0"/> + value="${onionoo.protocol.version}-1.21.0-dev"/> <property name="metricslibversion" value="2.6.2"/> <property name="jetty.version" value="-9.2.21.v20170120" /> <property name="warfile"

1 0

[onionoo/release] Increase timeout for testCountryDeDe even more.
by karsten＠torproject.org 18 Oct '19

18 Oct '19

commit 1579c1e2c103880129271daf30f49cb2e52f7b10 Author: Karsten Loesing <karsten.loesing(a)gmx.net> Date: Fri Oct 4 11:01:52 2019 +0200 Increase timeout for testCountryDeDe even more. The timeout was again being reached in the GitLab CI environment. --- .../java/org/torproject/metrics/onionoo/server/ResourceServletTest.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/test/java/org/torproject/metrics/onionoo/server/ResourceServletTest.java b/src/test/java/org/torproject/metrics/onionoo/server/ResourceServletTest.java index 935c06e..7df56ea 100644 --- a/src/test/java/org/torproject/metrics/onionoo/server/ResourceServletTest.java +++ b/src/test/java/org/torproject/metrics/onionoo/server/ResourceServletTest.java @@ -1134,7 +1134,7 @@ public class ResourceServletTest { null); } - @Test(timeout = 400) + @Test(timeout = 800) public void testCountryDeDe() { this.assertSummaryDocument( "/summary?country=de&country=de", 1, new String[] { "TorkaZ" }, 0,

1 0

[onionoo/release] Update to latest metrics-base.
by karsten＠torproject.org 18 Oct '19

18 Oct '19

commit df7d3369e7418ff381e8f6b9850311fa0187e757 Author: Karsten Loesing <karsten.loesing(a)gmx.net> Date: Mon Oct 14 16:32:25 2019 +0200 Update to latest metrics-base. --- src/build | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/build b/src/build index 62a964a..d82fff9 160000 --- a/src/build +++ b/src/build @@ -1 +1 @@ -Subproject commit 62a964a7702086ca6ba0e2307809d4f983163b47 +Subproject commit d82fff984634fe006ac7b0b102e7f48a52ca20d9

1 0

[onionoo/release] Bump version to 7.0-1.20.0-dev.
by karsten＠torproject.org 18 Oct '19

18 Oct '19

commit c61ce6c4ec69741c3fe35f48e4cddf18f5a8ee49 Author: Karsten Loesing <karsten.loesing(a)gmx.net> Date: Fri Oct 4 11:09:15 2019 +0200 Bump version to 7.0-1.20.0-dev. --- build.xml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/build.xml b/build.xml index 360dc8b..a6969f5 100644 --- a/build.xml +++ b/build.xml @@ -11,7 +11,7 @@ <property name="implementation-title" value="Onionoo" /> <property name="onionoo.protocol.version" value="7.0"/> <property name="release.version" - value="${onionoo.protocol.version}-1.20.0"/> + value="${onionoo.protocol.version}-1.20.0-dev"/> <property name="metricslibversion" value="2.6.2"/> <property name="jetty.version" value="-9.2.21.v20170120" /> <property name="warfile"

1 0

[onionoo/release] Prepare for 7.0-1.21.0 release.
by karsten＠torproject.org 18 Oct '19

18 Oct '19

commit 08f4d3a7f628c0adaba11363d997eaf453982c76 Author: Karsten Loesing <karsten.loesing(a)gmx.net> Date: Fri Oct 18 08:58:11 2019 +0200 Prepare for 7.0-1.21.0 release. --- CHANGELOG.md | 3 ++- build.xml | 2 +- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 3ab6329..d0f9e8d 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,6 +1,7 @@ -# Changes in version 7.0-1.21.0 - 2019-1?-?? +# Changes in version 7.0-1.21.0 - 2019-10-18 * Medium changes + - Add previously missing Jetty servlets dependency. - Fix a bug where old reverse DNS lookups were sometimes not cleared properly. diff --git a/build.xml b/build.xml index a6969f5..91e6130 100644 --- a/build.xml +++ b/build.xml @@ -11,7 +11,7 @@ <property name="implementation-title" value="Onionoo" /> <property name="onionoo.protocol.version" value="7.0"/> <property name="release.version" - value="${onionoo.protocol.version}-1.20.0-dev"/> + value="${onionoo.protocol.version}-1.21.0"/> <property name="metricslibversion" value="2.6.2"/> <property name="jetty.version" value="-9.2.21.v20170120" /> <property name="warfile"

1 0

[onionoo/release] Always clear old reverse DNS lookups.
by karsten＠torproject.org 18 Oct '19

18 Oct '19

commit 6faa1ab757f16263f7925dbe4c49d6dfb698f265 Author: Karsten Loesing <karsten.loesing(a)gmx.net> Date: Thu Oct 3 16:43:21 2019 +0200 Always clear old reverse DNS lookups. The fix is to distinguish between lookup results being null for a given fingerprint (because we didn't have enough time to look up an address) and the empty set (because we received 0 verified or 0 unverified host names in response). Fixes #31941. --- CHANGELOG.md | 9 ++++++++- .../metrics/onionoo/updater/NodeDetailsStatusUpdater.java | 4 ++-- .../metrics/onionoo/updater/RdnsLookupRequest.java | 14 +++++++------- .../metrics/onionoo/updater/RdnsLookupWorker.java | 4 ++-- 4 files changed, 19 insertions(+), 12 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 696b33d..3ab6329 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,4 +1,11 @@ -# Changes in version 7.0-1.20.0 - 2019-0?-?? +# Changes in version 7.0-1.21.0 - 2019-1?-?? + + * Medium changes + - Fix a bug where old reverse DNS lookups were sometimes not + cleared properly. + + +# Changes in version 7.0-1.20.0 - 2019-10-04 * Medium changes - Use Ivy for resolving external dependencies rather than relying diff --git a/src/main/java/org/torproject/metrics/onionoo/updater/NodeDetailsStatusUpdater.java b/src/main/java/org/torproject/metrics/onionoo/updater/NodeDetailsStatusUpdater.java index 2bdf03f..a5f16e4 100644 --- a/src/main/java/org/torproject/metrics/onionoo/updater/NodeDetailsStatusUpdater.java +++ b/src/main/java/org/torproject/metrics/onionoo/updater/NodeDetailsStatusUpdater.java @@ -771,10 +771,10 @@ public class NodeDetailsStatusUpdater implements DescriptorListener, verifiedLookupResults.get(nodeStatus.getAddress()); SortedSet<String> unverifiedHostNames = unverifiedLookupResults.get(nodeStatus.getAddress()); - if (null != verifiedHostNames && !verifiedHostNames.isEmpty()) { + if (null != verifiedHostNames) { this.rdnsVerifiedLookupResults.put(fingerprint, verifiedHostNames); } - if (null != unverifiedHostNames && !unverifiedHostNames.isEmpty()) { + if (null != unverifiedHostNames) { this.rdnsUnverifiedLookupResults.put(fingerprint, unverifiedHostNames); } } diff --git a/src/main/java/org/torproject/metrics/onionoo/updater/RdnsLookupRequest.java b/src/main/java/org/torproject/metrics/onionoo/updater/RdnsLookupRequest.java index 2f598a4..53e3fa9 100644 --- a/src/main/java/org/torproject/metrics/onionoo/updater/RdnsLookupRequest.java +++ b/src/main/java/org/torproject/metrics/onionoo/updater/RdnsLookupRequest.java @@ -39,9 +39,9 @@ class RdnsLookupRequest extends Thread { @Override public void run() { this.lookupStartedMillis = System.currentTimeMillis(); + final SortedSet<String> verifiedResults = new TreeSet<>(); + final SortedSet<String> unverifiedResults = new TreeSet<>(); try { - final SortedSet<String> verifiedResults = new TreeSet<>(); - final SortedSet<String> unverifiedResults = new TreeSet<>(); final String[] bytes = this.address.split("\\."); if (bytes.length == 4) { final String reverseDnsDomain = @@ -69,15 +69,15 @@ class RdnsLookupRequest extends Thread { } } } - synchronized (this) { - this.verifiedHostNames = verifiedResults; - this.unverifiedHostNames = unverifiedResults; - } } catch (NamingException e) { /* The Onionoo field is omitted for both lookup failure and absence of * a host name. We'll try again the next time. */ } - this.lookupCompletedMillis = System.currentTimeMillis(); + synchronized (this) { + this.verifiedHostNames = verifiedResults; + this.unverifiedHostNames = unverifiedResults; + this.lookupCompletedMillis = System.currentTimeMillis(); + } this.parent.interrupt(); } diff --git a/src/main/java/org/torproject/metrics/onionoo/updater/RdnsLookupWorker.java b/src/main/java/org/torproject/metrics/onionoo/updater/RdnsLookupWorker.java index ab5360e..6353daa 100644 --- a/src/main/java/org/torproject/metrics/onionoo/updater/RdnsLookupWorker.java +++ b/src/main/java/org/torproject/metrics/onionoo/updater/RdnsLookupWorker.java @@ -40,7 +40,7 @@ class RdnsLookupWorker extends Thread { /* Getting interrupted should be the default case. */ } SortedSet<String> verifiedHostNames = request.getVerifiedHostNames(); - if (null != verifiedHostNames && !verifiedHostNames.isEmpty()) { + if (null != verifiedHostNames) { synchronized (this.reverseDomainNameResolver .rdnsVerifiedLookupResults) { this.reverseDomainNameResolver.rdnsVerifiedLookupResults.put( @@ -48,7 +48,7 @@ class RdnsLookupWorker extends Thread { } } SortedSet<String> unverifiedHostNames = request.getUnverifiedHostNames(); - if (null != unverifiedHostNames && !unverifiedHostNames.isEmpty()) { + if (null != unverifiedHostNames) { synchronized (this.reverseDomainNameResolver .rdnsUnverifiedLookupResults) { this.reverseDomainNameResolver.rdnsUnverifiedLookupResults.put(

1 0

[onionoo/master] Prepare for 7.0-1.21.0 release.
by karsten＠torproject.org 18 Oct '19

18 Oct '19

commit 08f4d3a7f628c0adaba11363d997eaf453982c76 Author: Karsten Loesing <karsten.loesing(a)gmx.net> Date: Fri Oct 18 08:58:11 2019 +0200 Prepare for 7.0-1.21.0 release. --- CHANGELOG.md | 3 ++- build.xml | 2 +- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 3ab6329..d0f9e8d 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,6 +1,7 @@ -# Changes in version 7.0-1.21.0 - 2019-1?-?? +# Changes in version 7.0-1.21.0 - 2019-10-18 * Medium changes + - Add previously missing Jetty servlets dependency. - Fix a bug where old reverse DNS lookups were sometimes not cleared properly. diff --git a/build.xml b/build.xml index a6969f5..91e6130 100644 --- a/build.xml +++ b/build.xml @@ -11,7 +11,7 @@ <property name="implementation-title" value="Onionoo" /> <property name="onionoo.protocol.version" value="7.0"/> <property name="release.version" - value="${onionoo.protocol.version}-1.20.0-dev"/> + value="${onionoo.protocol.version}-1.21.0"/> <property name="metricslibversion" value="2.6.2"/> <property name="jetty.version" value="-9.2.21.v20170120" /> <property name="warfile"

1 0

[tor/master] core: tabify a line in include.am
by teor＠torproject.org 18 Oct '19

18 Oct '19

commit 1697019d5f4b7306f4c7ffb54178530461a54a52 Author: teor <teor(a)torproject.org> Date: Fri Oct 18 13:42:22 2019 +1000 core: tabify a line in include.am --- src/core/include.am | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/core/include.am b/src/core/include.am index f6ae3f2b5..a5d11c24f 100644 --- a/src/core/include.am +++ b/src/core/include.am @@ -323,7 +323,7 @@ noinst_HEADERS += \ src/feature/control/fmt_serverstatus.h \ src/feature/control/getinfo_geoip.h \ src/feature/dirauth/authmode.h \ - src/feature/dirauth/bridgeauth.h \ + src/feature/dirauth/bridgeauth.h \ src/feature/dirauth/bwauth.h \ src/feature/dirauth/dirauth_periodic.h \ src/feature/dirauth/dirauth_sys.h \

1 0

[onionoo/master] Always clear old reverse DNS lookups.
by karsten＠torproject.org 18 Oct '19

18 Oct '19

commit 6faa1ab757f16263f7925dbe4c49d6dfb698f265 Author: Karsten Loesing <karsten.loesing(a)gmx.net> Date: Thu Oct 3 16:43:21 2019 +0200 Always clear old reverse DNS lookups. The fix is to distinguish between lookup results being null for a given fingerprint (because we didn't have enough time to look up an address) and the empty set (because we received 0 verified or 0 unverified host names in response). Fixes #31941. --- CHANGELOG.md | 9 ++++++++- .../metrics/onionoo/updater/NodeDetailsStatusUpdater.java | 4 ++-- .../metrics/onionoo/updater/RdnsLookupRequest.java | 14 +++++++------- .../metrics/onionoo/updater/RdnsLookupWorker.java | 4 ++-- 4 files changed, 19 insertions(+), 12 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 696b33d..3ab6329 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,4 +1,11 @@ -# Changes in version 7.0-1.20.0 - 2019-0?-?? +# Changes in version 7.0-1.21.0 - 2019-1?-?? + + * Medium changes + - Fix a bug where old reverse DNS lookups were sometimes not + cleared properly. + + +# Changes in version 7.0-1.20.0 - 2019-10-04 * Medium changes - Use Ivy for resolving external dependencies rather than relying diff --git a/src/main/java/org/torproject/metrics/onionoo/updater/NodeDetailsStatusUpdater.java b/src/main/java/org/torproject/metrics/onionoo/updater/NodeDetailsStatusUpdater.java index 2bdf03f..a5f16e4 100644 --- a/src/main/java/org/torproject/metrics/onionoo/updater/NodeDetailsStatusUpdater.java +++ b/src/main/java/org/torproject/metrics/onionoo/updater/NodeDetailsStatusUpdater.java @@ -771,10 +771,10 @@ public class NodeDetailsStatusUpdater implements DescriptorListener, verifiedLookupResults.get(nodeStatus.getAddress()); SortedSet<String> unverifiedHostNames = unverifiedLookupResults.get(nodeStatus.getAddress()); - if (null != verifiedHostNames && !verifiedHostNames.isEmpty()) { + if (null != verifiedHostNames) { this.rdnsVerifiedLookupResults.put(fingerprint, verifiedHostNames); } - if (null != unverifiedHostNames && !unverifiedHostNames.isEmpty()) { + if (null != unverifiedHostNames) { this.rdnsUnverifiedLookupResults.put(fingerprint, unverifiedHostNames); } } diff --git a/src/main/java/org/torproject/metrics/onionoo/updater/RdnsLookupRequest.java b/src/main/java/org/torproject/metrics/onionoo/updater/RdnsLookupRequest.java index 2f598a4..53e3fa9 100644 --- a/src/main/java/org/torproject/metrics/onionoo/updater/RdnsLookupRequest.java +++ b/src/main/java/org/torproject/metrics/onionoo/updater/RdnsLookupRequest.java @@ -39,9 +39,9 @@ class RdnsLookupRequest extends Thread { @Override public void run() { this.lookupStartedMillis = System.currentTimeMillis(); + final SortedSet<String> verifiedResults = new TreeSet<>(); + final SortedSet<String> unverifiedResults = new TreeSet<>(); try { - final SortedSet<String> verifiedResults = new TreeSet<>(); - final SortedSet<String> unverifiedResults = new TreeSet<>(); final String[] bytes = this.address.split("\\."); if (bytes.length == 4) { final String reverseDnsDomain = @@ -69,15 +69,15 @@ class RdnsLookupRequest extends Thread { } } } - synchronized (this) { - this.verifiedHostNames = verifiedResults; - this.unverifiedHostNames = unverifiedResults; - } } catch (NamingException e) { /* The Onionoo field is omitted for both lookup failure and absence of * a host name. We'll try again the next time. */ } - this.lookupCompletedMillis = System.currentTimeMillis(); + synchronized (this) { + this.verifiedHostNames = verifiedResults; + this.unverifiedHostNames = unverifiedResults; + this.lookupCompletedMillis = System.currentTimeMillis(); + } this.parent.interrupt(); } diff --git a/src/main/java/org/torproject/metrics/onionoo/updater/RdnsLookupWorker.java b/src/main/java/org/torproject/metrics/onionoo/updater/RdnsLookupWorker.java index ab5360e..6353daa 100644 --- a/src/main/java/org/torproject/metrics/onionoo/updater/RdnsLookupWorker.java +++ b/src/main/java/org/torproject/metrics/onionoo/updater/RdnsLookupWorker.java @@ -40,7 +40,7 @@ class RdnsLookupWorker extends Thread { /* Getting interrupted should be the default case. */ } SortedSet<String> verifiedHostNames = request.getVerifiedHostNames(); - if (null != verifiedHostNames && !verifiedHostNames.isEmpty()) { + if (null != verifiedHostNames) { synchronized (this.reverseDomainNameResolver .rdnsVerifiedLookupResults) { this.reverseDomainNameResolver.rdnsVerifiedLookupResults.put( @@ -48,7 +48,7 @@ class RdnsLookupWorker extends Thread { } } SortedSet<String> unverifiedHostNames = request.getUnverifiedHostNames(); - if (null != unverifiedHostNames && !unverifiedHostNames.isEmpty()) { + if (null != unverifiedHostNames) { synchronized (this.reverseDomainNameResolver .rdnsUnverifiedLookupResults) { this.reverseDomainNameResolver.rdnsUnverifiedLookupResults.put(

1 0

[tor-browser/tor-browser-68.1.0esr-9.0-3] Bug 31144 - Do not switching apps from CustomTabs without consent
by gk＠torproject.org 18 Oct '19

18 Oct '19

commit d5123da897516717e62db98dccbcabd70162dcb3 Author: Matthew Finkel <Matthew.Finkel(a)gmail.com> Date: Fri Oct 18 00:57:00 2019 +0000 Bug 31144 - Do not switching apps from CustomTabs without consent --- .../base/java/org/mozilla/gecko/customtabs/CustomTabsActivity.java | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/mobile/android/base/java/org/mozilla/gecko/customtabs/CustomTabsActivity.java b/mobile/android/base/java/org/mozilla/gecko/customtabs/CustomTabsActivity.java index 230773cd1292..872fe9723001 100644 --- a/mobile/android/base/java/org/mozilla/gecko/customtabs/CustomTabsActivity.java +++ b/mobile/android/base/java/org/mozilla/gecko/customtabs/CustomTabsActivity.java @@ -621,7 +621,8 @@ public class CustomTabsActivity extends AppCompatActivity final Intent intent = new Intent(Intent.ACTION_VIEW); intent.setData(uri); try { - startActivity(intent); + // Bug 31144 - Don't know how to handle this case. + //startActivity(intent); } catch (ActivityNotFoundException e) { Log.w(LOGTAG, "No activity handler found for: " + request.uri); }

1 0