January 2019 - tor-commits - lists.torproject.org

[tor/release-0.3.5] Stop re-checking our hardcoded dh parameters on every startup
by nickm＠torproject.org 03 Jan '19

03 Jan '19

commit b82717b27378a0f8048da9d865a8bd3c6dfedd6f Author: Nick Mathewson <nickm(a)torproject.org> Date: Fri Dec 14 14:07:00 2018 -0500 Stop re-checking our hardcoded dh parameters on every startup Closes ticket 28851. --- changes/ticket28851 | 4 ++++ src/lib/crypt_ops/crypto_dh_openssl.c | 6 ++++++ 2 files changed, 10 insertions(+) diff --git a/changes/ticket28851 b/changes/ticket28851 new file mode 100644 index 000000000..bab031866 --- /dev/null +++ b/changes/ticket28851 @@ -0,0 +1,4 @@ + o Minor features (performance): + - Stop re-validating our hardcoded Diffie-Hellman parameters on every + startup. Doing this wasted time and cycles, especially on low-powered + devices. Closes ticket 28851. diff --git a/src/lib/crypt_ops/crypto_dh_openssl.c b/src/lib/crypt_ops/crypto_dh_openssl.c index 54946458d..0d9bd513c 100644 --- a/src/lib/crypt_ops/crypto_dh_openssl.c +++ b/src/lib/crypt_ops/crypto_dh_openssl.c @@ -45,6 +45,8 @@ static BIGNUM *dh_param_p_tls = NULL; /** Shared G parameter for our DH key exchanges. */ static BIGNUM *dh_param_g = NULL; +/* This function is disabled unless we change the DH parameters. */ +#if 0 /** Validate a given set of Diffie-Hellman parameters. This is moderately * computationally expensive (milliseconds), so should only be called when * the DH parameters change. Returns 0 on success, * -1 on failure. @@ -98,6 +100,7 @@ crypto_validate_dh_params(const BIGNUM *p, const BIGNUM *g) DH_free(dh); return ret; } +#endif /** * Helper: convert <b>hex<b> to a bignum, and return it. Assert that the @@ -151,8 +154,11 @@ crypto_dh_init_openssl(void) dh_param_p = bignum_from_hex(OAKLEY_PRIME_2); dh_param_p_tls = bignum_from_hex(TLS_DH_PRIME); + /* Checks below are disabled unless we change the hardcoded DH parameters. */ +#if 0 tor_assert(0 == crypto_validate_dh_params(dh_param_p, dh_param_g)); tor_assert(0 == crypto_validate_dh_params(dh_param_p_tls, dh_param_g)); +#endif } /** Number of bits to use when choosing the x or y value in a Diffie-Hellman

1 0

[translation/donatepages-messagespot] Update translations for donatepages-messagespot
by translation＠torproject.org 03 Jan '19

03 Jan '19

commit 969984cab5879c20b47873363279e8da1011e046 Author: Translation commit bot <translation(a)torproject.org> Date: Thu Jan 3 14:45:27 2019 +0000 Update translations for donatepages-messagespot --- locale/es_AR/LC_MESSAGES/messages.po | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/locale/es_AR/LC_MESSAGES/messages.po b/locale/es_AR/LC_MESSAGES/messages.po index 45b16d18f..00278a0e0 100644 --- a/locale/es_AR/LC_MESSAGES/messages.po +++ b/locale/es_AR/LC_MESSAGES/messages.po @@ -1,13 +1,13 @@ # Translators: # Emma Peel, 2018 # erinm, 2018 -# Joaquín Serna, 2018 # Mariano Calvento <cmc800(a)gmail.com>, 2018 # Zuhualime Akoochimoya, 2018 +# Joaquín Serna, 2019 # msgid "" msgstr "" -"Last-Translator: Zuhualime Akoochimoya, 2018\n" +"Last-Translator: Joaquín Serna, 2019\n" "Language-Team: Spanish (Argentina) (https://www.transifex.com/otf/teams/1519/es_AR/)\n" "Language: es_AR\n" "Plural-Forms: nplurals=2; plural=(n != 1);\n" @@ -329,7 +329,7 @@ msgstr "remera" #: tmp/cache_locale/93/936f5ca9f26662b60293a725343573df95cb28c99d7c3f12b1c94ed37a453012.php:259 msgid "$15" -msgstr "" +msgstr "$15" #: tmp/cache_locale/93/936f5ca9f26662b60293a725343573df95cb28c99d7c3f12b1c94ed37a453012.php:261 msgid "OFF" @@ -1178,7 +1178,7 @@ msgid "" "About 80% of the Tor Project's spending goes to staffing, mostly software " "engineers." msgstr "" -"Cerca del 80% de los gastos del Proyecto Tor van a la planta rentada, " +"Cerca del 80% de los gastos del Proyecto Tor van para pagarle al personal, " "mayormente ingenieros en sistemas." #: tmp/cache_locale/4a/4ab2d928dab25aeb8c96bb2d1c2ad651173d6c029f40a442edf6925bfd038cd2.php:232

1 0

[tor/maint-0.3.5] Lower the loop_max constant in curve25519_basepoint_spot_check()
by nickm＠torproject.org 03 Jan '19

03 Jan '19

commit 041e9235c1710936a43f73d2f6e87bfc6e1c2242 Author: Nick Mathewson <nickm(a)torproject.org> Date: Thu Dec 13 11:26:09 2018 -0500 Lower the loop_max constant in curve25519_basepoint_spot_check() The point of this function is to make sure that the ed25519-based implementation of curve25519_basepoint() actually works when we start tor, and use the regular fallback implementation if it doesn't. But it accounts for 9% of our startup time in the case when we have directory information, and I think it's safe to make the test shorter. After all, it has yet to find any actual bugs in curved25519_scalarmult_basepoint_donna() on any platforms. Closes ticket 28838. --- changes/ticket28838 | 8 ++++++++ src/lib/crypt_ops/crypto_curve25519.c | 2 +- 2 files changed, 9 insertions(+), 1 deletion(-) diff --git a/changes/ticket28838 b/changes/ticket28838 new file mode 100644 index 000000000..6c290bf82 --- /dev/null +++ b/changes/ticket28838 @@ -0,0 +1,8 @@ + o Minor features (performance): + - Remove about 96% of the work from the function that we run at + startup to test our curve25519_basepoint implementation. Since + this function has yet to find an actual failure, we'll only + run it for 8 iterations instead of 200. Based on our profile + information, this change should save around 8% of our startup + time on typical desktops, and may have a similar effect on + other platforms. Closes ticket 28838. diff --git a/src/lib/crypt_ops/crypto_curve25519.c b/src/lib/crypt_ops/crypto_curve25519.c index e6a39a8c0..f3a9de9fc 100644 --- a/src/lib/crypt_ops/crypto_curve25519.c +++ b/src/lib/crypt_ops/crypto_curve25519.c @@ -289,7 +289,7 @@ curve25519_basepoint_spot_check(void) 0x0d,0xbf,0x3a,0x0d,0x26,0x38,0x1a,0xf4, 0xeb,0xa4,0xa9,0x8e,0xaa,0x9b,0x4e,0x6a }; - const int loop_max=200; + const int loop_max=8; int save_use_ed = curve25519_use_ed; unsigned char e1[32], e2[32]; unsigned char x[32],y[32];

1 0

[tor/maint-0.3.5] Merge remote-tracking branch 'public/ticket28838_035' into maint-0.3.5
by nickm＠torproject.org 03 Jan '19

03 Jan '19

commit 98736cf36a1d8250e53a0c86a0b80fdb75f0d551 Merge: ed62f0fa1 041e9235c Author: Nick Mathewson <nickm(a)torproject.org> Date: Thu Jan 3 09:44:10 2019 -0500 Merge remote-tracking branch 'public/ticket28838_035' into maint-0.3.5 changes/ticket28838 | 8 ++++++++ src/lib/crypt_ops/crypto_curve25519.c | 2 +- 2 files changed, 9 insertions(+), 1 deletion(-)

1 0

[tor/master] Lower the loop_max constant in curve25519_basepoint_spot_check()
by nickm＠torproject.org 03 Jan '19

03 Jan '19

commit 041e9235c1710936a43f73d2f6e87bfc6e1c2242 Author: Nick Mathewson <nickm(a)torproject.org> Date: Thu Dec 13 11:26:09 2018 -0500 Lower the loop_max constant in curve25519_basepoint_spot_check() The point of this function is to make sure that the ed25519-based implementation of curve25519_basepoint() actually works when we start tor, and use the regular fallback implementation if it doesn't. But it accounts for 9% of our startup time in the case when we have directory information, and I think it's safe to make the test shorter. After all, it has yet to find any actual bugs in curved25519_scalarmult_basepoint_donna() on any platforms. Closes ticket 28838. --- changes/ticket28838 | 8 ++++++++ src/lib/crypt_ops/crypto_curve25519.c | 2 +- 2 files changed, 9 insertions(+), 1 deletion(-) diff --git a/changes/ticket28838 b/changes/ticket28838 new file mode 100644 index 000000000..6c290bf82 --- /dev/null +++ b/changes/ticket28838 @@ -0,0 +1,8 @@ + o Minor features (performance): + - Remove about 96% of the work from the function that we run at + startup to test our curve25519_basepoint implementation. Since + this function has yet to find an actual failure, we'll only + run it for 8 iterations instead of 200. Based on our profile + information, this change should save around 8% of our startup + time on typical desktops, and may have a similar effect on + other platforms. Closes ticket 28838. diff --git a/src/lib/crypt_ops/crypto_curve25519.c b/src/lib/crypt_ops/crypto_curve25519.c index e6a39a8c0..f3a9de9fc 100644 --- a/src/lib/crypt_ops/crypto_curve25519.c +++ b/src/lib/crypt_ops/crypto_curve25519.c @@ -289,7 +289,7 @@ curve25519_basepoint_spot_check(void) 0x0d,0xbf,0x3a,0x0d,0x26,0x38,0x1a,0xf4, 0xeb,0xa4,0xa9,0x8e,0xaa,0x9b,0x4e,0x6a }; - const int loop_max=200; + const int loop_max=8; int save_use_ed = curve25519_use_ed; unsigned char e1[32], e2[32]; unsigned char x[32],y[32];

1 0

[tor/master] Merge branch 'maint-0.3.5'
by nickm＠torproject.org 03 Jan '19

03 Jan '19

commit 47176eb6786bcde95505f44eef7a7c9cf67658b2 Merge: 27853938a 98736cf36 Author: Nick Mathewson <nickm(a)torproject.org> Date: Thu Jan 3 09:44:15 2019 -0500 Merge branch 'maint-0.3.5' changes/ticket28838 | 8 ++++++++ src/lib/crypt_ops/crypto_curve25519.c | 2 +- 2 files changed, 9 insertions(+), 1 deletion(-)

1 0

[tor/master] Merge remote-tracking branch 'public/ticket28838_035' into maint-0.3.5
by nickm＠torproject.org 03 Jan '19

03 Jan '19

commit 98736cf36a1d8250e53a0c86a0b80fdb75f0d551 Merge: ed62f0fa1 041e9235c Author: Nick Mathewson <nickm(a)torproject.org> Date: Thu Jan 3 09:44:10 2019 -0500 Merge remote-tracking branch 'public/ticket28838_035' into maint-0.3.5 changes/ticket28838 | 8 ++++++++ src/lib/crypt_ops/crypto_curve25519.c | 2 +- 2 files changed, 9 insertions(+), 1 deletion(-)

1 0

[tor/release-0.3.5] Lower the loop_max constant in curve25519_basepoint_spot_check()
by nickm＠torproject.org 03 Jan '19

03 Jan '19

commit 041e9235c1710936a43f73d2f6e87bfc6e1c2242 Author: Nick Mathewson <nickm(a)torproject.org> Date: Thu Dec 13 11:26:09 2018 -0500 Lower the loop_max constant in curve25519_basepoint_spot_check() The point of this function is to make sure that the ed25519-based implementation of curve25519_basepoint() actually works when we start tor, and use the regular fallback implementation if it doesn't. But it accounts for 9% of our startup time in the case when we have directory information, and I think it's safe to make the test shorter. After all, it has yet to find any actual bugs in curved25519_scalarmult_basepoint_donna() on any platforms. Closes ticket 28838. --- changes/ticket28838 | 8 ++++++++ src/lib/crypt_ops/crypto_curve25519.c | 2 +- 2 files changed, 9 insertions(+), 1 deletion(-) diff --git a/changes/ticket28838 b/changes/ticket28838 new file mode 100644 index 000000000..6c290bf82 --- /dev/null +++ b/changes/ticket28838 @@ -0,0 +1,8 @@ + o Minor features (performance): + - Remove about 96% of the work from the function that we run at + startup to test our curve25519_basepoint implementation. Since + this function has yet to find an actual failure, we'll only + run it for 8 iterations instead of 200. Based on our profile + information, this change should save around 8% of our startup + time on typical desktops, and may have a similar effect on + other platforms. Closes ticket 28838. diff --git a/src/lib/crypt_ops/crypto_curve25519.c b/src/lib/crypt_ops/crypto_curve25519.c index e6a39a8c0..f3a9de9fc 100644 --- a/src/lib/crypt_ops/crypto_curve25519.c +++ b/src/lib/crypt_ops/crypto_curve25519.c @@ -289,7 +289,7 @@ curve25519_basepoint_spot_check(void) 0x0d,0xbf,0x3a,0x0d,0x26,0x38,0x1a,0xf4, 0xeb,0xa4,0xa9,0x8e,0xaa,0x9b,0x4e,0x6a }; - const int loop_max=200; + const int loop_max=8; int save_use_ed = curve25519_use_ed; unsigned char e1[32], e2[32]; unsigned char x[32],y[32];

1 0

[tor/release-0.3.5] Merge remote-tracking branch 'public/ticket28838_035' into maint-0.3.5
by nickm＠torproject.org 03 Jan '19

03 Jan '19

commit 98736cf36a1d8250e53a0c86a0b80fdb75f0d551 Merge: ed62f0fa1 041e9235c Author: Nick Mathewson <nickm(a)torproject.org> Date: Thu Jan 3 09:44:10 2019 -0500 Merge remote-tracking branch 'public/ticket28838_035' into maint-0.3.5 changes/ticket28838 | 8 ++++++++ src/lib/crypt_ops/crypto_curve25519.c | 2 +- 2 files changed, 9 insertions(+), 1 deletion(-)

1 0

[tor/release-0.3.5] Merge branch 'maint-0.3.5' into release-0.3.5
by nickm＠torproject.org 03 Jan '19

03 Jan '19

commit aeb3f460975e019ac3f1896e2ecf250c52324ae2 Merge: 55474b9d9 98736cf36 Author: Nick Mathewson <nickm(a)torproject.org> Date: Thu Jan 3 09:44:15 2019 -0500 Merge branch 'maint-0.3.5' into release-0.3.5 changes/ticket28838 | 8 ++++++++ src/lib/crypt_ops/crypto_curve25519.c | 2 +- 2 files changed, 9 insertions(+), 1 deletion(-)

1 0