January 2019 - tor-commits - lists.torproject.org

[tor/master] Merge branch 'ticket28880'
by nickm＠torproject.org 04 Jan '19

04 Jan '19

commit 7232f04939f44146254c21086178c62cce1d3392 Merge: a7cbbf279 ce3d50104 Author: Nick Mathewson <nickm(a)torproject.org> Date: Thu Jan 3 21:33:40 2019 -0500 Merge branch 'ticket28880' src/test/test_config.c | 2 ++ src/test/test_hs_service.c | 7 +++++-- src/test/test_shared_random.c | 1 + 3 files changed, 8 insertions(+), 2 deletions(-)

1 0

[tor/master] Fix null-pointer-deref warning from scan-build in test_hs_service.c
by nickm＠torproject.org 04 Jan '19

04 Jan '19

commit ce3d501040fb994bb3c7dd82b21e02648621d3f1 Author: Nick Mathewson <nickm(a)torproject.org> Date: Mon Dec 17 09:28:24 2018 -0500 Fix null-pointer-deref warning from scan-build in test_hs_service.c --- src/test/test_hs_service.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/test/test_hs_service.c b/src/test/test_hs_service.c index 79cbd2e5d..b2aafc1cd 100644 --- a/src/test/test_hs_service.c +++ b/src/test/test_hs_service.c @@ -1654,6 +1654,9 @@ test_build_descriptors(void *arg) service->desc_current = NULL; build_all_descriptors(now); + tt_assert(service->desc_current); + tt_assert(service->desc_current->desc); + hs_desc_superencrypted_data_t *superencrypted; superencrypted = &service->desc_current->desc->superencrypted_data; tt_int_op(smartlist_len(superencrypted->clients), OP_EQ, 16);

1 0

[tor/master] Fix dead-assignment warning in test_shared_random.c
by nickm＠torproject.org 04 Jan '19

04 Jan '19

commit f50558ce8ce33339b86ac642d92a27430e066d62 Author: Nick Mathewson <nickm(a)torproject.org> Date: Mon Dec 17 09:27:40 2018 -0500 Fix dead-assignment warning in test_shared_random.c --- src/test/test_shared_random.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/test/test_shared_random.c b/src/test/test_shared_random.c index 433661f12..16e28afaf 100644 --- a/src/test/test_shared_random.c +++ b/src/test/test_shared_random.c @@ -309,6 +309,7 @@ test_get_start_time_of_current_run(void *arg) retval = parse_rfc1123_time("Mon, 19 Apr 2015 23:00:00 UTC", &mock_consensus.valid_after); + tt_int_op(retval, OP_EQ, 0); retval = parse_rfc1123_time("Mon, 20 Apr 2015 00:08:00 UTC", &current_time);

1 0

[tor/master] Remove a needless memset() in get_token_arguments()
by nickm＠torproject.org 04 Jan '19

04 Jan '19

commit 9dc53bc68f5e038c9531e3b12a58026d4007f652 Author: Nick Mathewson <nickm(a)torproject.org> Date: Fri Dec 14 14:48:12 2018 -0500 Remove a needless memset() in get_token_arguments() I believe we originally added this for "just in case" safety, but it isn't actually needed -- we never copy uninitialized stack here. What's more, this one memset is showing up on our startup profiles, so we ought to remove it. Closes ticket 28852. --- changes/ticket28852 | 4 ++++ src/feature/dirparse/parsecommon.c | 1 - 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/changes/ticket28852 b/changes/ticket28852 new file mode 100644 index 000000000..a58cc3ba0 --- /dev/null +++ b/changes/ticket28852 @@ -0,0 +1,4 @@ + o Minor features (performance): + - Remove a needless memset() call from get_token_arguments, + thereby speeding up the tokenization of directory objects by about + 20%. Closes ticket 28852. diff --git a/src/feature/dirparse/parsecommon.c b/src/feature/dirparse/parsecommon.c index e00af0eea..5280f2ed2 100644 --- a/src/feature/dirparse/parsecommon.c +++ b/src/feature/dirparse/parsecommon.c @@ -169,7 +169,6 @@ get_token_arguments(memarea_t *area, directory_token_t *tok, char *cp = mem; int j = 0; char *args[MAX_ARGS]; - memset(args, 0, sizeof(args)); while (*cp) { if (j == MAX_ARGS) return -1;

1 0

[tor/master] Merge branch 'ticket28852'
by nickm＠torproject.org 04 Jan '19

04 Jan '19

commit a7cbbf279ef8ab727ff3603940575c6d948985dc Merge: 4e4f93d36 9dc53bc68 Author: Nick Mathewson <nickm(a)torproject.org> Date: Thu Jan 3 21:31:08 2019 -0500 Merge branch 'ticket28852' changes/ticket28852 | 4 ++++ src/feature/dirparse/parsecommon.c | 1 - 2 files changed, 4 insertions(+), 1 deletion(-)

1 0

[translation/tails-greeter-2] Update translations for tails-greeter-2
by translation＠torproject.org 03 Jan '19

03 Jan '19

commit 54631aeb18a89de9f247f61a8ccd91b73d323dad Author: Translation commit bot <translation(a)torproject.org> Date: Thu Jan 3 22:46:31 2019 +0000 Update translations for tails-greeter-2 --- az/az.po | 22 ++++++++++++++-------- 1 file changed, 14 insertions(+), 8 deletions(-) diff --git a/az/az.po b/az/az.po index 0ba868322..dd28f5f10 100644 --- a/az/az.po +++ b/az/az.po @@ -3,14 +3,20 @@ # This file is distributed under the same license as the PACKAGE package. # FIRST AUTHOR <EMAIL@ADDRESS>, YEAR. # +# Translators: +# fiore <salimova.gulnar(a)gmail.com>, 2017 +# D, 2018 +# Nikafn <appone6(a)gmail.com>, 2018 +# ferhad.necef, 2019 +# #, fuzzy msgid "" msgstr "" "Project-Id-Version: PACKAGE VERSION\n" "Report-Msgid-Bugs-To: \n" -"POT-Creation-Date: 2018-01-22 14:15+0100\n" -"PO-Revision-Date: YEAR-MO-DA HO:MI+ZONE\n" -"Last-Translator: D, 2018\n" +"POT-Creation-Date: 2018-09-04 09:46+0200\n" +"PO-Revision-Date: 2016-11-18 21:29+0000\n" +"Last-Translator: ferhad.necef, 2019\n" "Language-Team: Azerbaijani (https://www.transifex.com/otf/teams/1519/az/)\n" "MIME-Version: 1.0\n" "Content-Type: text/plain; charset=UTF-8\n" @@ -235,7 +241,7 @@ msgstr "" #: ../tailsgreeter/gui.py:397 msgid "Offline" -msgstr "" +msgstr "Offline" #: ../tailsgreeter/gui.py:481 msgid "Failed to relock persistent storage." @@ -275,14 +281,14 @@ msgstr "" msgid "default:LTR" msgstr "" -#: ../tailsgreeter/persistence.py:89 +#: ../tailsgreeter/persistence.py:91 #, python-brace-format msgid "" "live-persist failed with return code {returncode}:\n" "{stderr}" msgstr "" -#: ../tailsgreeter/persistence.py:122 ../tailsgreeter/persistence.py:139 +#: ../tailsgreeter/persistence.py:124 ../tailsgreeter/persistence.py:141 #, python-brace-format msgid "" "cryptsetup failed with return code {returncode}:\n" @@ -290,7 +296,7 @@ msgid "" "{stderr}" msgstr "" -#: ../tailsgreeter/persistence.py:156 +#: ../tailsgreeter/persistence.py:158 #, python-brace-format msgid "" "live-persist failed with return code {returncode}:\n" @@ -298,7 +304,7 @@ msgid "" "{stderr}" msgstr "" -#: ../tailsgreeter/persistence.py:170 +#: ../tailsgreeter/persistence.py:172 #, python-brace-format msgid "" "umount failed with return code {returncode}:\n"

1 0

[nyx/master] Voluminous content slowed interpreter panel
by atagar＠torproject.org 03 Jan '19

03 Jan '19

commit 6492a3a1676b3795d9179ff875fb879fe1383688 Author: Damian Johnson <atagar(a)torproject.org> Date: Thu Jan 3 14:40:25 2019 -0800 Voluminous content slowed interpreter panel Each refresh of our interpreter panel iterated over every line of its content, regardless of if it was visible or not. This is silly. Limiting the range the draw function consults to only what's visible. Caught thanks to wagon... https://trac.torproject.org/projects/tor/ticket/28902 --- nyx/panel/interpreter.py | 14 +++++++++----- web/changelog/index.html | 6 ++++++ 2 files changed, 15 insertions(+), 5 deletions(-) diff --git a/nyx/panel/interpreter.py b/nyx/panel/interpreter.py index aa57d29..0a4209d 100644 --- a/nyx/panel/interpreter.py +++ b/nyx/panel/interpreter.py @@ -130,9 +130,13 @@ class InterpreterPanel(nyx.panel.Panel): self._x_offset = 2 subwindow.scrollbar(1, scroll, len(self._lines) + 1) - for i, line in enumerate(self._lines + [prompt]): - x, y = self._x_offset, i + 1 - scroll + visible_lines = self._lines[scroll:scroll + subwindow.height - 1] - if y > 0: - for text, attr in line: - x = subwindow.addstr(x, y, text, *attr) + if len(visible_lines) < subwindow.height - 1: + visible_lines.append(prompt) + + for y, line in enumerate(visible_lines): + x = self._x_offset + + for text, attr in line: + x = subwindow.addstr(x, y + 1, text, *attr) diff --git a/web/changelog/index.html b/web/changelog/index.html index 0bbc01a..8041655 100644 --- a/web/changelog/index.html +++ b/web/changelog/index.html @@ -112,6 +112,12 @@ </ul> </li> + <li>Interpreter + <ul> + <li>Large amounts of content made panel sluggish (<a href="https://trac.torproject.org/projects/tor/ticket/28902">ticket</a>)</li> + </ul> + </li> + <li>Curses <ul> <li>Resizing could crash the interface (<a href="https://trac.torproject.org/projects/tor/ticket/24382">ticket</a>)</li>

1 0

[nyx/master] More strictly scrub connections as private
by atagar＠torproject.org 03 Jan '19

03 Jan '19

commit 9204c77be8100f9327468e6e072923b96d17b377 Author: Damian Johnson <atagar(a)torproject.org> Date: Thu Jan 3 13:58:47 2019 -0800 More strictly scrub connections as private Teor made a great point that even if we aren't configured to receive client traffic (ie, not a bridge or guard) we can still receive sensitive connections... https://trac.torproject.org/projects/tor/ticket/27475 https://lists.torproject.org/pipermail/tor-relays/2018-September/016153.html No longer checking our bridge/guard status and simply censoring connections if they don't belong to a relay in the consensus. --- nyx/panel/connection.py | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/nyx/panel/connection.py b/nyx/panel/connection.py index 40fce88..f306278 100644 --- a/nyx/panel/connection.py +++ b/nyx/panel/connection.py @@ -232,10 +232,7 @@ class ConnectionEntry(Entry): return True if self.get_type() == Category.INBOUND: - controller = tor_controller() - - if controller.is_user_traffic_allowed().inbound: - return len(nyx.tracker.get_consensus_tracker().get_relay_fingerprints(self._connection.remote_address)) == 0 + return len(nyx.tracker.get_consensus_tracker().get_relay_fingerprints(self._connection.remote_address)) == 0 elif self.get_type() == Category.EXIT: # DNS connections exiting us aren't private (since they're hitting our # resolvers). Everything else is.

1 0

[nyx/master] Correct tests with new '--interface :80' behavior
by atagar＠torproject.org 03 Jan '19

03 Jan '19

commit 74e4a518a432bae4f4f81ce599e7a115bcec9521 Author: Damian Johnson <atagar(a)torproject.org> Date: Thu Jan 3 14:02:15 2019 -0800 Correct tests with new '--interface :80' behavior Oops, commit 5453231 changed our argument parsing behavior in a way that broke our tests. --- test/arguments.py | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/test/arguments.py b/test/arguments.py index 5223af5..e9d6665 100644 --- a/test/arguments.py +++ b/test/arguments.py @@ -21,6 +21,9 @@ class TestArgumentParsing(unittest.TestCase): args = parse(['--interface', '80']) self.assertEqual((DEFAULT_ARGS['control_port'][0], 80), args.control_port) + args = parse(['--interface', ':80']) + self.assertEqual((DEFAULT_ARGS['control_port'][0], 80), args.control_port) + args = parse(['--socket', '/tmp/my_socket', '--config', '/tmp/my_config']) self.assertEqual('/tmp/my_socket', args.control_socket) self.assertEqual('/tmp/my_config', args.config) @@ -72,7 +75,6 @@ class TestArgumentParsing(unittest.TestCase): 'blarg', '127.0.0.1', '127.0.0.1:', - ':80', '400.0.0.1:80', '127.0.0.1:-5', '127.0.0.1:500000',

1 0

[webwml/master] fix our physical address yet again
by arma＠torproject.org 03 Jan '19

03 Jan '19

commit d2bf8fd59b6a998d10e3a9f470cab3526b838274 Author: Roger Dingledine <arma(a)torproject.org> Date: Thu Jan 3 16:42:19 2019 -0500 fix our physical address yet again (i did it the first time in commit 05b73e, but that got broken in commit e33a33. oops.) --- about/en/contact.wml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/about/en/contact.wml b/about/en/contact.wml index 7234f855..27613698 100644 --- a/about/en/contact.wml +++ b/about/en/contact.wml @@ -158,7 +158,7 @@ sub 4096R/C00942E4 2017-03-13 Should you need to reach us via old-fashioned mail, our mailing address is: <address>The Tor Project, Inc. -P.O. Box 4903 +217 First Ave South #4903 Seattle, WA 98194 USA </address>

1 0