September 2018 - tor-commits - lists.torproject.org

[tor/release-0.3.4] rust/protover: fix check for overlapping ranges
by nickm＠torproject.org 12 Sep '18

12 Sep '18

commit 03c4d0ab9cfb60ba036bb8e5fe980a5bd2551f7d Author: cypherpunks <cypherpunks(a)torproject.org> Date: Wed Sep 12 02:14:29 2018 +0000 rust/protover: fix check for overlapping ranges Closes ticket 27649. Bugfix on e6625113c98c281b0a649598d7daa347c28915e9. --- changes/bug27649 | 4 ++++ src/rust/protover/protoset.rs | 2 +- 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/changes/bug27649 b/changes/bug27649 new file mode 100644 index 000000000..6498e961e --- /dev/null +++ b/changes/bug27649 @@ -0,0 +1,4 @@ + o Minor bugfixes (rust): + - The protover rewrite in #24031 allowed repeated votes from the same + voter for the same protocol version to be counted multiple times in + protover_compute_vote(). Bugfix on 0.3.3.5-rc; fixes bug 27649. diff --git a/src/rust/protover/protoset.rs b/src/rust/protover/protoset.rs index 7e6f606a2..b99e1a99f 100644 --- a/src/rust/protover/protoset.rs +++ b/src/rust/protover/protoset.rs @@ -174,7 +174,7 @@ impl ProtoSet { if low == u32::MAX || high == u32::MAX { return Err(ProtoverError::ExceedsMax); } - if low < last_high { + if low <= last_high { return Err(ProtoverError::Overlap); } else if low > high { return Err(ProtoverError::LowGreaterThanHigh);

1 0

[tor/release-0.3.4] test/protover: remove version zero from tests
by nickm＠torproject.org 12 Sep '18

12 Sep '18

commit e9ef7d5ab42a8f896be92b9ed2c1818044b38f04 Author: cypherpunks <cypherpunks(a)torproject.org> Date: Sat Aug 18 16:54:09 2018 +0000 test/protover: remove version zero from tests This isn't legal according to dir-spec.txt. We can write separate tests for it if the spec is changed to make it legal. --- src/test/test_protover.c | 22 +++++++++++----------- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/src/test/test_protover.c b/src/test/test_protover.c index 0948cd564..fb374c728 100644 --- a/src/test/test_protover.c +++ b/src/test/test_protover.c @@ -290,13 +290,13 @@ test_protover_all_supported(void *arg) tor_free(msg); /* We shouldn't be able to DoS ourselves parsing a large range. */ - tt_assert(! protover_all_supported("Sleen=0-2147483648", &msg)); - tt_str_op(msg, OP_EQ, "Sleen=0-2147483648"); + tt_assert(! protover_all_supported("Sleen=1-2147483648", &msg)); + tt_str_op(msg, OP_EQ, "Sleen=1-2147483648"); tor_free(msg); /* This case is allowed. */ - tt_assert(! protover_all_supported("Sleen=0-4294967294", &msg)); - tt_str_op(msg, OP_EQ, "Sleen=0-4294967294"); + tt_assert(! protover_all_supported("Sleen=1-4294967294", &msg)); + tt_str_op(msg, OP_EQ, "Sleen=1-4294967294"); tor_free(msg); /* If we get a (barely) valid (but unsupported list, we say "yes, that's @@ -313,7 +313,7 @@ test_protover_all_supported(void *arg) /* If we get a completely unparseable list, protover_all_supported should * hit a fatal assertion for BUG(entries == NULL). */ tor_capture_bugs_(1); - tt_assert(protover_all_supported("Sleen=0-4294967295", &msg)); + tt_assert(protover_all_supported("Sleen=1-4294967295", &msg)); tor_end_capture_bugs_(); /* Protocol name too long */ @@ -548,11 +548,11 @@ test_protover_vote_roundtrip(void *args) { "Zn=4294967295-1", NULL }, { "Zn=4294967293-4294967295", NULL }, /* Will fail because of 4294967295. */ - { "Foo=1,3 Bar=3 Baz= Quux=9-12,14,15-16,900 Zn=0,4294967295", + { "Foo=1,3 Bar=3 Baz= Quux=9-12,14,15-16,900 Zn=1,4294967295", NULL }, - { "Foo=1,3 Bar=3 Baz= Quux=9-12,14,15-16,900 Zn=0,4294967294", - "Bar=3 Foo=1,3 Quux=9-12,14-16,900 Zn=0,4294967294" }, - { "Zu16=0,65536", "Zu16=0,65536" }, + { "Foo=1,3 Bar=3 Baz= Quux=9-12,14,15-16,900 Zn=1,4294967294", + "Bar=3 Foo=1,3 Quux=9-12,14-16,900 Zn=1,4294967294" }, + { "Zu16=1,65536", "Zu16=1,65536" }, { "N-1=1,2", "N-1=1-2" }, { "-1=4294967295", NULL }, { "-1=3", "-1=3" }, @@ -581,9 +581,9 @@ test_protover_vote_roundtrip(void *args) { "Sleen=1-501", "Sleen=1-501" }, { "Sleen=1-65537", NULL }, /* Both C/Rust implementations should be able to handle this mild DoS. */ - { "Sleen=0-2147483648", NULL }, + { "Sleen=1-2147483648", NULL }, /* Rust tests are built in debug mode, so ints are bounds-checked. */ - { "Sleen=0-4294967295", NULL }, + { "Sleen=1-4294967295", NULL }, }; unsigned u; smartlist_t *votes = smartlist_new();

1 0

[tor/release-0.3.4] fixup! changes file
by nickm＠torproject.org 12 Sep '18

12 Sep '18

commit 4fa46fca8e71e085883dab6183df498759bc439f Author: cypherpunks <cypherpunks(a)torproject.org> Date: Wed Sep 12 14:22:31 2018 +0000 fixup! changes file --- changes/bug27649 | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/changes/bug27649 b/changes/bug27649 index 6498e961e..55bfc3a84 100644 --- a/changes/bug27649 +++ b/changes/bug27649 @@ -1,4 +1,4 @@ o Minor bugfixes (rust): - - The protover rewrite in #24031 allowed repeated votes from the same + - The protover rewrite in 24031 allowed repeated votes from the same voter for the same protocol version to be counted multiple times in - protover_compute_vote(). Bugfix on 0.3.3.5-rc; fixes bug 27649. + protover_compute_vote(). Fixes bug 27649; bugfix on 0.3.3.5-rc.

1 0

[tor/release-0.3.4] Merge branch 'maint-0.3.4' into release-0.3.4
by nickm＠torproject.org 12 Sep '18

12 Sep '18

commit 04f210811e1ea32abdd4d610c01db0ad084d6952 Merge: 204a90c93 f8d5fb42a Author: Nick Mathewson <nickm(a)torproject.org> Date: Wed Sep 12 17:24:41 2018 -0400 Merge branch 'maint-0.3.4' into release-0.3.4 changes/bug27649 | 4 ++++ src/rust/protover/protoset.rs | 17 ++++++++--------- src/rust/protover/protover.rs | 4 ++-- src/rust/protover/tests/protover.rs | 14 +++++++------- src/test/test_protover.c | 22 +++++++++++----------- 5 files changed, 32 insertions(+), 29 deletions(-)

1 0

[tor/release-0.3.4] Merge branch 'maint-0.3.3' into maint-0.3.4
by nickm＠torproject.org 12 Sep '18

12 Sep '18

commit f8d5fb42a392a764da9f46102583ea2dff960939 Merge: 73ba308d3 4fa46fca8 Author: Nick Mathewson <nickm(a)torproject.org> Date: Wed Sep 12 17:24:41 2018 -0400 Merge branch 'maint-0.3.3' into maint-0.3.4 changes/bug27649 | 4 ++++ src/rust/protover/protoset.rs | 17 ++++++++--------- src/rust/protover/protover.rs | 4 ++-- src/rust/protover/tests/protover.rs | 14 +++++++------- src/test/test_protover.c | 22 +++++++++++----------- 5 files changed, 32 insertions(+), 29 deletions(-)

1 0

[translation/torcheck_completed] Update translations for torcheck_completed
by translation＠torproject.org 12 Sep '18

12 Sep '18

commit dfe3150e95623f3a1f758cb5f04d1d44354c4f19 Author: Translation commit bot <translation(a)torproject.org> Date: Wed Sep 12 21:18:39 2018 +0000 Update translations for torcheck_completed --- hu/torcheck.po | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/hu/torcheck.po b/hu/torcheck.po index 966ae4b00..9df040aeb 100644 --- a/hu/torcheck.po +++ b/hu/torcheck.po @@ -6,13 +6,13 @@ # Blackywantscookies, 2014 # Lajos Pasztor <mrlajos(a)gmail.com>, 2014 # benewfy <benewfy(a)gmail.com>, 2015 -# vargaviktor <viktor.varga(a)gmail.com>, 2015 +# vargaviktor <viktor.varga(a)gmail.com>, 2015,2018 # vargaviktor <viktor.varga(a)gmail.com>, 2012 msgid "" msgstr "" "Project-Id-Version: The Tor Project\n" "POT-Creation-Date: 2012-02-16 20:28+PDT\n" -"PO-Revision-Date: 2018-09-12 20:48+0000\n" +"PO-Revision-Date: 2018-09-12 20:49+0000\n" "Last-Translator: vargaviktor <viktor.varga(a)gmail.com>\n" "Language-Team: Hungarian (http://www.transifex.com/otf/torproject/language/hu/)\n" "MIME-Version: 1.0\n" @@ -72,7 +72,7 @@ msgstr "Tovább információ erről a exit relay itt:" msgid "" "The Tor Project is a US 501(c)(3) non-profit dedicated to the research, " "development, and education of online anonymity and privacy." -msgstr "A Tor Project egy a US 501(c)(3) szerinti non-profit, amely kutatással, fejéesztéssel és oktatással foglakozik az online anonimitás és személyes adatvédelem területén." +msgstr "A Tor Project egy a US 501(c)(3) szerinti non-profit, amely kutatással, fejlesztéssel és oktatással foglakozik az online anonimitás és személyes adatvédelem területén." msgid "Learn More »" msgstr "Tanulj többet »"

1 0

[translation/torcheck] Update translations for torcheck
by translation＠torproject.org 12 Sep '18

12 Sep '18

commit 170fcca4da8984949d1d90fe8ab9eb3c3ebad844 Author: Translation commit bot <translation(a)torproject.org> Date: Wed Sep 12 21:18:34 2018 +0000 Update translations for torcheck --- hu/torcheck.po | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/hu/torcheck.po b/hu/torcheck.po index 966ae4b00..9df040aeb 100644 --- a/hu/torcheck.po +++ b/hu/torcheck.po @@ -6,13 +6,13 @@ # Blackywantscookies, 2014 # Lajos Pasztor <mrlajos(a)gmail.com>, 2014 # benewfy <benewfy(a)gmail.com>, 2015 -# vargaviktor <viktor.varga(a)gmail.com>, 2015 +# vargaviktor <viktor.varga(a)gmail.com>, 2015,2018 # vargaviktor <viktor.varga(a)gmail.com>, 2012 msgid "" msgstr "" "Project-Id-Version: The Tor Project\n" "POT-Creation-Date: 2012-02-16 20:28+PDT\n" -"PO-Revision-Date: 2018-09-12 20:48+0000\n" +"PO-Revision-Date: 2018-09-12 20:49+0000\n" "Last-Translator: vargaviktor <viktor.varga(a)gmail.com>\n" "Language-Team: Hungarian (http://www.transifex.com/otf/torproject/language/hu/)\n" "MIME-Version: 1.0\n" @@ -72,7 +72,7 @@ msgstr "Tovább információ erről a exit relay itt:" msgid "" "The Tor Project is a US 501(c)(3) non-profit dedicated to the research, " "development, and education of online anonymity and privacy." -msgstr "A Tor Project egy a US 501(c)(3) szerinti non-profit, amely kutatással, fejéesztéssel és oktatással foglakozik az online anonimitás és személyes adatvédelem területén." +msgstr "A Tor Project egy a US 501(c)(3) szerinti non-profit, amely kutatással, fejlesztéssel és oktatással foglakozik az online anonimitás és személyes adatvédelem területén." msgid "Learn More »" msgstr "Tanulj többet »"

1 0

[translation/torbutton-browseronboardingproperties] Update translations for torbutton-browseronboardingproperties
by translation＠torproject.org 12 Sep '18

12 Sep '18

commit 89f871ccab02d1051667e2cb49b3630530a6e8b3 Author: Translation commit bot <translation(a)torproject.org> Date: Wed Sep 12 21:18:26 2018 +0000 Update translations for torbutton-browseronboardingproperties --- hu/browserOnboarding.properties | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hu/browserOnboarding.properties b/hu/browserOnboarding.properties index bcebc628e..ae88c3720 100644 --- a/hu/browserOnboarding.properties +++ b/hu/browserOnboarding.properties @@ -25,7 +25,7 @@ onboarding.tour-tor-circuit-display.button=Megtekintem az útvonalam onboarding.tour-tor-security=Biztonság onboarding.tour-tor-security.title=Válassza ki élményét onboarding.tour-tor-security.description=We also provide you with additional settings for bumping up your browser security. Our Security Settings allow you to block elements that could be used to attack your computer. Click below to see what the different options do. -onboarding.tour-tor-security.button=Review Settings +onboarding.tour-tor-security.button=Beállítások áttekintése onboarding.tour-tor-expect-differences=Experience Tips onboarding.tour-tor-expect-differences.title=Expect some differences.

1 0

[translation/torbirdy_completed] Update translations for torbirdy_completed
by translation＠torproject.org 12 Sep '18

12 Sep '18

commit 54adf1d887cd581ca1274b5eec67b3329d7a2b8b Author: Translation commit bot <translation(a)torproject.org> Date: Wed Sep 12 21:17:29 2018 +0000 Update translations for torbirdy_completed --- hu/torbirdy.dtd | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hu/torbirdy.dtd b/hu/torbirdy.dtd index 8ec4ae90e..2b07613a2 100644 --- a/hu/torbirdy.dtd +++ b/hu/torbirdy.dtd @@ -29,7 +29,7 @@ <!ENTITY torbirdy.prefs.socks_host.key "g"> <!ENTITY torbirdy.prefs.socks_port.label "Port: "> <!ENTITY torbirdy.prefs.socks_port.key "p"> -<!ENTITY torbirdy.prefs.torification.label "Átlátszó Torosítás"> +<!ENTITY torbirdy.prefs.torification.label "Átlátszó Torosítás (Figyelem: egyedi transproxy-t vagy Tor routert igényel)"> <!ENTITY torbirdy.prefs.torification.key "t"> <!ENTITY torbirdy.prefs.global "Globális"> <!ENTITY torbirdy.prefs.imap.label "A push támogatás bekapcsolása az IMAP fiókokhoz [alapértelmezett: kikapcsolva]">

1 0

[translation/torbirdy] Update translations for torbirdy
by translation＠torproject.org 12 Sep '18

12 Sep '18

commit bd42fbbf6349de2d843c0af0528f41dd9c1968fe Author: Translation commit bot <translation(a)torproject.org> Date: Wed Sep 12 21:17:22 2018 +0000 Update translations for torbirdy --- hu/torbirdy.dtd | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hu/torbirdy.dtd b/hu/torbirdy.dtd index 8ec4ae90e..2b07613a2 100644 --- a/hu/torbirdy.dtd +++ b/hu/torbirdy.dtd @@ -29,7 +29,7 @@ <!ENTITY torbirdy.prefs.socks_host.key "g"> <!ENTITY torbirdy.prefs.socks_port.label "Port: "> <!ENTITY torbirdy.prefs.socks_port.key "p"> -<!ENTITY torbirdy.prefs.torification.label "Átlátszó Torosítás"> +<!ENTITY torbirdy.prefs.torification.label "Átlátszó Torosítás (Figyelem: egyedi transproxy-t vagy Tor routert igényel)"> <!ENTITY torbirdy.prefs.torification.key "t"> <!ENTITY torbirdy.prefs.global "Globális"> <!ENTITY torbirdy.prefs.imap.label "A push támogatás bekapcsolása az IMAP fiókokhoz [alapértelmezett: kikapcsolva]">

1 0