tor-commits November 2018

tor-commits@lists.torproject.org

19 participants
2292 discussions

[tor/release-0.3.4] hs-v3: Close all SOCKS request on descriptor failure
by nickm＠torproject.org 02 Nov '18

02 Nov '18

commit fa6d5dd2686d9fedfbbea9bdf0d7dab1a7afc7c4 Author: David Goulet <dgoulet(a)torproject.org> Date: Wed Sep 19 10:56:15 2018 -0400 hs-v3: Close all SOCKS request on descriptor failure Client side, when a descriptor is finally fetched and stored in the cache, we then go over all pending SOCKS request for that descriptor. If it turns out that the intro points are unusable, we close the first SOCKS request but not the others for the same .onion. This commit makes it that we'll close all SOCKS requests so we don't let hanging the other ones. It also fixes another bug which is having a SOCKS connection in RENDDESC_WAIT state but with a descriptor in the cache. At some point, tor will expire the intro failure cache which will make that descriptor usable again. When retrying all SOCKS connection (retry_all_socks_conn_waiting_for_desc()), we won't end up in the code path where we have already the descriptor for a pending request causing a BUG(). Bottom line is that we should never have pending requests (waiting for a descriptor) with that descriptor in the cache (even if unusable). Fixees #27410. Signed-off-by: David Goulet <dgoulet(a)torproject.org> --- changes/ticket27410 | 5 +++++ src/or/hs_client.c | 2 +- 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/changes/ticket27410 b/changes/ticket27410 new file mode 100644 index 000000000..a21fdde58 --- /dev/null +++ b/changes/ticket27410 @@ -0,0 +1,5 @@ + o Minor bugfixes (hidden service v3): + - Close all SOCKS request (for the same .onion) if the newly fetched + descriptor is unusable. Before that, we would close only the first one + leaving the other hanging and let to time out by themselves. Fixes bug + 27410; bugfix on 0.3.2.1-alpha. diff --git a/src/or/hs_client.c b/src/or/hs_client.c index 4e2824c13..fb21e6f20 100644 --- a/src/or/hs_client.c +++ b/src/or/hs_client.c @@ -1423,7 +1423,7 @@ hs_client_desc_has_arrived(const hs_ident_dir_conn_t *ident) /* We are unable to use the descriptor so remove the directory request * from the cache so the next connection can try again. */ note_connection_attempt_succeeded(edge_conn->hs_ident); - goto end; + continue; } log_info(LD_REND, "Descriptor has arrived. Launching circuits.");

1 0

[tor/release-0.3.4] Merge branch 'bug26896_034' into maint-0.3.4
by nickm＠torproject.org 02 Nov '18

02 Nov '18

commit f288f2478a5d455cd151e8fd13fe3ed66dfd75e5 Merge: 8ed4f1ee8 21a9d0344 Author: Nick Mathewson <nickm(a)torproject.org> Date: Fri Nov 2 09:05:14 2018 -0400 Merge branch 'bug26896_034' into maint-0.3.4 changes/bug26896 | 3 +++ src/or/directory.c | 4 +++- 2 files changed, 6 insertions(+), 1 deletion(-)

1 0

[tor/release-0.3.4] Merge remote-tracking branch 'dgoulet/ticket27410_032_01' into maint-0.3.3
by nickm＠torproject.org 02 Nov '18

02 Nov '18

commit e847909b71333690d3fb9a31a738ea3c1ab6d1e1 Merge: bcc1a7180 fa6d5dd26 Author: Nick Mathewson <nickm(a)torproject.org> Date: Fri Nov 2 09:04:20 2018 -0400 Merge remote-tracking branch 'dgoulet/ticket27410_032_01' into maint-0.3.3 changes/ticket27410 | 5 +++++ src/or/hs_client.c | 2 +- 2 files changed, 6 insertions(+), 1 deletion(-)

1 0

[tor/release-0.3.4] Merge branch 'maint-0.3.3' into maint-0.3.4
by nickm＠torproject.org 02 Nov '18

02 Nov '18

commit 8ed4f1ee8418eaafcb6314f093d1186d711a837e Merge: 158db532e e847909b7 Author: Nick Mathewson <nickm(a)torproject.org> Date: Fri Nov 2 09:04:25 2018 -0400 Merge branch 'maint-0.3.3' into maint-0.3.4 changes/ticket27410 | 5 +++++ src/or/hs_client.c | 2 +- 2 files changed, 6 insertions(+), 1 deletion(-)

1 0

[tor/release-0.3.4] Merge branch 'maint-0.3.4' into release-0.3.4
by nickm＠torproject.org 02 Nov '18

02 Nov '18

commit 1ace56149546e7f99a205b14e5086f8924102ae5 Merge: e160fc57f 8ed4f1ee8 Author: Nick Mathewson <nickm(a)torproject.org> Date: Fri Nov 2 09:04:25 2018 -0400 Merge branch 'maint-0.3.4' into release-0.3.4 changes/ticket27410 | 5 +++++ src/or/hs_client.c | 2 +- 2 files changed, 6 insertions(+), 1 deletion(-)

1 0

[tor/release-0.3.4] Merge branch 'maint-0.3.4' into release-0.3.4
by nickm＠torproject.org 02 Nov '18

02 Nov '18

commit 1c5e7430efbc3bb03596957d454c9ff6825de67b Merge: 1ace56149 f288f2478 Author: Nick Mathewson <nickm(a)torproject.org> Date: Fri Nov 2 09:05:18 2018 -0400 Merge branch 'maint-0.3.4' into release-0.3.4 changes/bug26896 | 3 +++ src/or/directory.c | 4 +++- 2 files changed, 6 insertions(+), 1 deletion(-)

1 0

[tor/release-0.3.5] Merge branch 'maint-0.3.4' into maint-0.3.5
by nickm＠torproject.org 02 Nov '18

02 Nov '18

commit a3fc93b8dd8558b741a5d2e3d322957fa9396875 Merge: d409565e3 f288f2478 Author: Nick Mathewson <nickm(a)torproject.org> Date: Fri Nov 2 09:05:18 2018 -0400 Merge branch 'maint-0.3.4' into maint-0.3.5

1 0

[tor/release-0.3.5] Merge branch 'maint-0.3.4' into maint-0.3.5
by nickm＠torproject.org 02 Nov '18

02 Nov '18

commit d409565e38d44c6f2fb08b4b2d37c76597e3d951 Merge: 0d124488f 8ed4f1ee8 Author: Nick Mathewson <nickm(a)torproject.org> Date: Fri Nov 2 09:04:25 2018 -0400 Merge branch 'maint-0.3.4' into maint-0.3.5

1 0

[tor/release-0.3.5] Merge remote-tracking branch 'dgoulet/ticket27410_032_01' into maint-0.3.3
by nickm＠torproject.org 02 Nov '18

02 Nov '18

1 0

[tor/release-0.3.5] Merge branch 'maint-0.3.3' into maint-0.3.4
by nickm＠torproject.org 02 Nov '18

02 Nov '18

1 0

Jump to page:

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

tor-commits November 2018