tor-commits February 2017

tor-commits@lists.torproject.org

14 participants
1811 discussions

[metrics-web/master] Tweak two graph descriptions.
by karsten＠torproject.org 03 Feb '17

03 Feb '17

commit e855b6c25274e6968d7d267bb73f06e34ea89f31 Author: Karsten Loesing <karsten.loesing(a)gmx.net> Date: Fri Feb 3 21:21:55 2017 +0100 Tweak two graph descriptions. --- website/etc/categories.json | 2 +- website/etc/metrics.json | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/website/etc/categories.json b/website/etc/categories.json index acd0614..7c8bcbf 100644 --- a/website/etc/categories.json +++ b/website/etc/categories.json @@ -4,7 +4,7 @@ "icon": "fa-users", "header": "Users", "summary": "Where Tor users are from and how they connect to Tor.", - "description": "We estimate the number of users by analyzing the requests induced by Tor clients. These papers detail on how we count users and how we count bridge users.", + "description": "We estimate the number of users by analyzing the requests induced by clients to relays and bridges.", "metrics": [ "userstats-relay-country", "userstats-bridge-country", diff --git a/website/etc/metrics.json b/website/etc/metrics.json index 3eb000c..a335640 100644 --- a/website/etc/metrics.json +++ b/website/etc/metrics.json @@ -421,7 +421,7 @@ "id": "webstats-tb-platform", "title": "Tor Browser downloads by platform", "type": "Graph", - "description": "This graph shows absolute numbers of requests to Tor's web servers to download a Tor Browser executable, broken down by platform (Windows, Mac, Linux) of the requested executable.", + "description": "This graph shows absolute numbers of requests to Tor's web servers to download a Tor Browser executable, broken down by platform (Windows, Mac, Linux) of the requested executable. Note that this graph does not show the platform used to download Tor Browser but the platform that it was downloaded for.", "function": "plot_webstats_tb_platform", "parameters": [ "start",

1 0

[tor/master] Bump to 0.3.0.3-alpha-dev
by nickm＠torproject.org 03 Feb '17

03 Feb '17

commit 54ec335434727539a1c45d5d68cc787f9bc5f522 Author: Nick Mathewson <nickm(a)torproject.org> Date: Fri Feb 3 13:58:50 2017 -0500 Bump to 0.3.0.3-alpha-dev --- ChangeLog | 3 +++ configure.ac | 2 +- contrib/win32build/tor-mingw.nsi.in | 2 +- src/win32/orconfig.h | 2 +- 4 files changed, 6 insertions(+), 3 deletions(-) diff --git a/ChangeLog b/ChangeLog index df54659..7cc4f44 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,6 @@ +Changes in version 0.3.0.4-??? - 2017-02-?? + + Changes in version 0.3.0.3-alpha - 2017-02-03 Tor 0.3.0.3-alpha fixes a few significant bugs introduced over the 0.3.0.x development series, including some that could cause diff --git a/configure.ac b/configure.ac index 0d2dd06..c9e0c2a 100644 --- a/configure.ac +++ b/configure.ac @@ -4,7 +4,7 @@ dnl Copyright (c) 2007-2015, The Tor Project, Inc. dnl See LICENSE for licensing information AC_PREREQ([2.63]) -AC_INIT([tor],[0.3.0.3-alpha]) +AC_INIT([tor],[0.3.0.3-alpha-dev]) AC_CONFIG_SRCDIR([src/or/main.c]) AC_CONFIG_MACRO_DIR([m4]) diff --git a/contrib/win32build/tor-mingw.nsi.in b/contrib/win32build/tor-mingw.nsi.in index 93f75a9..62e8036 100644 --- a/contrib/win32build/tor-mingw.nsi.in +++ b/contrib/win32build/tor-mingw.nsi.in @@ -8,7 +8,7 @@ !include "LogicLib.nsh" !include "FileFunc.nsh" !insertmacro GetParameters -!define VERSION "0.3.0.3-alpha" +!define VERSION "0.3.0.3-alpha-dev" !define INSTALLER "tor-${VERSION}-win32.exe" !define WEBSITE "https://www.torproject.org/" !define LICENSE "LICENSE" diff --git a/src/win32/orconfig.h b/src/win32/orconfig.h index eeb870b..ec4d62b 100644 --- a/src/win32/orconfig.h +++ b/src/win32/orconfig.h @@ -218,7 +218,7 @@ #define USING_TWOS_COMPLEMENT /* Version number of package */ -#define VERSION "0.3.0.3-alpha" +#define VERSION "0.3.0.3-alpha-dev"

1 0

[webwml/master] Alpha is now 0.3.0.3-alpha
by nickm＠torproject.org 03 Feb '17

03 Feb '17

commit 45d157bb71c7da3fe5be9877bdcde9bdbd4c2b09 Author: Nick Mathewson <nickm(a)torproject.org> Date: Fri Feb 3 13:57:19 2017 -0500 Alpha is now 0.3.0.3-alpha --- Makefile | 2 +- include/versions.wmi | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/Makefile b/Makefile index cedf601..87149e3 100644 --- a/Makefile +++ b/Makefile @@ -15,7 +15,7 @@ # website component, and set it to needs_review. export STABLETAG=tor-0.2.9.9 -export DEVTAG=tor-0.3.0.2-alpha +export DEVTAG=tor-0.3.0.3-alpha WMLBASE=. SUBDIRS=docs eff projects press about download getinvolved donate docs/torbutton diff --git a/include/versions.wmi b/include/versions.wmi index 40d087c..d2e0da6 100644 --- a/include/versions.wmi +++ b/include/versions.wmi @@ -1,5 +1,5 @@ <define-tag version-stable whitespace=delete>0.2.9.9</define-tag> -<define-tag version-alpha whitespace=delete>0.3.0.2-alpha</define-tag> +<define-tag version-alpha whitespace=delete>0.3.0.3-alpha</define-tag> <define-tag version-win32-stable whitespace=delete>0.2.9.9</define-tag>

1 0

[tor/master] a few more changelog edits
by nickm＠torproject.org 03 Feb '17

03 Feb '17

commit bb2ea3642d54ff03d7d60e593113f4e64e9e07ab Author: Nick Mathewson <nickm(a)torproject.org> Date: Fri Feb 3 13:44:20 2017 -0500 a few more changelog edits --- ChangeLog | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/ChangeLog b/ChangeLog index f923d8a..df54659 100644 --- a/ChangeLog +++ b/ChangeLog @@ -11,7 +11,7 @@ Changes in version 0.3.0.3-alpha - 2017-02-03 test this release. o Major bugfixes (directory authority): - - During voting, when marking a node as a probable sybil, do not + - During voting, when marking a relay as a probable sybil, do not clear its BadExit flag: sybils can still be bad in other ways too. (We still clear the other flags.) Fixes bug 21108; bugfix on 0.2.0.13-alpha. @@ -47,7 +47,7 @@ Changes in version 0.3.0.3-alpha - 2017-02-03 o Minor features (ciphersuite selection): - Clients now advertise a list of ciphersuites closer to the ones preferred by Firefox. Closes part of ticket 15426. - - Allow servers to accept a wider range of ciphersuites, including + - Allow relays to accept a wider range of ciphersuites, including chacha20-poly1305 and AES-CCM. Closes the other part of 15426. o Minor features (controller, configuration): @@ -114,15 +114,15 @@ Changes in version 0.3.0.3-alpha - 2017-02-03 o Minor bugfixes (hidden service): - Clean up the code for expiring intro points with no associated circuits. It was causing, rarely, a service with some expiring - nodes to not open enough introduction points. Fixes part of bug - 21302; bugfix on 0.2.7.2-alpha. + introduction points to not open enough additional introduction + points. Fixes part of bug 21302; bugfix on 0.2.7.2-alpha. - Stop setting the torrc option HiddenServiceStatistics to "0" just because we're not a bridge or relay. Instead, we preserve whatever value the user set (or didn't set). Fixes bug 21150; bugfix on 0.2.6.2-alpha. - - Two possible underflow which would ultimately lead to creating a - lot of introduction point circuits and closing them in a non stop - loop. Fixes bug 21302; bugfix on 0.2.7.2-alpha. + - Resolve two possible underflows which could lead to creating and + closing a lot of introduction point circuits in a non-stop loop. + Fixes bug 21302; bugfix on 0.2.7.2-alpha. o Minor bugfixes (portability): - Use "OpenBSD" compiler macro instead of "OPENBSD" or "__OpenBSD__".

1 0

[tor/master] changelog fixes; thanks dgoulet!
by nickm＠torproject.org 03 Feb '17

03 Feb '17

commit 353f1235bcab90f312696550bef958e3cb671f55 Author: Nick Mathewson <nickm(a)torproject.org> Date: Fri Feb 3 13:29:16 2017 -0500 changelog fixes; thanks dgoulet! --- ChangeLog | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/ChangeLog b/ChangeLog index 7cfe1a2..f923d8a 100644 --- a/ChangeLog +++ b/ChangeLog @@ -19,7 +19,7 @@ Changes in version 0.3.0.3-alpha - 2017-02-03 do not penalize it for not having performed an Ed25519 link handshake if it does not claim to support an Ed25519 handshake. Previously, we would treat such relays as non-running. Fixes bug - 21107; bugfix on 0.2.3.1-alpha. + 21107; bugfix on 0.3.0.1-alpha. o Major bugfixes (entry guards): - Stop trying to build circuits through entry guards for which we @@ -77,7 +77,7 @@ Changes in version 0.3.0.3-alpha - 2017-02-03 o Minor bugfix (logging): - Don't recommend the use of Tor2web in non-anonymous mode. Recommending Tor2web is a bad idea because the client loses all - anonymity. Tor2web shouldy only be used in specific cases by users + anonymity. Tor2web should only be used in specific cases by users who *know* and understand the issues. Fixes bug 21294; bugfix on 0.2.9.3-alpha. @@ -121,7 +121,7 @@ Changes in version 0.3.0.3-alpha - 2017-02-03 value the user set (or didn't set). Fixes bug 21150; bugfix on 0.2.6.2-alpha. - Two possible underflow which would ultimately lead to creating a - lot of introduction points circuits and closing them in a non stop + lot of introduction point circuits and closing them in a non stop loop. Fixes bug 21302; bugfix on 0.2.7.2-alpha. o Minor bugfixes (portability): @@ -130,9 +130,9 @@ Changes in version 0.3.0.3-alpha - 2017-02-03 variants (such as Bitrig). Fixes bug 20980; bugfix on 0.1.2.1-alpha. - When mapping a file of length greater than SIZE_MAX, do not - silently its contents. This issue could occur on 32 bit systems - with large file support and files which are larger than 4 GB. - Fixes bug 21134; bugfix on 0.3.0.1-alpha. + silently truncate its contents. This issue could occur on 32 bit + systems with large file support and files which are larger than 4 + GB. Fixes bug 21134; bugfix on 0.3.0.1-alpha. o Minor bugfixes (tor-resolve): - The tor-resolve command line tool now rejects hostnames over 255

1 0

[tor/master] Fix "make distcheck".
by nickm＠torproject.org 03 Feb '17

03 Feb '17

commit 39606aece5753594bd492edfddbcdd6df13de442 Author: Nick Mathewson <nickm(a)torproject.org> Date: Fri Feb 3 12:04:08 2017 -0500 Fix "make distcheck". I had forgotten to include the fuzz_static_testcases.sh script in EXTRA_DIST. --- src/test/include.am | 1 + 1 file changed, 1 insertion(+) diff --git a/src/test/include.am b/src/test/include.am index 9f30443..1c0726f 100644 --- a/src/test/include.am +++ b/src/test/include.am @@ -271,6 +271,7 @@ src_test_test_bt_cl_CPPFLAGS= $(src_test_AM_CPPFLAGS) $(TEST_CPPFLAGS) EXTRA_DIST += \ src/test/bt_test.py \ src/test/ntor_ref.py \ + src/test/fuzz_static_testcases.sh \ src/test/slownacl_curve25519.py \ src/test/zero_length_keys.sh \ src/test/test_keygen.sh \

1 0

[tor/master] Add a blurb, edit the changelog
by nickm＠torproject.org 03 Feb '17

03 Feb '17

commit 7878668cab5076541eea36b904f268c664bb0e39 Author: Nick Mathewson <nickm(a)torproject.org> Date: Fri Feb 3 12:04:40 2017 -0500 Add a blurb, edit the changelog --- ChangeLog | 89 +++++++++++++++++++++++++++++++++++---------------------------- 1 file changed, 50 insertions(+), 39 deletions(-) diff --git a/ChangeLog b/ChangeLog index 62cf13d..7cfe1a2 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,5 +1,14 @@ Changes in version 0.3.0.3-alpha - 2017-02-03 - BLURB BLURB BLURB. + Tor 0.3.0.3-alpha fixes a few significant bugs introduced over the + 0.3.0.x development series, including some that could cause + authorities to behave badly. There is also a fix for a longstanding + bug that could prevent IPv6 exits from working. Tor 0.3.0.3-alpha also + includes some smaller features and bugfixes. + + The Tor 0.3.0.x release series is now in patch-freeze: no additional + features will be considered for inclusion in 0.3.0.x. We suspect that + some bugs will probably remain, however, and we encourage people to + test this release. o Major bugfixes (directory authority): - During voting, when marking a node as a probable sybil, do not @@ -14,20 +23,20 @@ Changes in version 0.3.0.3-alpha - 2017-02-03 o Major bugfixes (entry guards): - Stop trying to build circuits through entry guards for which we - have no descriptor yet. Also, stop crashing if we *do* + have no descriptor. Also, stop crashing in the case that we *do* accidentally try to build a circuit in such a state. Fixes bug 21242; bugfix on 0.3.0.1-alpha. o Major bugfixes (IPv6 Exits): - Stop rejecting all IPv6 traffic on Exits whose exit policy rejects - IPv6 addresses. Instead, only reject a port over IPv6 if the exit - policy rejects that port on more than an IPv6 /16 of addresses. - This bug was made worse by 17027 in 0.2.8.1-alpha, which rejects a - relay's own IPv6 address by default. Fixes bug 21357; bugfix on - commit 004f3f4e53 in 0.2.4.7-alpha. + any IPv6 addresses. Instead, only reject a port over IPv6 if the + exit policy rejects that port on more than an IPv6 /16 of + addresses. This bug was made worse by 17027 in 0.2.8.1-alpha, + which rejected a relay's own IPv6 address by default. Fixes bug + 21357; bugfix on commit 004f3f4e53 in 0.2.4.7-alpha. o Minor feature (client): - - Enable IPv6 traffic by default on the SocksPort. To disable this, + - Enable IPv6 traffic on the SocksPort by default. To disable this, a user will have to specify "NoIPv6Traffic". Closes ticket 21269. o Minor feature (fallback scripts): @@ -36,10 +45,10 @@ Changes in version 0.3.0.3-alpha - 2017-02-03 20174. Patch by haxxpop. o Minor features (ciphersuite selection): + - Clients now advertise a list of ciphersuites closer to the ones + preferred by Firefox. Closes part of ticket 15426. - Allow servers to accept a wider range of ciphersuites, including chacha20-poly1305 and AES-CCM. Closes the other part of 15426. - - Clients now advertise a list of ciphersuites closer to the ones - preferred by Firefox. Closes ticket 15426. o Minor features (controller, configuration): - Each of the *Port options, such as SocksPort, ORPort, ControlPort, @@ -53,23 +62,24 @@ Changes in version 0.3.0.3-alpha - 2017-02-03 in feature 20956. Implements ticket 21300. o Minor features (portability, compilation): - - Autoconf now check to determine if OpenSSL structures are opaque, + - Autoconf now checks to determine if OpenSSL structures are opaque, instead of explicitly checking for OpenSSL version numbers. Part of ticket 21359. - Support building with recent LibreSSL code that uses opaque structures. Closes ticket 21359. o Minor features (relay): - - Allow separation of exit and relay traffic to different source IP - addresses. Closes ticket 17975. Written by Michael Sonntag. + - We now allow separation of exit and relay traffic to different + source IP addresses, using the OutboundBindAddressExit and + OutboundBindAddressOR options respectively. Closes ticket 17975. + Written by Michael Sonntag. o Minor bugfix (logging): - - Don't recommend the use of Tor2web in non anonymous mode. In that - mode, we disable client functionalities and recommending Tor2web - as a solution is a bad idea because in that case client loses all - anonymity. Tor2web should really only be used in very specific - cases and with users *knowing* what they do. Fixes bug 21294; - bugfix on 0.2.9.3-alpha. + - Don't recommend the use of Tor2web in non-anonymous mode. + Recommending Tor2web is a bad idea because the client loses all + anonymity. Tor2web shouldy only be used in specific cases by users + who *know* and understand the issues. Fixes bug 21294; bugfix + on 0.2.9.3-alpha. o Minor bugfixes (client): - Always recover from failures in extend_info_from_node(), in an @@ -90,38 +100,39 @@ Changes in version 0.3.0.3-alpha - 2017-02-03 o Minor bugfixes (configure, autoconf): - Rename the configure option --enable-expensive-hardening to - --enable-fragile-hardening. TROVE-2017-001 was triggerable only - through the expensive hardening which is making the tor daemon - abort when the issue is detected. Thus, it makes tor more at risk - of remote crashes but safer against RCE or heartbleed bug - category. Fixes bug 21290; bugfix on 0.2.5.4-alpha. + --enable-fragile-hardening. Expensive hardening makes the tor + daemon abort when some kinds of issues are detected. Thus, it + makes tor more at risk of remote crashes but safer against RCE or + heartbleed bug category. We now try to explain this issue in a + message from the configure script. Fixes bug 21290; bugfix + on 0.2.5.4-alpha. o Minor bugfixes (controller): - Restore the (deprecated) DROPGUARDS controller command. Fixes bug 20824; bugfix on 0.3.0.1-alpha. o Minor bugfixes (hidden service): - - Cleanup expiring intro point nodes if no circuit is associated to - it anymore. It was causing, rarely, the service to not open enough - introduction points circuit in the case we had dead expiring - nodes.; bugfix on 0.2.7.2-alpha. - - Stop modifying the value of our torrc option - HiddenServiceStatistics just because we're not a bridge or relay. - Use an internal value for what tor should use and keep the torrc - option intact. Fixes bug 21150; bugfix on 0.2.6.2-alpha. + - Clean up the code for expiring intro points with no associated + circuits. It was causing, rarely, a service with some expiring + nodes to not open enough introduction points. Fixes part of bug + 21302; bugfix on 0.2.7.2-alpha. + - Stop setting the torrc option HiddenServiceStatistics to "0" just + because we're not a bridge or relay. Instead, we preserve whatever + value the user set (or didn't set). Fixes bug 21150; bugfix + on 0.2.6.2-alpha. - Two possible underflow which would ultimately lead to creating a lot of introduction points circuits and closing them in a non stop loop. Fixes bug 21302; bugfix on 0.2.7.2-alpha. o Minor bugfixes (portability): - - Use "OpenBSD" pre-defined compiler macro instead of "OPENBSD" or - "__OpenBSD__". It is supported by OpenBSD itself and also most - OpenBSD variants like Bitrig. Fixes bug 20980; bugfix + - Use "OpenBSD" compiler macro instead of "OPENBSD" or "__OpenBSD__". + It is supported by OpenBSD itself, and also by most OpenBSD + variants (such as Bitrig). Fixes bug 20980; bugfix on 0.1.2.1-alpha. - - Do not silently truncate content of files if they are larger than - SIZE_MAX bytes. This issue could occur on 32 bit systems with - large file support and files which are larger than 4 GB. Fixes bug - 21134; bugfix on 0.3.0.1-alpha. + - When mapping a file of length greater than SIZE_MAX, do not + silently its contents. This issue could occur on 32 bit systems + with large file support and files which are larger than 4 GB. + Fixes bug 21134; bugfix on 0.3.0.1-alpha. o Minor bugfixes (tor-resolve): - The tor-resolve command line tool now rejects hostnames over 255

1 0

[tor/master] Bump version to 0.3.0.3-alpha
by nickm＠torproject.org 03 Feb '17

03 Feb '17

commit 80a5beae624abf3774fc66034707472a0eb94cd9 Author: Nick Mathewson <nickm(a)torproject.org> Date: Fri Feb 3 11:33:11 2017 -0500 Bump version to 0.3.0.3-alpha --- configure.ac | 2 +- contrib/win32build/tor-mingw.nsi.in | 2 +- src/win32/orconfig.h | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/configure.ac b/configure.ac index bad21e3..0d2dd06 100644 --- a/configure.ac +++ b/configure.ac @@ -4,7 +4,7 @@ dnl Copyright (c) 2007-2015, The Tor Project, Inc. dnl See LICENSE for licensing information AC_PREREQ([2.63]) -AC_INIT([tor],[0.3.0.2-alpha-dev]) +AC_INIT([tor],[0.3.0.3-alpha]) AC_CONFIG_SRCDIR([src/or/main.c]) AC_CONFIG_MACRO_DIR([m4]) diff --git a/contrib/win32build/tor-mingw.nsi.in b/contrib/win32build/tor-mingw.nsi.in index c98aa78..93f75a9 100644 --- a/contrib/win32build/tor-mingw.nsi.in +++ b/contrib/win32build/tor-mingw.nsi.in @@ -8,7 +8,7 @@ !include "LogicLib.nsh" !include "FileFunc.nsh" !insertmacro GetParameters -!define VERSION "0.3.0.2-alpha-dev" +!define VERSION "0.3.0.3-alpha" !define INSTALLER "tor-${VERSION}-win32.exe" !define WEBSITE "https://www.torproject.org/" !define LICENSE "LICENSE" diff --git a/src/win32/orconfig.h b/src/win32/orconfig.h index e111d96..eeb870b 100644 --- a/src/win32/orconfig.h +++ b/src/win32/orconfig.h @@ -218,7 +218,7 @@ #define USING_TWOS_COMPLEMENT /* Version number of package */ -#define VERSION "0.3.0.2-alpha-dev" +#define VERSION "0.3.0.3-alpha"

1 0

[tor/master] Start on an 0.3.0.3-alpha changelog
by nickm＠torproject.org 03 Feb '17

03 Feb '17

commit a54b269c95df23f519bf32858fac2ce2af6c5ea7 Author: Nick Mathewson <nickm(a)torproject.org> Date: Fri Feb 3 10:50:36 2017 -0500 Start on an 0.3.0.3-alpha changelog --- ChangeLog | 137 +++++++++++++++++++++++++++++ changes/21359 | 7 -- changes/bug20824 | 3 - changes/bug20980 | 4 - changes/bug21052 | 4 - changes/bug21107 | 6 -- changes/bug21108_029 | 6 -- changes/bug21128 | 5 -- changes/bug21129 | 4 - changes/bug21134 | 5 -- changes/bug21150 | 5 -- changes/bug21242 | 10 --- changes/bug21280 | 5 -- changes/bug21290 | 7 -- changes/bug21294 | 6 -- changes/bug21300 | 6 -- changes/bug21302 | 8 -- changes/bug21357 | 7 -- changes/bug21372 | 4 - changes/change_separate_exit_and_relay.txt | 3 - changes/ciphers.inc | 5 -- changes/feature20956 | 6 -- changes/feature21269 | 3 - changes/server_cipher | 3 - changes/ticket20174 | 4 - changes/ticket21356 | 4 - 26 files changed, 137 insertions(+), 130 deletions(-) diff --git a/ChangeLog b/ChangeLog index 59fdc51..62cf13d 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,140 @@ +Changes in version 0.3.0.3-alpha - 2017-02-03 + BLURB BLURB BLURB. + + o Major bugfixes (directory authority): + - During voting, when marking a node as a probable sybil, do not + clear its BadExit flag: sybils can still be bad in other ways + too. (We still clear the other flags.) Fixes bug 21108; bugfix + on 0.2.0.13-alpha. + - When deciding whether we have just found a router to be reachable, + do not penalize it for not having performed an Ed25519 link + handshake if it does not claim to support an Ed25519 handshake. + Previously, we would treat such relays as non-running. Fixes bug + 21107; bugfix on 0.2.3.1-alpha. + + o Major bugfixes (entry guards): + - Stop trying to build circuits through entry guards for which we + have no descriptor yet. Also, stop crashing if we *do* + accidentally try to build a circuit in such a state. Fixes bug + 21242; bugfix on 0.3.0.1-alpha. + + o Major bugfixes (IPv6 Exits): + - Stop rejecting all IPv6 traffic on Exits whose exit policy rejects + IPv6 addresses. Instead, only reject a port over IPv6 if the exit + policy rejects that port on more than an IPv6 /16 of addresses. + This bug was made worse by 17027 in 0.2.8.1-alpha, which rejects a + relay's own IPv6 address by default. Fixes bug 21357; bugfix on + commit 004f3f4e53 in 0.2.4.7-alpha. + + o Minor feature (client): + - Enable IPv6 traffic by default on the SocksPort. To disable this, + a user will have to specify "NoIPv6Traffic". Closes ticket 21269. + + o Minor feature (fallback scripts): + - Add a check_existing mode to updateFallbackDirs.py, which checks + if fallbacks in the hard-coded list are working. Closes ticket + 20174. Patch by haxxpop. + + o Minor features (ciphersuite selection): + - Allow servers to accept a wider range of ciphersuites, including + chacha20-poly1305 and AES-CCM. Closes the other part of 15426. + - Clients now advertise a list of ciphersuites closer to the ones + preferred by Firefox. Closes ticket 15426. + + o Minor features (controller, configuration): + - Each of the *Port options, such as SocksPort, ORPort, ControlPort, + and so on, now comes with a __*Port variant that will not be saved + to the torrc file by the controller's SAVECONF command. This + change allows TorBrowser to set up a single-use domain socket for + each time it launches Tor. Closes ticket 20956. + - The GETCONF command can now query options that may only be + meaningful in context-sensitive lists. This allows the controller + to query the mixed SocksPort/__SocksPort style options introduced + in feature 20956. Implements ticket 21300. + + o Minor features (portability, compilation): + - Autoconf now check to determine if OpenSSL structures are opaque, + instead of explicitly checking for OpenSSL version numbers. Part + of ticket 21359. + - Support building with recent LibreSSL code that uses opaque + structures. Closes ticket 21359. + + o Minor features (relay): + - Allow separation of exit and relay traffic to different source IP + addresses. Closes ticket 17975. Written by Michael Sonntag. + + o Minor bugfix (logging): + - Don't recommend the use of Tor2web in non anonymous mode. In that + mode, we disable client functionalities and recommending Tor2web + as a solution is a bad idea because in that case client loses all + anonymity. Tor2web should really only be used in very specific + cases and with users *knowing* what they do. Fixes bug 21294; + bugfix on 0.2.9.3-alpha. + + o Minor bugfixes (client): + - Always recover from failures in extend_info_from_node(), in an + attempt to prevent any recurrence of bug 21242. Fixes bug 21372; + bugfix on 0.2.3.1-alpha. + + o Minor bugfixes (client, entry guards): + - Fix a bug warning (with backtrace) when we fail a channel that + circuits to fallback directories on it. Fixes bug 21128; bugfix + on 0.3.0.1-alpha. + - Fix a spurious bug warning (with backtrace) when removing an + expired entry guard. Fixes bug 21129; bugfix on 0.3.0.1-alpha. + - Fix a bug of the new guard algorithm where tor could stall for up + to 10 minutes before retrying a guard after a long period of no + network. Fixes bug 21052; bugfix on 0.3.0.1-alpha. + - Do not try to build circuits until we have descriptors for our + primary entry guards. Related to fix for bug 21242. + + o Minor bugfixes (configure, autoconf): + - Rename the configure option --enable-expensive-hardening to + --enable-fragile-hardening. TROVE-2017-001 was triggerable only + through the expensive hardening which is making the tor daemon + abort when the issue is detected. Thus, it makes tor more at risk + of remote crashes but safer against RCE or heartbleed bug + category. Fixes bug 21290; bugfix on 0.2.5.4-alpha. + + o Minor bugfixes (controller): + - Restore the (deprecated) DROPGUARDS controller command. Fixes bug + 20824; bugfix on 0.3.0.1-alpha. + + o Minor bugfixes (hidden service): + - Cleanup expiring intro point nodes if no circuit is associated to + it anymore. It was causing, rarely, the service to not open enough + introduction points circuit in the case we had dead expiring + nodes.; bugfix on 0.2.7.2-alpha. + - Stop modifying the value of our torrc option + HiddenServiceStatistics just because we're not a bridge or relay. + Use an internal value for what tor should use and keep the torrc + option intact. Fixes bug 21150; bugfix on 0.2.6.2-alpha. + - Two possible underflow which would ultimately lead to creating a + lot of introduction points circuits and closing them in a non stop + loop. Fixes bug 21302; bugfix on 0.2.7.2-alpha. + + o Minor bugfixes (portability): + - Use "OpenBSD" pre-defined compiler macro instead of "OPENBSD" or + "__OpenBSD__". It is supported by OpenBSD itself and also most + OpenBSD variants like Bitrig. Fixes bug 20980; bugfix + on 0.1.2.1-alpha. + - Do not silently truncate content of files if they are larger than + SIZE_MAX bytes. This issue could occur on 32 bit systems with + large file support and files which are larger than 4 GB. Fixes bug + 21134; bugfix on 0.3.0.1-alpha. + + o Minor bugfixes (tor-resolve): + - The tor-resolve command line tool now rejects hostnames over 255 + characters in length. Previously, it would silently truncate them, + which could lead to bugs. Fixes bug 21280; bugfix on 0.0.9pre5. + Patch by "junglefowl". + + o Minor bugfixes (Windows services): + - Be sure to initialize the monotonic time subsystem before using + it, even when running as an NT service. Fixes bug 21356; bugfix + on 0.2.9.1-alpha. + + Changes in version 0.3.0.2-alpha - 2017-01-23 Tor 0.3.0.2-alpha fixes a denial-of-service bug where an attacker could cause relays and clients to crash, even if they were not built with diff --git a/changes/21359 b/changes/21359 deleted file mode 100644 index 24113a0..0000000 --- a/changes/21359 +++ /dev/null @@ -1,7 +0,0 @@ - o Minor features (portability, compilation): - - Support building with recent LibreSSL code that uses opaque - structures. Closes ticket 21359. - - Autoconf now check to determine if OpenSSL - structures are opaque, instead of explicitly checking for - OpenSSL version numbers. - Part of ticket 21359. diff --git a/changes/bug20824 b/changes/bug20824 deleted file mode 100644 index 0cd5205..0000000 --- a/changes/bug20824 +++ /dev/null @@ -1,3 +0,0 @@ - o Minor bugfixes (controller): - - Restore the (deprecated) DROPGUARDS controller command. - Fixes bug 20824; bugfix on 0.3.0.1-alpha. diff --git a/changes/bug20980 b/changes/bug20980 deleted file mode 100644 index 0f8e28e..0000000 --- a/changes/bug20980 +++ /dev/null @@ -1,4 +0,0 @@ - o Minor bugfix (OpenBSD): - - Use "OpenBSD" pre-defined compiler macro instead of "OPENBSD" or - "__OpenBSD__". It is supported by OpenBSD itself and also most OpenBSD - variants like Bitrig. Fixes bug 20980; bugfix on 0.1.2.1-alpha. diff --git a/changes/bug21052 b/changes/bug21052 deleted file mode 100644 index 0597b3b..0000000 --- a/changes/bug21052 +++ /dev/null @@ -1,4 +0,0 @@ - o Minor bugfixes (client, guards): - - Fix a bug of the new guard algorithm where tor could stall for up to 10 - minutes before retrying a guard after a long period of no network. - Fixes bug 21052; bugfix on 0.3.0.1-alpha. diff --git a/changes/bug21107 b/changes/bug21107 deleted file mode 100644 index e9e4e78..0000000 --- a/changes/bug21107 +++ /dev/null @@ -1,6 +0,0 @@ - o Major bugfixes (directory authority): - - When deciding whether we have just found a router to be reachable, - do not penalize it for not having performed an Ed25519 link handshake - if it does not claim to support an Ed25519 handshake. Previously, - we would treat such relays as non-running. - Fixes bug 21107; bugfix on 0.2.3.1-alpha. diff --git a/changes/bug21108_029 b/changes/bug21108_029 deleted file mode 100644 index 3a3f004..0000000 --- a/changes/bug21108_029 +++ /dev/null @@ -1,6 +0,0 @@ - o Major bugfixes (directory authority): - - During voting, when marking a node as a probable sybil, do not - clear its BadExit flag: sybils can still be bad in other ways - too. (We still clear the other flags.) Fixes bug 21108; bugfix - on 0.2.0.13-alpha. - diff --git a/changes/bug21128 b/changes/bug21128 deleted file mode 100644 index 972d2a2..0000000 --- a/changes/bug21128 +++ /dev/null @@ -1,5 +0,0 @@ - o Minor bugfixes (client, entry guards): - - Fix a bug warning (with backtrace) when we fail a channel - that circuits to fallback directories on it. Fixes bug 21128; - bugfix on 0.3.0.1-alpha. - diff --git a/changes/bug21129 b/changes/bug21129 deleted file mode 100644 index 5a09bb4..0000000 --- a/changes/bug21129 +++ /dev/null @@ -1,4 +0,0 @@ - o Minor bugfixes (client, entry guards): - - Fix a spurious bug warning (with backtrace) when removing an - expired entry guard. Fixes bug 21129; bugfix on 0.3.0.1-alpha. - diff --git a/changes/bug21134 b/changes/bug21134 deleted file mode 100644 index b851718..0000000 --- a/changes/bug21134 +++ /dev/null @@ -1,5 +0,0 @@ - o Minor bugfixes (portability): - - Do not silently truncate content of files if they are larger - than SIZE_MAX bytes. This issue could occur on 32 bit systems - with large file support and files which are larger than 4 GB. - Fixes bug 21134; bugfix on 0.3.0.1-alpha. diff --git a/changes/bug21150 b/changes/bug21150 deleted file mode 100644 index a5235d5..0000000 --- a/changes/bug21150 +++ /dev/null @@ -1,5 +0,0 @@ - o Minor bugfixes (config, hidden service): - - Stop modifying the value of our torrc option HiddenServiceStatistics - just because we're not a bridge or relay. Use an internal value for what - tor should use and keep the torrc option intact. Fixes bug 21150; bugfix - on 0.2.6.2-alpha. diff --git a/changes/bug21242 b/changes/bug21242 deleted file mode 100644 index 0bdc203..0000000 --- a/changes/bug21242 +++ /dev/null @@ -1,10 +0,0 @@ - o Major bugfixes (entry guards): - - Stop trying to build circuits through entry guards for which we - have no descriptor yet. Also, stop crashing if we *do* accidentally - try to build a circuit in such a state. Fixes bug 21242; bugfix - on 0.3.0.1-alpha. - - o Minor features (entry guards): - - Do not try to build circuits until we have descriptors for our - primary entry guards. Related to fix for bug 21242. - diff --git a/changes/bug21280 b/changes/bug21280 deleted file mode 100644 index e9f0bc1..0000000 --- a/changes/bug21280 +++ /dev/null @@ -1,5 +0,0 @@ - o Minor bugfixes (tor-resolve): - - The tor-resolve command line tool now rejects hostnames over 255 - characters in length. Previously, it would silently truncate - them, which could lead to bugs. Fixes bug 21280; bugfix on 0.0.9pre5. - Patch by "junglefowl". diff --git a/changes/bug21290 b/changes/bug21290 deleted file mode 100644 index 6c899b8..0000000 --- a/changes/bug21290 +++ /dev/null @@ -1,7 +0,0 @@ - o Minor bugfixes (configure, autoconf): - - Rename the configure option --enable-expensive-hardening to - --enable-fragile-hardening. TROVE-2017-001 was triggerable only through - the expensive hardening which is making the tor daemon abort when the - issue is detected. Thus, it makes tor more at risk of remote crashes but - safer against RCE or heartbleed bug category. Fixes bug 21290; bugfix on - 0.2.5.4-alpha. diff --git a/changes/bug21294 b/changes/bug21294 deleted file mode 100644 index 32351d3..0000000 --- a/changes/bug21294 +++ /dev/null @@ -1,6 +0,0 @@ - o Minor bugfix (logging): - - Don't recommend to use Tor2web in non anonymous mode. In that mode, we - disable client functionalities and recommending Tor2web as a solution is - a bad idea because in that case client loses all anonymity. Tor2web - should really only be used in very specific cases and with users - *knowing* what they do. Fixes bug 21294; bugfix on 0.2.9.3-alpha. diff --git a/changes/bug21300 b/changes/bug21300 deleted file mode 100644 index 70cc12a..0000000 --- a/changes/bug21300 +++ /dev/null @@ -1,6 +0,0 @@ - o Minor features (controller): - - The GETCONF command can now query options that may only be meaningful - in context-sensitive lists. This allows the controller to query - the mixed SocksPort/__SocksPort style options introduced in - feature 20956. Implements ticket 21300. - diff --git a/changes/bug21302 b/changes/bug21302 deleted file mode 100644 index 309b357..0000000 --- a/changes/bug21302 +++ /dev/null @@ -1,8 +0,0 @@ - o Minor bugfixes (hidden service): - - Two possible underflow which would ultimately lead to creating a lot of - introduction points circuits and closing them in a non stop loop. Fixes - bug 21302; bugfix on 0.2.7.2-alpha. - - Cleanup expiring intro point nodes if no circuit is associated to it - anymore. It was causing, rarely, the service to not open enough - introduction points circuit in the case we had dead expiring nodes.; - bugfix on 0.2.7.2-alpha. diff --git a/changes/bug21357 b/changes/bug21357 deleted file mode 100644 index a1cb43a..0000000 --- a/changes/bug21357 +++ /dev/null @@ -1,7 +0,0 @@ - o Major bugfixes (IPv6 Exits): - - Stop rejecting all IPv6 traffic on Exits whose exit policy rejects IPv6 - addresses. Instead, only reject a port over IPv6 if the exit policy - rejects that port on more than an IPv6 /16 of addresses. This bug was - made worse by 17027 in 0.2.8.1-alpha, which rejects a relay's own IPv6 - address by default. - Fixes bug 21357; bugfix on commit 004f3f4e53 in 0.2.4.7-alpha. diff --git a/changes/bug21372 b/changes/bug21372 deleted file mode 100644 index 178ae3a..0000000 --- a/changes/bug21372 +++ /dev/null @@ -1,4 +0,0 @@ - o Minor bugfixes (client): - - Always recover from failures in extend_info_from_node(), - in an attempt to prevent any recurrence of bug 21242. - Fixes bug 21372; bugfix on 0.2.3.1-alpha. diff --git a/changes/change_separate_exit_and_relay.txt b/changes/change_separate_exit_and_relay.txt deleted file mode 100644 index de7defc..0000000 --- a/changes/change_separate_exit_and_relay.txt +++ /dev/null @@ -1,3 +0,0 @@ - o Minor features (relay): - - Allow separation of exit and relay traffic to different source IP - addresses. Closes ticket 17975. Written by Michael Sonntag. diff --git a/changes/ciphers.inc b/changes/ciphers.inc deleted file mode 100644 index a8b5fd6..0000000 --- a/changes/ciphers.inc +++ /dev/null @@ -1,5 +0,0 @@ - o Minor features (ciphersuite selection): - - Clients now advertise a list of ciphersuites closer to the ones - preferred by Firefox. Closes ticket 15426. - - diff --git a/changes/feature20956 b/changes/feature20956 deleted file mode 100644 index 1ebddb1..0000000 --- a/changes/feature20956 +++ /dev/null @@ -1,6 +0,0 @@ - o Minor features (configuration, controller): - - Each of the *Port options, such as SocksPort, ORPort, ControlPort, - and so on, now comes with a __*Port variant that will not be - saved to the torrc file by the controller's SAVECONF command. - This change allows TorBrowser to set up a single-use domain socket - for each time it launches Tor. Closes ticket 20956. diff --git a/changes/feature21269 b/changes/feature21269 deleted file mode 100644 index 4ddbd12..0000000 --- a/changes/feature21269 +++ /dev/null @@ -1,3 +0,0 @@ - o Minor feature (client): - - Enable IPv6 traffic by default on the SocksPort. To disable this, a user - will have to specify "NoIPv6Traffic". Closes ticket 21269. diff --git a/changes/server_cipher b/changes/server_cipher deleted file mode 100644 index b80c88a..0000000 --- a/changes/server_cipher +++ /dev/null @@ -1,3 +0,0 @@ - o Minor features (ciphersuite choices): - - Allow servers to accept a wider range of ciphersuites, including - chacha20-poly1305 and AES-CCM. Closes the other part of 15426. diff --git a/changes/ticket20174 b/changes/ticket20174 deleted file mode 100644 index b727fc1..0000000 --- a/changes/ticket20174 +++ /dev/null @@ -1,4 +0,0 @@ - o Minor feature (fallback scripts): - - Add a check_existing mode to updateFallbackDirs.py, which checks if - fallbacks in the hard-coded list are working. Closes ticket 20174. - Patch by haxxpop. diff --git a/changes/ticket21356 b/changes/ticket21356 deleted file mode 100644 index 394238b..0000000 --- a/changes/ticket21356 +++ /dev/null @@ -1,4 +0,0 @@ - o Minor bugfixes (Windows services): - - Be sure to initialize the monotonic time subsystem before using it, - even when running as an NT service. - Fixes bug 21356; bugfix on 0.2.9.1-alpha.

1 0

[tor/master] Prevention: never die from extend_info_from_node() failure.
by nickm＠torproject.org 03 Feb '17

03 Feb '17

commit 19e25d5cabd23f28044ccbddc01e5cacbde2cfcb Author: Nick Mathewson <nickm(a)torproject.org> Date: Fri Feb 3 10:14:25 2017 -0500 Prevention: never die from extend_info_from_node() failure. Bug 21242 occurred because we asserted that extend_info_from_node() had succeeded...even though we already had the code to handle such a failure. We fixed that in 93b39c51629ed0ded2bf807cb6. But there were four other cases in our code where we called extend_info_from_node() and either tor_assert()ed that it returned non-NULL, or [in one case] silently assumed that it returned non-NULL. That's not such a great idea. This patch makes those cases check for a bug of this kind instead. Fixes bug 21372; bugfix on 0.2.3.1-alpha when extend_info_from_node() was introduced. --- changes/bug21372 | 4 ++++ src/or/circuitbuild.c | 5 +++-- src/or/control.c | 7 ++----- src/or/rendservice.c | 3 +++ 4 files changed, 12 insertions(+), 7 deletions(-) diff --git a/changes/bug21372 b/changes/bug21372 new file mode 100644 index 0000000..178ae3a --- /dev/null +++ b/changes/bug21372 @@ -0,0 +1,4 @@ + o Minor bugfixes (client): + - Always recover from failures in extend_info_from_node(), + in an attempt to prevent any recurrence of bug 21242. + Fixes bug 21372; bugfix on 0.2.3.1-alpha. diff --git a/src/or/circuitbuild.c b/src/or/circuitbuild.c index 88445f9..8a57d83 100644 --- a/src/or/circuitbuild.c +++ b/src/or/circuitbuild.c @@ -2110,7 +2110,8 @@ onion_pick_cpath_exit(origin_circuit_t *circ, extend_info_t *exit_ei) return -1; } exit_ei = extend_info_from_node(node, 0); - tor_assert(exit_ei); + if (BUG(exit_ei == NULL)) + return -1; } state->chosen_exit = exit_ei; return 0; @@ -2376,7 +2377,7 @@ onion_extend_cpath(origin_circuit_t *circ) choose_good_middle_server(purpose, state, circ->cpath, cur_len); if (r) { info = extend_info_from_node(r, 0); - tor_assert(info); + tor_assert_nonfatal(info); } } diff --git a/src/or/control.c b/src/or/control.c index 2c71ea5..b0a6876 100644 --- a/src/or/control.c +++ b/src/or/control.c @@ -3377,7 +3377,8 @@ handle_control_extendcircuit(control_connection_t *conn, uint32_t len, SMARTLIST_FOREACH(nodes, const node_t *, node, { extend_info_t *info = extend_info_from_node(node, first_node); - if (first_node && !info) { + if (!info) { + tor_assert_nonfatal(first_node); log_warn(LD_CONTROL, "controller tried to connect to a node that doesn't have any " "addresses that are allowed by the firewall configuration; " @@ -3385,10 +3386,6 @@ handle_control_extendcircuit(control_connection_t *conn, uint32_t len, circuit_mark_for_close(TO_CIRCUIT(circ), -END_CIRC_REASON_CONNECTFAILED); connection_write_str_to_buf("551 Couldn't start circuit\r\n", conn); goto done; - } else { - /* True, since node_has_descriptor(node) == true and we are extending - * to the node's primary address */ - tor_assert(info); } circuit_append_new_exit(circ, info); extend_info_free(info); diff --git a/src/or/rendservice.c b/src/or/rendservice.c index 4c5372c..1d6fc0f 100644 --- a/src/or/rendservice.c +++ b/src/or/rendservice.c @@ -4162,6 +4162,9 @@ rend_consider_services_intro_points(void) * even if we are a single onion service and intend to connect to it * directly ourselves. */ intro->extend_info = extend_info_from_node(node, 0); + if (BUG(intro->extend_info == NULL)) { + break; + } intro->intro_key = crypto_pk_new(); const int fail = crypto_pk_generate_key(intro->intro_key); tor_assert(!fail);

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

tor-commits February 2017