October 2016 - tor-commits - lists.torproject.org

[meek/master] Ignore SIGPIPE in meek-client-torbrowser.
by dcf＠torproject.org 04 Oct '16

04 Oct '16

commit 125b0ca14312085def735bc8c239097972a166c5 Author: David Fifield <david(a)bamsoftware.com> Date: Sun Sep 25 22:23:57 2016 -0700 Ignore SIGPIPE in meek-client-torbrowser. See https://bugs.torproject.org/20030 for discussion. Since Go 1.6, writes to fd 1 or 2 when they are closed causes the program to terminate with a SIGPIPE. Because the default log location is stderr (fd 2), we would get a SIGPIPE when logging once the parent process had died and closed its stderr. This prevented meek-client-torbrowser from cleaning up its subprocesses. --- meek-client-torbrowser/meek-client-torbrowser.go | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/meek-client-torbrowser/meek-client-torbrowser.go b/meek-client-torbrowser/meek-client-torbrowser.go index 450f9fa..4f3531d 100644 --- a/meek-client-torbrowser/meek-client-torbrowser.go +++ b/meek-client-torbrowser/meek-client-torbrowser.go @@ -289,6 +289,17 @@ func main() { log.SetOutput(f) } + // By default, writes to file descriptor 1 and 2 when the descriptor has + // been closed will terminate the program with a SIGPIPE signal. This is + // a problem because the default log destination is stderr (file + // descriptor 2). When the parent process (tor) terminates and closes + // its stderr, any attempt to log will cause us to die, before we can do + // our own cleanup. Therefore ignore SIGPIPE, causing writes to a closed + // stderr to return syscall.EPIPE rather than terminate. + // https://golang.org/pkg/os/signal/#hdr-SIGPIPE + // https://bugs.torproject.org/20030#comment:6 + signal.Notify(make(chan os.Signal, 1), syscall.SIGPIPE) + sigChan := make(chan os.Signal, 1) signal.Notify(sigChan, syscall.SIGINT, syscall.SIGTERM)

1 0

[translation/torbutton-torbuttondtd] Update translations for torbutton-torbuttondtd
by translation＠torproject.org 03 Oct '16

03 Oct '16

commit 0289db4b31c9c5a36129c978b84567937741fc4e Author: Translation commit bot <translation(a)torproject.org> Date: Mon Oct 3 19:16:33 2016 +0000 Update translations for torbutton-torbuttondtd --- mt/torbutton.dtd | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/mt/torbutton.dtd b/mt/torbutton.dtd index 387a4b9..158e2ab 100644 --- a/mt/torbutton.dtd +++ b/mt/torbutton.dtd @@ -1,4 +1,4 @@ -<!ENTITY torbutton.context_menu.new_identity "Identita ġdieda"> +<!ENTITY torbutton.context_menu.new_identity "Identita ġdida"> <!ENTITY torbutton.context_menu.new_identity_key "I"> <!ENTITY torbutton.context_menu.new_circuit "New Tor Circuit for this Site"> <!ENTITY torbutton.context_menu.new_circuit_key "C"> @@ -17,7 +17,7 @@ <!ENTITY torbutton.cookiedialog.lockCol "Protett"> <!ENTITY torbutton.cookiedialog.domainCol "Host"> <!ENTITY torbutton.cookiedialog.nameCol "Isem"> -<!ENTITY torbutton.cookiedialog.pathCol "Path"> +<!ENTITY torbutton.cookiedialog.pathCol "Triq"> <!ENTITY torbutton.cookiedialog.protectCookie "Protect Cookie"> <!ENTITY torbutton.cookiedialog.removeCookie "Remove Cookie"> <!ENTITY torbutton.cookiedialog.unprotectCookie "Unprotect Cookie">

1 0

[translation/mat-gui] Update translations for mat-gui
by translation＠torproject.org 03 Oct '16

03 Oct '16

commit ec6fae455c8f7dadcc984f0c966cb57a5caf7ef5 Author: Translation commit bot <translation(a)torproject.org> Date: Mon Oct 3 19:15:50 2016 +0000 Update translations for mat-gui --- mt.po | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mt.po b/mt.po index aef7553..05a60c3 100644 --- a/mt.po +++ b/mt.po @@ -8,7 +8,7 @@ msgstr "" "Project-Id-Version: The Tor Project\n" "Report-Msgid-Bugs-To: \n" "POT-Creation-Date: 2016-02-10 23:06+0100\n" -"PO-Revision-Date: 2016-03-21 16:34+0000\n" +"PO-Revision-Date: 2016-10-03 18:46+0000\n" "Last-Translator: carolyn <carolyn(a)anhalt.org>\n" "Language-Team: Maltese (http://www.transifex.com/otf/torproject/language/mt/)\n" "MIME-Version: 1.0\n"

1 0

[translation/whisperback] Update translations for whisperback
by translation＠torproject.org 03 Oct '16

03 Oct '16

commit 159e9fd8f8a3624d38691a86839c2ed850b0f42a Author: Translation commit bot <translation(a)torproject.org> Date: Mon Oct 3 19:15:15 2016 +0000 Update translations for whisperback --- mt/mt.po | 39 ++++++++++++++++++++------------------- 1 file changed, 20 insertions(+), 19 deletions(-) diff --git a/mt/mt.po b/mt/mt.po index f2026cf..3518fc5 100644 --- a/mt/mt.po +++ b/mt/mt.po @@ -3,13 +3,14 @@ # This file is distributed under the same license as the PACKAGE package. # # Translators: +# Liam Montebello, 2016 msgid "" msgstr "" "Project-Id-Version: The Tor Project\n" "Report-Msgid-Bugs-To: \n" "POT-Creation-Date: 2015-12-16 19:54+0100\n" -"PO-Revision-Date: 2016-03-21 16:28+0000\n" -"Last-Translator: Tor Project <support-team-private(a)lists.torproject.org>\n" +"PO-Revision-Date: 2016-10-03 19:11+0000\n" +"Last-Translator: Liam Montebello\n" "Language-Team: Maltese (http://www.transifex.com/otf/torproject/language/mt/)\n" "MIME-Version: 1.0\n" "Content-Type: text/plain; charset=UTF-8\n" @@ -21,16 +22,16 @@ msgstr "" #: ../whisperBack/whisperback.py:56 #, python-format msgid "Invalid contact email: %s" -msgstr "" +msgstr "Emajl mhux validu: %s" #: ../whisperBack/whisperback.py:73 #, python-format msgid "Invalid contact OpenPGP key: %s" -msgstr "" +msgstr "Ċavetta tal-OpenPGP ghall dal kuntatt mhux valida: %s" #: ../whisperBack/whisperback.py:75 msgid "Invalid contact OpenPGP public key block" -msgstr "" +msgstr "Blokka taċ-ċavetta publika tal OpenPGP ghall dal kuntatt mhux valida" #: ../whisperBack/exceptions.py:41 #, python-format @@ -45,11 +46,11 @@ msgstr "" #: ../whisperBack/gui.py:214 msgid "Sending mail..." -msgstr "" +msgstr "Posta qed tinbagħat..." #: ../whisperBack/gui.py:215 msgid "Sending mail" -msgstr "" +msgstr "Posta qed tinbagħat" #. pylint: disable=C0301 #: ../whisperBack/gui.py:217 @@ -83,11 +84,11 @@ msgstr "" #: ../whisperBack/gui.py:269 msgid "Your message has been sent." -msgstr "" +msgstr "Il-messaġġ tiegħek ġie mibgħut" #: ../whisperBack/gui.py:276 msgid "An error occured during encryption." -msgstr "" +msgstr "Sar żball waqt il encryption" #: ../whisperBack/gui.py:296 #, python-format @@ -106,7 +107,7 @@ msgstr "" #: ../whisperBack/gui.py:379 ../data/whisperback.ui.h:21 msgid "WhisperBack" -msgstr "" +msgstr "WhisperBack" #: ../whisperBack/gui.py:380 ../data/whisperback.ui.h:2 msgid "Send feedback in an encrypted mail." @@ -118,7 +119,7 @@ msgstr "" #: ../whisperBack/gui.py:384 msgid "Tails developers <tails(a)boum.org>" -msgstr "" +msgstr "Iżviluppaturi ta' Tails <tails(a)boum.org>" #: ../whisperBack/gui.py:385 msgid "translator-credits" @@ -126,15 +127,15 @@ msgstr "" #: ../whisperBack/gui.py:412 msgid "This doesn't seem to be a valid URL or OpenPGP key." -msgstr "" +msgstr "Dan ma jidhirx li hu indiriżż tajjeb jew ċavetta tal OpenPGP." #: ../data/whisperback.ui.h:1 msgid "Copyright © 2009-2012 tails(a)boum.org" -msgstr "" +msgstr "Copyright © 2009-2012 tails(a)boum.org" #: ../data/whisperback.ui.h:3 msgid "https://tails.boum.org/" -msgstr "" +msgstr "https://tails.boum.org/" #: ../data/whisperback.ui.h:4 msgid "" @@ -167,7 +168,7 @@ msgstr "" #: ../data/whisperback.ui.h:23 msgid "Bug description" -msgstr "" +msgstr "Deskriżżjoni tal-problema" #: ../data/whisperback.ui.h:24 msgid "Optional email address to contact you" @@ -175,11 +176,11 @@ msgstr "" #: ../data/whisperback.ui.h:25 msgid "optional PGP key" -msgstr "" +msgstr "Ċavetta PGP mhux ta' bilfors" #: ../data/whisperback.ui.h:26 msgid "Technical details to include" -msgstr "" +msgstr "Dettalji tekniċi biex tinkludi" #: ../data/whisperback.ui.h:27 msgid "headers" @@ -191,8 +192,8 @@ msgstr "" #: ../data/whisperback.ui.h:29 msgid "Help" -msgstr "Help" +msgstr "Għajnuna" #: ../data/whisperback.ui.h:30 msgid "Send" -msgstr "" +msgstr "Ibgħat"

1 0

[translation/torbutton-torbuttondtd] Update translations for torbutton-torbuttondtd
by translation＠torproject.org 03 Oct '16

03 Oct '16

commit dcc0e59991c0ef4eb2b9d1313b009e283539d12c Author: Translation commit bot <translation(a)torproject.org> Date: Mon Oct 3 18:46:29 2016 +0000 Update translations for torbutton-torbuttondtd --- mt/torbutton.dtd | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/mt/torbutton.dtd b/mt/torbutton.dtd index 92b6eed..387a4b9 100644 --- a/mt/torbutton.dtd +++ b/mt/torbutton.dtd @@ -1,4 +1,4 @@ -<!ENTITY torbutton.context_menu.new_identity "New Identity"> +<!ENTITY torbutton.context_menu.new_identity "Identita ġdieda"> <!ENTITY torbutton.context_menu.new_identity_key "I"> <!ENTITY torbutton.context_menu.new_circuit "New Tor Circuit for this Site"> <!ENTITY torbutton.context_menu.new_circuit_key "C"> @@ -14,9 +14,9 @@ <!ENTITY torbutton.prefs.privacy_security_settings "Privacy and Security Settings"> <!ENTITY torbutton.prefs.restore_defaults "Restore Defaults"> <!ENTITY torbutton.cookiedialog.title "Manage Cookie Protections"> -<!ENTITY torbutton.cookiedialog.lockCol "Protected"> +<!ENTITY torbutton.cookiedialog.lockCol "Protett"> <!ENTITY torbutton.cookiedialog.domainCol "Host"> -<!ENTITY torbutton.cookiedialog.nameCol "Name"> +<!ENTITY torbutton.cookiedialog.nameCol "Isem"> <!ENTITY torbutton.cookiedialog.pathCol "Path"> <!ENTITY torbutton.cookiedialog.protectCookie "Protect Cookie"> <!ENTITY torbutton.cookiedialog.removeCookie "Remove Cookie">

1 0

[tor/master] Add TAGS to gitignore.
by nickm＠torproject.org 03 Oct '16

03 Oct '16

commit 684500519d5060fcbcc410a0e71d8d9a32fa8220 Author: Nick Mathewson <nickm(a)torproject.org> Date: Mon Oct 3 14:08:50 2016 -0400 Add TAGS to gitignore. --- .gitignore | 1 + 1 file changed, 1 insertion(+) diff --git a/.gitignore b/.gitignore index 2f94254..dc6738c 100644 --- a/.gitignore +++ b/.gitignore @@ -56,6 +56,7 @@ uptime-*.json /stamp-h /stamp-h.in /stamp-h1 +/TAGS /test-driver /tor.sh /tor.spec

1 0

[tor/master] Merge remote-tracking branch 'arma/bug20277'
by nickm＠torproject.org 03 Oct '16

03 Oct '16

commit 4bbdebff3fc47755df233a1720fbab81eb1cc344 Merge: a49fb1e 9228db5 Author: Nick Mathewson <nickm(a)torproject.org> Date: Mon Oct 3 14:05:26 2016 -0400 Merge remote-tracking branch 'arma/bug20277' src/or/directory.c | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-)

1 0

[tor/master] remove confusing comment about conditional consensus download
by nickm＠torproject.org 03 Oct '16

03 Oct '16

commit 9228db5f1bee0b715b73ba6f8c11f5eb77d59f62 Author: Roger Dingledine <arma(a)torproject.org> Date: Sun Oct 2 19:13:35 2016 -0400 remove confusing comment about conditional consensus download We removed that feature in 0.2.4.2-alpha, but some comments seem to have lingered. I didn't add a changes/ file since this is just internal code cleanup. --- src/or/directory.c | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/src/or/directory.c b/src/or/directory.c index 52b14b9..1f894d9 100644 --- a/src/or/directory.c +++ b/src/or/directory.c @@ -495,9 +495,6 @@ MOCK_IMPL(void, directory_get_from_dirserver, ( * sort of dir fetch we'll be doing, so it won't return a bridge * that can't answer our question. */ - /* XXX+++++ Not all bridges handle conditional consensus downloading, - * so, for now, never assume the server supports that. -PP - * Is that assumption still so in 2016? -NM */ const node_t *node = choose_random_dirguard(type); if (node && node->ri) { /* every bridge has a routerinfo. */ @@ -1305,9 +1302,9 @@ compare_strs_(const void **a, const void **b) /** Return the URL we should use for a consensus download. * - * This url depends on whether or not the server we go to - * is sufficiently new to support conditional consensus downloading, - * i.e. GET .../consensus/fpr+fpr+fpr + * Use the "conditional consensus downloading" feature described in + * dir-spec.txt, i.e. + * GET .../consensus/fpr+fpr+fpr * * If 'resource' is provided, it is the name of a consensus flavor to request. */

1 0

[tor/master] Teach 'make tags' about MOCK_IMPL.
by nickm＠torproject.org 03 Oct '16

03 Oct '16

commit a49fb1e2e5ebb03d7d115b4a4eaa1c17c160f1a8 Author: Nick Mathewson <nickm(a)torproject.org> Date: Mon Oct 3 13:58:09 2016 -0400 Teach 'make tags' about MOCK_IMPL. Patch from nherring; closes ticket 16869 --- Makefile.am | 3 +++ changes/16869 | 4 ++++ 2 files changed, 7 insertions(+) diff --git a/Makefile.am b/Makefile.am index c160af9..f400728 100644 --- a/Makefile.am +++ b/Makefile.am @@ -36,6 +36,9 @@ EXTRA_DIST+= \ README \ ReleaseNotes +## This tells etags how to find mockable function definitions. +AM_ETAGSFLAGS=--regex='{c}/MOCK_IMPL([^,]+,\W*\([a-zA-Z0-9_]+\)\W*,/\1/s' + if COVERAGE_ENABLED TEST_CFLAGS=-fno-inline -fprofile-arcs -ftest-coverage if DISABLE_ASSERTS_IN_UNIT_TESTS diff --git a/changes/16869 b/changes/16869 new file mode 100644 index 0000000..6687243 --- /dev/null +++ b/changes/16869 @@ -0,0 +1,4 @@ + o Minor features (development tools, etags): + - Teach the "make tags" Makefile target how to correctly find + "MOCK_IMPL" function definitions. Patch from nherring; closes + ticket 16869.

1 0

[tor/master] Avoid reordering IPv6 interface addresses
by nickm＠torproject.org 03 Oct '16

03 Oct '16

commit 3b2f012e28f73267a894c5e3b468c65d8e093b15 Author: cypherpunks <cypherpunks@localhost> Date: Fri Sep 30 21:49:09 2016 +0000 Avoid reordering IPv6 interface addresses When deleting unsuitable addresses in get_interface_address6_list(), to avoid reordering IPv6 interface addresses and keep the order returned by the OS, use SMARTLIST_DEL_CURRENT_KEEPORDER() instead of SMARTLIST_DEL_CURRENT(). This issue was reported by René Mayrhofer. [Closes ticket 20163; changes file written by teor. This paragraph added by nickm] --- changes/20163 | 6 ++++++ src/common/address.c | 4 ++-- 2 files changed, 8 insertions(+), 2 deletions(-) diff --git a/changes/20163 b/changes/20163 new file mode 100644 index 0000000..04074de --- /dev/null +++ b/changes/20163 @@ -0,0 +1,6 @@ + o Minor bugfixes (address discovery): + - Stop reordering IP addresses returned by the OS. +This makes is more likely that Tor will guess the same relay IP address every time. +Fixes issue 20163; bugfix on 0.2.7.1-alpha, ticket 17027. +Reported by René Mayrhofer, patch by "cypherpunks". + diff --git a/src/common/address.c b/src/common/address.c index 6799dd6..15ee3db 100644 --- a/src/common/address.c +++ b/src/common/address.c @@ -1770,13 +1770,13 @@ MOCK_IMPL(smartlist_t *,get_interface_address6_list,(int severity, { if (tor_addr_is_loopback(a) || tor_addr_is_multicast(a)) { - SMARTLIST_DEL_CURRENT(addrs, a); + SMARTLIST_DEL_CURRENT_KEEPORDER(addrs, a); tor_free(a); continue; } if (!include_internal && tor_addr_is_internal(a, 0)) { - SMARTLIST_DEL_CURRENT(addrs, a); + SMARTLIST_DEL_CURRENT_KEEPORDER(addrs, a); tor_free(a); continue; }

1 0