September 2019 - tor-commits - lists.torproject.org

[tor/release-0.4.1] Fold three more entries into changelog.
by nickm＠torproject.org 18 Sep '19

18 Sep '19

commit 3c248f7866f40018acf16391d3120c593006d189 Author: Nick Mathewson <nickm(a)torproject.org> Date: Wed Sep 18 08:15:19 2019 -0400 Fold three more entries into changelog. --- ChangeLog | 16 ++++++++++++++++ changes/bug31657 | 5 ----- changes/doc31089 | 4 ---- changes/ticket31772 | 4 ---- 4 files changed, 16 insertions(+), 13 deletions(-) diff --git a/ChangeLog b/ChangeLog index 956d8cab2..71a889626 100644 --- a/ChangeLog +++ b/ChangeLog @@ -33,6 +33,17 @@ Changes in version 0.4.1.6 - 2019-09-?? floating-point classifier functions on FreeBSD. Fixes part of bug 31687; bugfix on 0.3.1.5-alpha. + o Minor bugfixes (controller protocol): + - Fix the MAPADDRESS controller command to accept one or more + arguments. Previously, it required two or more arguments, and ignored + the first. Fixes bug 31772; bugfix on 0.4.1.1-alpha. + + o Minor bugfixes (guards, backport from 0.4.2.1-alpha): + - When tor is missing descriptors for some primary entry guards, + make the log message less alarming. It's normal for descriptors to + expire, as long as tor fetches new ones soon after. Fixes bug + 31657; bugfix on 0.3.3.1-alpha. + o Minor bugfixes (logging, backport from 0.4.2.1-alpha): - Change log level of message "Hash of session info was not as expected" to LOG_PROTOCOL_WARN. Fixes bug 12399; bugfix @@ -60,6 +71,11 @@ Changes in version 0.4.1.6 - 2019-09-?? single onion services failed when all intro nodes were unreachable via a 1-hop path. Fixes bug 23507; bugfix on 0.3.2.1-alpha. + o Documentation (backport from 0.4.2.1-alpha): + - Use RFC 2397 data URL scheme to embed an image into tor-exit- + notice.html so that operators no longer have to host it + themselves. Closes ticket 31089. + Changes in version 0.4.1.5 - 2019-08-20 This is the first stable release in the 0.4.1.x series. This series diff --git a/changes/bug31657 b/changes/bug31657 deleted file mode 100644 index 08e9d95fd..000000000 --- a/changes/bug31657 +++ /dev/null @@ -1,5 +0,0 @@ - o Minor bugfixes (guards): - - When tor is missing descriptors for some primary entry guards, make the - log message less alarming. It's normal for descriptors to expire, as long - as tor fetches new ones soon after. Fixes bug 31657; - bugfix on 0.3.3.1-alpha. diff --git a/changes/doc31089 b/changes/doc31089 deleted file mode 100644 index 2fc0ba4f7..000000000 --- a/changes/doc31089 +++ /dev/null @@ -1,4 +0,0 @@ - o Documentation: - - Use RFC 2397 data URL scheme to embed image into tor-exit-notice.html - so that operators would no longer have to host it themselves. - Closes ticket 31089. diff --git a/changes/ticket31772 b/changes/ticket31772 deleted file mode 100644 index 7847b3f74..000000000 --- a/changes/ticket31772 +++ /dev/null @@ -1,4 +0,0 @@ - o Minor bugfixes (controller protocol): - - Fix the MAPADDRESS controller command to accept one or more - arguments. Previously, it required two or more arguments, and ignored - the first. Fixes bug 31772; bugfix on 0.4.1.1-alpha.

1 0

[tor/release-0.4.1] Merge branch 'maint-0.4.1' into release-0.4.1
by nickm＠torproject.org 18 Sep '19

18 Sep '19

commit 8136ebba26c08ef54d65ec46dcd4796bb8429b33 Merge: 84fc0c579 70bcff601 Author: Nick Mathewson <nickm(a)torproject.org> Date: Wed Sep 18 08:07:56 2019 -0400 Merge branch 'maint-0.4.1' into release-0.4.1 changes/ticket31772 | 4 ++++ src/feature/control/control_cmd.c | 4 +++- 2 files changed, 7 insertions(+), 1 deletion(-)

1 0

[tor/maint-0.4.1] Merge branch 'bug31772_041' into maint-0.4.1
by nickm＠torproject.org 18 Sep '19

18 Sep '19

commit 70bcff6010f933c7dbce5d797ea354c6475e1f94 Merge: 5f00c03ed 25af8ada3 Author: Nick Mathewson <nickm(a)torproject.org> Date: Wed Sep 18 08:07:50 2019 -0400 Merge branch 'bug31772_041' into maint-0.4.1 changes/ticket31772 | 4 ++++ src/feature/control/control_cmd.c | 4 +++- 2 files changed, 7 insertions(+), 1 deletion(-)

1 0

[tor/maint-0.4.1] Correct the syntax description for the MAPADDRESS command.
by nickm＠torproject.org 18 Sep '19

18 Sep '19

commit 25af8ada30b84a0df19763bbc226ae209c38a1a0 Author: Nick Mathewson <nickm(a)torproject.org> Date: Tue Sep 17 19:26:45 2019 -0400 Correct the syntax description for the MAPADDRESS command. In 0.4.1.1-alpha I introduced a bug where we would require and ignore a single positional argument. Fixes bug 31772. --- changes/ticket31772 | 4 ++++ src/feature/control/control_cmd.c | 4 +++- 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/changes/ticket31772 b/changes/ticket31772 new file mode 100644 index 000000000..7847b3f74 --- /dev/null +++ b/changes/ticket31772 @@ -0,0 +1,4 @@ + o Minor bugfixes (controller protocol): + - Fix the MAPADDRESS controller command to accept one or more + arguments. Previously, it required two or more arguments, and ignored + the first. Fixes bug 31772; bugfix on 0.4.1.1-alpha. diff --git a/src/feature/control/control_cmd.c b/src/feature/control/control_cmd.c index abb579bd4..e0706ee4c 100644 --- a/src/feature/control/control_cmd.c +++ b/src/feature/control/control_cmd.c @@ -639,7 +639,9 @@ address_is_invalid_mapaddress_target(const char *addr) } static const control_cmd_syntax_t mapaddress_syntax = { - .max_args=1, + // no positional arguments are expected + .max_args=0, + // an arbitrary number of K=V entries are supported. .accept_keywords=true, };

1 0

[tor/master] Correct the syntax description for the MAPADDRESS command.
by nickm＠torproject.org 18 Sep '19

18 Sep '19

commit 25af8ada30b84a0df19763bbc226ae209c38a1a0 Author: Nick Mathewson <nickm(a)torproject.org> Date: Tue Sep 17 19:26:45 2019 -0400 Correct the syntax description for the MAPADDRESS command. In 0.4.1.1-alpha I introduced a bug where we would require and ignore a single positional argument. Fixes bug 31772. --- changes/ticket31772 | 4 ++++ src/feature/control/control_cmd.c | 4 +++- 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/changes/ticket31772 b/changes/ticket31772 new file mode 100644 index 000000000..7847b3f74 --- /dev/null +++ b/changes/ticket31772 @@ -0,0 +1,4 @@ + o Minor bugfixes (controller protocol): + - Fix the MAPADDRESS controller command to accept one or more + arguments. Previously, it required two or more arguments, and ignored + the first. Fixes bug 31772; bugfix on 0.4.1.1-alpha. diff --git a/src/feature/control/control_cmd.c b/src/feature/control/control_cmd.c index abb579bd4..e0706ee4c 100644 --- a/src/feature/control/control_cmd.c +++ b/src/feature/control/control_cmd.c @@ -639,7 +639,9 @@ address_is_invalid_mapaddress_target(const char *addr) } static const control_cmd_syntax_t mapaddress_syntax = { - .max_args=1, + // no positional arguments are expected + .max_args=0, + // an arbitrary number of K=V entries are supported. .accept_keywords=true, };

1 0

[tor/master] Merge branch 'bug31772_041' into maint-0.4.1
by nickm＠torproject.org 18 Sep '19

18 Sep '19

commit 70bcff6010f933c7dbce5d797ea354c6475e1f94 Merge: 5f00c03ed 25af8ada3 Author: Nick Mathewson <nickm(a)torproject.org> Date: Wed Sep 18 08:07:50 2019 -0400 Merge branch 'bug31772_041' into maint-0.4.1 changes/ticket31772 | 4 ++++ src/feature/control/control_cmd.c | 4 +++- 2 files changed, 7 insertions(+), 1 deletion(-)

1 0

[tor/master] Merge branch 'maint-0.4.1'
by nickm＠torproject.org 18 Sep '19

18 Sep '19

commit d6d3e829dd20b78e2b80e52f0e3865a1002e653b Merge: 7225cfc58 70bcff601 Author: Nick Mathewson <nickm(a)torproject.org> Date: Wed Sep 18 08:07:56 2019 -0400 Merge branch 'maint-0.4.1' changes/ticket31772 | 4 ++++ src/feature/control/control_cmd.c | 4 +++- 2 files changed, 7 insertions(+), 1 deletion(-)

1 0

[tor/release-0.4.1] Correct the syntax description for the MAPADDRESS command.
by nickm＠torproject.org 18 Sep '19

18 Sep '19

commit 25af8ada30b84a0df19763bbc226ae209c38a1a0 Author: Nick Mathewson <nickm(a)torproject.org> Date: Tue Sep 17 19:26:45 2019 -0400 Correct the syntax description for the MAPADDRESS command. In 0.4.1.1-alpha I introduced a bug where we would require and ignore a single positional argument. Fixes bug 31772. --- changes/ticket31772 | 4 ++++ src/feature/control/control_cmd.c | 4 +++- 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/changes/ticket31772 b/changes/ticket31772 new file mode 100644 index 000000000..7847b3f74 --- /dev/null +++ b/changes/ticket31772 @@ -0,0 +1,4 @@ + o Minor bugfixes (controller protocol): + - Fix the MAPADDRESS controller command to accept one or more + arguments. Previously, it required two or more arguments, and ignored + the first. Fixes bug 31772; bugfix on 0.4.1.1-alpha. diff --git a/src/feature/control/control_cmd.c b/src/feature/control/control_cmd.c index abb579bd4..e0706ee4c 100644 --- a/src/feature/control/control_cmd.c +++ b/src/feature/control/control_cmd.c @@ -639,7 +639,9 @@ address_is_invalid_mapaddress_target(const char *addr) } static const control_cmd_syntax_t mapaddress_syntax = { - .max_args=1, + // no positional arguments are expected + .max_args=0, + // an arbitrary number of K=V entries are supported. .accept_keywords=true, };

1 0

[tor/release-0.4.1] Merge branch 'bug31772_041' into maint-0.4.1
by nickm＠torproject.org 18 Sep '19

18 Sep '19

commit 70bcff6010f933c7dbce5d797ea354c6475e1f94 Merge: 5f00c03ed 25af8ada3 Author: Nick Mathewson <nickm(a)torproject.org> Date: Wed Sep 18 08:07:50 2019 -0400 Merge branch 'bug31772_041' into maint-0.4.1 changes/ticket31772 | 4 ++++ src/feature/control/control_cmd.c | 4 +++- 2 files changed, 7 insertions(+), 1 deletion(-)

1 0

[tor-browser/tor-browser-68.1.0esr-9.0-2] fixup! Bug 21431: Clean-up system extensions shipped in Firefox 52
by gk＠torproject.org 18 Sep '19

18 Sep '19

commit 63655f7a4c9575c5ab7828f49a9814c3ff157bda Author: Alex Catarineu <acat(a)torproject.org> Date: Wed Sep 18 12:19:39 2019 +0200 fixup! Bug 21431: Clean-up system extensions shipped in Firefox 52 --- browser/components/BrowserGlue.jsm | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/browser/components/BrowserGlue.jsm b/browser/components/BrowserGlue.jsm index a99a29a014ad..d22f9512184d 100644 --- a/browser/components/BrowserGlue.jsm +++ b/browser/components/BrowserGlue.jsm @@ -1844,6 +1844,9 @@ BrowserGlue.prototype = { const ID = "screenshots(a)mozilla.org"; const _checkScreenshotsPref = async () => { let addon = await AddonManager.getAddonByID(ID); + if (!addon) { + return; + } let disabled = Services.prefs.getBoolPref(PREF, false); if (disabled) { await addon.disable({ allowSystemAddons: true }); @@ -1860,6 +1863,9 @@ BrowserGlue.prototype = { const ID = "webcompat-reporter(a)mozilla.org"; Services.prefs.addObserver(PREF, async () => { let addon = await AddonManager.getAddonByID(ID); + if (!addon) { + return; + } let enabled = Services.prefs.getBoolPref(PREF, false); if (enabled && !addon.isActive) { await addon.enable({ allowSystemAddons: true });

1 0