May 2019 - tor-commits - lists.torproject.org

[tor/master] Practracker beatings are even more fun when they get caused mid-PR due to a github auto-rebase of a PR
by asn＠torproject.org 15 May '19

15 May '19

commit 5f47d582d50134d9504ec8e7a912887829904c8a Author: Mike Perry <mikeperry-git(a)torproject.org> Date: Wed May 15 04:58:21 2019 +0000 Practracker beatings are even more fun when they get caused mid-PR due to a github auto-rebase of a PR Because github PRs choose the most recent origin/master at the time of the PR (and for any fixups pushed to a PR later to send to CI), there are tons of conflicts and unexpected practracker issues. This means CI can suddenly fail after fixups to a branch that pass locally. Then CI fails and we have to close and re-open the PR. --- scripts/maint/practracker/exceptions.txt | 1 + 1 file changed, 1 insertion(+) diff --git a/scripts/maint/practracker/exceptions.txt b/scripts/maint/practracker/exceptions.txt index 24452b615..b380d507b 100644 --- a/scripts/maint/practracker/exceptions.txt +++ b/scripts/maint/practracker/exceptions.txt @@ -289,3 +289,4 @@ problem function-size /src/tools/tor-gencert.c:parse_commandline() 111 problem function-size /src/tools/tor-resolve.c:build_socks5_resolve_request() 104 problem function-size /src/tools/tor-resolve.c:do_resolve() 175 problem function-size /src/tools/tor-resolve.c:main() 112 +problem function-size /src/core/or/circuitpadding.c:circpad_machine_schedule_padding() 107

1 0

[translation/tails-persistence-setup_completed] Update translations for tails-persistence-setup_completed
by translation＠torproject.org 15 May '19

15 May '19

commit df0ebf7f87fe29ef5caf5c9c11d5394de592bde4 Author: Translation commit bot <translation(a)torproject.org> Date: Wed May 15 11:47:42 2019 +0000 Update translations for tails-persistence-setup_completed --- nl/nl.po | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/nl/nl.po b/nl/nl.po index 4ca9c6cfc..986aaee90 100644 --- a/nl/nl.po +++ b/nl/nl.po @@ -22,7 +22,7 @@ msgstr "" "Project-Id-Version: Tor Project\n" "Report-Msgid-Bugs-To: Tails developers <tails(a)boum.org>\n" "POT-Creation-Date: 2019-03-17 09:03+0100\n" -"PO-Revision-Date: 2019-04-14 18:18+0000\n" +"PO-Revision-Date: 2019-05-15 11:17+0000\n" "Last-Translator: Tonnes <tonnes.mb(a)gmail.com>\n" "Language-Team: Dutch (http://www.transifex.com/otf/torproject/language/nl/)\n" "MIME-Version: 1.0\n" @@ -269,7 +269,7 @@ msgstr "De machtigingen van het persistent volume zullen verbeterd worden." #: ../lib/Tails/Persistence/Step/Bootstrap.pm:315 msgid "Creating default persistence configuration." -msgstr "Aanmaken van standaard persitentie configuratie." +msgstr "Aanmaken van standaard persistentieconfiguratie." #: ../lib/Tails/Persistence/Step/Bootstrap.pm:318 msgid "The default persistence configuration will be created."

1 0

[translation/tails-persistence-setup] Update translations for tails-persistence-setup
by translation＠torproject.org 15 May '19

15 May '19

commit 77391de6237355a14a74fa8c0f92b4a960568f2a Author: Translation commit bot <translation(a)torproject.org> Date: Wed May 15 11:47:34 2019 +0000 Update translations for tails-persistence-setup --- nl/nl.po | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/nl/nl.po b/nl/nl.po index 4ca9c6cfc..986aaee90 100644 --- a/nl/nl.po +++ b/nl/nl.po @@ -22,7 +22,7 @@ msgstr "" "Project-Id-Version: Tor Project\n" "Report-Msgid-Bugs-To: Tails developers <tails(a)boum.org>\n" "POT-Creation-Date: 2019-03-17 09:03+0100\n" -"PO-Revision-Date: 2019-04-14 18:18+0000\n" +"PO-Revision-Date: 2019-05-15 11:17+0000\n" "Last-Translator: Tonnes <tonnes.mb(a)gmail.com>\n" "Language-Team: Dutch (http://www.transifex.com/otf/torproject/language/nl/)\n" "MIME-Version: 1.0\n" @@ -269,7 +269,7 @@ msgstr "De machtigingen van het persistent volume zullen verbeterd worden." #: ../lib/Tails/Persistence/Step/Bootstrap.pm:315 msgid "Creating default persistence configuration." -msgstr "Aanmaken van standaard persitentie configuratie." +msgstr "Aanmaken van standaard persistentieconfiguratie." #: ../lib/Tails/Persistence/Step/Bootstrap.pm:318 msgid "The default persistence configuration will be created."

1 0

[translation/tails-iuk_completed] Update translations for tails-iuk_completed
by translation＠torproject.org 15 May '19

15 May '19

commit 53c86eb4da94c1ab5038552016eb4b733bfa00cf Author: Translation commit bot <translation(a)torproject.org> Date: Wed May 15 11:46:53 2019 +0000 Update translations for tails-iuk_completed --- nl.po | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/nl.po b/nl.po index b804b9b0e..d1023a1fc 100644 --- a/nl.po +++ b/nl.po @@ -19,7 +19,7 @@ msgstr "" "Project-Id-Version: Tor Project\n" "Report-Msgid-Bugs-To: Tails developers <tails(a)boum.org>\n" "POT-Creation-Date: 2018-12-09 13:56+0100\n" -"PO-Revision-Date: 2019-04-14 18:07+0000\n" +"PO-Revision-Date: 2019-05-15 11:21+0000\n" "Last-Translator: Tonnes <tonnes.mb(a)gmail.com>\n" "Language-Team: Dutch (http://www.transifex.com/otf/torproject/language/nl/)\n" "MIME-Version: 1.0\n" @@ -118,7 +118,7 @@ msgid "" "Download size: %{size}s\n" "\n" "Do you want to upgrade now?" -msgstr "Je zou moeten upgraden naar %{name}s %{version}s.\n\nVoor meer informatie over deze nieuwe versie, ga naar %{details_url}s\n\nWe raden je aan om alle andere applicaties te sluiten tijdens de upgrade.\nDownloaden van de upgrade kan lang duren, van meerdere minuten tot enkele uren.\n\nDownload grootte: %{size}s\n\nWil je nu upgraden?" +msgstr "U zou een upgrade naar %{name}s %{version}s moeten uitvoeren.\n\nGa voor meer informatie over deze nieuwe versie naar %{details_url}s\n\nWe raden aan alle andere toepassingen te sluiten tijdens de upgrade.\nHet downloaden van de upgrade kan lang duren, van enkele minuten tot een paar uur.\n\nDownloadgrootte: %{size}s\n\nWilt u nu upgraden?" #: ../lib/Tails/IUK/Frontend.pm:386 msgid "Upgrade available"

1 0

[translation/tails-iuk] Update translations for tails-iuk
by translation＠torproject.org 15 May '19

15 May '19

commit 9ea00ed282c10202b9006d194e4503115317015c Author: Translation commit bot <translation(a)torproject.org> Date: Wed May 15 11:46:47 2019 +0000 Update translations for tails-iuk --- nl.po | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/nl.po b/nl.po index b804b9b0e..d1023a1fc 100644 --- a/nl.po +++ b/nl.po @@ -19,7 +19,7 @@ msgstr "" "Project-Id-Version: Tor Project\n" "Report-Msgid-Bugs-To: Tails developers <tails(a)boum.org>\n" "POT-Creation-Date: 2018-12-09 13:56+0100\n" -"PO-Revision-Date: 2019-04-14 18:07+0000\n" +"PO-Revision-Date: 2019-05-15 11:21+0000\n" "Last-Translator: Tonnes <tonnes.mb(a)gmail.com>\n" "Language-Team: Dutch (http://www.transifex.com/otf/torproject/language/nl/)\n" "MIME-Version: 1.0\n" @@ -118,7 +118,7 @@ msgid "" "Download size: %{size}s\n" "\n" "Do you want to upgrade now?" -msgstr "Je zou moeten upgraden naar %{name}s %{version}s.\n\nVoor meer informatie over deze nieuwe versie, ga naar %{details_url}s\n\nWe raden je aan om alle andere applicaties te sluiten tijdens de upgrade.\nDownloaden van de upgrade kan lang duren, van meerdere minuten tot enkele uren.\n\nDownload grootte: %{size}s\n\nWil je nu upgraden?" +msgstr "U zou een upgrade naar %{name}s %{version}s moeten uitvoeren.\n\nGa voor meer informatie over deze nieuwe versie naar %{details_url}s\n\nWe raden aan alle andere toepassingen te sluiten tijdens de upgrade.\nHet downloaden van de upgrade kan lang duren, van enkele minuten tot een paar uur.\n\nDownloadgrootte: %{size}s\n\nWilt u nu upgraden?" #: ../lib/Tails/IUK/Frontend.pm:386 msgid "Upgrade available"

1 0

[tor/maint-0.3.5] Merge branch 'bug30475_035' into maint-0.3.5
by nickm＠torproject.org 15 May '19

15 May '19

commit 6945f2b3efb65f9812885e91179203621d37dd7a Merge: 231036a11 ff5584034 Author: Nick Mathewson <nickm(a)torproject.org> Date: Wed May 15 07:41:34 2019 -0400 Merge branch 'bug30475_035' into maint-0.3.5 changes/bug30475 | 4 ++++ src/feature/hs/hs_service.c | 4 ++-- 2 files changed, 6 insertions(+), 2 deletions(-)

1 0

[tor/maint-0.3.5] Don't pass a NULL into a %s when logging client auth file load failure
by nickm＠torproject.org 15 May '19

15 May '19

commit ff5584034361154de381874e1a24d0a421aa0631 Author: Nick Mathewson <nickm(a)torproject.org> Date: Fri May 10 17:47:43 2019 -0400 Don't pass a NULL into a %s when logging client auth file load failure Fortunately, in 0.3.5.1-alpha we improved logging for various failure cases involved with onion service client auth. Unfortunately, for this one, we freed the file right before logging its name. Fortunately, tor_free() sets its pointer to NULL, so we didn't have a use-after-free bug. Unfortunately, passing NULL to %s is not defined. Fortunately, GCC 9.1.1 caught the issue! Unfortunately, nobody has actually tried building Tor with GCC 9.1.1 before. Or if they had, they didn't report the warning. Fixes bug 30475; bugfix on 0.3.5.1-alpha. --- changes/bug30475 | 4 ++++ src/feature/hs/hs_service.c | 4 ++-- 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/changes/bug30475 b/changes/bug30475 new file mode 100644 index 000000000..839597b88 --- /dev/null +++ b/changes/bug30475 @@ -0,0 +1,4 @@ + o Minor bugfixes (): + - Avoid a GCC 9.1.1 warning (and possible crash depending on libc + implemenation) when failing to load a hidden service client authorization + file. Fixes bug 30475; bugfix on 0.3.5.1-alpha. diff --git a/src/feature/hs/hs_service.c b/src/feature/hs/hs_service.c index 828ca1da4..402929036 100644 --- a/src/feature/hs/hs_service.c +++ b/src/feature/hs/hs_service.c @@ -1259,16 +1259,16 @@ load_client_keys(hs_service_t *service) client_key_file_path = hs_path_from_filename(client_keys_dir_path, filename); client_key_str = read_file_to_str(client_key_file_path, 0, NULL); - /* Free immediately after using it. */ - tor_free(client_key_file_path); /* If we cannot read the file, continue with the next file. */ if (!client_key_str) { log_warn(LD_REND, "Client authorization file %s can't be read. " "Corrupted or verify permission? Ignoring.", client_key_file_path); + tor_free(client_key_file_path); continue; } + tor_free(client_key_file_path); client = parse_authorized_client(client_key_str); /* Wipe and free immediately after using it. */

1 0

[tor/maint-0.4.0] Merge branch 'bug30475_035' into maint-0.3.5
by nickm＠torproject.org 15 May '19

15 May '19

commit 6945f2b3efb65f9812885e91179203621d37dd7a Merge: 231036a11 ff5584034 Author: Nick Mathewson <nickm(a)torproject.org> Date: Wed May 15 07:41:34 2019 -0400 Merge branch 'bug30475_035' into maint-0.3.5 changes/bug30475 | 4 ++++ src/feature/hs/hs_service.c | 4 ++-- 2 files changed, 6 insertions(+), 2 deletions(-)

1 0

[tor/maint-0.4.0] Merge branch 'maint-0.3.5' into maint-0.4.0
by nickm＠torproject.org 15 May '19

15 May '19

commit 7e3f7ab4060531c28ebf3f544f4ec5196e0424ec Merge: cd264e145 6945f2b3e Author: Nick Mathewson <nickm(a)torproject.org> Date: Wed May 15 07:41:42 2019 -0400 Merge branch 'maint-0.3.5' into maint-0.4.0

1 0

[tor/master] Merge branch 'bug30475_035' into maint-0.3.5
by nickm＠torproject.org 15 May '19

15 May '19

commit 6945f2b3efb65f9812885e91179203621d37dd7a Merge: 231036a11 ff5584034 Author: Nick Mathewson <nickm(a)torproject.org> Date: Wed May 15 07:41:34 2019 -0400 Merge branch 'bug30475_035' into maint-0.3.5 changes/bug30475 | 4 ++++ src/feature/hs/hs_service.c | 4 ++-- 2 files changed, 6 insertions(+), 2 deletions(-)

1 0