April 2019 - tor-commits - lists.torproject.org

[tor/master] Update networkstatus_getinfo_by_purpose() comment
by nickm＠torproject.org 26 Apr '19

26 Apr '19

commit 994b8ba424e0e225b3a3b3923044ff900cedfc12 Author: Neel Chauhan <neel(a)neelc.org> Date: Thu Apr 11 21:36:38 2019 -0400 Update networkstatus_getinfo_by_purpose() comment --- src/feature/nodelist/networkstatus.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/feature/nodelist/networkstatus.c b/src/feature/nodelist/networkstatus.c index 20881112a..db510c975 100644 --- a/src/feature/nodelist/networkstatus.c +++ b/src/feature/nodelist/networkstatus.c @@ -2405,7 +2405,8 @@ networkstatus_getinfo_by_purpose(const char *purpose_string, time_t now) return answer; } -/** Write out router status entries for all our bridge descriptors. */ +/** Write out router status entries for all our bridge descriptors. Here, we + * also mark routers as running. */ void networkstatus_dump_bridge_status_to_file(time_t now) {

1 0

[tor/master] Stop setting routers as running in list_server_status_v1()
by nickm＠torproject.org 26 Apr '19

26 Apr '19

commit 14d700804568ef5624856976b723eafab9e41972 Author: Neel Chauhan <neel(a)neelc.org> Date: Thu Apr 11 21:30:48 2019 -0400 Stop setting routers as running in list_server_status_v1() --- src/feature/control/fmt_serverstatus.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/src/feature/control/fmt_serverstatus.c b/src/feature/control/fmt_serverstatus.c index a1ddd2119..fc1029ae8 100644 --- a/src/feature/control/fmt_serverstatus.c +++ b/src/feature/control/fmt_serverstatus.c @@ -78,10 +78,7 @@ list_server_status_v1(smartlist_t *routers, char **router_status_out, SMARTLIST_FOREACH_BEGIN(routers, routerinfo_t *, ri) { const node_t *node = node_get_by_id(ri->cache_info.identity_digest); tor_assert(node); - if (authdir) { - /* Update router status in routerinfo_t. */ - dirserv_set_router_is_running(ri, now); - } + if (for_controller) { char name_buf[MAX_VERBOSE_NICKNAME_LEN+2]; char *cp = name_buf;

1 0

[tor/master] Remove unused get_options()
by nickm＠torproject.org 26 Apr '19

26 Apr '19

commit cc87acf29b40a135745f74412caaececf8ea0329 Author: Neel Chauhan <neel(a)neelc.org> Date: Sun Apr 14 14:51:42 2019 -0400 Remove unused get_options() --- src/feature/control/fmt_serverstatus.c | 1 - 1 file changed, 1 deletion(-) diff --git a/src/feature/control/fmt_serverstatus.c b/src/feature/control/fmt_serverstatus.c index 1fc5d4a15..d224a1d23 100644 --- a/src/feature/control/fmt_serverstatus.c +++ b/src/feature/control/fmt_serverstatus.c @@ -66,7 +66,6 @@ list_server_status_v1(smartlist_t *routers, char **router_status_out, smartlist_t *rs_entries; time_t now = time(NULL); time_t cutoff = now - ROUTER_MAX_AGE_TO_PUBLISH; - const or_options_t *options = get_options(); /* We include v2 dir auths here too, because they need to answer * controllers. Eventually we'll deprecate this whole function; * see also networkstatus_getinfo_by_purpose(). */

1 0

[tor/master] Merge remote-tracking branch 'tor-github/pr/889'
by nickm＠torproject.org 26 Apr '19

26 Apr '19

commit efeb101b968fe6604ff97604afe527a36b94cfc9 Merge: 36b4fc743 cc87acf29 Author: Nick Mathewson <nickm(a)torproject.org> Date: Thu Apr 25 20:25:34 2019 -0400 Merge remote-tracking branch 'tor-github/pr/889' changes/bug24490 | 5 +++++ src/feature/control/fmt_serverstatus.c | 7 +------ src/feature/dirauth/voteflags.c | 18 ++++++++++++++++++ src/feature/dirauth/voteflags.h | 2 ++ src/feature/nodelist/networkstatus.c | 12 ++++++------ 5 files changed, 32 insertions(+), 12 deletions(-)

1 0

[torspec/master] Merge remote-tracking branch 'tor-github/pr/76'
by nickm＠torproject.org 26 Apr '19

26 Apr '19

commit 8685ffa5edccca5e459a9a9d10e1ce3aee41b462 Merge: 702fdbf cf2e770 Author: Nick Mathewson <nickm(a)torproject.org> Date: Thu Apr 25 20:23:31 2019 -0400 Merge remote-tracking branch 'tor-github/pr/76' control-spec.txt | 4 ++++ 1 file changed, 4 insertions(+)

1 0

[torspec/master] Keep spacing in mind
by nickm＠torproject.org 26 Apr '19

26 Apr '19

commit cf2e770faf7364ff9c3d203146b17cbbce097ba7 Author: Neel Chauhan <neel(a)neelc.org> Date: Wed Apr 17 19:59:55 2019 -0400 Keep spacing in mind --- control-spec.txt | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/control-spec.txt b/control-spec.txt index 615ca51..d3d0a66 100644 --- a/control-spec.txt +++ b/control-spec.txt @@ -634,8 +634,10 @@ queries. [First implemented in 0.2.0.13-alpha.] [In 0.2.0.9-alpha this switched from v2 directory style to v3] - [In versions before 0.4.1.1-alpha we set the Running flag on bridges when /ns/purpose/bridge is accessed] - [In 0.4.1.1-alpha we set the Running flag on bridges when the bridge networkstatus file is written to disk] + [In versions before 0.4.1.1-alpha we set the Running flag on + bridges when /ns/purpose/bridge is accessed] + [In 0.4.1.1-alpha we set the Running flag on bridges when the + bridge networkstatus file is written to disk] "desc/all-recent" -- the latest server descriptor for every router that Tor knows about. (See md note about "desc/id" and "desc/name" above.)

1 0

[torspec/master] Update documentation for ns/purpose/bridge
by nickm＠torproject.org 26 Apr '19

26 Apr '19

commit 77dde55cb72bdb0e41bd7e0ead1d179a7000546a Author: Neel Chauhan <neel(a)neelc.org> Date: Thu Apr 11 21:53:28 2019 -0400 Update documentation for ns/purpose/bridge --- control-spec.txt | 1 + 1 file changed, 1 insertion(+) diff --git a/control-spec.txt b/control-spec.txt index 78a842f..ddd30fb 100644 --- a/control-spec.txt +++ b/control-spec.txt @@ -634,6 +634,7 @@ queries. [First implemented in 0.2.0.13-alpha.] [In 0.2.0.9-alpha this switched from v2 directory style to v3] + [in 0.4.1.1-alpha we stop setting bridges as running here] "desc/all-recent" -- the latest server descriptor for every router that Tor knows about. (See md note about "desc/id" and "desc/name" above.)

1 0

[torspec/master] Make GETINFO ns/purpose/bridge change more descriptive for #24490
by nickm＠torproject.org 26 Apr '19

26 Apr '19

commit 757104405df17e35367ffd5935cd63b432e9a5d7 Author: teor <teor(a)torproject.org> Date: Wed Apr 17 19:58:37 2019 -0400 Make GETINFO ns/purpose/bridge change more descriptive for #24490 Co-Authored-By: neelchauhan <neel(a)neelc.org> --- control-spec.txt | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/control-spec.txt b/control-spec.txt index ddd30fb..615ca51 100644 --- a/control-spec.txt +++ b/control-spec.txt @@ -634,7 +634,8 @@ queries. [First implemented in 0.2.0.13-alpha.] [In 0.2.0.9-alpha this switched from v2 directory style to v3] - [in 0.4.1.1-alpha we stop setting bridges as running here] + [In versions before 0.4.1.1-alpha we set the Running flag on bridges when /ns/purpose/bridge is accessed] + [In 0.4.1.1-alpha we set the Running flag on bridges when the bridge networkstatus file is written to disk] "desc/all-recent" -- the latest server descriptor for every router that Tor knows about. (See md note about "desc/id" and "desc/name" above.)

1 0

[torspec/master] dir-spec: add tor versions to bridge-distribution-request
by nickm＠torproject.org 26 Apr '19

26 Apr '19

commit cbd3ebe177284571170e36739ebf2f6edd900643 Author: teor <teor(a)torproject.org> Date: Thu Apr 18 10:03:44 2019 +1000 dir-spec: add tor versions to bridge-distribution-request --- dir-spec.txt | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/dir-spec.txt b/dir-spec.txt index 3f14470..ce87c22 100644 --- a/dir-spec.txt +++ b/dir-spec.txt @@ -652,13 +652,16 @@ Method = (KeywordChar | "_") + All bridges SHOULD include this line. Non-bridges MUST NOT include - it. (It is not currently implemented, or obeyed by Bridge DB.) + it. (It is currently ignored by Bridge DB.) BridgeDB SHOULD treat unrecognized Method values as if they were "none". (Default: "any") + [This line was introduced in 0.3.2.3-alpha, with a minimal backport + to 0.2.5.16, 0.2.8.17, 0.2.9.14, 0.3.0.13, 0.3.1.10, and later.] + "family" names NL [At most once]

1 0

[torspec/master] dir-spec: Fix a bridge-distribution-request backport version
by nickm＠torproject.org 26 Apr '19

26 Apr '19

commit aea58374148e1700ddd88e22a02869288adcbc89 Author: teor <teor(a)torproject.org> Date: Tue Apr 23 09:35:17 2019 +1000 dir-spec: Fix a bridge-distribution-request backport version Part of 30224. --- dir-spec.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dir-spec.txt b/dir-spec.txt index ce87c22..460d02a 100644 --- a/dir-spec.txt +++ b/dir-spec.txt @@ -660,7 +660,7 @@ (Default: "any") [This line was introduced in 0.3.2.3-alpha, with a minimal backport - to 0.2.5.16, 0.2.8.17, 0.2.9.14, 0.3.0.13, 0.3.1.10, and later.] + to 0.2.5.16, 0.2.8.17, 0.2.9.14, 0.3.0.13, 0.3.1.9, and later.] "family" names NL

1 0