March 2019 - tor-commits - lists.torproject.org

[tor/master] Also add tor_assertf_nonfatal()
by nickm＠torproject.org 29 Mar '19

29 Mar '19

commit b6813845cf3140475f72f1f52638fa04b44c3a1b Author: rl1987 <rl1987(a)sdf.lonestar.org> Date: Tue Mar 5 16:37:14 2019 +0200 Also add tor_assertf_nonfatal() --- src/lib/log/util_bug.c | 17 ++++++++++++++--- src/lib/log/util_bug.h | 28 ++++++++++++++++++++-------- 2 files changed, 34 insertions(+), 11 deletions(-) diff --git a/src/lib/log/util_bug.c b/src/lib/log/util_bug.c index 93a460156..bbc744f0c 100644 --- a/src/lib/log/util_bug.c +++ b/src/lib/log/util_bug.c @@ -96,7 +96,7 @@ tor_assertion_failed_(const char *fname, unsigned int line, void tor_bug_occurred_(const char *fname, unsigned int line, const char *func, const char *expr, - int once) + int once, const char *fmt, ...) { char buf[256]; const char *once_str = once ? @@ -116,11 +116,22 @@ tor_bug_occurred_(const char *fname, unsigned int line, add_captured_bug(expr); return; } + + va_list ap; + char *extra = NULL; + + if (fmt) { + va_start(ap,fmt); + tor_vasprintf(&extra, fmt, ap); + va_end(ap); + } + log_warn(LD_BUG, "%s:%u: %s: Non-fatal assertion %s failed.%s", fname, line, func, expr, once_str); tor_snprintf(buf, sizeof(buf), - "Non-fatal assertion %s failed in %s at %s:%u", - expr, func, fname, line); + "Non-fatal assertion %s failed in %s at %s:%u%s%s", + expr, func, fname, line, fmt ? " : " : "", extra); + tor_free(extra); } log_backtrace(LOG_WARN, LD_BUG, buf); diff --git a/src/lib/log/util_bug.h b/src/lib/log/util_bug.h index c0670a50a..63c5309c9 100644 --- a/src/lib/log/util_bug.h +++ b/src/lib/log/util_bug.h @@ -143,6 +143,7 @@ #ifdef ALL_BUGS_ARE_FATAL #define tor_assert_nonfatal_unreached() tor_assert(0) #define tor_assert_nonfatal(cond) tor_assert((cond)) +#define tor_assertf_nonfatal(cond, fmt, ...) tor_assertf(cond, fmt, ...) #define tor_assert_nonfatal_unreached_once() tor_assert(0) #define tor_assert_nonfatal_once(cond) tor_assert((cond)) #define BUG(cond) \ @@ -153,24 +154,35 @@ #elif defined(TOR_UNIT_TESTS) && defined(DISABLE_ASSERTS_IN_UNIT_TESTS) #define tor_assert_nonfatal_unreached() STMT_NIL #define tor_assert_nonfatal(cond) ((void)(cond)) +#define tor_assertf_nonfatal(cond, fmt, ...) STMT_BEGIN \ + (void)cond; \ + (void)fmt; \ + STMT_END #define tor_assert_nonfatal_unreached_once() STMT_NIL #define tor_assert_nonfatal_once(cond) ((void)(cond)) #define BUG(cond) (ASSERT_PREDICT_UNLIKELY_(cond) ? 1 : 0) #else /* Normal case, !ALL_BUGS_ARE_FATAL, !DISABLE_ASSERTS_IN_UNIT_TESTS */ #define tor_assert_nonfatal_unreached() STMT_BEGIN \ - tor_bug_occurred_(SHORT_FILE__, __LINE__, __func__, NULL, 0); \ + tor_bug_occurred_(SHORT_FILE__, __LINE__, __func__, NULL, 0, NULL); \ STMT_END #define tor_assert_nonfatal(cond) STMT_BEGIN \ if (ASSERT_PREDICT_LIKELY_(cond)) { \ } else { \ - tor_bug_occurred_(SHORT_FILE__, __LINE__, __func__, #cond, 0); \ + tor_bug_occurred_(SHORT_FILE__, __LINE__, __func__, #cond, 0, NULL);\ + } \ + STMT_END +#define tor_assertf_nonfatal(cond, fmt, ...) STMT_BEGIN \ + if (ASSERT_PREDICT_UNLIKELY_(cond)) { \ + } else { \ + tor_bug_occurred_(SHORT_FILE__, __LINE__, __func__, #cond, 0, \ + fmt, ##__VA_ARGS__); \ } \ STMT_END #define tor_assert_nonfatal_unreached_once() STMT_BEGIN \ static int warning_logged__ = 0; \ if (!warning_logged__) { \ warning_logged__ = 1; \ - tor_bug_occurred_(SHORT_FILE__, __LINE__, __func__, NULL, 1); \ + tor_bug_occurred_(SHORT_FILE__, __LINE__, __func__, NULL, 1, NULL); \ } \ STMT_END #define tor_assert_nonfatal_once(cond) STMT_BEGIN \ @@ -178,12 +190,12 @@ if (ASSERT_PREDICT_LIKELY_(cond)) { \ } else if (!warning_logged__) { \ warning_logged__ = 1; \ - tor_bug_occurred_(SHORT_FILE__, __LINE__, __func__, #cond, 1); \ + tor_bug_occurred_(SHORT_FILE__, __LINE__, __func__, #cond, 1, NULL);\ } \ STMT_END #define BUG(cond) \ (ASSERT_PREDICT_UNLIKELY_(cond) ? \ - (tor_bug_occurred_(SHORT_FILE__,__LINE__,__func__,"!("#cond")",0), 1) \ + (tor_bug_occurred_(SHORT_FILE__,__LINE__,__func__,"!("#cond")",1,NULL),1) \ : 0) #endif /* defined(ALL_BUGS_ARE_FATAL) || ... */ @@ -195,7 +207,7 @@ if (bool_result && !var) { \ var = 1; \ tor_bug_occurred_(SHORT_FILE__, __LINE__, __func__, \ - "!("#cond")", 1); \ + "!("#cond")", 1, NULL); \ } \ bool_result; } )) #else /* !(defined(__GNUC__)) */ @@ -205,7 +217,7 @@ (var ? 1 : \ (var=1, \ tor_bug_occurred_(SHORT_FILE__, __LINE__, __func__, \ - "!("#cond")", 1), \ + "!("#cond")", 1, NULL), \ 1)) \ : 0) #endif /* defined(__GNUC__) */ @@ -232,7 +244,7 @@ void tor_assertion_failed_(const char *fname, unsigned int line, const char *fmt, ...); void tor_bug_occurred_(const char *fname, unsigned int line, const char *func, const char *expr, - int once); + int once, const char *fmt, ...); #ifdef _WIN32 #define SHORT_FILE__ (tor_fix_source_file(__FILE__))

1 0

[tor/master] Add changes file
by nickm＠torproject.org 29 Mar '19

29 Mar '19

commit bf953fe602a973259723dacb4389d3c4bee7e0a4 Author: rl1987 <rl1987(a)sdf.lonestar.org> Date: Tue Mar 5 18:02:24 2019 +0200 Add changes file --- changes/ticket29662 | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/changes/ticket29662 b/changes/ticket29662 new file mode 100644 index 000000000..872df9ad8 --- /dev/null +++ b/changes/ticket29662 @@ -0,0 +1,5 @@ + o Minor features (debugging): + - Introduce tor_assertf() and tor_assertf_nonfatal() to enable logging of + additional information during assert failure. Now we can use format + strings to include pieces of information that are relevant for trouble + shooting. Resolves ticket 29662.

1 0

[tor/master] Introduce tor_assertf() to allow logging extra error message on assert failure
by nickm＠torproject.org 29 Mar '19

29 Mar '19

commit f236c9e7f91f8844d004164d6202915a5c78e6d6 Author: rl1987 <rl1987(a)sdf.lonestar.org> Date: Sun Mar 18 14:56:59 2018 +0100 Introduce tor_assertf() to allow logging extra error message on assert failure With format string support! --- src/lib/log/util_bug.c | 17 ++++++++++++++--- src/lib/log/util_bug.h | 16 ++++++++++++---- 2 files changed, 26 insertions(+), 7 deletions(-) diff --git a/src/lib/log/util_bug.c b/src/lib/log/util_bug.c index f42d2d2ab..93a460156 100644 --- a/src/lib/log/util_bug.c +++ b/src/lib/log/util_bug.c @@ -70,14 +70,25 @@ tor_set_failed_assertion_callback(void (*fn)(void)) /** Helper for tor_assert: report the assertion failure. */ void tor_assertion_failed_(const char *fname, unsigned int line, - const char *func, const char *expr) + const char *func, const char *expr, + const char *fmt, ...) { char buf[256]; + char *extra = NULL; + va_list ap; + + if (fmt) { + va_start(ap,fmt); + tor_vasprintf(&extra, fmt, ap); + va_end(ap); + } + log_err(LD_BUG, "%s:%u: %s: Assertion %s failed; aborting.", fname, line, func, expr); tor_snprintf(buf, sizeof(buf), - "Assertion %s failed in %s at %s:%u", - expr, func, fname, line); + "Assertion %s failed in %s at %s:%u: %s", + expr, func, fname, line, extra ? extra : ""); + tor_free(extra); log_backtrace(LOG_ERR, LD_BUG, buf); } diff --git a/src/lib/log/util_bug.h b/src/lib/log/util_bug.h index 18d40bbf3..c0670a50a 100644 --- a/src/lib/log/util_bug.h +++ b/src/lib/log/util_bug.h @@ -92,13 +92,20 @@ #define tor_assert(a) STMT_BEGIN \ (void)(a); \ STMT_END +#define tor_assertf(a, fmt, ...) STMT_BEGIN \ + (void)(a); \ + (void)(fmt); \ + STMT_END #else /** Like assert(3), but send assertion failures to the log as well as to * stderr. */ -#define tor_assert(expr) STMT_BEGIN \ +#define tor_assert(expr) tor_assertf(expr, NULL) + +#define tor_assertf(expr, fmt, ...) STMT_BEGIN \ if (ASSERT_PREDICT_LIKELY_(expr)) { \ } else { \ - tor_assertion_failed_(SHORT_FILE__, __LINE__, __func__, #expr); \ + tor_assertion_failed_(SHORT_FILE__, __LINE__, __func__, #expr, \ + fmt, ##__VA_ARGS__); \ abort(); \ } STMT_END #endif /* defined(TOR_UNIT_TESTS) && defined(DISABLE_ASSERTS_IN_UNIT_TESTS) */ @@ -106,7 +113,7 @@ #define tor_assert_unreached() \ STMT_BEGIN { \ tor_assertion_failed_(SHORT_FILE__, __LINE__, __func__, \ - "line should be unreached"); \ + "line should be unreached", NULL); \ abort(); \ } STMT_END @@ -221,7 +228,8 @@ #define tor_fragile_assert() tor_assert_nonfatal_unreached_once() void tor_assertion_failed_(const char *fname, unsigned int line, - const char *func, const char *expr); + const char *func, const char *expr, + const char *fmt, ...); void tor_bug_occurred_(const char *fname, unsigned int line, const char *func, const char *expr, int once);

1 0

[tor/master] Silence compiler warnings
by nickm＠torproject.org 29 Mar '19

29 Mar '19

commit f66a17444e4a83e548985784956f321e9e1e1ab2 Author: rl1987 <rl1987(a)sdf.lonestar.org> Date: Tue Mar 5 17:02:03 2019 +0200 Silence compiler warnings --- src/lib/log/util_bug.c | 16 ++++++++++++++++ 1 file changed, 16 insertions(+) diff --git a/src/lib/log/util_bug.c b/src/lib/log/util_bug.c index bbc744f0c..1ce48c0eb 100644 --- a/src/lib/log/util_bug.c +++ b/src/lib/log/util_bug.c @@ -69,6 +69,7 @@ tor_set_failed_assertion_callback(void (*fn)(void)) /** Helper for tor_assert: report the assertion failure. */ void +CHECK_PRINTF(5, 6) tor_assertion_failed_(const char *fname, unsigned int line, const char *func, const char *expr, const char *fmt, ...) @@ -77,11 +78,18 @@ tor_assertion_failed_(const char *fname, unsigned int line, char *extra = NULL; va_list ap; +#ifdef __clang__ +#pragma clang diagnostic push +#pragma clang diagnostic ignored "-Wformat-nonliteral" +#endif if (fmt) { va_start(ap,fmt); tor_vasprintf(&extra, fmt, ap); va_end(ap); } +#ifdef __clang__ +#pragma clang diagnostic pop +#endif log_err(LD_BUG, "%s:%u: %s: Assertion %s failed; aborting.", fname, line, func, expr); @@ -94,6 +102,7 @@ tor_assertion_failed_(const char *fname, unsigned int line, /** Helper for tor_assert_nonfatal: report the assertion failure. */ void +CHECK_PRINTF(6, 7) tor_bug_occurred_(const char *fname, unsigned int line, const char *func, const char *expr, int once, const char *fmt, ...) @@ -120,11 +129,18 @@ tor_bug_occurred_(const char *fname, unsigned int line, va_list ap; char *extra = NULL; +#ifdef __clang__ +#pragma clang diagnostic push +#pragma clang diagnostic ignored "-Wformat-nonliteral" +#endif if (fmt) { va_start(ap,fmt); tor_vasprintf(&extra, fmt, ap); va_end(ap); } +#ifdef __clang__ +#pragma clang diagnostic pop +#endif log_warn(LD_BUG, "%s:%u: %s: Non-fatal assertion %s failed.%s", fname, line, func, expr, once_str);

1 0

[tor/master] Refrain from using static buffer for assert failure message; call tor_asprintf() instead
by nickm＠torproject.org 29 Mar '19

29 Mar '19

commit 9c132a5f9e87a2cd0f59bd8d21226ba2256f7bce Author: rl1987 <rl1987(a)sdf.lonestar.org> Date: Fri Mar 22 13:44:02 2019 +0200 Refrain from using static buffer for assert failure message; call tor_asprintf() instead --- src/lib/log/util_bug.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/src/lib/log/util_bug.c b/src/lib/log/util_bug.c index 1ce48c0eb..e5d5a2958 100644 --- a/src/lib/log/util_bug.c +++ b/src/lib/log/util_bug.c @@ -74,7 +74,7 @@ tor_assertion_failed_(const char *fname, unsigned int line, const char *func, const char *expr, const char *fmt, ...) { - char buf[256]; + char *buf = NULL; char *extra = NULL; va_list ap; @@ -93,11 +93,11 @@ tor_assertion_failed_(const char *fname, unsigned int line, log_err(LD_BUG, "%s:%u: %s: Assertion %s failed; aborting.", fname, line, func, expr); - tor_snprintf(buf, sizeof(buf), - "Assertion %s failed in %s at %s:%u: %s", + tor_asprintf(&buf, "Assertion %s failed in %s at %s:%u: %s", expr, func, fname, line, extra ? extra : ""); tor_free(extra); log_backtrace(LOG_ERR, LD_BUG, buf); + tor_free(buf); } /** Helper for tor_assert_nonfatal: report the assertion failure. */ @@ -107,7 +107,7 @@ tor_bug_occurred_(const char *fname, unsigned int line, const char *func, const char *expr, int once, const char *fmt, ...) { - char buf[256]; + char *buf = NULL; const char *once_str = once ? " (Future instances of this warning will be silenced.)": ""; if (! expr) { @@ -144,12 +144,12 @@ tor_bug_occurred_(const char *fname, unsigned int line, log_warn(LD_BUG, "%s:%u: %s: Non-fatal assertion %s failed.%s", fname, line, func, expr, once_str); - tor_snprintf(buf, sizeof(buf), - "Non-fatal assertion %s failed in %s at %s:%u%s%s", + tor_asprintf(&buf, "Non-fatal assertion %s failed in %s at %s:%u%s%s", expr, func, fname, line, fmt ? " : " : "", extra); tor_free(extra); } log_backtrace(LOG_WARN, LD_BUG, buf); + tor_free(buf); #ifdef TOR_UNIT_TESTS if (failed_assertion_cb) {

1 0

[tor/master] Check for NULL in tor_assertf_nonfatal()
by nickm＠torproject.org 29 Mar '19

29 Mar '19

commit 537ad0bca3479c10fc7d1093aff534be11800dcb Author: rl1987 <rl1987(a)sdf.lonestar.org> Date: Fri Mar 29 18:38:27 2019 +0200 Check for NULL in tor_assertf_nonfatal() --- src/lib/log/util_bug.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/lib/log/util_bug.c b/src/lib/log/util_bug.c index e5d5a2958..b9dc296fc 100644 --- a/src/lib/log/util_bug.c +++ b/src/lib/log/util_bug.c @@ -145,7 +145,8 @@ tor_bug_occurred_(const char *fname, unsigned int line, log_warn(LD_BUG, "%s:%u: %s: Non-fatal assertion %s failed.%s", fname, line, func, expr, once_str); tor_asprintf(&buf, "Non-fatal assertion %s failed in %s at %s:%u%s%s", - expr, func, fname, line, fmt ? " : " : "", extra); + expr, func, fname, line, fmt ? " : " : "", + extra ? extra : ""); tor_free(extra); } log_backtrace(LOG_WARN, LD_BUG, buf);

1 0

[tor/master] allow circuituse.c to get even longer.
by nickm＠torproject.org 29 Mar '19

29 Mar '19

commit f0e39df5ce7b884ae6ff1c8579200886e298f44c Author: Nick Mathewson <nickm(a)torproject.org> Date: Fri Mar 29 14:30:33 2019 -0400 allow circuituse.c to get even longer. --- scripts/maint/practracker/exceptions.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/maint/practracker/exceptions.txt b/scripts/maint/practracker/exceptions.txt index cd56eba0e..ad5d3e972 100644 --- a/scripts/maint/practracker/exceptions.txt +++ b/scripts/maint/practracker/exceptions.txt @@ -92,7 +92,7 @@ problem function-size /src/core/or/circuitlist.c:circuits_handle_oom() 117 problem function-size /src/core/or/circuitmux.c:circuitmux_set_policy() 110 problem function-size /src/core/or/circuitmux.c:circuitmux_attach_circuit() 114 problem function-size /src/core/or/circuitstats.c:circuit_build_times_parse_state() 124 -problem file-size /src/core/or/circuituse.c 3150 +problem file-size /src/core/or/circuituse.c 3152 problem function-size /src/core/or/circuituse.c:circuit_is_acceptable() 129 problem function-size /src/core/or/circuituse.c:circuit_expire_building() 394 problem function-size /src/core/or/circuituse.c:circuit_log_ancient_one_hop_circuits() 126

1 0

[tor/master] Merge branch 'ticket29662_squashed' into ticket29662_squashed_merged
by nickm＠torproject.org 29 Mar '19

29 Mar '19

commit 9ed02ec2824059b9c18c2cadfd972c8a2e09b94c Merge: 00ca3d04c 537ad0bca Author: Nick Mathewson <nickm(a)torproject.org> Date: Fri Mar 29 14:28:48 2019 -0400 Merge branch 'ticket29662_squashed' into ticket29662_squashed_merged changes/ticket29662 | 5 ++++ src/core/or/circuituse.c | 4 +++- src/lib/log/util_bug.c | 59 ++++++++++++++++++++++++++++++++++++++-------- src/lib/log/util_bug.h | 44 ++++++++++++++++++++++++---------- src/test/test_bt_cl.c | 2 +- src/test/testing_rsakeys.c | 3 ++- 6 files changed, 92 insertions(+), 25 deletions(-)

1 0

[translation/https_everywhere_completed] Update translations for https_everywhere_completed
by translation＠torproject.org 29 Mar '19

29 Mar '19

commit bbdfe6305e04d8080ec7326956f1aea294e51d42 Author: Translation commit bot <translation(a)torproject.org> Date: Fri Mar 29 19:46:05 2019 +0000 Update translations for https_everywhere_completed --- lt/ssl-observatory.dtd | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/lt/ssl-observatory.dtd b/lt/ssl-observatory.dtd index b5e873801..89afafe1e 100644 --- a/lt/ssl-observatory.dtd +++ b/lt/ssl-observatory.dtd @@ -70,7 +70,7 @@ gautas liudijimas rodys, kad kažkas apsilankė www.kazkas.com, tačiau nerodys to, kas apsilankė svetainėje, ar kokį konkrečiai puslapį jie žiūrėjo. Išsamesnei informacijai, užveskite pelės žymeklį virš parametrų:"> -<!ENTITY ssl-observatory.prefs.hide "Slėpti išsamesnius nustatymus"> +<!ENTITY ssl-observatory.prefs.hide "Slėpti išplėstinius parametrus"> <!ENTITY ssl-observatory.prefs.nonanon "Tikrinti sertifikatus net jei Tor nepasiekiamas"> @@ -84,14 +84,14 @@ tačiau nerodys to, kas apsilankė svetainėje, ar kokį konkrečiai puslapį ji <!ENTITY ssl-observatory.prefs.priv_dns_tooltip "Jei šis parametras išjungtas, Observatorija neįrašinės tų liudijimų, kurių vardų nepavyksta gauti per DNS sistemą."> -<!ENTITY ssl-observatory.prefs.show "Rodyti išsamesnius nustatymus"> +<!ENTITY ssl-observatory.prefs.show "Rodyti išplėstinius parametrus"> <!ENTITY ssl-observatory.prefs.title "SSL Observatorijos nustatymai"> <!ENTITY ssl-observatory.prefs.use "Naudoti Observatoriją?"> <!ENTITY ssl-observatory.warning.title "ĮSPĖJIMAS iš EFF SSL Observatorijos"> <!ENTITY ssl-observatory.warning.showcert "Rodyti sertifikatų grandinę"> -<!ENTITY ssl-observatory.warning.okay "Suprantu"> +<!ENTITY ssl-observatory.warning.okay "Aš suprantu"> <!ENTITY ssl-observatory.warning.text "EFF SSL Observatorija įspėja apie šios svetainės HTTPS liudijimą(-us):"> <!ENTITY ssl-observatory.warning.defense "Jeigu esate prisijungę prie šios svetainės, gali būti patariama, kai turėsite saugų ryšį, pasikeisti savo slaptažodį. (Šie įspėjimai gali būti išjungti "SSL Observatorijos" kortelėje, HTTPS Everywhere nuostatų dialoge.)">

1 0

[translation/https_everywhere] Update translations for https_everywhere
by translation＠torproject.org 29 Mar '19

29 Mar '19

commit 5269d6db72919c9d779dad55866f9db101bfb021 Author: Translation commit bot <translation(a)torproject.org> Date: Fri Mar 29 19:45:56 2019 +0000 Update translations for https_everywhere --- lt/https-everywhere.dtd | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/lt/https-everywhere.dtd b/lt/https-everywhere.dtd index 8e5ac586f..d181757c8 100644 --- a/lt/https-everywhere.dtd +++ b/lt/https-everywhere.dtd @@ -1,13 +1,13 @@ <!ENTITY https-everywhere.about.title "Apie HTTPS Everywhere"> <!ENTITY https-everywhere.about.ext_name "HTTPS Everywhere"> -<!ENTITY https-everywhere.about.ext_description "Šifruokite saityną! Automatiškai naudokite HTTPS apsaugą daugelyje svetainių."> +<!ENTITY https-everywhere.about.ext_description "Šifruokite saityną! Automatiškai naudokite HTTPS saugumą daugelyje svetainių."> <!ENTITY https-everywhere.about.version "Versija"> <!ENTITY https-everywhere.about.rulesets_version "Taisyklių rinkinio versija"> <!ENTITY https-everywhere.about.add_new_rule "Pridėti naują taisyklę"> <!ENTITY https-everywhere.menu.donate_eff_imperative "Paaukoti EFF"> -<!ENTITY https-everywhere.menu.observatory "SSL Observatorijos nustatymai"> -<!ENTITY https-everywhere.menu.globalEnable "Įgalinti HTTPS Everywhere"> +<!ENTITY https-everywhere.menu.observatory "SSL observatorijos nuostatos"> +<!ENTITY https-everywhere.menu.globalEnable "Įjungti HTTPS Everywhere"> <!ENTITY https-everywhere.menu.encryptAllSitesEligible "Encrypt All Sites Eligible (EASE)"> <!ENTITY https-everywhere.menu.showCounter "Rodyti skaitiklį"> <!ENTITY https-everywhere.menu.viewAllRules "Žiūrėti visas taisykles">

1 0