December 2019 - tor-commits - lists.torproject.org

[tor/master] Add a changes file for ticket 32172.
by nickm＠torproject.org 17 Dec '19

17 Dec '19

commit fefa08df752c87a16b4a203576670c0501736c98 Author: Nick Mathewson <nickm(a)torproject.org> Date: Tue Dec 10 10:54:45 2019 -0500 Add a changes file for ticket 32172. --- changes/ticket32172 | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/changes/ticket32172 b/changes/ticket32172 new file mode 100644 index 000000000..a66161799 --- /dev/null +++ b/changes/ticket32172 @@ -0,0 +1,4 @@ + o Minor features (tests, Android): + - When running the unit tests on Android, create temporary files + in a subdirectory of /data/local/tmp. Closes ticket + 32172. Based on a patch from Hans-Christoph Steiner.

1 0

[tor/master] set up tmp dir for test suite to run on Android
by nickm＠torproject.org 17 Dec '19

17 Dec '19

commit 4d4cbf739f24dae421ba5509d084becb50deaf6a Author: Hans-Christoph Steiner <hans(a)eds.org> Date: Wed Oct 16 18:52:36 2019 +0200 set up tmp dir for test suite to run on Android There is no /tmp or mkdtemp on Android, there is /data/local/tmp for root and the shell user. So this fakes mkdtemp. Also, FYI, tor might not like the default perms of /data/local/tmp, e.g. 0770. https://trac.torproject.org/projects/tor/ticket/32172 --- src/test/testing_common.c | 11 +++++++++++ 1 file changed, 11 insertions(+) diff --git a/src/test/testing_common.c b/src/test/testing_common.c index c28d02be7..378a6f192 100644 --- a/src/test/testing_common.c +++ b/src/test/testing_common.c @@ -89,6 +89,17 @@ setup_directory(void) (int)getpid(), rnd32); r = mkdir(temp_dir); } +#elif defined(__ANDROID__) + /* tor might not like the default perms, so create a subdir */ + tor_snprintf(temp_dir, sizeof(temp_dir), + "/data/local/tmp/tor_%d_%d_%s", + (int) getuid(), (int) getpid(), rnd32); + r = mkdir(temp_dir, 0700); + if (r) { + fprintf(stderr, "Can't create directory %s:", temp_dir); + perror(""); + exit(1); + } #else /* !defined(_WIN32) */ tor_snprintf(temp_dir, sizeof(temp_dir), "/tmp/tor_test_%d_%s", (int) getpid(), rnd32);

1 0

[tor-browser-build/master] Fold in stable changelog for 9.0.3
by sysrqb＠torproject.org 17 Dec '19

17 Dec '19

commit 38624f870024a93c907c15e6a16838faedda8ead Author: Matthew Finkel <sysrqb(a)torproject.org> Date: Tue Dec 17 18:53:54 2019 +0000 Fold in stable changelog for 9.0.3 --- projects/tor-browser/Bundle-Data/Docs/ChangeLog.txt | 21 +++++++++++++++++++++ 1 file changed, 21 insertions(+) diff --git a/projects/tor-browser/Bundle-Data/Docs/ChangeLog.txt b/projects/tor-browser/Bundle-Data/Docs/ChangeLog.txt index c4866d4..fd891e0 100644 --- a/projects/tor-browser/Bundle-Data/Docs/ChangeLog.txt +++ b/projects/tor-browser/Bundle-Data/Docs/ChangeLog.txt @@ -1,3 +1,24 @@ +Tor Browser 9.0.2 -- December 3 2019 + * All Platforms + * Update Firefox to 68.3.0esr + * Bump NoScript to 11.0.9 + * Bug 32362: NoScript TRUSTED setting doesn't work + * Bug 32429: Issues with about:blank and NoScript on .onion sites + * Bump HTTPS Everywhere to 2019.11.7 + * Bug 27268: Preferences clean-up in Torbutton code + * Translations update + * Windows + OS X + Linux + * Bug 32125: Fix circuit display for bridge without a fingerprint + * Bug 32250: Backport enhanced letterboxing support (bug 1546832 and 1556017) + * Windows + * Bug 31989: Backport backout of old mingw-gcc patch + * Bug 32616: Disable GetSecureOutputDirectoryPath() functionality + * Android + * Bug 32365: Localization is broken in Tor Browser 9 on Android + * Build System + * All Platforms + * Bug 32413: Bump Go version to 1.12.13 + Tor Browser 9.5a3 -- December 3 2019 * All Platforms * Update Firefox to 68.3.0esr

1 0

[tor-browser/tor-browser-68.3.0esr-9.0-1] Bug #32405: Crash immediately after bootstrap on Android
by sysrqb＠torproject.org 17 Dec '19

17 Dec '19

commit 4eb56ec0936e03dcc5d7e83322961c986065dc5d Author: sisbell <shane.isbell(a)gmail.com> Date: Wed Nov 27 21:08:02 2019 -0800 Bug #32405: Crash immediately after bootstrap on Android --- mobile/android/base/java/org/mozilla/gecko/BrowserApp.java | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/mobile/android/base/java/org/mozilla/gecko/BrowserApp.java b/mobile/android/base/java/org/mozilla/gecko/BrowserApp.java index 36f0b0dbb66c..38dac85ef3bc 100644 --- a/mobile/android/base/java/org/mozilla/gecko/BrowserApp.java +++ b/mobile/android/base/java/org/mozilla/gecko/BrowserApp.java @@ -3032,7 +3032,10 @@ public class BrowserApp extends GeckoApp // When the content loaded in the background (such as about:tor), // it was loaded while mBrowserChrome was GONE. We should refresh the // height now so the page is rendered correctly. - Tabs.getInstance().getSelectedTab().doReload(true); + final Tab currentTab = Tabs.getInstance().getSelectedTab(); + if (currentTab != null) { + currentTab.doReload(true); + } // If we finished, then Tor bootstrapped 100% mTorNeedsStart = false;

1 0

[tor/master] Document high-level architecture goals
by nickm＠torproject.org 17 Dec '19

17 Dec '19

commit 0fd49c6663e3950092ec7436a43dc4154740df68 Author: Taylor Yu <catalyst(a)torproject.org> Date: Sun Dec 8 17:07:34 2019 -0600 Document high-level architecture goals Create a high-level description of the long-term software architecture goals. Closes ticket 32206. --- changes/ticket32206 | 3 +++ src/arch_goals.md | 31 +++++++++++++++++++++++++++++++ src/mainpage.md | 2 ++ 3 files changed, 36 insertions(+) diff --git a/changes/ticket32206 b/changes/ticket32206 new file mode 100644 index 000000000..7ced81853 --- /dev/null +++ b/changes/ticket32206 @@ -0,0 +1,3 @@ + o Documentation: + - Create a high-level description of the long-term software + architecture goals. Closes ticket 32206. diff --git a/src/arch_goals.md b/src/arch_goals.md new file mode 100644 index 000000000..92c86d9df --- /dev/null +++ b/src/arch_goals.md @@ -0,0 +1,31 @@ +@page arch_goals High level code design practices + +This page describes the high level design practices for Tor's code. +This design is a long-term goal of what we want our code to look like, +rather than a description of how it currently is. + +Overall, we want various parts of tor's code to interact with each +other through a small number of interfaces. + +We want to avoid having "god objects" or "god modules". These are +objects or modules that know far too much about other parts of the +code. God objects/modules are generally recognized to be an +antipattern of software design. + +Historically, there have been modules in tor that have tended toward +becoming god modules. These include modules that help more +specialized code communicate with the outside world: the configuration +and control modules, for example. Others are modules that deal with +global state, initialization, or shutdown. + +If a centralized module needs to invoke code in almost every other +module in the system, it is better if it exports a small, general +interface that other modules call. The centralized module should not +explicitly call out to all the modules that interact with it. + +Instead, modules that interact with the centralized module should call +registration interfaces. These interfaces allow modules to register +handlers for things like configuration parsing and control command +execution. (The config and control modules are examples of this.) +Alternatively, registration can happen through statically initialized +data structures. (The subsystem mechanism is an example of this.) diff --git a/src/mainpage.md b/src/mainpage.md index 3901e7955..8a7357881 100644 --- a/src/mainpage.md +++ b/src/mainpage.md @@ -29,6 +29,8 @@ Tor repository. @subpage intro +@subpage arch_goals + @subpage initialization @subpage dataflow

1 0

[tor/master] Merge remote-tracking branch 'tor-github/pr/1596'
by nickm＠torproject.org 17 Dec '19

17 Dec '19

commit 5f9808d1d799c39f014ce3175779123aabc6058b Merge: 47d69d981 0fd49c666 Author: Nick Mathewson <nickm(a)torproject.org> Date: Tue Dec 17 09:39:50 2019 -0500 Merge remote-tracking branch 'tor-github/pr/1596' changes/ticket32206 | 3 +++ src/arch_goals.md | 31 +++++++++++++++++++++++++++++++ src/mainpage.md | 2 ++ 3 files changed, 36 insertions(+)

1 0

[tor/master] Merge branch 'tor-github/pr/1608'
by dgoulet＠torproject.org 17 Dec '19

17 Dec '19

commit 47d69d981e63200c519e9bd9d358da9887c3c7ae Merge: fa791b840 f684fd79e Author: David Goulet <dgoulet(a)torproject.org> Date: Tue Dec 17 09:30:19 2019 -0500 Merge branch 'tor-github/pr/1608' src/test/test_hs_client.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

1 0

[tor/master] Remove extra space from helper_get_circ_and_stream_for_test() call in test_e2e_rend_circuit_setup()
by dgoulet＠torproject.org 17 Dec '19

17 Dec '19

commit f684fd79e994fbd9f626b14b81b82b03061eacab Author: Neel Chauhan <neel(a)neelc.org> Date: Mon Dec 16 14:19:55 2019 -0500 Remove extra space from helper_get_circ_and_stream_for_test() call in test_e2e_rend_circuit_setup() --- src/test/test_hs_client.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/test/test_hs_client.c b/src/test/test_hs_client.c index ab586a1de..74a76993f 100644 --- a/src/test/test_hs_client.c +++ b/src/test/test_hs_client.c @@ -306,7 +306,7 @@ test_e2e_rend_circuit_setup(void *arg) mock_connection_ap_handshake_send_begin); /* Setup */ - retval = helper_get_circ_and_stream_for_test( &or_circ, &conn, 0); + retval = helper_get_circ_and_stream_for_test(&or_circ, &conn, 0); tt_int_op(retval, OP_EQ, 0); tt_assert(or_circ); tt_assert(conn);

1 0

[tor/master] Compact lines in test_e2e_rend_circuit_setup()
by dgoulet＠torproject.org 17 Dec '19

17 Dec '19

commit ec35593e4253fc148c7b55a9e27f3b399489fc59 Author: Neel Chauhan <neel(a)neelc.org> Date: Mon Dec 16 14:23:09 2019 -0500 Compact lines in test_e2e_rend_circuit_setup() --- src/test/test_hs_client.c | 11 ++++------- src/test/test_hs_service.c | 11 ++++------- 2 files changed, 8 insertions(+), 14 deletions(-) diff --git a/src/test/test_hs_client.c b/src/test/test_hs_client.c index ab586a1de..7d737b2a3 100644 --- a/src/test/test_hs_client.c +++ b/src/test/test_hs_client.c @@ -322,9 +322,8 @@ test_e2e_rend_circuit_setup(void *arg) /**********************************************/ /* Setup the circuit */ - retval = hs_circuit_setup_e2e_rend_circ(or_circ, - ntor_key_seed, sizeof(ntor_key_seed), - 0); + retval = hs_circuit_setup_e2e_rend_circ(or_circ, ntor_key_seed, + sizeof(ntor_key_seed), 0); tt_int_op(retval, OP_EQ, 0); /**********************************************/ @@ -334,11 +333,9 @@ test_e2e_rend_circuit_setup(void *arg) tt_int_op(retval, OP_EQ, 1); /* Check that the crypt path has prop224 algorithm parameters */ - tt_int_op( - crypto_digest_get_algorithm(or_circ->cpath->pvt_crypto.f_digest), + tt_int_op(crypto_digest_get_algorithm(or_circ->cpath->pvt_crypto.f_digest), OP_EQ, DIGEST_SHA3_256); - tt_int_op( - crypto_digest_get_algorithm(or_circ->cpath->pvt_crypto.b_digest), + tt_int_op(crypto_digest_get_algorithm(or_circ->cpath->pvt_crypto.b_digest), OP_EQ, DIGEST_SHA3_256); tt_assert(or_circ->cpath->pvt_crypto.f_crypto); tt_assert(or_circ->cpath->pvt_crypto.b_crypto); diff --git a/src/test/test_hs_service.c b/src/test/test_hs_service.c index 45c8cb984..daed1cda8 100644 --- a/src/test/test_hs_service.c +++ b/src/test/test_hs_service.c @@ -183,9 +183,8 @@ test_e2e_rend_circuit_setup(void *arg) /* Setup the circuit: do the ntor key exchange */ { uint8_t ntor_key_seed[DIGEST256_LEN] = {2}; - retval = hs_circuit_setup_e2e_rend_circ(or_circ, - ntor_key_seed, sizeof(ntor_key_seed), - 1); + retval = hs_circuit_setup_e2e_rend_circ(or_circ, ntor_key_seed, + sizeof(ntor_key_seed), 1); tt_int_op(retval, OP_EQ, 0); } @@ -194,11 +193,9 @@ test_e2e_rend_circuit_setup(void *arg) tt_int_op(retval, OP_EQ, 1); /* Check the digest algo */ - tt_int_op( - crypto_digest_get_algorithm(or_circ->cpath->pvt_crypto.f_digest), + tt_int_op(crypto_digest_get_algorithm(or_circ->cpath->pvt_crypto.f_digest), OP_EQ, DIGEST_SHA3_256); - tt_int_op( - crypto_digest_get_algorithm(or_circ->cpath->pvt_crypto.b_digest), + tt_int_op(crypto_digest_get_algorithm(or_circ->cpath->pvt_crypto.b_digest), OP_EQ, DIGEST_SHA3_256); tt_assert(or_circ->cpath->pvt_crypto.f_crypto); tt_assert(or_circ->cpath->pvt_crypto.b_crypto);

1 0

[tor/master] Merge branch 'tor-github/pr/1609'
by dgoulet＠torproject.org 17 Dec '19

17 Dec '19

commit fa791b840afcbc690ea9c4edd2e6ddc5136927a9 Merge: 11c8c4f23 ec35593e4 Author: David Goulet <dgoulet(a)torproject.org> Date: Tue Dec 17 09:26:49 2019 -0500 Merge branch 'tor-github/pr/1609' src/test/test_hs_client.c | 11 ++++------- src/test/test_hs_service.c | 11 ++++------- 2 files changed, 8 insertions(+), 14 deletions(-)

1 0