June 2018 - tor-commits - lists.torproject.org

[tor/release-0.3.4] Add some casts to get test_dir.c compiling on windows.
by nickm＠torproject.org 25 Jun '18

25 Jun '18

commit d85fbc9a58ea8bbcba4af9ecb8026bc4a59099d7 Author: Nick Mathewson <nickm(a)torproject.org> Date: Fri Jun 22 18:22:20 2018 -0400 Add some casts to get test_dir.c compiling on windows. Fixed bug 26479. Bug introduced by 0a6f4627a4292e4; bug not in any released version. --- src/test/test_dir.c | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/src/test/test_dir.c b/src/test/test_dir.c index 96adb5ed5..b42755e35 100644 --- a/src/test/… [View More]test_dir.c +++ b/src/test/test_dir.c @@ -1640,13 +1640,13 @@ test_dir_dirserv_read_measured_bandwidths(void *arg) char *fname = tor_strdup(get_fname("V3BandwidthsFile")); /* Test Torflow file only with timestamp*/ - tor_asprintf(&content, "%ld", timestamp); + tor_asprintf(&content, "%ld", (long)timestamp); write_str_to_file(fname, content, 0); tor_free(content); tt_int_op(-1, OP_EQ, dirserv_read_measured_bandwidths(fname, NULL)); /* Test Torflow file with timestamp followed by '\n' */ - tor_asprintf(&content, "%ld\n", timestamp); + tor_asprintf(&content, "%ld\n", (long)timestamp); write_str_to_file(fname, content, 0); tor_free(content); tt_int_op(0, OP_EQ, dirserv_read_measured_bandwidths(fname, NULL)); @@ -1659,7 +1659,7 @@ test_dir_dirserv_read_measured_bandwidths(void *arg) "pid_bw=57136645 pid_delta=2.12168374577 circ_fail=0.2 " "scanner=/filepath\n"; - tor_asprintf(&content, "%ld\n%s", timestamp, torflow_relay_lines); + tor_asprintf(&content, "%ld\n%s", (long)timestamp, torflow_relay_lines); write_str_to_file(fname, content, 0); tor_free(content); tt_int_op(0, OP_EQ, dirserv_read_measured_bandwidths(fname, NULL)); @@ -1673,14 +1673,14 @@ test_dir_dirserv_read_measured_bandwidths(void *arg) "earliest_bandwidth=2018-05-08T16:13:26\n" "====\n"; - tor_asprintf(&content, "%ld\n%s%s", timestamp, v110_header_lines, + tor_asprintf(&content, "%ld\n%s%s", (long)timestamp, v110_header_lines, torflow_relay_lines); write_str_to_file(fname, content, 0); tor_free(content); tt_int_op(0, OP_EQ, dirserv_read_measured_bandwidths(fname, NULL)); /* Test Torflow with additional headers afer a correct bw line */ - tor_asprintf(&content, "%ld\n%s%s", timestamp, torflow_relay_lines, + tor_asprintf(&content, "%ld\n%s%s", (long)timestamp, torflow_relay_lines, v110_header_lines); write_str_to_file(fname, content, 0); tor_free(content); @@ -1688,7 +1688,7 @@ test_dir_dirserv_read_measured_bandwidths(void *arg) /* Test Torflow with additional headers afer a correct bw line and more * bw lines after the headers. */ - tor_asprintf(&content, "%ld\n%s%s%s", timestamp, torflow_relay_lines, + tor_asprintf(&content, "%ld\n%s%s%s", (long)timestamp, torflow_relay_lines, v110_header_lines, torflow_relay_lines); write_str_to_file(fname, content, 0); tor_free(content); @@ -1700,7 +1700,7 @@ test_dir_dirserv_read_measured_bandwidths(void *arg) "master_key_ed25519=YaqV4vbvPYKucElk297eVdNArDz9HtIwUoIeo0+cVIpQ " "bw=760 nick=Test rtt=380 time=2018-05-08T16:13:26\n"; - tor_asprintf(&content, "%ld\n%s%s", timestamp, v110_header_lines, + tor_asprintf(&content, "%ld\n%s%s", (long)timestamp, v110_header_lines, sbws_relay_lines); write_str_to_file(fname, content, 0); tor_free(content); [View Less]

1 0

[tor/release-0.3.4] Fix test_geoip failures on windows by writing file in binary mode.
by nickm＠torproject.org 25 Jun '18

25 Jun '18

commit 3cc0a145bd2befbc22e86d4fa609d5b00f6039f6 Author: Nick Mathewson <nickm(a)torproject.org> Date: Fri Jun 22 14:47:48 2018 -0400 Fix test_geoip failures on windows by writing file in binary mode. Fixes bug 26480; bug appeared when we re-enabled the geoip tests on windows. Bug originally introduced by our fix to 25787; bug not in any released Tor. --- src/test/test_geoip.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/test/… [View More]

1 0

[tor/release-0.3.4] Merge branch 'maint-0.3.4' into release-0.3.4
by nickm＠torproject.org 25 Jun '18

25 Jun '18

commit 247c163acebdfe44223d4a90cf06229eb4fc52db Merge: 9f2936462 d85fbc9a5 Author: Nick Mathewson <nickm(a)torproject.org> Date: Mon Jun 25 13:50:37 2018 -0400 Merge branch 'maint-0.3.4' into release-0.3.4 src/test/test_dir.c | 14 +++++++------- src/test/test_geoip.c | 8 ++++---- 2 files changed, 11 insertions(+), 11 deletions(-)

1 0

[tor-browser-build/master] Bug 26496: Set MAR_OLD_FORMAT=1 in dmg2mar
by boklm＠torproject.org 25 Jun '18

25 Jun '18

commit ce2f13cfa3a98c01e0f1417c5f9017fbda3d148a Author: Nicolas Vigier <boklm(a)torproject.org> Date: Mon Jun 25 17:56:31 2018 +0200 Bug 26496: Set MAR_OLD_FORMAT=1 in dmg2mar --- Makefile | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Makefile b/Makefile index 80e9983..3b5c2d9 100644 --- a/Makefile +++ b/Makefile @@ -132,13 +132,13 @@ update_responses-alpha: submodule-update dmg2mar-release: submodule-update $(rbm) build release --step … [View More]

1 0

[tor/release-0.3.4] Begin a changelog for 0.3.4.3-alpha
by nickm＠torproject.org 25 Jun '18

25 Jun '18

commit 9f2936462ce2ba26aa50295e2aacbcb1216de274 Author: Nick Mathewson <nickm(a)torproject.org> Date: Mon Jun 25 10:17:35 2018 -0400 Begin a changelog for 0.3.4.3-alpha --- ChangeLog | 69 +++++++++++++++++++++++++++++++++++++++++++++ changes/bug24891 | 4 --- changes/bug24977 | 5 ---- changes/bug25686_diagnostic | 4 --- changes/bug25787 | 7 ----- changes/bug26158 | 5 ---- changes/bug26196 | 7 ----- … [View More] changes/bug26245 | 3 -- changes/bug26258_033 | 4 --- changes/bug26402 | 4 --- changes/bug26415 | 3 -- changes/bug26435 | 5 ---- changes/ticket25947 | 4 --- changes/ticket25960 | 5 ---- 14 files changed, 69 insertions(+), 60 deletions(-) diff --git a/ChangeLog b/ChangeLog index 60583ac7f..c0fddc4eb 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,72 @@ +Changes in version 0.3.4.3-alpha - 2018-06-2? + Tor 0.3.4.3-alpha fixes several bugs in earlier versions, including + one that was causing stability issues on directory authorities. + + o Major bugfixes (directory authority): + - Stop leaking memory on directory authorities when planning to + vote. This bug was crashing authorities by exhausting their + memory. Fixes bug 26435; bugfix on 0.3.3.6. + + o Major bugfixes (rust, testing): + - Make sure that failing tests in Rust will actually cause the build + to fail: previously, they were ignored. Fixes bug 26258; bugfix + on 0.3.3.4-alpha. + + o Minor feature (directory authorities): + - Stop warning about incomplete bw lines before the first complete + bw line has been found, so that additional header lines can be + ignored. Fixes bug 25960; bugfix on 0.2.2.1-alpha + + o Minor features (relay, diagnostic): + - Add several checks to detect whether Tor relays are uploading + their descriptors without specifying why they regenerated them. + Diagnostic for ticket 25686. + + o Minor features (unit tests): + - Test complete bandwidth measurements files, and test that + incomplete bandwidth lines only give warnings when the end of the + header has not been detected. Fixes bug 25947; bugfix + on 0.2.2.1-alpha + + o Minor bugfixes (compilation): + - Refrain from compiling unit testing related object files when + --disable-unittests is set to configure script. Fixes bug 24891; + bugfix on 0.2.5.1-alpha. + - When linking the libtor_testing.a library, only include the + dirauth object files once. Previously, they were getting added + twice. Fixes bug 26402; bugfix on 0.3.4.1-alpha. + - The --enable-fatal-warnings flag now affects Rust code as well. + Closes ticket 26245. + + o Minor bugfixes (onion services): + - Recompute some consensus information after detecting a clock jump, + or after transitioning from a non-live consensus to a live + consensus. We do this to avoid having an outdated state, and + miscalculating the index for next-generation onion services. Fixes + bug 24977; bugfix on 0.3.2.1-alpha. + + o Minor bugfixes (relay): + - Relays now correctly block attempts to re-extend to the previous + relay by Ed25519 identity. Previously they would warn in this + case, but not actually reject the attempt. Fixes bug 26158; bugfix + on 0.3.0.1-alpha. + + o Minor bugfixes (testing): + - Fix compilation of the doctests in the Rust crypto crate. Fixes + bug 26415; bugfix on 0.3.4.1-alpha. + - Instead of trying to read the geoip configuration files from + within the unit tests, instead create our own ersatz files with + just enough geoip data in the format we expect. Trying to read + from the source directory created problems on Windows with mingw, + where the build system's paths are not the same as the platform's + paths. Fixes bug 25787; bugfix on 0.3.4.1-alpha. + - Refrain from trying to get an item from an empty smartlist in + test_bridges_clear_bridge_list. Set DEBUG_SMARTLIST in unit tests + to catch improper smartlist usage. Furthermore, enable + DEBUG_SMARTLIST globally when build is configured with fragile + hardening. Fixes bug 26196; bugfix on 0.3.4.1-alpha. + + Changes in version 0.3.3.7 - 2018-06-12 Tor 0.3.3.7 backports several changes from the 0.3.4.x series, including fixes for bugs affecting compatibility and stability. diff --git a/changes/bug24891 b/changes/bug24891 deleted file mode 100644 index 403b2b112..000000000 --- a/changes/bug24891 +++ /dev/null @@ -1,4 +0,0 @@ - o Minor bugfixes (compilation): - - Refrain from compiling unit testing related object files - when --disable-unittests is set to configure script. - Fixes bug 24891; bugfix on 0.2.5.1-alpha. diff --git a/changes/bug24977 b/changes/bug24977 deleted file mode 100644 index f8127a2a7..000000000 --- a/changes/bug24977 +++ /dev/null @@ -1,5 +0,0 @@ - o Minor bugfixes (onion services): - - Recompute some consensus information after clock skews or when we - transition from a non-live consensus to a live consensus. We do this to - avoid having an outdated state which could impact next-generation onion - services. Fixes bug 24977; bugfix on 0.3.2.1-alpha. diff --git a/changes/bug25686_diagnostic b/changes/bug25686_diagnostic deleted file mode 100644 index 96323145d..000000000 --- a/changes/bug25686_diagnostic +++ /dev/null @@ -1,4 +0,0 @@ - o Minor features (relay, diagnostic): - - Add several checks to detect whether Tor relays are uploading their - descriptors without specifying why they regenerated. Diagnostic for - ticket 25686. diff --git a/changes/bug25787 b/changes/bug25787 deleted file mode 100644 index 3041e8a60..000000000 --- a/changes/bug25787 +++ /dev/null @@ -1,7 +0,0 @@ - o Minor bugfixes (testing): - - Instead of trying to read the geoip configuration files from within the - unit tests, instead create our own ersatz files with just enough - geoip data in the format we expect. Trying to read from the source - directory created problems on Windows with mingw, where the - build system's paths are not the same as the platform's paths. - Fixes bug 25787; bugfix on 0.3.4.1-alpha. diff --git a/changes/bug26158 b/changes/bug26158 deleted file mode 100644 index 0d74cf116..000000000 --- a/changes/bug26158 +++ /dev/null @@ -1,5 +0,0 @@ - o Minor bugfixes (relay): - - Relays now correctly block attempts to re-extend to the previous - relay by Ed25519 identity. Previously they would warn in this case, - but not actually reject the attempt. Fixes bug 26158; bugfix on - 0.3.0.1-alpha. diff --git a/changes/bug26196 b/changes/bug26196 deleted file mode 100644 index e63f09a2d..000000000 --- a/changes/bug26196 +++ /dev/null @@ -1,7 +0,0 @@ - o Minor bugfixes (testing, compilation): - - Refrain from trying to get an item from empty smartlist in - test_bridges_clear_bridge_list. Set DEBUG_SMARTLIST in unit - tests to catch improper smartlist usage. Furthermore, - enable DEBUG_SMARTLIST globally when build is configured - with fragile hardening. Fixes bug 26196; bugfix on - 0.3.4.1-alpha. diff --git a/changes/bug26245 b/changes/bug26245 deleted file mode 100644 index 7a14cea0b..000000000 --- a/changes/bug26245 +++ /dev/null @@ -1,3 +0,0 @@ - o Minor features (compilation): - o The --enable-fatal-warnings flag now affects Rust code as well. - Closes ticket 26245. diff --git a/changes/bug26258_033 b/changes/bug26258_033 deleted file mode 100644 index ceca38333..000000000 --- a/changes/bug26258_033 +++ /dev/null @@ -1,4 +0,0 @@ - o Major bugfixes (rust, testing): - - Fix a bug where a failure in the rust unit tests would not actually - cause the build to fail. Fixes bug 26258; bugfix on 0.3.3.4-alpha. - diff --git a/changes/bug26402 b/changes/bug26402 deleted file mode 100644 index b21283a2d..000000000 --- a/changes/bug26402 +++ /dev/null @@ -1,4 +0,0 @@ - o Minor bugfixes (compilation): - - When linking the libtor_testing.a library, only include the dirauth - object files once. Previously, they were getting added twice. - Fixes bug 26402; bugfix on 0.3.4.1-alpha. diff --git a/changes/bug26415 b/changes/bug26415 deleted file mode 100644 index 497fbb736..000000000 --- a/changes/bug26415 +++ /dev/null @@ -1,3 +0,0 @@ - o Minor bugfixes (testing): - - Fix compilation of the doctests in the Rust crypto crate. Fixes - bug 26415; bugfix on 0.3.4.1-alpha. diff --git a/changes/bug26435 b/changes/bug26435 deleted file mode 100644 index f66c503dd..000000000 --- a/changes/bug26435 +++ /dev/null @@ -1,5 +0,0 @@ - o Major bugfixes (directory authority): - - Fix a memory leak where directory authorities would leak a chunk - of memory for every router descriptor every time they considered - voting. This bug was taking down directory authorities due to - out-of-memory issues. Fixes bug 26435; bugfix on 0.3.3.6. diff --git a/changes/ticket25947 b/changes/ticket25947 deleted file mode 100644 index 68559a73f..000000000 --- a/changes/ticket25947 +++ /dev/null @@ -1,4 +0,0 @@ - o Minor feature (unit tests): - - Test complete bandwidth measurements files and test that incomplete lines - only give warnings when the end of the header has not been - detected. Fixes bug 25947; bugfix on 0.2.2.1-alpha diff --git a/changes/ticket25960 b/changes/ticket25960 deleted file mode 100644 index 0d1be2119..000000000 --- a/changes/ticket25960 +++ /dev/null @@ -1,5 +0,0 @@ - o Minor feature (directory authorities): - - Stop warning about incomplete bw lines before the first complete bw line - has been found, so that additional header lines can be ignored. - Fixes bug 25960; bugfix on 0.2.2.1-alpha - [View Less]

1 0

[torspec/master] Merge remote-tracking branch 'juga/ticket8494'
by nickm＠torproject.org 25 Jun '18

25 Jun '18

commit f3b7ffa27da3f25ccb6c204b5c541ee3fa0a1976 Merge: 14dea86 1aab99d Author: Nick Mathewson <nickm(a)torproject.org> Date: Mon Jun 25 10:06:55 2018 -0400 Merge remote-tracking branch 'juga/ticket8494' bandwidth-file-spec.txt | 33 +++++++++++++++++++++++++++++++++ 1 file changed, 33 insertions(+)

1 0

[torspec/master] bandwidth-file-spec: add MaxAdvertisedBandwidth
by nickm＠torproject.org 25 Jun '18

25 Jun '18

commit 1aab99d17022fb2b5430f521c00336fce05981a0 Author: juga0 <juga(a)riseup.net> Date: Mon Jun 25 07:26:45 2018 +0000 bandwidth-file-spec: add MaxAdvertisedBandwidth Add MaxAdvertisedBandwidth section in the bw KeyValue and explain why measured bandwidths need to be limited to it and how current implementations do it. Co-authored-by: teor <teor2345(a)gmail.com> --- bandwidth-file-spec.txt | 33 +++++++++++++++++++++++++++++++++ 1 file changed, 33 … [View More]insertions(+) diff --git a/bandwidth-file-spec.txt b/bandwidth-file-spec.txt index c647aee..da7b4b0 100644 --- a/bandwidth-file-spec.txt +++ b/bandwidth-file-spec.txt @@ -253,14 +253,17 @@ In version 1.1.0, the KeyValue can be in any arbitrary order. The measured bandwidth of this relay. + No Zero Bandwidths: Tor accepts zero bandwidths, but they trigger bugs in older Tor implementations. Therefore, implementations SHOULD NOT produce zero bandwidths. Instead, they SHOULD use one as their minimum bandwidth. If there are zero bandwidths, the parser MAY ignore them. + Bandwidth Aggregation: Multiple measurements can be aggregated using an averaging scheme, such as a mean, median, or decaying average. + Bandwidth Scaling: Torflow scales bandwidths to kilobytes per second. Other implementations SHOULD use kilobytes per second for their initial bandwidth scaling. @@ -270,6 +273,36 @@ In version 1.1.0, the KeyValue can be in any arbitrary order. Appendix B for information about scaling, and one possible scaling method. + MaxAdvertisedBandwidth: + Bandwidth generators MUST limit the relays' measured bandwidth based + on the MaxAdvertisedBadwidth. + A relay's MaxAdvertisedBandwidth limits the bandwidth-avg in its + descriptor. bandwidth-avg is the minimum of MaxAdvertisedBandwidth, + BandwidthRate, RelayBandwidthRate, BandwidthBurst, and + RelayBandwidthBurst. + Therefore, generators MUST limit a relay's measured bandwidth to its + descriptor's bandwidth-avg. This limit needs to be implemented in the + generator, because generators may scale consensus weights before + sending them to Tor. + Generators SHOULD NOT limit measured bandwidths based on descriptors' + bandwidth-observed, because that penalises new relays. + + sbws limits the relay's measured bandwidth to the bandwidth-avg + advertised. + + Torflow partitions relays based on their bandwidth. For unmeasured + relays, Torflow uses the minimum of all descriptor bandwidths, + including bandwidth-avg (MaxAdvertisedBandwidth) and + bandwidth-observed. Then Torflow measures the relays in each partition + against each other, which implicitly limits a relay's measured + bandwidth to the bandwidths of similar relays. + + Torflow also generates consensus weights based on the ratio between the + measured bandwidth and the minimum of all descriptor bandwidths (at the + time of the measurement). So when an operator reduces the + MaxAdvertisedBandwidth for a relay, Torflow reduces that relay's + measured bandwidth. + KeyValue [Zero or more times.] [View Less]

1 0

[torspec/master] Fix Timestamp, to be the most recent result.
by nickm＠torproject.org 25 Jun '18

25 Jun '18

commit 8760c78ddcdb5d7a33b0d6322e82cb287cae6fcb Author: juga0 <juga(a)riseup.net> Date: Tue May 22 08:51:54 2018 +0000 Fix Timestamp, to be the most recent result. It is not the timestamp when the file was created. --- bandwidth-file-spec.txt | 15 ++++++++++++--- 1 file changed, 12 insertions(+), 3 deletions(-) diff --git a/bandwidth-file-spec.txt b/bandwidth-file-spec.txt index c647aee..7db9eab 100644 --- a/bandwidth-file-spec.txt +++ b/bandwidth-file-spec.txt @@ -118,… [View More]

1 0

[torspec/master] Replace generator by threads
by nickm＠torproject.org 25 Jun '18

25 Jun '18

commit f73177db201197aab855225aa9cf6705d2b3b07c Author: juga0 <juga(a)riseup.net> Date: Wed May 23 09:14:43 2018 +0000 Replace generator by threads to make text more clar. Also: * result by bandwidth result * forgotten scanner word by generator --- bandwidth-file-spec.txt | 15 ++++++++------- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/bandwidth-file-spec.txt b/bandwidth-file-spec.txt index db8c881..def9e68 100644 --- a/bandwidth-file-spec.txt ++… [View More]

1 0

[torspec/master] Add a latest bandwidth header Line
by nickm＠torproject.org 25 Jun '18

25 Jun '18

commit 2598b382d5bb34c69312f1b27cca50658e35595c Author: juga0 <juga(a)riseup.net> Date: Tue May 22 08:57:01 2018 +0000 Add a latest bandwidth header Line --- bandwidth-file-spec.txt | 14 ++++++++++++++ 1 file changed, 14 insertions(+) diff --git a/bandwidth-file-spec.txt b/bandwidth-file-spec.txt index 56facd0..a8cfa0a 100644 --- a/bandwidth-file-spec.txt +++ b/bandwidth-file-spec.txt @@ -191,6 +191,20 @@ It consists of: This Line has been added in version 1.1.0 of this … [View More]

1 0