June 2018 - tor-commits - lists.torproject.org

[torspec/master] Add file creation date header Line
by nickm＠torproject.org 25 Jun '18

25 Jun '18

commit 718302ed4bd9a0f2b72d26719a9d2d189085d320 Author: juga0 <juga(a)riseup.net> Date: Tue May 22 08:54:42 2018 +0000 Add file creation date header Line --- bandwidth-file-spec.txt | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/bandwidth-file-spec.txt b/bandwidth-file-spec.txt index 7db9eab..56facd0 100644 --- a/bandwidth-file-spec.txt +++ b/bandwidth-file-spec.txt @@ -164,6 +164,15 @@ It consists of: This Line has been added in version 1.1.0 of this specification. + "file_created=" DateTime NL + + [Zero or one time.] + + The date and time timestamp in ISO 8601 format and UTC time zone + when the file was created. + + This Line has been added in version 1.1.0 of this specification. + "generator_started=" DateTime NL [Zero or one time.]

1 0

[torspec/master] Do not generate file if timestamp is missing
by nickm＠torproject.org 25 Jun '18

25 Jun '18

commit 0cedb90f0b69fa24a71566e6100f9f6137cd8b09 Author: juga0 <juga(a)riseup.net> Date: Wed May 23 09:01:41 2018 +0000 Do not generate file if timestamp is missing --- bandwidth-file-spec.txt | 3 +++ 1 file changed, 3 insertions(+) diff --git a/bandwidth-file-spec.txt b/bandwidth-file-spec.txt index a8cfa0a..db8c881 100644 --- a/bandwidth-file-spec.txt +++ b/bandwidth-file-spec.txt @@ -128,6 +128,9 @@ It consists of: If there are scanners that do not run continuously, they SHOULD be excluded from the timestamp calculation. + If a generator does not have information about the most recent result, + it MUST NOT generate the file. + It does not follow the KeyValue format for backwards compatibility with version 1.0.0.

1 0

[torspec/master] Add latest_bandwidth, file_created to the example
by nickm＠torproject.org 25 Jun '18

25 Jun '18

commit c8764b1586e5283217e84f7899a69f13bdaae933 Author: juga0 <juga(a)riseup.net> Date: Wed May 23 09:29:30 2018 +0000 Add latest_bandwidth, file_created to the example and change other example dates to be more coherent. --- bandwidth-file-spec.txt | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/bandwidth-file-spec.txt b/bandwidth-file-spec.txt index def9e68..295f8b6 100644 --- a/bandwidth-file-spec.txt +++ b/bandwidth-file-spec.txt @@ -420,8 +420,10 @@ A.2. Generated by sbws version 0.1.X version=1.1.0 software=sbws software_version=0.1.0 -generator_started=2018-05-08T16:13:25 -earliest_bandwidth=2018-05-08T16:13:26 +latest_bandwidth=2018-04-16T20:49:18 +file_created=2018-04-16T21:49:18 +generator_started=2018-04-16T15:13:25 +earliest_bandwidth=2018-04-16T15:13:26 ==== bw=380 error_circ=0 error_misc=0 error_stream=1 master_key_ed25519=YaqV4vbvPYKucElk297eVdNArDz9HtIwUoIeo0+cVIpQ nick=Test node_id=$68A483E05A2ABDCA6DA5A3EF8DB5177638A27F80 rtt=380 success=1 time=2018-05-08T16:13:26 bw=189 error_circ=0 error_misc=0 error_stream=0 master_key_ed25519=a6a+dZadrQBtfSbmQkP7j2ardCmLnm5NJ4ZzkvDxbo0I nick=Test2 node_id=$96C15995F30895689291F455587BD94CA427B6FC rtt=378 success=1 time=2018-05-08T16:13:36

1 0

[torspec/master] Change generators by threads
by nickm＠torproject.org 25 Jun '18

25 Jun '18

commit 23625d66c26325b3fabe5ec6003c92d77892e829 Author: juga0 <juga(a)riseup.net> Date: Fri Jun 1 10:23:38 2018 +0000 Change generators by threads --- bandwidth-file-spec.txt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/bandwidth-file-spec.txt b/bandwidth-file-spec.txt index 295f8b6..f92c8d3 100644 --- a/bandwidth-file-spec.txt +++ b/bandwidth-file-spec.txt @@ -126,7 +126,7 @@ It consists of: recent timestamp from each thread and use the oldest value. This ensures all the threads continue running. - If there are generators that do not run continuously, they SHOULD be + If there are threads that do not run continuously, they SHOULD be excluded from the timestamp calculation. If a generator does not have information about the most recent result,

1 0

[torspec/master] Merge remote-tracking branch 'juga/ticket26155'
by nickm＠torproject.org 25 Jun '18

25 Jun '18

commit 14dea86acc6b00fdfa8985f3728bb6bba0c7c711 Merge: ed29ac2 b4aa080 Author: Nick Mathewson <nickm(a)torproject.org> Date: Mon Jun 25 10:02:39 2018 -0400 Merge remote-tracking branch 'juga/ticket26155' bandwidth-file-spec.txt | 47 ++++++++++++++++++++++++++++++++++++++++++----- 1 file changed, 42 insertions(+), 5 deletions(-)

1 0

[torspec/master] Rephrase what to do when there aren't recent results
by nickm＠torproject.org 25 Jun '18

25 Jun '18

commit b4aa080b0945300eab1d6a4ffd252c6870dc5c66 Author: juga0 <juga(a)riseup.net> Date: Fri Jun 1 10:25:22 2018 +0000 Rephrase what to do when there aren't recent results --- bandwidth-file-spec.txt | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/bandwidth-file-spec.txt b/bandwidth-file-spec.txt index f92c8d3..48861a5 100644 --- a/bandwidth-file-spec.txt +++ b/bandwidth-file-spec.txt @@ -129,8 +129,7 @@ It consists of: If there are threads that do not run continuously, they SHOULD be excluded from the timestamp calculation. - If a generator does not have information about the most recent result, - it MUST NOT generate the file. + If there are no recent results, the generator MUST NOT generate a new file. It does not follow the KeyValue format for backwards compatibility with version 1.0.0.

1 0

[torspec/master] rend-spec-v3.txt: Clarify role of first layer desc encryption.
by nickm＠torproject.org 25 Jun '18

25 Jun '18

commit ed29ac205461ca0d1e61e3d4caad95381139eedb Author: George Kadianakis <desnacked(a)riseup.net> Date: Sat Jun 23 13:24:51 2018 -0500 rend-spec-v3.txt: Clarify role of first layer desc encryption. It's meant to protect against entities that don't know the identity public key (aka the onion address). Closes #26379. Pointed out by Steven Murdoch. --- rend-spec-v3.txt | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/rend-spec-v3.txt b/rend-spec-v3.txt index 728f38f..0b56fce 100644 --- a/rend-spec-v3.txt +++ b/rend-spec-v3.txt @@ -1124,8 +1124,8 @@ Table of contents: 2.5.1. First layer of encryption [HS-DESC-FIRST-LAYER] The first layer of HS descriptor encryption is designed to protect - descriptor confidentiality against entities who don't know the blinded - public key of the hidden service. + descriptor confidentiality against entities who don't know the public + identity key of the hidden service. 2.5.1.1. First layer encryption logic @@ -1136,6 +1136,11 @@ Table of contents: SECRET_DATA = blinded-public-key STRING_CONSTANT = "hsdir-superencrypted-data" + The encryption scheme in [HS-DESC-ENCRYPTION-KEYS] uses the service + credential which is derived from the public identity key (see [SUBCRED]) to + ensure that only entities who know the public identity key can decrypt the + first descriptor layer. + The ciphertext is placed on the "superencrypted" field of the descriptor. Before encryption the plaintext is padded with NUL bytes to the nearest

1 0

[stem/master] Typo fix as pointed out by Roger
by atagar＠torproject.org 24 Jun '18

24 Jun '18

commit ff8a5af281026a994a4e0b7d78813d50f686ae01 Author: Dave Rolek <dmr-x(a)riseup.net> Date: Thu Jun 21 18:15:36 2018 +0000 Typo fix as pointed out by Roger --- stem/control.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/stem/control.py b/stem/control.py index 1bef73b9..97a09f2b 100644 --- a/stem/control.py +++ b/stem/control.py @@ -1770,7 +1770,7 @@ class Controller(BaseController): if not os.path.exists(data_directory): raise stem.OperationFailed(message = "Data directory reported by tor doesn't exist (%s)" % data_directory) elif not os.path.exists(cached_descriptor_path): - raise stem.OperationFailed(message = "Data directory doens't contain cached microescriptors (%s)" % cached_descriptor_path) + raise stem.OperationFailed(message = "Data directory doesn't contain cached microescriptors (%s)" % cached_descriptor_path) with stem.descriptor.reader.DescriptorReader([cached_descriptor_path]) as reader: for desc in reader:

1 0

[stem/master] Fix additional typo
by atagar＠torproject.org 24 Jun '18

24 Jun '18

commit 94cd5ae7eee9d3b572cc11f286c342d024237d22 Author: Dave Rolek <dmr-x(a)riseup.net> Date: Thu Jun 21 19:00:49 2018 +0000 Fix additional typo --- stem/control.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/stem/control.py b/stem/control.py index 97a09f2b..b1918ce9 100644 --- a/stem/control.py +++ b/stem/control.py @@ -1770,7 +1770,7 @@ class Controller(BaseController): if not os.path.exists(data_directory): raise stem.OperationFailed(message = "Data directory reported by tor doesn't exist (%s)" % data_directory) elif not os.path.exists(cached_descriptor_path): - raise stem.OperationFailed(message = "Data directory doesn't contain cached microescriptors (%s)" % cached_descriptor_path) + raise stem.OperationFailed(message = "Data directory doesn't contain cached microdescriptors (%s)" % cached_descriptor_path) with stem.descriptor.reader.DescriptorReader([cached_descriptor_path]) as reader: for desc in reader:

1 0

[stem/master] Check the 'cached-microdescs' file for skipping, instead of 'cached-descriptors'
by atagar＠torproject.org 24 Jun '18

24 Jun '18

commit 04728e1408f5db4dccac5342c62d324db943cc82 Author: Dave Rolek <dmr-x(a)riseup.net> Date: Thu Jun 21 19:07:16 2018 +0000 Check the 'cached-microdescs' file for skipping, instead of 'cached-descriptors' This should fix #26225, although attempts to reproduce were unfruitful, so the fix hasn't been directly tested. cefe584cd57c45a77379428a4c15fb225c0afdcc (which introduced the check for 'cached-descriptors') had made this more stable, but since it was checking a different file, it seems that some temporal edge cases could still run this test into a failure, as evidenced by a few recent Jenkins failures. --- test/integ/control/controller.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/integ/control/controller.py b/test/integ/control/controller.py index cde8e140..4d28afac 100644 --- a/test/integ/control/controller.py +++ b/test/integ/control/controller.py @@ -1154,7 +1154,7 @@ class TestController(unittest.TestCase): runner = test.runner.get_runner() - if not os.path.exists(runner.get_test_dir('cached-descriptors')): + if not os.path.exists(runner.get_test_dir('cached-microdescs')): self.skipTest('(no cached microdescriptors)') return

1 0