April 2018 - tor-commits - lists.torproject.org

[torspec/master] normalize lack of period at end of title
by arma＠torproject.org 18 Apr '18

18 Apr '18

commit 4b93747f86f942700777fc7c8c99b06aa3e69603 Author: Roger Dingledine <arma(a)torproject.org> Date: Wed Apr 18 15:41:57 2018 -0400 normalize lack of period at end of title --- proposals/103-multilevel-keys.txt | 2 +- proposals/109-no-sharing-ips.txt | 2 +- proposals/240-auth-cert-revocation.txt | 2 +- proposals/242-better-families.txt | 2 +- proposals/274-rotate-onion-keys-less.txt | 2 +- proposals/277-detect-id-sharing.txt | 2 +- 6 files changed, 6 insertions(+), 6 deletions(-) diff --git a/proposals/103-multilevel-keys.txt b/proposals/103-multilevel-keys.txt index c8a7a66..7ec254a 100644 --- a/proposals/103-multilevel-keys.txt +++ b/proposals/103-multilevel-keys.txt @@ -1,5 +1,5 @@ Filename: 103-multilevel-keys.txt -Title: Splitting identity key from regularly used signing key. +Title: Splitting identity key from regularly used signing key Author: Nick Mathewson Created: Jan 2007 Status: Closed diff --git a/proposals/109-no-sharing-ips.txt b/proposals/109-no-sharing-ips.txt index 5438cf0..a0f1fff 100644 --- a/proposals/109-no-sharing-ips.txt +++ b/proposals/109-no-sharing-ips.txt @@ -1,5 +1,5 @@ Filename: 109-no-sharing-ips.txt -Title: No more than one server per IP address. +Title: No more than one server per IP address Author: Kevin Bauer & Damon McCoy Created: 9-March-2007 Status: Closed diff --git a/proposals/240-auth-cert-revocation.txt b/proposals/240-auth-cert-revocation.txt index fa426ca..b4dcd0d 100644 --- a/proposals/240-auth-cert-revocation.txt +++ b/proposals/240-auth-cert-revocation.txt @@ -1,5 +1,5 @@ Filename: 240-auth-cert-revocation.txt -Title: Early signing key revocation for directory authorities. +Title: Early signing key revocation for directory authorities Author: Nick Mathewson Created: 09-Jan-2015 Status: Draft diff --git a/proposals/242-better-families.txt b/proposals/242-better-families.txt index 400bc3c..f8d0894 100644 --- a/proposals/242-better-families.txt +++ b/proposals/242-better-families.txt @@ -1,5 +1,5 @@ Filename: 242-better-families.txt -Title: Better performance and usability for the MyFamily option. +Title: Better performance and usability for the MyFamily option Author: Nick Mathewson Created: 2015-02-27 Status: Open diff --git a/proposals/274-rotate-onion-keys-less.txt b/proposals/274-rotate-onion-keys-less.txt index d3a962a..09f5ea5 100644 --- a/proposals/274-rotate-onion-keys-less.txt +++ b/proposals/274-rotate-onion-keys-less.txt @@ -1,5 +1,5 @@ Filename: 274-rotate-onion-keys-less.txt -Title: Rotate onion keys less frequently. +Title: Rotate onion keys less frequently Author: Nick Mathewson Created: 20-Feb-2017 Status: Closed diff --git a/proposals/277-detect-id-sharing.txt b/proposals/277-detect-id-sharing.txt index dee7f6e..7837615 100644 --- a/proposals/277-detect-id-sharing.txt +++ b/proposals/277-detect-id-sharing.txt @@ -1,5 +1,5 @@ Filename: 277-detect-id-sharing.txt -Title: Detect multiple relay instances running with same ID. +Title: Detect multiple relay instances running with same ID Author: Nick Mathewson Created: 20-Feb-2017 Status: Open

1 0

[torspec/master] declare prop#251 closed
by arma＠torproject.org 18 Apr '18

18 Apr '18

commit 3260c2225eafed5b5152d6c474463dfc22c5eea5 Author: Roger Dingledine <arma(a)torproject.org> Date: Wed Apr 18 15:38:49 2018 -0400 declare prop#251 closed --- proposals/251-netflow-padding.txt | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/proposals/251-netflow-padding.txt b/proposals/251-netflow-padding.txt index 18de188..f1b9450 100644 --- a/proposals/251-netflow-padding.txt +++ b/proposals/251-netflow-padding.txt @@ -2,8 +2,10 @@ Filename: 251-netflow-padding.txt Title: Padding for netflow record resolution reduction Authors: Mike Perry Created: 20 August 2015 -Status: Draft +Status: Closed +Implemented-In: 0.3.1.1-alpha +NOTE: Please look at padding-spec.txt now, not this document. 0. Motivation

1 0

[translation/support-topics] Update translations for support-topics
by translation＠torproject.org 18 Apr '18

18 Apr '18

commit ffe0b8f83d799d7ab42795837db238a1ce37b7d5 Author: Translation commit bot <translation(a)torproject.org> Date: Wed Apr 18 19:20:31 2018 +0000 Update translations for support-topics --- it.json | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/it.json b/it.json index 716532c7a..c68cb5e62 100644 --- a/it.json +++ b/it.json @@ -20,8 +20,8 @@ "label": "Tor Mobile" }, "gettor": { - "path": "#gettor", - "control": "gettor", + "path": "#ottienitor", + "control": "ottienitor", "label": "OttieniTor" }, "connecting": { @@ -45,13 +45,13 @@ "label": "Operatori" }, "onionservices": { - "path": "#onion-services", - "control": "onion-services", + "path": "#servizi-onion", + "control": "servizi-onion", "label": "Servizi Onion" }, "misc": { - "path": "#misc", - "control": "misc", - "label": "Misc" + "path": "#varie", + "control": "varie", + "label": "Varie" } }

1 0

[nyx/master] Drop duplicate axis_offset calculation
by atagar＠torproject.org 18 Apr '18

18 Apr '18

commit 680d5f48fa1f76c043672eb475bee8554254834b Author: Damian Johnson <atagar(a)torproject.org> Date: Wed Apr 18 11:40:28 2018 -0700 Drop duplicate axis_offset calculation Minor innocuous simplification. We got the width of our y-axis labels twice - might as well do it once. --- nyx/panel/graph.py | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/nyx/panel/graph.py b/nyx/panel/graph.py index 79b50fa..dc71107 100644 --- a/nyx/panel/graph.py +++ b/nyx/panel/graph.py @@ -616,13 +616,14 @@ def _draw_subgraph(subwindow, data, x, width, height, bounds_type, interval, col x_axis_labels = _x_axis_labels(interval, columns) y_axis_labels = _y_axis_labels(height, data, min_bound, max_bound) - columns = max(columns, width - max([len(label) for label in y_axis_labels.values()]) - 2) - axis_offset = max([len(label) for label in y_axis_labels.values()]) + + x_axis_offset = max([len(label) for label in y_axis_labels.values()]) + columns = max(columns, width - x_axis_offset - 2) subwindow.addstr(x, 1, data.header(width), color, BOLD) for x_offset, label in x_axis_labels.items(): - subwindow.addstr(x + x_offset + axis_offset, height, label, color) + subwindow.addstr(x + x_offset + x_axis_offset, height, label, color) for y, label in y_axis_labels.items(): subwindow.addstr(x, y, label, color) @@ -630,7 +631,7 @@ def _draw_subgraph(subwindow, data, x, width, height, bounds_type, interval, col for col in range(columns): column_count = int(data.values[interval][col]) - min_bound column_height = int(min(height - 2, (height - 2) * column_count / (max(1, max_bound) - min_bound))) - subwindow.vline(x + col + axis_offset + 1, height - column_height, column_height, color, HIGHLIGHT, char = fill_char) + subwindow.vline(x + col + x_axis_offset + 1, height - column_height, column_height, color, HIGHLIGHT, char = fill_char) def _x_axis_labels(interval, columns):

1 0

[nyx/master] Fix unit tests
by atagar＠torproject.org 18 Apr '18

18 Apr '18

commit 314dd59d1d1bc1fdc6aa88763b4c16e5e4284aeb Author: Damian Johnson <atagar(a)torproject.org> Date: Wed Apr 18 11:39:44 2018 -0700 Fix unit tests Just a couple minor regressions from prior changes. --- nyx/panel/graph.py | 2 -- test/arguments.py | 2 +- 2 files changed, 1 insertion(+), 3 deletions(-) diff --git a/nyx/panel/graph.py b/nyx/panel/graph.py index a33aaa4..79b50fa 100644 --- a/nyx/panel/graph.py +++ b/nyx/panel/graph.py @@ -108,8 +108,6 @@ def _bandwidth_title_stats(): stats.append('limit: %s/s' % bw_rate_label) stats.append('burst: %s/s' % bw_burst_label) - my_router_status_entry = nyx.tracker.get_consensus_tracker().my_router_status_entry() - my_server_descriptor = controller.get_server_descriptor(default = None) observed_bw = getattr(my_server_descriptor, 'observed_bandwidth', None) diff --git a/test/arguments.py b/test/arguments.py index da55127..5223af5 100644 --- a/test/arguments.py +++ b/test/arguments.py @@ -83,7 +83,7 @@ class TestArgumentParsing(unittest.TestCase): def test_help(self): self.assertTrue(get_help().startswith('Usage nyx [OPTION]')) - self.assertTrue('change control interface from 127.0.0.1:9051' in get_help()) + self.assertTrue('change control interface from 127.0.0.1:default' in get_help()) def test_version(self): self.assertTrue(get_version().startswith('nyx version'))

1 0

[stem/master] Cite ticket for the exit policy workaround
by atagar＠torproject.org 18 Apr '18

18 Apr '18

commit 599ece8a729a20328185839254f8fc03dcb5e8a1 Author: Damian Johnson <atagar(a)torproject.org> Date: Wed Apr 18 11:27:37 2018 -0700 Cite ticket for the exit policy workaround --- stem/control.py | 2 ++ 1 file changed, 2 insertions(+) diff --git a/stem/control.py b/stem/control.py index 9229f07c..02183d95 100644 --- a/stem/control.py +++ b/stem/control.py @@ -1295,6 +1295,8 @@ class Controller(BaseController): # ProtocolError: GETINFO response didn't have an OK status: # router_get_my_routerinfo returned NULL # + # https://trac.torproject.org/projects/tor/ticket/25842 + # # Failing back to the legacy method we used for getting our exit # policy.

1 0

[translation/support-topics] Update translations for support-topics
by translation＠torproject.org 18 Apr '18

18 Apr '18

commit 84e27f10bf3917d16ad2467521704c90a1596c7b Author: Translation commit bot <translation(a)torproject.org> Date: Wed Apr 18 18:20:32 2018 +0000 Update translations for support-topics --- it.json | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/it.json b/it.json index 3c299f2ae..716532c7a 100644 --- a/it.json +++ b/it.json @@ -25,13 +25,13 @@ "label": "OttieniTor" }, "connecting": { - "path": "#connecting-to-tor", - "control": "connecting-to-tor", - "label": "Connecting To Tor" + "path": "#connessione-a-tor", + "control": "connessione-a-tor", + "label": "Connessione a Tor" }, "censorship": { - "path": "#censorship", - "control": "censorship", + "path": "#censura", + "control": "censura", "label": "Censura" }, "https": { @@ -40,9 +40,9 @@ "label": "HTTPS" }, "operators": { - "path": "#operators", - "control": "operators", - "label": "Operators" + "path": "#operatori", + "control": "operatori", + "label": "Operatori" }, "onionservices": { "path": "#onion-services",

1 0

[stem/master] Fallback to GETCONF for getting exit policies
by atagar＠torproject.org 18 Apr '18

18 Apr '18

commit f61e91314c81949bb6fb199f14afa0f56d4b4557 Author: Damian Johnson <atagar(a)torproject.org> Date: Wed Apr 18 10:17:08 2018 -0700 Fallback to GETCONF for getting exit policies As pointed out by dmr on #25423 when tor is unable to determine our address 'GETINFO exit-policy/full' fails. I was able to easily repro this by running our integ tests when disconnected... ====================================================================== ERROR: test_get_exit_policy ---------------------------------------------------------------------- Traceback (most recent call last): File "/home/atagar/Desktop/stem/test/require.py", line 58, in wrapped return func(self, *args, **kwargs) File "/home/atagar/Desktop/stem/test/integ/control/controller.py", line 278, in test_get_exit_policy self.assertEqual(ExitPolicy('reject *:*'), controller.get_exit_policy()) File "/home/atagar/Desktop/stem/stem/control.py", line 481, in wrapped return func(self, *args, **kwargs) File "/home/atagar/Desktop/stem/stem/control.py", line 1289, in get_exit_policy policy = stem.exit_policy.ExitPolicy(*self.get_info('exit-policy/full').splitlines()) File "/home/atagar/Desktop/stem/stem/control.py", line 481, in wrapped return func(self, *args, **kwargs) File "/home/atagar/Desktop/stem/stem/control.py", line 1186, in get_info stem.response.convert('GETINFO', response) File "/home/atagar/Desktop/stem/stem/response/__init__.py", line 124, in convert message._parse_message(**kwargs) File "/home/atagar/Desktop/stem/stem/response/getinfo.py", line 40, in _parse_message raise stem.ProtocolError("GETINFO response didn't have an OK status:\n%s" % self) ProtocolError: GETINFO response didn't have an OK status: router_get_my_routerinfo returned NULL I'll shoot tor a ticket in a bit, but in the meantime when this happens we'll now fall back to our prior method of getting the policy. One small fix for the legacy method is that we now account for 'ExitRelay 0' in our the torrc (otherwise our tests wouldn't pass). --- stem/control.py | 28 +++++++++++++++++++++++++++- 1 file changed, 27 insertions(+), 1 deletion(-) diff --git a/stem/control.py b/stem/control.py index a91e9588..9229f07c 100644 --- a/stem/control.py +++ b/stem/control.py @@ -1286,7 +1286,33 @@ class Controller(BaseController): policy = self._get_cache('exit_policy') if not policy: - policy = stem.exit_policy.ExitPolicy(*self.get_info('exit-policy/full').splitlines()) + try: + policy = stem.exit_policy.ExitPolicy(*self.get_info('exit-policy/full').splitlines()) + except stem.ProtocolError: + # When tor is unable to determine our address 'GETINFO + # exit-policy/full' fails with... + # + # ProtocolError: GETINFO response didn't have an OK status: + # router_get_my_routerinfo returned NULL + # + # Failing back to the legacy method we used for getting our exit + # policy. + + rules = [] + + if self.get_conf('ExitRelay') == '0': + rules.append('reject *:*') + + if self.get_conf('ExitPolicyRejectPrivate') == '1': + rules.append('reject private:*') + + for policy_line in self.get_conf('ExitPolicy', multiple = True): + rules += policy_line.split(',') + + rules += self.get_info('exit-policy/default').split(',') + + policy = stem.exit_policy.get_config_policy(rules, self.get_info('address', None)) + self._set_cache({'exit_policy': policy}) return policy

1 0

[stem/master] Context methods for the Circuit class
by atagar＠torproject.org 18 Apr '18

18 Apr '18

commit cc95059da5a8e34d10c16f5a226df21ffb5b43c9 Author: Damian Johnson <atagar(a)torproject.org> Date: Tue Apr 17 10:09:14 2018 -0700 Context methods for the Circuit class Like our Relay class circuits are intended to be used for a time then closed. Decorating it with the methods necessary so it can be used through 'with' clauses. --- stem/client/__init__.py | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/stem/client/__init__.py b/stem/client/__init__.py index 2c6b7ea6..be7e16ad 100644 --- a/stem/client/__init__.py +++ b/stem/client/__init__.py @@ -256,3 +256,9 @@ class Circuit(object): with self.relay._orport_lock: self.relay._orport.send(stem.client.cell.DestroyCell(self.id).pack(self.relay.link_protocol)) del self.relay._circuits[self.id] + + def __enter__(self): + return self + + def __exit__(self, exit_type, value, traceback): + self.close()

1 0

[webwml/master] Add rust to tor languages
by atagar＠torproject.org 18 Apr '18

18 Apr '18

commit d715762b4b2eb523456d21ec585dd2b806ab42e9 Author: Damian Johnson <atagar(a)torproject.org> Date: Wed Apr 18 09:32:26 2018 -0700 Add rust to tor languages Damn me. Teor asked for a couple small tweaks for the project page (noting that it's in part rust and removing athena) almost two months ago. Unfortunately I was ill at the time so got buried under a stack of todo notes. :/ --- getinvolved/en/volunteer.wml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/getinvolved/en/volunteer.wml b/getinvolved/en/volunteer.wml index 2bb3db15..01856c80 100644 --- a/getinvolved/en/volunteer.wml +++ b/getinvolved/en/volunteer.wml @@ -109,9 +109,9 @@ meetings around the world.</li> <tr> <td><a href="#project-tor">Tor</a></td> <td>Core</td> - <td>C</td> + <td>C, Rust</td> <td>Heavy</td> - <td>nickm, athena, arma, dgoulet, asn, teor</td> + <td>nickm, arma, dgoulet, asn, teor</td> </tr> <tr>

1 0