February 2018 - tor-commits - lists.torproject.org

[atlas/master] Only show version from consensus if inconsistent with platform (Fixes: #24974)
by irl＠torproject.org 09 Feb '18

09 Feb '18

commit b186e90e81f158b222d5df4e91956420db83c8b0 Author: Iain R. Learmonth <irl(a)fsfe.org> Date: Sat Feb 10 00:29:56 2018 +0000 Only show version from consensus if inconsistent with platform (Fixes: #24974) --- js/models/relay.js | 4 +++- templates/details/router.html | 7 ++----- 2 files changed, 5 insertions(+), 6 deletions(-) diff --git a/js/models/relay.js b/js/models/relay.js index 4984d65..cd3078b 100644 --- a/js/models/relay.js +++ b/js/models/relay.js @@ -233,9 +233,11 @@ define([ model.set({badexit: false}); relay.flags = model.parseflags(relay.flags, relay.is_bridge); + relay.version_consistent = relay.version == relay.platform.split(" ")[1]; + /* Synthetic Additional Flags */ var additional_flags = [] - if (!((typeof relay.recommended_version !== 'undefined') ? relay.recommended_version : true)) additional_flags.push("Not Recommended"); + if (!((typeof relay.recommended_version !== 'undefined') ? relay.recommended_version : false) && relay.version_consistent) additional_flags.push("Not Recommended"); if (!((typeof relay.measured !== 'undefined') ? relay.measured : true)) additional_flags.push("Unmeasured"); if (((typeof relay.hibernating !== 'undefined') ? relay.hibernating : false)) additional_flags.push("Hibernating"); if (IsFallbackDir(relay.fingerprint)) additional_flags.push("FallbackDir"); diff --git a/templates/details/router.html b/templates/details/router.html index 4842987..5233648 100644 --- a/templates/details/router.html +++ b/templates/details/router.html @@ -10,7 +10,7 @@ <% if (relay.get('new_relay') === true) {%> <div class="alert alert-info">This relay appears to be less than 2 weeks old. <a href="https://blog.torproject.org/lifecycle-new-relay">This blog post</a> explains the lifecycle of a new relay, and why it will not be immediately fully used to capacity.</div> <% } %> -<% if (relay.get('recommended_version') === false) { %> +<% if (relay.get('recommended_version') === false && relay.get('version_consistent') == true) { %> <div class="alert alert-danger">This relay is running an outdated Tor version and should be updated to a recent release of Tor that may contain important fixes.</div> <% } %> <div class="row"> @@ -164,10 +164,7 @@ <dd><%= relay.get('consensus_weight') %></dd> <dt><span class="tip" title="What OS and Tor version the relay is using">Platform</span></dt> - <dd><%= _.escape(relay.get('platform')) %></dd> - - <dt><span class="tip" title="Tor version as seen in the consensus (used to determine whether or not this relay runs a recommended version of tor)">Version</span></dt> - <dd><%= _.escape(relay.get('version')) %></dd> + <dd><%= _.escape(relay.get('platform')) %><% if (!relay.get('version_consistent')) { %> (version is <%= _.escape(relay.get('version')) %> in consensus)<% } %></dd> </dl> </div>

1 0

[atlas/master] Bump cache breaker
by irl＠torproject.org 09 Feb '18

09 Feb '18

commit 0c69e4f0daf20c218777bbb09c01b16c1613a766 Author: Iain R. Learmonth <irl(a)fsfe.org> Date: Sat Feb 10 00:30:16 2018 +0000 Bump cache breaker --- index.html | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/index.html b/index.html index 70eb245..955a663 100644 --- a/index.html +++ b/index.html @@ -40,7 +40,7 @@ <script src="https://metrics.torproject.org/js/script.js"></script>  - <link rel="stylesheet" href="css/atlas.css?v27"> + <link rel="stylesheet" href="css/atlas.css?v28"> </head> @@ -156,7 +156,7 @@ <script> var require = { - urlArgs: "v27" + urlArgs: "v28" }; </script> <script data-main="js/main" src="js/libs/require/require.js"></script>

1 0

[tor/master] Re-wrap and sort the changelog
by nickm＠torproject.org 09 Feb '18

09 Feb '18

commit 379372b90a0696ccffcc622c57673b64d17855c3 Author: Nick Mathewson <nickm(a)torproject.org> Date: Fri Feb 9 17:25:30 2018 -0500 Re-wrap and sort the changelog --- ChangeLog | 52 ++++++++++++++++++++++++++-------------------------- 1 file changed, 26 insertions(+), 26 deletions(-) diff --git a/ChangeLog b/ChangeLog index 9fb15e857..957d83fac 100644 --- a/ChangeLog +++ b/ChangeLog @@ -33,19 +33,18 @@ Changes in version 0.3.3.2-alpha - 2018-02-09 bug 25070; bugfix on 0.3.1.1-alpha. o Major bugfixes (scheduler, consensus): - - The scheduler subsystem was failing to promptly notice changes - in consensus parameters, making it harder to switch schedulers + - The scheduler subsystem was failing to promptly notice changes in + consensus parameters, making it harder to switch schedulers network-wide. Fixes bug 24975; bugfix on 0.3.2.1-alpha. o Minor features (denial-of-service avoidance): - Make our OOM handler aware of the geoip client history cache so it - doesn't fill up the memory. This check is important for IPv6 - and our DoS mitigation subsystem. Closes ticket 25122. + doesn't fill up the memory. This check is important for IPv6 and + our DoS mitigation subsystem. Closes ticket 25122. o Minor features (directory authority): - When directory authorities are unable to add signatures to a - pending consensus, log the - reason why. Closes ticket 24849. + pending consensus, log the reason why. Closes ticket 24849. o Minor features (geoip): - Update geoip and geoip6 to the February 7 2018 Maxmind GeoLite2 @@ -59,14 +58,14 @@ Changes in version 0.3.3.2-alpha - 2018-02-09 o Minor bugfix (channel connection): - Use the actual observed address of an incoming relay connection, not the canonical address of the relay from its descriptor, when - making decisions about how to handle the incoming connection. Fixes - bug 24952; bugfix on 0.2.4.11-alpha. Patch by "ffmancera". + making decisions about how to handle the incoming connection. + Fixes bug 24952; bugfix on 0.2.4.11-alpha. Patch by "ffmancera". o Minor bugfix (directory authority): - Directory authorities, when refusing a descriptor from a rejected - relay, now explicitly tell the relay (in its logs) to set a - valid ContactInfo address and contact the bad-relays@ mailing - list. Fixes bug 25170; bugfix on 0.2.9.1. + relay, now explicitly tell the relay (in its logs) to set a valid + ContactInfo address and contact the bad-relays@ mailing list. + Fixes bug 25170; bugfix on 0.2.9.1. o Minor bugfixes (all versions of Tor): - Use the "misspell" tool to detect and fix typos throughout the @@ -81,16 +80,16 @@ Changes in version 0.3.3.2-alpha - 2018-02-09 o Minor bugfixes (correctness): - Remove a nonworking, unnecessary check to see whether a circuit - hop's identity digest was set when the circuit failed. Fixes bug 24927; - bugfix on 0.2.4.4-alpha. + hop's identity digest was set when the circuit failed. Fixes bug + 24927; bugfix on 0.2.4.4-alpha. o Minor bugfixes (logging): - Don't treat inability to store a cached consensus object as a bug: it can happen normally when we are out of disk space. Fixes bug 24859; bugfix on 0.3.1.1-alpha. - Fix a (mostly harmless) race condition when invoking - LOG_PROTOCOL_WARN message from a subthread while the torrc options are - changing. Fixes bug 23954; bugfix on 0.1.1.9-alpha. + LOG_PROTOCOL_WARN message from a subthread while the torrc options + are changing. Fixes bug 23954; bugfix on 0.1.1.9-alpha. o Minor bugfixes (onion services): - Remove a BUG() statement when a client fetches an onion descriptor @@ -120,15 +119,15 @@ Changes in version 0.3.3.2-alpha - 2018-02-09 o Minor bugfixes (scheduler, KIST): - Avoid adding the same channel twice in the KIST scheduler pending - list, which would waste CPU cycles. - Fixes bug 24700; bugfix on 0.3.2.1-alpha. + list, which would waste CPU cycles. Fixes bug 24700; bugfix + on 0.3.2.1-alpha. o Minor bugfixes (unit test, monotonic time): - - Increase a constant (1msec to 10msec) in the monotonic time test that - makes sure the nsec/usec/msec times read are synchronized. This - change was needed to accommodate slow systems like armel or when - the clock_gettime() is not a VDSO on the running kernel. Fixes bug - 25113; bugfix on 0.2.9.1. + - Increase a constant (1msec to 10msec) in the monotonic time test + that makes sure the nsec/usec/msec times read are synchronized. + This change was needed to accommodate slow systems like armel or + when the clock_gettime() is not a VDSO on the running kernel. + Fixes bug 25113; bugfix on 0.2.9.1. o Minor bugfixes (v3 onion services): - Look at the "HSRend" protocol version, not the "HSDir" protocol @@ -136,10 +135,6 @@ Changes in version 0.3.3.2-alpha - 2018-02-09 v3 onion service protocol as a rendezvous point. Fixes bug 25105; bugfix on 0.3.2.1-alpha. - o Documentation (man page): - - The HiddenServiceVersion torrc option accepts only one number: - either version 2 or 3. Closes ticket 25026; bugfix on 0.3.2.2-alpha. - o Code simplification and refactoring: - Remove the unused nodelist_recompute_all_hsdir_indices(). Closes ticket 25108. @@ -148,6 +143,11 @@ Changes in version 0.3.3.2-alpha - 2018-02-09 anything other than stats logged by a SIGUSR1 signal. Closes ticket 25163. + o Documentation (man page): + - The HiddenServiceVersion torrc option accepts only one number: + either version 2 or 3. Closes ticket 25026; bugfix + on 0.3.2.2-alpha. + Changes in version 0.3.3.1-alpha - 2018-01-25 Tor 0.3.3.1-alpha is the first release in the 0.3.3.x series. It adds

1 0

[tor/master] Bump to 0.3.3.2-alpha
by nickm＠torproject.org 09 Feb '18

09 Feb '18

commit 9e0d4684980aede132353a528d1e564a2a0ad6de Author: Nick Mathewson <nickm(a)torproject.org> Date: Fri Feb 9 17:25:58 2018 -0500 Bump to 0.3.3.2-alpha --- configure.ac | 2 +- contrib/win32build/tor-mingw.nsi.in | 2 +- src/win32/orconfig.h | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/configure.ac b/configure.ac index 7eb189a0e..87e27da67 100644 --- a/configure.ac +++ b/configure.ac @@ -4,7 +4,7 @@ dnl Copyright (c) 2007-2017, The Tor Project, Inc. dnl See LICENSE for licensing information AC_PREREQ([2.63]) -AC_INIT([tor],[0.3.3.1-alpha-dev]) +AC_INIT([tor],[0.3.3.2-alpha]) AC_CONFIG_SRCDIR([src/or/main.c]) AC_CONFIG_MACRO_DIR([m4]) diff --git a/contrib/win32build/tor-mingw.nsi.in b/contrib/win32build/tor-mingw.nsi.in index f4d18a77d..e98bea5f7 100644 --- a/contrib/win32build/tor-mingw.nsi.in +++ b/contrib/win32build/tor-mingw.nsi.in @@ -8,7 +8,7 @@ !include "LogicLib.nsh" !include "FileFunc.nsh" !insertmacro GetParameters -!define VERSION "0.3.3.1-alpha-dev" +!define VERSION "0.3.3.2-alpha" !define INSTALLER "tor-${VERSION}-win32.exe" !define WEBSITE "https://www.torproject.org/" !define LICENSE "LICENSE" diff --git a/src/win32/orconfig.h b/src/win32/orconfig.h index a4767e54c..6ff86ffaa 100644 --- a/src/win32/orconfig.h +++ b/src/win32/orconfig.h @@ -218,7 +218,7 @@ #define USING_TWOS_COMPLEMENT /* Version number of package */ -#define VERSION "0.3.3.1-alpha-dev" +#define VERSION "0.3.3.2-alpha"

1 0

[tor/master] final mucking. all yours, nick
by arma＠torproject.org 09 Feb '18

09 Feb '18

commit 416a385fee065f8894a205656c1184ad6988dcfc Author: Roger Dingledine <arma(a)torproject.org> Date: Fri Feb 9 17:24:45 2018 -0500 final mucking. all yours, nick --- ChangeLog | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/ChangeLog b/ChangeLog index 9ddfed986..9fb15e857 100644 --- a/ChangeLog +++ b/ChangeLog @@ -57,10 +57,10 @@ Changes in version 0.3.3.2-alpha - 2018-02-09 ticket 24972. o Minor bugfix (channel connection): - - The accurate address of a connection is real_addr, not the addr - member. TLS Channel remote address is now real_addr content - instead of addr member. Fixes bug 24952; bugfix on - 0.2.4.11-alpha. Patch by "ffmancera". + - Use the actual observed address of an incoming relay connection, + not the canonical address of the relay from its descriptor, when + making decisions about how to handle the incoming connection. Fixes + bug 24952; bugfix on 0.2.4.11-alpha. Patch by "ffmancera". o Minor bugfix (directory authority): - Directory authorities, when refusing a descriptor from a rejected @@ -120,11 +120,11 @@ Changes in version 0.3.3.2-alpha - 2018-02-09 o Minor bugfixes (scheduler, KIST): - Avoid adding the same channel twice in the KIST scheduler pending - list, which would waste CPU cycles handling the same channel twice. + list, which would waste CPU cycles. Fixes bug 24700; bugfix on 0.3.2.1-alpha. o Minor bugfixes (unit test, monotonic time): - - Bump a gap of 1msec to 10msec in the monotonic time test that + - Increase a constant (1msec to 10msec) in the monotonic time test that makes sure the nsec/usec/msec times read are synchronized. This change was needed to accommodate slow systems like armel or when the clock_gettime() is not a VDSO on the running kernel. Fixes bug

1 0

[translation/tor-messenger-fingerdtd] Update translations for tor-messenger-fingerdtd
by translation＠torproject.org 09 Feb '18

09 Feb '18

commit 456c988c4d0672cb1ea06bdfd467f99aa803f781 Author: Translation commit bot <translation(a)torproject.org> Date: Fri Feb 9 22:19:29 2018 +0000 Update translations for tor-messenger-fingerdtd --- ti/finger.dtd | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ti/finger.dtd b/ti/finger.dtd index 7563e291c..d6d169141 100644 --- a/ti/finger.dtd +++ b/ti/finger.dtd @@ -10,6 +10,6 @@ <!ENTITY finger.intro "Manage the list of fingerprints you've seen."> <!ENTITY addFingerDialog.title "Add Fingerprint"> <!ENTITY addFingerDialog.finger "Fingerprint"> -<!ENTITY addFingerDialog.accept "OK"> +<!ENTITY addFingerDialog.accept "ሕራይ"> <!ENTITY addFingerDialog.cancel "Skip"> <!ENTITY addFingerDialog.tooltip "If you know the 40 hex char fingerprint of your contact's OTR private key, enter it now."> \ No newline at end of file

1 0

[tor/master] more changelog cleanup
by arma＠torproject.org 09 Feb '18

09 Feb '18

commit 3fdd08a174f74f12ec156f3f72835e23a3fe539c Author: Roger Dingledine <arma(a)torproject.org> Date: Fri Feb 9 17:10:34 2018 -0500 more changelog cleanup --- ChangeLog | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/ChangeLog b/ChangeLog index 601a2ae6c..9ddfed986 100644 --- a/ChangeLog +++ b/ChangeLog @@ -137,9 +137,8 @@ Changes in version 0.3.3.2-alpha - 2018-02-09 bugfix on 0.3.2.1-alpha. o Documentation (man page): - - HiddenServiceVersion only accepts one version to be specified. - This version can either be version 2 or 3. Closes ticket 25026; - bugfix on 0.3.2.2-alpha. + - The HiddenServiceVersion torrc option accepts only one number: + either version 2 or 3. Closes ticket 25026; bugfix on 0.3.2.2-alpha. o Code simplification and refactoring: - Remove the unused nodelist_recompute_all_hsdir_indices(). Closes

1 0

[tor/master] whitespace and typo cleanups
by arma＠torproject.org 09 Feb '18

09 Feb '18

commit 99666dc6c4edb7614abc001d92326ca59c23f5f5 Author: Roger Dingledine <arma(a)torproject.org> Date: Fri Feb 9 17:05:20 2018 -0500 whitespace and typo cleanups --- src/common/address_set.c | 6 +++--- src/common/address_set.h | 2 +- src/or/hs_circuit.c | 2 +- src/or/replaycache.c | 11 ++--------- 4 files changed, 7 insertions(+), 14 deletions(-) diff --git a/src/common/address_set.c b/src/common/address_set.c index 6fa942b0d..ea48c1638 100644 --- a/src/common/address_set.c +++ b/src/common/address_set.c @@ -34,7 +34,7 @@ * independent siphashes rather than messing around with bit-shifts. The * approach here is probably more sound, and we should prefer it if&when we * unify the implementations. - **/ + */ struct address_set_t { /** siphash keys to make N_HASHES independent hashes for each address. */ @@ -63,7 +63,7 @@ address_set_new(int max_addresses_guess) } /** - * Release all storage associated with <b>set</b> + * Release all storage associated with <b>set</b>. */ void address_set_free(address_set_t *set) @@ -107,7 +107,7 @@ address_set_add_ipv4h(address_set_t *set, uint32_t addr) } /** - * Return true if <b>addr</b> if a member of <b>set</b>. (And probably, + * Return true if <b>addr</b> is a member of <b>set</b>. (And probably, * return false if <b>addr</b> is not a member of set.) */ int diff --git a/src/common/address_set.h b/src/common/address_set.h index aedf17fc6..28d29f3fd 100644 --- a/src/common/address_set.h +++ b/src/common/address_set.h @@ -2,7 +2,7 @@ /* See LICENSE for licensing information */ /** - * \file addressset.h + * \file address_set.h * \brief Types to handle sets of addresses. * * This module was first written on a semi-emergency basis to improve the diff --git a/src/or/hs_circuit.c b/src/or/hs_circuit.c index faa4b5d45..3a674f622 100644 --- a/src/or/hs_circuit.c +++ b/src/or/hs_circuit.c @@ -722,7 +722,7 @@ hs_circ_retry_service_rendezvous_point(origin_circuit_t *circ) * circuit to the same rendezvous point at the same time. */ circ->hs_service_side_rend_circ_has_been_relaunched = 1; - /* Legacy service don't have a hidden service ident. */ + /* Legacy services don't have a hidden service ident. */ if (circ->hs_ident) { retry_service_rendezvous_point(circ); } else { diff --git a/src/or/replaycache.c b/src/or/replaycache.c index 4a56bfd7d..a9a670993 100644 --- a/src/or/replaycache.c +++ b/src/or/replaycache.c @@ -26,7 +26,6 @@ /** Free the replaycache r and all of its entries. */ - void replaycache_free_(replaycache_t *r) { @@ -44,7 +43,6 @@ replaycache_free_(replaycache_t *r) * for entries to age out and interval is the time after which the cache * should be scrubbed for old entries. */ - replaycache_t * replaycache_new(time_t horizon, time_t interval) { @@ -72,9 +70,8 @@ replaycache_new(time_t horizon, time_t interval) return r; } -/** See documentation for replaycache_add_and_test() +/** See documentation for replaycache_add_and_test(). */ - STATIC int replaycache_add_and_test_internal( time_t present, replaycache_t *r, const void *data, size_t len, @@ -136,9 +133,8 @@ replaycache_add_and_test_internal( return rv; } -/** See documentation for replaycache_scrub_if_needed() +/** See documentation for replaycache_scrub_if_needed(). */ - STATIC void replaycache_scrub_if_needed_internal(time_t present, replaycache_t *r) { @@ -186,7 +182,6 @@ replaycache_scrub_if_needed_internal(time_t present, replaycache_t *r) * and the function will return 1 if it was already seen within the cache's * horizon, or 0 otherwise. */ - int replaycache_add_and_test(replaycache_t *r, const void *data, size_t len) { @@ -196,7 +191,6 @@ replaycache_add_and_test(replaycache_t *r, const void *data, size_t len) /** Like replaycache_add_and_test(), but if it's a hit also return the time * elapsed since this digest was last seen. */ - int replaycache_add_test_and_elapsed( replaycache_t *r, const void *data, size_t len, time_t *elapsed) @@ -207,7 +201,6 @@ replaycache_add_test_and_elapsed( /** Scrub aged entries out of r if sufficiently long has elapsed since r was * last scrubbed. */ - void replaycache_scrub_if_needed(replaycache_t *r) {

1 0

[tor/master] changelog cleanups
by arma＠torproject.org 09 Feb '18

09 Feb '18

commit d95c7c7f529fc1be2cf6a474915f065fd2eb6f41 Author: Roger Dingledine <arma(a)torproject.org> Date: Fri Feb 9 17:04:39 2018 -0500 changelog cleanups --- ChangeLog | 75 ++++++++++++++++++++++++++++++--------------------------------- 1 file changed, 36 insertions(+), 39 deletions(-) diff --git a/ChangeLog b/ChangeLog index bf9f2d5a7..601a2ae6c 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,6 +1,6 @@ Changes in version 0.3.3.2-alpha - 2018-02-09 Tor 0.3.3.2-alpha is the second alpha in the 0.3.3.x series. It - introduces a mechanism to handle the high loads that many relays + introduces a mechanism to handle the high loads that many relay operators have been reporting recently. It also fixes several bugs in older releases. If this new code proves reliable, we plan to backport it to older supported release series. @@ -33,19 +33,18 @@ Changes in version 0.3.3.2-alpha - 2018-02-09 bug 25070; bugfix on 0.3.1.1-alpha. o Major bugfixes (scheduler, consensus): - - A logic in the code was preventing the scheduler subystem to - properly make a decision based on the latest consensus when it - arrives. This lead to the scheduler failing to notice any - consensus parameters that might have changed between consensuses. - Fixes bug 24975; bugfix on 0.3.2.1-alpha. + - The scheduler subsystem was failing to promptly notice changes + in consensus parameters, making it harder to switch schedulers + network-wide. Fixes bug 24975; bugfix on 0.3.2.1-alpha. o Minor features (denial-of-service avoidance): - Make our OOM handler aware of the geoip client history cache so it - doesn't fill up the memory which is especially important for IPv6 + doesn't fill up the memory. This check is important for IPv6 and our DoS mitigation subsystem. Closes ticket 25122. o Minor features (directory authority): - - When unable to add signatures to a pending consensus, log the + - When directory authorities are unable to add signatures to a + pending consensus, log the reason why. Closes ticket 24849. o Minor features (geoip): @@ -53,19 +52,19 @@ Changes in version 0.3.3.2-alpha - 2018-02-09 Country database. o Minor features (logging, diagnostic): - - When logging a failure to check a onion service's certificate, - also log what the problem with the certificate was. Diagnostic for + - When logging a failure to create an onion service's descriptor, + also log what the problem with the descriptor was. Diagnostic for ticket 24972. o Minor bugfix (channel connection): - The accurate address of a connection is real_addr, not the addr member. TLS Channel remote address is now real_addr content - instead of addr member. Fixes bug 24952; bugfix on 707c1e2e26 in + instead of addr member. Fixes bug 24952; bugfix on 0.2.4.11-alpha. Patch by "ffmancera". - o Minor bugfix (directory authority, documentation): - - When a fingerprint or network address is marked as rejected, the - returned message by the authority now explicitly mention to set a + o Minor bugfix (directory authority): + - Directory authorities, when refusing a descriptor from a rejected + relay, now explicitly tell the relay (in its logs) to set a valid ContactInfo address and contact the bad-relays@ mailing list. Fixes bug 25170; bugfix on 0.2.9.1. @@ -75,14 +74,14 @@ Changes in version 0.3.3.2-alpha - 2018-02-09 Patch from Deepesh Pathak. o Minor bugfixes (circuit, cannibalization): - - Don't cannibalize circuits for which we don't know the first hop - which can happen if our Guard relay went off the consensus after - the circuit was created preemptively. Fixes bug 24469; bugfix - on 0.0.6. + - Don't cannibalize preemptively-built circuits if we no longer + recognize their first hop. This situation can happen if our Guard + relay went off the consensus after the circuit was created. Fixes + bug 24469; bugfix on 0.0.6. o Minor bugfixes (correctness): - Remove a nonworking, unnecessary check to see whether a circuit - hop's identity was set when the circuit failed. Fixes bug 24927; + hop's identity digest was set when the circuit failed. Fixes bug 24927; bugfix on 0.2.4.4-alpha. o Minor bugfixes (logging): @@ -90,17 +89,17 @@ Changes in version 0.3.3.2-alpha - 2018-02-09 it can happen normally when we are out of disk space. Fixes bug 24859; bugfix on 0.3.1.1-alpha. - Fix a (mostly harmless) race condition when invoking - LOG_PROTOCOL_WARN message from a subthread while the options are + LOG_PROTOCOL_WARN message from a subthread while the torrc options are changing. Fixes bug 23954; bugfix on 0.1.1.9-alpha. o Minor bugfixes (onion services): - - Remove a BUG() statement which can be triggered in normal - circumstances where a client fetches a descriptor that has a lower - revision counter than the one in its cache. This can happen due to - HSDir desync. Fixes bug 24976; bugfix on 0.3.2.1-alpha. - - Don't log in the heartbeat any long term established one hop - rendezvous points if tor is a single onion service. Fixes bug - 25116; bugfix on 0.2.9.6-rc; + - Remove a BUG() statement when a client fetches an onion descriptor + that has a lower revision counter than the one in its cache. This + can happen in normal circumstances due to HSDir desync. Fixes bug + 24976; bugfix on 0.3.2.1-alpha. + - If we are configured to offer a single onion service, don't log + long-term established one hop rendezvous points in the heartbeat. + Fixes bug 25116; bugfix on 0.2.9.6-rc. o Minor bugfixes (performance): - Avoid calling protocol_list_supports_protocol() from inside tight @@ -121,13 +120,13 @@ Changes in version 0.3.3.2-alpha - 2018-02-09 o Minor bugfixes (scheduler, KIST): - Avoid adding the same channel twice in the KIST scheduler pending - list wasting CPU cycles at handling the same channel twice. Fixes - bug 24700; bugfix on 0.3.2.1-alpha. + list, which would waste CPU cycles handling the same channel twice. + Fixes bug 24700; bugfix on 0.3.2.1-alpha. o Minor bugfixes (unit test, monotonic time): - - Bump a gap of 1msec to 10msec used in the monotonic time test that - makes sure the nsec/usec/msec time read are synchronized. This - change was needed to accommodate slow system like armel or when + - Bump a gap of 1msec to 10msec in the monotonic time test that + makes sure the nsec/usec/msec times read are synchronized. This + change was needed to accommodate slow systems like armel or when the clock_gettime() is not a VDSO on the running kernel. Fixes bug 25113; bugfix on 0.2.9.1. @@ -137,17 +136,15 @@ Changes in version 0.3.3.2-alpha - 2018-02-09 v3 onion service protocol as a rendezvous point. Fixes bug 25105; bugfix on 0.3.2.1-alpha. - o Code simplification and refactoring: - - Remove the unused nodelist_recompute_all_hsdir_indices(). Closes - ticket 25108. - - o Documentation: + o Documentation (man page): - HiddenServiceVersion only accepts one version to be specified. This version can either be version 2 or 3. Closes ticket 25026; bugfix on 0.3.2.2-alpha. - o Code simplification and refactoring (rephist): - - Remove a series of counters used to track circuit extend attemps + o Code simplification and refactoring: + - Remove the unused nodelist_recompute_all_hsdir_indices(). Closes + ticket 25108. + - Remove a series of counters used to track circuit extend attempts and connection status but that in reality we aren't using for anything other than stats logged by a SIGUSR1 signal. Closes ticket 25163.

1 0

[metrics-web/master] Simplify setting the lower y axis limit to 0.
by karsten＠torproject.org 09 Feb '18

09 Feb '18

commit 73dd9973a5a8f65aec79764042e1ca587829d00f Author: Karsten Loesing <karsten.loesing(a)gmx.net> Date: Fri Feb 9 20:38:43 2018 +0100 Simplify setting the lower y axis limit to 0. --- src/main/R/rserver/graphs.R | 64 +++++++++++++++++---------------------------- 1 file changed, 24 insertions(+), 40 deletions(-) diff --git a/src/main/R/rserver/graphs.R b/src/main/R/rserver/graphs.R index 2a055c2..c7f7d90 100644 --- a/src/main/R/rserver/graphs.R +++ b/src/main/R/rserver/graphs.R @@ -303,8 +303,7 @@ plot_networksize <- function(start, end, path) { labels = date_format(date_breaks$format), date_breaks = date_breaks$major, date_minor_breaks = date_breaks$minor) + - scale_y_continuous(name = "", limits = c(0, max(networksize$value, - na.rm = TRUE))) + + scale_y_continuous(name = "", limits = c(0, NA)) + scale_colour_hue("", breaks = c("relays", "bridges"), labels = c("Relays", "Bridges")) + ggtitle("Number of relays\n") @@ -341,8 +340,7 @@ plot_versions <- function(start, end, path) { labels = date_format(date_breaks$format), date_breaks = date_breaks$major, date_minor_breaks = date_breaks$minor) + - scale_y_continuous(name = "", - limits = c(0, max(versions$relays, na.rm = TRUE))) + + scale_y_continuous(name = "", limits = c(0, NA)) + scale_colour_manual(name = "Tor version", values = colours[colours$breaks %in% visible_versions, 2], breaks = visible_versions) + @@ -370,8 +368,7 @@ plot_platforms <- function(start, end, path) { labels = date_format(date_breaks$format), date_breaks = date_breaks$major, date_minor_breaks = date_breaks$minor) + - scale_y_continuous(name = "", - limits = c(0, max(platforms$value, na.rm = TRUE))) + + scale_y_continuous(name = "", limits = c(0, NA)) + scale_colour_manual(name = "Platform", breaks = c("Linux", "Darwin", "BSD", "Windows", "Other"), labels = c("Linux", "macOS", "BSD", "Windows", "Other"), @@ -401,8 +398,7 @@ plot_bandwidth <- function(start, end, path) { labels = date_format(date_breaks$format), date_breaks = date_breaks$major, date_minor_breaks = date_breaks$minor) + - scale_y_continuous(name = "Bandwidth (Gbit/s)", - limits = c(0, max(bandwidth$value, na.rm = TRUE) * 8 / 1e9)) + + scale_y_continuous(name = "Bandwidth (Gbit/s)", limits = c(0, NA)) + scale_colour_hue(name = "", h.start = 90, breaks = c("bwadv", "bwhist"), labels = c("Advertised bandwidth", "Bandwidth history")) + @@ -448,8 +444,7 @@ plot_bwhist_flags <- function(start, end, path) { labels = date_format(date_breaks$format), date_breaks = date_breaks$major, date_minor_breaks = date_breaks$minor) + - scale_y_continuous(name="Bandwidth (Gbit/s)", - limits = c(0, max(bw$value, na.rm = TRUE) * 8 / 1e9)) + + scale_y_continuous(name="Bandwidth (Gbit/s)", limits = c(0, NA)) + scale_colour_manual(name = "", values = c("#E69F00", "#56B4E9", "#009E73", "#0072B2")) + ggtitle("Bandwidth history by relay flags") + @@ -477,8 +472,7 @@ plot_dirbytes <- function(start, end, path) { labels = date_format(date_breaks$format), date_breaks = date_breaks$major, date_minor_breaks = date_breaks$minor) + - scale_y_continuous(name="Bandwidth (Gbit/s)", - limits = c(0, max(dir$value, na.rm = TRUE) * 8 / 1e9)) + + scale_y_continuous(name="Bandwidth (Gbit/s)", limits = c(0, NA)) + scale_colour_hue(name = "", breaks = c("dirwrite", "dirread"), labels = c("Written dir bytes", "Read dir bytes")) + @@ -519,8 +513,7 @@ plot_relayflags <- function(start, end, flags, path) { labels = date_format(date_breaks$format), date_breaks = date_breaks$major, date_minor_breaks = date_breaks$minor, limits = as.Date(c(start, end))) + - scale_y_continuous(name = "", limits = c(0, max(networksize$value, - na.rm = TRUE))) + + scale_y_continuous(name = "", limits = c(0, NA)) + scale_colour_manual(name = "Relay flags", values = c("#E69F00", "#56B4E9", "#009E73", "#EE6A50", "#000000", "#0072B2"), breaks = flags, labels = flags) + @@ -567,8 +560,7 @@ plot_torperf <- function(start, end, source, server, filesize, path) { labels = date_format(date_breaks$format), date_breaks = date_breaks$major, date_minor_breaks = date_breaks$minor) + - scale_y_continuous(name = "") + - expand_limits(y = 0) + + scale_y_continuous(name = "", limits = c(0, NA)) + scale_fill_manual(name = paste("Measured times on", ifelse(source == "all", "all sources", source), "per day"), breaks = c("line", "ribbon"), @@ -724,8 +716,7 @@ plot_bandwidth_flags <- function(start, end, path) { labels = date_format(date_breaks$format), date_breaks = date_breaks$major, date_minor_breaks = date_breaks$minor) + - scale_y_continuous(name="Bandwidth (Gbit/s)", - limits = c(0, max(bandwidth$value, na.rm = TRUE) * 8 / 1e9)) + + scale_y_continuous(name="Bandwidth (Gbit/s)", limits = c(0, NA)) + scale_colour_manual(name = "", values = c("#E69F00", "#D6C827", "#009E73", "#00C34F")) + ggtitle(paste("Advertised bandwidth and bandwidth history by", @@ -854,8 +845,7 @@ plot_userstats <- function(start, end, node, variable, value, events, labels = date_format(date_breaks$format), date_breaks = date_breaks$major, date_minor_breaks = date_breaks$minor) + - scale_y_continuous(name = "", labels = formatter) + - expand_limits(y = 0) + + scale_y_continuous(name = "", labels = formatter, limits = c(0, NA)) + ggtitle(title) if (length(value) > 1) { plot <- plot + @@ -904,8 +894,6 @@ plot_userstats_bridge_combined <- function(start, end, country, path) { by = list(transport = u$transport), FUN = sum) a <- a[order(a$mid, decreasing = TRUE)[1:top], ] u <- u[u$transport %in% a$transport, ] - max_y <- ifelse(length(na.omit(u$high)) == 0, 0, - max(u$high, na.rm = TRUE)) title <- paste("Bridge users by transport from ", countryname(country), sep = "") date_breaks <- date_breaks( @@ -919,8 +907,7 @@ plot_userstats_bridge_combined <- function(start, end, country, path) { labels = date_format(date_breaks$format), date_breaks = date_breaks$major, date_minor_breaks = date_breaks$minor) + - scale_y_continuous(name = "", limits = c(0, max_y), - labels = formatter) + + scale_y_continuous(name = "", limits = c(0, NA), labels = formatter) + scale_colour_hue(paste("Top-", top, " transports", sep = "")) + scale_fill_hue(paste("Top-", top, " transports", sep = "")) + ggtitle(title) + @@ -951,7 +938,7 @@ plot_advbwdist_perc <- function(start, end, p, path) { date_breaks = date_breaks$major, date_minor_breaks = date_breaks$minor) + scale_y_continuous(name = "Advertised bandwidth in Gbit/s\n", - limits = c(0, max(t$advbw, na.rm = TRUE))) + + limits = c(0, NA)) + scale_colour_hue(name = "Percentile", breaks = rev(levels(t$percentile))) + ggtitle("Advertised bandwidth distribution\n") @@ -979,7 +966,7 @@ plot_advbwdist_relay <- function(start, end, n, path) { date_breaks = date_breaks$major, date_minor_breaks = date_breaks$minor) + scale_y_continuous(name = "Advertised bandwidth in Gbit/s\n", - limits = c(0, max(t$advbw, na.rm = TRUE))) + + limits = c(0, NA)) + scale_colour_hue(name = "n", breaks = levels(t$relay)) + ggtitle("Advertised bandwidth of n-th fastest relays\n") ggsave(filename = path, width = 8, height = 5, dpi = 150) @@ -1078,14 +1065,14 @@ plot_webstats_tb <- function(start, end, path) { ggplot(d, aes(x = log_date, y = count)) + geom_point() + geom_line() + - expand_limits(y = 0) + facet_grid(request_type ~ ., scales = "free_y") + scale_x_date(name = paste("\nThe Tor Project - ", "https://metrics.torproject.org/", sep = ""), labels = date_format(date_breaks$format), date_breaks = date_breaks$major, date_minor_breaks = date_breaks$minor) + - scale_y_continuous(name = 'Requests per day\n', labels = formatter) + + scale_y_continuous(name = 'Requests per day\n', labels = formatter, + limits = c(0, NA)) + theme(strip.text.y = element_text(angle = 0, hjust = 0, size = rel(1.5)), strip.background = element_rect(fill = NA)) + ggtitle("Tor Browser downloads and updates\n") @@ -1103,13 +1090,13 @@ plot_webstats_tb_platform <- function(start, end, path) { ggplot(d, aes(x = log_date, y = count, colour = platform)) + geom_point() + geom_line() + - expand_limits(y = 0) + scale_x_date(name = paste("\nThe Tor Project - ", "https://metrics.torproject.org/", sep = ""), labels = date_format(date_breaks$format), date_breaks = date_breaks$major, date_minor_breaks = date_breaks$minor) + - scale_y_continuous(name = 'Requests per day\n', labels = formatter) + + scale_y_continuous(name = 'Requests per day\n', labels = formatter, + limits = c(0, NA)) + scale_colour_hue(name = "Platform", breaks = c("w", "m", "l", "o", ""), labels = c("Windows", "macOS", "Linux", "Other", "Unknown")) + @@ -1134,13 +1121,13 @@ plot_webstats_tb_locale <- function(start, end, path) { ggplot(d, aes(x = log_date, y = count, colour = locale)) + geom_point() + geom_line() + - expand_limits(y = 0) + scale_x_date(name = paste("\nThe Tor Project - ", "https://metrics.torproject.org/", sep = ""), labels = date_format(date_breaks$format), date_breaks = date_breaks$major, date_minor_breaks = date_breaks$minor) + - scale_y_continuous(name = 'Requests per day\n', labels = formatter) + + scale_y_continuous(name = 'Requests per day\n', labels = formatter, + limits = c(0, NA)) + scale_colour_hue(name = "Locale", breaks = c(e$locale, "(other)"), labels = c(e$locale, "Other")) + @@ -1163,14 +1150,14 @@ plot_webstats_tm <- function(start, end, path) { ggplot(d, aes(x = log_date, y = count)) + geom_point() + geom_line() + - expand_limits(y = 0) + facet_grid(request_type ~ ., scales = "free_y") + scale_x_date(name = paste("\nThe Tor Project - ", "https://metrics.torproject.org/", sep = ""), labels = date_format(date_breaks$format), date_breaks = date_breaks$major, date_minor_breaks = date_breaks$minor) + - scale_y_continuous(name = 'Requests per day\n', labels = formatter) + + scale_y_continuous(name = 'Requests per day\n', labels = formatter, + limits = c(0, NA)) + theme(strip.text.y = element_text(angle = 0, hjust = 0, size = rel(1.5)), strip.background = element_rect(fill = NA)) + ggtitle("Tor Messenger downloads and updates\n") @@ -1204,12 +1191,11 @@ plot_relays_ipv6 <- function(start, end, path) { labels = date_format(date_breaks$format), date_breaks = date_breaks$major, date_minor_breaks = date_breaks$minor) + - scale_y_continuous(name = "") + + scale_y_continuous(name = "", limits = c(0, NA)) + scale_colour_hue(name = "", h.start = 90, breaks = c("total", "announced", "reachable", "exiting"), labels = c("Total (IPv4) OR", "IPv6 announced OR", "IPv6 reachable OR", "IPv6 exiting")) + - expand_limits(y = 0) + ggtitle("Relays by IP version") + theme(legend.position = "top") ggsave(filename = path, width = 8, height = 5, dpi = 150) @@ -1239,11 +1225,10 @@ plot_bridges_ipv6 <- function(start, end, path) { labels = date_format(date_breaks$format), date_breaks = date_breaks$major, date_minor_breaks = date_breaks$minor) + - scale_y_continuous(name = "") + + scale_y_continuous(name = "", limits = c(0, NA)) + scale_colour_hue(name = "", h.start = 90, breaks = c("total", "announced"), labels = c("Total (IPv4) OR", "IPv6 announced OR")) + - expand_limits(y = 0) + ggtitle("Bridges by IP version") + theme(legend.position = "top") ggsave(filename = path, width = 8, height = 5, dpi = 150) @@ -1282,13 +1267,12 @@ plot_advbw_ipv6 <- function(start, end, path) { labels = date_format(date_breaks$format), date_breaks = date_breaks$major, date_minor_breaks = date_breaks$minor) + - scale_y_continuous(name = "Bandwidth (Gbit/s)") + + scale_y_continuous(name = "Bandwidth (Gbit/s)", limits = c(0, NA)) + scale_colour_hue(name = "", h.start = 90, breaks = c("total", "total_guard", "total_exit", "reachable_guard", "reachable_exit", "exiting"), labels = c("Total (IPv4) OR", "Guard total (IPv4)", "Exit total (IPv4)", "Reachable guard IPv6 OR", "Reachable exit IPv6 OR", "IPv6 exiting")) + - expand_limits(y = 0) + ggtitle("Advertised bandwidth by IP version") + theme(legend.position = "top") + guides(colour = guide_legend(nrow = 2, byrow = TRUE))

1 0