November 2017 - tor-commits - lists.torproject.org

[tor/release-0.3.2] test: Initialize the voting schedule in test_dir.c
by nickm＠torproject.org 07 Nov '17

07 Nov '17

commit 33da5d7672dc7ac13ce2093a5789fb6bc48e4f86 Author: David Goulet <dgoulet(a)torproject.org> Date: Tue Oct 31 14:07:41 2017 -0400 test: Initialize the voting schedule in test_dir.c Signed-off-by: David Goulet <dgoulet(a)torproject.org> --- src/test/test_dir.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/test/test_dir.c b/src/test/test_dir.c index b920655db..87b86c38b 100644 --- a/src/test/test_dir.c +++ b/src/test/test_dir.c @@ -2379,6 +2379,7 @@ test_a_networkstatus( sign_skey_2 = crypto_pk_new(); sign_skey_3 = crypto_pk_new(); sign_skey_leg1 = pk_generate(4); + dirvote_recalculate_timing(get_options(), now); sr_state_init(0, 0); tt_assert(!crypto_pk_read_private_key_from_string(sign_skey_1,

1 0

[tor/release-0.3.2] Make tor recalculate voting schedule even if not a dirauth
by nickm＠torproject.org 07 Nov '17

07 Nov '17

commit ce99ebf25d3aec18ad840062a949aca4f98c14e6 Author: David Goulet <dgoulet(a)torproject.org> Date: Tue Oct 31 09:54:55 2017 -0400 Make tor recalculate voting schedule even if not a dirauth Because the HS subsystem needs the voting schedule to compute time period, we need all tor type to do that. Part of #23623 Signed-off-by: David Goulet <dgoulet(a)torproject.org> --- src/or/dirvote.c | 7 ++----- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/src/or/dirvote.c b/src/or/dirvote.c index 6f237e9b2..c5ceefecb 100644 --- a/src/or/dirvote.c +++ b/src/or/dirvote.c @@ -2863,16 +2863,13 @@ dirvote_get_next_valid_after_time(void) } /** Set voting_schedule to hold the timing for the next vote we should be - * doing. */ + * doing. All type of tor do that because HS subsystem needs the timing as + * well to function properly. */ void dirvote_recalculate_timing(const or_options_t *options, time_t now) { voting_schedule_t *new_voting_schedule; - if (!authdir_mode_v3(options)) { - return; - } - /* get the new voting schedule */ new_voting_schedule = get_voting_schedule(options, now, LOG_NOTICE); tor_assert(new_voting_schedule);

1 0

[tor/master] Merge branch 'maint-0.3.2'
by nickm＠torproject.org 07 Nov '17

07 Nov '17

commit c6c4a421fd7d8a0d4baba8f34276acaa245548f1 Merge: 0227aab1b 9d848ca58 Author: Nick Mathewson <nickm(a)torproject.org> Date: Tue Nov 7 09:58:53 2017 -0500 Merge branch 'maint-0.3.2' changes/bug23623 | 4 ++ src/or/dirvote.c | 68 ++++++++----------- src/or/dirvote.h | 7 +- src/or/shared_random.c | 8 +-- src/or/shared_random_state.c | 17 ++--- src/or/shared_random_state.h | 2 +- src/test/test_dir.c | 1 + src/test/test_hs_common.c | 21 +++++- src/test/test_hs_service.c | 4 ++ src/test/test_shared_random.c | 149 +++++++++++++++++------------------------- 10 files changed, 126 insertions(+), 155 deletions(-)

1 0

[tor/master] test: Fix voting schedule for hs_service.c
by nickm＠torproject.org 07 Nov '17

07 Nov '17

commit bd631a649b5cfae23fc13be08c72d5c1c0c70174 Author: David Goulet <dgoulet(a)torproject.org> Date: Tue Oct 31 14:48:27 2017 -0400 test: Fix voting schedule for hs_service.c Part of #23623 Signed-off-by: David Goulet <dgoulet(a)torproject.org> --- src/test/test_hs_service.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/src/test/test_hs_service.c b/src/test/test_hs_service.c index 462c860a9..3084c6b95 100644 --- a/src/test/test_hs_service.c +++ b/src/test/test_hs_service.c @@ -33,6 +33,7 @@ #include "circuitlist.h" #include "circuituse.h" #include "crypto.h" +#include "dirvote.h" #include "networkstatus.h" #include "nodelist.h" #include "relay.h" @@ -967,6 +968,7 @@ test_rotate_descriptors(void *arg) ret = parse_rfc1123_time("Sat, 26 Oct 1985 14:00:00 UTC", &mock_ns.fresh_until); tt_int_op(ret, OP_EQ, 0); + dirvote_recalculate_timing(get_options(), mock_ns.valid_after); /* Create a service with a default descriptor and state. It's added to the * global map. */ @@ -1004,6 +1006,7 @@ test_rotate_descriptors(void *arg) ret = parse_rfc1123_time("Sat, 27 Oct 1985 02:00:00 UTC", &mock_ns.fresh_until); tt_int_op(ret, OP_EQ, 0); + dirvote_recalculate_timing(get_options(), mock_ns.valid_after); /* Note down what to expect for the next rotation time which is 01:00 + 23h * meaning 00:00:00. */ @@ -1065,6 +1068,7 @@ test_build_update_descriptors(void *arg) ret = parse_rfc1123_time("Sat, 26 Oct 1985 04:00:00 UTC", &mock_ns.fresh_until); tt_int_op(ret, OP_EQ, 0); + dirvote_recalculate_timing(get_options(), mock_ns.valid_after); /* Create a service without a current descriptor to trigger a build. */ service = helper_create_service();

1 0

[tor/release-0.3.2] test: Fix voting schedule for hs_common.c
by nickm＠torproject.org 07 Nov '17

07 Nov '17

commit 814f4c6967d068f15ace98f78953a5dba0154ee7 Author: David Goulet <dgoulet(a)torproject.org> Date: Tue Oct 31 14:46:21 2017 -0400 test: Fix voting schedule for hs_common.c Part of #23623 Signed-off-by: David Goulet <dgoulet(a)torproject.org> --- src/test/test_hs_common.c | 21 ++++++++++++++++++++- 1 file changed, 20 insertions(+), 1 deletion(-) diff --git a/src/test/test_hs_common.c b/src/test/test_hs_common.c index 22fed12f1..b435a93e3 100644 --- a/src/test/test_hs_common.c +++ b/src/test/test_hs_common.c @@ -23,6 +23,7 @@ #include "config.h" #include "networkstatus.h" #include "directory.h" +#include "dirvote.h" #include "nodelist.h" #include "routerlist.h" #include "statefile.h" @@ -808,26 +809,41 @@ test_time_between_tp_and_srv(void *arg) ret = parse_rfc1123_time("Sat, 26 Oct 1985 00:00:00 UTC", &ns.valid_after); tt_int_op(ret, OP_EQ, 0); + ret = parse_rfc1123_time("Sat, 26 Oct 1985 01:00:00 UTC", &ns.fresh_until); + tt_int_op(ret, OP_EQ, 0); + dirvote_recalculate_timing(get_options(), ns.valid_after); ret = hs_in_period_between_tp_and_srv(&ns, 0); tt_int_op(ret, OP_EQ, 0); ret = parse_rfc1123_time("Sat, 26 Oct 1985 11:00:00 UTC", &ns.valid_after); tt_int_op(ret, OP_EQ, 0); + ret = parse_rfc1123_time("Sat, 26 Oct 1985 12:00:00 UTC", &ns.fresh_until); + tt_int_op(ret, OP_EQ, 0); + dirvote_recalculate_timing(get_options(), ns.valid_after); ret = hs_in_period_between_tp_and_srv(&ns, 0); tt_int_op(ret, OP_EQ, 0); ret = parse_rfc1123_time("Sat, 26 Oct 1985 12:00:00 UTC", &ns.valid_after); tt_int_op(ret, OP_EQ, 0); + ret = parse_rfc1123_time("Sat, 26 Oct 1985 13:00:00 UTC", &ns.fresh_until); + tt_int_op(ret, OP_EQ, 0); + dirvote_recalculate_timing(get_options(), ns.valid_after); ret = hs_in_period_between_tp_and_srv(&ns, 0); tt_int_op(ret, OP_EQ, 1); ret = parse_rfc1123_time("Sat, 26 Oct 1985 23:00:00 UTC", &ns.valid_after); tt_int_op(ret, OP_EQ, 0); + ret = parse_rfc1123_time("Sat, 27 Oct 1985 00:00:00 UTC", &ns.fresh_until); + tt_int_op(ret, OP_EQ, 0); + dirvote_recalculate_timing(get_options(), ns.valid_after); ret = hs_in_period_between_tp_and_srv(&ns, 0); tt_int_op(ret, OP_EQ, 1); - ret = parse_rfc1123_time("Sat, 26 Oct 1985 00:00:00 UTC", &ns.valid_after); + ret = parse_rfc1123_time("Sat, 27 Oct 1985 00:00:00 UTC", &ns.valid_after); + tt_int_op(ret, OP_EQ, 0); + ret = parse_rfc1123_time("Sat, 27 Oct 1985 01:00:00 UTC", &ns.fresh_until); tt_int_op(ret, OP_EQ, 0); + dirvote_recalculate_timing(get_options(), ns.valid_after); ret = hs_in_period_between_tp_and_srv(&ns, 0); tt_int_op(ret, OP_EQ, 0); @@ -1314,6 +1330,7 @@ run_reachability_scenario(const reachability_cfg_t *cfg, int num_scenario) &mock_service_ns->valid_until); set_consensus_times(cfg->service_valid_until, &mock_service_ns->fresh_until); + dirvote_recalculate_timing(get_options(), mock_service_ns->valid_after); /* Set client consensus time. */ set_consensus_times(cfg->client_valid_after, &mock_client_ns->valid_after); @@ -1321,6 +1338,7 @@ run_reachability_scenario(const reachability_cfg_t *cfg, int num_scenario) &mock_client_ns->valid_until); set_consensus_times(cfg->client_valid_until, &mock_client_ns->fresh_until); + dirvote_recalculate_timing(get_options(), mock_client_ns->valid_after); /* New time period checks for this scenario. */ tt_int_op(hs_in_period_between_tp_and_srv(mock_service_ns, 0), OP_EQ, @@ -1544,6 +1562,7 @@ helper_set_consensus_and_system_time(networkstatus_t *ns, int position) } else { tt_assert(0); } + dirvote_recalculate_timing(get_options(), ns->valid_after); /* Set system time: pretend to be just 2 minutes before consensus expiry */ real_time = ns->valid_until - 120;

1 0

[tor/release-0.3.2] Add changes file for #23623.
by nickm＠torproject.org 07 Nov '17

07 Nov '17

commit 023f62bda474cb52a8a31ba2ae6de95f3e506b18 Author: George Kadianakis <desnacked(a)riseup.net> Date: Tue Nov 7 00:28:14 2017 +0200 Add changes file for #23623. --- changes/bug23623 | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/changes/bug23623 b/changes/bug23623 new file mode 100644 index 000000000..1e2e5c2ac --- /dev/null +++ b/changes/bug23623 @@ -0,0 +1,4 @@ + o Minor bugfixes (onion services): + - Cache some needed onion service client information instead of + continuously computing it over and over again. Fixes bug 23623; bugfix + on 0.3.2.1-alpha.

1 0

[tor/release-0.3.2] test: Fix voting schedule for hs_service.c
by nickm＠torproject.org 07 Nov '17

07 Nov '17

commit bd631a649b5cfae23fc13be08c72d5c1c0c70174 Author: David Goulet <dgoulet(a)torproject.org> Date: Tue Oct 31 14:48:27 2017 -0400 test: Fix voting schedule for hs_service.c Part of #23623 Signed-off-by: David Goulet <dgoulet(a)torproject.org> --- src/test/test_hs_service.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/src/test/test_hs_service.c b/src/test/test_hs_service.c index 462c860a9..3084c6b95 100644 --- a/src/test/test_hs_service.c +++ b/src/test/test_hs_service.c @@ -33,6 +33,7 @@ #include "circuitlist.h" #include "circuituse.h" #include "crypto.h" +#include "dirvote.h" #include "networkstatus.h" #include "nodelist.h" #include "relay.h" @@ -967,6 +968,7 @@ test_rotate_descriptors(void *arg) ret = parse_rfc1123_time("Sat, 26 Oct 1985 14:00:00 UTC", &mock_ns.fresh_until); tt_int_op(ret, OP_EQ, 0); + dirvote_recalculate_timing(get_options(), mock_ns.valid_after); /* Create a service with a default descriptor and state. It's added to the * global map. */ @@ -1004,6 +1006,7 @@ test_rotate_descriptors(void *arg) ret = parse_rfc1123_time("Sat, 27 Oct 1985 02:00:00 UTC", &mock_ns.fresh_until); tt_int_op(ret, OP_EQ, 0); + dirvote_recalculate_timing(get_options(), mock_ns.valid_after); /* Note down what to expect for the next rotation time which is 01:00 + 23h * meaning 00:00:00. */ @@ -1065,6 +1068,7 @@ test_build_update_descriptors(void *arg) ret = parse_rfc1123_time("Sat, 26 Oct 1985 04:00:00 UTC", &mock_ns.fresh_until); tt_int_op(ret, OP_EQ, 0); + dirvote_recalculate_timing(get_options(), mock_ns.valid_after); /* Create a service without a current descriptor to trigger a build. */ service = helper_create_service();

1 0

[tor/release-0.3.2] Merge remote-tracking branch 'asn/ticket23623_032_01' into maint-0.3.2
by nickm＠torproject.org 07 Nov '17

07 Nov '17

commit 9d848ca58a4624df7abae298d8977ae82bcfb543 Merge: 7d767706e 023f62bda Author: Nick Mathewson <nickm(a)torproject.org> Date: Tue Nov 7 09:58:42 2017 -0500 Merge remote-tracking branch 'asn/ticket23623_032_01' into maint-0.3.2 changes/bug23623 | 4 ++ src/or/dirvote.c | 68 ++++++++----------- src/or/dirvote.h | 7 +- src/or/shared_random.c | 8 +-- src/or/shared_random_state.c | 17 ++--- src/or/shared_random_state.h | 2 +- src/test/test_dir.c | 1 + src/test/test_hs_common.c | 21 +++++- src/test/test_hs_service.c | 4 ++ src/test/test_shared_random.c | 149 +++++++++++++++++------------------------- 10 files changed, 126 insertions(+), 155 deletions(-)

1 0

[tor/release-0.3.2] Merge branch 'maint-0.3.2' into release-0.3.2
by nickm＠torproject.org 07 Nov '17

07 Nov '17

commit 89ed93e46818d0c1d1ae47f8848fac752149eef1 Merge: bd432bbac 9d848ca58 Author: Nick Mathewson <nickm(a)torproject.org> Date: Tue Nov 7 09:58:53 2017 -0500 Merge branch 'maint-0.3.2' into release-0.3.2 changes/bug23623 | 4 ++ src/or/dirvote.c | 68 ++++++++----------- src/or/dirvote.h | 7 +- src/or/shared_random.c | 8 +-- src/or/shared_random_state.c | 17 ++--- src/or/shared_random_state.h | 2 +- src/test/test_dir.c | 1 + src/test/test_hs_common.c | 21 +++++- src/test/test_hs_service.c | 4 ++ src/test/test_shared_random.c | 149 +++++++++++++++++------------------------- 10 files changed, 126 insertions(+), 155 deletions(-)

1 0

[translation/tor-browser-manual] Update translations for tor-browser-manual
by translation＠torproject.org 07 Nov '17

07 Nov '17

commit 23709d43a43ed039e3e298a084d604d90504a904 Author: Translation commit bot <translation(a)torproject.org> Date: Tue Nov 7 14:20:38 2017 +0000 Update translations for tor-browser-manual --- it/it.po | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/it/it.po b/it/it.po index 2e11ec06b..ed2a79b4e 100644 --- a/it/it.po +++ b/it/it.po @@ -504,6 +504,8 @@ msgid "" "Wait for your download to finish, then find the “Generate Hash” section in " "Satori’s menu and click “Select Files”." msgstr "" +"Aspettate che il download sia terminato, poi cercate il menu \"Genera hash\"" +" tra i menu di Satori e clicca su \" Seleziona files\"" #: downloading.page:121 msgid "" @@ -904,6 +906,8 @@ msgid "" "Onion services (formerly known as “hidden services”) are services (like " "websites) that are only accessible through the Tor network." msgstr "" +"I servizi Onion ( conosciuti anche come \"Servizi nascosti\") sono servizi (" +" come i siti web) a cui è possibile accedere solo attraverso la rete Tor" #: onionsites.page:16 msgid "" @@ -939,6 +943,10 @@ msgid "" " that it is connecting to the right location and that the connection is not " "being tampered with." msgstr "" +"Gli indirizzi di un servizio onion sono generati automaticamente, gli utenti" +" quindi non hanno bisogno di comprare un dominio; il suffisso .onion aiuta " +"Tor ad accertarsi che sia connesso all'indirizzo corretto e che la " +"connessione non sia stata reindirizzata" #: onionsites.page:46 msgid "How to access an onion service"

1 0