tor-commits March 2016

tor-commits@lists.torproject.org

16 participants
1259 discussions

[tor/master] Sandbox: Don't preseed getaddrinfo(gethostname()) in client mode.
by nickm＠torproject.org 21 Mar '16

21 Mar '16

commit 368825ff4529e78ec5be3f79aacf5a5bdd18ef6a Author: Nick Mathewson <nickm(a)torproject.org> Date: Tue Mar 15 11:19:59 2016 -0400 Sandbox: Don't preseed getaddrinfo(gethostname()) in client mode. If we're a server with no address configured, resolve_my_hostname will need this. But not otherwise. And the preseeding itself can consume a few seconds if like tails we have no resolvers. Fixes bug 18548. --- changes/bug18548 | 12 ++++++++++++ src/or/config.c | 1 + src/or/main.c | 7 +++++++ 3 files changed, 20 insertions(+) diff --git a/changes/bug18548 b/changes/bug18548 new file mode 100644 index 0000000..262d1d3 --- /dev/null +++ b/changes/bug18548 @@ -0,0 +1,12 @@ + o Minor bugfixes (linux seccomp2 sandbox): + - Avoid a 10-second delay when starting as a client with Sandbox 1 + enabled and no DNS resolvers configured. This should help TAILS + start up faster. Fixes bug 18548; bugfix on 0.2.5.1-alpha. + + + o Minor features (linux seccomp2 sandbox): + - Detect and reject attempts to change our Address with Sandbox 1 + enabled. Changing Address with Sandbox turned on would never + actually work, but previously it would fail in strange and + confusing ways. Found while fixing 18548. + diff --git a/src/or/config.c b/src/or/config.c index 0e15f9b..ed436f9 100644 --- a/src/or/config.c +++ b/src/or/config.c @@ -4267,6 +4267,7 @@ options_transition_allowed(const or_options_t *old, } \ } while (0) + SB_NOCHANGE_STR(Address); SB_NOCHANGE_STR(PidFile); SB_NOCHANGE_STR(ServerDNSResolvConfFile); SB_NOCHANGE_STR(DirPortFrontPage); diff --git a/src/or/main.c b/src/or/main.c index 713816d..f37c23c 100644 --- a/src/or/main.c +++ b/src/or/main.c @@ -3312,6 +3312,13 @@ do_dump_config(void) static void init_addrinfo(void) { + if (! server_mode(get_options()) || + (get_options()->Address && strlen(get_options()->Address) > 0)) { + /* We don't need to seed our own hostname, because we won't be calling + * resolve_my_address on it. + */ + return; + } char hname[256]; // host name to sandbox

1 0

[tor/master] Merge remote-tracking branch 'public/bug18548'
by nickm＠torproject.org 21 Mar '16

21 Mar '16

commit 233180a9ab3dac64560f4a90548f62bcbfec6ed8 Merge: d567796 368825f Author: Nick Mathewson <nickm(a)torproject.org> Date: Mon Mar 21 12:36:41 2016 -0400 Merge remote-tracking branch 'public/bug18548' changes/bug18548 | 12 ++++++++++++ src/or/config.c | 1 + src/or/main.c | 7 +++++++ 3 files changed, 20 insertions(+)

1 0

[tor/master] punctuate changes file better
by nickm＠torproject.org 21 Mar '16

21 Mar '16

commit c83bcc358437660471abdc11ed9e12585674e0d6 Author: Nick Mathewson <nickm(a)torproject.org> Date: Mon Mar 21 12:37:10 2016 -0400 punctuate changes file better --- changes/bug18548 | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/changes/bug18548 b/changes/bug18548 index 262d1d3..542d331 100644 --- a/changes/bug18548 +++ b/changes/bug18548 @@ -1,11 +1,11 @@ o Minor bugfixes (linux seccomp2 sandbox): - - Avoid a 10-second delay when starting as a client with Sandbox 1 + - Avoid a 10-second delay when starting as a client with "Sandbox 1" enabled and no DNS resolvers configured. This should help TAILS start up faster. Fixes bug 18548; bugfix on 0.2.5.1-alpha. o Minor features (linux seccomp2 sandbox): - - Detect and reject attempts to change our Address with Sandbox 1 + - Detect and reject attempts to change our Address with "Sandbox 1" enabled. Changing Address with Sandbox turned on would never actually work, but previously it would fail in strange and confusing ways. Found while fixing 18548.

1 0

[tor/master] Merge remote-tracking branch 'public/bug17443_v2'
by nickm＠torproject.org 21 Mar '16

21 Mar '16

commit d567796946506672376ceda86789b2bcb0a25ad0 Merge: 34d429f a874d66 Author: Nick Mathewson <nickm(a)torproject.org> Date: Mon Mar 21 11:21:31 2016 -0400 Merge remote-tracking branch 'public/bug17443_v2' changes/bug17443 | 5 +++++ src/tools/tor-gencert.c | 9 ++++++++- 2 files changed, 13 insertions(+), 1 deletion(-)

1 0

[tor/master] Handle the case where tor-gencert gets a passphrase with no NL
by nickm＠torproject.org 21 Mar '16

21 Mar '16

commit a874d66ea9ddb8c64189f33bb2a9ef05ee74f3fe Author: Nick Mathewson <nickm(a)torproject.org> Date: Thu Feb 11 13:21:47 2016 -0500 Handle the case where tor-gencert gets a passphrase with no NL Closes ticket 17443. --- changes/bug17443 | 5 +++++ src/tools/tor-gencert.c | 9 ++++++++- 2 files changed, 13 insertions(+), 1 deletion(-) diff --git a/changes/bug17443 b/changes/bug17443 new file mode 100644 index 0000000..e4c040b --- /dev/null +++ b/changes/bug17443 @@ -0,0 +1,5 @@ + o Minor bugfixes (tor-gencert): + - Correctly handle the case where an authority operator enters a + passphrase but sends an EOF before sending a newline. + Fixes bug 17443; bugfix on 0.2.0.20-rc. Found by "junglefowl". + diff --git a/src/tools/tor-gencert.c b/src/tools/tor-gencert.c index e833aa9..4e5e1dc 100644 --- a/src/tools/tor-gencert.c +++ b/src/tools/tor-gencert.c @@ -96,14 +96,21 @@ load_passphrase(void) { char *cp; char buf[1024]; /* "Ought to be enough for anybody." */ + memset(buf, 0, sizeof(buf)); /* should be needless */ ssize_t n = read_all(passphrase_fd, buf, sizeof(buf), 0); if (n < 0) { log_err(LD_GENERAL, "Couldn't read from passphrase fd: %s", strerror(errno)); return -1; } + /* We'll take everything from the buffer except for optional terminating + * newline. */ cp = memchr(buf, '\n', n); - passphrase_len = cp-buf; + if (cp == NULL) { + passphrase_len = n; + } else { + passphrase_len = cp-buf; + } passphrase = tor_strndup(buf, passphrase_len); memwipe(buf, 0, sizeof(buf)); return 0;

1 0

[tor/master] Sort changes files into changelog.
by nickm＠torproject.org 21 Mar '16

21 Mar '16

commit 4bb432f633f728e54cd5c6bef7299019578f2ea9 Author: Nick Mathewson <nickm(a)torproject.org> Date: Mon Mar 21 11:18:15 2016 -0400 Sort changes files into changelog. --- ChangeLog | 256 ++++++++++++++++++++++++++++++++++++++++ changes/assert_event_base | 5 - changes/bug14821 | 4 - changes/bug15221 | 4 - changes/bug15937 | 7 -- changes/bug16023 | 4 - changes/bug16248 | 8 -- changes/bug16825 | 7 -- changes/bug17153 | 4 - changes/bug17732 | 10 -- changes/bug17852 | 10 -- changes/bug18051 | 5 - changes/bug18116 | 4 - changes/bug18123 | 4 - changes/bug18162 | 7 -- changes/bug18184 | 5 - changes/bug18204_028 | 3 - changes/bug18208 | 5 - changes/bug18221 | 3 - changes/bug18242 | 6 - changes/bug18258 | 12 -- changes/bug18259 | 4 - changes/bug18261 | 6 - changes/bug18296 | 4 - changes/bug18348 | 5 - changes/bug18374 | 3 - changes/bug18384 | 5 - changes/bug18426_18459 | 4 - changes/bug18448 | 6 - changes/bug18454 | 8 -- changes/bug18458 | 9 -- changes/bug18570 | 7 -- changes/bug18600 | 3 - changes/bug8976 | 5 - changes/build18490 | 4 - changes/feature17840 | 9 -- changes/geoip-february2016 | 4 - changes/geoip-march2016 | 4 - changes/remove_memarea_freelist | 4 - changes/test_asan | 3 - changes/ticket17744 | 4 - changes/ticket18332 | 10 -- changes/trunnel_update | 5 - 43 files changed, 256 insertions(+), 233 deletions(-) diff --git a/ChangeLog b/ChangeLog index c39ea19..f6cd2b4 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,259 @@ +Changes in version 0.2.8.2-rc - 2016-03-?? + Tor 0.2.8.1-alpha is the first release candidate in its series. + XXXX write more here XXXX + + o New system requirements: + - Tor no longer supports versions of OpenSSL with a broken + implementation of counter mode. (This bug was present in OpenSSL + 1.0.0, and was fixed in OpenSSL 1.0.0a.) Tor still detects, but + no longer runs with, these versions. + - Tor no longer attempts to support platforms where the "time_t" type + is unsigned. (To the best of our knowledge, only OpenVMS does this, + and Tor has never actually built on OpenVMS.) Closes ticket 18184. + + o Removed features: + - Streamline relay-side hsdir handling: when relays consider whether + to accept an uploaded hidden service descriptor, they no longer + check whether they are one of the relays in the network that is + "supposed" to handle that descriptor. Implements ticket 18332. + - We no longer maintain an internal freelist in memarea.c. Allocators + should be good enough to make this code unnecessary, and it's doubtful + that it ever had any performance benefit. + + o Major bugfixes (dns proxy mode, crash): + - Avoid crashing when running as a DNS proxy. Fixes bug 16248; bugfix on + 0.2.0.1-alpha. Patch from 'cypherpunks'. + + o Major bugfixes (security, pointers): + - Avoid a difficult-to-trigger heap corruption attack when extending + a smartlist to contain over 16GB of pointers. Fixes bug 18162; + bugfix on Tor 0.1.1.11-alpha, which fixed a related bug + incompletely. Reported by Guido Vranken. + + o Major bugfixes (compilation): + - Repair hardened builds under the clang compiler. Previously, + our use of _FORTIFY_SOURCE would conflict with clang's address + sanitizer. Fixes bug 14821; bugfix on 0.2.5.4-alpha. + + o Major bugfixes (crash on shutdown): + - Correctly handle detaching circuits from cmuxes when doing + circuit_free_all() on shutdown. Fixes bug 18116; bugfix on + 0.2.8.1-alpha. + + o Major bugfixes (relays, bridge clients): + - Ensure relays always allow IPv4 OR and Dir connections. + Ensure bridge clients use the address configured in the bridge line. + Fixes bug 18348; bugfix on 0.2.8.1-alpha. + Reported by sysrqb, patch by teor. + + o Minor feature (IPv6): + - Add ClientPreferIPv6DirPort, which is set to 0 by default. If set + to 1, tor prefers IPv6 directory addresses. + - Add ClientUseIPv4, which is set to 1 by default. If set to 0, tor + avoids using IPv4 for client OR and directory connections. + - Try harder to fulfil IP version restrictions ClientUseIPv4 0 and + ClientUseIPv6 0; and the preferences ClientPreferIPv6ORPort and + ClientPreferIPv6DirPort. + Closes ticket 17840; patch by "teor". + + o Minor features (bug-resistance): + - Make Tor survive errors involving connections without a corresponding + event object. Previously we'd fail with an assertion; now we produce a + log message. Related to bug 16248. + + o Minor features (build): + - Detect systems with FreeBSD-derived kernels (such as GNU/kFreeBSD) as + having possible IPfW support. Closes ticket 18448. Patch from + Steven Chamberlain. + + o Minor features (code hardening): + - Use tor_snprintf() and tor_vsnprintf() even in external and + low-level code, to harden against accidental failures to NUL- + terminate. Part of ticket 17852. Patch from 'jsturgix'. Found + with Flawfinder. + + o Minor features (compilation): + - Note our minimum required autoconf/automake versions in the + appropriate locations. Closes ticket 17732. + + o Minor features (crypto): + - Fix a segfault during startup: If unix socket was configured as + listener (such as a ControlSocket or a SocksPort unix socket), and + tor was started as root but not configured to switch to another + user, tor would segfault while trying to string compare a NULL + value. Fixes bug 18261; bugfix on 0.2.8.1-alpha. Patch by weasel. + - Validate the Diffie-Hellman hard coded parameters and ensure that + p is a safe prime, and g is suitable. Closes ticket 18221. + + o Minor features (geoip): + - Update geoip and geoip6 to the March 3 2016 Maxmind GeoLite2 + Country database. + + o Minor features (robustness): + - Exit immediately with an error message if the code attempts to + use libevent without having initialized it. This should resolve + some frequently-made mistakes in our unit tests. Closes ticket + 18241. + + o Minor features (unix domain sockets): + - Since some operating systems do not consider the actual modes on a + UNIX domain socket itself, tor does not allow creating such a + socket in a directory that is group or world accessible if it is + supposed to be private. Likewise, it will not allow only group + accessible sockets in a world accessible directory. + However, on some operating systems this is unnecessary, so + add a per-socket option called RelaxDirModeCheck. + Closes ticket 18458. Patch by weasel. + + o Minor features: + - Update geoip and geoip6 to the February 2 2016 Maxmind GeoLite2 + Country database. + + o Minor bugfixes (build): + - Do not link the unit tests against both the testing and non-testing + versions of the static libraries. Fixes bug 18490; bugfix on + 0.2.7.1-alpha. + + o Minor bugfixes (client): + - Count receipt of new microdescriptors as progress towards + bootstrapping. Now, when a user who has set EntryNodes finishes + bootstrapping, Tor automatically repopulates the guard set based + on this new directory information. Fixes bug 16825; bugfix on + 0.2.3.1-alpha. + + o Minor bugfixes (code correctness): + - Update to the latest version of Trunnel, which tries harder + to avoid generating code that can invoke memcpy(p,NULL,0). + Bug found by clang address sanitizer. Fixes bug 18373; bugfix + on 0.2.7.2-alpha. + + o Minor bugfixes (configuration): + - Fix a tiny memory leak when parsing a port configuration ending in + ":auto". Fixes bug 18374; bugfix on 0.2.3.3-alpha. + + o Minor bugfixes (containers): + - If we somehow attempt to construct a heap with more than + 1073741822 elements, avoid an integer overflow when maintaining + the heap property. Fixes bug 18296; bugfix on 0.1.2.1-alpha. + + o Minor bugfixes (correctness): + - Fix a bad memory handling bug that would occur if we had queued + a cell on a channel's incoming queue. Fortunately, we can't actually + queue a cell like that as our code is constructed today, but it's best + to avoid this kind of error, even if there isn't any code that triggers + it today. Fixes bug 18570; bugfix on 0.2.4.4-alpha. + + o Minor bugfixes (crypto, static analysis): + - Silence spurious clang-scan warnings in the ed25519_donna code + by explicitly initialising some objects. + Fixes bug 18384; bugfix on 0f3eeca9 in 0.2.7.2-alpha. + Patch by "teor". + + o Minor bugfixes (directory): + - When generating a URL for a directory server on an IPv6 address, + wrap the IPv6 address in square brackets. Fixes bug 18051; + bugfix on 0.2.3.9-alpha. Patch from Malek. + + o Minor bugfixes (exit policies, security): + - Refresh an exit relay's exit policy when interface addresses change. + Previously, tor only refreshed the exit policy when the configured + external address changed. + Fixes bug 18208; bugfix on tor 0.2.7.3. Patch by "teor". + + o Minor bugfixes (hidden service client): + - Seven very fast consecutive requests to the same .onion address + triggers 7 descriptor fetches. The first six each pick a directory + (there are 6 overall) and the seventh one wasn't able to pick one + which was triggering a close on all current directory connections. It + has been fixed by not closing them if we have pending directory fetch. + Fixes bug 15937; bugfix on tor-0.2.7.1-alpha. + + o Minor bugfixes (hidden service, control port): + - Add the onion address to the HS_DESC event for the UPLOADED action + both on success or failure. It was previously hardcoded with UNKNOWN. + Fixes bug 16023; bugfix on 0.2.7.2-alpha. + + o Minor bugfixes (logging): + - Scrub service in from "unrecognized service ID" log messages. + Fixes bug 18600; bugfix on 0.2.4.11-alpha. + + o Minor bugfixes (memory safety): + - Avoid freeing an uninitialised pointer when opening a socket fails + in get_interface_addresses_ioctl. + Fixes bug 18454; bugfix on 9f06ec0c in tor-0.2.3.11-alpha. + Reported by "toralf" and "cypherpunks", patch by "teor". + - Correctly duplicate addresses in get_interface_address6_list. + Fixes bug 18454; bugfix on 110765f5 in tor-0.2.8.1-alpha. + Reported by "toralf", patch by "cypherpunks". + + o Minor bugfixes (private directory): + - Prevent a race condition when creating private directories. + Fixes part of bug 17852; bugfix on 0.2pre13. Part of ticket + 17852. Patch from 'jsturgix'. Found with Flawfinder. + + o Minor bugfixes (sandbox): + - Allow the setrlimit syscall, and the prlimit and prlimit64 syscalls, + which some libc implementations + use under the hood. Fixes bug 15221; bugfix on 0.2.5.1-alpha. + + o Minor bugfixes (security, hidden services): + - Prevent hidden services connecting to client-supplied rendezvous + addresses that are reserved as internal or multicast. + Fixes bug 8976; bugfix on b7c172c9e in tor-0.2.3.21. + Patch by "dgoulet" and "teor". + + o Minor bugfixes (security, win32): + - Set SO_EXCLUSIVEADDRUSE on Win32 to avoid a local port-stealing + attack. + Fixes bug 18123; bugfix on all tor versions. Patch by "teor". + + o Minor bugfixes (test networks, IPv6): + - Allow internal IPv6 addresses in descriptors in test networks. + Fixes bug 17153; bugfix on 6b4af1071 in 0.2.3.16-alpha. + Patch by "teor", reported by "karsten". + + o Minor bugfixes (testing): + - We no longer disable assertions in the unit tests when coverage + is enabled. Instead, we require you to say --disable-asserts-in-tests + to the configure script if you need assertions disabled in the + unit tests (for example, if you want to perform branch coverage). + Fixes bug 18242; bugfix on 0.2.7.1-alpha. + + o Minor bugfixes: + - Bridges now refuse "rendezvous2" (hidden service descriptor) + publish attempts. Suggested by ticket 18332. + + o Code simplification and refactoring: + - Quote all the string interpolations in configure.ac -- even + those which we are pretty sure can't contain spaces. Closes + ticket 17744. Patch from "zerosion". + - Remove specialized code for non-inplace AES_CTR. 99% of our AES + is inplace, so there's no need to have a separate implementation + for the non-inplace code. Closes ticket 18258. Patch from + Malek. + - Simplify return types for some crypto functions that can't + actually fail. Patch from Hassan Alsibyani. Closes ticket + 18259. + + o Dependency updates: + - Tor now uses Autoconf version 2.63 or later, and Automake 1.11 or later + (released in 2008 and 2009 respectively). If you are building Tor from + the git repository instead of from the source distribution, and your + tools are older than this, you will need to upgrade. + Closes ticket 17732. + + o Documentation: + - Change build messages to refer to "Fedora" instead of "Fedora Core", + and "dnf" instead of "yum". Closes tickets 18459 and 18426. + Patches from "icanhasaccount" and "cypherpunks". + + o Testing: + - Fix several warnings from clang's address sanitizer produced in the + unit tests. + - Treat backtrace test failures as expected on FreeBSD until we + solve bug 17808. Closes ticket 18204. + + Changes in version 0.2.8.1-alpha - 2016-02-04 Tor 0.2.8.1-alpha is the first alpha release in its series. It includes numerous small features and bugfixes against previous Tor diff --git a/changes/assert_event_base b/changes/assert_event_base deleted file mode 100644 index b887795..0000000 --- a/changes/assert_event_base +++ /dev/null @@ -1,5 +0,0 @@ - o Minor features (robustness): - - Exit immediately with an error message if the code attempts to - use libevent without having initialized it. This should resolve - some frequently-made mistakes in our unit tests. Closes ticket - 18241. diff --git a/changes/bug14821 b/changes/bug14821 deleted file mode 100644 index e9ccc2f..0000000 --- a/changes/bug14821 +++ /dev/null @@ -1,4 +0,0 @@ - o Major bugfixes (compilation): - - Repair hardened builds under the clang compiler. Previously, - our use of _FORTIFY_SOURCE would conflict with clang's address - sanitizer. Fixes bug 14821; bugfix on 0.2.5.4-alpha. diff --git a/changes/bug15221 b/changes/bug15221 deleted file mode 100644 index d466e1d..0000000 --- a/changes/bug15221 +++ /dev/null @@ -1,4 +0,0 @@ - o Minor bugfixes (sandbox): - - Allow the setrlimit syscall, and the prlimit and prlimit64 syscalls, - which some libc implementations - use under the hood. Fixes bug 15221; bugfix on 0.2.5.1-alpha. diff --git a/changes/bug15937 b/changes/bug15937 deleted file mode 100644 index 88adbe4..0000000 --- a/changes/bug15937 +++ /dev/null @@ -1,7 +0,0 @@ - o Minor bugfixes (hidden service client): - - Seven very fast consecutive requests to the same .onion address - triggers 7 descriptor fetches. The first six each pick a directory - (there are 6 overall) and the seventh one wasn't able to pick one - which was triggering a close on all current directory connections. It - has been fixed by not closing them if we have pending directory fetch. - Fixes bug 15937; bugfix on tor-0.2.7.1-alpha. diff --git a/changes/bug16023 b/changes/bug16023 deleted file mode 100644 index 96c0904..0000000 --- a/changes/bug16023 +++ /dev/null @@ -1,4 +0,0 @@ - o Minor bugfixes (hidden service, control port): - - Add the onion address to the HS_DESC event for the UPLOADED action - both on success or failure. It was previously hardcoded with UNKNOWN. - Fixes bug 16023; bugfix on 0.2.7.2-alpha. diff --git a/changes/bug16248 b/changes/bug16248 deleted file mode 100644 index a07eba9..0000000 --- a/changes/bug16248 +++ /dev/null @@ -1,8 +0,0 @@ - o Major bugfixes (dns proxy mode, crash): - - Avoid crashing when running as a DNS proxy. Fixes bug 16248; bugfix on - 0.2.0.1-alpha. Patch from 'cypherpunks'. - - o Minor features (bug-resistance): - - Make Tor survive errors involving connections without a corresponding - event object. Previously we'd fail with an assertion; now we produce a - log message. Related to bug 16248. diff --git a/changes/bug16825 b/changes/bug16825 deleted file mode 100644 index ab0879a..0000000 --- a/changes/bug16825 +++ /dev/null @@ -1,7 +0,0 @@ - o Minor bugfixes (client): - - Count receipt of new microdescriptors as progress towards - bootstrapping. Now, when a user who has set EntryNodes finishes - bootstrapping, Tor automatically repopulates the guard set based - on this new directory information. Fixes bug 16825; bugfix on - 0.2.3.1-alpha. - diff --git a/changes/bug17153 b/changes/bug17153 deleted file mode 100644 index 15a53c1..0000000 --- a/changes/bug17153 +++ /dev/null @@ -1,4 +0,0 @@ - o Minor bugfixes (test networks, IPv6): - - Allow internal IPv6 addresses in descriptors in test networks. - Fixes bug 17153; bugfix on 6b4af1071 in 0.2.3.16-alpha. - Patch by "teor", reported by "karsten". diff --git a/changes/bug17732 b/changes/bug17732 deleted file mode 100644 index 010645d..0000000 --- a/changes/bug17732 +++ /dev/null @@ -1,10 +0,0 @@ - o Minor features (compilation): - - Note our minimum required autoconf/automake versions in the - appropriate locations. Closes ticket 17732. - - o Dependency updates: - - Tor now uses Autoconf version 2.63 or later, and Automake 1.11 or later - (released in 2008 and 2009 respectively). If you are building Tor from - the git repository instead of from the source distribution, and your - tools are older than this, you will need to upgrade. - Closes ticket 17732. diff --git a/changes/bug17852 b/changes/bug17852 deleted file mode 100644 index b36b55f..0000000 --- a/changes/bug17852 +++ /dev/null @@ -1,10 +0,0 @@ - o Minor features (code hardening): - - Use tor_snprintf() and tor_vsnprintf() even in external and - low-level code, to harden against accidental failures to NUL- - terminate. Part of ticket 17852. Patch from 'jsturgix'. Found - with Flawfinder. - - o Minor bugfixes (private directory): - - Prevent a race condition when creating private directories. - Fixes part of bug 17852; bugfix on 0.2pre13. Part of ticket - 17852. Patch from 'jsturgix'. Found with Flawfinder. diff --git a/changes/bug18051 b/changes/bug18051 deleted file mode 100644 index 0dd32f0..0000000 --- a/changes/bug18051 +++ /dev/null @@ -1,5 +0,0 @@ - o Minor bugfixes (directory): - - When generating a URL for a directory server on an IPv6 address, - wrap the IPv6 address in square brackets. Fixes bug 18051; - bugfix on 0.2.3.9-alpha. Patch from Malek. - diff --git a/changes/bug18116 b/changes/bug18116 deleted file mode 100644 index bcb96e8..0000000 --- a/changes/bug18116 +++ /dev/null @@ -1,4 +0,0 @@ - o Major bugfixes (crash on shutdown): - - Correctly handle detaching circuits from cmuxes when doing - circuit_free_all() on shutdown. Fixes bug 18116; bugfix on - 0.2.8.1-alpha. diff --git a/changes/bug18123 b/changes/bug18123 deleted file mode 100644 index 1359b4e..0000000 --- a/changes/bug18123 +++ /dev/null @@ -1,4 +0,0 @@ - o Minor bugfixes (security, win32): - - Set SO_EXCLUSIVEADDRUSE on Win32 to avoid a local port-stealing - attack. - Fixes bug 18123; bugfix on all tor versions. Patch by "teor". diff --git a/changes/bug18162 b/changes/bug18162 deleted file mode 100644 index 88d19a8..0000000 --- a/changes/bug18162 +++ /dev/null @@ -1,7 +0,0 @@ - o Major bugfixes (security, pointers): - - - Avoid a difficult-to-trigger heap corruption attack when extending - a smartlist to contain over 16GB of pointers. Fixes bug 18162; - bugfix on Tor 0.1.1.11-alpha, which fixed a related bug - incompletely. Reported by Guido Vranken. - diff --git a/changes/bug18184 b/changes/bug18184 deleted file mode 100644 index 01b97d4..0000000 --- a/changes/bug18184 +++ /dev/null @@ -1,5 +0,0 @@ - o New system requirements: - - Tor no longer attempts to support platforms where the "time_t" type - is unsigned. (To the best of our knowledge, only OpenVMS does this, - and Tor has never actually built on OpenVMS.) Closes ticket 18184. - diff --git a/changes/bug18204_028 b/changes/bug18204_028 deleted file mode 100644 index 3a1a116..0000000 --- a/changes/bug18204_028 +++ /dev/null @@ -1,3 +0,0 @@ - o Testing: - - Treat backtrace test failures as expected on FreeBSD until we - solve bug 17808. Closes ticket 18204. diff --git a/changes/bug18208 b/changes/bug18208 deleted file mode 100644 index a5e1cd6..0000000 --- a/changes/bug18208 +++ /dev/null @@ -1,5 +0,0 @@ - o Minor bugfixes (exit policies, security): - - Refresh an exit relay's exit policy when interface addresses change. - Previously, tor only refreshed the exit policy when the configured - external address changed. - Fixes bug 18208; bugfix on tor 0.2.7.3. Patch by "teor". diff --git a/changes/bug18221 b/changes/bug18221 deleted file mode 100644 index afc2404..0000000 --- a/changes/bug18221 +++ /dev/null @@ -1,3 +0,0 @@ - o Minor features (crypto): - - Validate the Diffie-Hellman hard coded parameters and ensure that - p is a safe prime, and g is suitable. Closes ticket 18221. diff --git a/changes/bug18242 b/changes/bug18242 deleted file mode 100644 index e91f6d5..0000000 --- a/changes/bug18242 +++ /dev/null @@ -1,6 +0,0 @@ - o Minor bugfixes (testing): - - We no longer disable assertions in the unit tests when coverage - is enabled. Instead, we require you to say --disable-asserts-in-tests - to the configure script if you need assertions disabled in the - unit tests (for example, if you want to perform branch coverage). - Fixes bug 18242; bugfix on 0.2.7.1-alpha. diff --git a/changes/bug18258 b/changes/bug18258 deleted file mode 100644 index 00e1224..0000000 --- a/changes/bug18258 +++ /dev/null @@ -1,12 +0,0 @@ - o Code simplification and refactoring: - - Remove specialized code for non-inplace AES_CTR. 99% of our AES - is inplace, so there's no need to have a separate implementation - for the non-inplace code. Closes ticket 18258. Patch from - Malek. - - o New requirements: - - Tor no longer supports versions of OpenSSL with a broken - implementation of counter mode. (This bug was present in OpenSSL - 1.0.0, and was fixed in OpenSSL 1.0.0a.) Tor still detects, but - no longer runs with, these versions. - diff --git a/changes/bug18259 b/changes/bug18259 deleted file mode 100644 index 1084b8f..0000000 --- a/changes/bug18259 +++ /dev/null @@ -1,4 +0,0 @@ - o Code simplification and refactoring: - - Simplify return types for some crypto functions that can't - actually fail. Patch from Hassan Alsibyani. Closes ticket - 18259. diff --git a/changes/bug18261 b/changes/bug18261 deleted file mode 100644 index df4c74f..0000000 --- a/changes/bug18261 +++ /dev/null @@ -1,6 +0,0 @@ - o Minor features (crypto): - - Fix a segfault during startup: If unix socket was configured as - listener (such as a ControlSocket or a SocksPort unix socket), and - tor was started as root but not configured to switch to another - user, tor would segfault while trying to string compare a NULL - value. Fixes bug 18261; bugfix on 0.2.8.1-alpha. Patch by weasel. diff --git a/changes/bug18296 b/changes/bug18296 deleted file mode 100644 index 1e98200..0000000 --- a/changes/bug18296 +++ /dev/null @@ -1,4 +0,0 @@ - o Minor bugfixes (containers): - - If we somehow attempt to construct a heap with more than - 1073741822 elements, avoid an integer overflow when maintaining - the heap property. Fixes bug 18296; bugfix on 0.1.2.1-alpha. diff --git a/changes/bug18348 b/changes/bug18348 deleted file mode 100644 index 44187ae..0000000 --- a/changes/bug18348 +++ /dev/null @@ -1,5 +0,0 @@ - o Major bugfixes (relays, bridge clients): - - Ensure relays always allow IPv4 OR and Dir connections. - Ensure bridge clients use the address configured in the bridge line. - Fixes bug 18348; bugfix on 0.2.8.1-alpha. - Reported by sysrqb, patch by teor. diff --git a/changes/bug18374 b/changes/bug18374 deleted file mode 100644 index 4764c53..0000000 --- a/changes/bug18374 +++ /dev/null @@ -1,3 +0,0 @@ - o Minor bugfixes (configuration): - - Fix a tiny memory leak when parsing a port configuration ending in - ":auto". Fixes bug 18374; bugfix on 0.2.3.3-alpha. diff --git a/changes/bug18384 b/changes/bug18384 deleted file mode 100644 index 78befca..0000000 --- a/changes/bug18384 +++ /dev/null @@ -1,5 +0,0 @@ - o Minor bugfixes (crypto, static analysis): - - Silence spurious clang-scan warnings in the ed25519_donna code - by explicitly initialising some objects. - Fixes bug 18384; bugfix on 0f3eeca9 in 0.2.7.2-alpha. - Patch by "teor". diff --git a/changes/bug18426_18459 b/changes/bug18426_18459 deleted file mode 100644 index 9059d6e..0000000 --- a/changes/bug18426_18459 +++ /dev/null @@ -1,4 +0,0 @@ - o Documentation: - - Change build messages to refer to "Fedora" instead of "Fedora Core", - and "dnf" instead of "yum". Closes tickets 18459 and 18426. - Patches from "icanhasaccount" and "cypherpunks". diff --git a/changes/bug18448 b/changes/bug18448 deleted file mode 100644 index e328ce3..0000000 --- a/changes/bug18448 +++ /dev/null @@ -1,6 +0,0 @@ - o Minor features (build): - - Detect systems with FreeBSD-derived kernels (such as GNU/kFreeBSD) as - having possible IPfW support. Closes ticket 18448. Patch from - Steven Chamberlain. - - diff --git a/changes/bug18454 b/changes/bug18454 deleted file mode 100644 index c573dae..0000000 --- a/changes/bug18454 +++ /dev/null @@ -1,8 +0,0 @@ - o Minor bugfixes (memory safety): - - Avoid freeing an uninitialised pointer when opening a socket fails - in get_interface_addresses_ioctl. - Fixes bug 18454; bugfix on 9f06ec0c in tor-0.2.3.11-alpha. - Reported by "toralf" and "cypherpunks", patch by "teor". - - Correctly duplicate addresses in get_interface_address6_list. - Fixes bug 18454; bugfix on 110765f5 in tor-0.2.8.1-alpha. - Reported by "toralf", patch by "cypherpunks". diff --git a/changes/bug18458 b/changes/bug18458 deleted file mode 100644 index ea0fa3f..0000000 --- a/changes/bug18458 +++ /dev/null @@ -1,9 +0,0 @@ - o Minor features (unix domain sockets): - - Since some operating systems do not consider the actual modes on a - UNIX domain socket itself, tor does not allow creating such a - socket in a directory that is group or world accessible if it is - supposed to be private. Likewise, it will not allow only group - accessible sockets in a world accessible directory. - However, on some operating systems this is unnecessary, so - add a per-socket option called RelaxDirModeCheck. - Closes ticket 18458. Patch by weasel. diff --git a/changes/bug18570 b/changes/bug18570 deleted file mode 100644 index 04f72f4..0000000 --- a/changes/bug18570 +++ /dev/null @@ -1,7 +0,0 @@ - o Minor bugfixes (correctness): - - Fix a bad memory handling bug that would occur if we had queued - a cell on a channel's incoming queue. Fortunately, we can't actually - queue a cell like that as our code is constructed today, but it's best - to avoid this kind of error, even if there isn't any code that triggers - it today. Fixes bug 18570; bugfix on 0.2.4.4-alpha. - diff --git a/changes/bug18600 b/changes/bug18600 deleted file mode 100644 index bf53bfe..0000000 --- a/changes/bug18600 +++ /dev/null @@ -1,3 +0,0 @@ - o Minor bugfixes (logging): - - Scrub service in from "unrecognized service ID" log messages. - Fixes bug 18600; bugfix on 0.2.4.11-alpha. diff --git a/changes/bug8976 b/changes/bug8976 deleted file mode 100644 index ff1c1a7..0000000 --- a/changes/bug8976 +++ /dev/null @@ -1,5 +0,0 @@ - o Minor bugfixes (security, hidden services): - - Prevent hidden services connecting to client-supplied rendezvous - addresses that are reserved as internal or multicast. - Fixes bug 8976; bugfix on b7c172c9e in tor-0.2.3.21. - Patch by "dgoulet" and "teor". diff --git a/changes/build18490 b/changes/build18490 deleted file mode 100644 index 466a133..0000000 --- a/changes/build18490 +++ /dev/null @@ -1,4 +0,0 @@ - o Minor bugfixes (build): - - Do not link the unit tests against both the testing and non-testing - versions of the static libraries. Fixes bug 18490; bugfix on - 0.2.7.1-alpha. diff --git a/changes/feature17840 b/changes/feature17840 deleted file mode 100644 index b8b3b7f..0000000 --- a/changes/feature17840 +++ /dev/null @@ -1,9 +0,0 @@ - o Minor feature (IPv6): - - Add ClientUseIPv4, which is set to 1 by default. If set to 0, tor - avoids using IPv4 for client OR and directory connections. - - Add ClientPreferIPv6DirPort, which is set to 0 by default. If set - to 1, tor prefers IPv6 directory addresses. - - Try harder to fulfil IP version restrictions ClientUseIPv4 0 and - ClientUseIPv6 0; and the preferences ClientPreferIPv6ORPort and - ClientPreferIPv6DirPort. - Closes ticket 17840; patch by "teor". diff --git a/changes/geoip-february2016 b/changes/geoip-february2016 deleted file mode 100644 index 49a8041..0000000 --- a/changes/geoip-february2016 +++ /dev/null @@ -1,4 +0,0 @@ - o Minor features: - - Update geoip and geoip6 to the February 2 2016 Maxmind GeoLite2 - Country database. - diff --git a/changes/geoip-march2016 b/changes/geoip-march2016 deleted file mode 100644 index a66599f..0000000 --- a/changes/geoip-march2016 +++ /dev/null @@ -1,4 +0,0 @@ - o Minor features (geoip): - - Update geoip and geoip6 to the March 3 2016 Maxmind GeoLite2 - Country database. - diff --git a/changes/remove_memarea_freelist b/changes/remove_memarea_freelist deleted file mode 100644 index 63b5c41..0000000 --- a/changes/remove_memarea_freelist +++ /dev/null @@ -1,4 +0,0 @@ - o Removed features: - - We no longer maintain an internal freelist in memarea.c. Allocators - should be good enough to make this code unnecessary, and it's doubtful - that it ever had any performance benefit. diff --git a/changes/test_asan b/changes/test_asan deleted file mode 100644 index ce0aa97..0000000 --- a/changes/test_asan +++ /dev/null @@ -1,3 +0,0 @@ - o Testing: - - Fix several warnings from clang's address sanitizer produced in the - unit tests. diff --git a/changes/ticket17744 b/changes/ticket17744 deleted file mode 100644 index 57a4a59..0000000 --- a/changes/ticket17744 +++ /dev/null @@ -1,4 +0,0 @@ - o Code simplification and refactoring: - - Quote all the string interpolations in configure.ac -- even - those which we are pretty sure can't contain spaces. Closes - ticket 17744. Patch from "zerosion". \ No newline at end of file diff --git a/changes/ticket18332 b/changes/ticket18332 deleted file mode 100644 index d19c617..0000000 --- a/changes/ticket18332 +++ /dev/null @@ -1,10 +0,0 @@ - o Removed features: - - Streamline relay-side hsdir handling: when relays consider whether - to accept an uploaded hidden service descriptor, they no longer - check whether they are one of the relays in the network that is - "supposed" to handle that descriptor. Implements ticket 18332. - - o Minor bugfixes: - - Bridges now refuse "rendezvous2" (hidden service descriptor) - publish attempts. Suggested by ticket 18332. - diff --git a/changes/trunnel_update b/changes/trunnel_update deleted file mode 100644 index dd9c26c..0000000 --- a/changes/trunnel_update +++ /dev/null @@ -1,5 +0,0 @@ - o Minor bugfixes (code correctness): - - Update to the latest version of Trunnel, which tries harder - to avoid generating code that can invoke memcpy(p,NULL,0). - Bug found by clang address sanitizer. Fixes bug 18373; bugfix - on 0.2.7.2-alpha.

1 0

[tor/master] Run "formatChangelog"
by nickm＠torproject.org 21 Mar '16

21 Mar '16

commit 34d429f243658f5a7ac3dc8dafa454d75b02e67d Author: Nick Mathewson <nickm(a)torproject.org> Date: Mon Mar 21 11:18:45 2016 -0400 Run "formatChangelog" --- ChangeLog | 258 +++++++++++++++++++++++++++++++------------------------------- 1 file changed, 127 insertions(+), 131 deletions(-) diff --git a/ChangeLog b/ChangeLog index f6cd2b4..bc7f105 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,28 +1,16 @@ Changes in version 0.2.8.2-rc - 2016-03-?? - Tor 0.2.8.1-alpha is the first release candidate in its series. - XXXX write more here XXXX + Tor 0.2.8.1-alpha is the first release candidate in its series. XXXX + write more here XXXX o New system requirements: - Tor no longer supports versions of OpenSSL with a broken - implementation of counter mode. (This bug was present in OpenSSL - 1.0.0, and was fixed in OpenSSL 1.0.0a.) Tor still detects, but - no longer runs with, these versions. - - Tor no longer attempts to support platforms where the "time_t" type - is unsigned. (To the best of our knowledge, only OpenVMS does this, - and Tor has never actually built on OpenVMS.) Closes ticket 18184. - - o Removed features: - - Streamline relay-side hsdir handling: when relays consider whether - to accept an uploaded hidden service descriptor, they no longer - check whether they are one of the relays in the network that is - "supposed" to handle that descriptor. Implements ticket 18332. - - We no longer maintain an internal freelist in memarea.c. Allocators - should be good enough to make this code unnecessary, and it's doubtful - that it ever had any performance benefit. - - o Major bugfixes (dns proxy mode, crash): - - Avoid crashing when running as a DNS proxy. Fixes bug 16248; bugfix on - 0.2.0.1-alpha. Patch from 'cypherpunks'. + implementation of counter mode. (This bug was present in OpenSSL + 1.0.0, and was fixed in OpenSSL 1.0.0a.) Tor still detects, but no + longer runs with, these versions. + - Tor no longer attempts to support platforms where the "time_t" + type is unsigned. (To the best of our knowledge, only OpenVMS does + this, and Tor has never actually built on OpenVMS.) Closes + ticket 18184. o Major bugfixes (security, pointers): - Avoid a difficult-to-trigger heap corruption attack when extending @@ -31,20 +19,28 @@ Changes in version 0.2.8.2-rc - 2016-03-?? incompletely. Reported by Guido Vranken. o Major bugfixes (compilation): - - Repair hardened builds under the clang compiler. Previously, - our use of _FORTIFY_SOURCE would conflict with clang's address + - Repair hardened builds under the clang compiler. Previously, our + use of _FORTIFY_SOURCE would conflict with clang's address sanitizer. Fixes bug 14821; bugfix on 0.2.5.4-alpha. o Major bugfixes (crash on shutdown): - Correctly handle detaching circuits from cmuxes when doing - circuit_free_all() on shutdown. Fixes bug 18116; bugfix on - 0.2.8.1-alpha. + circuit_free_all() on shutdown. Fixes bug 18116; bugfix + on 0.2.8.1-alpha. + + o Major bugfixes (dns proxy mode, crash): + - Avoid crashing when running as a DNS proxy. Fixes bug 16248; + bugfix on 0.2.0.1-alpha. Patch from 'cypherpunks'. o Major bugfixes (relays, bridge clients): - - Ensure relays always allow IPv4 OR and Dir connections. - Ensure bridge clients use the address configured in the bridge line. - Fixes bug 18348; bugfix on 0.2.8.1-alpha. - Reported by sysrqb, patch by teor. + - Ensure relays always allow IPv4 OR and Dir connections. Ensure + bridge clients use the address configured in the bridge line. + Fixes bug 18348; bugfix on 0.2.8.1-alpha. Reported by sysrqb, + patch by teor. + + o Minor features: + - Update geoip and geoip6 to the February 2 2016 Maxmind GeoLite2 + Country database. o Minor feature (IPv6): - Add ClientPreferIPv6DirPort, which is set to 0 by default. If set @@ -53,22 +49,21 @@ Changes in version 0.2.8.2-rc - 2016-03-?? avoids using IPv4 for client OR and directory connections. - Try harder to fulfil IP version restrictions ClientUseIPv4 0 and ClientUseIPv6 0; and the preferences ClientPreferIPv6ORPort and - ClientPreferIPv6DirPort. - Closes ticket 17840; patch by "teor". + ClientPreferIPv6DirPort. Closes ticket 17840; patch by "teor". o Minor features (bug-resistance): - - Make Tor survive errors involving connections without a corresponding - event object. Previously we'd fail with an assertion; now we produce a - log message. Related to bug 16248. + - Make Tor survive errors involving connections without a + corresponding event object. Previously we'd fail with an + assertion; now we produce a log message. Related to bug 16248. o Minor features (build): - - Detect systems with FreeBSD-derived kernels (such as GNU/kFreeBSD) as - having possible IPfW support. Closes ticket 18448. Patch from + - Detect systems with FreeBSD-derived kernels (such as GNU/kFreeBSD) + as having possible IPfW support. Closes ticket 18448. Patch from Steven Chamberlain. o Minor features (code hardening): - - Use tor_snprintf() and tor_vsnprintf() even in external and - low-level code, to harden against accidental failures to NUL- + - Use tor_snprintf() and tor_vsnprintf() even in external and low- + level code, to harden against accidental failures to NUL- terminate. Part of ticket 17852. Patch from 'jsturgix'. Found with Flawfinder. @@ -77,11 +72,11 @@ Changes in version 0.2.8.2-rc - 2016-03-?? appropriate locations. Closes ticket 17732. o Minor features (crypto): - - Fix a segfault during startup: If unix socket was configured as + - Fix a segfault during startup: If unix socket was configured as listener (such as a ControlSocket or a SocksPort unix socket), and tor was started as root but not configured to switch to another user, tor would segfault while trying to string compare a NULL - value. Fixes bug 18261; bugfix on 0.2.8.1-alpha. Patch by weasel. + value. Fixes bug 18261; bugfix on 0.2.8.1-alpha. Patch by weasel. - Validate the Diffie-Hellman hard coded parameters and ensure that p is a safe prime, and g is suitable. Closes ticket 18221. @@ -90,41 +85,57 @@ Changes in version 0.2.8.2-rc - 2016-03-?? Country database. o Minor features (robustness): - - Exit immediately with an error message if the code attempts to - use libevent without having initialized it. This should resolve - some frequently-made mistakes in our unit tests. Closes ticket - 18241. + - Exit immediately with an error message if the code attempts to use + libevent without having initialized it. This should resolve some + frequently-made mistakes in our unit tests. Closes ticket 18241. o Minor features (unix domain sockets): - Since some operating systems do not consider the actual modes on a UNIX domain socket itself, tor does not allow creating such a socket in a directory that is group or world accessible if it is - supposed to be private. Likewise, it will not allow only group - accessible sockets in a world accessible directory. - However, on some operating systems this is unnecessary, so - add a per-socket option called RelaxDirModeCheck. - Closes ticket 18458. Patch by weasel. + supposed to be private. Likewise, it will not allow only group + accessible sockets in a world accessible directory. However, on + some operating systems this is unnecessary, so add a per-socket + option called RelaxDirModeCheck. Closes ticket 18458. Patch + by weasel. - o Minor features: - - Update geoip and geoip6 to the February 2 2016 Maxmind GeoLite2 - Country database. + o Minor bugfixes (exit policies, security): + - Refresh an exit relay's exit policy when interface addresses + change. Previously, tor only refreshed the exit policy when the + configured external address changed. Fixes bug 18208; bugfix on + tor 0.2.7.3. Patch by "teor". + + o Minor bugfixes (security, hidden services): + - Prevent hidden services connecting to client-supplied rendezvous + addresses that are reserved as internal or multicast. Fixes bug + 8976; bugfix on b7c172c9e in tor-0.2.3.21. Patch by "dgoulet" + and "teor". + + o Minor bugfixes (security, win32): + - Set SO_EXCLUSIVEADDRUSE on Win32 to avoid a local port-stealing + attack. Fixes bug 18123; bugfix on all tor versions. Patch + by "teor". + + o Minor bugfixes: + - Bridges now refuse "rendezvous2" (hidden service descriptor) + publish attempts. Suggested by ticket 18332. o Minor bugfixes (build): - - Do not link the unit tests against both the testing and non-testing - versions of the static libraries. Fixes bug 18490; bugfix on - 0.2.7.1-alpha. + - Do not link the unit tests against both the testing and non- + testing versions of the static libraries. Fixes bug 18490; bugfix + on 0.2.7.1-alpha. o Minor bugfixes (client): - Count receipt of new microdescriptors as progress towards bootstrapping. Now, when a user who has set EntryNodes finishes bootstrapping, Tor automatically repopulates the guard set based - on this new directory information. Fixes bug 16825; bugfix on - 0.2.3.1-alpha. + on this new directory information. Fixes bug 16825; bugfix + on 0.2.3.1-alpha. o Minor bugfixes (code correctness): - - Update to the latest version of Trunnel, which tries harder - to avoid generating code that can invoke memcpy(p,NULL,0). - Bug found by clang address sanitizer. Fixes bug 18373; bugfix + - Update to the latest version of Trunnel, which tries harder to + avoid generating code that can invoke memcpy(p,NULL,0). Bug found + by clang address sanitizer. Fixes bug 18373; bugfix on 0.2.7.2-alpha. o Minor bugfixes (configuration): @@ -134,44 +145,37 @@ Changes in version 0.2.8.2-rc - 2016-03-?? o Minor bugfixes (containers): - If we somehow attempt to construct a heap with more than 1073741822 elements, avoid an integer overflow when maintaining - the heap property. Fixes bug 18296; bugfix on 0.1.2.1-alpha. + the heap property. Fixes bug 18296; bugfix on 0.1.2.1-alpha. o Minor bugfixes (correctness): - - Fix a bad memory handling bug that would occur if we had queued - a cell on a channel's incoming queue. Fortunately, we can't actually - queue a cell like that as our code is constructed today, but it's best - to avoid this kind of error, even if there isn't any code that triggers - it today. Fixes bug 18570; bugfix on 0.2.4.4-alpha. + - Fix a bad memory handling bug that would occur if we had queued a + cell on a channel's incoming queue. Fortunately, we can't actually + queue a cell like that as our code is constructed today, but it's + best to avoid this kind of error, even if there isn't any code + that triggers it today. Fixes bug 18570; bugfix on 0.2.4.4-alpha. o Minor bugfixes (crypto, static analysis): - - Silence spurious clang-scan warnings in the ed25519_donna code - by explicitly initialising some objects. - Fixes bug 18384; bugfix on 0f3eeca9 in 0.2.7.2-alpha. - Patch by "teor". + - Silence spurious clang-scan warnings in the ed25519_donna code by + explicitly initialising some objects. Fixes bug 18384; bugfix on + 0f3eeca9 in 0.2.7.2-alpha. Patch by "teor". o Minor bugfixes (directory): - When generating a URL for a directory server on an IPv6 address, - wrap the IPv6 address in square brackets. Fixes bug 18051; - bugfix on 0.2.3.9-alpha. Patch from Malek. - - o Minor bugfixes (exit policies, security): - - Refresh an exit relay's exit policy when interface addresses change. - Previously, tor only refreshed the exit policy when the configured - external address changed. - Fixes bug 18208; bugfix on tor 0.2.7.3. Patch by "teor". + wrap the IPv6 address in square brackets. Fixes bug 18051; bugfix + on 0.2.3.9-alpha. Patch from Malek. o Minor bugfixes (hidden service client): - Seven very fast consecutive requests to the same .onion address triggers 7 descriptor fetches. The first six each pick a directory (there are 6 overall) and the seventh one wasn't able to pick one - which was triggering a close on all current directory connections. It - has been fixed by not closing them if we have pending directory fetch. - Fixes bug 15937; bugfix on tor-0.2.7.1-alpha. + which was triggering a close on all current directory connections. + It has been fixed by not closing them if we have pending directory + fetch. Fixes bug 15937; bugfix on tor-0.2.7.1-alpha. o Minor bugfixes (hidden service, control port): - Add the onion address to the HS_DESC event for the UPLOADED action - both on success or failure. It was previously hardcoded with UNKNOWN. - Fixes bug 16023; bugfix on 0.2.7.2-alpha. + both on success or failure. It was previously hardcoded with + UNKNOWN. Fixes bug 16023; bugfix on 0.2.7.2-alpha. o Minor bugfixes (logging): - Scrub service in from "unrecognized service ID" log messages. @@ -179,77 +183,69 @@ Changes in version 0.2.8.2-rc - 2016-03-?? o Minor bugfixes (memory safety): - Avoid freeing an uninitialised pointer when opening a socket fails - in get_interface_addresses_ioctl. - Fixes bug 18454; bugfix on 9f06ec0c in tor-0.2.3.11-alpha. - Reported by "toralf" and "cypherpunks", patch by "teor". + in get_interface_addresses_ioctl. Fixes bug 18454; bugfix on + 9f06ec0c in tor-0.2.3.11-alpha. Reported by "toralf" and + "cypherpunks", patch by "teor". - Correctly duplicate addresses in get_interface_address6_list. - Fixes bug 18454; bugfix on 110765f5 in tor-0.2.8.1-alpha. - Reported by "toralf", patch by "cypherpunks". + Fixes bug 18454; bugfix on 110765f5 in tor-0.2.8.1-alpha. Reported + by "toralf", patch by "cypherpunks". o Minor bugfixes (private directory): - - Prevent a race condition when creating private directories. - Fixes part of bug 17852; bugfix on 0.2pre13. Part of ticket - 17852. Patch from 'jsturgix'. Found with Flawfinder. + - Prevent a race condition when creating private directories. Fixes + part of bug 17852; bugfix on 0.2pre13. Part of ticket 17852. Patch + from 'jsturgix'. Found with Flawfinder. o Minor bugfixes (sandbox): - - Allow the setrlimit syscall, and the prlimit and prlimit64 syscalls, - which some libc implementations - use under the hood. Fixes bug 15221; bugfix on 0.2.5.1-alpha. - - o Minor bugfixes (security, hidden services): - - Prevent hidden services connecting to client-supplied rendezvous - addresses that are reserved as internal or multicast. - Fixes bug 8976; bugfix on b7c172c9e in tor-0.2.3.21. - Patch by "dgoulet" and "teor". - - o Minor bugfixes (security, win32): - - Set SO_EXCLUSIVEADDRUSE on Win32 to avoid a local port-stealing - attack. - Fixes bug 18123; bugfix on all tor versions. Patch by "teor". + - Allow the setrlimit syscall, and the prlimit and prlimit64 + syscalls, which some libc implementations use under the hood. + Fixes bug 15221; bugfix on 0.2.5.1-alpha. o Minor bugfixes (test networks, IPv6): - Allow internal IPv6 addresses in descriptors in test networks. - Fixes bug 17153; bugfix on 6b4af1071 in 0.2.3.16-alpha. - Patch by "teor", reported by "karsten". + Fixes bug 17153; bugfix on 6b4af1071 in 0.2.3.16-alpha. Patch by + "teor", reported by "karsten". o Minor bugfixes (testing): - - We no longer disable assertions in the unit tests when coverage - is enabled. Instead, we require you to say --disable-asserts-in-tests + - We no longer disable assertions in the unit tests when coverage is + enabled. Instead, we require you to say --disable-asserts-in-tests to the configure script if you need assertions disabled in the unit tests (for example, if you want to perform branch coverage). Fixes bug 18242; bugfix on 0.2.7.1-alpha. - o Minor bugfixes: - - Bridges now refuse "rendezvous2" (hidden service descriptor) - publish attempts. Suggested by ticket 18332. - o Code simplification and refactoring: - - Quote all the string interpolations in configure.ac -- even - those which we are pretty sure can't contain spaces. Closes - ticket 17744. Patch from "zerosion". - - Remove specialized code for non-inplace AES_CTR. 99% of our AES - is inplace, so there's no need to have a separate implementation - for the non-inplace code. Closes ticket 18258. Patch from - Malek. + - Quote all the string interpolations in configure.ac -- even those + which we are pretty sure can't contain spaces. Closes ticket + 17744. Patch from "zerosion". + - Remove specialized code for non-inplace AES_CTR. 99% of our AES is + inplace, so there's no need to have a separate implementation for + the non-inplace code. Closes ticket 18258. Patch from Malek. - Simplify return types for some crypto functions that can't - actually fail. Patch from Hassan Alsibyani. Closes ticket - 18259. + actually fail. Patch from Hassan Alsibyani. Closes ticket 18259. o Dependency updates: - - Tor now uses Autoconf version 2.63 or later, and Automake 1.11 or later - (released in 2008 and 2009 respectively). If you are building Tor from - the git repository instead of from the source distribution, and your - tools are older than this, you will need to upgrade. - Closes ticket 17732. + - Tor now uses Autoconf version 2.63 or later, and Automake 1.11 or + later (released in 2008 and 2009 respectively). If you are + building Tor from the git repository instead of from the source + distribution, and your tools are older than this, you will need to + upgrade. Closes ticket 17732. o Documentation: - - Change build messages to refer to "Fedora" instead of "Fedora Core", - and "dnf" instead of "yum". Closes tickets 18459 and 18426. + - Change build messages to refer to "Fedora" instead of "Fedora + Core", and "dnf" instead of "yum". Closes tickets 18459 and 18426. Patches from "icanhasaccount" and "cypherpunks". + o Removed features: + - Streamline relay-side hsdir handling: when relays consider whether + to accept an uploaded hidden service descriptor, they no longer + check whether they are one of the relays in the network that is + "supposed" to handle that descriptor. Implements ticket 18332. + - We no longer maintain an internal freelist in memarea.c. + Allocators should be good enough to make this code unnecessary, + and it's doubtful that it ever had any performance benefit. + o Testing: - - Fix several warnings from clang's address sanitizer produced in the - unit tests. + - Fix several warnings from clang's address sanitizer produced in + the unit tests. - Treat backtrace test failures as expected on FreeBSD until we solve bug 17808. Closes ticket 18204.

1 0

[tor/master] Fix (most) lintChanges warnings on master.
by nickm＠torproject.org 21 Mar '16

21 Mar '16

commit 52bc92140287852f8f7fbb3ca4ba233ab229ff4f Author: Nick Mathewson <nickm(a)torproject.org> Date: Mon Mar 21 11:14:57 2016 -0400 Fix (most) lintChanges warnings on master. --- changes/bug15221 | 2 +- changes/bug15937 | 4 ++-- changes/bug16023 | 4 ++-- changes/bug16248 | 2 +- changes/bug16825 | 2 +- changes/bug18051 | 5 +++-- changes/bug18116 | 5 +++-- changes/bug18184 | 2 +- changes/bug18208 | 4 ++-- changes/bug18348 | 2 +- changes/bug18458 | 4 ++-- changes/remove_memarea_freelist | 2 +- changes/trunnel_update | 2 +- scripts/maint/lintChanges.py | 1 + 14 files changed, 22 insertions(+), 19 deletions(-) diff --git a/changes/bug15221 b/changes/bug15221 index ed72309..d466e1d 100644 --- a/changes/bug15221 +++ b/changes/bug15221 @@ -1,4 +1,4 @@ o Minor bugfixes (sandbox): - Allow the setrlimit syscall, and the prlimit and prlimit64 syscalls, which some libc implementations - use under the hood. Fixes bug 15221. Bugfix on 0.2.5.1-alpha. + use under the hood. Fixes bug 15221; bugfix on 0.2.5.1-alpha. diff --git a/changes/bug15937 b/changes/bug15937 index 6c73fa4..88adbe4 100644 --- a/changes/bug15937 +++ b/changes/bug15937 @@ -1,7 +1,7 @@ - o Minor bug fix (hidden service client): + o Minor bugfixes (hidden service client): - Seven very fast consecutive requests to the same .onion address triggers 7 descriptor fetches. The first six each pick a directory (there are 6 overall) and the seventh one wasn't able to pick one which was triggering a close on all current directory connections. It has been fixed by not closing them if we have pending directory fetch. - Fixes #15937; Bugfix on tor-0.2.7.1-alpha. + Fixes bug 15937; bugfix on tor-0.2.7.1-alpha. diff --git a/changes/bug16023 b/changes/bug16023 index 7451e27..96c0904 100644 --- a/changes/bug16023 +++ b/changes/bug16023 @@ -1,4 +1,4 @@ - o Minor feature (hidden service, control port) + o Minor bugfixes (hidden service, control port): - Add the onion address to the HS_DESC event for the UPLOADED action both on success or failure. It was previously hardcoded with UNKNOWN. - Fixes #16023; + Fixes bug 16023; bugfix on 0.2.7.2-alpha. diff --git a/changes/bug16248 b/changes/bug16248 index 399b709..a07eba9 100644 --- a/changes/bug16248 +++ b/changes/bug16248 @@ -1,5 +1,5 @@ o Major bugfixes (dns proxy mode, crash): - - Avoid crashing when running as a DNS proxy. Closes bug 16248; bugfix on + - Avoid crashing when running as a DNS proxy. Fixes bug 16248; bugfix on 0.2.0.1-alpha. Patch from 'cypherpunks'. o Minor features (bug-resistance): diff --git a/changes/bug16825 b/changes/bug16825 index 75c5627..ab0879a 100644 --- a/changes/bug16825 +++ b/changes/bug16825 @@ -1,4 +1,4 @@ - o Minor bugfixes: + o Minor bugfixes (client): - Count receipt of new microdescriptors as progress towards bootstrapping. Now, when a user who has set EntryNodes finishes bootstrapping, Tor automatically repopulates the guard set based diff --git a/changes/bug18051 b/changes/bug18051 index 1b11867..0dd32f0 100644 --- a/changes/bug18051 +++ b/changes/bug18051 @@ -1,4 +1,5 @@ - o Minor bugfixes: + o Minor bugfixes (directory): - When generating a URL for a directory server on an IPv6 address, wrap the IPv6 address in square brackets. Fixes bug 18051; - bugfix on ?. Patch from Malek. + bugfix on 0.2.3.9-alpha. Patch from Malek. + diff --git a/changes/bug18116 b/changes/bug18116 index 23ff8f7..bcb96e8 100644 --- a/changes/bug18116 +++ b/changes/bug18116 @@ -1,3 +1,4 @@ - o Major bugfixes: + o Major bugfixes (crash on shutdown): - Correctly handle detaching circuits from cmuxes when doing - circuit_free_all() on shutdown again; fixes bug #18116. + circuit_free_all() on shutdown. Fixes bug 18116; bugfix on + 0.2.8.1-alpha. diff --git a/changes/bug18184 b/changes/bug18184 index af493df..01b97d4 100644 --- a/changes/bug18184 +++ b/changes/bug18184 @@ -1,4 +1,4 @@ - o Removed platform support: + o New system requirements: - Tor no longer attempts to support platforms where the "time_t" type is unsigned. (To the best of our knowledge, only OpenVMS does this, and Tor has never actually built on OpenVMS.) Closes ticket 18184. diff --git a/changes/bug18208 b/changes/bug18208 index d6d194b..a5e1cd6 100644 --- a/changes/bug18208 +++ b/changes/bug18208 @@ -1,5 +1,5 @@ - o Minor bug fixes (exit policies, security): + o Minor bugfixes (exit policies, security): - Refresh an exit relay's exit policy when interface addresses change. Previously, tor only refreshed the exit policy when the configured external address changed. - Closes ticket 18208 on tor 0.2.7.3. Patch by "teor". + Fixes bug 18208; bugfix on tor 0.2.7.3. Patch by "teor". diff --git a/changes/bug18348 b/changes/bug18348 index 03978ed..44187ae 100644 --- a/changes/bug18348 +++ b/changes/bug18348 @@ -1,4 +1,4 @@ - o Major bug fixes (relays, bridge clients): + o Major bugfixes (relays, bridge clients): - Ensure relays always allow IPv4 OR and Dir connections. Ensure bridge clients use the address configured in the bridge line. Fixes bug 18348; bugfix on 0.2.8.1-alpha. diff --git a/changes/bug18458 b/changes/bug18458 index 59646ef..ea0fa3f 100644 --- a/changes/bug18458 +++ b/changes/bug18458 @@ -1,4 +1,4 @@ - o Minor features: + o Minor features (unix domain sockets): - Since some operating systems do not consider the actual modes on a UNIX domain socket itself, tor does not allow creating such a socket in a directory that is group or world accessible if it is @@ -6,4 +6,4 @@ accessible sockets in a world accessible directory. However, on some operating systems this is unnecessary, so add a per-socket option called RelaxDirModeCheck. - Fixes bug 18458. Patch by weasel. + Closes ticket 18458. Patch by weasel. diff --git a/changes/remove_memarea_freelist b/changes/remove_memarea_freelist index dd9520c..63b5c41 100644 --- a/changes/remove_memarea_freelist +++ b/changes/remove_memarea_freelist @@ -1,4 +1,4 @@ - o Removed code: + o Removed features: - We no longer maintain an internal freelist in memarea.c. Allocators should be good enough to make this code unnecessary, and it's doubtful that it ever had any performance benefit. diff --git a/changes/trunnel_update b/changes/trunnel_update index 4f8c185..dd9c26c 100644 --- a/changes/trunnel_update +++ b/changes/trunnel_update @@ -1,5 +1,5 @@ o Minor bugfixes (code correctness): - Update to the latest version of Trunnel, which tries harder to avoid generating code that can invoke memcpy(p,NULL,0). - Bug found by clang address sanitizer. Fixes bug 18373. Bugfix + Bug found by clang address sanitizer. Fixes bug 18373; bugfix on 0.2.7.2-alpha. diff --git a/scripts/maint/lintChanges.py b/scripts/maint/lintChanges.py index a73110d..48edd06 100755 --- a/scripts/maint/lintChanges.py +++ b/scripts/maint/lintChanges.py @@ -16,6 +16,7 @@ KNOWN_GROUPS=set([ "Minor features", "Major feature", "Major features", + "New system requirements", "Testing", "Documentation", "Code simplification and refactoring",

1 0

[tor/maint-0.2.7] Fix some warnings from lintchanges.
by nickm＠torproject.org 21 Mar '16

21 Mar '16

commit ee08f224893ecb4ef56b2c1d58d15621cb4386e7 Author: Nick Mathewson <nickm(a)torproject.org> Date: Mon Mar 21 10:58:29 2016 -0400 Fix some warnings from lintchanges. --- changes/bug14821 | 2 +- changes/bug17906 | 4 ++-- changes/bug17923 | 2 +- changes/bug18050 | 6 +++--- changes/bug18089 | 6 ++---- changes/bug18162 | 2 +- changes/geoip-march2016 | 2 +- 7 files changed, 11 insertions(+), 13 deletions(-) diff --git a/changes/bug14821 b/changes/bug14821 index 0920d1f..e017eff 100644 --- a/changes/bug14821 +++ b/changes/bug14821 @@ -1,4 +1,4 @@ o Major bugfixes (compilation): - Correctly repair hardened builds under the clang compiler. Previously, our use of _FORTIFY_SOURCE would conflict with clang's address - sanitizer. Closes ticket 14821. + sanitizer. Fixes bug 14821; bugfix on 0.2.5.4-alpha. diff --git a/changes/bug17906 b/changes/bug17906 index fff76d1..4b97740 100644 --- a/changes/bug17906 +++ b/changes/bug17906 @@ -1,4 +1,4 @@ o Minor features (authorities): - - Update the V3 identity key for dannenberg, it was changed on + - Update the V3 identity key for the dannenberg authority, which changed on 18 November 2015. - Closes task #17906. Patch by "teor". + Closes task 17906. Patch by "teor". diff --git a/changes/bug17923 b/changes/bug17923 index 48026a5..94849fb 100644 --- a/changes/bug17923 +++ b/changes/bug17923 @@ -1,4 +1,4 @@ - o Minor bugfixes: + o Minor bugfixes (portability): - Add an #endif to configure.ac so that we correctly detect the presence of in6_addr.s6_addr32. Fixes bug 17923; bugfix on 0.2.0.13-alpha. diff --git a/changes/bug18050 b/changes/bug18050 index ce24a77..27456be 100644 --- a/changes/bug18050 +++ b/changes/bug18050 @@ -1,7 +1,7 @@ - o Minor fixes (relays): + o Minor bugfixes (relays): - Check that both the ORPort and DirPort (if present) are reachable before publishing a relay descriptor. Otherwise, relays publish a descriptor with DirPort 0 when the DirPort reachability test takes longer than the ORPort reachability test. - Closes bug #18050. Reported by "starlight", patch by "teor". - Bugfix on 0.1.0.1-rc, commit a1f1fa6ab on 27 Feb 2005. + Fixes bug 18050; + bugfix on 0.1.0.1-rc. Reported by "starlight", patch by "teor". diff --git a/changes/bug18089 b/changes/bug18089 index c1fb342..8ff75b8 100644 --- a/changes/bug18089 +++ b/changes/bug18089 @@ -1,6 +1,4 @@ - o Minor fixes (security): + o Minor bugfixes (security): - Make memwipe() do nothing when passed a NULL pointer or zero size. Check size argument to memwipe() for underflow. - Closes bug #18089. Reported by "gk", patch by "teor". - Bugfix on 0.2.3.25 and 0.2.4.6-alpha (#7352), - commit 49dd5ef3 on 7 Nov 2012. + Fixes bug 18089; bugfix on 0.2.3.25 and 0.2.4.6-alpha. Reported by "gk", patch by "teor". diff --git a/changes/bug18162 b/changes/bug18162 index 0844d6f..88d19a8 100644 --- a/changes/bug18162 +++ b/changes/bug18162 @@ -1,7 +1,7 @@ o Major bugfixes (security, pointers): - Avoid a difficult-to-trigger heap corruption attack when extending - a smartlist to contain over 16GB of pointers. Fixes bug #18162; + a smartlist to contain over 16GB of pointers. Fixes bug 18162; bugfix on Tor 0.1.1.11-alpha, which fixed a related bug incompletely. Reported by Guido Vranken. diff --git a/changes/geoip-march2016 b/changes/geoip-march2016 index d7b1bd4..a66599f 100644 --- a/changes/geoip-march2016 +++ b/changes/geoip-march2016 @@ -1,4 +1,4 @@ - o Minor features: + o Minor features (geoip): - Update geoip and geoip6 to the March 3 2016 Maxmind GeoLite2 Country database.

1 0

[tor/maint-0.2.7] a couple more changes files issues.
by nickm＠torproject.org 21 Mar '16

21 Mar '16

commit 920e3d6a191486a5879aa0f2e0bfcf743d075c12 Author: Nick Mathewson <nickm(a)torproject.org> Date: Mon Mar 21 11:00:50 2016 -0400 a couple more changes files issues. --- changes/bug14821 | 2 +- changes/bug17906 | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/changes/bug14821 b/changes/bug14821 index e017eff..e9ccc2f 100644 --- a/changes/bug14821 +++ b/changes/bug14821 @@ -1,4 +1,4 @@ o Major bugfixes (compilation): - - Correctly repair hardened builds under the clang compiler. Previously, + - Repair hardened builds under the clang compiler. Previously, our use of _FORTIFY_SOURCE would conflict with clang's address sanitizer. Fixes bug 14821; bugfix on 0.2.5.4-alpha. diff --git a/changes/bug17906 b/changes/bug17906 index 4b97740..2937369 100644 --- a/changes/bug17906 +++ b/changes/bug17906 @@ -1,4 +1,4 @@ - o Minor features (authorities): + o Major features (authorities): - Update the V3 identity key for the dannenberg authority, which changed on 18 November 2015. Closes task 17906. Patch by "teor".

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

tor-commits March 2016