November 2015 - tor-commits - lists.torproject.org

[tor/master] every version of openssl we support has SSL_get_state
by nickm＠torproject.org 10 Nov '15

10 Nov '15

commit 39e8fa81f7e42b6bff10e48109bee9409870d38d Author: Nick Mathewson <nickm(a)torproject.org> Date: Tue Nov 10 10:14:58 2015 -0500 every version of openssl we support has SSL_get_state --- src/common/compat_openssl.h | 3 --- 1 file changed, 3 deletions(-) diff --git a/src/common/compat_openssl.h b/src/common/compat_openssl.h index 23f6950..5d5941a 100644 --- a/src/common/compat_openssl.h +++ b/src/common/compat_openssl.h @@ -24,9 +24,6 @@ #define OpenSSL_version(v) SSLeay_version(v) #define OpenSSL_version_num() SSLeay() #define RAND_OpenSSL() RAND_SSLeay() -#ifndef SSL_get_state -#define SSL_get_state(ssl) SSL_state(ssl) -#endif #define STATE_IS_SW_SERVER_HELLO(st) \ (((st) == SSL3_ST_SW_SRVR_HELLO_A) || \ ((st) == SSL3_ST_SW_SRVR_HELLO_B))

1 0

[tor/master] appease check-spaces
by nickm＠torproject.org 10 Nov '15

10 Nov '15

commit 05c34b3330349bbb1311e2366e7593993f1de6d7 Author: Nick Mathewson <nickm(a)torproject.org> Date: Tue Nov 10 10:40:19 2015 -0500 appease check-spaces --- src/common/compat_openssl.h | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/common/compat_openssl.h b/src/common/compat_openssl.h index 5d5941a..3fcd684 100644 --- a/src/common/compat_openssl.h +++ b/src/common/compat_openssl.h @@ -7,7 +7,7 @@ #ifndef TOR_COMPAT_OPENSSL_H #define TOR_COMPAT_OPENSSL_H -#include <openssl/opensslv.h> +#include <openssl/opensslv.h> /** * \file compat_openssl.h @@ -34,3 +34,4 @@ #endif #endif +

1 0

[tor/master] Merge branch 'bug17549'
by nickm＠torproject.org 10 Nov '15

10 Nov '15

commit 0a3eed5f204dc9759e5001c7cf2bb448015d6891 Merge: 0d5a439 05c34b3 Author: Nick Mathewson <nickm(a)torproject.org> Date: Tue Nov 10 10:40:31 2015 -0500 Merge branch 'bug17549' changes/bug17549 | 3 +++ src/common/compat_openssl.h | 37 +++++++++++++++++++++++++++++++++++++ src/common/crypto.c | 33 ++++++++++++--------------------- src/common/include.am | 1 + src/common/tortls.c | 21 ++++++++++----------- src/common/tortls.h | 1 + src/test/test_tortls.c | 24 +++++++++++++----------- 7 files changed, 77 insertions(+), 43 deletions(-) diff --cc src/test/test_tortls.c index fd3d50c,90bf0d3..dceecf4 --- a/src/test/test_tortls.c +++ b/src/test/test_tortls.c @@@ -53,9 -53,11 +53,12 @@@ extern tor_tls_context_t *server_tls_context; extern tor_tls_context_t *client_tls_context; -#if OPENSSL_VERSION_NUMBER >= OPENSSL_V_SERIES(1,1,0) +#if OPENSSL_VERSION_NUMBER >= OPENSSL_V_SERIES(1,1,0) \ + && !defined(LIBRESSL_VERSION_NUMBER) #define OPENSSL_OPAQUE + #define SSL_STATE_STR "before SSL initialization" + #else + #define SSL_STATE_STR "before/accept initialization" #endif #ifndef OPENSSL_OPAQUE

1 0

[tor/release-0.2.7] start trying to write a blurb
by nickm＠torproject.org 10 Nov '15

10 Nov '15

commit 4dd7a55cf22caa56ef53609e2545002733803a56 Author: Nick Mathewson <nickm(a)torproject.org> Date: Tue Nov 10 09:13:58 2015 -0500 start trying to write a blurb --- ReleaseNotes | 13 +++++++++++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/ReleaseNotes b/ReleaseNotes index 029dd61..ef173af 100644 --- a/ReleaseNotes +++ b/ReleaseNotes @@ -3,8 +3,17 @@ This document summarizes new features and bugfixes in each stable release of Tor. If you want to see more detailed descriptions of the changes in each development snapshot, see the ChangeLog file. -Changes in version 0.2.7.5- 2015-11-?? - XXXX WRITE A BLURB XXXX +Changes in version 0.2.7.5 - 2015-11-1? + Tor 0.2.7.5 is the first stable release in the Tor 0.2.7 series. + + The 0.2.7 series adds a more secure identity key type for relays, + improves cryptography performance, resolves several longstanding + hidden-service performance issues, improves controller support for + hidden services, and includes small bugfixes and performance + improvements throughout the program. This release series also + includes more tests than before, and significant simplifications + to which parts of Tor invoke which others. For a full list of + changes, see below. o New system requirements: - Tor no longer includes workarounds to support Libevent versions

1 0

[torspec/master] Bug 17578: Fix typos in control-spec.txt
by nickm＠torproject.org 10 Nov '15

10 Nov '15

commit 7f10e7a9d63c3bebd42f690a20369d9c67132aed Author: Georg Koppen <gk(a)torproject.org> Date: Tue Nov 10 13:45:59 2015 +0000 Bug 17578: Fix typos in control-spec.txt --- control-spec.txt | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/control-spec.txt b/control-spec.txt index 4df6a60..5dc7f8d 100644 --- a/control-spec.txt +++ b/control-spec.txt @@ -43,11 +43,11 @@ 1.1. Forward-compatibility This is an evolving protocol; new client and server behavior will be - allowed in future versions. To allow new backward-compatible client + allowed in future versions. To allow new backward-compatible behavior on behalf of the client, we may add new commands and allow existing commands to take new arguments in future versions. To allow new backward-compatible server behavior, we note various places below - where servers speaking a future versions of this protocol may insert + where servers speaking a future version of this protocol may insert new data, and note that clients should/must "tolerate" unexpected elements in these places. There are two ways that we do this: @@ -68,8 +68,8 @@ For example, we might say "This field will be OPEN, CLOSED, or CONNECTED. Clients MUST tolerate unexpected values." This means that a client MUST NOT crash or otherwise fail to parse the message - or other subsequent when there are unexpected values, and that the - client SHOULD try to handle the rest of the message as well as it + or other subsequent messages when there are unexpected values, and + that it SHOULD try to handle the rest of the message as well as it can. The most obvious way to do this is by pretending that each list of alternatives has an additional "unrecognized value" element, and mapping any unrecognized values to that element; the

1 0

[torbutton/maint-1.9.3] Bug 16990: Avoid matching '250 ' to the end of node name
by gk＠torproject.org 10 Nov '15

10 Nov '15

commit c0e4b60c3dea82ad49d366038d5d950077a1c0fe Author: Arthur Edelstein <arthuredelstein(a)gmail.com> Date: Thu Nov 5 08:15:16 2015 -0800 Bug 16990: Avoid matching '250 ' to the end of node name --- src/modules/tor-control-port.js | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/modules/tor-control-port.js b/src/modules/tor-control-port.js index de9f10a..2b41897 100644 --- a/src/modules/tor-control-port.js +++ b/src/modules/tor-control-port.js @@ -517,11 +517,11 @@ info.stringToValue = function (string) { key = matchForKey ? matchForKey[1] : null; if (key === null) return null; // matchResult finds a single-line result for `250-` or a multi-line one for `250+`. - let matchResult = string.match(/250[ -].+?=(.*?)$/mi) || - string.match(/250\+.+?=([\s\S]*?)^\.$/mi), + let matchResult = string.match(/^250[ -].+?=(.*?)$/mi) || + string.match(/^250\+.+?=([\s\S]*?)^\.$/mi), // Retrieve the captured group (the text of the value in the key-value pair) valueString = matchResult ? matchResult[1] : null, - // Get the parser functino for the key found. + // Get the parser function for the key found. parse = info.getParser(key.toLowerCase()); if (parse === undefined) { throw new Error("No parser found for '" + key + "'");

1 0

[torbutton/master] Bug 16990: Avoid matching '250 ' to the end of node name
by gk＠torproject.org 10 Nov '15

10 Nov '15

commit 55724056112b1fd6bc2a42046a42dc265e1e44ea Author: Arthur Edelstein <arthuredelstein(a)gmail.com> Date: Thu Nov 5 08:15:16 2015 -0800 Bug 16990: Avoid matching '250 ' to the end of node name --- src/modules/tor-control-port.js | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/modules/tor-control-port.js b/src/modules/tor-control-port.js index de9f10a..2b41897 100644 --- a/src/modules/tor-control-port.js +++ b/src/modules/tor-control-port.js @@ -517,11 +517,11 @@ info.stringToValue = function (string) { key = matchForKey ? matchForKey[1] : null; if (key === null) return null; // matchResult finds a single-line result for `250-` or a multi-line one for `250+`. - let matchResult = string.match(/250[ -].+?=(.*?)$/mi) || - string.match(/250\+.+?=([\s\S]*?)^\.$/mi), + let matchResult = string.match(/^250[ -].+?=(.*?)$/mi) || + string.match(/^250\+.+?=([\s\S]*?)^\.$/mi), // Retrieve the captured group (the text of the value in the key-value pair) valueString = matchResult ? matchResult[1] : null, - // Get the parser functino for the key found. + // Get the parser function for the key found. parse = info.getParser(key.toLowerCase()); if (parse === undefined) { throw new Error("No parser found for '" + key + "'");

1 0

[translation/torbutton-torbuttondtd] Update translations for torbutton-torbuttondtd
by translation＠torproject.org 10 Nov '15

10 Nov '15

commit bbf46cbc0dbbd743ab7ac3f370fea031f90bd994 Author: Translation commit bot <translation(a)torproject.org> Date: Tue Nov 10 06:45:53 2015 +0000 Update translations for torbutton-torbuttondtd --- ar/torbutton.dtd | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ar/torbutton.dtd b/ar/torbutton.dtd index ca7ff68..6397c71 100644 --- a/ar/torbutton.dtd +++ b/ar/torbutton.dtd @@ -153,7 +153,7 @@ <!ENTITY torbutton.prefs.sec_caption "مستوى الأمان"> <!ENTITY torbutton.prefs.sec_low "منخفض (افتراضي)"> <!ENTITY torbutton.prefs.sec_low_usable_desc "هذا يوفر أفضل خبرة للإستخدام"> -<!ENTITY torbutton.prefs.sec_low_desc "At this security level, all browser features are enabled."> +<!ENTITY torbutton.prefs.sec_low_desc "طبقاً لهذا المستوى من إعدادات الأمان سوف يتم تفعيل كل صفات المتصفح"> <!ENTITY torbutton.prefs.sec_font_rend_svg_tooltip "The SVG OpenType font rendering mechanism is disabled."> <!ENTITY torbutton.prefs.sec_med_low "شبه منخفض"> <!ENTITY torbutton.prefs.sec_gen_desc "At this security level, the following changes apply (mouseover for details):">

1 0

[translation/torbutton-torbuttondtd] Update translations for torbutton-torbuttondtd
by translation＠torproject.org 10 Nov '15

10 Nov '15

commit cf9b790e4a469fd47c65a1e5a1e2f106a5981097 Author: Translation commit bot <translation(a)torproject.org> Date: Tue Nov 10 05:45:54 2015 +0000 Update translations for torbutton-torbuttondtd --- ar/torbutton.dtd | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/ar/torbutton.dtd b/ar/torbutton.dtd index b1cc509..ca7ff68 100644 --- a/ar/torbutton.dtd +++ b/ar/torbutton.dtd @@ -106,7 +106,7 @@ <!ENTITY torbutton.prefs.restore_defaults "استعادة الافتراضيات"> <!ENTITY torbutton.prefs.test_settings "فحص الإعدادات"> <!ENTITY torbutton.prefs.test_auto "افحص إعدادات تور بعد أول تشغيل كل مرة يتم تشغيل فيرفكس"> -<!ENTITY torbutton.prefs.disable_livemarks "Disable livemarks updates during Tor usage"> +<!ENTITY torbutton.prefs.disable_livemarks "إلغاء تحديث العلامات الحية أثناء إستعمال تور"> <!ENTITY torbutton.prefs.tor_memory_jar "لا تحفظ ملفات تعريف الارتباط (كوكيز) في القرص إذا كان التور مفعلًا"> <!ENTITY torbutton.prefs.nontor_memory_jar "لا تحفظ ملفات تعريف الارتباط (كوكيز) في القرص إن كان تور معطلًا"> <!ENTITY torbutton.prefs.session_restore "حفظ الجلسة واستعادة هذه التبويبات:"> @@ -133,7 +133,7 @@ <!ENTITY torbutton.cookiedialog.removeAllBut "إزالة الكل لكن استمر في الحماية"> <!ENTITY torbutton.cookiedialog.saveAllCookies "احم ملفات تعريف الارتباط الجديدة"> <!ENTITY torbutton.cookiedialog.doNotSaveAllCookies "لا تحم ملفات تعريف الارتباط الجديدة"> -<!ENTITY torbutton.prefs.disable_livemarks "Disable livemarks updates during Tor usage"> +<!ENTITY torbutton.prefs.disable_livemarks "إلغاء تحديث العلامات الحية أثناء إستعمال تور"> <!ENTITY torbutton.prefs.dtd_recommended "(محبّذ)"> <!ENTITY torbutton.prefs.dtd_optional "(اختياري)"> <!ENTITY torbutton.prefs.dtd_crucial "(ضروري جدا)"> @@ -152,7 +152,7 @@ <!ENTITY torbutton.prefs.resist_fingerprinting "تغيير التفاصيل التي تميزك عن المستخدمين الآخرين لمتصفح تور"> <!ENTITY torbutton.prefs.sec_caption "مستوى الأمان"> <!ENTITY torbutton.prefs.sec_low "منخفض (افتراضي)"> -<!ENTITY torbutton.prefs.sec_low_usable_desc "This provides the most usable experience."> +<!ENTITY torbutton.prefs.sec_low_usable_desc "هذا يوفر أفضل خبرة للإستخدام"> <!ENTITY torbutton.prefs.sec_low_desc "At this security level, all browser features are enabled."> <!ENTITY torbutton.prefs.sec_font_rend_svg_tooltip "The SVG OpenType font rendering mechanism is disabled."> <!ENTITY torbutton.prefs.sec_med_low "شبه منخفض">

1 0

[tor/master] Mark fallback directoriess as too busy after a 503 response
by nickm＠torproject.org 10 Nov '15

10 Nov '15

commit 0d5a439292a7837033afb733221b1f3b1f641b5f Author: teor (Tim Wilson-Brown) <teor2345(a)gmail.com> Date: Tue Nov 10 09:47:48 2015 +1100 Mark fallback directoriess as too busy after a 503 response Mark fallback directory mirrors as "too busy" when they return a 503 response. Previously, the code just marked authorities as busy. Unless clients set their own fallback directories, they will never see this bug. (There are no default fallbacks yet.) Fixes bug 17572; bugfix on 5c51b3f1f0d4 released in 0.2.4.7-alpha. Patch by "teor". --- changes/bug17572-fallback-by-digest | 5 +++++ src/or/routerlist.c | 4 ++-- 2 files changed, 7 insertions(+), 2 deletions(-) diff --git a/changes/bug17572-fallback-by-digest b/changes/bug17572-fallback-by-digest new file mode 100644 index 0000000..3fba123 --- /dev/null +++ b/changes/bug17572-fallback-by-digest @@ -0,0 +1,5 @@ + o Minor bugfix (fallback directories): + - Mark fallbacks as "too busy" when they return a 503 response, + rather than just marking authorities. + Fixes bug 17572; bugfix on 5c51b3f1f0d4 released in 0.2.4.7-alpha. + Patch by "teor". diff --git a/src/or/routerlist.c b/src/or/routerlist.c index 694a148..8f6a440 100644 --- a/src/or/routerlist.c +++ b/src/or/routerlist.c @@ -1363,10 +1363,10 @@ router_get_trusteddirserver_by_digest(const char *digest) dir_server_t * router_get_fallback_dirserver_by_digest(const char *digest) { - if (!trusted_dir_servers) + if (!fallback_dir_servers) return NULL; - SMARTLIST_FOREACH(trusted_dir_servers, dir_server_t *, ds, + SMARTLIST_FOREACH(fallback_dir_servers, dir_server_t *, ds, { if (tor_memeq(ds->digest, digest, DIGEST_LEN)) return ds;

1 0