October 2014 - tor-commits - lists.torproject.org

[arm/master] Moving accounting info into the graph panel
by atagar＠torproject.org 18 Oct '14

18 Oct '14

commit 197640fe1e939570c60f34ddd054a0df0b1ebaf7 Author: Damian Johnson <atagar(a)torproject.org> Date: Sat Oct 18 14:14:33 2014 -0700 Moving accounting info into the graph panel Shifting handling for accounting info from the bandwidth stats to the graph panel. This doesn't make things much better or worse at present, but it'll allow us to greatly simplify the stats. --- arm/graph_panel.py | 111 +++++++++++++++++++++++++--------------------------- 1 file changed, 53 insertions(+), 58 deletions(-) diff --git a/arm/graph_panel.py b/arm/graph_panel.py index 8f08fb3..7072f38 100644 --- a/arm/graph_panel.py +++ b/arm/graph_panel.py @@ -189,13 +189,6 @@ class GraphStats: def secondary_header(self, width): return '' - def get_content_height(self): - """ - Provides the height content should take up (not including the graph). - """ - - return DEFAULT_CONTENT_HEIGHT - def draw(self, panel, width, height): """ Allows for any custom drawing monitor wishes to append. @@ -253,11 +246,10 @@ class BandwidthStats(GraphStats): GraphStats.__init__(self) # listens for tor reload (sighup) events which can reset the bandwidth - # rate/burst and if tor's using accounting + # rate/burst controller = tor_controller() self._title_stats = [] - self._accounting_stats = None if not is_pause_buffer: self.reset_listener(controller, State.INIT, None) # initializes values @@ -286,32 +278,13 @@ class BandwidthStats(GraphStats): if not new_copy: new_copy = BandwidthStats(True) - new_copy._accounting_stats = self._accounting_stats new_copy._title_stats = self._title_stats return GraphStats.clone(self, new_copy) def reset_listener(self, controller, event_type, _): - # updates title parameters and accounting status if they changed - self.new_desc_event(None) # updates title params - if event_type in (State.INIT, State.RESET) and CONFIG['features.graph.bw.accounting.show']: - is_accounting_enabled = controller.get_info('accounting/enabled', None) == '1' - - if is_accounting_enabled != bool(self._accounting_stats): - self._accounting_stats = tor_controller().get_accounting_stats(None) - - # redraws the whole screen since our height changed - - arm.controller.get_controller().redraw() - - # redraws to reflect changes (this especially noticeable when we have - # accounting and shut down since it then gives notice of the shutdown) - - if self._graph_panel and self.is_selected: - self._graph_panel.redraw(True) - def prepopulate_from_state(self): """ Attempts to use tor's state file to prepopulate values for the 15 minute @@ -364,10 +337,6 @@ class BandwidthStats(GraphStats): return time.time() - min(stats.last_read_time, stats.last_write_time) def bandwidth_event(self, event): - if self._accounting_stats and self.is_next_tick_redraw(): - if time.time() - self._accounting_stats.retrieved >= ACCOUNTING_RATE: - self._accounting_stats = tor_controller().get_accounting_stats(None) - # scales units from B to KB for graphing self._process_event(event.read / 1024.0, event.written / 1024.0) @@ -375,7 +344,7 @@ class BandwidthStats(GraphStats): def draw(self, panel, width, height): # line of the graph's x-axis labeling - labeling_line = GraphStats.get_content_height(self) + panel.graph_height - 2 + labeling_line = DEFAULT_CONTENT_HEIGHT + panel.graph_height - 2 # if display is narrow, overwrites x-axis labels with avg / total stats @@ -392,25 +361,6 @@ class BandwidthStats(GraphStats): panel.addstr(labeling_line, 1, primary_footer, PRIMARY_COLOR) panel.addstr(labeling_line, graph_column + 6, secondary_footer, SECONDARY_COLOR) - # provides accounting stats if enabled - - if self._accounting_stats: - if tor_controller().is_alive(): - hibernate_color = CONFIG['attr.hibernate_color'].get(self._accounting_stats.status, 'red') - - x, y = 0, labeling_line + 2 - x = panel.addstr(y, x, 'Accounting (', curses.A_BOLD) - x = panel.addstr(y, x, self._accounting_stats.status, curses.A_BOLD, hibernate_color) - x = panel.addstr(y, x, ')', curses.A_BOLD) - - panel.addstr(y, 35, 'Time to reset: %s' % str_tools.short_time_label(self._accounting_stats.time_until_reset)) - - panel.addstr(y + 1, 2, '%s / %s' % (self._accounting_stats.read_bytes, self._accounting_stats.read_limit), PRIMARY_COLOR) - panel.addstr(y + 1, 37, '%s / %s' % (self._accounting_stats.written_bytes, self._accounting_stats.write_limit), SECONDARY_COLOR) - else: - panel.addstr(labeling_line + 2, 0, 'Accounting:', curses.A_BOLD) - panel.addstr(labeling_line + 2, 12, 'Connection Closed...') - def get_title(self, width): stats_label = str_tools.join(self._title_stats, ', ', width - 13) return 'Bandwidth (%s):' % stats_label if stats_label else 'Bandwidth:' @@ -449,10 +399,6 @@ class BandwidthStats(GraphStats): else: return 'Upload:' - def get_content_height(self): - base_height = GraphStats.get_content_height(self) - return base_height + 3 if self._accounting_stats else base_height - def new_desc_event(self, event): controller = tor_controller() @@ -608,6 +554,7 @@ class GraphPanel(panel.Panel): self.bounds = list(Bounds)[CONFIG['features.graph.bound']] self.graph_height = CONFIG['features.graph.height'] self.current_display = None # label of the stats currently being displayed + self._accounting_stats = None self.stats = { GraphStat.BANDWIDTH: BandwidthStats(), @@ -621,6 +568,7 @@ class GraphPanel(panel.Panel): stat._graph_panel = self self.set_pause_attr('stats') + self.set_pause_attr('_accounting_stats') try: initial_stats = GRAPH_INIT_STATS.get(CONFIG['features.graph.type']) @@ -643,6 +591,26 @@ class GraphPanel(panel.Panel): except ValueError as exc: log.info(msg('panel.graphing.prepopulation_failure', error = str(exc))) + tor_controller().add_event_listener(self.bandwidth_event, stem.control.EventType.BW) + + def bandwidth_event(self, event): + if not CONFIG['features.graph.bw.accounting.show']: + self._accounting_stats = None + elif not self._accounting_stats or time.time() - self._accounting_stats.retrieved >= ACCOUNTING_RATE: + old_accounting_stats = self._accounting_stats + self._accounting_stats = tor_controller().get_accounting_stats(None) + + if bool(old_accounting_stats) != bool(self._accounting_stats): + # we either added or removed accounting info, redraw the whole screen since this changes our height + + arm.controller.get_controller().redraw() + + # redraws to reflect changes (this especially noticeable when we have + # accounting and shut down since it then gives notice of the shutdown) + + if self.current_display == GraphStat.BANDWIDTH: + self.redraw(True) + def get_update_interval(self): """ Provides the rate that we update the graph at. @@ -684,9 +652,14 @@ class GraphPanel(panel.Panel): """ if self.current_display: - return self.stats[self.current_display].get_content_height() + self.graph_height + height = DEFAULT_CONTENT_HEIGHT + self.graph_height else: - return 0 + height = 0 + + if self.current_display == GraphStat.BANDWIDTH and self._accounting_stats: + height += 3 + + return height def set_graph_height(self, new_graph_height): """ @@ -911,6 +884,28 @@ class GraphPanel(panel.Panel): param.draw(self, width, height) # allows current stats to modify the display + # provides accounting stats if enabled + + accounting_stats = self.get_attr('_accounting_stats') + + if self.current_display == GraphStat.BANDWIDTH and accounting_stats: + if tor_controller().is_alive(): + hibernate_color = CONFIG['attr.hibernate_color'].get(accounting_stats.status, 'red') + + labeling_line = DEFAULT_CONTENT_HEIGHT + self.graph_height - 2 + x, y = 0, labeling_line + 2 + x = self.addstr(y, x, 'Accounting (', curses.A_BOLD) + x = self.addstr(y, x, accounting_stats.status, curses.A_BOLD, hibernate_color) + x = self.addstr(y, x, ')', curses.A_BOLD) + + self.addstr(y, 35, 'Time to reset: %s' % str_tools.short_time_label(accounting_stats.time_until_reset)) + + self.addstr(y + 1, 2, '%s / %s' % (accounting_stats.read_bytes, accounting_stats.read_limit), PRIMARY_COLOR) + self.addstr(y + 1, 37, '%s / %s' % (accounting_stats.written_bytes, accounting_stats.write_limit), SECONDARY_COLOR) + else: + self.addstr(labeling_line + 2, 0, 'Accounting:', curses.A_BOLD) + self.addstr(labeling_line + 2, 12, 'Connection Closed...') + def get_stats(self): """ Provides the currently selected stats label.

1 0

[arm/master] Draw block is a no-op without any stats
by atagar＠torproject.org 18 Oct '14

18 Oct '14

commit cb5c895333092f051d15d363a74219e08e65b502 Author: Damian Johnson <atagar(a)torproject.org> Date: Sun Oct 12 15:37:17 2014 -0700 Draw block is a no-op without any stats Our graph panel's whole draw method was wrapped in a conditional. Minor tweak so we can unindent the whole method. --- arm/graphing/graph_panel.py | 176 +++++++++++++++++++++---------------------- 1 file changed, 88 insertions(+), 88 deletions(-) diff --git a/arm/graphing/graph_panel.py b/arm/graphing/graph_panel.py index 4450c6c..99c1d3b 100644 --- a/arm/graphing/graph_panel.py +++ b/arm/graphing/graph_panel.py @@ -438,129 +438,129 @@ class GraphPanel(panel.Panel): ] def draw(self, width, height): - """ Redraws graph panel """ + if not self.current_display: + return - if self.current_display: - param = self.get_attr('stats')[self.current_display] - graph_column = min((width - 10) / 2, param.max_column) + param = self.get_attr('stats')[self.current_display] + graph_column = min((width - 10) / 2, param.max_column) - if self.is_title_visible(): - self.addstr(0, 0, param.get_title(width), curses.A_STANDOUT) + if self.is_title_visible(): + self.addstr(0, 0, param.get_title(width), curses.A_STANDOUT) - # top labels + # top labels - left, right = param.primary_header(width / 2), param.secondary_header(width / 2) + left, right = param.primary_header(width / 2), param.secondary_header(width / 2) - if left: - self.addstr(1, 0, left, curses.A_BOLD, PRIMARY_COLOR) + if left: + self.addstr(1, 0, left, curses.A_BOLD, PRIMARY_COLOR) - if right: - self.addstr(1, graph_column + 5, right, curses.A_BOLD, SECONDARY_COLOR) + if right: + self.addstr(1, graph_column + 5, right, curses.A_BOLD, SECONDARY_COLOR) - # determines max/min value on the graph + # determines max/min value on the graph - if self.bounds == Bounds.GLOBAL_MAX: - primary_max_bound = int(param.max_primary[self.update_interval]) - secondary_max_bound = int(param.max_secondary[self.update_interval]) + if self.bounds == Bounds.GLOBAL_MAX: + primary_max_bound = int(param.max_primary[self.update_interval]) + secondary_max_bound = int(param.max_secondary[self.update_interval]) + else: + # both Bounds.LOCAL_MAX and Bounds.TIGHT use local maxima + if graph_column < 2: + # nothing being displayed + primary_max_bound, secondary_max_bound = 0, 0 else: - # both Bounds.LOCAL_MAX and Bounds.TIGHT use local maxima - if graph_column < 2: - # nothing being displayed - primary_max_bound, secondary_max_bound = 0, 0 - else: - primary_max_bound = int(max(param.primary_counts[self.update_interval][1:graph_column + 1])) - secondary_max_bound = int(max(param.secondary_counts[self.update_interval][1:graph_column + 1])) - - primary_min_bound = secondary_min_bound = 0 - - if self.bounds == Bounds.TIGHT: - primary_min_bound = int(min(param.primary_counts[self.update_interval][1:graph_column + 1])) - secondary_min_bound = int(min(param.secondary_counts[self.update_interval][1:graph_column + 1])) + primary_max_bound = int(max(param.primary_counts[self.update_interval][1:graph_column + 1])) + secondary_max_bound = int(max(param.secondary_counts[self.update_interval][1:graph_column + 1])) - # if the max = min (ie, all values are the same) then use zero lower - # bound so a graph is still displayed + primary_min_bound = secondary_min_bound = 0 - if primary_min_bound == primary_max_bound: - primary_min_bound = 0 + if self.bounds == Bounds.TIGHT: + primary_min_bound = int(min(param.primary_counts[self.update_interval][1:graph_column + 1])) + secondary_min_bound = int(min(param.secondary_counts[self.update_interval][1:graph_column + 1])) - if secondary_min_bound == secondary_max_bound: - secondary_min_bound = 0 + # if the max = min (ie, all values are the same) then use zero lower + # bound so a graph is still displayed - # displays upper and lower bounds + if primary_min_bound == primary_max_bound: + primary_min_bound = 0 - self.addstr(2, 0, '%4i' % primary_max_bound, PRIMARY_COLOR) - self.addstr(self.graph_height + 1, 0, '%4i' % primary_min_bound, PRIMARY_COLOR) + if secondary_min_bound == secondary_max_bound: + secondary_min_bound = 0 - self.addstr(2, graph_column + 5, '%4i' % secondary_max_bound, SECONDARY_COLOR) - self.addstr(self.graph_height + 1, graph_column + 5, '%4i' % secondary_min_bound, SECONDARY_COLOR) + # displays upper and lower bounds - # displays intermediate bounds on every other row + self.addstr(2, 0, '%4i' % primary_max_bound, PRIMARY_COLOR) + self.addstr(self.graph_height + 1, 0, '%4i' % primary_min_bound, PRIMARY_COLOR) - if CONFIG['features.graph.showIntermediateBounds']: - ticks = (self.graph_height - 3) / 2 + self.addstr(2, graph_column + 5, '%4i' % secondary_max_bound, SECONDARY_COLOR) + self.addstr(self.graph_height + 1, graph_column + 5, '%4i' % secondary_min_bound, SECONDARY_COLOR) - for i in range(ticks): - row = self.graph_height - (2 * i) - 3 + # displays intermediate bounds on every other row - if self.graph_height % 2 == 0 and i >= (ticks / 2): - row -= 1 + if CONFIG['features.graph.showIntermediateBounds']: + ticks = (self.graph_height - 3) / 2 - if primary_min_bound != primary_max_bound: - primary_val = (primary_max_bound - primary_min_bound) * (self.graph_height - row - 1) / (self.graph_height - 1) + for i in range(ticks): + row = self.graph_height - (2 * i) - 3 - if primary_val not in (primary_min_bound, primary_max_bound): - self.addstr(row + 2, 0, '%4i' % primary_val, PRIMARY_COLOR) + if self.graph_height % 2 == 0 and i >= (ticks / 2): + row -= 1 - if secondary_min_bound != secondary_max_bound: - secondary_val = (secondary_max_bound - secondary_min_bound) * (self.graph_height - row - 1) / (self.graph_height - 1) + if primary_min_bound != primary_max_bound: + primary_val = (primary_max_bound - primary_min_bound) * (self.graph_height - row - 1) / (self.graph_height - 1) - if secondary_val not in (secondary_min_bound, secondary_max_bound): - self.addstr(row + 2, graph_column + 5, '%4i' % secondary_val, SECONDARY_COLOR) + if primary_val not in (primary_min_bound, primary_max_bound): + self.addstr(row + 2, 0, '%4i' % primary_val, PRIMARY_COLOR) - # creates bar graph (both primary and secondary) + if secondary_min_bound != secondary_max_bound: + secondary_val = (secondary_max_bound - secondary_min_bound) * (self.graph_height - row - 1) / (self.graph_height - 1) - for col in range(graph_column): - column_count = int(param.primary_counts[self.update_interval][col + 1]) - primary_min_bound - column_height = min(self.graph_height, self.graph_height * column_count / (max(1, primary_max_bound) - primary_min_bound)) + if secondary_val not in (secondary_min_bound, secondary_max_bound): + self.addstr(row + 2, graph_column + 5, '%4i' % secondary_val, SECONDARY_COLOR) - for row in range(column_height): - self.addstr(self.graph_height + 1 - row, col + 5, ' ', curses.A_STANDOUT, PRIMARY_COLOR) + # creates bar graph (both primary and secondary) - column_count = int(param.secondary_counts[self.update_interval][col + 1]) - secondary_min_bound - column_height = min(self.graph_height, self.graph_height * column_count / (max(1, secondary_max_bound) - secondary_min_bound)) + for col in range(graph_column): + column_count = int(param.primary_counts[self.update_interval][col + 1]) - primary_min_bound + column_height = min(self.graph_height, self.graph_height * column_count / (max(1, primary_max_bound) - primary_min_bound)) - for row in range(column_height): - self.addstr(self.graph_height + 1 - row, col + graph_column + 10, ' ', curses.A_STANDOUT, SECONDARY_COLOR) + for row in range(column_height): + self.addstr(self.graph_height + 1 - row, col + 5, ' ', curses.A_STANDOUT, PRIMARY_COLOR) - # bottom labeling of x-axis + column_count = int(param.secondary_counts[self.update_interval][col + 1]) - secondary_min_bound + column_height = min(self.graph_height, self.graph_height * column_count / (max(1, secondary_max_bound) - secondary_min_bound)) - interval_sec = 1 # seconds per labeling + for row in range(column_height): + self.addstr(self.graph_height + 1 - row, col + graph_column + 10, ' ', curses.A_STANDOUT, SECONDARY_COLOR) - for i in range(len(UPDATE_INTERVALS)): - if i == self.update_interval: - interval_sec = UPDATE_INTERVALS[i][1] + # bottom labeling of x-axis - interval_spacing = 10 if graph_column >= WIDE_LABELING_GRAPH_COL else 5 - units_label, decimal_precision = None, 0 + interval_sec = 1 # seconds per labeling - for i in range((graph_column - 4) / interval_spacing): - loc = (i + 1) * interval_spacing - time_label = str_tools.time_label(loc * interval_sec, decimal_precision) - - if not units_label: - units_label = time_label[-1] - elif units_label != time_label[-1]: - # upped scale so also up precision of future measurements - units_label = time_label[-1] - decimal_precision += 1 - else: - # if constrained on space then strips labeling since already provided - time_label = time_label[:-1] + for i in range(len(UPDATE_INTERVALS)): + if i == self.update_interval: + interval_sec = UPDATE_INTERVALS[i][1] + + interval_spacing = 10 if graph_column >= WIDE_LABELING_GRAPH_COL else 5 + units_label, decimal_precision = None, 0 + + for i in range((graph_column - 4) / interval_spacing): + loc = (i + 1) * interval_spacing + time_label = str_tools.time_label(loc * interval_sec, decimal_precision) + + if not units_label: + units_label = time_label[-1] + elif units_label != time_label[-1]: + # upped scale so also up precision of future measurements + units_label = time_label[-1] + decimal_precision += 1 + else: + # if constrained on space then strips labeling since already provided + time_label = time_label[:-1] - self.addstr(self.graph_height + 2, 4 + loc, time_label, PRIMARY_COLOR) - self.addstr(self.graph_height + 2, graph_column + 10 + loc, time_label, SECONDARY_COLOR) + self.addstr(self.graph_height + 2, 4 + loc, time_label, PRIMARY_COLOR) + self.addstr(self.graph_height + 2, graph_column + 10 + loc, time_label, SECONDARY_COLOR) - param.draw(self, width, height) # allows current stats to modify the display + param.draw(self, width, height) # allows current stats to modify the display def get_stats(self): """

1 0

[arm/master] Moving graph stat inititalization into the graph panel
by atagar＠torproject.org 18 Oct '14

18 Oct '14

commit 6ea5b4a6acd94bb8151ad67d92820d69c0341fe2 Author: Damian Johnson <atagar(a)torproject.org> Date: Sun Oct 12 15:20:41 2014 -0700 Moving graph stat inititalization into the graph panel Hmmmm, not sure why we did this. Our controller initialized graph stats then added them to the graph panel. Maybe this made sense with a past feature or pausing implementation. ... or maybe it still makes sense and I'm not spotting why. It's a lot simpler for the panel to be responsible for its own stats so going with this for now. Guess we'll see if this bites me down the line. --- arm/controller.py | 45 ----------------------------------- arm/graphing/graph_panel.py | 55 ++++++++++++++++++++++++++++++++++--------- 2 files changed, 44 insertions(+), 56 deletions(-) diff --git a/arm/controller.py b/arm/controller.py index 48034e9..42d0531 100644 --- a/arm/controller.py +++ b/arm/controller.py @@ -52,17 +52,9 @@ CONFIG = conf.config_dict("arm", { "features.redrawRate": 5, "features.refreshRate": 5, "features.confirmQuit": True, - "features.graph.type": 1, - "features.graph.bw.prepopulate": True, "start_time": 0, }, conf_handler) -GraphStat = enum.Enum("BANDWIDTH", "CONNECTIONS", "SYSTEM_RESOURCES") - -# maps 'features.graph.type' config values to the initial types - -GRAPH_INIT_STATS = {1: GraphStat.BANDWIDTH, 2: GraphStat.CONNECTIONS, 3: GraphStat.SYSTEM_RESOURCES} - def get_controller(): """ @@ -173,43 +165,6 @@ def init_controller(stdscr, start_time): ARM_CONTROLLER = Controller(stdscr, sticky_panels, page_panels) - # additional configuration for the graph panel - - graph_panel = ARM_CONTROLLER.get_panel("graph") - - if graph_panel: - # statistical monitors for graph - - bw_stats = arm.graphing.bandwidth_stats.BandwidthStats() - graph_panel.add_stats(GraphStat.BANDWIDTH, bw_stats) - graph_panel.add_stats(GraphStat.SYSTEM_RESOURCES, arm.graphing.resource_stats.ResourceStats()) - - if CONFIG["features.panels.show.connection"]: - graph_panel.add_stats(GraphStat.CONNECTIONS, arm.graphing.conn_stats.ConnStats()) - - # sets graph based on config parameter - - try: - initial_stats = GRAPH_INIT_STATS.get(CONFIG["features.graph.type"]) - graph_panel.set_stats(initial_stats) - except ValueError: - pass # invalid stats, maybe connections when lookups are disabled - - # prepopulates bandwidth values from state file - - if CONFIG["features.graph.bw.prepopulate"] and tor_controller().is_alive(): - try: - missing_seconds = bw_stats.prepopulate_from_state() - - if missing_seconds: - log.notice(msg('panel.graphing.prepopulation_successful', duration = str_tools.time_label(missing_seconds, 0, True))) - else: - log.notice(msg('panel.graphing.prepopulation_all_successful')) - - graph_panel.update_interval = 4 - except ValueError as exc: - log.info(msg('panel.graphing.prepopulation_failure', error = str(exc))) - class LabelPanel(panel.Panel): """ diff --git a/arm/graphing/graph_panel.py b/arm/graphing/graph_panel.py index a034e56..4450c6c 100644 --- a/arm/graphing/graph_panel.py +++ b/arm/graphing/graph_panel.py @@ -24,9 +24,9 @@ import arm.controller import stem.control -from arm.util import panel, tor_controller +from arm.util import msg, panel, tor_controller -from stem.util import conf, enum, str_tools +from stem.util import conf, enum, log, str_tools # time intervals at which graphs can be updated @@ -41,6 +41,12 @@ UPDATE_INTERVALS = [ ('daily', 86400), ] +GraphStat = enum.Enum("BANDWIDTH", "CONNECTIONS", "SYSTEM_RESOURCES") + +# maps 'features.graph.type' config values to the initial types + +GRAPH_INIT_STATS = {1: GraphStat.BANDWIDTH, 2: GraphStat.CONNECTIONS, 3: GraphStat.SYSTEM_RESOURCES} + DEFAULT_CONTENT_HEIGHT = 4 # space needed for labeling above and below the graph PRIMARY_COLOR, SECONDARY_COLOR = 'green', 'cyan' MIN_GRAPH_HEIGHT = 1 @@ -74,6 +80,9 @@ CONFIG = conf.config_dict('arm', { 'features.graph.bound': 1, 'features.graph.max_width': 150, 'features.graph.showIntermediateBounds': True, + 'features.graph.type': 1, + 'features.panels.show.connection': True, + 'features.graph.bw.prepopulate': True, }, conf_handler) @@ -246,9 +255,41 @@ class GraphPanel(panel.Panel): self.bounds = list(Bounds)[CONFIG['features.graph.bound']] self.graph_height = CONFIG['features.graph.height'] self.current_display = None # label of the stats currently being displayed - self.stats = {} # available stats (mappings of label -> instance) + + self.stats = { + GraphStat.BANDWIDTH: arm.graphing.bandwidth_stats.BandwidthStats(), + GraphStat.SYSTEM_RESOURCES: arm.graphing.resource_stats.ResourceStats(), + } + + if CONFIG['features.panels.show.connection']: + self.stats[GraphStat.CONNECTIONS] = arm.graphing.conn_stats.ConnStats() + + for stat in self.stats.values(): + stat._graph_panel = self + self.set_pause_attr('stats') + try: + initial_stats = GRAPH_INIT_STATS.get(CONFIG['features.graph.type']) + self.set_stats(initial_stats) + except ValueError: + pass # invalid stats, maybe connections when lookups are disabled + + # prepopulates bandwidth values from state file + + if CONFIG["features.graph.bw.prepopulate"] and tor_controller().is_alive(): + try: + missing_seconds = self.stats[GraphStat.BANDWIDTH].prepopulate_from_state() + + if missing_seconds: + log.notice(msg('panel.graphing.prepopulation_successful', duration = str_tools.time_label(missing_seconds, 0, True))) + else: + log.notice(msg('panel.graphing.prepopulation_all_successful')) + + self.update_interval = 4 + except ValueError as exc: + log.info(msg('panel.graphing.prepopulation_failure', error = str(exc))) + def get_update_interval(self): """ Provides the rate that we update the graph at. @@ -521,14 +562,6 @@ class GraphPanel(panel.Panel): param.draw(self, width, height) # allows current stats to modify the display - def add_stats(self, label, stats): - """ - Makes GraphStats instance available in the panel. - """ - - stats._graph_panel = self - self.stats[label] = stats - def get_stats(self): """ Provides the currently selected stats label.

1 0

[stem/master] Accounting info's time_until_reset incorrect
by atagar＠torproject.org 18 Oct '14

18 Oct '14

commit 11469cf3b5f012b3f5e152bd40e6dcce485787c2 Author: Damian Johnson <atagar(a)torproject.org> Date: Sat Oct 18 14:10:25 2014 -0700 Accounting info's time_until_reset incorrect Oops. We inverted attributes always accounting a negative time_until_reset. --- stem/control.py | 2 +- test/unit/control/controller.py | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/stem/control.py b/stem/control.py index 4688bd7..ed83a00 100644 --- a/stem/control.py +++ b/stem/control.py @@ -1246,7 +1246,7 @@ class Controller(BaseController): retrieved = retrieved, status = status, interval_end = interval_end, - time_until_reset = int(retrieved) - calendar.timegm(interval_end.timetuple()), + time_until_reset = calendar.timegm(interval_end.timetuple()) - int(retrieved), read_bytes = used_read, read_bytes_left = left_read, read_limit = used_read + left_read, diff --git a/test/unit/control/controller.py b/test/unit/control/controller.py index 948068f..5e0058f 100644 --- a/test/unit/control/controller.py +++ b/test/unit/control/controller.py @@ -281,7 +281,7 @@ class TestControl(unittest.TestCase): self.assertRaises(stem.ProtocolError, self.controller.get_socks_listeners) @patch('stem.control.Controller.get_info') - @patch('time.time', Mock(return_value = 1410723698.276578)) + @patch('time.time', Mock(return_value = 1410723598.276578)) def test_get_accounting_stats(self, get_info_mock): """ Exercises the get_accounting_stats() method. @@ -296,10 +296,10 @@ class TestControl(unittest.TestCase): }[param] expected = stem.control.AccountingStats( - 1410723698.276578, + 1410723598.276578, 'awake', datetime.datetime(2014, 9, 14, 19, 41), - 38, + 62, 4837, 102944, 107781, 2050, 7440, 9490, )

1 0

[translation/torbutton-torbuttonproperties] Update translations for torbutton-torbuttonproperties
by translation＠torproject.org 18 Oct '14

18 Oct '14

commit e103d413dc0b4e9011bb4ba03a1efdf4f509f781 Author: Translation commit bot <translation(a)torproject.org> Date: Sat Oct 18 20:45:54 2014 +0000 Update translations for torbutton-torbuttonproperties --- af/torbutton.properties | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/af/torbutton.properties b/af/torbutton.properties index 1548b52..1913165 100644 --- a/af/torbutton.properties +++ b/af/torbutton.properties @@ -1,7 +1,7 @@ -torbutton.button.tooltip.disabled = Enable Tor -torbutton.button.tooltip.enabled = Disable Tor -torbutton.panel.tooltip.disabled = Click to enable Tor -torbutton.panel.tooltip.enabled = Click to disable Tor +torbutton.button.tooltip.disabled = Sit Tor aan +torbutton.button.tooltip.enabled = Sit Tor Af +torbutton.panel.tooltip.disabled = Klil om Tor aan te sit +torbutton.panel.tooltip.enabled = Klik om Tor af te sit torbutton.panel.plugins.disabled = Click to enable plugins torbutton.panel.plugins.enabled = Click to disable plugins torbutton.panel.label.disabled = Tor Disabled @@ -16,9 +16,9 @@ torbutton.popup.test.success = Tor proxy test successful! torbutton.popup.test.failure = Tor proxy test FAILED! Check your proxy and Polipo settings. torbutton.popup.test.confirm_toggle = The most recent Tor proxy test failed to use Tor.\n\nAre you sure you want to enable anyway?\n\nNote: If you have fixed the problem, you can rerun the test in the Torbutton Proxy Preferences window to eliminate this warning. torbutton.popup.test.ff3_notice = Click OK to test Tor proxy settings. This test will happen in the background. Please be patient. -torbutton.panel.label.verified = Tor Verified +torbutton.panel.label.verified = Tor Geverifieer torbutton.popup.test.auto_failed = The automatic Tor proxy test failed to use Tor.\n\nAre you sure you want to enable anyway? -torbutton.prefs.recommended = (recommended) +torbutton.prefs.recommended = (aanbeveel) torbutton.prefs.optional = (opsionele) torbutton.prefs.crucial = (noodsaaklik) torbutton.popup.external.title = Download an external file type?

1 0

[translation/tor-launcher-properties] Update translations for tor-launcher-properties
by translation＠torproject.org 18 Oct '14

18 Oct '14

commit e9f78db03d36d60278351ceec6df750c7bc7e338 Author: Translation commit bot <translation(a)torproject.org> Date: Sat Oct 18 20:45:33 2014 +0000 Update translations for tor-launcher-properties --- af/torlauncher.properties | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/af/torlauncher.properties b/af/torlauncher.properties index 02be756..c347389 100644 --- a/af/torlauncher.properties +++ b/af/torlauncher.properties @@ -27,7 +27,7 @@ torlauncher.error_bridges_missing=You must specify one or more bridges. torlauncher.error_default_bridges_type_missing=You must select a transport type for the provided bridges. torlauncher.error_bridge_bad_default_type=No provided bridges that have the transport type %S are available. Please adjust your settings. -torlauncher.recommended_bridge=(recommended) +torlauncher.recommended_bridge=(aanbeveel) torlauncher.connect=Connect torlauncher.restart_tor=Restart Tor

1 0

[translation/torbutton-torbuttonproperties] Update translations for torbutton-torbuttonproperties
by translation＠torproject.org 18 Oct '14

18 Oct '14

commit 2ebea073ba238d2d05f2edd0ddff775bf9f91812 Author: Translation commit bot <translation(a)torproject.org> Date: Sat Oct 18 20:16:08 2014 +0000 Update translations for torbutton-torbuttonproperties --- af/torbutton.properties | 26 +++++++++++++------------- 1 file changed, 13 insertions(+), 13 deletions(-) diff --git a/af/torbutton.properties b/af/torbutton.properties index 0154401..1548b52 100644 --- a/af/torbutton.properties +++ b/af/torbutton.properties @@ -19,19 +19,19 @@ torbutton.popup.test.ff3_notice = Click OK to test Tor proxy settings. This test torbutton.panel.label.verified = Tor Verified torbutton.popup.test.auto_failed = The automatic Tor proxy test failed to use Tor.\n\nAre you sure you want to enable anyway? torbutton.prefs.recommended = (recommended) -torbutton.prefs.optional = (optional) -torbutton.prefs.crucial = (crucial) +torbutton.prefs.optional = (opsionele) +torbutton.prefs.crucial = (noodsaaklik) torbutton.popup.external.title = Download an external file type? -torbutton.popup.external.app = Tor Browser cannot display this file. You will need to open it with another application.\n\n +torbutton.popup.external.app = Tor Browser kan hierdie lêer nie vertoon nie. Jy sal n ander program moet gebruik om dit oop te maak.\n\n torbutton.popup.external.note = Some types of files can cause applications to connect to the Internet without using Tor.\n\n torbutton.popup.external.suggest = To be safe, you should only open downloaded files while offline, or use a Tor Live CD such as Tails.\n torbutton.popup.launch = Download file -torbutton.popup.cancel = Cancel +torbutton.popup.cancel = Kanselleer torbutton.popup.dontask = Automatically download files from now on torbutton.popup.test.no_http_proxy = Tor proxy test: Local HTTP Proxy is unreachable. Is Polipo running properly? -torbutton.popup.captcha.title = Avoid Google Captchas? +torbutton.popup.captcha.title = Vermy Google captcha ? torbutton.popup.captcha.ask = Torbutton detected a Google Captcha. Would you like to be redirected to another search engine for this query? -torbutton.popup.captcha.always = Always perform this action from now on +torbutton.popup.captcha.always = Voer altyd hierdie aksie uit van nou af torbutton.popup.redirect = Redirect torbutton.popup.no_redirect = Don't Redirect torbutton.popup.prompted_language = Om jou meer privaatheid te gee, kan Torbutton die Engelse weergawe van die web bladsye versoek . Dit kan veroorsaak dat web bladsye wat jy verkies om in jou moedertaal te lees, in Engels vertoon sal word.\n\nWil jy die Engelse web bladsye versoek vir beter privaatheid? @@ -39,19 +39,19 @@ torbutton.popup.no_newnym = Torbutton cannot safely give you a new identity. It torbutton.popup.use_tbb = Dit lyk of jy Torbutton met Firefox gebruik, wat nie meer 'n veilige opstel is nie.\n\nIn plaas daarvan, beveel ons aan dat jy die nuutste Tor Browser Bundel kry deur n e-pos aan gettor(a)torproject.org te stuur of om dit by die volgende URL af te laai : torbutton.popup.pref_error = Torbutton cannot update preferences in the Tor Browser profile directory. torbutton.popup.permission_denied = Please either reset the permissions of the Tor Browser directory or copy it to a new location. -torbutton.popup.device_full = The disk appears to be full. Please free up space or move Tor Browser to a new device. -torbutton.title.prompt_torbrowser = Important Torbutton Information +torbutton.popup.device_full = Die hardeskyf lyk vol . Maak asseblief ruimte of beweeg Tor Browser na 'n nuwe toestel. +torbutton.title.prompt_torbrowser = Belangrike Torbutton Inligting torbutton.popup.prompt_torbrowser = Torbutton works differently now: you can't turn it off any more.\n\nWe made this change because it isn't safe to use Torbutton in a browser that's also used for non-Tor browsing. There were too many bugs there that we couldn't fix any other way.\n\nIf you want to keep using Firefox normally, you should uninstall Torbutton and download Tor Browser Bundle. The privacy properties of Tor Browser are also superior to those of normal Firefox, even when Firefox is used with Torbutton.\n\nTo remove Torbutton, go to Tools->Addons->Extensions and then click the Remove button next to Torbutton. -torbutton.popup.short_torbrowser = Important Torbutton Information!\n\nTorbutton is now always enabled.\n\nClick on the Torbutton for more information. +torbutton.popup.short_torbrowser = Belangrike Torbutton inligting!\n\nTorbutton is nou altyd aan.\n\nKlik op die Torbutton vir meer inligting. torbutton.popup.confirm_plugins = Plugins such as Flash can harm your privacy and anonymity.\n\nThey can also bypass Tor to reveal your current location and IP address.\n\nAre you sure you want to enable plugins?\n\n -torbutton.popup.never_ask_again = Never ask me again +torbutton.popup.never_ask_again = Moet my nooit weer vra nie. # Canvas permission prompt. Strings are kept here for ease of translation. canvas.siteprompt=This website (%S) attempted to extract HTML5 canvas image data, which may be used to uniquely identify your computer.\n\nShould Tor Browser allow this website to extract HTML5 canvas image data? -canvas.notNow=Not Now +canvas.notNow=Nie nou nie canvas.notNowAccessKey=N -canvas.allow=Allow in the future +canvas.allow=Laat toe in die toekoms canvas.allowAccessKey=A -canvas.never=Never for this site (recommended) +canvas.never=Nie vir hierdie webwerf nie (aanbeveel) canvas.neverAccessKey=e

1 0

[translation/tails-misc] Update translations for tails-misc
by translation＠torproject.org 18 Oct '14

18 Oct '14

commit 3475d41703427b22ae4b897003fec6d48c70f890 Author: Translation commit bot <translation(a)torproject.org> Date: Sat Oct 18 20:15:53 2014 +0000 Update translations for tails-misc --- af.po | 34 +++++++++++++++++----------------- 1 file changed, 17 insertions(+), 17 deletions(-) diff --git a/af.po b/af.po index a249139..5772078 100644 --- a/af.po +++ b/af.po @@ -7,8 +7,8 @@ msgid "" msgstr "" "Project-Id-Version: The Tor Project\n" "Report-Msgid-Bugs-To: \n" -"POT-Creation-Date: 2014-10-10 13:00+0200\n" -"PO-Revision-Date: 2014-10-11 08:52+0000\n" +"POT-Creation-Date: 2014-10-15 17:57+0200\n" +"PO-Revision-Date: 2014-10-18 20:10+0000\n" "Last-Translator: runasand <runa.sandvik(a)gmail.com>\n" "Language-Team: Afrikaans (http://www.transifex.com/projects/p/torproject/language/af/)\n" "MIME-Version: 1.0\n" @@ -301,12 +301,12 @@ msgid "" msgstr "" #: config/chroot_local-includes/usr/local/bin/tails-upgrade-frontend-wrapper:19 -#: config/chroot_local-includes/usr/local/sbin/unsafe-browser:60 +#: config/chroot_local-includes/usr/local/sbin/unsafe-browser:62 msgid "error:" msgstr "" #: config/chroot_local-includes/usr/local/bin/tails-upgrade-frontend-wrapper:20 -#: config/chroot_local-includes/usr/local/sbin/unsafe-browser:61 +#: config/chroot_local-includes/usr/local/sbin/unsafe-browser:63 msgid "Error" msgstr "" @@ -356,63 +356,63 @@ msgstr "" msgid "Cancel" msgstr "Kanselleer" -#: config/chroot_local-includes/usr/local/sbin/unsafe-browser:71 +#: config/chroot_local-includes/usr/local/sbin/unsafe-browser:73 msgid "Do you really want to launch the Unsafe Browser?" msgstr "" -#: config/chroot_local-includes/usr/local/sbin/unsafe-browser:73 +#: config/chroot_local-includes/usr/local/sbin/unsafe-browser:75 msgid "" "Network activity within the Unsafe Browser is <b>not anonymous</b>. Only use" " the Unsafe Browser if necessary, for example if you have to login or " "register to activate your Internet connection." msgstr "" -#: config/chroot_local-includes/usr/local/sbin/unsafe-browser:74 +#: config/chroot_local-includes/usr/local/sbin/unsafe-browser:76 msgid "_Launch" msgstr "" -#: config/chroot_local-includes/usr/local/sbin/unsafe-browser:75 +#: config/chroot_local-includes/usr/local/sbin/unsafe-browser:77 msgid "_Exit" msgstr "" -#: config/chroot_local-includes/usr/local/sbin/unsafe-browser:85 +#: config/chroot_local-includes/usr/local/sbin/unsafe-browser:87 msgid "Starting the Unsafe Browser..." msgstr "" -#: config/chroot_local-includes/usr/local/sbin/unsafe-browser:86 +#: config/chroot_local-includes/usr/local/sbin/unsafe-browser:88 msgid "This may take a while, so please be patient." msgstr "" -#: config/chroot_local-includes/usr/local/sbin/unsafe-browser:104 +#: config/chroot_local-includes/usr/local/sbin/unsafe-browser:106 msgid "Failed to setup chroot." msgstr "" -#: config/chroot_local-includes/usr/local/sbin/unsafe-browser:184 +#: config/chroot_local-includes/usr/local/sbin/unsafe-browser:180 #: ../config/chroot_local-includes/usr/share/applications/unsafe-browser.desktop.in.h:1 msgid "Unsafe Browser" msgstr "" -#: config/chroot_local-includes/usr/local/sbin/unsafe-browser:240 +#: config/chroot_local-includes/usr/local/sbin/unsafe-browser:236 msgid "Shutting down the Unsafe Browser..." msgstr "" -#: config/chroot_local-includes/usr/local/sbin/unsafe-browser:241 +#: config/chroot_local-includes/usr/local/sbin/unsafe-browser:237 msgid "" "This may take a while, and you may not restart the Unsafe Browser until it " "is properly shut down." msgstr "" -#: config/chroot_local-includes/usr/local/sbin/unsafe-browser:253 +#: config/chroot_local-includes/usr/local/sbin/unsafe-browser:249 msgid "Failed to restart Tor." msgstr "" -#: config/chroot_local-includes/usr/local/sbin/unsafe-browser:261 +#: config/chroot_local-includes/usr/local/sbin/unsafe-browser:257 msgid "" "Another Unsafe Browser is currently running, or being cleaned up. Please " "retry in a while." msgstr "" -#: config/chroot_local-includes/usr/local/sbin/unsafe-browser:274 +#: config/chroot_local-includes/usr/local/sbin/unsafe-browser:270 msgid "" "No DNS server was obtained through DHCP or manually configured in " "NetworkManager."

1 0

[translation/torbutton-torbuttonproperties] Update translations for torbutton-torbuttonproperties
by translation＠torproject.org 18 Oct '14

18 Oct '14

commit 6b3ae0511fb4e55f5613640b668a720b931b9ac6 Author: Translation commit bot <translation(a)torproject.org> Date: Sat Oct 18 19:45:52 2014 +0000 Update translations for torbutton-torbuttonproperties --- af/torbutton.properties | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/af/torbutton.properties b/af/torbutton.properties index d23c67d..0154401 100644 --- a/af/torbutton.properties +++ b/af/torbutton.properties @@ -34,9 +34,9 @@ torbutton.popup.captcha.ask = Torbutton detected a Google Captcha. Would you lik torbutton.popup.captcha.always = Always perform this action from now on torbutton.popup.redirect = Redirect torbutton.popup.no_redirect = Don't Redirect -torbutton.popup.prompted_language = To give you more privacy, Torbutton can request the English language version of web pages. This may cause web pages that you prefer to read in your native language to display in English instead.\n\nWould you like to request English language web pages for better privacy? +torbutton.popup.prompted_language = Om jou meer privaatheid te gee, kan Torbutton die Engelse weergawe van die web bladsye versoek . Dit kan veroorsaak dat web bladsye wat jy verkies om in jou moedertaal te lees, in Engels vertoon sal word.\n\nWil jy die Engelse web bladsye versoek vir beter privaatheid? torbutton.popup.no_newnym = Torbutton cannot safely give you a new identity. It does not have access to the Tor Control Port.\n\nAre you running Tor Browser Bundle? -torbutton.popup.use_tbb = It appears that you are using Torbutton with Firefox, which is no longer a recommended safe configuration.\n\nInstead, we recommend that you obtain the latest Tor Browser Bundle by sending email to gettor(a)torproject.org or by downloading it at the following URL: +torbutton.popup.use_tbb = Dit lyk of jy Torbutton met Firefox gebruik, wat nie meer 'n veilige opstel is nie.\n\nIn plaas daarvan, beveel ons aan dat jy die nuutste Tor Browser Bundel kry deur n e-pos aan gettor(a)torproject.org te stuur of om dit by die volgende URL af te laai : torbutton.popup.pref_error = Torbutton cannot update preferences in the Tor Browser profile directory. torbutton.popup.permission_denied = Please either reset the permissions of the Tor Browser directory or copy it to a new location. torbutton.popup.device_full = The disk appears to be full. Please free up space or move Tor Browser to a new device.

1 0

[translation/tails-misc] Update translations for tails-misc
by translation＠torproject.org 18 Oct '14

18 Oct '14

commit 58a23a2f0deeab6dbee5f6a92bff0da4092e9d41 Author: Translation commit bot <translation(a)torproject.org> Date: Sat Oct 18 19:15:44 2014 +0000 Update translations for tails-misc --- uk.po | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/uk.po b/uk.po index e9afd36..29d8461 100644 --- a/uk.po +++ b/uk.po @@ -13,7 +13,7 @@ msgstr "" "Project-Id-Version: The Tor Project\n" "Report-Msgid-Bugs-To: \n" "POT-Creation-Date: 2014-10-15 17:57+0200\n" -"PO-Revision-Date: 2014-10-18 18:44+0000\n" +"PO-Revision-Date: 2014-10-18 18:50+0000\n" "Last-Translator: LinuxChata\n" "Language-Team: Ukrainian (http://www.transifex.com/projects/p/torproject/language/uk/)\n" "MIME-Version: 1.0\n"

1 0