January 2013 - tor-commits - lists.torproject.org

[flashproxy/master] Proxy ORPort to WebSocket.
by dcf＠torproject.org 30 Jan '13

30 Jan '13

commit fb9a61125ca148256d965fe875c3973a0998d7b3 Author: David Fifield <david(a)bamsoftware.com> Date: Mon Nov 26 01:44:39 2012 -0800 Proxy ORPort to WebSocket. --- websocket-transport/websocket-server.go | 49 +++++++++++++++++++++++++++++- 1 files changed, 47 insertions(+), 2 deletions(-) diff --git a/websocket-transport/websocket-server.go b/websocket-transport/websocket-server.go index 8b62b60..fcdcd7f 100644 --- a/websocket-transport/websocket-server.go +++ b/websocket-… [View More]

1 0

[flashproxy/master] Better to have BINDADDR=0.0.0.0 in ptserver.
by dcf＠torproject.org 30 Jan '13

30 Jan '13

commit 81432241e0b0659e781124787bf8c360bcef43dd Author: David Fifield <david(a)bamsoftware.com> Date: Mon Nov 26 04:07:43 2012 -0800 Better to have BINDADDR=0.0.0.0 in ptserver. --- websocket-transport/ptserver | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/websocket-transport/ptserver b/websocket-transport/ptserver index 5b74112..66807b9 100755 --- a/websocket-transport/ptserver +++ b/websocket-transport/ptserver @@ -4,7 +4,7 @@ export … [View More]

1 0

[flashproxy/master] Add ServerTransportPlugin line to README.
by dcf＠torproject.org 30 Jan '13

30 Jan '13

commit ded9ed61325a5ba7041b8522572bb7bbbd0a82a3 Author: David Fifield <david(a)bamsoftware.com> Date: Mon Nov 26 04:08:30 2012 -0800 Add ServerTransportPlugin line to README. --- websocket-transport/README | 2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/websocket-transport/README b/websocket-transport/README index 4d813f4..fedde17 100644 --- a/websocket-transport/README +++ b/websocket-transport/README @@ -2,6 +2,8 @@ ClientTransportPlugin websocket exec .… [View More]

1 0

[flashproxy/master] Add --port option to websocket-server.
by dcf＠torproject.org 30 Jan '13

30 Jan '13

commit a3edf9fd1d9e92120a84e5d8473c6e850afcd31f Author: David Fifield <david(a)bamsoftware.com> Date: Mon Nov 26 04:15:02 2012 -0800 Add --port option to websocket-server. --- websocket-transport/websocket-server.go | 6 +++++- 1 files changed, 5 insertions(+), 1 deletions(-) diff --git a/websocket-transport/websocket-server.go b/websocket-transport/websocket-server.go index 76c51d6..95fd0af 100644 --- a/websocket-transport/websocket-server.go +++ b/websocket-transport/… [View More]

1 0

[flashproxy/master] Increase MaxMessageSize to account for base64 overhead.
by dcf＠torproject.org 30 Jan '13

30 Jan '13

commit 62b5487ffb6a9b01d10c2d40e6edf37cf89e4f77 Author: David Fifield <david(a)bamsoftware.com> Date: Mon Nov 26 04:17:11 2012 -0800 Increase MaxMessageSize to account for base64 overhead. --- websocket-transport/websocket-server.go | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/websocket-transport/websocket-server.go b/websocket-transport/websocket-server.go index 95fd0af..90a2a8d 100644 --- a/websocket-transport/websocket-server.go +++ b/websocket-… [View More]

1 0

[flashproxy/master] Return EOF when reading a close frame.
by dcf＠torproject.org 30 Jan '13

30 Jan '13

commit a6dde961e9c807445ab7f38021cca491ab9cf539 Author: David Fifield <david(a)bamsoftware.com> Date: Mon Nov 26 04:10:34 2012 -0800 Return EOF when reading a close frame. --- websocket-transport/websocket.go | 4 ++++ 1 files changed, 4 insertions(+), 0 deletions(-) diff --git a/websocket-transport/websocket.go b/websocket-transport/websocket.go index 7dc1a7e..e401640 100644 --- a/websocket-transport/websocket.go +++ b/websocket-transport/websocket.go @@ -135,6 +135,10 @@ … [View More]

1 0

[flashproxy/master] Add "make install" target to websocket-transport.
by dcf＠torproject.org 30 Jan '13

30 Jan '13

commit 2b9df0fe490291bcdf6d8abb45f3812e6b334360 Author: David Fifield <david(a)bamsoftware.com> Date: Mon Nov 26 21:11:50 2012 -0800 Add "make install" target to websocket-transport. --- websocket-transport/Makefile | 9 ++++++++- 1 files changed, 8 insertions(+), 1 deletions(-) diff --git a/websocket-transport/Makefile b/websocket-transport/Makefile index f144c4a..208569d 100644 --- a/websocket-transport/Makefile +++ b/websocket-transport/Makefile @@ -1,3 +1,6 @@ +PREFIX = /… [View More]

1 0

[flashproxy/master] rm websockify patch and init script.
by dcf＠torproject.org 30 Jan '13

30 Jan '13

commit 9874c4b92efb217221db328a1ad7e45bba4bc15c Author: David Fifield <david(a)bamsoftware.com> Date: Mon Nov 26 21:05:49 2012 -0800 rm websockify patch and init script. --- init.d/websockify | 62 ------------------------------- patches/websockify-binary-default.patch | 40 -------------------- 2 files changed, 0 insertions(+), 102 deletions(-) diff --git a/init.d/websockify b/init.d/websockify deleted file mode 100755 index 22a5450..0000000 --- a/init.… [View More]d/websockify +++ /dev/null @@ -1,62 +0,0 @@ -#!/bin/sh -# -# websockify This shell script takes care of starting and stopping -# the websockify server. -# -# chkconfig: 2345 90 10 -# description: websockify server. -# processname: websockify -# pidfile: /var/websockify/websockify.pid - -# Installation instructions: -# cp init.d/websockify /etc/init.d/websockify -# chkconfig --add websockify -# service websockify start - -# Source function library. -. /etc/rc.d/init.d/functions - -BINDIR=/usr/local/bin -VARDIR=/var/websockify -WEBSOCKIFY=$BINDIR/websockify -WEBSOCKIFY_PORT=9901 -LOCAL_ADDRESS=127.0.0.1:9001 -PIDFILE=$VARDIR/websockify.pid -USER=websockify - -# See how we were called. -case "$1" in - start) - [ -x $WEBSOCKIFY ] || exit 1 - echo -n $"Starting websockify server: " - cd $VARDIR && daemon --user "$USER" --pidfile $PIDFILE "$WEBSOCKIFY" :"$WEBSOCKIFY_PORT" "$LOCAL_ADDRESS" - RETVAL=$? - echo - [ $RETVAL -eq 0 ] && touch /var/lock/subsys/websockify - ;; - stop) - # Stop daemon. - echo -n $"Shutting down websockify server: " - killproc websockify - RETVAL=$? - echo - [ $RETVAL -eq 0 ] && rm -f /var/lock/subsys/websockify - ;; - status) - status websockify - RETVAL=$? - ;; - restart|reload) - $0 stop - $0 start - ;; - condrestart) - [ -f /var/lock/subsys/websockify ] && restart || : - ;; - *) - echo $"Usage: $0 {start|stop|status|restart}" - RETVAL=3 - ;; -esac - -exit $RETVAL diff --git a/patches/websockify-binary-default.patch b/patches/websockify-binary-default.patch deleted file mode 100644 index bb7a469..0000000 --- a/patches/websockify-binary-default.patch +++ /dev/null @@ -1,40 +0,0 @@ -From dc3a5f38d9921aa3cd128744ab3be5e6cfb7ff48 Mon Sep 17 00:00:00 2001 -From: David Fifield <david(a)bamsoftware.com> -Date: Sun, 22 Jul 2012 20:52:47 -0700 -Subject: [PATCH] Assume binary transfer when no subprotocol is given. - ---- - websocket.py | 8 ++------ - 1 file changed, 2 insertions(+), 6 deletions(-) - -diff --git a/websocket.py b/websocket.py -index 96156b9..7a42ff6 100644 ---- a/websocket.py -+++ b/websocket.py -@@ -585,12 +585,10 @@ Sec-WebSocket-Accept: %s\r - key = h['Sec-WebSocket-Key'] - - # Choose binary if client supports it -- if 'binary' in protocols: -- self.base64 = False -- elif 'base64' in protocols: -+ if 'base64' in protocols: - self.base64 = True - else: -- raise self.EClose("Client must support 'binary' or 'base64' protocol") -+ self.base64 = False - - # Generate the hash value for the accept header - accept = b64encode(sha1(s2b(key + self.GUID)).digest()) -@@ -598,8 +596,6 @@ Sec-WebSocket-Accept: %s\r - response = self.server_handshake_hybi % b2s(accept) - if self.base64: - response += "Sec-WebSocket-Protocol: base64\r\n" -- else: -- response += "Sec-WebSocket-Protocol: binary\r\n" - response += "\r\n" - - else: --- -1.7.10.4 - [View Less]

1 0

[flashproxy/master] Capitalization for scope.
by dcf＠torproject.org 30 Jan '13

30 Jan '13

commit 6553c94c3132e22f09bbf8ddb2d806be6cbc0514 Author: David Fifield <david(a)bamsoftware.com> Date: Mon Nov 26 21:24:42 2012 -0800 Capitalization for scope. --- websocket-transport/pt.go | 88 +++++++++++++++--------------- websocket-transport/socks.go | 12 ++-- websocket-transport/websocket-client.go | 18 +++--- websocket-transport/websocket-server.go | 20 ++++---- websocket-transport/websocket.go | 36 ++++++------ 5 files changed, … [View More]87 insertions(+), 87 deletions(-) diff --git a/websocket-transport/pt.go b/websocket-transport/pt.go index e63dd6a..f8760d3 100644 --- a/websocket-transport/pt.go +++ b/websocket-transport/pt.go @@ -12,7 +12,7 @@ import ( func getenvRequired(key string) string { value := os.Getenv(key) if value == "" { - ptEnvError(fmt.Sprintf("no %s environment variable", key)) + PtEnvError(fmt.Sprintf("no %s environment variable", key)) } return value } @@ -35,7 +35,7 @@ func escape(s string) string { return buf.String() } -func ptLine(keyword string, v ...string) { +func PtLine(keyword string, v ...string) { var buf bytes.Buffer buf.WriteString(keyword) for _, x := range v { @@ -44,22 +44,22 @@ func ptLine(keyword string, v ...string) { fmt.Println(buf.String()) } -func ptEnvError(msg string) { - ptLine("ENV-ERROR", msg) +func PtEnvError(msg string) { + PtLine("ENV-ERROR", msg) os.Exit(1) } -func ptVersionError(msg string) { - ptLine("VERSION-ERROR", msg) +func PtVersionError(msg string) { + PtLine("VERSION-ERROR", msg) os.Exit(1) } -func ptCmethodError(methodName, msg string) { - ptLine("CMETHOD-ERROR", methodName, msg) +func PtCmethodError(methodName, msg string) { + PtLine("CMETHOD-ERROR", methodName, msg) os.Exit(1) } -func ptGetManagedTransportVer() string { +func PtGetManagedTransportVer() string { const transportVersion = "1" for _, offered := range strings.Split(getenvRequired("TOR_PT_MANAGED_TRANSPORT_VER"), ",") { if offered == transportVersion { @@ -69,7 +69,7 @@ func ptGetManagedTransportVer() string { return "" } -func ptGetClientTransports(supported []string) []string { +func PtGetClientTransports(supported []string) []string { clientTransports := getenvRequired("TOR_PT_CLIENT_TRANSPORTS") if clientTransports == "*" { return supported @@ -86,42 +86,42 @@ func ptGetClientTransports(supported []string) []string { return result } -func ptCmethod(name string, socks string, addr net.Addr) { - ptLine("CMETHOD", name, socks, addr.String()) +func PtCmethod(name string, socks string, addr net.Addr) { + PtLine("CMETHOD", name, socks, addr.String()) } -func ptCmethodsDone() { - ptLine("CMETHODS", "DONE") +func PtCmethodsDone() { + PtLine("CMETHODS", "DONE") } -func ptClientSetup(methodNames []string) []string { - ver := ptGetManagedTransportVer() +func PtClientSetup(methodNames []string) []string { + ver := PtGetManagedTransportVer() if ver == "" { - ptVersionError("no-version") + PtVersionError("no-version") } else { - ptLine("VERSION", ver) + PtLine("VERSION", ver) } - methods := ptGetClientTransports(methodNames) + methods := PtGetClientTransports(methodNames) if len(methods) == 0 { - ptCmethodsDone() + PtCmethodsDone() os.Exit(1) } return methods } -func ptSmethodError(methodName, msg string) { - ptLine("SMETHOD-ERROR", methodName, msg) +func PtSmethodError(methodName, msg string) { + PtLine("SMETHOD-ERROR", methodName, msg) os.Exit(1) } -func ptSmethod(name string, addr net.Addr) { - ptLine("SMETHOD", name, addr.String()) +func PtSmethod(name string, addr net.Addr) { + PtLine("SMETHOD", name, addr.String()) } -func ptSmethodsDone() { - ptLine("SMETHODS", "DONE") +func PtSmethodsDone() { + PtLine("SMETHODS", "DONE") } func resolveBindAddr(bindAddr string) (*net.TCPAddr, error) { @@ -140,13 +140,13 @@ func resolveBindAddr(bindAddr string) (*net.TCPAddr, error) { return net.ResolveTCPAddr("tcp", bindAddr) } -type ptBindAddr struct { +type PtBindAddr struct { MethodName string Addr *net.TCPAddr } -func filterBindAddrs(addrs []ptBindAddr, supported []string) []ptBindAddr { - var result []ptBindAddr +func filterBindAddrs(addrs []PtBindAddr, supported []string) []PtBindAddr { + var result []PtBindAddr for _, ba := range addrs { for _, methodName := range supported { @@ -163,22 +163,22 @@ func filterBindAddrs(addrs []ptBindAddr, supported []string) []ptBindAddr { // Return a map from method names to bind addresses. The map is the contents of // TOR_PT_SERVER_BINDADDR, with keys filtered by TOR_PT_SERVER_TRANSPORTS, and // further filtered by methods that we know. -func ptGetServerBindAddrs(supported []string) []ptBindAddr { - var result []ptBindAddr +func PtGetServerBindAddrs(supported []string) []PtBindAddr { + var result []PtBindAddr // Get the list of all requested bindaddrs. var serverBindAddr = getenvRequired("TOR_PT_SERVER_BINDADDR") for _, spec := range strings.Split(serverBindAddr, ",") { - var bindAddr ptBindAddr + var bindAddr PtBindAddr parts := strings.SplitN(spec, "-", 2) if len(parts) != 2 { - ptEnvError(fmt.Sprintf("TOR_PT_SERVER_BINDADDR: %q: doesn't contain \"-\"", spec)) + PtEnvError(fmt.Sprintf("TOR_PT_SERVER_BINDADDR: %q: doesn't contain \"-\"", spec)) } bindAddr.MethodName = parts[0] addr, err := resolveBindAddr(parts[1]) if err != nil { - ptEnvError(fmt.Sprintf("TOR_PT_SERVER_BINDADDR: %q: %s", spec, err.Error())) + PtEnvError(fmt.Sprintf("TOR_PT_SERVER_BINDADDR: %q: %s", spec, err.Error())) } bindAddr.Addr = addr result = append(result, bindAddr) @@ -196,31 +196,31 @@ func ptGetServerBindAddrs(supported []string) []ptBindAddr { return result } -type ptServerInfo struct { - BindAddrs []ptBindAddr +type PtServerInfo struct { + BindAddrs []PtBindAddr OrAddr *net.TCPAddr } -func ptServerSetup(methodNames []string) ptServerInfo { - var info ptServerInfo +func PtServerSetup(methodNames []string) PtServerInfo { + var info PtServerInfo var err error - ver := ptGetManagedTransportVer() + ver := PtGetManagedTransportVer() if ver == "" { - ptVersionError("no-version") + PtVersionError("no-version") } else { - ptLine("VERSION", ver) + PtLine("VERSION", ver) } var orPort = getenvRequired("TOR_PT_ORPORT") info.OrAddr, err = net.ResolveTCPAddr("tcp", orPort) if err != nil { - ptEnvError(fmt.Sprintf("cannot resolve TOR_PT_ORPORT %q: %s", orPort, err.Error())) + PtEnvError(fmt.Sprintf("cannot resolve TOR_PT_ORPORT %q: %s", orPort, err.Error())) } - info.BindAddrs = ptGetServerBindAddrs(methodNames) + info.BindAddrs = PtGetServerBindAddrs(methodNames) if len(info.BindAddrs) == 0 { - ptSmethodsDone() + PtSmethodsDone() os.Exit(1) } diff --git a/websocket-transport/socks.go b/websocket-transport/socks.go index 33df918..061869e 100644 --- a/websocket-transport/socks.go +++ b/websocket-transport/socks.go @@ -16,7 +16,7 @@ const ( socksRequestFailed = 0x5b ) -func readSocks4aConnect(s io.Reader) (string, error) { +func ReadSocks4aConnect(s io.Reader) (string, error) { r := bufio.NewReader(s) var h [8]byte @@ -57,7 +57,7 @@ func readSocks4aConnect(s io.Reader) (string, error) { return fmt.Sprintf("%s:%d", host, port), nil } -func sendSocks4aResponse(w io.Writer, code byte, addr *net.TCPAddr) error { +func SendSocks4aResponse(w io.Writer, code byte, addr *net.TCPAddr) error { var resp [8]byte resp[0] = socksResponseVersion resp[1] = code @@ -73,10 +73,10 @@ func sendSocks4aResponse(w io.Writer, code byte, addr *net.TCPAddr) error { var emptyAddr = net.TCPAddr{net.IPv4(0, 0, 0, 0), 0} -func sendSocks4aResponseGranted(w io.Writer, addr *net.TCPAddr) error { - return sendSocks4aResponse(w, socksRequestGranted, addr) +func SendSocks4aResponseGranted(w io.Writer, addr *net.TCPAddr) error { + return SendSocks4aResponse(w, socksRequestGranted, addr) } -func sendSocks4aResponseFailed(w io.Writer) error { - return sendSocks4aResponse(w, socksRequestFailed, &emptyAddr) +func SendSocks4aResponseFailed(w io.Writer) error { + return SendSocks4aResponse(w, socksRequestFailed, &emptyAddr) } diff --git a/websocket-transport/websocket-client.go b/websocket-transport/websocket-client.go index 7e483f6..a8d437b 100644 --- a/websocket-transport/websocket-client.go +++ b/websocket-transport/websocket-client.go @@ -97,9 +97,9 @@ func handleConnection(conn *net.TCPConn) error { }() conn.SetDeadline(time.Now().Add(socksTimeout * time.Second)) - dest, err := readSocks4aConnect(conn) + dest, err := ReadSocks4aConnect(conn) if err != nil { - sendSocks4aResponseFailed(conn) + SendSocks4aResponseFailed(conn) return err } // Disable deadline. @@ -109,20 +109,20 @@ func handleConnection(conn *net.TCPConn) error { // We need the parsed IP and port for the SOCKS reply. destAddr, err := net.ResolveTCPAddr("tcp", dest) if err != nil { - sendSocks4aResponseFailed(conn) + SendSocks4aResponseFailed(conn) return err } wsUrl := url.URL{Scheme: "ws", Host: dest} ws, err := websocket.Dial(wsUrl.String(), "", wsUrl.String()) if err != nil { - sendSocks4aResponseFailed(conn) + SendSocks4aResponseFailed(conn) return err } defer ws.Close() logDebug("WebSocket connection to %s", ws.Config().Location.String()) - sendSocks4aResponseGranted(conn, destAddr) + SendSocks4aResponseGranted(conn, destAddr) proxy(conn, ws) @@ -176,18 +176,18 @@ func main() { socksAddrStrs = defaultSocksAddrStrs } - ptClientSetup([]string{ptMethodName}) + PtClientSetup([]string{ptMethodName}) listeners := make([]*net.TCPListener, 0) for _, socksAddrStr := range socksAddrStrs { ln, err := startListener(socksAddrStr) if err != nil { - ptCmethodError(ptMethodName, err.Error()) + PtCmethodError(ptMethodName, err.Error()) } - ptCmethod(ptMethodName, "socks4", ln.Addr()) + PtCmethod(ptMethodName, "socks4", ln.Addr()) listeners = append(listeners, ln) } - ptCmethodsDone() + PtCmethodsDone() var numHandlers int = 0 diff --git a/websocket-transport/websocket-server.go b/websocket-transport/websocket-server.go index 90a2a8d..aadd602 100644 --- a/websocket-transport/websocket-server.go +++ b/websocket-transport/websocket-server.go @@ -16,7 +16,7 @@ import ( var defaultPort int -var ptInfo ptServerInfo +var ptInfo PtServerInfo // When a connection handler starts, +1 is written to this channel; when it // ends, -1 is written. @@ -27,14 +27,14 @@ func logDebug(format string, v ...interface{}) { } type websocketConn struct { - Ws *websocket + Ws *Websocket Base64 bool messageBuf []byte } func (conn *websocketConn) Read(b []byte) (n int, err error) { for len(conn.messageBuf) == 0 { - var m websocketMessage + var m WebsocketMessage m, err = conn.Ws.ReadMessage() if err != nil { return @@ -112,7 +112,7 @@ func (conn *websocketConn) SetWriteDeadline(t time.Time) error { return conn.Ws.Conn.SetWriteDeadline(t) } -func NewWebsocketConn(ws *websocket) websocketConn { +func NewWebsocketConn(ws *Websocket) websocketConn { var conn websocketConn conn.Ws = ws conn.Base64 = (ws.Subprotocol == "base64") @@ -147,7 +147,7 @@ func proxy(local *net.TCPConn, conn *websocketConn) { wg.Wait() } -func websocketHandler(ws *websocket) { +func websocketHandler(ws *Websocket) { conn := NewWebsocketConn(ws) handlerChan <- 1 @@ -170,7 +170,7 @@ func startListener(addr *net.TCPAddr) (*net.TCPListener, error) { return nil, err } go func() { - var config websocketConfig + var config WebsocketConfig config.Subprotocols = []string{"base64"} config.MaxMessageSize = 2500 http.Handle("/", config.Handler(websocketHandler)) @@ -188,7 +188,7 @@ func main() { flag.IntVar(&defaultPort, "port", 0, "port to listen on if unspecified by Tor") flag.Parse() - ptInfo = ptServerSetup([]string{ptMethodName}) + ptInfo = PtServerSetup([]string{ptMethodName}) listeners := make([]*net.TCPListener, 0) for _, bindAddr := range ptInfo.BindAddrs { @@ -200,12 +200,12 @@ func main() { ln, err := startListener(bindAddr.Addr) if err != nil { - ptSmethodError(bindAddr.MethodName, err.Error()) + PtSmethodError(bindAddr.MethodName, err.Error()) } - ptSmethod(bindAddr.MethodName, ln.Addr()) + PtSmethod(bindAddr.MethodName, ln.Addr()) listeners = append(listeners, ln) } - ptSmethodsDone() + PtSmethodsDone() var numHandlers int = 0 diff --git a/websocket-transport/websocket.go b/websocket-transport/websocket.go index e401640..cdb4b5d 100644 --- a/websocket-transport/websocket.go +++ b/websocket-transport/websocket.go @@ -15,19 +15,19 @@ import ( "strings" ) -type websocketConfig struct { +type WebsocketConfig struct { Subprotocols []string MaxMessageSize uint64 } -func (config *websocketConfig) maxMessageSize() uint64 { +func (config *WebsocketConfig) maxMessageSize() uint64 { if config.MaxMessageSize == 0 { return 64000 } return config.MaxMessageSize } -type websocket struct { +type Websocket struct { Conn net.Conn Bufrw *bufio.ReadWriter // Whether we are a client or a server implications for masking. @@ -37,17 +37,17 @@ type websocket struct { messageBuf bytes.Buffer } -type websocketFrame struct { +type WebsocketFrame struct { Fin bool Opcode byte Payload []byte } -func (frame *websocketFrame) IsControl() bool { +func (frame *WebsocketFrame) IsControl() bool { return (frame.Opcode & 0x08) != 0 } -type websocketMessage struct { +type WebsocketMessage struct { Opcode byte Payload []byte } @@ -58,7 +58,7 @@ func applyMask(payload []byte, maskKey [4]byte) { } } -func (ws *websocket) ReadFrame() (frame websocketFrame, err error) { +func (ws *Websocket) ReadFrame() (frame WebsocketFrame, err error) { var b byte err = binary.Read(ws.Bufrw, binary.BigEndian, &b) if err != nil { @@ -122,10 +122,10 @@ func (ws *websocket) ReadFrame() (frame websocketFrame, err error) { return frame, nil } -func (ws *websocket) ReadMessage() (message websocketMessage, err error) { +func (ws *Websocket) ReadMessage() (message WebsocketMessage, err error) { var opcode byte = 0 for { - var frame websocketFrame + var frame WebsocketFrame frame, err = ws.ReadFrame() if err != nil { return @@ -169,7 +169,7 @@ func (ws *websocket) ReadMessage() (message websocketMessage, err error) { } // Destructively masks payload in place if ws.IsClient. -func (ws *websocket) WriteFrame(opcode byte, payload []byte) (err error) { +func (ws *Websocket) WriteFrame(opcode byte, payload []byte) (err error) { if opcode >= 16 { err = errors.New(fmt.Sprintf("opcode %d is >= 16", opcode)) return @@ -212,7 +212,7 @@ func (ws *websocket) WriteFrame(opcode byte, payload []byte) (err error) { return } -func (ws *websocket) WriteMessage(opcode byte, payload []byte) (err error) { +func (ws *Websocket) WriteMessage(opcode byte, payload []byte) (err error) { return ws.WriteFrame(opcode, payload) } @@ -251,8 +251,8 @@ func httpError(w http.ResponseWriter, bufrw *bufio.ReadWriter, code int) { } type WebSocketHTTPHandler struct { - config *websocketConfig - websocketCallback func(*websocket) + Config *WebsocketConfig + WebsocketCallback func(*Websocket) } func (handler *WebSocketHTTPHandler) ServeHTTP(w http.ResponseWriter, req *http.Request) { @@ -319,11 +319,11 @@ func (handler *WebSocketHTTPHandler) ServeHTTP(w http.ResponseWriter, req *http. // 9. Optionally, a |Sec-WebSocket-Extensions| header field... // 10. Optionally, other header fields... - var ws websocket + var ws Websocket ws.Conn = conn ws.Bufrw = bufrw ws.IsClient = false - ws.MaxMessageSize = handler.config.MaxMessageSize + ws.MaxMessageSize = handler.Config.MaxMessageSize // See RFC 6455 section 4.2.2, item 5 for these steps. @@ -345,7 +345,7 @@ func (handler *WebSocketHTTPHandler) ServeHTTP(w http.ResponseWriter, req *http. // 5. Optionally, a |Sec-WebSocket-Protocol| header field, with a value // /subprotocol/ as defined in step 4 in Section 4.2.2. for _, clientProto := range clientProtocols { - for _, serverProto := range handler.config.Subprotocols { + for _, serverProto := range handler.Config.Subprotocols { if clientProto == serverProto { ws.Subprotocol = clientProto w.Header().Set("Sec-WebSocket-Protocol", clientProto) @@ -359,9 +359,9 @@ func (handler *WebSocketHTTPHandler) ServeHTTP(w http.ResponseWriter, req *http. bufrw.Flush() // Call the WebSocket-specific handler. - handler.websocketCallback(&ws) + handler.WebsocketCallback(&ws) } -func (config *websocketConfig) Handler(f func(*websocket)) http.Handler { +func (config *WebsocketConfig) Handler(f func(*Websocket)) http.Handler { return &WebSocketHTTPHandler{config, f} } [View Less]

1 0

[flashproxy/master] Return a struct from PtClientSetup for uniformity.
by dcf＠torproject.org 30 Jan '13

30 Jan '13

commit 4726fa6addb7c15758b8162cb740b5faa5829417 Author: David Fifield <david(a)bamsoftware.com> Date: Mon Nov 26 21:52:33 2012 -0800 Return a struct from PtClientSetup for uniformity. --- websocket-transport/pt.go | 16 ++++++++++++---- 1 files changed, 12 insertions(+), 4 deletions(-) diff --git a/websocket-transport/pt.go b/websocket-transport/pt.go index 8e74d13..ffc475e 100644 --- a/websocket-transport/pt.go +++ b/websocket-transport/pt.go @@ -150,10 +150,18 @@ func … [View More]

1 0