tor-commits October 2012

tor-commits@lists.torproject.org

20 participants
1288 discussions

r25849: {website} add delta airlines mag article. (website/trunk/press/en)
by Andrew Lewman 17 Oct '12

17 Oct '12

Author: phobos Date: 2012-10-17 20:10:15 +0000 (Wed, 17 Oct 2012) New Revision: 25849 Modified: website/trunk/press/en/inthemedia.wml Log: add delta airlines mag article. Modified: website/trunk/press/en/inthemedia.wml =================================================================== --- website/trunk/press/en/inthemedia.wml 2012-10-16 20:22:38 UTC (rev 25848) +++ website/trunk/press/en/inthemedia.wml 2012-10-17 20:10:15 UTC (rev 25849) @@ -32,6 +32,13 @@ <th>Topic</th> </tr> </thead> +<tr> +<td>2012 Oct</td> +<td>Delta Airlines Sky Magazine</td> +<td><a +href="http://deltaskymag.delta.com/Sky-Extras/Favorites/Hidden-in-Plain- +Sight.aspx">Hidden in Plain Sight</a></td> +</tr> <tr style="background-color: #e5e5e5;"> <td>2012 Sep 19</td> <td>infoBAE</td> @@ -265,7 +272,7 @@ href="http://www.cnn.com/2011/TECH/innovation/06/17/mesh.technology.revolution/in…">Starting a revolution with technology</a></td> </tr> -<tr> +<tr> <td>2011 June 12</td> <td>CNN: Tech</td> <td><a href="http://www.cnn.com/2011/TECH/web/06/11/hiding.online.identity/index.html">Wiping @@ -795,7 +802,8 @@ <tr style="background-color: #e5e5e5;"> <td>2007 Sep 10</td> <td>Wired</td> -<td> <a href="http://www.wired.com/politics/security/news/2007/09/embassy_hacks"> Rogue Nodes Turn Tor Anonymizer Into Eavesdropper's Paradise</a> Swedish computer security consultant Dan Egerstad monitored the traffic going through a Tor exit node he was running, then published unencrypted account and password information. Note that the better articles covering this event correctly indicate that this is not a security flaw or design problem with Tor - Tor provides anonymity, but does not encrypt anything going to or from an exit node. You must use SSL (https) while browsing to ensure end-to-end encryption. Also covered in <a href="http://www.theinquirer.net/en/inquirer/news/2007/09/10/tor-network-exposes-…"> The Inquirer</a>, <a href="http://www.infoworld.com/article/07/09/10/Security-researcher-intercepts-em…"> InfoWorld</a>, <a href="http://www.smh.com.au/articles/2007/11/12/1194766589 522.html?page=fullpage#contentSwap2">The Sydney Morning Herald</a>, <a href="http://www.securityfocus.com/news/11486">Security Focus</a>, <a href="http://arstechnica.com/news.ars/post/20070910-security-expert-used-tor-to-c…"> ars technica</a>, and many others. It was reported as early as August 31, 2007 on the <a href="http://blog.wired.com/27bstroke6/2007/08/embassy-e-mail-.html"> Wired Blog</a>, before Mr. Egerstad revealed that he had obtained the information via his Tor exit node. In the end, Mr. Egerstad was arrested, which was covered by <a href="http://www.theregister.co.uk/2007/11/15/tor_hacker_arrest/"> The Register</a>, <a href="http://www.smh.com.au/news/security/police-swoop-on-hacker-of-the-year/2007…"> The Sydney Morning Herald</a>, <a href="http://blogs.zdnet.com/Berlind/?p=900"> ZDNet</a>, and <a href="http://blog.wired.com/27bstroke6/2007/11/swedish-researc.html"> Wired Blog</a>.</td> +<td> <a href="http://www.wired.com/politics/security/news/2007/09/embassy_hacks"> Rogue Nodes Turn Tor Anonymizer Into Eavesdropper's Paradise</a> Swedish computer security consultant Dan Egerstad monitored the traffic going through a Tor exit node he was running, then published unencrypted account and password information. Note that the better articles covering this event correctly indicate that this is not a security flaw or design problem with Tor - Tor provides anonymity, but does not encrypt anything going to or from an exit node. You must use SSL (https) while browsing to ensure end-to-end encryption. Also covered in <a href="http://www.theinquirer.net/en/inquirer/news/2007/09/10/tor-network-exposes-…"> The Inquirer</a>, <a href="http://www.infoworld.com/article/07/09/10/Security-researcher-intercepts-em…"> InfoWorld</a>, <a href="http://www.smh.com.au/articles/2007/11/12/1194766589 522.html?page=fullpage# +contentSwap2">The Sydney Morning Herald</a>, <a href="http://www.securityfocus.com/news/11486">Security Focus</a>, <a href="http://arstechnica.com/news.ars/post/20070910-security-expert-used-tor-to-c…"> ars technica</a>, and many others. It was reported as early as August 31, 2007 on the <a href="http://blog.wired.com/27bstroke6/2007/08/embassy-e-mail-.html"> Wired Blog</a>, before Mr. Egerstad revealed that he had obtained the information via his Tor exit node. In the end, Mr. Egerstad was arrested, which was covered by <a href="http://www.theregister.co.uk/2007/11/15/tor_hacker_arrest/"> The Register</a>, <a href="http://www.smh.com.au/news/security/police-swoop-on-hacker-of-the-year/2007…"> The Sydney Morning Herald</a>, <a href="http://blogs.zdnet.com/Berlind/?p=900"> ZDNet</a>, and <a href="http://blog.wired.com/27bstroke6/2007/11/swedish-researc.html"> Wired Blog</a>.</td> </tr> <tr> <td>2007 Jul 27</td>

1 0

[flashproxy/master] Add ChangeLog starting at 0.8.
by dcf＠torproject.org 17 Oct '12

17 Oct '12

commit ff50773309d209e750c5a58b057ac33a7e91edf4 Author: David Fifield <david(a)bamsoftware.com> Date: Wed Oct 17 10:53:13 2012 -0700 Add ChangeLog starting at 0.8. --- ChangeLog | 5 +++++ 1 files changed, 5 insertions(+), 0 deletions(-) diff --git a/ChangeLog b/ChangeLog new file mode 100644 index 0000000..ce583e0 --- /dev/null +++ b/ChangeLog @@ -0,0 +1,5 @@ +Changes in version 0.8 + o The proxy badge does more intelligent parsing of the boolean "debug" + parameter. "0", "false", and other values are now interpreted as + false and do not activate debug mode. Formerly any non-empty value + was interpreted as true. Fixes bug 7110. Patch by Alexandre Allaire.

1 0

[flashproxy/master] Uniformity of formatting; change some comments.
by dcf＠torproject.org 17 Oct '12

17 Oct '12

commit 7a5af7d12ba6c907a12f92959771c05d218a90b5 Author: David Fifield <david(a)bamsoftware.com> Date: Wed Oct 17 10:48:15 2012 -0700 Uniformity of formatting; change some comments. --- proxy/flashproxy-test.js | 32 ++++++++++++++++---------------- proxy/flashproxy.js | 19 ++++++++++--------- 2 files changed, 26 insertions(+), 25 deletions(-) diff --git a/proxy/flashproxy-test.js b/proxy/flashproxy-test.js index f38182e..ba2b8a0 100755 --- a/proxy/flashproxy-test.js +++ b/proxy/flashproxy-test.js @@ -162,22 +162,22 @@ function test_parse_query_string() function test_get_query_param_boolean() { var TESTS = [ - {qs: "param=true", - expected: true}, - {qs: "param", - expected: true}, - {qs: "param=", - expected: true}, - {qs: "param=1", - expected: true}, - {qs: "param=0", - expected: false}, - {qs: "param=false", - expected: false}, - {qs: "param=unexpected", - expected: null}, - {qs: "pram=true", - expected: false}, + { qs: "param=true", + expected: true }, + { qs: "param", + expected: true }, + { qs: "param=", + expected: true }, + { qs: "param=1", + expected: true }, + { qs: "param=0", + expected: false }, + { qs: "param=false", + expected: false }, + { qs: "param=unexpected", + expected: null }, + { qs: "pram=true", + expected: false }, ]; announce("test_get_query_param_boolean"); diff --git a/proxy/flashproxy.js b/proxy/flashproxy.js index ec7d550..2078b69 100644 --- a/proxy/flashproxy.js +++ b/proxy/flashproxy.js @@ -7,10 +7,10 @@ * information from the facilitator. When this option is used, the facilitator * query is not done. The "relay" parameter must be given as well. * - * debug=<value> - * If set to true, 1, or present in the query string with no value, show - * verbose terminal-like output instead of the badge. To disable debug output, - * omit the debug parameter, or set it to false or 0. + * debug=0|1 + * If true, show verbose terminal-like output instead of the badge. The values + * "1", "true", and the empty string "" all enable debug mode. Any other value + * uses the normal badge display. * * facilitator=https://host:port/ * The URL of the facilitator CGI script. By default it is @@ -181,11 +181,12 @@ function build_url(scheme, host, port, path, params) { } /* Get a query string parameter and return it as a boolean, or return - default_val if param is not present in the query string. - Parameter values of "true", "1" and "" evalutate to true. - "false" and "0" evalutate to false. - Any other value evaluates to null. -*/ + default_val if param is not present in the query string. True values are "1", + "true", and "". False values are "0" and "false". Any other value causes the + function to return null (effectively false). + + The empty string is true so that URLs like http://example.com/?debug will + enable debug mode. */ function get_query_param_boolean(query, param, default_val) { var val;

1 0

[flashproxy/master] Patch for ticket #7110, adding a get_query_param_boolean() function.
by dcf＠torproject.org 17 Oct '12

17 Oct '12

commit 3001f18b435ee9192bb4538acbf646f3ae1e063b Author: Alexandre Allaire <aallai(a)functor.local> Date: Wed Oct 17 13:03:44 2012 -0400 Patch for ticket #7110, adding a get_query_param_boolean() function. --- proxy/flashproxy-test.js | 37 +++++++++++++++++++++++++++++++++++++ proxy/flashproxy.js | 32 +++++++++++++++++++++++++++----- 2 files changed, 64 insertions(+), 5 deletions(-) diff --git a/proxy/flashproxy-test.js b/proxy/flashproxy-test.js index 2dc185a..f38182e 100755 --- a/proxy/flashproxy-test.js +++ b/proxy/flashproxy-test.js @@ -159,6 +159,42 @@ function test_parse_query_string() } } +function test_get_query_param_boolean() +{ + var TESTS = [ + {qs: "param=true", + expected: true}, + {qs: "param", + expected: true}, + {qs: "param=", + expected: true}, + {qs: "param=1", + expected: true}, + {qs: "param=0", + expected: false}, + {qs: "param=false", + expected: false}, + {qs: "param=unexpected", + expected: null}, + {qs: "pram=true", + expected: false}, + ]; + + announce("test_get_query_param_boolean"); + for (var i = 0; i < TESTS.length; i++) { + var test = TESTS[i]; + var actual; + var query; + + query = parse_query_string(test.qs); + actual = get_query_param_boolean(query, "param", false); + if (objects_equal(actual, test.expected)) + pass(test.qs); + else + fail(test.qs, test.expected, actual); + } +} + function test_parse_addr_spec() { var TESTS = [ @@ -230,6 +266,7 @@ function test_get_query_param_addr() test_build_url(); test_parse_query_string(); +test_get_query_param_boolean(); test_parse_addr_spec(); test_get_query_param_addr(); diff --git a/proxy/flashproxy.js b/proxy/flashproxy.js index 327c9a5..ec7d550 100644 --- a/proxy/flashproxy.js +++ b/proxy/flashproxy.js @@ -7,9 +7,10 @@ * information from the facilitator. When this option is used, the facilitator * query is not done. The "relay" parameter must be given as well. * - * debug=1 - * If set (to any value), show verbose terminal-like output instead of the - * badge. + * debug=<value> + * If set to true, 1, or present in the query string with no value, show + * verbose terminal-like output instead of the badge. To disable debug output, + * omit the debug parameter, or set it to false or 0. * * facilitator=https://host:port/ * The URL of the facilitator CGI script. By default it is @@ -67,9 +68,10 @@ var RATE_LIMIT_HISTORY = 5.0; var WebSocket = window.WebSocket || window.MozWebSocket; var query = parse_query_string(window.location.search.substr(1)); +var DEBUG = get_query_param_boolean(query, "debug", false); var debug_div; -if (query.debug) { +if (DEBUG) { debug_div = document.createElement("pre"); debug_div.className = "debug"; } @@ -178,6 +180,26 @@ function build_url(scheme, host, port, path, params) { return parts.join(""); } +/* Get a query string parameter and return it as a boolean, or return + default_val if param is not present in the query string. + Parameter values of "true", "1" and "" evalutate to true. + "false" and "0" evalutate to false. + Any other value evaluates to null. +*/ +function get_query_param_boolean(query, param, default_val) { + var val; + + val = query[param]; + if (val === undefined) + return default_val; + else if (val === "true" || val === "1" || val === "") + return true; + else if (val === "false" || val === "0") + return false; + else + return null; +} + /* Get a query string parameter and return it as a string. Returns default_val if param is not defined in the query string. */ function get_query_param_string(query, param, default_val) { @@ -358,7 +380,7 @@ function make_websocket(addr) { } function FlashProxy() { - if (query.debug) { + if (DEBUG) { this.badge_elem = debug_div; } else { this.badge = new Badge();

1 0

[stem/master] Fix missing paranthesis
by atagar＠torproject.org 17 Oct '12

17 Oct '12

commit e33f55d57b100d9f2e6f697e849811b28cd3bcfb Author: Sathyanarayanan Gunasekaran <gsathya.ceg(a)gmail.com> Date: Wed Oct 17 17:54:35 2012 +0530 Fix missing paranthesis --- test/unit/tutorial.py | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/test/unit/tutorial.py b/test/unit/tutorial.py index 72ea28c..c2fcb25 100644 --- a/test/unit/tutorial.py +++ b/test/unit/tutorial.py @@ -63,7 +63,7 @@ class TestTutorial(unittest.TestCase): # prints the top fifteen relays count = 1 - for bw_value in sorted(bw_to_relay.keys(), reverse = True: + for bw_value in sorted(bw_to_relay.keys(), reverse = True): for nickname in bw_to_relay[bw_value]: expected_line = "%i. speedyexit (104590 bytes/s)" % count printed_line = "%i. %s (%i bytes/s)" % (count, nickname, bw_value)

1 0

[doctor/master] Temporarily remove urras from the list of bwauths.
by karsten＠torproject.org 17 Oct '12

17 Oct '12

commit f4b720e7f2886eea8a6eaf67c4b3ab7c75005078 Author: Karsten Loesing <karsten.loesing(a)gmx.net> Date: Wed Oct 17 10:49:48 2012 -0400 Temporarily remove urras from the list of bwauths. --- src/org/torproject/doctor/Checker.java | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/org/torproject/doctor/Checker.java b/src/org/torproject/doctor/Checker.java index 6bdf8f6..13dbc05 100644 --- a/src/org/torproject/doctor/Checker.java +++ b/src/org/torproject/doctor/Checker.java @@ -392,7 +392,7 @@ public class Checker { /* Check if any bandwidth scanner results are missing. */ private void checkBandwidthScanners() { SortedSet<String> missingBandwidthScanners = new TreeSet<String>( - Arrays.asList("turtles,urras,moria1,gabelmoo,maatuska". + Arrays.asList("turtles,moria1,gabelmoo,maatuska". split(","))); for (RelayNetworkStatusVote vote : this.downloadedVotes) { boolean containsMeasuredBandwidths = false;

1 0

[tor/master] Fix mal-merge, don't | END_CIRC_REASON_CHANNEL_CLOSED into reason codes in circuit_truncated()
by nickm＠torproject.org 17 Oct '12

17 Oct '12

commit 17442560c44e8093f9a67d7809ed799317d4d707 Author: Andrea Shepard <andrea(a)torproject.org> Date: Wed Oct 17 03:23:35 2012 -0700 Fix mal-merge, don't | END_CIRC_REASON_CHANNEL_CLOSED into reason codes in circuit_truncated() --- src/or/circuitbuild.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/src/or/circuitbuild.c b/src/or/circuitbuild.c index 9287084..b16dab2 100644 --- a/src/or/circuitbuild.c +++ b/src/or/circuitbuild.c @@ -3050,7 +3050,7 @@ circuit_truncated(origin_circuit_t *circ, crypt_path_t *layer, int reason) * just give up. */ circuit_mark_for_close(TO_CIRCUIT(circ), - END_CIRC_REASON_FLAG_REMOTE|END_CIRC_REASON_CHANNEL_CLOSED|reason); + END_CIRC_REASON_FLAG_REMOTE|reason); return 0; #if 0

1 0

[tor/master] Use LD_PROTOCOL rather than LD_BUG to warn about bogus reason codes that originated remotely in circuit_end_reason_to_control_string()
by nickm＠torproject.org 17 Oct '12

17 Oct '12

commit 35f573136da3c1b662114cfcc6369df1b5d7b98e Author: Andrea Shepard <andrea(a)torproject.org> Date: Wed Oct 17 03:24:28 2012 -0700 Use LD_PROTOCOL rather than LD_BUG to warn about bogus reason codes that originated remotely in circuit_end_reason_to_control_string() --- src/or/reasons.c | 20 ++++++++++++++++++-- 1 files changed, 18 insertions(+), 2 deletions(-) diff --git a/src/or/reasons.c b/src/or/reasons.c index a04cd86..874a867 100644 --- a/src/or/reasons.c +++ b/src/or/reasons.c @@ -300,8 +300,13 @@ errno_to_orconn_end_reason(int e) const char * circuit_end_reason_to_control_string(int reason) { - if (reason >= 0 && reason & END_CIRC_REASON_FLAG_REMOTE) + int is_remote = 0; + + if (reason >= 0 && reason & END_CIRC_REASON_FLAG_REMOTE) { reason &= ~END_CIRC_REASON_FLAG_REMOTE; + is_remote = 1; + } + switch (reason) { case END_CIRC_AT_ORIGIN: /* This shouldn't get passed here; it's a catch-all reason. */ @@ -338,7 +343,18 @@ circuit_end_reason_to_control_string(int reason) case END_CIRC_REASON_MEASUREMENT_EXPIRED: return "MEASUREMENT_EXPIRED"; default: - log_warn(LD_BUG, "Unrecognized reason code %d", (int)reason); + if (is_remote) { + /* + * If it's remote, it's not a bug *here*, so don't use LD_BUG, but + * do note that the someone we're talking to is speaking the Tor + * protocol with a weird accent. + */ + log_warn(LD_PROTOCOL, + "Remote server sent bogus reason code %d", reason); + } else { + log_warn(LD_BUG, + "Unrecognized reason code %d", reason); + } return NULL; } }

1 0

[tor/master] Add changes file for bug 7129
by nickm＠torproject.org 17 Oct '12

17 Oct '12

commit caa24a1f2de62bad56242526d15901e15593e3fd Author: Andrea Shepard <andrea(a)torproject.org> Date: Wed Oct 17 03:24:42 2012 -0700 Add changes file for bug 7129 --- changes/bug7129 | 6 ++++++ 1 files changed, 6 insertions(+), 0 deletions(-) diff --git a/changes/bug7129 b/changes/bug7129 new file mode 100644 index 0000000..d021623 --- /dev/null +++ b/changes/bug7129 @@ -0,0 +1,6 @@ + o Minor bugfixes: + - Fix mal-merge of channels that ORed END_CIRC_REASON_CHANNEL_CLOSED into + reason codes in circuit_truncated(). + - Fix unknown reason warning in circuit_end_reason_to_control_string() + to use LD_PROTOCOL rather than LD_BUG when the bad reason originated + elsewhere.

1 0

[tor/master] Remove changes/bug7129
by nickm＠torproject.org 17 Oct '12

17 Oct '12

commit 4164f481c81a6e3529821424e4a8ae044288b0ee Author: Nick Mathewson <nickm(a)torproject.org> Date: Wed Oct 17 09:49:36 2012 -0400 Remove changes/bug7129 Our convention is that we use the changelog to note release-to-release changes; we don't need to add changelog entries for bugs that didn't appear in any released version of Tor. (By convention, we sometimes say "this bug does not appear in any released version of Tor" or words to that effect in the commit message so that when Roger goes to make sure the changelog is right, he knows not to expect a changelog entry for that part.) --- changes/bug7129 | 6 ------ 1 files changed, 0 insertions(+), 6 deletions(-) diff --git a/changes/bug7129 b/changes/bug7129 deleted file mode 100644 index d021623..0000000 --- a/changes/bug7129 +++ /dev/null @@ -1,6 +0,0 @@ - o Minor bugfixes: - - Fix mal-merge of channels that ORed END_CIRC_REASON_CHANNEL_CLOSED into - reason codes in circuit_truncated(). - - Fix unknown reason warning in circuit_end_reason_to_control_string() - to use LD_PROTOCOL rather than LD_BUG when the bad reason originated - elsewhere.

1 0

Jump to page:

2025

2024

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

tor-commits October 2012