[tor-bugs] #23077 [Core Tor/Tor]: Channelpadding tests rely on actual time; can fail

[Tor Bug Tracker & Wiki]

#23077: Channelpadding tests rely on actual time; can fail
--------------------------------------+------------------------------------
 Reporter:  nickm                     |          Owner:  (none)
     Type:  defect                    |         Status:  new
 Priority:  Medium                    |      Milestone:  Tor: 0.3.1.x-final
Component:  Core Tor/Tor              |        Version:
 Severity:  Normal                    |     Resolution:
 Keywords:  unittest, channelpadding  |  Actual Points:
Parent ID:                            |         Points:
 Reviewer:                            |        Sponsor:
--------------------------------------+------------------------------------

Comment (by mikeperry):

 Is there a branch for what you tried?

 My guess is that the mocked time is messing with the timerwheel code and
 that we need to advance time in the timerwheel while waiting for the
 callback to fire. But this is just a guess..

 We could also boost this timeout value (the assignment to
 chan->next_padding_time_ms on line 399 and possibly elsewhere), but that
 will of course slow the tests down, since we actually wait for the
 callbacks...

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/23077#comment:2>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online