[tor-bugs] #23077 [Core Tor/Tor]: Channelpadding tests rely on actual time; can fail

[Tor Bug Tracker & Wiki]

#23077: Channelpadding tests rely on actual time; can fail
--------------------------------------+------------------------------------
 Reporter:  nickm                     |          Owner:  (none)
     Type:  defect                    |         Status:  new
 Priority:  Medium                    |      Milestone:  Tor: 0.3.1.x-final
Component:  Core Tor/Tor              |        Version:
 Severity:  Normal                    |     Resolution:
 Keywords:  unittest, channelpadding  |  Actual Points:
Parent ID:                            |         Points:
 Reviewer:                            |        Sponsor:
--------------------------------------+------------------------------------

Comment (by nickm):

 No branch; sorry.  I just used monotime_enable_test_mocking() at the start
 of the function, and made sure that the test function was running inside a
 TT_FORK

 Having the tests depend on actual time is really fragile and we should
 avoid it.  Not only does it slow down the tests, but there's _always_ a
 machine out there more slow than we had imagined.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/23077#comment:3>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online