[tor-bugs] #23077 [Core Tor/Tor]: Channelpadding tests rely on actual time; can fail

[Tor Bug Tracker & Wiki]

#23077: Channelpadding tests rely on actual time; can fail
--------------------------------------+------------------------------------
 Reporter:  nickm                     |          Owner:
     Type:  defect                    |         Status:  new
 Priority:  Medium                    |      Milestone:  Tor: 0.3.1.x-final
Component:  Core Tor/Tor              |        Version:
 Severity:  Normal                    |     Resolution:
 Keywords:  unittest, channelpadding  |  Actual Points:
Parent ID:                            |         Points:
 Reviewer:                            |        Sponsor:
--------------------------------------+------------------------------------

Comment (by nickm):

 I found an easy way to reproduce this.  Run the test in a loop, as in:
 {{{
 while ./src/test/test channelpadding/channelpadding_consensus  --verbose ;
 do true ; done
 }}}

 Then use Ctrl-Z to suspend the process, wait a second, and use `fg` to
 foreground the process. That will usually make the test fail, though
 sometimes I needed to try it a few times.

 I tried to fix this unit test with monotime_enable_test_mocking, but that
 makes the unit test freeze.

--
Ticket URL: <https://trac.torproject.org/projects/tor/ticket/23077#comment:1>
Tor Bug Tracker & Wiki <https://trac.torproject.org/>
The Tor Project: anonymity online