Hi Shondoit,
Thanks for taking time!
If you have a clean VM, with a default install of Windows 7, then please try it out and let me know. If you have a dirty Windows XP in the back of your closet, try it out as well. I'd love to hear how it breaks and then improving it.
Would you be interested in the opposite? That is, a (slightly) dirty default install of Windows 7 (x64), and a clean VM with a default install of Windows XP SP3? Alternatively, I could install XP into a new partition on HDD, if you'd prefer.
Don't forget to set-up Git (git config [...]), clone torbrowser.git, add my personal repo, checkout 'personal-build'
Could you please expand on this? I haven't used Git via mingw and I don't much feel like taking the time to RTFM ;)
P.S. How would one go about using your work for profile build(s) to test benefits of something like [0,1]?
[0] #3978: "Better TBB about:config settings(?); re: browsing and loading speed, etc." https://trac.torproject.org/projects/tor/ticket/3978
[1] https://trac.torproject.org/projects/tor/attachment/ticket/3978/tbb-ff-pgo.p...
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
Hey John,
If you have a clean VM, with a default install of Windows 7, then please try it out and let me know. If you have a dirty Windows XP in the back of your closet, try it out as well. I'd love to hear how it breaks and then improving it.
Would you be interested in the opposite? That is, a (slightly) dirty default install of Windows 7 (x64), and a clean VM with a default install of Windows XP SP3? Alternatively, I could install XP into a new partition on HDD, if you'd prefer.
I'm interested in any testing. I would recommend VM's though so that you can roll back to a snapshot if something goes wrong.
Don't forget to set-up Git (git config [...]), clone torbrowser.git, add my personal repo, checkout 'personal-build'
Could you please expand on this? I haven't used Git via mingw and I don't much feel like taking the time to RTFM ;)
Git via mingw is pretty much the same as regular git. If you've never used Git before, I highly recommend to get the basics: http://gitref.org
After you start mingw do the following. Please try to understand what every command does.
# Setting up Git (Change name/email if needed) $ git config --global user.name "John Crain" $ git config --global user.email "johncrain@eml.cc"
# Set up TBB build folder $ mkdir /c/Build $ cd /c/Build $ git clone git://git.torproject.org/torbrowser.git $ cd torbrowser
# Add my personal repo and check out the 'personal-build' branch. $ git remote add shondoit git://git.torproject.org/user/shondoit/torbrowser.git $ git fetch shondoit $ git checkout -t shondoit/personal-build
# Start building... This will take a couple of hours. $ make -f build-scripts/windows.mk build-all-binaries bundle
P.S. How would one go about using your work for profile build(s) to test benefits of something like [0,1]?
[0] #3978: "Better TBB about:config settings(?); re: browsing and loading speed, etc." https://trac.torproject.org/projects/tor/ticket/3978 [1] https://trac.torproject.org/projects/tor/attachment/ticket/3978/tbb-ff-pgo.p...
I
would recommend checking out a new branch and working from there. $ git checkout -b bug3978 It seems that the torbrowser source has changed too much to successfully apply that patch, so I think it might be best to start from scratch and manually apply the changes. How to go from there, I'm not sure.
It's best to start with a clean build first and verify that you can succesfuly build a normal TBB. Only then start with changing settings. If you have any questions about building or changing things you can join #tor-dev on irc.oftc.net and ask your question there. There are more people that can help you there, and I'll be on as well.
Good luck,
Regards,
Shondoit
Hello Shondoit,
So far so good, Tor is built and running, however, I did get one build error wrt Firefox 12.0, and it's one I'm unsure how to fix. Vidalia was not built, I assume that's due to the Firefox error stopping the build process.
Qt needs to be installed /after/ tbb-build finished completely. Don't forget to set-up Git (git config [...]), clone torbrowser.git, add my personal repo, checkout 'personal-build' And then the following should Just Work*?*: $ make -f build-scripts/windows.mk build-all-binaries bundle
Here's the build issue I haven't yet resolved:
$ mv: cannot move '/home/USERNAME/torbrowser/build-scripts/build-alpha-windows/build/firefox-12.0': Persmission denied $ make: *** [/home/USERNAME/torbrowser/build-scripts/build-alpha-windows/build/firefox-12.0] Error 1
Issues I was able to resolve:
1) I had to set QTcore4.dll PATH environment variable, I used system PATHs "C:\Qt\4.8.1;C:\Qt\4.8.1\bin". Otherwise, po2ts.exe complained about missing QTcore4.dll. Please see this on-topic Vidalia bug report: https://trac-vidalia.torproject.org/projects/vidalia/ticket/488
2) The zlib version you hard-coded (1.2.6) is out of date, and thus the download is 404ing. I edited versions.mk and versions-alpha.mk for the most recent version 1.2.7 and zlib downloaded fine.
3) I got an error while installing QT: "The installer could not find a valid C:\MinGW\include\w32api.h (Only versions with W32API 3.13 are supported)". I didn't do anything to fix this error. I'm on 64 bit, if that matters.
4) Running your 'make -f build...' command (from the above quote) from C:\MinGW\msys\1.0\home\USERNAME\torbrowser gives the the following error. So, I had to cd into /build-scripts/ and then run 'make -f windows.mk...'
$ make -f build-scripts/windows.mk build-all-binaries bundle $ build-scripts/windows.mk:57: /home/USERNAME/torbrowser/versions.mk: No such file or directory $ make: *** No rule to make target '/home/USERNAME/torbrowser/versions.mk'. stop
P.S. I hammered together your personal-build repo, with torbrowser.git [0], using TortoiseGit. But that's inefficient and clumsy. I tried many ways to 'add' your personal-build repo using msysGit, following your directions I quoted above, but I always failed. Could you please e-mail a quick and dirty step-by-step for using msysGit wrt your personal-build repo? E.g., #1. $git clone torbrowser.git..., #2. $git add shondoit's_personal-build..., #3. $git checkout... ?
I only had success after fetching your personal-build [1], into \home\USERNAME\torbrowser, with TortoiseGit.
P.P.S. Because you wrote you want this tested on Windows XP, and I am currently unsure how to solve the build problem on Windows 7, I'm going to test your process on a fresh install of Windows XP SP3, on a clean VM (using VirutalBox). Hopefully, by the time I test on Windows XP, someone smarter than me can provide a solution for the above Firefox 12 build issue.
Thanks!
[0] https://git.torproject.org/torbrowser.git
[1] https://gitweb.torproject.org/user/shondoit/torbrowser.git/tree/personal-bui...
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1
Hey John,
$ mv: cannot move '/home/USERNAME/torbrowser/build-scripts/build-alpha-windows/build/firefox-12.0':
Persmission denied
$ make: *** [/home/USERNAME/torbrowser/build-scripts/build-alpha-windows/build/firefox-12.0]
Error 1 I'm not sure about this one. It might be a path length issue. It's hard to tell without the full log. The last two lines hardly give any context. Try what I sent in the previous mail ($ mkdir /c/Build) or if that doesn't help mail some more log/context.
- I had to set QTcore4.dll PATH environment variable 2) The zlib
version you hard-coded (1.2.6) is out of date
These issues indicate you're not using my personal-build branch, since both are fixed in that.
- I got an error while installing QT: "The installer could not
find a valid C:\MinGW\include\w32api.h (Only versions with W32API 3.13 are supported)". I didn't do anything to fix this error. I'm on 64 bit, if that matters.
This is a known issue with Qt, it's only a warning and everything works fine regardless. It's documented in ./build-scripts/INSTALL if I remember correctly.
- Running your 'make -f build...' command (from the above quote)
from C:\MinGW\msys\1.0\home\USERNAME\torbrowser gives the the following error. So, I had to cd into /build-scripts/ and then run 'make -f windows.mk...'
You can either cd into build-scripts or use -f build-scripts/windows.mk instead. I prefer the former. The problem was that I assumed the people testing it would be somewhat familiar with the build process. My mistake
P.S. I hammered together your personal-build repo, with torbrowser.git [0], using TortoiseGit. But that's inefficient and clumsy. I tried many ways to 'add' your personal-build repo using msysGit, following your directions I quoted above, but I always failed. Could you please e-mail a quick and dirty step-by-step for using msysGit wrt your personal-build repo? E.g., #1. $git clone torbrowser.git..., #2. $git add shondoit's_personal-build..., #3. $git checkout... ?
$ git remote add shondoit git://git.torproject.org/user/shondoit/torbrowser.git $ git checkout -t shondoit/personal-build But you got that from my last mail already.
P.P.S. Because you wrote you want this tested on Windows XP, and I am currently unsure how to solve the build problem on Windows 7, I'm going to test your process on a fresh install of Windows XP SP3, on a clean VM (using VirutalBox). Hopefully, by the time I test on Windows XP, someone smarter than me can provide a solution for the above Firefox 12 build issue.
For my personal gain I would love it if you did both, but I understand that you want to make it work first. No worries.
Regards,
Shondoit
-
John Crain -
Shondoit Walker