Re: [tor-dev] [PATCH] Log malformed hostnames in socks5 request respecting SafeLogging

On 24 Aug 2015, at 09:12, Andreas Stieger astieger@suse.com wrote:

Hello,

I found a warning-level message in socks5 code relating to malformed hostnames that did not respect the SafeLogging setting, breaking the rule of least surprise. Please review the attached simple patch.

Hi Andreas,

Thank you for submitting this patch - is there a corresponding Trac ticket? (Patches without Trac tickets can get lost easily.)

If there isn't a Trac ticket, feel free to log one, or I can log one for you if you'd like.

Tim

Tim Wilson-Brown (teor)

teor2345 at gmail dot com pgp 0xABFED1AC https://gist.github.com/teor2345/d033b8ce0a99adbc89c5

teor at blah dot im OTR D5BE4EC2 255D7585 F3874930 DB130265 7C9EBBC7