commit 084a99bd2e0ba6734ea2ad6029ab688372ed7818 Author: aagbsn aagbsn@extc.org Date: Mon Mar 30 14:28:36 2015 +0000

Do not reset timer when output is received

If the timer is reset upon output received, eventually OONI's built-in timer will fire and consider the the test a failure.

As demonstrated in the example code, the process is launched by a Measurement method. Long-running processes probably shouldn't be started inside Measurements, and it might make more sense to launch processes as part of the NetTest setUp method instead. --- ooni/templates/process.py | 1 - 1 file changed, 1 deletion(-)

diff --git a/ooni/templates/process.py b/ooni/templates/process.py index 5e187ee..2d62de1 100644 --- a/ooni/templates/process.py +++ b/ooni/templates/process.py @@ -51,7 +51,6 @@ class ProcessDirector(protocol.ProcessProtocol): self.transport.closeStdin()

def outReceived(self, data): - self.resetTimer() log.debug("STDOUT: %s" % data) self.stdout += data if self.shouldClose():