commit ed070ee78b2a3d0baed01158b669611646957d97 Author: Damian Johnson atagar@torproject.org Date: Sun Jan 6 22:48:59 2013 -0800

Skipping E251 (no spaces around keyword / parameter equals)

I got a little ways through switching us over to this one then stopped. It looks aweful and makes the code less readable. If Sean and Ravi both decide that they want this then fine - one of them can be the person to swap it over. --- test/check_whitespace.py | 8 ++++++++ 1 files changed, 8 insertions(+), 0 deletions(-)

diff --git a/test/check_whitespace.py b/test/check_whitespace.py index ba41190..d65c5b5 100644 --- a/test/check_whitespace.py +++ b/test/check_whitespace.py @@ -53,6 +53,14 @@ def pep8_issues(base_path = DEFAULT_TARGET): # # Pep8 only works with this one if we have four space indents (its # detection is based on multiples of four). + # + # * E251 no spaces around keyword / parameter equals + # + # This one I dislike a great deal. It makes keyword arguments different + # from assignments which looks... aweful. I'm not sure what PEP8's author + # was on when he wrote this one but it's stupid. + # + # Someone else can change this if they really care.

ignored_issues = "E111,E121,W293,E501,E302,E701,E251,E127"