commit 649104fdb950057288a5e7b48f402d563546b83b Author: Nick Mathewson nickm@torproject.org Date: Tue Aug 8 19:58:19 2017 -0400
Remove a needless memwipe.
The interior of ctx here is already wiped by crypto_digest_free(). This memwipe call only wiped the pointer itself, which isn't sensitive. --- src/common/crypto_ed25519.c | 1 - 1 file changed, 1 deletion(-)
diff --git a/src/common/crypto_ed25519.c b/src/common/crypto_ed25519.c index d61549b79..abf23c4b3 100644 --- a/src/common/crypto_ed25519.c +++ b/src/common/crypto_ed25519.c @@ -468,7 +468,6 @@ ed25519_keypair_from_curve25519_keypair(ed25519_keypair_t *out, tor_assert(fast_memeq(pubkey_check.pubkey, out->pubkey.pubkey, 32));
memwipe(&pubkey_check, 0, sizeof(pubkey_check)); - memwipe(&ctx, 0, sizeof(ctx)); memwipe(sha512_output, 0, sizeof(sha512_output));
return 0;
tor-commits@lists.torproject.org