commit a66fff6381abc5e3a70bd9cf3108560ed79f8d3e Author: Nick Mathewson nickm@torproject.org Date: Thu Aug 21 11:05:59 2014 -0400

Mark one use of networkstatus_check_document_signature as (void)

Also explain why we aren't checking its return value.

[CID 1198197] --- src/or/dirvote.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/src/or/dirvote.c b/src/or/dirvote.c index 6536b7f..cf6b88e 100644 --- a/src/or/dirvote.c +++ b/src/or/dirvote.c @@ -2273,8 +2273,11 @@ networkstatus_add_detached_signatures(networkstatus_t *target, if (!sig->good_signature && !sig->bad_signature) { cert = authority_cert_get_by_digests(sig->identity_digest, sig->signing_key_digest); - if (cert) - networkstatus_check_document_signature(target, sig, cert); + if (cert) { + /* Not checking the return value here, since we are going to look + * at the status of sig->good_signature in a moment. */ + (void) networkstatus_check_document_signature(target, sig, cert); + } }

/* If this signature is good, or we don't have any signature yet,